Update the testpmd user guide with instructions for retrieving extended
NIC statistics.
Signed-off-by: Maryam Tahhan
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
Add a check to see if the primary process is running and exit gracefully if it
is not.
v2:
* Updated to tone down message and remove unnecessary brackets.
Suggested-by: Patrick Kutch
Signed-off-by: Maryam Tahhan
---
app/proc_info/main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
emove driver specific stats")
Signed-off-by: Maryam Tahhan
---
v2:
- Clarify why imissed is no longer deprecated.
- Improve definition of imissed in the documentation.
---
doc/guides/rel_notes/deprecation.rst | 2 +-
lib/librte_ether/rte_ethdev.h| 4 +++-
2 files changed, 4 insert
ets. Where the #
of errors can be >= the packets received (without overlap between
registers), this is because there may be multiple errors associated with
a packet.
v2:
- Added detailed descriptions for ierrors and ipkterrors.
Signed-off-by: Maryam Tahhan
---
lib/librte_ether/rte_ethdev.
ets. Where the #
of errors can be >= the packets received (without overlap between
registers), this is because there may be multiple errors associated with
a packet.
Signed-off-by: Maryam Tahhan
---
lib/librte_ether/rte_ethdev.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Remove the deprecation tag and notice for imissed.
Signed-off-by: Maryam Tahhan
---
doc/guides/rel_notes/deprecation.rst | 2 +-
lib/librte_ether/rte_ethdev.h| 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides
intain a persistent value per port oerrors has now been
set to 0. References to txdgpc is now removed as we don't use it. This
patch also removes rxnfgpc as it's not used anywhere.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 17 +++--
1 file changed, 3 insertions(
ding packets to the interface without
forwarding enabled - packets should be dropped and the error counters
incremented.
v2:
- specified the commit that this bug fix fixes.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
ed - packets should
be dropped and the error counters incremented.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 3a8cff0..09
Add a guide for the proc_info application.
Signed-off-by: Maryam Tahhan
---
doc/guides/sample_app_ug/index.rst | 1 +
doc/guides/sample_app_ug/proc_info.rst | 71 ++
2 files changed, 72 insertions(+)
create mode 100644 doc/guides/sample_app_ug/proc_info.rst
proc_info displays statistics information including extended stats for
given DPDK ports and dumps the memory information for DPDK.
Signed-off-by: Maryam Tahhan
---
MAINTAINERS| 4 +
app/Makefile | 1 +
app/proc_info/Makefile | 45 +++
app/proc_info/main.c | 354
Remove the dump_cfg application, this will be replaced by a new app
called proc_info that will implement the same functionality as dump_cfg
and extend it to retrieve statistics for DPDK ports.
Signed-off-by: Maryam Tahhan
---
app/Makefile | 1 -
app/dump_cfg/Makefile | 45
ierrors only included a base set of error statistics, this patch adds
additional error registers to ierrors.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b
Add the NIC/HW specific stats that were removed from rte_ethdev.c to
the extended stats in ixgbe.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/drivers/net/ixgbe
Remove non generic stats in rte_stats_strings and mark the relevant
fields in struct rte_eth_stats as deprecated.
Signed-off-by: Maryam Tahhan
---
doc/guides/rel_notes/abi.rst | 12
lib/librte_ether/rte_ethdev.c | 9 -
lib/librte_ether/rte_ethdev.h | 30
Extend rte_eth_xstats_get to retrieve additional stats from the device
driver as well the ethdev generic stats.
Signed-off-by: Maryam Tahhan
---
lib/librte_ether/rte_ethdev.c | 31 ---
1 file changed, 20 insertions(+), 11 deletions(-)
mode change 100644 => 100
Implement ixgbe_dev_xstats_reset and ixgbe_dev_xstats_get.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 87
1 file changed, 87 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index
Move stats register reads to ixgbe_read_stats_registers() as it will be
used by the functions to retrieve stats and extended stats.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 64 +++-
1 file changed, 44 insertions(+), 20 deletions
proc_info copyright year.
- Display queue stats for all devices in proc_info.
v6:
- Modified the driver implementation of ixgbe_dev_xstats_get() so that
it doesn't worry about the generic stats written by the generic layer.
Maryam Tahhan (9):
ixgbe: move stats register reads to a new function
Add a guide for the proc_info application.
Signed-off-by: Maryam Tahhan
---
doc/guides/sample_app_ug/index.rst | 1 +
doc/guides/sample_app_ug/proc_info.rst | 71 ++
2 files changed, 72 insertions(+)
create mode 100644 doc/guides/sample_app_ug/proc_info.rst
proc_info displays statistics information including extended stats for
given DPDK ports and dumps the memory information for DPDK.
Signed-off-by: Maryam Tahhan
---
MAINTAINERS| 4 +
app/Makefile | 1 +
app/proc_info/Makefile | 45 +++
app/proc_info/main.c | 354
Remove the dump_cfg application, this will be replaced by a new app
called proc_info that will implement the same functionality as dump_cfg
and extend it to retrieve statistics for DPDK ports.
Signed-off-by: Maryam Tahhan
---
app/Makefile | 1 -
app/dump_cfg/Makefile | 45
ierrors only included a base set of error statistics, this patch adds
additional error registers to ierrors.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b
Add the NIC/HW specific stats that were removed from rte_ethdev.c to
the extended stats in ixgbe.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/drivers/net/ixgbe
Extend rte_eth_xstats_get to retrieve additional stats from the device
driver as well the ethdev generic stats.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 7 ---
lib/librte_ether/rte_ethdev.c| 25 -
2 files changed, 20 insertions(+), 12
Implement ixgbe_dev_xstats_reset and ixgbe_dev_xstats_get.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 87
1 file changed, 87 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index
Move stats register reads to ixgbe_read_stats_registers() as it will be
used by the functions to retrieve stats and extended stats.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 64 +++-
1 file changed, 44 insertions(+), 20 deletions
proc_info displays statistics information including extened stats for
given DPDK ports and dumps the memory information for DPDK.
Signed-off-by: Maryam Tahhan
---
MAINTAINERS| 4 +
app/Makefile | 1 +
app/proc_info/Makefile | 45 +
app/proc_info/main.c | 512
Remove the dump_cfg application, this will be replaced by a new app
called proc_info that will implement the same functionality as dump_cfg
and extend it to retrieve statistics for DPDK ports.
Signed-off-by: Maryam Tahhan
---
app/Makefile | 1 -
app/dump_cfg/Makefile | 45
ierrors only included a base set of error statistics, this patch adds
additional error registers to ierrors.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b
Add the NIC/HW specific stats that were removed from rte_ethdev.c to
the extended stats in ixgbe.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/drivers/net/ixgbe
Remove non generic stats in rte_stats_strings and mark the relevant
fields in struct rte_eth_stats as deprecated.
Signed-off-by: Maryam Tahhan
---
doc/guides/rel_notes/abi.rst | 11 +++
lib/librte_ether/rte_ethdev.c | 9 -
lib/librte_ether/rte_ethdev.h | 30
Extend rte_eth_xstats_get to retrieve additional stats from the device
driver as well the ethdev generic stats.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 7 ---
lib/librte_ether/rte_ethdev.c| 25 -
2 files changed, 20 insertions(+), 12
Implement ixgbe_dev_xstats_reset and ixgbe_dev_xstats_get.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 87
1 file changed, 87 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index
Move stats register reads to ixgbe_read_stats_registers() as it will be
used by the functions to retrieve stats and extended stats.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 64 +++-
1 file changed, 44 insertions(+), 20 deletions
d NIC specific stats removed from ethdev" into two
patches, one
that adds the stats and another that extends ierrors to include more error
stats.
- Remove second call to ixgbe_dev_xstats_get() from rte_eth_xstats_get().
Maryam Tahhan (8):
ixgbe: move stats register reads to a ne
proc_info displays statistics information including extened stats for
given DPDK ports and dumps the memory information for DPDK.
Signed-off-by: Maryam Tahhan
---
MAINTAINERS| 4 +
app/Makefile | 1 +
app/proc_info/Makefile | 45 +
app/proc_info/main.c | 512
Remove the dump_cfg application, this will be replaced by a new app
called proc_info that will implement the same functionality as dump_cfg
and extend it to retrieve statistics for DPDK ports.
Signed-off-by: Maryam Tahhan
---
app/Makefile | 1 -
app/dump_cfg/Makefile | 45
Add the NIC/HW specific stats that were removed from rte_ethdev.c to
the extended stats in ixgbe.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 43 ++--
1 file changed, 24 insertions(+), 19 deletions(-)
diff --git a/drivers/net/ixgbe
Remove non generic stats in rte_stats_strings and mark the relevant
fields in struct rte_eth_stats as deprecated.
Signed-off-by: Maryam Tahhan
---
doc/guides/rel_notes/abi.rst | 11 +++
lib/librte_ether/rte_ethdev.c | 9 -
lib/librte_ether/rte_ethdev.h | 30
Extend rte_eth_xstats_get to retrieve additional stats from the device
driver as well the ethdev generic stats.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
lib/librte_ether/rte_ethdev.c| 20 ++--
2 files changed, 15 insertions(+), 7 deletions
Implement ixgbe_dev_xstats_reset and ixgbe_dev_xstats_get.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 85
1 file changed, 85 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index
Move stats register reads to ixgbe_read_stats_registers() as it will be
used by the functions to retrieve stats and extended stats.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 64 +++-
1 file changed, 44 insertions(+), 20 deletions
stats fields in rte_stats_strings and deprecates
the fields related to them in struct rte_eth_stats.
- Modifies rte_eth_xstats_get() to return generic stats and extended stats.
Maryam Tahhan (7):
ixgbe: move stats register reads to a new function
ixgbe: add functions to get and reset xstats
proc_info displays statistics information including extened stats for
given DPDK ports and dumps the memory information for DPDK.
Signed-off-by: Maryam Tahhan
---
MAINTAINERS| 4 +
app/Makefile | 1 +
app/proc_info/Makefile | 45 +
app/proc_info/main.c | 514
Remove the dump_cfg application, this will be replaced by a new app
called proc_info that will implement the same functionality as dump_cfg
and extend it to retrieve statistics for DPDK ports.
Signed-off-by: Maryam Tahhan
---
app/Makefile | 1 -
app/dump_cfg/Makefile | 45
Extend testpmd to show additional aggregate extended stats.
Signed-off-by: Maryam Tahhan
---
app/test-pmd/config.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index f788ed5..b42d83f 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd
Extend rte_eth_xstats_get to retrieve additional stats from the device
driver as well the top level extended stats.
Signed-off-by: Maryam Tahhan
---
lib/librte_ether/rte_ethdev.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib
Implement xstats_get() and xstats_reset() in dev_ops for ixgbe to
expose detailed error statistics to DPDK applications.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 85
1 file changed, 85 insertions(+)
diff --git a/drivers/net
Add MAC error and drop statistics to struct rte_eth_stats and the
extended stats.
Signed-off-by: Maryam Tahhan
---
lib/librte_ether/rte_ethdev.c | 4
lib/librte_ether/rte_ethdev.h | 4
2 files changed, 8 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether
functionality. test_pmd was also extended
to display additional statistics.
Maryam Tahhan (7):
ethdev: add additional error stats
ixgbe: move stats register reads to a new function
ixgbe: Expose extended error statistics
ethdev: expose extended error stats
testpmd: extend testpmd to show all
Extend dump_cfg to also display statistcs information for given DPDK
ports and rename the application to proc_info as it's now a utility
doing a little more than just dumping the memory information for DPDK.
Signed-off-by: Maryam Tahhan
---
app/Makefile | 2 +-
app/dump_cfg/Makefile
Extend testpmd to show additional aggregate extended stats.
Signed-off-by: Maryam Tahhan
---
app/test-pmd/config.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index f788ed5..b42d83f 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd
Extend rte_eth_xstats_get to retrieve additional stats from the device
driver as well the top level extended stats. Add additional drop
counters to the extended stats.
Signed-off-by: Maryam Tahhan
---
lib/librte_ether/rte_ethdev.c | 12
lib/librte_ether/rte_ethdev.h | 4
2
Implement xstats_get() and xstats_reset() in dev_ops for ixgbe to expose
detailed error statistics to DPDK applications.
Signed-off-by: Maryam Tahhan
---
drivers/net/ixgbe/ixgbe_ethdev.c | 160 +--
1 file changed, 138 insertions(+), 22 deletions(-)
diff
functionality.
The testpmd app was also extended to display additional statistics.
Maryam Tahhan (4):
ixgbe: expose extended error statistics
ethdev: expose extended error stats
testpmd: extend testpmd to show all extended stats
app: replace dump_cfg with proc_info
app/Makefile
56 matches
Mail list logo
