Re: [PATCH] net/virtio: Fix check of threshold for Tx freeing

2025-06-13 Thread Maxime Coquelin
On 6/9/25 9:23 AM, Hengqi Chen wrote: Like most dirvers, make the fast path of virtio_xmit_cleanup() behave as described by the comments of rte_eth_txconf::tx_free_thresh ([0]): Start freeing Tx buffers if there are less free descriptors than this value. The rationale behind this ch

Re: [PATCH] vhost: fix net control virtqueue used length

2025-06-13 Thread Maxime Coquelin
On 6/5/25 1:35 PM, Eugenio Pérez wrote: By the standard this is the number of bytes written. Fixes: 474f4d7840ad ("vhost: add control virtqueue") Cc: sta...@dpdk.org Signed-off-by: Eugenio Pérez --- lib/vhost/virtio_net_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [PATCH 2/2] vhost: search the packed vq driver area in RO areas

2025-06-13 Thread Maxime Coquelin
On 6/5/25 1:35 PM, Eugenio Pérez wrote: QEMU's shadow virtqueue and VDUSE exposes this as read-only. If we don't change it, vhost_iova_to_vva do not consider them as valid and returns that they're not found. Fixes: 2d1541e2b6b3 ("vhost: add vring address setup for packed queues") Cc: sta...@d

Re: [PATCH 0/2] Search the split vq desc and avail in RO areas

2025-06-13 Thread Maxime Coquelin
On 6/5/25 1:35 PM, Eugenio Pérez wrote: QEMU's shadow virtqueue and VDUSE exposes these areas as read-only. If we don't change it, vhost_iova_to_vva do not consider them as valid and returns that they're not found. Eugenio Pérez (2): vhost: search the split vq desc and avail in RO areas

Re: [PATCH] vhost: fix net control virtqueue used length

2025-06-12 Thread Maxime Coquelin
&cvq->used->ring[cvq->last_used_idx & (cvq->size - 1)]; used_elem->id = ctrl_elem->head_idx; - used_elem->len = ctrl_elem->n_descs; + used_elem->len = sizeof(*ctrl_elem->desc_ack); cvq->last_used_idx++; Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH 1/2] vhost: search the split vq desc and avail in RO areas

2025-06-12 Thread Maxime Coquelin
be squashed into this one. Eugenio, is that Ok for you? With above suggested changes: Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH] net/virtio: Fix check of threshold for Tx freeing

2025-06-12 Thread Maxime Coquelin
f (likely(vq->vq_free_cnt < vq->vq_free_thresh)) virtio_xmit_cleanup(vq, nb_used); for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) { Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH v4 1/1] vhost: handle virtqueue locking for memory hotplug

2025-06-12 Thread Maxime Coquelin
this. No, my point was to modify VHOST_USER_ASSERT_LOCK() to no trigger an assertion in case vDPA is configured, as we don't want to lock in this case. Regards, Maxime ---- *От:* Maxime Coquelin *Отправлено:* 3 июня 2025

Re: [PATCH] uapi: update to 6.15 for vduse.h

2025-06-10 Thread Maxime Coquelin
Hi Stephen, On 6/9/25 3:41 AM, Stephen Hemminger wrote: Use the header as produced by the kernel: $ make headers_install We use the header as produced by our import script (devtools/linux- uapi.sh) as defined in the contribution guidelines and approved by the tech and gov boards. I'm fine w

Re: [PATCH 0/2] Search the split vq desc and avail in RO areas

2025-06-06 Thread Maxime Coquelin
On 6/6/25 4:20 PM, David Marchand wrote: On Thu, Jun 5, 2025 at 4:55 PM Eugenio Perez Martin wrote: On Thu, Jun 5, 2025 at 1:50 PM David Marchand wrote: On Thu, Jun 5, 2025 at 1:36 PM Eugenio Pérez wrote: QEMU's shadow virtqueue and VDUSE exposes these areas as read-only. If we don't

Re: [PATCH v4 1/1] vhost: handle virtqueue locking for memory hotplug

2025-06-03 Thread Maxime Coquelin
Hello Danylo, On 6/2/25 10:50 AM, Danylo Vodopianov wrote: For vDPA devices, virtqueues are not locked once the device has been configured. In the commit 5e8fcc60b59d ("vhost: enhance virtqueue access lock asserts"), the asserts were enhanced to trigger rte_panic functionality, preventing access

[PATCH] net/mlx5: avoid setting kernel MTU if not needed

2025-05-28 Thread Maxime Coquelin
") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- Hi Dariuz, I set priv->mtu as it is done after the mlx5_set_mtu() call, but I'm not sure it is necessary, as is the existing call to mlx5_get_mtu() because it seems done in mlx5_dev_spawn(). --- drivers/net/mlx5/mlx5_ethdev

[PATCH v1] net/virtio-user: implement MAC setting for Vhost-kernel

2025-05-21 Thread Maxime Coquelin
This patch implements MAC address setting with Vhost-kernel backends. With this, it is possible to set the TAP interface MAC address using the Ethdev API. Signed-off-by: Maxime Coquelin --- Change from RFC: Rebased on latest main --- drivers/net/virtio/virtio_user/vhost_kernel.c | 23

Re: [PATCH v1 0/1] bbdev: fix possible null pointer dereferencing

2025-05-16 Thread Maxime Coquelin
On 5/2/25 12:10 AM, Nicolas Chautru wrote: Hi Maxime, Minor fix for warning reported by coverity. Thanks Nic Nicolas Chautru (1): bbdev: fix possible null pointer dereference lib/bbdev/rte_bbdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) Applied to next-baseban

Re: [PATCH] vhost: fix wrapping on control virtqueue rings

2025-05-16 Thread Maxime Coquelin
On 4/2/25 8:53 AM, David Marchand wrote: The idx field of a virtqueue available ring is increased by the driver regardless of the ring size. It is for the device to mask this index modulo the ring size (2.7.6 of the virtio 1.3 specification). The same applies to the used ring. Failing to mask

Re: [PATCH 2/2] crypto/virtio: fix cipher data src length

2025-05-16 Thread Maxime Coquelin
On 4/3/25 2:26 PM, Rajesh Mudimadugula wrote: In symmetric algorithm chaining, we need to consider both cipher and auth data length for cipher source. Fixes: 82adb12a1fce ("crypto/virtio: support burst enqueue/dequeue") Signed-off-by: Rajesh Mudimadugula --- drivers/crypto/virtio/virtio_r

Re: [PATCH 1/2] vhost: fix cipher data length

2025-05-16 Thread Maxime Coquelin
On 4/3/25 2:22 PM, Rajesh Mudimadugula wrote: This patch fixes cipher data length, in the event of algorithm chaining. When enqueuing crypto op to vhost backend cipher.data.length is set correctly which is in virtqueue_crypto_sym_pkt_header_arrange(). This field is computed and assigned wrongl

Re: [PATCH] vhost/crypto: fix uninitialized variable

2025-05-16 Thread Maxime Coquelin
On 5/15/25 10:10 AM, Gowrishankar Muthukrishnan wrote: Fix uninitialized variable as reported in coverity scan. Coverity-issue: 457449 Fixes: d1b484bf187 ("vhost/crypto: support asymmetric RSA") Signed-off-by: Gowrishankar Muthukrishnan --- lib/vhost/vhost_crypto.c | 2 +- 1 file changed

Re: [PATCH] net/virtio: support Rx/Tx burst mode info

2025-05-16 Thread Maxime Coquelin
On 5/12/25 1:58 PM, Maxime Coquelin wrote: Hi Roger, On 4/16/25 7:35 PM, Roger Melton wrote: Return burst mode according to the selected Rx/Tx burst function name. Update 25.07 release notes with this information. Signed-off-by: Roger Melton ---   doc/guides/rel_notes/release_25_07.rst

Re: [PATCH] vhost/crypto: fix uninitialized variable

2025-05-16 Thread Maxime Coquelin
desc *desc = descs; uint32_t nb_descs = 0, max_n_descs, i; - struct vhost_crypto_data_req data_req; struct virtio_crypto_op_data_req req; struct virtio_crypto_inhdr *inhdr; struct vring_desc *src_desc; Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH] net/virtio: support Rx/Tx burst mode info

2025-05-12 Thread Maxime Coquelin
| 76 ++ 2 files changed, 79 insertions(+) Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH v1 1/1] bbdev: fix possible null pointer dereference

2025-05-12 Thread Maxime Coquelin
dev_id); Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: Virtio-PMD speed limits to 100Gbps, while hardware supports 200Gbps

2025-04-29 Thread Maxime Coquelin
Hi, On 4/28/25 4:14 PM, Ayshathul Thuhara wrote: Hi Team,  I am using virtio-net, virtio-pci  drivers for a Bittware hardware. I could see the data is sent and received with the throughput of 100Gbps. But the hardware supports for 200Gbps. I am not able to get the throughput more than 200Gbp

Re: [PATCH 4/4] ci: check licenses

2025-04-16 Thread Maxime Coquelin
On 4/16/25 2:34 PM, Maxime Coquelin wrote: From: David Marchand Call check-spdx.tag.sh so that all committed files are checked. Signed-off-by: David Marchand Acked-by: Aaron Conole --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows

[PATCH 4/4] ci: check licenses

2025-04-16 Thread Maxime Coquelin
From: David Marchand Call check-spdx.tag.sh so that all committed files are checked. Signed-off-by: David Marchand Acked-by: Aaron Conole --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7a6b679

[PATCH 3/4] vhost: use imported VDUSE uAPI header

2025-04-16 Thread Maxime Coquelin
This patch makes use of the imported VDUSE uAPI header, and remove VDUSE build dependency on the presence of the VDUSE header on the system. Signed-off-by: Maxime Coquelin --- lib/vhost/meson.build | 5 + lib/vhost/vduse.c | 2 +- lib/vhost/vduse.h | 22 -- 3

[PATCH 2/4] uapi: import VDUSE header from v6.14 kernel

2025-04-16 Thread Maxime Coquelin
This header will be used by the Vhost library. Signed-off-by: Maxime Coquelin --- kernel/linux/uapi/linux/vduse.h | 353 kernel/linux/uapi/version | 2 +- 2 files changed, 354 insertions(+), 1 deletion(-) create mode 100644 kernel/linux/uapi/linux

[PATCH 1/4] license: add exception for Linux Kernel uAPI headers

2025-04-16 Thread Maxime Coquelin
/contributing/linux_uapi.rst Signed-off-by: Maxime Coquelin --- devtools/check-spdx-tag.sh | 2 +- license/Linux-syscall-note | 25 + license/exceptions.txt | 17 + 3 files changed, 35 insertions(+), 9 deletions(-) create mode 100644 license/Linux

[PATCH 0/4] Linux Kernel uAPI headers import

2025-04-16 Thread Maxime Coquelin
This series documents the license exception granted by both the technical and governing boards to import uAPI header files. It also imports VDUSE uAPI header file from Kernel v6.14. David Marchand (1): ci: check licenses Maxime Coquelin (3): license: add exception for Linux Kernel uAPI

Re: [PATCH] vhost: fix wrapping on control virtqueue rings

2025-04-08 Thread Maxime Coquelin
trl.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) Thanks for the fix! Reviewed-by: Maxime Coquelin Tested-by: Maxime Coquelin Maxime

Tech Board Meeting Minutes - 2025-Jan-22

2025-04-02 Thread Maxime Coquelin
Members Attending -- Aaron Conole Bruce Richardson Hemant Agrawal Jerin Jacob Kevin Traynor Maxime Coquelin (chair) Stephen Hemminger Thomas Monjalon Honnappa Nagarahalli NOTE: The technical board meetings are on every second Wednesday at 3pm UTC. Meetings are public, and DPDK

Re: [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up

2025-03-12 Thread Maxime Coquelin
On 3/12/25 2:48 PM, Maxime Coquelin wrote: On 3/5/25 7:27 PM, Nicolas Chautru wrote: Incomplete clean up for vrb2 variant when queue setup fails to complete successfully. Fixes: fc65d3dcabe01 ("baseband/acc: refactor queue allocation") Cc: sta...@dpdk.org Signed-off-by: Nicol

Re: [PATCH] bbdev: enable to be compiled with MSVC

2025-03-12 Thread Maxime Coquelin
On 3/12/25 3:56 PM, Maxime Coquelin wrote: On 3/11/25 8:17 PM, Andre Muezerie wrote: The errors below popped up when compiling with MSVC: ../lib/bbdev/rte_bbdev.c(79): error C2061: syntax error: identifier 'TAILQ_ENTRY' ../lib/bbdev/rte_bbdev.c(85): error C2059: sy

Re: [PATCH] bbdev: enable to be compiled with MSVC

2025-03-12 Thread Maxime Coquelin
cluded with other general includes, not with RTE ones. I can fix it while applying. With this fixed: Reviewed-by: Maxime Coquelin Thanks, Maxime #include "rte_bbdev_op.h" #include "rte_bbdev.h"

Re: [PATCH] doc: update virtio prog guide with new feature list

2025-03-12 Thread Maxime Coquelin
On 3/4/25 6:42 PM, Kommula Shiva Shankar wrote: This patch adds newly added virtio hash report feature to prog guide. Signed-off-by: Kommula Shiva Shankar --- doc/guides/nics/virtio.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/vir

Re: [PATCH v1 1/1] baseband/acc: fix queue setup failure clean up

2025-03-12 Thread Maxime Coquelin
bbdev *dev, uint16_t queue_id, free_q: rte_free(q); q = NULL; + if (d->device_variant == VRB2_VARIANT) + d->queue_index[conf->op_type]--; return ret; } Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH] doc: update virtio prog guide with new feature list

2025-03-12 Thread Maxime Coquelin
ipping and inserting. +* Virtio supports hash report feature in packed queue mode. + * Virtio supports using port IO to get PCI resource when UIO module is not available. * Virtio supports RSS Rx mode with 40B configurable hash key length, 128 Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH] vhost/crypto: fix build with asserts

2025-03-05 Thread Maxime Coquelin
qt.qInv.length = qinvlen; - RTE_ASSERT((tlv + len - &der[0]) == der_len); + RTE_ASSERT(tlv + len == der + der_len); return 0; } Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH] vhost/crypto: fix locking

2025-03-05 Thread Maxime Coquelin
-- lib/vhost/vhost_crypto.c | 95 +++- 1 file changed, 46 insertions(+), 49 deletions(-) Thanks for fixing this! With the typo fixed: Reviewed-by: Maxime Coquelin Maxime

Re: [PATCH v2 0/3] bbdev: trace point and logging

2025-03-04 Thread Maxime Coquelin
On 1/23/25 11:55 PM, Nicolas Chautru wrote: v2: fix build error. Hi, Based on previous discussion improving logging for bbdev and PMD using notably trace points and internal logging extension. The trace point impacting real time are not built by default. This is added at bbdev level and also

Re: [PATCH v1 0/2] bbdev: doc and vector clean up

2025-03-04 Thread Maxime Coquelin
On 2/28/25 5:50 PM, Nicolas Chautru wrote: Minor changes to clean up the documentation for bbdev programming guide and updating vectors to avoid false alarms when using different windowing configuration assumption by users. Nicolas Chautru (2): doc: update bbdev documentation test/bbdev

Re: [PATCH v1 2/2] test/bbdev: update to fft test vectors

2025-03-04 Thread Maxime Coquelin
| 870 app/test-bbdev/test_vectors/fft_byp_28.data | 48 +- 2 files changed, 24 insertions(+), 894 deletions(-) delete mode 100644 app/test-bbdev/test_vectors/fft_9.data I did not spot any error :D Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH v1 1/2] doc: update bbdev documentation

2025-03-04 Thread Maxime Coquelin
processing (channel coding, modulation, ...). -The framework currently only supports FEC function. +The framework currently supports FEC functions (5G/4G Encoder/Decoder), as well as FFT and MLD-TS. Design Principles Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH v2 2/3] baseband/acc: add trace point

2025-03-04 Thread Maxime Coquelin
++ drivers/baseband/acc/rte_vrb_pmd.c | 63 +- drivers/baseband/acc/vrb_trace.h | 35 + 4 files changed, 133 insertions(+), 28 deletions(-) create mode 100644 drivers/baseband/acc/vrb_trace.h Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH v2 3/3] baseband/acc: add internal logging

2025-03-04 Thread Maxime Coquelin
, that sounds good to me. Thanks, Maxime Thanks Nic -Original Message- From: Maxime Coquelin Sent: Friday, February 28, 2025 12:52 AM To: Stephen Hemminger ; Chautru, Nicolas Cc: dev@dpdk.org; hemant.agra...@nxp.com; Vargas, Hernan Subject: Re: [PATCH v2 3/3] baseband/acc: add internal

Re: [v9 0/6] vhost: add RSA support

2025-03-04 Thread Maxime Coquelin
On 2/28/25 2:47 PM, Gowrishankar Muthukrishnan wrote: This patch series supports asymmetric RSA in vhost crypto library. It also includes changes to improve vhost crypto library: * support newer QEMU versions. * fix broken vhost_crypto example application. * stabilize crypto fastpath ope

Re: [PATCH 1/1] vhost: fix missing descriptor chains length checks

2025-03-04 Thread Maxime Coquelin
On 12/23/24 4:29 AM, Yunjian Wang wrote: The descriptor chains length must be greater than the Virtio-net header size. Otherwise, such descriptor chains sizes implies no packet data. Fixes: fe8477ebbd94 ("vhost: support async packed ring dequeue") Cc: sta...@dpdk.org Signed-off-by: Yunjian W

Re: [EXTERNAL] Re: [PATCH v2] net/virtio: add virtio hash report feature

2025-03-04 Thread Maxime Coquelin
On 2/27/25 10:44 AM, Shiva Shankar Kommula wrote: -Original Message- From: Maxime Coquelin Sent: Tuesday, February 25, 2025 9:39 PM To: Shiva Shankar Kommula ; dev@dpdk.org; chen...@nvidia.com Cc: david.march...@redhat.com; Jerin Jacob ; Nithin Kumar Dabilpuram ; Srujana Challa

Re: [PATCH 1/1] vhost: fix missing descriptor chains length checks

2025-03-04 Thread Maxime Coquelin
VHOST_DATA_LOG(dev->ifname, ERR, "Failed mbuf alloc of size %d from %s.", Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [EXTERNAL] Re: [PATCH v2] net/virtio: add virtio hash report feature

2025-03-04 Thread Maxime Coquelin
On 3/3/25 11:25 AM, Maxime Coquelin wrote: On 2/27/25 10:44 AM, Shiva Shankar Kommula wrote: -Original Message- From: Maxime Coquelin Sent: Tuesday, February 25, 2025 9:39 PM To: Shiva Shankar Kommula ; dev@dpdk.org; chen...@nvidia.com Cc: david.march...@redhat.com; Jerin Jacob

Re: [EXTERNAL] Re: [PATCH v2] net/virtio: add virtio hash report feature

2025-03-03 Thread Maxime Coquelin
On 2/27/25 10:44 AM, Shiva Shankar Kommula wrote: -Original Message- From: Maxime Coquelin Sent: Tuesday, February 25, 2025 9:39 PM To: Shiva Shankar Kommula ; dev@dpdk.org; chen...@nvidia.com Cc: david.march...@redhat.com; Jerin Jacob ; Nithin Kumar Dabilpuram ; Srujana Challa

Re: [v9 6/6] examples/vhost_crypto: support asymmetric crypto

2025-03-03 Thread Maxime Coquelin
files changed, 43 insertions(+), 12 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [v9 5/6] vhost: support asymmetric RSA crypto ops

2025-03-03 Thread Maxime Coquelin
+++-- lib/vhost/virtio_crypto.h | 67 3 files changed, 521 insertions(+), 33 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [v9 4/6] examples/vhost_crypto: fix user callbacks

2025-03-03 Thread Maxime Coquelin
nan Acked-by: Akhil Goyal --- examples/vhost_crypto/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [v9 3/6] vhost: update vhost_user crypto session parameters

2025-03-03 Thread Maxime Coquelin
| 33 + 2 files changed, 35 insertions(+), 10 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [v9 2/6] vhost: skip crypto op fetch before vring init

2025-03-03 Thread Maxime Coquelin
;) Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- lib/vhost/vhost_crypto.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [v9 1/6] vhost: fix thread safety checks for vhost crypto data req

2025-03-03 Thread Maxime Coquelin
76 ++-- 1 file changed, 41 insertions(+), 35 deletions(-) Reviewed-by: Maxime Coquelin Thanks for doing these changes, Maxime

Re: [EXTERNAL] Re: [v6 1/5] vhost: skip crypto op fetch before vring init

2025-02-28 Thread Maxime Coquelin
Hi Gowri, On 2/28/25 2:59 PM, Gowrishankar Muthukrishnan wrote: Hi Maxime, Before your series arrived, we were wondering if we should not deprecate Vhost crypto as it was not really maintained and we had no identified user. Since it seems you are going to use it, which is great, would you co

Re: [PATCH v2 3/3] baseband/acc: add internal logging

2025-02-28 Thread Maxime Coquelin
Hi Nicolas, On 2/7/25 10:52 AM, Maxime Coquelin wrote: Hi Nicolas, On 1/24/25 7:00 PM, Stephen Hemminger wrote: On Fri, 24 Jan 2025 17:52:43 + "Chautru, Nicolas" wrote: Hi Stephen, The commit message may be misleading, the logging interface doesn't change here. Note al

Re: [EXTERNAL] Re: [v6 1/5] vhost: skip crypto op fetch before vring init

2025-02-28 Thread Maxime Coquelin
Hi Gowri, On 2/28/25 9:48 AM, David Marchand wrote: On Thu, Feb 27, 2025 at 7:07 PM Gowrishankar Muthukrishnan wrote: Ha, and also you should be able to remove: __rte_no_thread_safety_analysis /* FIXME: requires iotlb_lock? */ in vhost_crypto_process_one_req() once implemented. Removing it

Re: [v6 1/5] vhost: skip crypto op fetch before vring init

2025-02-27 Thread Maxime Coquelin
On 2/27/25 10:15 AM, Maxime Coquelin wrote: Hi Gowri, Thanks for the change, but I think there is an issue with the locking, more below: On 2/26/25 7:43 PM, Gowrishankar Muthukrishnan wrote: Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR), worker thread should not try

Re: [v6 1/5] vhost: skip crypto op fetch before vring init

2025-02-27 Thread Maxime Coquelin
Hi Gowri, Thanks for the change, but I think there is an issue with the locking, more below: On 2/26/25 7:43 PM, Gowrishankar Muthukrishnan wrote: Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR), worker thread should not try to fetch crypto op, which would lead to memory f

Re: [v5 1/5] vhost: skip crypto op fetch before vring init

2025-02-25 Thread Maxime Coquelin
On 2/24/25 11:35 AM, Gowrishankar Muthukrishnan wrote: Until virtio avail ring is initialized (by VHOST_USER_SET_VRING_ADDR), worker thread should not try to fetch crypto op, which would lead to memory fault. Fixes: 939066d96563 ("vhost/crypto: add public function implementation") Cc: sta...@

Re: [PATCH v2] net/virtio: add virtio hash report feature

2025-02-25 Thread Maxime Coquelin
Hi, On 1/27/25 8:41 AM, Kommula Shiva Shankar wrote: This patch adds virtio hash report feature, which is supported in packet queue mode with scalar version Why only restrict to packed ring? isn't it also compatible with split ring? Signed-off-by: Kommula Shiva Shankar --- drivers/net/vi

Re: [RFC v2 08/10] net/virtio: remove weak symbols

2025-02-18 Thread Maxime Coquelin
/virtio_rxtx_simple.c | 4 +++- 3 files changed, 12 insertions(+), 3 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH 1/1] vhost: add NULL callback checks

2025-02-07 Thread Maxime Coquelin
On 1/24/25 3:14 PM, Kevin Traynor wrote: rte_vhost_driver_callback_register() does not specify any mandatory callbacks in struct rte_vhost_device_ops. Add some missing NULL checks before calling rte_vhost_device_ops callbacks. Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost appl

Re: [PATCH] vhost: fix FD entries cleanup

2025-02-07 Thread Maxime Coquelin
On 2/6/25 9:41 AM, Maxime Coquelin wrote: With the recent rework of the FD manager to use epoll, an error message is emitted with Vhost-user at FD entry removal: ERR|VHOST_FDMAN: could not remove 102 fd from 101 epfd: No such file or directory It occurs because the read callback closes the

Re: [PATCH] vhost: fix VDUSE devices registration

2025-02-07 Thread Maxime Coquelin
On 1/31/25 2:09 PM, Maxime Coquelin wrote: This patch fixes a regression in vhost_driver_register() causing VDUSE devices registration to fail systematically because the return value was initialized to -1 and not changed later on for this type of devices. Fixes: 4d2aa150769b ("vhost: r

Re: [v3] vhost: include AKCIPHER algorithms in crypto_config

2025-02-07 Thread Maxime Coquelin
On 1/7/25 7:25 PM, Gowrishankar Muthukrishnan wrote: Update virtio_crypto_config structure to include AKCIPHER algorithms, as per VirtIO standard. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal --- v3: - rebased on main. lib/vhost/virtio_crypto.h | 2 +- 1 file change

Re: [PATCH] net/vhost: improve devargs documentation

2025-02-07 Thread Maxime Coquelin
On 12/20/24 3:58 PM, Maxime Coquelin wrote: This patch adds missing 'client' devarg documentation and improve other devargs. Bugzilla ID: 1603 Signed-off-by: Maxime Coquelin --- doc/guides/nics/vhost.rst | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff -

Re: [PATCH 1/1] vhost: add NULL callback checks

2025-02-07 Thread Maxime Coquelin
ew_device(dev->vid) == 0) + if (!dev->notify_ops->new_device || + dev->notify_ops->new_device(dev->vid) == 0) dev->flags |= VIRTIO_DEV_RUNNING; } Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH v2 3/3] baseband/acc: add internal logging

2025-02-07 Thread Maxime Coquelin
Hi Nicolas, On 1/24/25 7:00 PM, Stephen Hemminger wrote: On Fri, 24 Jan 2025 17:52:43 + "Chautru, Nicolas" wrote: Hi Stephen, The commit message may be misleading, the logging interface doesn't change here. Note also that I reuse existing trace point framework for some of the error log

Re: [PATCH v2 1/3] bbdev: add trace point

2025-02-07 Thread Maxime Coquelin
uint16_t nb_ops, uint16_t nb_ops_deq, const char *op_string), + rte_trace_point_emit_u8(dev_id); + rte_trace_point_emit_u16(qp_id); + rte_trace_point_emit_ptr(ops); + rte_trace_point_emit_u16(nb_ops); + rte_trace_point_emit_u16(nb_ops_deq); + rte_trace_point_emit_string(op_string); +) + +#ifdef __cplusplus +} +#endif + +#endif /* _RTE_BBDEV_TRACE_FP_H_ */ diff --git a/lib/bbdev/version.map b/lib/bbdev/version.map index 1e11485b17..b9b4f31e33 100644 --- a/lib/bbdev/version.map +++ b/lib/bbdev/version.map @@ -40,4 +40,8 @@ EXPERIMENTAL { # added in 24.11 rte_bbdev_queue_ops_dump; rte_bbdev_ops_param_string; + + # added in 25.03 + __rte_bbdev_trace_dequeue; + __rte_bbdev_trace_enqueue; }; Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [v2 3/4] crypto/virtio: add vhost backend to virtio_user

2025-02-06 Thread Maxime Coquelin
On 1/7/25 7:44 PM, Gowrishankar Muthukrishnan wrote: Add vhost backend to virtio_user crypto. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/virtio/meson.build | 7 + drivers/crypto/virtio/virtio_cryptodev.c | 57 +- drivers/crypto/virtio/virtio_cryptode

Re: [v2 1/4] common/virtio: move vDPA to common directory

2025-02-06 Thread Maxime Coquelin
Hi Gowrishankar, On 1/7/25 7:44 PM, Gowrishankar Muthukrishnan wrote: Move vhost-vdpa backend implementation into common folder. If we decided to have a common base for Virtio devices, which I think is a good idea to avoid needless duplication, we should do a deeper refactoring by sharing all

Re: [v3] vhost: include AKCIPHER algorithms in crypto_config

2025-02-06 Thread Maxime Coquelin
; /* Maximum length of authenticated key */ uint32_t max_auth_key_len; - uint32_t reserve; + uint32_t akcipher_algo; /* Maximum size of each crypto request's content */ uint64_t max_size; }; Reviewed-by: Maxime Coquelin Thanks, Maxime

[PATCH] vhost: fix FD entries cleanup

2025-02-06 Thread Maxime Coquelin
FD set. This patch defers the close() after the FD entry is removed from the set. Fixes: 0e38b42bf61c ("vhost: manage FD with epoll") Cc: sta...@dpdk.org Signed-off-by: David Marchand Signed-off-by: Maxime Coquelin --- lib/vhost/fd_man.c | 12 +++- lib/vhost/fd_man.h | 2 +-

Re: [PATCH] vhost: fix VDUSE devices registration

2025-02-05 Thread Maxime Coquelin
Hi Ariel, On 1/31/25 6:34 PM, Ariel Otilibili-Anieli wrote: Hello Maxime, On Friday, January 31, 2025 14:09 CET, Maxime Coquelin wrote: This patch fixes a regression in vhost_driver_register() causing VDUSE devices registration to fail systematically because the return value was

Re: [RFC 0/3] Vhost: fix FD entries cleanup

2025-02-05 Thread Maxime Coquelin
Hi Chenbo & David, On 2/5/25 8:27 AM, Chenbo Xia wrote: Hi David, On Feb 4, 2025, at 21:18, David Marchand wrote: External email: Use caution opening links or attachments Hello vhost maintainers, On Tue, Dec 24, 2024 at 4:50 PM Maxime Coquelin wrote: The vhost FD manager provid

[PATCH] vhost: fix VDUSE devices registration

2025-01-31 Thread Maxime Coquelin
This patch fixes a regression in vhost_driver_register() causing VDUSE devices registration to fail systematically because the return value was initialized to -1 and not changed later on for this type of devices. Fixes: 4d2aa150769b ("vhost: remove check around mutex init") Signed-off-

Re: [v2 2/2] examples/vhost_crypto: add asymmetric support

2025-01-29 Thread Maxime Coquelin
On 1/7/25 7:02 PM, Gowrishankar Muthukrishnan wrote: Add symmetric support. Signed-off-by: Gowrishankar Muthukrishnan --- examples/vhost_crypto/main.c | 54 ++-- 1 file changed, 40 insertions(+), 14 deletions(-) diff --git a/examples/vhost_crypto/main.

Re: [v2 1/2] vhost: add asymmetric RSA support

2025-01-29 Thread Maxime Coquelin
to.c | 504 --- lib/vhost/vhost_user.h | 33 ++- 2 files changed, 498 insertions(+), 39 deletions(-) I'm not a crypto expert, so a second pair of eyes would be welcome. I did not find any obvious bug while reviewing this patch: Acked-by: Maxime Coquelin

Re: [PATCH v3 0/3] vhost: fix and improve dequeue error path

2025-01-17 Thread Maxime Coquelin
On 1/16/25 10:54 AM, Maxime Coquelin wrote: This series starts with a fix for a regression in the Vhost dequeue error path. The other patches improve the error handling to reduce the chance of such regressions in the future. Changes in v3: == - Squashed patches 2 & 3 (D

Re: [PATCH] vhost: fix misleading log when setting max queue num

2025-01-17 Thread Maxime Coquelin
On 1/9/25 3:31 PM, Maxime Coquelin wrote: rte_vhost_driver_set_max_queue_num API returns early when called for a Vhost-user device, as this API is intended to limit the maximum number of queue pairs supported by VDUSE devices. However, a log mentioning the maximim number of queue pairs is

Re: [PATCH 1/1] vhost: fix missing gso_size validity check

2025-01-17 Thread Maxime Coquelin
On 12/20/24 4:45 AM, Yunjian Wang wrote: The value of tso_segsz cannot be 0, instead check that value of gso_size was set. Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/vhost/virtio_net.c | 3 +++ 1 file changed, 3 inse

Re: [PATCH v4] vhost/user: clear ring addresses when getting vring base

2025-01-17 Thread Maxime Coquelin
On 11/27/24 3:03 AM, Jianping Zhao wrote: Clear ring addresses during vring base retrieval to handle guest reboot scenarios correctly. This is particularly important for vdpa-blk devices where the following issue occurs: When a guest OS with vdpa-blk device reboots, during UEFI stage, only on

Re: [PATCH v2 4/4] vhost: improve RARP handling in dequeue paths

2025-01-16 Thread Maxime Coquelin
On 1/15/25 5:46 PM, David Marchand wrote: On Wed, Jan 15, 2025 at 1:59 PM Maxime Coquelin wrote: With previous refactoring, we can now simplify the RARP packet injection handling in both the sync and async dequeue paths. Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 42

[PATCH v3 3/3] vhost: improve RARP handling in dequeue paths

2025-01-16 Thread Maxime Coquelin
With previous refactoring, we can now simplify the RARP packet injection handling in both the sync and async dequeue paths. Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 72 ++ 1 file changed, 30 insertions(+), 42 deletions(-) diff --git a

[PATCH v3 1/3] vhost: fix missing packets count reset when not ready

2025-01-16 Thread Maxime Coquelin
") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c index 69901ab3b5..a340e5a772 100644 --- a/lib/vhost/virtio_net.c +++ b/lib/vhost/virtio_net.c @@ -3629

[PATCH v3 2/3] vhost: rework dequeue paths error handling

2025-01-16 Thread Maxime Coquelin
This patch refactors the error handling in the Vhost dequeue paths to ease its maintenance and readability. Suggested-by: David Marchand Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 58 +++--- 1 file changed, 26 insertions(+), 32 deletions

[PATCH v3 0/3] vhost: fix and improve dequeue error path

2025-01-16 Thread Maxime Coquelin
s in v2: == - Add RARP handling refactoring Maxime Coquelin (3): vhost: fix missing packets count reset when not ready vhost: rework dequeue paths error handling vhost: improve RARP handling in dequeue paths lib/vhost/virtio_net.c | 110 ++--

Re: [PATCH v2 3/4] vhost: rework async dequeue path error handling

2025-01-16 Thread Maxime Coquelin
On 1/15/25 5:49 PM, David Marchand wrote: On Wed, Jan 15, 2025 at 5:42 PM David Marchand wrote: On Wed, Jan 15, 2025 at 1:59 PM Maxime Coquelin wrote: This patch refactors the error handling in the Vhost async dequeue path to ease its maintenance and readability. Suggested-by: David

[PATCH v2 4/4] vhost: improve RARP handling in dequeue paths

2025-01-15 Thread Maxime Coquelin
With previous refactoring, we can now simplify the RARP packet injection handling in both the sync and async dequeue paths. Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 42 ++ 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a

[PATCH v2 3/4] vhost: rework async dequeue path error handling

2025-01-15 Thread Maxime Coquelin
This patch refactors the error handling in the Vhost async dequeue path to ease its maintenance and readability. Suggested-by: David Marchand Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff

[PATCH v2 2/4] vhost: rework dequeue path error handling

2025-01-15 Thread Maxime Coquelin
This patch refactors the error handling in the Vhost dequeue path to ease its maintenance and readability. Suggested-by: David Marchand Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a

[PATCH v2 1/4] vhost: fix missing packets count reset when not ready

2025-01-15 Thread Maxime Coquelin
") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c index 69901ab3b5..a340e5a772 100644 --- a/lib/vhost/virtio_net.c +++ b/lib/vhost/virtio_net.c @@ -3629

[PATCH v2 0/4] vhost: fix and improve dequeue error path

2025-01-15 Thread Maxime Coquelin
This series starts with a fix for a regression in the Vhost dequeue error path. The other patches improve the error handling to reduce the chance of such regressions in the future. Changes in v2: == - Add RARP handling refactoring Maxime Coquelin (4): vhost: fix missing packets

[PATCH 3/3] vhost: rework async dequeue path error handling

2025-01-15 Thread Maxime Coquelin
This patch refactors the error handling in the Vhost async dequeue path to ease its maintenance and readability. Suggested-by: David Marchand Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff

[PATCH 2/3] vhost: rework dequeue path error handling

2025-01-15 Thread Maxime Coquelin
This patch refactors the error handling in the Vhost dequeue path to ease its maintenance and readability. Suggested-by: David Marchand Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a

[PATCH 1/3] vhost: fix missing packets count reset when not ready

2025-01-15 Thread Maxime Coquelin
") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c index 69901ab3b5..a340e5a772 100644 --- a/lib/vhost/virtio_net.c +++ b/lib/vhost/virtio_net.c @@ -3629

  1   2   3   4   5   6   7   8   9   10   >