Hi Bruce,
Series-acked-by: Vladimir Medvedkin
On 14/10/2024 12:02, Bruce Richardson wrote:
A number of small fixes and other changes to enable Tx scheduler
enhancements to our DPDK driver have been added to the base code.
Upstream these changes for 24.11 RC2. Most have previously been
submitte
Hi Stephen,
Thanks for the review.
No particular reason, will change it to uint32_t in v2.
On 09/09/2024 01:11, Stephen Hemminger wrote:
On Fri, 6 Sep 2024 16:53:16 +
Vladimir Medvedkin wrote:
+struct divisors {
+ int n; /* number of divisors */
+ int div_arr[MAX_DIVISORS];
Hi Stephen,
Thanks for the review, I'll address your comments in v3
On 08/10/2024 19:28, Stephen Hemminger wrote:
On Tue, 8 Oct 2024 17:55:23 +
Vladimir Medvedkin wrote:
+ if ((tbl8_idx == -ENOSPC) && dp->dq != NULL) {
Better to either drop the parenthesis here, or put it on both
Hi David,
On 09/10/2024 11:56, David Marchand wrote:
On Wed, Oct 9, 2024 at 11:51 AM David Marchand
wrote:
Hi Vladimir,
On Tue, Oct 8, 2024 at 7:16 PM Vladimir Medvedkin
wrote:
diff --git a/lib/fib/dir24_8_avx512.c b/lib/fib/dir24_8_avx512.c
index 43dba28cfb..edd802abe4 100644
--- a/lib/fib
Acked-by: Vladimir Medvedkin
On 04/09/2024 14:57, Bruce Richardson wrote:
To simplify building 32-bit binaries on 64-bit system, we can supply a
cross-compilation file which provides the relevant compiler flags and
settings needed - '-m32' compile/link flag, and appropriate
PKG_CONFIG_LIBDIR va
Acked-by: Vladimir Medvedkin
On 26/07/2024 15:54, Niall Meade wrote:
Separated name, entries and key_len parameter checks in
rte_hash_create(). Also made the error messages more
informative/verbose to help with debugging. Also added myself to the
mailing list.
Signed-off-by: Niall Meade
---
I am not aware of such plans.
From: rajesh goel
Sent: Wednesday, August 28, 2024 11:22 AM
To: Medvedkin, Vladimir
Cc: Ferruh Yigit ; Wang, Yipeng1
; Gobriel, Sameh ; Richardson,
Bruce ; dev@dpdk.org
Subject: Re: Bihash Support in DPDK
Thanks Vladimir for the confirmation.
Is there any plan
Hi Rajesh,
rte_hash does not support per bucket locks, instead it uses global rwlock.
But you can try lock free mode (see documentation, in particular
RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF flag)
From: rajesh goel
Sent: Tuesday, August 27, 2024 4:57 PM
To: Medvedkin, Vladimir
Cc: Ferruh
: rajesh goel
Sent: Tuesday, August 27, 2024 7:04 AM
To: Ferruh Yigit
Cc: Wang, Yipeng1 ; Gobriel, Sameh
; Richardson, Bruce ;
Medvedkin, Vladimir ; dev@dpdk.org
Subject: Re: Bihash Support in DPDK
Hi All,
Can we get some reply.
Thanks
Rajesh
On Thu, Aug 22, 2024 at 9:32 PM Ferruh Yigit
Hi Robin,
On 31/07/2024 16:04, Robin Jarry wrote:
Hi Vladimir,
I noticed that the fib/rib APIs (both IPv4 and IPv6) require the next
hops to be represented as integer indexes. Reading the code, I noticed
that they are stored as uint64_t with the MSB used for internal purposes.
I believe yo
Acked-by: Vladimir Medvedkin
On 23/07/2024 09:27, Robin Jarry wrote:
In 24.11, all IPv6 public APIs will be modified to use a structure
instead of fixed size arrays.
Signed-off-by: Robin Jarry
Acked-by: Morten Brørup
---
Notes:
v2: updated with the exhaustive list of symbols
doc/gui
Hi Robin,
Apologies for the delayed response
On 19/03/2024 20:38, Robin Jarry wrote:
Hi Vladimir,
Medvedkin, Vladimir, Mar 19, 2024 at 18:16:
> 2) Is it OK/safe to modify a fib from a control thread (read/write)
> while it is used by data path threads (read only)?
This part is
Hi all,
This patch breaks ipsec tests with ipsec-secgw:
./examples/ipsec-secgw/test/run_test.sh -4 trs_aesctr_sha1
...
ERROR: ./examples/ipsec-secgw/test/linux_test.sh failed for dst=192.168.31.14,
sz=1
test IPv4 trs_aesctr_sha1 finished with status 1
ERROR test trs_aesctr_sha1 FAILED
On 03
-Original Message-
From: Richardson, Bruce
Sent: Monday, July 22, 2024 12:25 PM
To: Medvedkin, Vladimir
Cc: dev@dpdk.org
Subject: Re: [PATCH v4 2/3] net/ice: refactor raw pattern parsing function
On Mon, Jul 22, 2024 at 10:59:49AM +, Vladimir Medvedkin wrote:
> Replace str
-Original Message-
From: Richardson, Bruce
Sent: Monday, July 22, 2024 11:42 AM
To: Medvedkin, Vladimir
Cc: dev@dpdk.org; sta...@dpdk.org; Stolarchuk, Michael
Subject: Re: [PATCH v3 1/3] net/ice: fix possible memory leak
On Mon, Jul 22, 2024 at 08:28:34AM +, Vladimir Medvedkin
Hi Morten,
On 19/07/2024 10:12, Morten Brørup wrote:
From: Robin Jarry [mailto:rja...@redhat.com]
Vladimir Medvedkin, Jul 18, 2024 at 23:25:
I think alignment should be 1 since in FIB6 users usually don't copy
IPv6
address and just provide a pointer to the memory inside the packet.
How can
Hi Bruce,
Sure, will submit v2.
Thanks!
-Original Message-
From: Richardson, Bruce
Sent: Thursday, July 11, 2024 6:05 PM
To: Medvedkin, Vladimir
Cc: dev@dpdk.org; ting...@intel.com; Stolarchuk, Michael
Subject: Re: [PATCH] net/ice: fix possible memory leak
On Thu, Jul 11, 2024 at
Acked-by: Vladimir Medvedkin
On 04/07/2024 07:50, Mingjin Ye wrote:
This patch enable three Forward Error Correction(FEC) related ops
in ice driver. As no speed information can get from HW, this patch
only show FEC capability.
Signed-off-by: Qiming Yang
Signed-off-by: Mingjin Ye
---
v3: opt
Hi Minjin,
- please update release notes
- see comments inline
On 02/07/2024 09:02, Mingjin Ye wrote:
This patch enable three Forward Error Correction(FEC) related ops
in ice driver. As no speed information can get from HW, this patch
only show FEC capability.
Signed-off-by: Qiming Yang
Signe
Acked-by: Vladimir Medvedkin
On 02/07/2024 09:40, Zhichao Zeng wrote:
This patch enabled querying Forward Error Correction(FEC) capabilities,
set FEC mode and get current FEC mode functions.
Signed-off-by: Zhichao Zeng
---
v6: fix some judgments
v5: fix some judgments
v4: fix some logic
v3:
Hi Zhichao,
On 11/04/2024 10:29, Zhichao Zeng wrote:
This patch enabled querying Forward Error Correction(FEC) capabilities,
set FEC mode and get current FEC mode functions.
Signed-off-by: Qiming Yang
Signed-off-by: Zhichao Zeng
---
v5: fix some judgments
v4: fix some logic
v3: optimize code
Hi Mingjin,
On 11/04/2024 10:45, Mingjin Ye wrote:
This patch enable three Forward Error Correction(FEC) related ops
in ice driver. As no speed information can get from HW, this patch
only show FEC capability.
Signed-off-by: Mingjin Ye
---
doc/guides/nics/features/ice.ini | 1 +
doc/guides
Hi Robin,
On 19/03/2024 08:30, Robin Jarry wrote:
Hi Vladimir,
I have been using rte_fib for a while and stumbled upon a few quirks.
I was wondering if you would answer some questions:
1) Is it OK/safe to share the same fib to perform route lookups from
multiple lcores in parallel? So far
Hi Zhichao,
On 12/03/2024 08:44, Zeng, ZhichaoX wrote:
Hi Vladimir:
Thanks for your comments, some responses and questions are inline.
From: Medvedkin, Vladimir
Sent: Monday, March 11, 2024 11:59 PM
To: Zeng, ZhichaoX ; dev@dpdk.org
Cc: Cui, KaixinX ; Yang, Qiming ;
Zhang, Yuying
Subject
Hi Zhicha,
It would be good to reflect FEC feature here:
https://doc.dpdk.org/guides/nics/overview.html
in "/Table 1.1 //Features availability in networking drivers/"
please find the rest comments inline
On 06/03/2024 10:41, Zhichao Zeng wrote:
This patch enabled querying Forward Error Corre
Acked-by: Vladimir Medvedkin
On 06/03/2024 20:13, Tyler Retzlaff wrote:
Zero length arrays are GNU extension. Replace with
standard flex array.
Signed-off-by: Tyler Retzlaff
Reviewed-by: Morten Brørup
---
lib/lpm/rte_lpm6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Acked-by: Vladimir Medvedkin
On 06/03/2024 20:13, Tyler Retzlaff wrote:
Zero length arrays are GNU extension. Replace with
standard flex array.
Signed-off-by: Tyler Retzlaff
Reviewed-by: Morten Brørup
Acked-by: Stephen Hemminger
---
lib/fib/dir24_8.h | 2 +-
lib/fib/trie.h| 2 +-
2
Acked-by: Vladimir Medvedkin
On 06/03/2024 20:13, Tyler Retzlaff wrote:
Zero length arrays are GNU extension. Replace with
standard flex array.
Signed-off-by: Tyler Retzlaff
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Morten Brørup
Acked-by: Chengwen Feng
Acked-by: Stephen Hemminger
--
Acked-by: Vladimir Medvedkin
On 28/02/2024 18:47, Tyler Retzlaff wrote:
Use newly added __rte_pure macro from rte_common.h instead of directly
using __attribute__((pure)).
Signed-off-by: Tyler Retzlaff
Reviewed-by: Morten Brørup
---
lib/lpm/rte_lpm.c | 4 ++--
lib/lpm/rte_lpm6.c | 2 +-
Hi Beilei,
Just a one nit below, besides that LGTM
Acked-by: Vladimir Medvedkin
On 22/12/2023 16:51, beilei.x...@intel.com wrote:
From: Beilei Xing
Since the response of virtual channel virtchnl2_get_ptype_info is
changed on IMC side, driver needs to be updated when requiring
the virtual ch
On 15/02/2024 13:31, edwin.brosse...@6wind.com wrote:
From: Edwin Brossette
Different Intel nics with the igxbe pmd do not handle RSS in the same
way when working with virtualization. While some nics like Intel 82599ES
only have a single RSS table in the device and leave all rss features to
b
On 30/01/2024 10:00, Kevin Traynor wrote:
When vf issues a reset to pf there is a 50 msec wait plus an additional
max of 1 msec for the pf to indicate the reset is complete before
timeout.
In some cases, it is seen that the reset is timing out, in which case
the reset does not complete and an er
Hi Abdullah,
Could you please tell more about use cases where this API may be useful?
a new API to get the hidden key count in the hash table if the rcu qsbr is
enabled
Here in commit message and down below in doxygen comments, I think this
statement should be more specific because rcu can
Hi Wenjing,
Please find comments inlined
On 05/01/2024 08:16, wenjing.q...@intel.com wrote:
From: Wenjing Qiao
Add TDI implementation to a flow engine.
Signed-off-by: Wenjing Qiao
---
--- /dev/null
+++ b/drivers/net/cpfl/cpfl_tdi.c
@@ -0,0 +1,1282 @@
+/* SPDX-License-Identifier: BSD-3-Clau
Hi Wenjing,
Please find comments inlined
On 05/01/2024 08:16, wenjing.q...@intel.com wrote:
From: Wenjing Qiao
To supporting P4-programmed network controller, reuse devargs
"flow_parser" to specify the path of a p4 context JSON configure
file. The cpfl PMD use the JSON configuration file to t
Hi Jeffrey,
Have you tried FIB library? This problem has been solved there for a
long time, and it also has a number of other improvements.
Thanks!
On 10/11/2023 14:08, Warrington, Jeffrey wrote:
On 11/10/23, 2:42 AM, "David Marchand" mailto:david.march...@redhat.com>> wrote:
On Fri, Nov 1
Hi Satananda, Anoob, Chengwen, Jerin, all,
After a number of internal discussions we have decided that we're going
to postpone this feature/patchset till next release.
>[Satananda] Have you considered extending rte_dma_port_param and
rte_dma_vchan_conf to represent interdomain memory transfe
Acked-by: Vladimir Medvedkin
On 10/07/2023 22:59, Bili Dong wrote:
An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its
use case in P4. We implement it in this patch so it could be easily
registered in the pipeline later.
Signed-off-by: Bili Dong
--
Regards,
Vladimir
Hi David,
Yes, I sent them separately because the bugfix in mentioned patch should be
backported unlike adding a new test.
-Original Message-
From: David Marchand
Sent: Thursday, June 29, 2023 2:00 PM
To: Medvedkin, Vladimir
Cc: dev@dpdk.org; konstantin.v.anan...@yandex.ru
Subject
Hi Bili,
Please find just one nit below inlined
Apart from it LGTM
Acked-by: Vladimir Medvedkin
On 20/06/2023 20:12, Bili Dong wrote:
An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its
use case in P4. We implement it in this patch so it could be easily
registered in the pi
Hi Bill,
On 15/02/2023 11:06, Bili Dong wrote:
An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its
use case in P4. We implement it in this patch so it could be easily
registered in the pipeline later.
Signed-off-by: Bili Dong
---
+static inline uint32_t
+rte_hash_xor(const vo
Hi Stepthen,
There is a problem with the build on a machine that supports GFNI:
../lib/hash/rte_thash_gfni.c:15:1: error: redefinition of ‘rte_thash_gfni’
15 | rte_thash_gfni(const uint64_t *mtrx __rte_unused,
| ^~
In file included from ../lib/hash/rte_thash_gfni.h:13,
Hi Stephen,
On 03/11/2022 18:33, Stephen Hemminger wrote:
On Thu, 3 Nov 2022 18:13:38 +
Vladimir Medvedkin wrote:
+ if (ret != 0) {
+ printf("rte_hash_lookup_with_hash_bulk"
+
Acked-by: Vladimir Medvedkin
On 30/09/2022 13:40, Radu Nicolau wrote:
Fix a typo in computing port mask for Tx checksum offload capability.
Fixes: 4edcee19fc20 ("examples/ipsec-secgw: use Tx checksum offload
conditionally")
Cc: ndabilpu...@marvell.com
Signed-off-by: Radu Nicolau
---
examp
Acked-by: Vladimir Medvedkin
On 07/09/2022 12:33, Sean Morrissey wrote:
This patch fixes a core dump which occurs on 32-bit-builds
after sending a matched packet due to overrunning an array.
Fixes: 6de0ea50e9b9 ("examples/l3fwd: merge l3fwd-acl example")
Cc: sean.morris...@intel.com
Cc: sta...
Tested-by: Vladimir Medvedkin
On 30/06/2022 12:45, Radu Nicolau wrote:
Fix fallback session create for inline sessions.
Fixes: a8ade12123c3 ("examples/ipsec-secgw: create lookaside sessions at init")
Cc: vfia...@marvell.com
Signed-off-by: Radu Nicolau
---
v2: create the session rather than j
Acked-by: Vladimir Medvedkin
On 22/06/2022 21:41, Stephen Hemminger wrote:
The comments in rte_rib6 were cut-and-pasted from rte_rib
and because of that some references to rte_rib_node were
not updated.
Signed-off-by: Stephen Hemminger
---
lib/rib/rte_rib6.h | 6 +++---
1 file changed, 3 i
On 17/06/2022 13:06, David Marchand wrote:
On Thu, Jun 16, 2022 at 11:33 AM David Marchand
wrote:
GCC 12 raises the following warning:
In function ‘_mm256_loadu_si256’,
inlined from ‘rte_mov32’ at
../lib/eal/x86/include/rte_memcpy.h:319:9,
inlined from ‘rte_mov128’ at
Hi David,
On 03/06/2022 10:41, David Marchand wrote:
On Fri, Jun 3, 2022 at 9:56 AM Bruce Richardson
wrote:
On Fri, Jun 03, 2022 at 09:45:45AM +0200, David Marchand wrote:
Hello Vladimir,
On Thu, Jun 2, 2022 at 8:42 PM Medvedkin, Vladimir
wrote:
if (!dst
Hi David,
On 18/05/2022 11:16, David Marchand wrote:
GCC 12 raises the following warning:
In function ‘_mm256_loadu_si256’,
inlined from ‘rte_mov32’ at
../lib/eal/x86/include/rte_memcpy.h:319:9,
inlined from ‘rte_mov128’ at
../lib/eal/x86/include/rte_memcpy.h:344:2,
On 01/06/2022 12:15, Stanislaw Kardach wrote:
From: Michal Mazurek
Add an implementation of the rte_lpm_lookupx4() function for platforms
without support for vector operations.
This will be useful in the upcoming RISC-V port as well as any platform
which may want to start with a basic level
Hi Stanislaw,
On 30/05/2022 19:24, Stanislaw Kardach wrote:
From: Michal Mazurek
Add an implementation of the rte_lpm_lookupx4() function for platforms
without support for vector operations.
This will be useful in the upcoming RISC-V port as well as any platform
which may want to start with
On 30/05/2022 19:24, Stanislaw Kardach wrote:
All other rte_lpm_lookup* functions take lpm argument as a const. As the
basic rte_lpm_lookup() performs the same function, it should also do
that.
As this function is inline, no API/ABI change happens.
Signed-off-by: Stanislaw Kardach
---
lib
Hi Stanislaw,
On 27/05/2022 12:16, Stanisław Kardach wrote:
On Tue, May 24, 2022 at 6:28 PM Stanisław Kardach wrote:
That said I wonder why do we have different const requirements for
rte_lpm_lookup() and rte_lpm_lookupx4():
static inline int rte_lpm_lookup(struct rte_lpm *lpm, uint32_t ip
Hi Stanislaw, Michal,
As far as I can see, this implementation almost completely repeats other
lookupx4() implementations, except for the use of vector instructions.
On my board (x86_64) in lpm_perf_autotest your implementation takes about:
LPM LookupX4: 29.5 cycles (fails = 12.5%)
replacing
Fixes: 5a5793a5ffa2 ("rib: add RIB library")
On 26/04/2022 15:28, Medvedkin, Vladimir wrote:
+Cc:sta...@dpdk.org
On 14/04/2022 21:01, Stephen Hemminger wrote:
If a /32 route is entered in the RIB the code to traverse
will not see that a a end of the tree. This is due to tryi
+Cc:sta...@dpdk.org
On 14/04/2022 21:01, Stephen Hemminger wrote:
If a /32 route is entered in the RIB the code to traverse
will not see that a a end of the tree. This is due to trying
to do a negative shift which is an undefined in C.
Fix by checking for max depth as is already done in rib6.
On 13/04/2022 03:09, Stephen Hemminger wrote:
Also mark some conditional functions as const.
Signed-off-by: Stephen Hemminger
---
lib/rib/rte_rib6.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c
inde
On 13/04/2022 03:09, Stephen Hemminger wrote:
Also mark some conditional functions as const.
Signed-off-by: Stephen Hemminger
---
lib/rib/rte_rib.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/lib/rib/rte_rib.c b/lib/rib/rte_rib.c
index
Hi Stephen,
If I understand correctly, the only problem is that
"rte_rib_get_nxt(rib, 0, 0, ..." does not return 0/0 prefix?
If so, that's what was intended. From the documentation:
* Retrieve next more specific prefix from the RIB
* that is covered by ip/depth supernet in an ascending order
On 20/02/2022 18:21, Stephen Hemminger wrote:
The functions rte_lpm_free() and rte_lpm6_free() already
handle NULL pointer case.
Signed-off-by: Stephen Hemminger
---
app/test/test_func_reentrancy.c | 3 +--
lib/lpm/rte_lpm.h | 1 +
lib/lpm/rte_lpm6.h | 1 +
3 f
Hi,
On 09/02/2022 13:54, Bruce Richardson wrote:
On Wed, Feb 09, 2022 at 12:00:40PM +, Ananyev, Konstantin wrote:
Or have a generic library for reading LPM entries. L3fwd is supposed
to be as small as possible (it no longer is), and the real work should
be done by libraries to make it e
Hi all,
On 08/02/2022 10:44, Ananyev, Konstantin wrote:
This patchset introduces config file support for l3fwd
and its lookup methods LPM, FIB, and EM, similar to
that of l3fwd-acl. This allows for route rules to be
defined in configuration files and edited there instead
of in each of the look
Hi Kevin,
On 11/01/2022 17:15, Kevin Traynor wrote:
On 23/12/2021 15:25, Vladimir Medvedkin wrote:
This patch fixes the division by 0, which occurs if the number of
routes is less than 10.
Can be triggered by passing -n argument with value < 10:
9 causing a divide by zero - another example
Hi Yaron,
On 09/01/2022 13:20, Yaron Illouz wrote:
I am using Mellanox Technologies MT27800 Family [ConnectX-5], using dpdk
19 with multi rx queue with rss
port_conf.rx_adv_conf.rss_conf.rss_hf=(ETH_RSS_IP | ETH_RSS_UDP |
ETH_RSS_TCP)
I analyze traffic and need all packet of same session to
Hi David,
On 16/11/2021 14:53, David Marchand wrote:
On Fri, Nov 12, 2021 at 3:17 PM Vladimir Medvedkin
wrote:
1. This patch replaces _mm512_set_epi8 with _mm512_set_epi32
due to the lack of support by some compilers.
Ok, it was the initial report from Lance.
2. This patch checks if AVX51
On 12/11/2021 15:01, Conor Walsh wrote:
This patch fixes unused but set variables within the following test apps:
- test distributor perf
- test thash perf
Bugzilla ID: 881
Fixes: c0de0eb82e40 ("distributor: switch over to new API")
Fixes: 239fffe0402e ("test/thash: add performance tests
On 12/11/2021 01:02, Stephen Hemminger wrote:
Yet another spelling error found by codespell.
Signed-off-by: Stephen Hemminger
---
lib/rib/rte_rib6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c
index b00c7fbf5ab0..70405113b419
On 12/11/2021 01:02, Stephen Hemminger wrote:
Yet another spelling error found by codespell.
Signed-off-by: Stephen Hemminger
---
lib/hash/rte_thash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c
index 394e1328c531..6847e3
On 12/11/2021 01:02, Stephen Hemminger wrote:
Lots of typos in comments found by codespell
Signed-off-by: Stephen Hemminger
Acked-by: Konstantin Ananyev
---
lib/ipsec/esp_inb.c | 4 ++--
lib/ipsec/esp_outb.c | 2 +-
lib/ipsec/ipsec_sad.c | 2 +-
lib/ipsec/sa.c| 2 +-
lib/ip
Hi Honnappa,
On 08/11/2021 23:04, Honnappa Nagarahalli wrote:
This patch adds a comment for RTE_HASH_BUCKET_ENTRIES explaining why a
particular value was chosen.
Signed-off-by: Vladimir Medvedkin
---
lib/hash/rte_cuckoo_hash.h | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
Hi all,
It looks like the problem caused by the lack of _mm512_set1_epi8()
implementation inside the gcc8, however _mm512_set1_epi[16,32,64] has
been implemented.
I replaced it with _mm512_set1_epi32 and on gcc8 it builds fine. I'll
send a fix soon.
On 09/11/2021 17:22, Lance Richardson wrot
@dpdk.org; Wang, Yipeng1
; Gobriel, Sameh ;
Richardson, Bruce ; Medvedkin, Vladimir
Subject: Re: [dpdk-dev] Doubt regarding DPDK hash Library
implementation
+Cc hash lib maintainers
01/11/2021 11:55, Syam Prasad N Pearson:
Dear Sir/Madam,
I am a developer trying to get familiar with the DPDK hash
Hi Usama,
On 04/11/2021 12:11, Walsh, Conor wrote:
From: dev On Behalf Of Usama Nadeem
Sent: Thursday 14 October 2021 19:43
To: tho...@monjalon.net
Cc: dev@dpdk.org; Usama Nadeem
Subject: [dpdk-dev] [PATCH v4] examples/l3fwd: ipv4 and udp/tcp cksum
verification through software
checks if ipv4
Hi Thomas,
On 27/10/2021 10:29, Thomas Monjalon wrote:
26/10/2021 22:29, Medvedkin, Vladimir:
Hi Thomas,
Thanks for the review, I'll address your comments in v6.
Please find my comment below
On 25/10/2021 19:02, Thomas Monjalon wrote:
21/10/2021 20:54, Vladimir Medvedkin:
This patch
Hi Thomas,
On 27/10/2021 10:28, Thomas Monjalon wrote:
26/10/2021 22:30, Medvedkin, Vladimir:
Hi Thomas,
On 25/10/2021 19:23, Thomas Monjalon wrote:
06/09/2021 17:55, Vladimir Medvedkin:
This patch adds a new parameter to the fib configuration to specify
the size of the extension for
Hi Stephen,
On 25/10/2021 19:27, Stephen Hemminger wrote:
On Thu, 21 Oct 2021 19:54:29 +0100
Vladimir Medvedkin wrote:
+static uint8_t default_rss_key[] = {
Should this be const?
That way you can make sure API isn't modifying it.
Thanks, I'll fix this in v6
--
Regards,
Vladimir
Hi Thomas,
On 25/10/2021 19:23, Thomas Monjalon wrote:
06/09/2021 17:55, Vladimir Medvedkin:
This patch adds a new parameter to the fib configuration to specify
the size of the extension for internal RIB structure.
It looks to be an announced API change.
What happens if the new field is not i
On 25/10/2021 19:04, Thomas Monjalon wrote:
Vladimir, your patches are late and not perfect.
You need reviews. Please ask other maintainers to help with reviews.
21/10/2021 20:54, Vladimir Medvedkin:
This patch adds documentation for the new optimized Toeplitz hash
implementation using GFNI
Hi Thomas,
Thanks for the review, I'll address your comments in v6.
Please find my comment below
On 25/10/2021 19:02, Thomas Monjalon wrote:
21/10/2021 20:54, Vladimir Medvedkin:
This patch adds performance tests for different implementations
of the Toeplitz hash function.
Please name them.
Hi Konstantin,
On 21/10/2021 11:42, Ananyev, Konstantin wrote:
This patch add a new Toeplitz hash implementation using
Galios Fields New Instructions (GFNI).
Signed-off-by: Vladimir Medvedkin
---
doc/api/doxy-api-index.md | 1 +
lib/hash/meson.build | 1 +
lib/hash/rte_t
Hi David,
On 20/10/2021 21:55, David Marchand wrote:
Hello Vladimir,
On Fri, Oct 8, 2021 at 11:29 PM Vladimir Medvedkin
wrote:
This patch fixes buffer overflow reported by ASAN,
please reference https://bugs.dpdk.org/show_bug.cgi?id=819
The rte_lpm6 keeps routing information for control pla
Hi David,
On 19/10/2021 09:02, David Marchand wrote:
On Fri, Oct 15, 2021 at 3:02 PM Medvedkin, Vladimir
wrote:
I am confused.
Does it mean that rte_jhash_32b is not compliant with rte_hash_create API?
I think so too, because despite the fact that the ABI is the same, the
API remains
Hi Stephen,
On 19/10/2021 03:15, Stephen Hemminger wrote:
On Mon, 18 Oct 2021 10:40:00 +
"Ananyev, Konstantin" wrote:
On Fri, 15 Oct 2021 10:30:02 +0100
Vladimir Medvedkin wrote:
+ m[i * 8 + j] = (rss_key[i] << j)|
+ (uint8_t)((uin
Hi Stephen,
Thanks for reviewing
On 15/10/2021 18:58, Stephen Hemminger wrote:
On Fri, 15 Oct 2021 10:30:02 +0100
Vladimir Medvedkin wrote:
+ m[i * 8 + j] = (rss_key[i] << j)|
+ (uint8_t)((uint16_t)(rss_key[i + 1]) >>
+
On 15/10/2021 12:55, Ananyev, Konstantin wrote:
+/**
+ * Calculate Toeplitz hash.
+ *
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice.
+ *
+ * @param m
+ * Pointer to the matrices generated from the corresponding
+ * RSS hash key using rte_thash_complete_matrix()
Hi David,
On 15/10/2021 11:33, David Marchand wrote:
On Thu, Oct 14, 2021 at 7:55 PM Vladimir Medvedkin
wrote:
@@ -1607,6 +1611,17 @@ static struct rte_hash_parameters hash_params_ex = {
};
/*
+ * Wrapper function around rte_jhash_32b.
+ * It is required because rte_jhash_32b() accepts th
Hi Konstantin,
On 08/10/2021 13:31, Ananyev, Konstantin wrote:
This patch enables new GFNI Toeplitz hash in
predictable RSS library.
Signed-off-by: Vladimir Medvedkin
---
lib/hash/rte_thash.c | 43 +++
lib/hash/rte_thash.h | 19 +++
Hi Konstantin,
Thanks for the review,
On 07/10/2021 20:23, Ananyev, Konstantin wrote:
This patch add a new Toeplitz hash implementation using
Galios Fields New Instructions (GFNI).
Signed-off-by: Vladimir Medvedkin
---
doc/api/doxy-api-index.md | 1 +
lib/hash/meson.build | 1 +
Hi David,
On 14/10/2021 09:04, David Marchand wrote:
Hello Vladimir,
On Wed, Oct 13, 2021 at 9:27 PM Medvedkin, Vladimir
wrote:
With patch applied, ASan reports another issue.
Did you test your fix with ASan?
You're right, for some reason ASAN wasn't enabled.
I applied patch
Hi David,
On 14/10/2021 10:34, David Marchand wrote:
On Wed, Oct 13, 2021 at 9:28 PM Vladimir Medvedkin
wrote:
This patch fixes buffer overflow reported by ASAN,
please reference https://bugs.dpdk.org/show_bug.cgi?id=818
Some tests for the rte_hash table use the rte_jhash_32b() as
the hash f
Hi Honnappa,
On 14/10/2021 02:19, Honnappa Nagarahalli wrote:
On Wed, 13 Oct 2021 16:38:58 -0500
Honnappa Nagarahalli wrote:
--- a/lib/hash/rte_hash.h
+++ b/lib/hash/rte_hash.h
@@ -430,7 +430,6 @@ rte_hash_get_key_with_position(const struct
rte_hash *h, const int32_t position,
* -
Hi David,
On 11/10/2021 13:03, David Marchand wrote:
On Fri, Oct 8, 2021 at 11:28 PM Vladimir Medvedkin
wrote:
This patch fixes buffer overflow reported by ASAN,
please reference https://bugs.dpdk.org/show_bug.cgi?id=818
Some tests for the rte_hash table use the rte_jhash_32b() as
the hash f
On 14/09/2021 09:05, David Marchand wrote:
On Mon, Sep 13, 2021 at 8:47 PM Ben Pfaff wrote:
This is probably due to conversion from ms word to rst format.
Fixes: fc1f2750a3ec ("doc: programmers guide")
Cc: sta...@dpdk.org
Signed-off-by: Ben Pfaff
Reviewed-by: David Marchand
Acke
Hi Stephen,
On 07/09/2021 02:35, Stephen Hemminger wrote:
On Mon, 6 Sep 2021 17:03:58 +0100
Vladimir Medvedkin wrote:
+uint8_t big_rss_key[] = {
+0x6d, 0x5a, 0x56, 0xda, 0x25, 0x5b, 0x0e, 0xc2,
+0x41, 0x67, 0x25, 0x3d, 0x43, 0xa3, 0x8f, 0xb0,
+0xd0, 0xca, 0x2b, 0xcb, 0xae, 0x7b, 0x30, 0xb4,
Hi Stephen,
On 07/09/2021 02:34, Stephen Hemminger wrote:
On Mon, 6 Sep 2021 17:01:15 +0100
Vladimir Medvedkin wrote:
diff --git a/lib/fib/version.map b/lib/fib/version.map
index be975ea..af76add 100644
--- a/lib/fib/version.map
+++ b/lib/fib/version.map
@@ -1,4 +1,4 @@
-EXPERIMENTAL {
+DPDK
Hi Stephen,
Thanks!
Acked-by: Vladimir Medvedkin
On 31/08/2021 23:49, Stephen Hemminger wrote:
The rib and rib6 API's have been in since 19.11 and
should be marked as stable.
Signed-off-by: Stephen Hemminger
---
lib/rib/rte_rib.h | 18 --
lib/rib/rte_rib6.h | 18 --
On 05/08/2021 16:34, Jan Viktorin wrote:
On Thu, 5 Aug 2021 16:29:50 +0200
"Medvedkin, Vladimir" wrote:
On 05/08/2021 16:07, Jan Viktorin wrote:
On Thu, 5 Aug 2021 15:57:14 +0200
"Medvedkin, Vladimir" wrote:
On 05/08/2021 15:32, Jan Viktorin wrote:
On Thu, 5 Aug
On 05/08/2021 16:07, Jan Viktorin wrote:
On Thu, 5 Aug 2021 15:57:14 +0200
"Medvedkin, Vladimir" wrote:
On 05/08/2021 15:32, Jan Viktorin wrote:
On Thu, 5 Aug 2021 15:27:15 +0200
"Medvedkin, Vladimir" wrote:
Hi Jan,
The RIB is always used as a control plan
On 05/08/2021 15:32, Jan Viktorin wrote:
On Thu, 5 Aug 2021 15:27:15 +0200
"Medvedkin, Vladimir" wrote:
Hi Jan,
The RIB is always used as a control plane struct intended to maintain
the correct content of the dataplane struct, such as DIR24_8 for
example. So it is always us
1 - 100 of 269 matches
Mail list logo
