[dpdk-dev] [PATCH 2/2] doc: update QEDE PMD firmware version

2018-11-21 Thread Mody, Rasesh
Update QEDE PMD firmware version to 8.37.7.0 Signed-off-by: Rasesh Mody --- doc/guides/nics/qede.rst |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst index cba3886..c0a3833 100644 --- a/doc/guides/nics/qede.rst +++ b

[dpdk-dev] [PATCH 1/2] net/qede: fix Tx offload mask

2018-11-21 Thread Mody, Rasesh
From: Shahed Shaikh Following commit updated the Tx offload mask commit 1037ed842c37 ("mbuf: fix Tx offload mask"). So, not having PKT_TX_IPV6 and PKT_TX_IPV4 in qede PMDs supported Tx offload mask breaks TSO support since application will fail in transmit prepare function. Fixes: 1037ed842c37

Re: [dpdk-dev] [PATCH v2 2/2] net/bnx2x: bump version to 1.0.7.1

2018-11-19 Thread Mody, Rasesh
Hi Ferruh, >From: Ferruh Yigit >Sent: Monday, November 19, 2018 5:28 AM > >On 11/17/2018 9:37 AM, Mody, Rasesh wrote: >> Signed-off-by: Rasesh Mody > >Hi Rasesh, > >18.11-rc4 is out and this patchset was late for it, I suggest postponing >previous >pa

Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: cleanup info logs

2018-11-17 Thread Mody, Rasesh
>From: Ferruh Yigit >Sent: Friday, November 16, 2018 3:26 AM > >On 11/14/2018 6:17 PM, Mody, Rasesh wrote: >> Reduced number of INFO logs in BNX2X PMD by converting some INFO logs >> to DEBUG and few NOTICE logs to INFO, removing extra new lines, >> printing banne

[dpdk-dev] [PATCH v2 1/2] net/bnx2x: cleanup info logs

2018-11-17 Thread Mody, Rasesh
Reduced number of INFO logs in BNX2X PMD by converting some INFO logs to DEBUG and few NOTICE logs to INFO, removing extra new lines, printing banner bar once for the adapter and device specific info. Fixes: ba7eeb035a5f ("net/bnx2x: fix logging to include device name") Fixes: 540a211084a7 ("bnx2x

[dpdk-dev] [PATCH v2 2/2] net/bnx2x: bump version to 1.0.7.1

2018-11-17 Thread Mody, Rasesh
Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index c80f84c..4c775c1 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -29,7 +29,7 @@ #d

[dpdk-dev] [PATCH 2/2] net/bnx2x: bump version to 1.0.7.1

2018-11-14 Thread Mody, Rasesh
Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index e2a6580..83334bf 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -29,7 +29,7 @@ #d

[dpdk-dev] [PATCH 1/2] net/bnx2x: cleanup info logs

2018-11-14 Thread Mody, Rasesh
Reduced number of INFO logs in BNX2X PMD by converting some INFO logs to DEBUG and few NOTICE logs to INFO, removing extra new lines, printing banner bar once for the adapter and device specific info. Fixes: ba7eeb035a5f ("net/bnx2x: fix logging to include device name") Fixes: 540a211084a7 ("bnx2x

[dpdk-dev] [PATCH] net/qede: fix Tx tunnel offload notsup mask

2018-11-12 Thread Mody, Rasesh
From: Shahed Shaikh Tunneling offloads are represented by multi-bit values. So, feature wise tunneling offload can only be entirely supported/unsupported using PKT_TX_TUNNEL_MASK. Its upon PMDs to further isolate which of the tunneling offload types are supported by respective PMD. Using subset o

Re: [dpdk-dev] [PATCH] net/qede: fix crash when configure fails

2018-11-09 Thread Mody, Rasesh
>From: Timothy Redaelli >Sent: Friday, November 09, 2018 7:46 AM > >Currently, if configuration fails (for example if a 100G card is used with an >odd >number of RX/TX queues) QEDE crashes due to a null pointer dereference. > >This commit fixes it by checking that the pointer is not NULL before u

Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix to use rte log

2018-11-08 Thread Mody, Rasesh
>From: Stephen Hemminger >Sent: Thursday, November 08, 2018 1:39 PM > >On Thu, 8 Nov 2018 21:19:26 +0000 >"Mody, Rasesh" wrote: > >> Use rte_log() rather than RTE_LOG() for dynamic logging. Rearrange >> dynamic log types to the top and configurab

[dpdk-dev] [PATCH 2/2] net/bnx2x: fix VF link status update

2018-11-08 Thread Mody, Rasesh
In general the VF driver should not access the chip. For VF link status update, VF driver should not use HW lock, use bnx2x_link_report_locked() instead. Add few prints for releasing previously held HW locks. Fixes: a9b58b15ed51 ("net/bnx2x: fix to add PHY lock") Signed-off-by: Rasesh Mody ---

[dpdk-dev] [PATCH 1/2] net/bnx2x: fix to use rte log

2018-11-08 Thread Mody, Rasesh
Use rte_log() rather than RTE_LOG() for dynamic logging. Rearrange dynamic log types to the top and configurable log types to bottom. Remove unused RTE_LIBRTE_BNX2X_DEBUG_TX_FREE Fixes: ba7eeb035a5f ("net/bnx2x: fix logging to include device name") Signed-off-by: Rasesh Mody --- drivers/net/bnx

[dpdk-dev] [PATCH] net/qede/base: fix to initialize HW for LLH filters

2018-10-30 Thread Mody, Rasesh
During initalization of leading PF, we need to initialize HW for LLH filters. Set HW init parameter to set the eingine affinity for multiple engine adapters. Fixes: 3eed444a9621 ("net/qede/base: changes for 100G") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c |8

[dpdk-dev] [PATCH 01/18] net/qede/base: upgrade to FW 8.37.7.0

2018-09-29 Thread Mody, Rasesh
This patch adds changes to base driver for upgrading to 8.37.3.0 FW. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.h |1 + drivers/net/qede/base/common_hsi.h| 15 +- drivers/net/qede/base/ecore.h |5 +- drivers/net/qede/base/ecor

[dpdk-dev] [PATCH 16/18] net/qede/base: add APIs for dscp priority map configuration

2018-09-29 Thread Mody, Rasesh
Add APIs for dscp priority map configuration. APIs added are ecore_dcbx_get_dscp_priority(), ecore_dcbx_set_dscp_priority(). These base driver APIs can be used for dscp-map query/config. Configure the doorbell queue (DORQ) to use vlan-id/priority. Signed-off-by: Rasesh Mody --- drivers/net/qede

[dpdk-dev] [PATCH 17/18] net/qede/base: semantic changes

2018-09-29 Thread Mody, Rasesh
This patch consists of semantic/formatting changes. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dcbx.c |3 ++- drivers/net/qede/base/ecore_init_ops.c | 12 - drivers/net/qede/base/ecore_int.c |3 ++- drivers/net/qede/base/ecore_int_api.h |3 ++- dri

[dpdk-dev] [PATCH 15/18] net/qede/base: add RL update params

2018-09-29 Thread Mody, Rasesh
Add 'rl_bc_stage_th','rl_timer_stage_th' and 'dcqcn_reset_alpha_on_idle' to RL update param as well as logs. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_sp_commands.c |8 +++- drivers/net/qede/base/ecore_sp_commands.h |3 +++ 2 files changed, 10 insertions(+), 1 deleti

[dpdk-dev] [PATCH 07/18] net/qede/base: add error handling for mutex allocation

2018-09-29 Thread Mody, Rasesh
Add error handling for mutex allocation failure Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_cxt.c | 11 +++ drivers/net/qede/base/ecore_vf.c | 19 ++- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/drivers/net/qede/base/ecore_cxt.c b/

[dpdk-dev] [PATCH 18/18] net/qede: bump PMD version to 2.10.0.1

2018-09-29 Thread Mody, Rasesh
Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.h b/drivers/net/qede/qede_ethdev.h index 8a9df98..622bd01 100644 --- a/drivers/net/qede/qede_ethdev.h +++ b/drivers/net/qede/qede_ethde

[dpdk-dev] [PATCH 14/18] net/qede/base: changes for 100G

2018-09-29 Thread Mody, Rasesh
Change details: - Get engine affinity from the management FW and configure accordingly - Add an LLH filter with the primary MAC address in QPAR/NPAR - Move some of the LLH APIs around - Add PPFID APIs - Update all allocated ppfids with the same value for the following PORT_PF registers:

[dpdk-dev] [PATCH 13/18] net/qede/base: enable control frame filtering

2018-09-29 Thread Mody, Rasesh
Enable control frame filtering for non-trusted VFs. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_l2.c |5 + drivers/net/qede/base/ecore_l2_api.h |5 - drivers/net/qede/base/ecore_sriov.c |4 +++- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH 06/18] net/qede/base: add mf-bit/API for FIP special mode

2018-09-29 Thread Mody, Rasesh
Add mf-bit/API for FIP special mode. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |3 +++ drivers/net/qede/base/ecore_dev.c |8 +++- drivers/net/qede/base/ecore_dev_api.h |9 + 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/driv

[dpdk-dev] [PATCH 05/18] net/qede/base: add API to update FW RSS indirection table

2018-09-29 Thread Mody, Rasesh
Added ecore_update_eth_rss_ind_table_entry() api to update FW RSS indirection table entry according to new interface of FW 8.37.x.x. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_l2.c | 52 ++ drivers/net/qede/base/ecore_l2_api.h | 24

[dpdk-dev] [PATCH 12/18] net/qede/base: get pre-negotiated OEM values

2018-09-29 Thread Mody, Rasesh
Request management FW for OEM values, which are negotiated prior to the driver load by sending the GET_OEM_UPDATES command after both engines are initialized. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 14 ++ drivers/net/qede/base/mcp_public.h |8 ++

[dpdk-dev] [PATCH 11/18] net/qede/base: add periodic Doorbell Recovery support

2018-09-29 Thread Mody, Rasesh
Add support for periodic Doorbell Recovery. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.h |1 + drivers/net/qede/base/ecore_int.c | 37 + drivers/net/qede/base/ecore_int_api.h | 11 ++ 3 files changed, 31 insertions(+), 1

[dpdk-dev] [PATCH 04/18] net/qede/base: workaround to indicate SHMEM data ready

2018-09-29 Thread Mody, Rasesh
The driver can notify that there was an MCP reset and read the SHMEM values before the management FW has completed initializing them. As a temporary solution, the "sup_msgs" field is used as a SHMEM data ready indication. This should be replaced with an actual indication when it is provided by the

[dpdk-dev] [PATCH 10/18] net/qede/base: add support for SRIOV VF min rate

2018-09-29 Thread Mody, Rasesh
Add support for SRIOV vf min rate configuration. Fix return code for ecore_iov_get_vf_min_rate(). Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_iov_api.h | 10 ++ drivers/net/qede/base/ecore_sriov.c | 28 +++- 2 files changed, 37 insertions(+),

[dpdk-dev] [PATCH 03/18] net/qede/base: add DPC sync after PF stop

2018-09-29 Thread Mody, Rasesh
Add DPC sync after stopping the physical funciton to allow clean up of asyncronous events. Post this the driver don't expect the FW to send async events. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c |6 ++ drivers/net/qede/base/ecore_spq.c | 12 ++-- 2 files

[dpdk-dev] [PATCH 09/18] net/qede/base: add pretend function for port/PF

2018-09-29 Thread Mody, Rasesh
Add a pretend function for port/PF, pretend to another port and another function when accessing the ptt window Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_hw.c | 24 drivers/net/qede/base/ecore_hw.h | 12 2 files changed, 36 insertions(+)

[dpdk-dev] [PATCH 02/18] net/qede/base: check for EDPM enabled in DB recovery

2018-09-29 Thread Mody, Rasesh
Add a check for EDPM enabled before flushing doorbell recovery queue. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |2 ++ drivers/net/qede/base/ecore_dev.c | 10 +- drivers/net/qede/base/ecore_int.c | 20 +--- 3 files changed, 28 insertions(+),

[dpdk-dev] [PATCH 08/18] net/qede/base: adjust queue manager idx greater than max

2018-09-29 Thread Mody, Rasesh
Modified queue manager getter APIs to cycle through their range if index is higher than max. This prevents accessing index out of bounds. Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH 00/18] net/qede: base driver update

2018-09-29 Thread Mody, Rasesh
This patch set updates the base driver to use FW 8.37.7.0 and adds support for other base driver functionalities. It also updates the PMD version to 2.10.0.1. Rasesh Mody (18): net/qede/base: upgrade to FW 8.37.7.0 net/qede/base: check for EDPM enabled in DB recovery net/qede/base: add DPC s

[dpdk-dev] [PATCH v2 5/5] net/bnx2x: fix to add phy lock

2018-09-28 Thread Mody, Rasesh
This patch adds phy_lock, acquire/release the lock when performing PHY transactions. Without this fix driver can run into synchronization issues with management FW when modifying PHY settings. Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/

[dpdk-dev] [PATCH v2 3/5] net/bnx2x: fix to disable further interrupts

2018-09-28 Thread Mody, Rasesh
Fix to disable further fastpath/slowpath interrupts. These will be enabled again by their respective handlers Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/driv

[dpdk-dev] [PATCH v2 4/5] net/bnx2x: fix call to link handling periodic function

2018-09-28 Thread Mody, Rasesh
If link handling periodic function is allowed to be called in interrupt context, the periodic function can get called too frequently and exhaust the retry credits to check link status. This change makes sure link handling periodic function is not called in interrupt context. Fixes: 540a211084a7 (

Re: [dpdk-dev] [PATCH 2/5] net/bnx2x: update link/PHY management

2018-09-21 Thread Mody, Rasesh
>From: Ferruh Yigit >Sent: Friday, September 21, 2018 11:10 AM > >On 9/19/2018 10:59 PM, Mody, Rasesh wrote: >> This patch has changes to update the link/PHY management (elink) code >> to the latest. >> >> Signed-off-by: Rasesh Mody >> --- >> dr

[dpdk-dev] [PATCH 5/5] net/bnx2x: fix to add phy lock

2018-09-19 Thread Mody, Rasesh
This patch adds phy_lock, acquire/release the lock when performing PHY transactions. Without this fix driver can run into synchronization issues with management FW when modifying PHY settings. Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/

[dpdk-dev] [PATCH 4/5] net/bnx2x: fix call to link handling periodic function

2018-09-19 Thread Mody, Rasesh
If link handling periodic function is allowed to be called in interrupt context, the periodic function can get called too frequently and exhaust the retry credits to check link status. This change makes sure link handling periodic function is not called in interrupt context. Fixes: 540a211084a7 (

[dpdk-dev] [PATCH 3/5] net/bnx2x: fix to disable further interrupts

2018-09-19 Thread Mody, Rasesh
Fix to disable further fastpath/slowpath interrupts. These will be enabled again by their respective handlers Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/driv

Re: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity

2018-09-19 Thread Mody, Rasesh
>From: Stephen Hemminger >Sent: Tuesday, September 18, 2018 8:07 AM > >On Tue, 18 Sep 2018 11:40:28 +0200 >Thomas Monjalon wrote: > >> 25/07/2018 20:20, Stephen Hemminger: >> > No need for profanity in comments. >> > >> > Signed-off-by: Stephen Hemminger >> > --- >> > drivers/net/bnx2x/elink.c

Re: [dpdk-dev] 17.11.4 patches review and test

2018-08-20 Thread Mody, Rasesh
>From: dev On Behalf Of Marco Varlese >Sent: Monday, August 20, 2018 2:21 AM > >Hi, > >The code in 17.11.4-rc1 does not compile for me. This needs to be fixed for 17.11.4 as rte_eth_linkstatus_set() is not available in DPDK 17.11.x. Will send a patch with fix. Thanks! -Rasesh >Please, see belo

Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix to poll link status

2018-08-02 Thread Mody, Rasesh
Hi Thomas, >From: Thomas Monjalon >Sent: Thursday, August 02, 2018 12:58 PM > >Hi, > >There is a compilation error with this patch: > Sending v2 series to address it, please apply. Thanks! -Rasesh >25/07/2018 00:25, Rasesh Mody: >> + PMD_DRV_LOG(ERR, sc, "Unable to start

Re: [dpdk-dev] [PATCH v2] net/bnx2x: move SPDX tags to source files

2018-07-16 Thread Mody, Rasesh
Hi Hemant, > From: Hemant [mailto:hemant.agra...@nxp.com] > Sent: Sunday, July 15, 2018 11:30 PM > > Hi Rasesh > > On 7/14/2018 7:03 AM, Rasesh Mody wrote: > > diff --git a/drivers/net/bnx2x/bnx2x_stats.h > > b/drivers/net/bnx2x/bnx2x_stats.h index 6fcaf60..107ef20 100644 > > --- a/drivers/net/bn

Re: [dpdk-dev] [PATCH] net/bnx2x: move SPDX tags to source files

2018-07-10 Thread Mody, Rasesh
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, July 09, 2018 2:07 PM > > Hi, > > 08/07/2018 07:24, Rasesh Mody: > > We were using LICENSE.bnx2x_pmd to reference inclusion of SPDX > > licensing tag from all the source file. Remove the LICENSE.bnx2x_pmd > > file and directly i

Re: [dpdk-dev] [PATCH] net/qede: move SPDX tags to source files

2018-07-10 Thread Mody, Rasesh
> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Sunday, July 08, 2018 11:40 PM > > Hi Rasesh, > There is a problem with these patches. > > The SPDX shall be first line for *.c, *.h and Makefiles. It shall come before > the > copyright statements. I will send a v2 with the

Re: [dpdk-dev] [PATCH] doc: update qede management firmware guide

2018-06-27 Thread Mody, Rasesh
Hi Ferruh, > From: Mody, Rasesh > Sent: Friday, June 08, 2018 11:50 AM > > > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > > Sent: Friday, June 08, 2018 11:10 AM > > > > On 6/1/2018 11:57 PM, Rasesh Mody wrote: > > > Fixes: c49a438fce90 ("do

Re: [dpdk-dev] [PATCH] doc: update qede management firmware guide

2018-06-08 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, June 08, 2018 11:10 AM > > On 6/1/2018 11:57 PM, Rasesh Mody wrote: > > Fixes: c49a438fce90 ("doc: update qede guide and features") > > Fixes: db86fbe54d90 ("doc: update qede PMD NIC guide") > > Cc: sta...@dpdk.org > > > > Signed

Re: [dpdk-dev] [PATCH] net/qede: fix L2-handles used for RSS hash update

2018-06-05 Thread Mody, Rasesh
> From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Tuesday, June 05, 2018 9:42 AM > > On 06/05/2018 05:16 PM, Mody, Rasesh wrote: > >> From: Kevin Traynor [mailto:ktray...@redhat.com] > >> Sent: Tuesday, June 05, 2018 6:40 AM > >> > >> On 0

Re: [dpdk-dev] [PATCH] net/qede: fix L2-handles used for RSS hash update

2018-06-05 Thread Mody, Rasesh
> From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Tuesday, June 05, 2018 6:40 AM > > On 06/01/2018 06:16 PM, Rasesh Mody wrote: > > Fix fast path array index which is used for passing L2 handles to RSS > > indirection table. Currently, it is using the local copy of > > indirection table.

Re: [dpdk-dev] [PATCH] net/qede: fix slow path completion timeout

2018-05-24 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, May 24, 2018 10:22 AM > > On 5/23/2018 7:48 PM, Rasesh Mody wrote: > > From: Shahed Shaikh > > > > In 100G mode, we poll firmware slow path completion for every 1 > > second, which is not enough and may result in c

Re: [dpdk-dev] [PATCH 1/2] net/qede: change copyright info to Cavium

2018-05-23 Thread Mody, Rasesh
Hi Thomas, This patchset depends on https://dpdk.org/dev/patchwork/patch/40361/ Thanks! -Rasesh > From: Mody, Rasesh > Sent: Wednesday, May 23, 2018 1:57 PM > > Signed-off-by: Rasesh Mody > --- > drivers/net/qede/LICENSE.qede_pmd |2 +- > driv

Re: [dpdk-dev] [PATCH 1/2] net/qede: fix to update VF MTU

2018-05-23 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, May 23, 2018 8:48 AM > > On 5/23/2018 12:16 AM, Rasesh Mody wrote: > > This patch fixes VF MTU update to work without having to restart the > > vport and there by not requiring port re-configuration. It adds a VF >

Re: [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison

2018-05-15 Thread Mody, Rasesh
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, May 15, 2018 7:46 AM > > 15/05/2018 00:16, Mody, Rasesh: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > > > Sent: Sunday, May 13, 2018 10:05 PM > > > > > &

Re: [dpdk-dev] [PATCH v3 1/4] net/bnx2x: do not cast function pointers as a policy

2018-05-15 Thread Mody, Rasesh
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > Sent: Sunday, May 13, 2018 10:04 PM > > This is stopping the compiler telling you when you have done something > stupid... that is something none of us can afford... > > Now gcc 8.x can tell you did something stupid despite tryin

Re: [dpdk-dev] [PATCH v3 4/4] net/bnx2x: solve overruns

2018-05-15 Thread Mody, Rasesh
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > Sent: Sunday, May 13, 2018 10:05 PM > > Signed-off-by: Andy Green > Fixes: 540a211084a7 ("bnx2x: driver core") > Cc: sta...@dpdk.org > Acked-by: Pablo de Lara > --- Acked-by: Rasesh Mody

Re: [dpdk-dev] [PATCH 1/5] net/qede: convert to new Rx/Tx offloads API

2018-05-15 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, May 14, 2018 5:53 AM > > On 5/11/2018 10:16 AM, Andrew Rybchenko wrote: > > On 03/28/2018 03:15 AM, Rasesh Mody wrote: > >> From: Harish Patil > >> > >> Ethdev RX/TX offloads API has changed since: > >> commit ce17eddefc20 ("eth

Re: [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison

2018-05-14 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, May 14, 2018 4:17 AM > To: Andy Green ; dev@dpdk.org; Patil, Harish > ; Mody, Rasesh > Subject: Re: [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable > comparison > > On 5/14/2018 6:04 AM, And

Re: [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison

2018-05-14 Thread Mody, Rasesh
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andy Green > Sent: Sunday, May 13, 2018 10:05 PM > > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c: > In function ‘elink_check_kr2_wa’: > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:12922:28: > error: bitwise comparison always

Re: [dpdk-dev] [PATCH 00/14] net/qede/base: update PMD version to 2.8.0.1

2018-04-08 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, April 06, 2018 2:03 AM > To: Mody, Rasesh ; dev@dpdk.org > Cc: Dept-Eng DPDK Dev > Subject: Re: [PATCH 00/14] net/qede/base: update PMD version to 2.8.0.1 > > On 4/1/2018 6:46 AM, Rase

Re: [dpdk-dev] [PATCH] net/bnx2x: convert to new Rx offloads API

2018-04-07 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, April 05, 2018 6:40 AM > > On 4/1/2018 7:03 AM, Rasesh Mody wrote: > > From: Harish Patil > > > > Ethdev RX offloads API has changed since: > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > > > > This patch

Re: [dpdk-dev] [PATCH] [18.02-rc2] net/qede: remove VF Tx switch option

2018-01-12 Thread Mody, Rasesh
> From: Mody, Rasesh > Sent: Thursday, January 11, 2018 11:03 AM > To: 'Ferruh Yigit' ; Thomas Monjalon > ; Patil, Harish > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] [18.02-rc2] net/qede: remove VF Tx switch > option > > Hi Ferruh, > > &

Re: [dpdk-dev] [PATCH] [18.02-rc2] net/qede: remove VF Tx switch option

2018-01-11 Thread Mody, Rasesh
Hi Ferruh, > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, January 11, 2018 9:50 AM > > On 11/8/2017 12:41 AM, Thomas Monjalon wrote: > > The compile-time option CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH > > has been added just before the 17.11 release. > > Such ne

Re: [dpdk-dev] [PATCH v2 3/3] net/qede: add support for GENEVE tunneling offload

2017-12-15 Thread Mody, Rasesh
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Friday, December 15, 2017 4:19 PM > > On 12/15/2017 1:12 PM, Mody, Rasesh wrote: > > Hi Ferruh, > > > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > >> Sent: Frida

Re: [dpdk-dev] [PATCH v2 3/3] net/qede: add support for GENEVE tunneling offload

2017-12-15 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, December 15, 2017 1:02 PM > To: Mody, Rasesh > > On 12/13/2017 10:36 PM, Rasesh Mody wrote: > > From: Shahed Shaikh > > > > This patch refactors existing VXLAN tunneling offlo

Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option

2017-11-09 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, November 09, 2017 5:07 PM > > On 11/9/2017 3:16 PM, Patil, Harish wrote: > > -Original Message- > > From: Ferruh Yigit > > Date: Thursday, November 9, 2017 at 4:07 PM > &

Re: [dpdk-dev] [PATCH] igb_uio: prevent reset for a list of devices

2017-11-03 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, November 03, 2017 3:38 PM > > Some devices are having problem on device reset that happens during DPDK > application exit [1]. > > Create a static list of devices and exclude them from device reset. > > [1] > http://dpdk.org/ml

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-11-03 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, November 02, 2017 5:32 PM > > On 11/2/2017 11:45 AM, Mody, Rasesh wrote: > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > >> Sent: Thursday, November 02, 2017 11:10 AM > >> &

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-11-02 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, November 02, 2017 11:10 AM > > On 11/2/2017 10:34 AM, Mody, Rasesh wrote: > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > >> Sent: Thursday, November 02, 2017 1:55 AM > >>

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-11-02 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, November 02, 2017 1:55 AM > > On 11/2/2017 1:03 AM, Mody, Rasesh wrote: > >> From: Stephen Hemminger [mailto:step...@networkplumber.org] > >> Sent: Wednesday, November 01, 2017 7:12 AM > &g

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-11-02 Thread Mody, Rasesh
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, November 01, 2017 7:12 AM > > On Wed, 1 Nov 2017 06:58:53 +0000 > "Mody, Rasesh" wrote: > > > Hi Jianfeng and Ferruh, > > > > > From: Ferruh Yigit [mailto:ferruh.

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-10-31 Thread Mody, Rasesh
Hi Jianfeng and Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, October 26, 2017 5:50 PM > > On 10/26/2017 2:28 AM, Tan, Jianfeng wrote: > > Hi Rasesh, > > > > > > On 10/26/2017 7:43 AM, Mody, Rasesh wrote: > >> Hi

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-10-25 Thread Mody, Rasesh
Hi Ferruh, > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Friday, October 20, 2017 9:58 AM > > On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > > Remove device reset during application start, the reset for > > application exit still there. > > > > Reset in open removed be

Re: [dpdk-dev] [PATCH 1/7] net/qede/base: fix recovery from previous ungraceful exit

2017-08-04 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, July 31, 2017 10:53 AM > To: Mody, Rasesh ; dev@dpdk.org > Cc: Dept-Eng DPDK Dev ; Thomas > Monjalon > Subject: Re: [dpdk-dev] [PATCH 1/7] net/qede/base: fix recovery from > previous ungraceful exit >

Re: [dpdk-dev] [PATCH 5/7] doc: list NPAR as supported feature in qede

2017-08-04 Thread Mody, Rasesh
> From: Rasesh Mody [mailto:rasesh.m...@cavium.com] > Sent: Monday, July 24, 2017 3:19 AM > > From: Shahed Shaikh > > Existing qede PMD code already supports NPAR feature. > So adding this in "Supported Features" section after testing it with latest > DPDK. > > Also, add myself to the list of m

Re: [dpdk-dev] [INTERNAL REVIEW 1/7] net/qede/base: fix recovery from previous ungraceful exit

2017-07-24 Thread Mody, Rasesh
Please ignore this patch-set with 'INTERNAL REVIEW' subject prefix. Sending a follow up with proper subject prefix. Thanks! -Rasesh > -Original Message- > From: Rasesh Mody [mailto:rasesh.m...@cavium.com] > Sent: Monday, July 24, 2017 3:10 AM > To: dev@dpdk.org >

Re: [dpdk-dev] [PATCH v2 0/8] net/qede: update PMD to 2.5.1.1

2017-07-08 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, July 05, 2017 3:02 AM > > On 7/1/2017 8:29 PM, Rasesh Mody wrote: > > Hi Ferruh, > > > > This patch set contains minor enhancements and bug fixes for QEDE PMD. > > It updates the driver version to 2.5.1.1. The patch set is tes

Re: [dpdk-dev] [PATCH 8/9] net/qede: use newer packet mbuf allocate API

2017-07-01 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, June 29, 2017 5:55 AM > > On 6/29/2017 10:51 AM, Rasesh Mody wrote: > > Use rte_pktmbuf_alloc() API instead of rte_mbuf_raw_alloc(). > > > > Signed-off-by: Rasesh Mody > > --- > > drivers/net/qede/qede_rxtx.c |

Re: [dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions

2017-06-28 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, June 28, 2017 9:01 AM > To: Alexey Kardashevskiy ; Mody, Rasesh > ; dev@dpdk.org > Cc: Patil, Harish > Subject: Re: [dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions > > On 4

Re: [dpdk-dev] [PATCH 6/7] mbuf: introduce new Tx offload flag for MPLS-in-UDP

2017-06-07 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, June 01, 2017 12:44 PM > > On 6/1/2017 7:59 PM, Patil, Harish wrote: > >> > > > >> On 5/28/2017 9:37 AM, Rasesh Mody wrote: > >>> From: Harish Patil > >>> > >>> Some PMDs need to know the tunnel type in order to handle advance

Re: [dpdk-dev] [PATCH] net/qede: fix RSS table entries for 100G adapter

2017-05-08 Thread Mody, Rasesh
Hi Thomas, > From: Rasesh Mody [mailto:rasesh.m...@cavium.com] > Sent: Sunday, May 07, 2017 3:53 PM > > With the change in base APIs the logic for 100G handling needs to be > adjusted to pass cid values instead for queue ids. The current API works > assuming its queue id. > > Fixes: 69d7ba88f1a1

Re: [dpdk-dev] [dpdk-stable] [PATCH 11/11] net/qede: fix to limit CFLAGS to base files

2017-05-06 Thread Mody, Rasesh
> From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Wednesday, May 03, 2017 7:11 PM > > On Thu, May 04, 2017 at 12:14:30AM +, Mody, Rasesh wrote: > > > > > > > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > > > Sent: Monday

Re: [dpdk-dev] [dpdk-stable] [PATCH 11/11] net/qede: fix to limit CFLAGS to base files

2017-05-03 Thread Mody, Rasesh
> From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Monday, May 01, 2017 11:15 PM > > On Tue, Apr 25, 2017 at 12:28:46AM -0700, Rasesh Mody wrote: > > From: Rasesh Mody > > > > Changes included in this fix > > - limit CFLAGS to base files > > - fix to remove/mark unused members >

Re: [dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions

2017-04-28 Thread Mody, Rasesh
Hi Alexey, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, April 26, 2017 2:18 AM > > On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote: > > Recent kernels/distros have updated firmware images, use them. > > In order to keep support of older distros (such as Fedora 19 or Ub

Re: [dpdk-dev] [PATCH v4 31/62] net/qede/base: revise tunnel APIs/structs

2017-03-29 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, March 29, 2017 2:23 AM > > On 3/28/2017 10:18 PM, Mody, Rasesh wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > >> Sent: Tuesday, March 28, 2017 4:23 AM > >

Re: [dpdk-dev] [PATCH 1/3] net/qede: fix missing UDP protocol in RSS offload types

2017-03-28 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, March 28, 2017 5:19 AM > > On 3/24/2017 7:40 AM, Rasesh Mody wrote: > > From: Harish Patil > > > > Both UDP and TCP based RSS offload types are supported by the device. > > This patch adds UDP protocol which got missed out in t

Re: [dpdk-dev] [PATCH v4 31/62] net/qede/base: revise tunnel APIs/structs

2017-03-28 Thread Mody, Rasesh
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Tuesday, March 28, 2017 4:23 AM > > On 3/28/2017 7:52 AM, Rasesh Mody wrote: > > Revise tunnel APIs/structs. > > - Unite tunnel start and update params in single struct > >"ecore_tunnel_info" > > - Remove A0 chip tun

Re: [dpdk-dev] [PATCH v7 1/7] qede: add base driver

2017-03-28 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, March 28, 2017 4:16 AM > > On 4/27/2016 3:18 PM, rasesh.mody at qlogic.com (Rasesh Mody) wrote: > > The base driver is the backend module for the QLogic FastLinQ QL4 > > 25G/40G CNA family of adapters as well as t

Re: [dpdk-dev] [PATCH 00/62] net/qede/base: update PMD to 2.4.0.1

2017-03-27 Thread Mody, Rasesh
Please ignore this as it doesn't have subject prefix v4. > From: y...@qlogic.com [mailto:y...@qlogic.com] > Sent: Monday, March 27, 2017 11:41 PM > > From: Rasesh Mody > > Hi Ferruh, > > This patch set adds support for new firmware 8.18.9.0, adds new features > and includes bug fixes. This pat

Re: [dpdk-dev] [PATCH v2 61/61] net/qede: add LRO/TSO offloads support

2017-03-24 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, March 24, 2017 4:59 AM > > On 3/18/2017 7:06 AM, Rasesh Mody wrote: > > From: Harish Patil > > > > This patch includes slowpath configuration and fastpath changes to > > support LRO and TSO. A bit of revamping is needed in order

Re: [dpdk-dev] [PATCH v3 41/61] net/qede/base: add support for previous driver unload

2017-03-24 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, March 24, 2017 4:01 AM > > On 3/24/2017 7:28 AM, Rasesh Mody wrote: > > New driver/management fw load request sequence for handling previous > > driver unload. > > > > Signed-off-by: Rasesh Mody > > Hi Rasesh, > > P

Re: [dpdk-dev] [PATCH v2 00/61] net/qede/base: qede PMD enhancements

2017-03-24 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, March 20, 2017 9:59 AM > To: Mody, Rasesh ; dev@dpdk.org > Cc: Dept-Eng DPDK Dev > Subject: Re: [PATCH v2 00/61] net/qede/base: qede PMD enhancements > > On 3/18/2017 7:05 AM, Rasesh Mody wrote:

Re: [dpdk-dev] [PATCH 00/61] net/qede/base: qede PMD enhancements

2017-03-18 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, March 03, 2017 2:25 AM > > On 2/27/2017 7:56 AM, Rasesh Mody wrote: > > Hi, > > > > This patch set adds support for new firmware 8.18.9.0, new features > > and bug fixes. > > This looks like depends other qede driver patchset [1

Re: [dpdk-dev] [PATCH 02/21] net/qede/base: fix to set pointers to NULL after freeing

2017-03-18 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, March 02, 2017 5:05 AM > > On 2/27/2017 7:51 AM, Rasesh Mody wrote: > > Set pointers to NULL after freeing the allocations on ecore_resc_free(). > > > > Fixes: 26ae839d06e9 ("qede: add DCBX support") > > Fixes: ec94dbc57362 ("q

Re: [dpdk-dev] [PATCH 01/21] net/qede/base: fix incorrect typecasting of flag

2017-03-06 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, March 02, 2017 5:04 AM > > On 2/27/2017 7:51 AM, Rasesh Mody wrote: > > dcbx-update-flag is incorrectly converted to boolean before assigining > > it to ramrod data, fix this typecasting. Also, added more debug > > messages in

Re: [dpdk-dev] net/qede/base: build is broken on FreeBSD 11.0 with clang 3.8.0

2017-01-17 Thread Mody, Rasesh
> From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Tuesday, January 17, 2017 7:00 AM > > Hi, > > build is broken for me on FreeBSD 11.0. Just default config and gmake: > > == Build drivers/net/qede >CC base/ecore_dev.o >CC base/ecore_hw.o >CC base/ecore_cxt.o > /tmp/

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/5] net/qede: fix scatter-gather issue

2017-01-05 Thread Mody, Rasesh
> From: Harish Patil [mailto:harish.pa...@qlogic.com] > Sent: Thursday, January 05, 2017 1:12 PM > > > > >On 12/31/2016 8:16 AM, Rasesh Mody wrote: > >> From: Harish Patil > >> > >> - Make qede_process_sg_pkts() inline and add unlikely check > >> - Fix mbuf segment chaining logic in qede_proces

Re: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes

2017-01-04 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, January 03, 2017 7:41 AM > > On 12/31/2016 7:41 AM, Mody, Rasesh wrote: > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > >> Sent: Friday, December 23, 2016 7:42 AM > >> >

Re: [dpdk-dev] [PATCH 23/25] net/qede/base: semantic/formatting changes

2016-12-30 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, December 23, 2016 7:42 AM > > On 12/3/2016 9:11 AM, Rasesh Mody wrote: > > This patch consists of semantic/formatting changes. It also includes > > comment additions. > > As far as I can see majority of the changes are formattin

Re: [dpdk-dev] [PATCH 22/25] net/qede/base: add support for new firmware

2016-12-30 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, December 23, 2016 7:40 AM > > On 12/3/2016 9:11 AM, Rasesh Mody wrote: > > Add support for 8.14.x.x firmware. > > Is it possible to list what has been changed with new FW here? The new firmware adds support for exte

  1   2   >