Re: [dpdk-dev] [PATCH v2 3/3] ethdev: remove vxlan and nvgre encapsulation commands

2018-10-05 Thread Mohammad Abdul Awal
: Mohammad Abdul Awal

Re: [dpdk-dev] [PATCH] doc: add deprecation notice to remove rte meter color

2019-01-21 Thread Mohammad Abdul Awal
currently replicated in many places, + such as: rte_meter.h, rte_mtr.h, rte_tm.h. Acked-by: Mohammad Abdul Awal

Re: [dpdk-dev] [PATCH] doc: security deprecation notice for session changes

2018-11-14 Thread Mohammad Abdul Awal
security session. Acked-by: Mohammad Abdul Awal

Re: [dpdk-dev] [PATCH 3/9] net: add ESP trailer structure definition

2018-11-16 Thread Mohammad Abdul Awal
_((__packed__)); +/** + * ESP Trailer + */ +struct esp_tail { + uint8_t pad_len; /**< number of pad bytes (0-255) */ + uint8_t next_proto; /**< IPv4 or IPv6 or next layer header */ +} __attribute__((__packed__)); + #ifdef __cplusplus } #endif Acked-by: Mohammad Abdul Awal

Re: [dpdk-dev] [PATCH 1/9] cryptodev: add opaque userdata pointer into crypto sym session

2018-11-16 Thread Mohammad Abdul Awal
/ }; Acked-by: Mohammad Abdul Awal

Re: [dpdk-dev] [PATCH 2/9] security: add opaque userdata pointer into security session

2018-11-16 Thread Mohammad Abdul Awal
{ struct rte_security_session { void *sess_private_data; /**< Private session material */ + uint64_t opaque_data; + /**< Opaque user defined data */ }; /** Acked-by: Mohammad Abdul Awal

Re: [dpdk-dev] [PATCH] doc: deprecation notice for sched API change

2018-11-21 Thread Mohammad Abdul Awal
ced in v18.05, ``RTE_MBUF_INDIRECT()`` Acked-by: Mohammad Abdul Awal

Re: [dpdk-dev] [PATCH v2 3/9] net: add ESP trailer structure definition

2018-12-04 Thread Mohammad Abdul Awal
_((__packed__)); +/** + * ESP Trailer + */ +struct esp_tail { + uint8_t pad_len; /**< number of pad bytes (0-255) */ + uint8_t next_proto; /**< IPv4 or IPv6 or next layer header */ +} __attribute__((__packed__)); + #ifdef __cplusplus } #endif Acked-by: Mohammad Abdul Awal

Re: [dpdk-dev] [PATCH v2 2/9] security: add opaque userdata pointer into security session

2018-12-04 Thread Mohammad Abdul Awal
{ struct rte_security_session { void *sess_private_data; /**< Private session material */ + uint64_t opaque_data; + /**< Opaque user defined data */ }; /** Acked-by: Mohammad Abdul Awal

Re: [dpdk-dev] [PATCH v2 1/9] cryptodev: add opaque userdata pointer into crypto sym session

2018-12-04 Thread Mohammad Abdul Awal
/ }; Acked-by: Mohammad Abdul Awal

[dpdk-dev] [PATCH 1/3] ethdev: fix null pointer checking

2019-04-03 Thread Mohammad Abdul Awal
Null value for parameter name will cause segfault for the strnlen and strcmp functions. Fixes: 0b33b68d12 ("ethdev: export allocate function") Fixes: 942661004c ("ethdev: export secondary attach function") Cc: sta...@dpdk.org Signed-off-by: Mohammad Abdul Awal --

[dpdk-dev] [PATCH 3/3] vhost: fix null pointer checking

2019-04-03 Thread Mohammad Abdul Awal
ce API to fetch negotiated features") Fixes: eb32247457 ("vhost: export guest memory regions") Fixes: 40ef286f23 ("vhost: export vhost vring info") Fixes: bd2e0c3fe5 ("vhost: add APIs for live migration") Fixes: 0b8572a0c1 ("vhost: add external message ha

[dpdk-dev] [PATCH 2/3] net/virtio: fix null pointer checking

2019-04-03 Thread Mohammad Abdul Awal
Null value of device name should return error without further processing. Fixes: 1c8489da56 ("net/virtio-user: fix multi-process support") Signed-off-by: Mohammad Abdul Awal --- drivers/net/virtio/virtio_user_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/

Re: [dpdk-dev] [PATCH 1/3] ethdev: fix null pointer checking

2019-04-04 Thread Mohammad Abdul Awal
mas Monjalon wrote: >>> 03/04/2019 18:07, Mohammad Abdul Awal: >>>> Null value for parameter name will cause segfault for the strnlen and >>>> strcmp functions. >>> >>> I'm not sure we want such obvious checks for all

[dpdk-dev] [PATCH v2] vhost: fix null pointer checking

2019-04-04 Thread Mohammad Abdul Awal
") Fixes: b4953225ce ("vhost: add APIs for datapath configuration") Cc: sta...@dpdk.org Signed-off-by: Mohammad Abdul Awal --- lib/librte_vhost/socket.c | 2 +- lib/librte_vhost/vdpa.c | 5 - lib/librte_vhost/vhost.c | 16 3 files changed, 13 insertions(+),

Re: [dpdk-dev] [PATCH 2/3] net/virtio: fix null pointer checking

2019-04-04 Thread Mohammad Abdul Awal
On 04/04/2019 07:22, Tiwei Bie wrote: On Wed, Apr 03, 2019 at 05:08:11PM +0100, Mohammad Abdul Awal wrote: Null value of device name should return error without further processing. Fixes: 1c8489da56 ("net/virtio-user: fix multi-process support") Signed-off-by: Mohammad

[dpdk-dev] [PATCH v3] vhost: fix null pointer checking

2019-04-11 Thread Mohammad Abdul Awal
PI") Fixes: b4953225ce ("vhost: add APIs for datapath configuration") Fixes: 5fbb3941da ("vhost: introduce driver features related APIs") Fixes: 292959c719 ("vhost: cleanup unix socket") Cc: sta...@dpdk.org Signed-off-by: Mohammad Abdul Awal --- v3: fixed per review com

Re: [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

2018-07-02 Thread Mohammad Abdul Awal
11:11:11:11:11:11 22:22:22:22:22:22 flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end This also replace the proposal done by Mohammad Abdul Awal [1] which handles in a more complex way for the same work. Note this API has already a modification planned for 18.11 [2

Re: [dpdk-dev] [PATCH v8 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

2018-07-05 Thread Mohammad Abdul Awal
udp-dst 4 ip-src ::1 ip-dst :: vlan-tci 34 eth-src 11:11:11:11:11:11 eth-dst 22:22:22:22:22:22 flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end This also replace the proposal done by Mohammad Abdul Awal [1] which handles in a more

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: add VXLAN encap/decap support

2018-07-05 Thread Mohammad Abdul Awal
cap / +queue index 0 / end + + testpmd> set vxlan-with-vlan ip-version ipv4 vni 4 udp-src 4 udp-dst 4 ip-src + 127.0.0.1 ip-dst 128.0.0.1 vlan-tci 34 eth-src 11:11:11:11:11:11 + eth-dst 22:22:22:22:22:22 + testpmd> flow create 0 ingress pattern end actions vxlan_encap / + queue index 0 / end + +IPv6 VXLAN outer header:: + + testpmd> set vxlan ip-version ipv6 vni 4 udp-src 4 udp-dst 4 ip-src ::1 +ip-dst :: eth-src 11:11:11:11:11:11 eth-dst 22:22:22:22:22:22 + testpmd> flow create 0 ingress pattern end actions vxlan_encap / + queue index 0 / end + + testpmd> set vxlan-with-vlan ip-version ipv6 vni 4 udp-src 4 udp-dst 4 + ip-src ::1 ip-dst :: vlan-tci 34 eth-src 11:11:11:11:11:11 + eth-dst 22:22:22:22:22:22 + testpmd> flow create 0 ingress pattern end actions vxlan_encap / + queue index 0 / end + BPF Functions -- Tested-by: Mohammad Abdul Awal Acked-by: Mohammad Abdul Awal

Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: add NVGRE encap/decap support

2018-07-05 Thread Mohammad Abdul Awal
owing commands + +IPv4 NVGRE outer header:: + + testpmd> set nvgre ip-version ipv4 tni 4 ip-src 127.0.0.1 ip-dst 128.0.0.1 +eth-src 11:11:11:11:11:11 eth-dst 22:22:22:22:22:22 + testpmd> flow create 0 ingress pattern end actions nvgre_encap / +queue index 0 / end + + testpmd> set nvgre-with-vlan ip-version ipv4 tni 4 ip-src 127.0.0.1 + ip-dst 128.0.0.1 vlan-tci 34 eth-src 11:11:11:11:11:11 + eth-dst 22:22:22:22:22:22 + testpmd> flow create 0 ingress pattern end actions nvgre_encap / + queue index 0 / end + +IPv6 NVGRE outer header:: + + testpmd> set nvgre ip-version ipv6 tni 4 ip-src ::1 ip-dst :: +eth-src 11:11:11:11:11:11 eth-dst 22:22:22:22:22:22 + testpmd> flow create 0 ingress pattern end actions nvgre_encap / +queue index 0 / end + + testpmd> set nvgre-with-vlan ip-version ipv6 tni 4 ip-src ::1 ip-dst :: +vlan-tci 34 eth-src 11:11:11:11:11:11 eth-dst 22:22:22:22:22:22 + testpmd> flow create 0 ingress pattern end actions nvgre_encap / +queue index 0 / end + BPF Functions -- Tested-by: Mohammad Abdul Awal Acked-by: Mohammad Abdul Awal

[dpdk-dev] [PATCH] app/testpmd: enabled vxlan and nvgre encap/decap support for rte_flow

2018-05-09 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal --- app/test-pmd/cmdline_flow.c | 872 1 file changed, 872 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 5754e78..7d80f2a 100644 --- a/app/test-pmd/cmdline_flow.c +++ b

Re: [dpdk-dev] [PATCH] app/testpmd: enabled vxlan and nvgre encap/decap support for rte_flow

2018-05-11 Thread Mohammad Abdul Awal
Hi Bernard, On 10/05/2018 13:47, Iremonger, Bernard wrote: Hi Awal, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mohammad Abdul Awal Sent: Wednesday, May 9, 2018 5:57 PM To: dev@dpdk.org Cc: Awal, Mohammad Abdul Subject: [dpdk-dev] [PATCH] app/testpmd

Re: [dpdk-dev] [PATCH] net/i40e: fix missing Port Representor data-path callbacks

2018-05-11 Thread Mohammad Abdul Awal
On 09/05/2018 16:00, Remy Horton wrote: This patch adds Rx and Tx burst functions to the i40e Port Representors, so that the implementation within this PMD can be tested using applications such as testpmd which require data-path functionality. Fixes: e0cb96204b71 ("net/i40e: add support for re

Re: [dpdk-dev] [DPDK] net/ixgbe: fix missing Port Representor data-path callbacks

2018-05-11 Thread Mohammad Abdul Awal
On 09/05/2018 16:00, Remy Horton wrote: This patch adds Rx and Tx burst functions to the ixgbe Port Representors, so that the implementation within ixgbe PMD can be tested using applications such as testpmd which require data-path functionality. Fixes: cf80ba6e2038 ("net/ixgbe: add support for

Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix missing Port Representor data-path

2018-05-11 Thread Mohammad Abdul Awal
tx_burst; vf = &pf->vfs[representor->vf_id]; Acked-by: Mohammad Abdul Awal

Re: [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix missing Port Representor data-path

2018-05-11 Thread Mohammad Abdul Awal
ethdev->rx_pkt_burst = ixgbe_vf_representor_rx_burst; + ethdev->tx_pkt_burst = ixgbe_vf_representor_tx_burst; /* Setting the number queues allocated to the VF */ ethdev->data->nb_rx_queues = IXGBE_VF_MAX_RX_QUEUES; Acked-by: Mohammad Abdul Awal

[dpdk-dev] [PATCH v2 0/2] Added vxlan/nvgre encap/decap support to testpmd

2018-05-11 Thread Mohammad Abdul Awal
. We have also updated the testpmd user guide documentation with how to used new action types RTE_FLOW_ACTION_VXLAN_ENCAP, RTE_FLOW_ACTION_VXLAN_DECAP, RTE_FLOW_ACTION_NVGRE_ENCAP, RTE_FLOW_ACTION_NVGRE_DECAP capabilities. Mohammad Abdul Awal (2): app/testpmd: enabled vxlan and nvgre encap/decap

[dpdk-dev] [PATCH v2 1/2] app/testpmd: enabled vxlan and nvgre encap/decap support for rte_flow

2018-05-11 Thread Mohammad Abdul Awal
We have enabled testpmd application with ability to create a flow with vxlan/nvgre tunnel types and with encapsulation/decapsulation functionalities. Signed-off-by: Mohammad Abdul Awal --- app/test-pmd/cmdline_flow.c | 937 1 file changed, 937

[dpdk-dev] [PATCH v2 2/2] doc/guides: updated testpmd app user guide for vxlan/nvgre encap/decap

2018-05-11 Thread Mohammad Abdul Awal
Updated the testpmd user guide documentation with how to used new action types RTE_FLOW_ACTION_VXLAN_ENCAP, RTE_FLOW_ACTION_VXLAN_DECAP, RTE_FLOW_ACTION_NVGRE_ENCAP, RTE_FLOW_ACTION_NVGRE_DECAP capabilities. Signed-off-by: Mohammad Abdul Awal --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 50

Re: [dpdk-dev] [PATCH v2 2/2] doc/guides: updated testpmd app user guide for vxlan/nvgre encap/decap

2018-05-14 Thread Mohammad Abdul Awal
ties. Signed-off-by: Mohammad Abdul Awal --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 50 + 1 file changed, 50 insertions(+) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 542c217..6ee3ff3 100

[dpdk-dev] [PATCH 1/2] doc: add port representor update in release notes

2018-05-28 Thread Mohammad Abdul Awal
Change-Id: I21f59c0e540577970c2f3bb8fcd6536fb1ccaefb Signed-off-by: Mohammad Abdul Awal --- doc/guides/rel_notes/release_18_05.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index e8d74f507

[dpdk-dev] [PATCH 2/2] doc: add vxlan and nvgre tunnel update in release notes

2018-05-28 Thread Mohammad Abdul Awal
Change-Id: Ibcb8d2343db7f3ac8346dd2ac73ff93e026e0431 Signed-off-by: Mohammad Abdul Awal --- doc/guides/rel_notes/release_18_05.rst | 17 + 1 file changed, 17 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index

[dpdk-dev] [PATCH 2/2] doc: add vxlan and nvgre tunnel update in release notes

2018-05-28 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal --- doc/guides/rel_notes/release_18_05.rst | 17 + 1 file changed, 17 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index 511d51908..37d102572 100644 --- a/doc/guides/rel_notes

[dpdk-dev] [PATCH 1/2] doc: add port representor update in release notes

2018-05-28 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal --- doc/guides/rel_notes/release_18_05.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index e8d74f507..511d51908 100644 --- a/doc/guides/rel_notes

Re: [dpdk-dev] [PATCH v2 2/2] doc/guides: updated testpmd app user guide for vxlan/nvgre encap/decap

2018-06-18 Thread Mohammad Abdul Awal
Hi Ferruh, On 14/06/2018 18:19, Ferruh Yigit wrote: On 6/14/2018 6:14 PM, Ferruh Yigit wrote: On 5/14/2018 4:42 PM, Mohammad Abdul Awal wrote: On 14/05/2018 11:35, Iremonger, Bernard wrote: Hi Awal, -Original Message- From: Awal, Mohammad Abdul Sent: Friday, May 11, 2018 6:14 PM

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN encap/decap support

2018-06-18 Thread Mohammad Abdul Awal
Hi Nelio, On 18/06/2018 09:52, Nelio Laranjeiro wrote: Due to the complex VXLAN_ENCAP flow action and based on the fact testpmd does not allocate memory, this patch adds a new command in testpmd to initialise a global structure containing the necessary information to make the outer layer of the

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add NVGRE encap/decap support

2018-06-18 Thread Mohammad Abdul Awal
On 18/06/2018 09:52, Nelio Laranjeiro wrote: Due to the complex NVGRE_ENCAP flow action and based on the fact testpmd does not allocate memory, this patch adds a new command in testpmd to initialise a global structure containing the necessary information to make the outer layer of the packet.

Re: [dpdk-dev] [PATCH v4 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

2018-06-22 Thread Mohammad Abdul Awal
Hi Nelio, On 21/06/2018 08:13, Nelio Laranjeiro wrote: This series adds an easy and maintainable configuration version support for those two actions for 18.08 by using global variables in testpmd to store the necessary information for the tunnel encapsulation. Those variables are used in conju

Re: [dpdk-dev] [PATCH v4 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

2018-06-22 Thread Mohammad Abdul Awal
On 22/06/2018 09:31, Nélio Laranjeiro wrote: On Fri, Jun 22, 2018 at 08:42:10AM +0100, Mohammad Abdul Awal wrote: Hi Nelio, On 21/06/2018 08:13, Nelio Laranjeiro wrote: This series adds an easy and maintainable configuration version support for those two actions for 18.08 by using global

Re: [dpdk-dev] [PATCH v4 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

2018-06-22 Thread Mohammad Abdul Awal
On 22/06/2018 10:08, Nélio Laranjeiro wrote: On Fri, Jun 22, 2018 at 09:51:15AM +0100, Mohammad Abdul Awal wrote: On 22/06/2018 09:31, Nélio Laranjeiro wrote: On Fri, Jun 22, 2018 at 08:42:10AM +0100, Mohammad Abdul Awal wrote: Hi Nelio, On 21/06/2018 08:13, Nelio Laranjeiro wrote

Re: [dpdk-dev] [PATCH v4 3/5] drivers/net/i40e: add Port Representor functionality

2018-01-10 Thread Mohammad Abdul Awal
On 10/01/2018 07:56, Xing, Beilei wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Remy Horton + dev_info->rx_offload_capa = + DEV_RX_OFFLOAD_VLAN_STRIP | + DEV_RX_OFFLOAD_QINQ_STRIP | + DEV_RX_OFFLOAD_IPV4_

Re: [dpdk-dev] [PATCH v4 3/5] drivers/net/i40e: add Port Representor functionality

2018-01-10 Thread Mohammad Abdul Awal
On 10/01/2018 12:37, Xing, Beilei wrote: -Original Message- From: Awal, Mohammad Abdul On 10/01/2018 07:56, Xing, Beilei wrote: <...> +static const struct ether_addr null_mac_addr; + +int +rte_pmd_i40e_remove_vf_mac_addr(uint8_t port, uint16_t vf_id, + struct ether_addr *mac_a

Re: [dpdk-dev] [PATCH v4 0/5] lib: add Port Representors

2018-01-10 Thread Mohammad Abdul Awal
On 09/01/2018 22:01, Ferruh Yigit wrote: <...> The port representor infrastructure is enabled through a single common, device independent, virtual PMD whos context is initialized and enabled through a broker instance running within the context of the physical function device driver.> +---

Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add group counter support to rte_flow

2018-04-06 Thread Mohammad Abdul Awal
On 05/04/2018 17:31, Thomas Monjalon wrote: 05/04/2018 15:51, Declan Doherty: +Group Count Query +~ + +Query group counter which can be associated with multiple flows on a specified +port. + +This function allows retrieving of group counters. Data +is gathered by special actions

Re: [dpdk-dev] [PATCH v2 2/4] ethdev: Add vTEP encap/decap actions

2018-04-06 Thread Mohammad Abdul Awal
On 05/04/2018 17:42, Thomas Monjalon wrote: 05/04/2018 15:51, Declan Doherty: +/** + * RTE_FLOW_ACTION_TYPE_VTEP_ENCAP + * + * Virtual tunnel end-point encapsulation action data. + * + * Non-terminating action by default. + */ +struct rte_flow_action_vtep_encap { + struct rte_flow_action_

Re: [dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action items support

2018-04-06 Thread Mohammad Abdul Awal
On 05/04/2018 17:49, Thomas Monjalon wrote: 05/04/2018 15:51, Declan Doherty: +struct rte_flow_item_metadata { + uint32_t id;/**< field identifier */ + uint32_t size; /**< field size */ + uint8_t bytes[];/**< field value */ +}; Spotted C99 syntax

Re: [dpdk-dev] [PATCH v2 4/4] ethdev: Add metadata flow and action items support

2018-04-06 Thread Mohammad Abdul Awal
On 06/04/2018 16:57, Thomas Monjalon wrote: 06/04/2018 15:47, Mohammad Abdul Awal: On 05/04/2018 17:49, Thomas Monjalon wrote: 05/04/2018 15:51, Declan Doherty: +struct rte_flow_item_metadata { + uint32_t id;/**< field identifier */ + uint32_t s

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add group counter support to rte_flow

2018-04-09 Thread Mohammad Abdul Awal
Hi Adrien, On 06/04/2018 21:26, Adrien Mazarguil wrote: On Fri, Apr 06, 2018 at 01:24:00PM +0100, Declan Doherty wrote: Add new RTE_FLOW_ACTION_TYPE_GROUP_COUNT action type to enable shared counters across multiple flows on a single port or across multiple flows on multiple ports within the sa

Re: [dpdk-dev] [PATCH v3 2/4] ethdev: Add tunnel encap/decap actions

2018-04-09 Thread Mohammad Abdul Awal
On 06/04/2018 21:26, Adrien Mazarguil wrote: On Fri, Apr 06, 2018 at 01:24:01PM +0100, Declan Doherty wrote: Add new flow action types and associated action data structures to support the encapsulation and decapsulation of the virtual tunnel endpoints. The RTE_FLOW_ACTION_TYPE_TUNNEL_ENCAP ac

Re: [dpdk-dev] [PATCH v4 2/5] ethdev: introduce new tunnel VXLAN-GPE

2018-04-17 Thread Mohammad Abdul Awal
< VNI (24) + Reserved (8). */ +} __attribute__((__packed__)); minor nit: the field comments could be aligned Once addressed the above comment Acked-by: Mohammad Abdul Awal

Re: [dpdk-dev] [PATCH v4 15/16] ethdev: add physical port action to flow API

2018-04-17 Thread Mohammad Abdul Awal
: - rte_flow_copy() - rte_flow_create() - rte_flow_query() - rte_flow_validate() Signed-off-by: Adrien Mazarguil Acked-by: Andrew Rybchenko Cc: "Zhang, Qi Z" Acked-by: Mohammad Abdul Awal --- app/test-pmd/cmdline_flow.c | 35 app/test-pm

[dpdk-dev] [RFC 0/5] Port Representor for control and monitoring of VF devices

2017-09-07 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- This RFC introduces a port representor based model for the control, management and monitoring of SR-IOV virtual function (VF) devices for control plane applications which have bound the devices

[dpdk-dev] [RFC 1/5] Implemented port representor broker infrastructure, created BDF to port function.

2017-09-07 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- lib/librte_ether/Makefile | 2 + lib/librte_ether/rte_ethdev.c | 93 ++ lib/librte_ether/rte_ethdev.h | 26 +++ lib/librte_ether/rte_ether_version.map

[dpdk-dev] [RFC 2/5] added --enable-representor command line argument in EAL to load representor broker infrastructure.

2017-09-07 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- lib/librte_eal/bsdapp/eal/eal.c| 6 ++ lib/librte_eal/common/eal_common_options.c | 1 + lib/librte_eal/common/eal_internal_cfg.h | 2 ++ lib/librte_eal/common/eal_options.h

[dpdk-dev] [RFC 4/5] Enable port representor PMD and broker for fortville PMD driver

2017-09-07 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- drivers/net/i40e/Makefile| 1 + drivers/net/i40e/i40e_ethdev.c | 17 ++ drivers/net/i40e/i40e_prep_ops.c | 402 +++ drivers/net/i40e/i40e_prep_ops.h

[dpdk-dev] [RFC 3/5] Implement port representor PMD

2017-09-07 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- config/common_base | 5 + drivers/net/Makefile | 2 + drivers/net/representor/Makefile | 51 ++ drivers/net

[dpdk-dev] [RFC 5/5] Enable port representor PMD and broker for ixgbe PMD driver.

2017-09-07 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- drivers/net/ixgbe/Makefile | 2 +- drivers/net/ixgbe/ixgbe_ethdev.c | 33 +++-- drivers/net/ixgbe/ixgbe_ethdev.h | 11 ++ drivers/net/ixgbe/ixgbe_prep_ops.c | 279

[dpdk-dev] [PATCH 2/6] lib/representor: port representor library to manage broker infrastructure and representor PMDs

2017-11-01 Thread Mohammad Abdul Awal
: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- config/common_base | 5 + lib/Makefile | 3 + lib/librte_representor/Makefile| 53 ++ lib/librte_representor

[dpdk-dev] [PATCH 1/6] ethdev: added switch_domain and representor port flag

2017-11-01 Thread Mohammad Abdul Awal
switch_domain attribute has been added to specify that a rte_eth_dev instance belongs to a switch domain in the software switch. RTE_ETH_DEV_REPRESENTOR_PORT has been defined to specify that a rte_eth_dev instance is a representor device. Signed-off-by: Mohammad Abdul Awal Signed-off-by: Declan

[dpdk-dev] [PATCH 3/6] eal: added --enable-representor command line argument in EAL to load representor broker infrastructure

2017-11-01 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Declan Doherty --- lib/librte_eal/bsdapp/eal/eal.c| 6 ++ lib/librte_eal/common/eal_common_options.c | 1 + lib/librte_eal/common/eal_internal_cfg.h | 2 ++ lib/librte_eal/common/eal_options.h| 2 ++ lib/librte_eal

[dpdk-dev] [PATCH 4/6] net/representor: Implement port representor PMD

2017-11-01 Thread Mohammad Abdul Awal
Representor PMD is a virtual PMD which provides a logical representation in DPDK for ports of a multi port device. This supports configuration, management, and monitoring of VFs of a physical function bound to a userspace control plane application. Signed-off-by: Mohammad Abdul Awal Signed-off

[dpdk-dev] [PATCH 5/6] net/i40e: Enable port representor PMD and broker for fortville PMD driver

2017-11-01 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- drivers/net/i40e/Makefile| 1 + drivers/net/i40e/i40e_ethdev.c | 16 ++ drivers/net/i40e/i40e_ethdev.h | 1 + drivers/net/i40e/i40e_prep_ops.c | 472

[dpdk-dev] [PATCH 6/6] net/ixgbe: Enable port representor PMD and broker for ixgbe PMD driver

2017-11-01 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- drivers/net/ixgbe/Makefile | 1 + drivers/net/ixgbe/ixgbe_ethdev.c | 22 +++- drivers/net/ixgbe/ixgbe_ethdev.h | 6 + drivers/net/ixgbe/ixgbe_prep_ops.c | 250

[dpdk-dev] [PATCH v2 2/6] lib/representor: port representor library to manage broker infrastructure and representor PMDs

2017-11-17 Thread Mohammad Abdul Awal
: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- config/common_base | 5 + lib/Makefile | 3 + lib/librte_representor/Makefile| 53 ++ lib/librte_representor

[dpdk-dev] [PATCH v2 4/6] net/representor: Implement port representor PMD

2017-11-17 Thread Mohammad Abdul Awal
control plane application. Change-Id: I5a7834bbc05bc9037e3218f69f10c1bd1e787236 Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- drivers/net/Makefile | 1 + drivers/net/representor/Makefile | 52

[dpdk-dev] [PATCH v2 1/6] ethdev: added switch_domain and representor port flag

2017-11-17 Thread Mohammad Abdul Awal
switch_domain attribute has been added to specify that a rte_eth_dev instance belongs to a switch domain in the software switch. RTE_ETH_DEV_REPRESENTOR_PORT has been defined to specify that a rte_eth_dev instance is a representor device. Signed-off-by: Mohammad Abdul Awal Signed-off-by: Declan

[dpdk-dev] [PATCH v2 3/6] eal: added --enable-representor command line argument in EAL to load representor broker infrastructure

2017-11-17 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Declan Doherty --- lib/librte_eal/bsdapp/eal/eal.c| 6 ++ lib/librte_eal/common/eal_common_options.c | 1 + lib/librte_eal/common/eal_internal_cfg.h | 2 ++ lib/librte_eal/common/eal_options.h| 2 ++ lib/librte_eal

[dpdk-dev] [PATCH v2 5/6] net/i40e: Enable port representor PMD and broker for fortville PMD driver

2017-11-17 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- drivers/net/i40e/Makefile| 1 + drivers/net/i40e/i40e_ethdev.c | 16 ++ drivers/net/i40e/i40e_ethdev.h | 1 + drivers/net/i40e/i40e_prep_ops.c | 472

[dpdk-dev] [PATCH v2 6/6] net/ixgbe: Enable port representor PMD and broker for ixgbe PMD driver

2017-11-17 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- drivers/net/ixgbe/Makefile | 1 + drivers/net/ixgbe/ixgbe_ethdev.c | 22 +++- drivers/net/ixgbe/ixgbe_ethdev.h | 6 + drivers/net/ixgbe/ixgbe_prep_ops.c | 250

Re: [dpdk-dev] [PATCH v2 2/6] lib/representor: port representor library to manage broker infrastructure and representor PMDs

2017-12-08 Thread Mohammad Abdul Awal
On 17/11/2017 23:03, Ferruh Yigit wrote: On 11/17/2017 6:42 AM, Mohammad Abdul Awal wrote: diff --git a/lib/librte_representor/rte_port_representor_version.map b/lib/librte_representor/rte_port_representor_version.map new file mode 100644 index 000..09ed768 --- /dev/null +++ b/lib

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: added switch_domain and representor port flag

2017-12-08 Thread Mohammad Abdul Awal
On 20/11/2017 19:57, Ferruh Yigit wrote: On 11/17/2017 6:42 AM, Mohammad Abdul Awal wrote: switch_domain attribute has been added to specify that a rte_eth_dev instance belongs to a switch domain in the software switch. RTE_ETH_DEV_REPRESENTOR_PORT has been defined to specify that a

Re: [dpdk-dev] [PATCH v2 4/6] net/representor: Implement port representor PMD

2017-12-08 Thread Mohammad Abdul Awal
On 08/12/2017 15:02, Remy Horton wrote: On 20/11/2017 07:46, Ferruh Yigit wrote: [..] Why we need this PMD? It looks like this has been used only for parameter parsing. Can it be possible to rte_representor_broker_init() will allocate ethdevs and fill brokers with this information? Possi

Re: [dpdk-dev] [PATCH v2 4/6] net/representor: Implement port representor PMD

2017-12-11 Thread Mohammad Abdul Awal
On 11/12/2017 10:08, Remy Horton wrote: int rte_representor_port_register(const char *devargs); Question is where this *devargs comes from - I don't think there is currently any commandline option to specify a parameter string for PFs. Remy, devargs will be passed by the application who us

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: added switch_domain and representor port flag

2017-12-11 Thread Mohammad Abdul Awal
Hi Alex, On 11/12/2017 13:45, Alex Rosenbaum wrote: Mohammad, I did not see a v2 change log. did I miss it? please send. The V2 change is for vdev handling by the representor PMD as the vdev API location changed from DPDK 17.08 to 17.11. So, V2 patch mainly a rebased against DPDK 17.11. I

Re: [dpdk-dev] [RFC 0/5] Port Representor for control and monitoring of VF devices

2017-12-22 Thread Mohammad Abdul Awal
Hi ALex, On 21/12/2017 14:51, Alex Rosenbaum wrote: Declan, Mohammad, The submission [1] of steering action between switch ports clearly requires a switch model in DPDK. The Port Representor based on a virtual PMD broker on NIC ops (rte_dev_ops) does not provide the required functionality. Usi

Re: [dpdk-dev] [RFC 0/5] Port Representor for control and monitoring of VF devices

2017-12-27 Thread Mohammad Abdul Awal
On 22/12/2017 22:33, Alex Rosenbaum wrote: On Fri, Dec 22, 2017 at 4:31 PM, Mohammad Abdul Awal wrote: On 21/12/2017 14:51, Alex Rosenbaum wrote: As described in the links Alejandro referenced earlier, each of the switch ports should be a real PMD, and switch operations should be applied on

Re: [dpdk-dev] [RFC 0/5] Port Representor for control and monitoring of VF devices

2018-01-02 Thread Mohammad Abdul Awal
On 27/12/2017 15:50, Alex Rosenbaum wrote: On Wed, Dec 27, 2017 at 11:40 AM, Mohammad Abdul Awal wrote: On 22/12/2017 22:33, Alex Rosenbaum wrote: On Fri, Dec 22, 2017 at 4:31 PM, Mohammad Abdul Awal On 21/12/2017 14:51, Alex Rosenbaum wrote: By hotplug I did not mean HW hotplug, rather I

Re: [dpdk-dev] [PATCH v3 0/5] lib: add Port Representors

2018-01-03 Thread Mohammad Abdul Awal
Hi Neil, On 26/12/2017 13:54, Neil Horman wrote: On Fri, Dec 22, 2017 at 02:52:16PM +, Remy Horton wrote: Port Representors provide a logical presentation in DPDK of VF (virtual function) ports for the purposes of control and monitoring. Each port representor device represents a single VF

Re: [dpdk-dev] [DPDK 0/5] lib: add Port Representors

2018-01-03 Thread Mohammad Abdul Awal
Hi Neil, On 22/12/2017 16:37, Neil Horman wrote: On Fri, Dec 22, 2017 at 02:41:16PM +, Remy Horton wrote: Port Representors provide a logical presentation in DPDK of VF (virtual function) ports for the purposes of control and monitoring. Each port representor device represents a single VF

[dpdk-dev] [PATCH] ether: fix invalid string length in ethdev name comparison

2018-02-26 Thread Mohammad Abdul Awal
. Fixes: 9c5b8d8b9fe ("ethdev: clean port id retrieval when attaching") Signed-off-by: Mohammad Abdul Awal --- lib/librte_ether/rte_ethdev.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c ind

Re: [dpdk-dev] [PATCH] ether: fix invalid string length in ethdev name comparison

2018-02-27 Thread Mohammad Abdul Awal
On 27/02/2018 00:15, Ananyev, Konstantin wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mohammad Abdul Awal + len1 = strlen(name); for (pid = 0; pid < RTE_MAX_ETHPORTS; pid++) { + len2 = strlen(rte_eth_dev_shared_data-&g

[dpdk-dev] [PATCH v2] ether: fix invalid string length in ethdev name comparison

2018-02-27 Thread Mohammad Abdul Awal
("ethdev: clean port id retrieval when attaching") Signed-off-by: Mohammad Abdul Awal --- lib/librte_ether/rte_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 0590f0c..3b885a6 100644

Re: [dpdk-dev] [PATCH 03/18] ethdev: introduce new tunnel VXLAN-GPE

2018-02-27 Thread Mohammad Abdul Awal
On 26/02/2018 15:09, Xueming Li wrote: diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index 45daa91..fe02ad8 100644 --- a/lib/librte_net/rte_ether.h +++ b/lib/librte_net/rte_ether.h @@ -310,6 +310,31 @@ struct vxlan_hdr { /**< VXLAN tunnel header length. */ /** + *

[dpdk-dev] [PATCH] app/testpmd: fix RSS-hash-key size

2016-08-03 Thread Mohammad Abdul Awal
RSS hash-key-size is retrieved from device configuration instead of using a fixed size of 40 bytes. Fixes: f79959ea1504 ("app/testpmd: allow to configure RSS hash key") Signed-off-by: Mohammad Abdul Awal --- app/test-pmd/cmdline.c | 24 +--- app/test-pmd/conf

[dpdk-dev] [PATCH v2] app/testpmd: fix RSS-hash-key size

2016-08-05 Thread Mohammad Abdul Awal
RSS hash-key-size is retrieved from device configuration instead of using a fixed size of 40 bytes. Fixes: f79959ea1504 ("app/testpmd: allow to configure RSS hash key") Signed-off-by: Mohammad Abdul Awal --- v2: * Used macro instead of hard-coded value. * Some nits as per comments.

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes

2019-04-29 Thread Mohammad Abdul Awal
s/dev/2018-November/120035.html. + * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``. Acked-by: Mohammad Abdul Awal