[dpdk-dev] [PATCH v3] net/i40e: fix FDIR issue for common PCTYPEs

2021-04-20 Thread Murphy Yang
Currently, FDIR doesn't work for all common PCTYPEs, the root cause is that input set is not configured. Fixes: 4a072ad43442 ("net/i40e: fix flow director config after flow validate") Signed-off-by: Murphy Yang --- drivers/net/i40e/i40e_fdir.c | 25 + 1 f

[dpdk-dev] [PATCH v2] net/i40e: fix FDIR issue for common PCTYPEs

2021-04-20 Thread Murphy Yang
Currently, FDIR doesn't work for all common PCTYPEs, the root cause is that input set is not configured. Fixes: 4a072ad43442 ("net/i40e: fix flow director config after flow validate") Signed-off-by: Murphy Yang --- v2: - tune the code and modify commit message drivers/net/i40e/i

[dpdk-dev] [PATCH] net/i40e: fix flow does not effect on uncustomed pctype

2021-04-15 Thread Murphy Yang
Uncustomed flow rule does not effect, the root cause is not write the configure in register. Fixes: 4a072ad43442 ("net/i40e: fix flow director config after flow validate") Signed-off-by: Murphy Yang --- drivers/net/i40e/i40e_fdir.c | 20 +--- 1 file changed, 9 inserti

[dpdk-dev] [PATCH] net/i40e: fix mbuf fast free wrong check

2021-04-06 Thread Murphy Yang
ID: 665 Fixes: 399421100e08 ("net/i40e: fix missing mbuf fast free offload") Signed-off-by: Murphy Yang --- drivers/net/i40e/i40e_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index b3d7765e3b.

[dpdk-dev] [PATCH v2] net/i40e: fix inappropriate config during flow validate

2021-03-31 Thread Murphy Yang
The configuration of FDIR input set should not be set during flow validate. It should be set when flow create. Fixes: fe5d0e85b713 ("net/i40e: fix flow director flex configuration") Fixes: 15018d79f0be ("net/i40e: add FDIR support for GTP-C and GTP-U") Signed-off-by: Murphy

[dpdk-dev] [PATCH v3] net/ixgbe: fix RSS RETA be reset after port start

2021-03-29 Thread Murphy Yang
RETA configuration") Signed-off-by: Murphy Yang --- v3: - modify the notify message v2: - tune the return value drivers/net/ixgbe/ixgbe_ethdev.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 8a9a21e7c2..

[dpdk-dev] [PATCH v2] net/ixgbe: fix RSS RETA be reset after port start

2021-03-29 Thread Murphy Yang
RETA configuration") Signed-off-by: Murphy Yang --- v2: - tune the return value drivers/net/ixgbe/ixgbe_ethdev.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 8a9a21e7c2..6aebf9c11e 100644 --- a/drivers

[dpdk-dev] [PATCH] net/ixgbe: fix RSS RETA be reset after port start

2021-03-29 Thread Murphy Yang
RETA configuration") Signed-off-by: Murphy Yang --- drivers/net/ixgbe/ixgbe_ethdev.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 8a9a21e7c2..41068fe646 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/d

[dpdk-dev] [PATCH] net/i40e: fix inappropriate config during flow validate

2021-03-18 Thread Murphy Yang
The configuration of FDIR input set should not be set during flow validate. It should be set when flow create. Fixes: fe5d0e85b713 ("net/i40e: fix flow director flex configuration") Fixes: 15018d79f0be ("net/i40e: add FDIR support for GTP-C and GTP-U") Signed-off-by: Murph

[dpdk-dev] [RFC] net/i40e: change the timing of FDIR input set configuration

2021-03-15 Thread Murphy Yang
The configuration of FDIR input set should not be set during flow validate. It should be set when flow create. Signed-off-by: Murphy Yang --- drivers/net/i40e/i40e_ethdev.h | 1 + drivers/net/i40e/i40e_fdir.c | 88 +++ drivers/net/i40e/i40e_flow.c | 95

[dpdk-dev] [PATCH] net/i40e: i40e PMD APIs add input pointer null check

2021-01-08 Thread Murphy Yang
Pointer 'NULL' check for 'mac_addr' or 'conf' within i40e PMD APIs. Fixes: 66c78f4799ff ("net/i40e: add support for packet template to flow director") Fixes: 04b443fb2c43 ("net/i40e: fix port id type") Signed-off-by: Murphy Yang --- drivers/

[dpdk-dev] [PATCH] net/ice: disable IPv4 checksum offload in vector path

2021-01-07 Thread Murphy Yang
ICE choices vector TX path or basic TX path by macro 'ICE_NO_VECTOR_FLAGS'. This patch adds 'DEV_TX_OFFLOAD_IPV4_CKSUM' in 'ICE_NO_VECTOR_FLAGS' to make IPv4 checksum offload processed by basic TX path. Fixes: a22483208800 ("net/ice: disable TSO offload in v

[dpdk-dev] [PATCH v8] net/iavf: fix invalid RSS combinations rule can be created

2021-01-07 Thread Murphy Yang
nations in 'invalid_rss_comb' array to do valid check, if the combination check failed, the rule will be created unsuccessful. Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") Signed-off-by: Murphy Yang --- v8: - Update the comments. v7: - Remove unsupported RSS combinations array. - Restor

[dpdk-dev] [PATCH v7] net/iavf: fix invalid RSS combinations rule can be created

2021-01-07 Thread Murphy Yang
6_TCP For 'ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP' (same as IPV6), this pathch adds these combinations in 'invalid_rss_comb' array to do valid check, if the combination check failed, the rule will be created unsuccessful. Fixes: 91f27b2e39ab ("net/iavf: refactor RSS&qu

[dpdk-dev] [PATCH v6] net/iavf: fix invalid RSS combinations rule can be created

2020-12-27 Thread Murphy Yang
his patch adds these combinations in 'unsupported_rss_comb' array to do valid check, if the combination check failed, the rule will be created unsuccessful. Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") Signed-off-by: Murphy Yang --- v6: - add unsupported RSS combinations

[dpdk-dev] [PATCH v5] net/iavf: fix invalid RSS combinations rule can be created

2020-12-23 Thread Murphy Yang
atch removes the 'ETH_RSS_GTPU' from the input set mask, if the combination is invalid, the 'rss_type' check will be failed, the rule will be created unsuccessful. Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") Signed-off-by: Murphy Yang --- v5: - remo

[dpdk-dev] [PATCH v4] net/iavf: fix invalid RSS combinations rule can be created

2020-12-23 Thread Murphy Yang
So, this patch adds these combinations in 'invalid_rss_comb' array to do valid check, if the combination check failed, the rule will be created unsuccessful. Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") Signed-off-by: Murphy Yang --- v4: - use 'ETH_RSS_XXX' replac

[dpdk-dev] [PATCH v3] net/iavf: fix invalid RSS combinations rule can be created

2020-12-22 Thread Murphy Yang
adds these combinations in 'invalid_rss_comb' array to do valid check, if the combination check failed, the rule will be created unsuccessful. Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") Signed-off-by: Murphy Yang --- v3: - update the comments. v2: - add invalid RSS co

[dpdk-dev] [PATCH v2] net/iavf: fix negative GTP-U flow rules create successfully

2020-12-17 Thread Murphy Yang
PE_INNER_IPV4 - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_UDP - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_TCP - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6 - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_UDP - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_TCP Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") Signed-off-by:

[dpdk-dev] [PATCH v8] net/ice: fix outer checksum unknown

2020-12-15 Thread Murphy Yang
Rx flex descriptor") Fixes: 4ab7dbb0a0f6 ("net/ice: switch to Rx flexible descriptor in AVX path") Fixes: ece1f8a8f1c8 ("net/ice: switch to flexible descriptor in SSE path") Signed-off-by: Murphy Yang --- v8: - tune the commit title. v7: - fix compile error with default targe

[dpdk-dev] [PATCH] net/iavf: fix negative GTP-U flow rules create successfully

2020-12-08 Thread Murphy Yang
GTP-U patterns. So, this commit modifies the macro define of the 'IAVF_RSS_TYPE_XXX' to make the result correct. Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") Signed-off-by: Murphy Yang --- drivers/net/iavf/iavf_hash.c | 30 ++ 1 file changed, 10 insert

[dpdk-dev] [PATCH v2] net/i40e: fix incorrect checksum flag of L4 checksum

2020-12-02 Thread Murphy Yang
#x27; flag to 'l3_l4e_flags' for sse and 'l3_l4_flags_shuf' for avx2 to ensure that the 'ol_flags' can match correct flags. Fixes: 9966a00a0688 ("net/i40e: enable bad checksum flags in vector Rx") Fixes: dafadd73762e ("net/i40e: add AVX2 Rx fun

[dpdk-dev] [PATCH 2/2] app/testpmd: support GTP-U extension packet checksum offload

2020-11-25 Thread Murphy Yang
To enable Tx side offload on GTP-U packets that contain extension header, testpmd should set 'info->l2_len' correctly, this value should contain UDP header length, GTP-U header length and GTP-U extension header length. Signed-off-by: Murphy Yang --- app/test-pmd/cs

[dpdk-dev] [PATCH 1/2] net/i40e: support GTP checksum offload

2020-11-25 Thread Murphy Yang
To support Tx side offload on GTP tunneling packet, driver should set correct tunneling parameters of 'L4TUNT'. Signed-off-by: Murphy Yang --- drivers/net/i40e/i40e_rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rx

[dpdk-dev] [PATCH 0/2] support GTP-U Tx offload on FVL and CVL

2020-11-25 Thread Murphy Yang
Support outer L3 and inner L3 + L4 Tx checksum offload for GTP-U packets that contain extension header on FVL. Support outer L3 + L4 and inner L3 + L4 Rx and Tx checksum offload for GTP-U packets that contain extension header on CVL. Murphy Yang (2): net/i40e: support GTP checksum offload app

[dpdk-dev] [PATCH v7] net/ice: fix outer checksum on cvl unknown

2020-11-23 Thread Murphy Yang
Rx flex descriptor") Fixes: 4ab7dbb0a0f6 ("net/ice: switch to Rx flexible descriptor in AVX path") Fixes: ece1f8a8f1c8 ("net/ice: switch to flexible descriptor in SSE path") Signed-off-by: Murphy Yang --- v7: - fix compile error with default target on SSE vector path. v6: - re

[dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error

2020-11-22 Thread Murphy Yang
27;L4T_CS' flag marked, the hardware can calculate the outer tunneling UDP checksum. Fixes: bd70c451532c ("net/ice: support Tx checksum offload for tunnel") Signed-off-by: Murphy Yang --- drivers/net/ice/ice_rxtx.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) dif

[dpdk-dev] [PATCH] net/i40e: fix incorrect checksum flag of L4 checksum

2020-11-11 Thread Murphy Yang
and 'l3_l4_flags_shuf' for avx2 to ensure that the 'ol_flags' can match correct flags. Fixes: 9966a00a0688 ("net/i40e: enable bad checksum flags in vector Rx") Fixes: dafadd73762e ("net/i40e: add AVX2 Rx function") Signed-off-by: Murphy Yang ---

[dpdk-dev] [PATCH v6] net/ice: fix outer checksum on cvl unknown

2020-11-08 Thread Murphy Yang
Fixes: dbf3c0e77a22 ("net/ice: handle Rx flex descriptor") Fixes: 4ab7dbb0a0f6 ("net/ice: switch to Rx flexible descriptor in AVX path") Fixes: ece1f8a8f1c8 ("net/ice: switch to flexible descriptor in SSE path") Signed-off-by: Murphy Yang --- v6: - rename variable na

[dpdk-dev] [PATCH v5] net/ice: fix outher chksum on cvl unknown

2020-11-04 Thread Murphy Yang
Fixes: dbf3c0e77a22 ("net/ice: handle Rx flex descriptor") Fixes: 4ab7dbb0a0f6 ("net/ice: switch to Rx flexible descriptor in AVX path") Fixes: ece1f8a8f1c8 ("net/ice: switch to flexible descriptor in SSE path") Signed-off-by: Murphy Yang --- v5: - fix outer L4 checks

[dpdk-dev] [PATCH v4] net/ice: fix outher chksum on cvl unknown

2020-11-02 Thread Murphy Yang
Fixes: dbf3c0e77a22 ("net/ice: handle Rx flex descriptor") Fixes: 4ab7dbb0a0f6 ("net/ice: switch to Rx flexible descriptor in AVX path") Fixes: ece1f8a8f1c8 ("net/ice: switch to flexible descriptor in SSE path") Signed-off-by: Murphy Yang --- v4: - cover AVX512 vector

[dpdk-dev] [PATCH] net/ice: fix outher chksum on cvl unknown

2020-11-02 Thread Murphy Yang
Fixes: dbf3c0e77a22 ("net/ice: handle Rx flex descriptor") Fixes: 4ab7dbb0a0f6 ("net/ice: switch to Rx flexible descriptor in AVX path") Fixes: ece1f8a8f1c8 ("net/ice: switch to flexible descriptor in SSE path") Signed-off-by: Murphy Yang --- drivers/net/i

[dpdk-dev] [PATCH v3] net/ice: fix outher chksum on cvl unknown

2020-10-26 Thread Murphy Yang
From: murphy When set 'csum set outer-udp hw 0' ,support for ICE_RX_FLEX_DESC_STATUS0_XSUM_EUDPE_S,mark the packet PKT_RX_OUTER_L4_CKSUM_BAD or PKT_RX_OUTER_L4_CKSUM_GOOD. Fixes: dbf3c0e77a22 ("net/ice: handle Rx flex descriptor") Fixes: 4ab7dbb0a0f6 ("net/ice: switch to Rx flexible descriptor i

[dpdk-dev] [PATCH 1/1] net/ice: fix outher chksum on cvl unknown

2020-10-15 Thread murphy yang
From: murphy When set 'csum set outer-udp hw 0' ,support for ICE_RX_FLEX_DESC_STATUS0_XSUM_EUDPE_S,mark the packet PKT_RX_OUTER_L4_CKSUM_BAD or PKT_RX_OUTER_L4_CKSUM_GOOD. Fixes: dbf3c0e77a22 ("net/ice: handle Rx flex descriptor") Fixes: 4ab7dbb0a0f6 ("net/ice: switch to Rx flexible descriptor i

[dpdk-dev] [PATCH] net/ice: fix outher chksum on cvl unknown

2020-10-14 Thread murphy yang
From: murphy When set 'csum set outer-udp hw 0' ,support for ICE_RX_FLEX_DESC_STATUS0_XSUM_EUDPE_S,mark the packet PKT_RX_OUTER_L4_CKSUM_BAD or PKT_RX_OUTER_L4_CKSUM_GOOD Fixes: dbf3c0e77a22 ("net/ice: handle Rx flex descriptor") Signed-off-by: murphy --- drivers/net/ice/ice_rxtx.c | 5 +

[dpdk-dev] [PATCH] net/iavf: fix link status

2020-09-18 Thread murphy yang
From: murphy If the PF driver supports the new speed reporting capabilities then use link_event_adv instead of link_event to get the speed. Fixes: 5330b042977c ("net/iavf: fix link speed") Cc: sta...@dpdk.org Signed-off-by: murphy --- drivers/net/iavf/iavf_vchnl.c | 7 +++ 1 file changed