[PATCH v12 7/7] test/graph_feature_arc: add functional tests

2025-06-05 Thread Nitin Saxena
Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_ar

[PATCH v12 6/7] app/graph: add custom feature nodes for ip4 output arc

2025-06-05 Thread Nitin Saxena
at runtime on any ethdev via CLI. graph> help feature graph> feature enable graph> feature disable graph> graph stats show Signed-off-by: Nitin Saxena --- app/graph/commands.list | 6 ++ app/graph/feature.c | 141 app/graph/f

[PATCH v12 4/7] graph: add feature enable/disable APIs

2025-06-05 Thread Nitin Saxena
This patch also adds feature arc fast path APIs as well along with documentation Signed-off-by: Nitin Saxena --- doc/guides/prog_guide/graph_lib.rst | 180 ++ lib/graph/graph_feature_arc.c| 717 ++- lib/graph/meson.build| 2 +- lib

[PATCH v12 5/7] ip4: add ip4 output feature arc

2025-06-05 Thread Nitin Saxena
- Added ip4 output arc to allow applications to hook feature nodes in ip4 egress direction - Added interface_tx node as end feature to ip4 output arc Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_25_07.rst | 2 + lib/node/ethdev_ctrl.c | 8 + lib/node

[PATCH v12 3/7] graph: add feature arc init APIs

2025-06-05 Thread Nitin Saxena
This patch adds feature arc init()/create()/destroy() APIs. It also add APIs for adding feature node to an arc. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md|3 +- doc/guides/prog_guide/graph_lib.rst | 25 +- lib/graph/graph_feature_arc.c| 1327

[PATCH v12 2/7] graph: add feature arc registrations

2025-06-05 Thread Nitin Saxena
This patch defines RTE_GRAPH_FEATURE_ARC_REGISTER() and RTE_GRAPH_FEATURE_REGISTER() constructors and associated APIs with programming guide. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 3 +- doc/guides/prog_guide/graph_lib.rst | 291 +++ doc

[PATCH v12 1/7] graph: add API to override node process function

2025-06-05 Thread Nitin Saxena
New internal API used by feature arc library to override node's original process() func. Signed-off-by: Nitin Saxena --- lib/graph/graph_private.h | 11 +++ lib/graph/node.c | 22 ++ 2 files changed, 33 insertions(+) diff --git a/lib/graph/graph_privat

[PATCH v12 0/7] add feature arc in rte_graph

2025-06-05 Thread Nitin Saxena
Changed design to handle fast path synchronization via RCU mechanism when any feature is enabled or disabled - Added feature arc specific mbuf dynamic field to carry feature data across nodes - Added feature arc example in app/graph - Programming guide and functional test cases in future versio

Re: [PATCH v10 4/7] graph: add feature enable/disable APIs

2025-06-04 Thread Nitin Saxena
Hi Kiran, On Wed, Jun 4, 2025 at 5:06 PM Kiran Kumar Kokkilagadda wrote: > > > > > -Original Message- > > From: Nitin Saxena > > Sent: Wednesday, June 4, 2025 3:43 PM > > To: Jerin Jacob ; Kiran Kumar Kokkilagadda > > ; Nithin Kumar Dabilp

Re: [PATCH v9 2/5] graph: add feature arc abstraction

2025-06-04 Thread Nitin Saxena
Hi Jerin, On Fri, May 30, 2025 at 6:43 PM Jerin Jacob wrote: > > > > > -Original Message- > > From: Nitin Saxena > > Sent: Monday, April 21, 2025 8:47 PM > > To: Jerin Jacob ; Kiran Kumar Kokkilagadda > > ; Nithin Kumar Dabilpuram > >

Re: [PATCH v9 2/5] graph: add feature arc abstraction

2025-06-04 Thread Nitin Saxena
Hi Jerin, I have fixed all your comments in the v10 patchset. Thanks, Nitin On Fri, May 30, 2025 at 6:39 PM Jerin Jacob wrote: > > > > -Original Message- > > From: Nitin Saxena > > Sent: Monday, April 21, 2025 8:47 PM > > To: Jerin Jacob ; Kiran Kumar K

Re: [PATCH v10 3/7] graph: add feature arc init APIs

2025-06-04 Thread Nitin Saxena
Hi Kiran, On Wed, Jun 4, 2025 at 4:54 PM Kiran Kumar Kokkilagadda wrote: > > > > > -Original Message- > > From: Nitin Saxena > > Sent: Wednesday, June 4, 2025 3:43 PM > > To: Jerin Jacob ; Kiran Kumar Kokkilagadda > > ; Nithin Kumar Dabilp

[PATCH v11 5/7] ip4: add ip4 output feature arc

2025-06-04 Thread Nitin Saxena
- Added ip4 output arc to allow applications to hook feature nodes in ip4 egress direction - Added interface_tx node as end feature to ip4 output arc Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_25_07.rst | 2 + lib/node/ethdev_ctrl.c | 8 + lib/node

[PATCH v11 6/7] app/graph: add custom feature nodes for ip4 output arc

2025-06-04 Thread Nitin Saxena
at runtime on any ethdev via CLI. graph> help feature graph> feature enable graph> feature disable graph> graph stats show Signed-off-by: Nitin Saxena --- app/graph/commands.list | 6 ++ app/graph/feature.c | 141 app/graph/f

[PATCH v11 7/7] test/graph_feature_arc: add functional tests

2025-06-04 Thread Nitin Saxena
Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_ar

[PATCH v11 4/7] graph: add feature enable/disable APIs

2025-06-04 Thread Nitin Saxena
This patch also adds feature arc fast path APIs as well along with documentation Signed-off-by: Nitin Saxena --- doc/guides/prog_guide/graph_lib.rst | 180 ++ lib/graph/graph_feature_arc.c| 717 ++- lib/graph/meson.build| 2 +- lib

[PATCH v11 2/7] graph: add feature arc registrations

2025-06-04 Thread Nitin Saxena
This patch defines RTE_GRAPH_FEATURE_ARC_REGISTER() and RTE_GRAPH_FEATURE_REGISTER() constructors and associated APIs with programming guide. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 1 + doc/guides/prog_guide/graph_lib.rst | 289 +++ doc

[PATCH v11 3/7] graph: add feature arc init APIs

2025-06-04 Thread Nitin Saxena
This patch adds feature arc init()/create()/destroy() APIs. It also add APIs for adding feature node to an arc. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md|1 + doc/guides/prog_guide/graph_lib.rst | 27 +- lib/graph/graph_feature_arc.c| 1327

[PATCH v11 1/7] graph: add API to override node process function

2025-06-04 Thread Nitin Saxena
New internal API used by feature arc library to override node's original process() func. Signed-off-by: Nitin Saxena --- lib/graph/graph_private.h | 11 +++ lib/graph/node.c | 22 ++ 2 files changed, 33 insertions(+) diff --git a/lib/graph/graph_privat

[PATCH v11 0/7] add feature arc in rte_graph

2025-06-04 Thread Nitin Saxena
s enabled or disabled - Added feature arc specific mbuf dynamic field to carry feature data across nodes - Added feature arc example in app/graph - Programming guide and functional test cases in future versions Nitin Saxena (7): graph: add API to override node process function graph: add featu

[PATCH v10 3/7] graph: add feature arc init APIs

2025-06-04 Thread Nitin Saxena
This patch adds feature arc init()/create()/destroy() APIs. It also add APIs for adding feature node to an arc. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md|1 + doc/guides/prog_guide/graph_lib.rst | 23 +- lib/graph/graph_feature_arc.c| 1329

[PATCH v10 7/7] test/graph_feature_arc: add functional tests

2025-06-04 Thread Nitin Saxena
Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_ar

[PATCH v10 6/7] app/graph: add custom feature nodes for ip4 output arc

2025-06-04 Thread Nitin Saxena
at runtime on any ethdev via CLI. graph> help feature graph> feature enable graph> feature disable graph> graph stats show Signed-off-by: Nitin Saxena --- app/graph/commands.list | 6 ++ app/graph/feature.c | 141 app/graph/f

[PATCH v10 4/7] graph: add feature enable/disable APIs

2025-06-04 Thread Nitin Saxena
This patch also adds feature arc fast path APIs as well along with documentation Signed-off-by: Nitin Saxena --- doc/guides/prog_guide/graph_lib.rst | 180 ++ lib/graph/graph_feature_arc.c| 701 ++- lib/graph/meson.build| 2 +- lib

[PATCH v10 5/7] ip4: add ip4 output feature arc

2025-06-04 Thread Nitin Saxena
- Added ip4 output arc to allow applications to hook feature nodes in ip4 egress direction - Added interface_tx node as end feature to ip4 output arc Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_25_07.rst | 2 + lib/node/ethdev_ctrl.c | 8 + lib/node

[PATCH v10 2/7] graph: add feature arc registrations

2025-06-04 Thread Nitin Saxena
This patch defines RTE_GRAPH_FEATURE_ARC_REGISTER() and RTE_GRAPH_FEATURE_REGISTER() constructors and associated APIs with programming guide. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 1 + doc/guides/prog_guide/graph_lib.rst | 289 +++ doc

[PATCH v10 1/7] graph: add API to override node process function

2025-06-04 Thread Nitin Saxena
New internal API used by feature arc library to override node's original process() func. Signed-off-by: Nitin Saxena --- lib/graph/graph_private.h | 11 +++ lib/graph/node.c | 23 +++ 2 files changed, 34 insertions(+) diff --git a/lib/graph/graph_priv

[PATCH v10 0/7] add feature arc in rte_graph

2025-06-04 Thread Nitin Saxena
dynamic field to carry feature data across nodes - Added feature arc example in app/graph - Programming guide and functional test cases in future versions Nitin Saxena (7): graph: add API to override node process function graph: add feature arc registrations graph: add feature arc init APIs

Re: [PATCH v3 00/14] add lookup fib nodes in graph library

2025-06-02 Thread Nitin Saxena
Hi Morten, Let me take a stab regarding the VRF question. Please find answers inline Thanks, Nitin On Mon, Jun 2, 2025 at 2:12 PM Morten Brørup wrote: > > +TO: Robin Jarry, might have relevant feedback for such a node > > > From: Ankur Dwivedi [mailto:adwiv...@marvell.com] > > Sent: Monday, 2 J

Re: [PATCH v5 1/2] node: add global node mbuf dynfield

2025-04-28 Thread Nitin Saxena
Hi Pavan, I have incorporated your comments in patch 6 Thanks for reviewing Nitin On Sat, Apr 19, 2025 at 12:33 AM Pavan Nikhilesh Bhagavatula wrote: > > > > > -Original Message- > > From: Nitin Saxena > > Sent: Wednesday, April 9, 2025 7:26 PM > > To

[PATCH v6 2/2] node: use node mbuf dynfield in ip4 nodes

2025-04-28 Thread Nitin Saxena
- Used global node mbuf in ip[4|6]_lookup/rewrite nodes - Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get() Signed-off-by: Nitin Saxena --- lib/node/ip4_lookup.c | 14 --- lib/node/ip4_rewrite.c| 15 +--- lib/node/ip6_lookup.c

[PATCH v6 0/2] node: add mbuf dynamic field for nodes

2025-04-28 Thread Nitin Saxena
in v2: - removed usage of memzone for saving mbuf dynfield [Stephen] - fixed checkpatch issues - redefine RTE_NODE_MBUF_OVERLOADABLE_FIELDS_SIZE to 8 byte which are currently in use. Size can increase later based on the usage Nitin Saxena (2): node: add global node mbuf dynfield node: use

[PATCH v6 1/2] node: add global node mbuf dynfield

2025-04-28 Thread Nitin Saxena
are used by any two adjacent nodes. Same fields can be repurposed by any other adjacent nodes This dynfield can be also be used by out-of-tree nodes. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 2 + doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node

[PATCH v9 4/5] app/graph: add custom feature nodes for ip4 output arc

2025-04-21 Thread Nitin Saxena
at runtime on any ethdev via CLI. graph> help feature graph> feature enable graph> feature disable graph> graph stats show Signed-off-by: Nitin Saxena --- app/graph/commands.list | 6 ++ app/graph/feature.c | 141 app/graph/f

[PATCH v9 3/5] ip4: add ip4 output feature arc

2025-04-21 Thread Nitin Saxena
- Added ip4 output arc to allow applications to hook feature nodes in ip4 egress direction - Added interface_tx node as end feature to ip4 output arc Signed-off-by: Nitin Saxena --- lib/node/ethdev_ctrl.c | 8 + lib/node/interface_tx_feature.c | 213

[PATCH v9 5/5] test/graph_feature_arc: add functional tests

2025-04-21 Thread Nitin Saxena
Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_ar

[PATCH v9 2/5] graph: add feature arc abstraction

2025-04-21 Thread Nitin Saxena
also be hooked (with no custom changes in DPDK in-built nodes) Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md|2 + doc/guides/rel_notes/release_25_07.rst | 10 + lib/graph/graph_feature_arc.c| 2050 ++ lib/graph/graph_private.h

[PATCH v9 1/5] graph: add API to override node process function

2025-04-21 Thread Nitin Saxena
New API used by feature arc library to override node's original process() func. Signed-off-by: Nitin Saxena --- lib/graph/graph_private.h | 11 +++ lib/graph/node.c | 23 +++ 2 files changed, 34 insertions(+) diff --git a/lib/graph/graph_private.h

[PATCH v9 0/5] add feature arc in rte_graph

2025-04-21 Thread Nitin Saxena
handle fast path synchronization via RCU mechanism when any feature is enabled or disabled - Added feature arc specific mbuf dynamic field to carry feature data across nodes - Added feature arc example in app/graph - Programming guide and functional test cases in future versions Nitin Saxena (5):

[PATCH v8 5/5] test/graph_feature_arc: add functional tests

2025-04-19 Thread Nitin Saxena
Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_ar

[PATCH v8 4/5] app/graph: add custom feature nodes for ip4 output arc

2025-04-19 Thread Nitin Saxena
at runtime on any ethdev via CLI. graph> help feature graph> feature enable graph> feature disable graph> graph stats show Signed-off-by: Nitin Saxena --- app/graph/commands.list | 6 ++ app/graph/feature.c | 141 + app/graph/f

[PATCH v8 3/5] ip4: add ip4 output feature arc

2025-04-19 Thread Nitin Saxena
- Added ip4 output arc to allow applications to hook feature nodes in ip4 egress direction - Added interface_tx node as end feature to ip4 output arc Signed-off-by: Nitin Saxena --- lib/node/ethdev_ctrl.c | 8 + lib/node/interface_tx_feature.c | 213

[PATCH v8 2/5] graph: add feature arc abstraction

2025-04-19 Thread Nitin Saxena
also be hooked (with no custom changes in DPDK in-built nodes) Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md|2 + doc/guides/rel_notes/release_25_07.rst | 10 + lib/graph/graph_feature_arc.c| 2050 ++ lib/graph/graph_private.h

[PATCH v8 1/5] graph: add API to override node process function

2025-04-19 Thread Nitin Saxena
New API used by feature arc library to override node's original process() func. Signed-off-by: Nitin Saxena --- lib/graph/graph_private.h | 11 +++ lib/graph/node.c | 23 +++ 2 files changed, 34 insertions(+) diff --git a/lib/graph/graph_private.h

[PATCH v8 0/5] add feature arc in rte_graph

2025-04-19 Thread Nitin Saxena
echanism when any feature is enabled or disabled - Added feature arc specific mbuf dynamic field to carry feature data across nodes - Added feature arc example in app/graph - Programming guide and functional test cases in future versions Nitin Saxena (5): graph: add API to override node pro

[PATCH v7 5/5] test/graph_feature_arc: add functional tests

2025-04-19 Thread Nitin Saxena
Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_ar

[PATCH v7 4/5] app/graph: add custom feature nodes for ip4 output arc

2025-04-19 Thread Nitin Saxena
at runtime on any ethdev via CLI. graph> help feature graph> feature enable graph> feature disable graph> graph stats show Signed-off-by: Nitin Saxena --- app/graph/commands.list | 6 ++ app/graph/feature.c | 141 + app/graph/f

[PATCH v7 3/5] ip4: add ip4 output feature arc

2025-04-19 Thread Nitin Saxena
- Added ip4 output arc to allow applications to hook feature nodes in ip4 egress direction - Added interface_tx node as end feature to ip4 output arc Signed-off-by: Nitin Saxena --- lib/node/ethdev_ctrl.c | 8 + lib/node/interface_tx_feature.c | 213

[PATCH v7 2/5] graph: add feature arc abstraction

2025-04-19 Thread Nitin Saxena
also be hooked (with no custom changes in in-built nodes) Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md|2 + doc/guides/rel_notes/release_25_07.rst | 10 + lib/graph/graph_feature_arc.c| 2050 ++ lib/graph/graph_private.h

[PATCH v7 1/5] graph: add API to override node process function

2025-04-19 Thread Nitin Saxena
New API used by feature arc library to override node's original process() func. Signed-off-by: Nitin Saxena --- lib/graph/graph_private.h | 11 +++ lib/graph/node.c | 23 +++ 2 files changed, 34 insertions(+) diff --git a/lib/graph/graph_private.h

[PATCH v7 0/5] add feature arc in rte_graph

2025-04-19 Thread Nitin Saxena
bled or disabled - Added feature arc specific mbuf dynamic field to carry feature data across nodes - Added feature arc example in app/graph - Programming guide and functional test cases in future versions Nitin Saxena (5): graph: add API to override node process function graph: add feature

Re: [PATCH v1 04/12] node: add process callback for IP4 FIB

2025-04-16 Thread Nitin Saxena
Hi Ankur, Same comments apply to IPv6 nodes as well. See for ip4 lookup comments Thanks, Nitin On Tue, Apr 15, 2025 at 6:20 PM Ankur Dwivedi wrote: > > Adds the process callback function for ip4_lookup_fib node. > > Signed-off-by: Ankur Dwivedi > --- > lib/node/ip4_lookup_fib.c | 164

Re: [PATCH v1 02/12] node: add IP4 lookup FIB node

2025-04-16 Thread Nitin Saxena
Hi Ankur, Please see my comments inline below Thanks, Nitin On Tue, Apr 15, 2025 at 5:41 PM Ankur Dwivedi wrote: > > Adds a lookup FIB node for IP4. > > Signed-off-by: Ankur Dwivedi > --- > lib/node/ip4_lookup_fib.c | 127 ++ > lib/node/meson.build |

[PATCH v5 0/2] node: add mbuf dynamic field for nodes

2025-04-10 Thread Nitin Saxena
mbuf dynfield [Stephen] - fixed checkpatch issues - redefine RTE_NODE_MBUF_OVERLOADABLE_FIELDS_SIZE to 8 byte which are currently in use. Size can increase later based on the usage Nitin Saxena (2): node: add global node mbuf dynfield node: use node mbuf dynfield in ip4 nodes doc/api/doxy-api

[PATCH v5 1/2] node: add global node mbuf dynfield

2025-04-09 Thread Nitin Saxena
are used by any two adjacent nodes. Same fields can be repurposed by any other adjacent nodes This dynfield can be also be used by out-of-tree nodes. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node

[PATCH v5 2/2] node: use node mbuf dynfield in ip4 nodes

2025-04-09 Thread Nitin Saxena
- Used global node mbuf in ip[4|6]_lookup/rewrite nodes - Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get() Signed-off-by: Nitin Saxena --- lib/node/ip4_lookup.c | 14 --- lib/node/ip4_rewrite.c| 15 +--- lib/node/ip6_lookup.c

Re: [PATCH v4 0/2] node: add mbuf dynamic field for nodes

2025-04-08 Thread Nitin Saxena
Hi David, Thanks, Nitin On Tue, Apr 8, 2025 at 1:05 PM David Marchand wrote: > > Hello Nitin, > > On Mon, Apr 7, 2025 at 9:48 AM Nitin Saxena wrote: > > > > Currently each rte_node registers separate mbuf dynamic fields for their > > own purpose. This leads to

[PATCH v4 0/2] node: add mbuf dynamic field for nodes

2025-04-07 Thread Nitin Saxena
can increase later based on the usage Nitin Saxena (2): node: add global node mbuf dynfield node: use node mbuf dynfield in ip4 nodes doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node/ip4_lookup.c | 14 +-- lib/node

[PATCH v4 2/2] node: use node mbuf dynfield in ip4 nodes

2025-04-07 Thread Nitin Saxena
- Used global node mbuf in ip[4|6]_lookup/rewrite nodes - Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get() Signed-off-by: Nitin Saxena --- lib/node/ip4_lookup.c | 14 --- lib/node/ip4_rewrite.c| 15 +--- lib/node/ip6_lookup.c

[PATCH v4 1/2] node: add global node mbuf dynfield

2025-04-07 Thread Nitin Saxena
are used by any two adjacent nodes. Same fields can be repurposed by any other adjacent nodes This dynfield can be also be used by out-of-tree nodes. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node

Re: [EXTERNAL] Re: [PATCH 1/2] node: add global node mbuf dynfield

2025-04-06 Thread Nitin Saxena
> > Regards, > > > Nitin > > > > > > On Tue, Apr 1, 2025 at 7:45 PM Stephen Hemminger > > > wrote: > > > > > > > > On Tue, 1 Apr 2025 09:50:46 +0530 > > > > Nitin Saxena wrote: > > > > > > > > >

[PATCH v2 0/2] node: add mbuf dynamic field for nodes

2025-04-05 Thread Nitin Saxena
overlaodable mbuf dynamic fields. Changes in v2: - removed usage of memzone for saving mbuf dynfield [Stephen] - fixed checkpatch issues - redefine RTE_NODE_MBUF_OVERLOADABLE_FIELDS_SIZE to 8 byte which are currently in use. Size can increase later based on the usage Nitin Saxena (2): node: add

Re: [PATCH 1/2] node: add global node mbuf dynfield

2025-04-04 Thread Nitin Saxena
Hi Stephen, Thanks for commenting. See response inline. Regards, Nitin On Tue, Apr 1, 2025 at 7:45 PM Stephen Hemminger wrote: > > On Tue, 1 Apr 2025 09:50:46 +0530 > Nitin Saxena wrote: > > > +int rte_node_mbuf_dynfield_register(void) > > +{ > > + struct n

[PATCH v3 2/2] node: use node mbuf dynfield in ip4 nodes

2025-04-04 Thread Nitin Saxena
- Used global node mbuf in ip[4|6]_lookup/rewrite nodes - Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get() Signed-off-by: Nitin Saxena --- lib/node/ip4_lookup.c | 14 --- lib/node/ip4_rewrite.c| 15 +--- lib/node/ip6_lookup.c

[PATCH v3 1/2] node: add global node mbuf dynfield

2025-04-04 Thread Nitin Saxena
are used by any two adjacent nodes. Same fields can be repurposed by any other adjacent nodes This dynfield can be also be used by out-of-tree nodes. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node

[PATCH v3 0/2] node: add mbuf dynamic field for nodes

2025-04-04 Thread Nitin Saxena
usage Nitin Saxena (2): node: add global node mbuf dynfield node: use node mbuf dynfield in ip4 nodes doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node/ip4_lookup.c | 14 +-- lib/node/ip4_rewrite.c

[PATCH v2 2/2] node: use node mbuf dynfield in ip4 nodes

2025-04-03 Thread Nitin Saxena
- Used global node mbuf in ip[4|6]_lookup/rewrite nodes - Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get() Signed-off-by: Nitin Saxena --- lib/node/ip4_lookup.c | 14 --- lib/node/ip4_rewrite.c| 15 +--- lib/node/ip6_lookup.c

[PATCH v2 1/2] node: add global node mbuf dynfield

2025-04-03 Thread Nitin Saxena
are used by any two adjacent nodes. Same fields can be repurposed by any other adjacent nodes This dynfield can be also be used by out-of-tree nodes. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node

[PATCH 1/2] node: add global node mbuf dynfield

2025-04-01 Thread Nitin Saxena
are used by any two adjacent nodes. Same fields can be repurposed by any other adjacent nodes This dynfield can be also be used by out-of-tree nodes. Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node

[PATCH 0/2] node: add mbuf dynamic field for nodes

2025-04-01 Thread Nitin Saxena
overlaodable mbuf dynamic fields. Nitin Saxena (2): node: add global node mbuf dynfield node: use node mbuf dynfield in ip4 nodes doc/api/doxy-api-index.md | 3 +- doc/guides/rel_notes/release_25_07.rst | 6 ++ lib/node/ip4_lookup.c | 14 +-- lib/node

[PATCH 2/2] node: use node mbuf dynfield in ip4 nodes

2025-03-31 Thread Nitin Saxena
- Used global node mbuf in ip[4|6]_lookup/rewrite nodes - Redefine node_mbuf_priv1() to rte_node_mbuf_overload_fields_get() Signed-off-by: Nitin Saxena --- lib/node/ip4_lookup.c | 14 --- lib/node/ip4_rewrite.c| 15 +--- lib/node/ip6_lookup.c

Re: [EXTERNAL] [PATCH v6 0/4] add feature arc in rte_graph

2025-01-14 Thread Nitin Saxena
a sites: Dial * then 972 0427 1800 External: Dial 97204271...@zoomcrc.com OR: Dial 144.195.19.161 (US West), enter 972 0427 1800 and # when prompted. International H323 IP addresses == Thanks, Nitin On Fri, Jan 10, 2025 at 7:29 PM Robin Jarry wrote: > > Nitin Saxena, Jan 0

Re: Feature arc slides

2025-01-07 Thread Nitin Saxena
Hi Stephen, On Mon, Jan 6, 2025 at 5:45 AM Stephen Hemminger wrote: > > On Fri, 3 Jan 2025 20:29:15 +0530 > Nitin Saxena wrote: > > > Sending to DPDK community again > > > > Thanks, > > Nitin > > Why not convert the slides into useful long term docum

[PATCH v6 4/4] app/graph: add custom feature nodes for ip4 output arc

2025-01-02 Thread Nitin Saxena
at runtime on any ethdev via CLI. graph> help feature graph> feature enable graph> feature disable graph> graph stats show Signed-off-by: Nitin Saxena --- app/graph/commands.list | 6 ++ app/graph/feature.c | 141 ++ app/graph/f

[PATCH v6 3/4] ip4: add ip4 output feature arc

2025-01-02 Thread Nitin Saxena
Added ip4 output arc to allow applications to hook feature nodes in ip4 egress direction Signed-off-by: Nitin Saxena --- lib/node/ethdev_ctrl.c | 8 + lib/node/interface_tx_feature.c | 133 lib/node/interface_tx_feature_priv.h | 33 +++ lib/node/ip4_rewrite.c

[PATCH v6 2/4] graph: add feature arc abstraction

2025-01-02 Thread Nitin Saxena
anner Signed-off-by: Nitin Saxena --- doc/api/doxy-api-index.md|2 + doc/guides/rel_notes/release_25_03.rst | 10 + lib/graph/graph_feature_arc.c| 1780 ++ lib/graph/graph_private.h|4 + lib/graph/meson.

[PATCH v6 0/4] add feature arc in rte_graph

2025-01-02 Thread Nitin Saxena
ion - Changed design to handle fast path synchronization via RCU mechanism when any feature is enabled or disabled - Added feature arc specific mbuf dynamic field to carry feature data across nodes - Added feature arc example in app/graph - Programming guide and functional test cases in future version

[PATCH v6 1/4] graph: add API to override node process function

2025-01-02 Thread Nitin Saxena
New API used by feature arc library to override node's original process() func. Signed-off-by: Nitin Saxena --- lib/graph/graph_private.h | 11 +++ lib/graph/node.c | 23 +++ 2 files changed, 34 insertions(+) diff --git a/lib/graph/graph_private.h

RE: [EXTERNAL] graph: make the in-built nodes better reusable

2024-10-21 Thread Nitin Saxena
swan, FRR etc 8. VLAN nodes (Not immediate item for us but in roadmap) Also see inline comments below. [0]: https://patches.dpdk.org/project/dpdk/cover/20241014143401.3135897-1-nsax...@marvell.com/ > -Original Message- > From: Robin Jarry > Sent: Monday, October 21, 2024 6:2

Re: [EXTERNAL] [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-17 Thread Nitin Saxena
ature arc: we need to configure > it per interface, and this is independent of the main graph. > There would be more protocols which need to be enabled per interface > WDYT? > Christophe > > > On 17 Oct 2024, at 09:50, Robin Jarry wrote: > > > > Hi Nitin, all,

Re: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-17 Thread Nitin Saxena
Hi Robin, See inline comments Thanks, Nitin On Thu, Oct 17, 2024 at 1:20 PM Robin Jarry wrote: > > Hi Nitin, all, > > Nitin Saxena, Oct 17, 2024 at 09:03: > > Hi Robin/David and all, > > > > We realized the feature arc patch series is difficult to unders

Re: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-17 Thread Nitin Saxena
which I can share, when ready, to discuss. If needed, I can also plan to present that in one of the DPDK community meetings. Their we can also discuss if there are any alternatives of achieving above objectives Thanks, Nitin . On Wed, Oct 16, 2024 at 7:20 PM Nitin Saxena wrote: > > Hi

Re: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-17 Thread Nitin Saxena
Hi Robin, Thanks for the review Please see my replies inline Thanks, Nitin On Wed, Oct 16, 2024 at 3:08 PM Robin Jarry wrote: > > Hi folks, > > David Marchand, Oct 16, 2024 at 11:24: > > On Mon, Oct 14, 2024 at 1:12 PM Nitin Saxena wrote: > >> I had pushed non R

[PATCH v5 5/5] docs: add programming guide for feature arc

2024-10-14 Thread Nitin Saxena
Updated graph library guide with feature arc Signed-off-by: Nitin Saxena --- doc/guides/prog_guide/graph_lib.rst | 288 +++ doc/guides/prog_guide/img/feature_arc-1.svg | 277 +++ doc/guides/prog_guide/img/feature_arc-2.svg | 511 doc/guides

[PATCH v5 4/5] test/graph_feature_arc: add functional tests

2024-10-14 Thread Nitin Saxena
Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_ar

[PATCH v5 3/5] graph: add IPv4 output feature arc

2024-10-14 Thread Nitin Saxena
add ipv4-output feature arc in ipv4-rewrite node to allow custom/standard nodes(like outbound IPsec policy node) in outgoing forwarding path Signed-off-by: Nitin Saxena --- lib/node/ip4_rewrite.c | 476 +--- lib/node/ip4_rewrite_priv.h | 15 +- lib/node

[PATCH v5 2/5] graph: add feature arc option in graph create

2024-10-14 Thread Nitin Saxena
Added option in graph create to call feature-specific process node functions. This removes extra overhead for checking feature arc status in nodes where application is not using feature arc processing Signed-off-by: Pavan Nikhilesh Signed-off-by: Nitin Saxena --- doc/guides/rel_notes

[PATCH v5 1/5] graph: add feature arc support

2024-10-14 Thread Nitin Saxena
add feature arc to allow dynamic steering of packets across graph nodes based on protocol features enabled on incoming or outgoing interface Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_24_11.rst | 10 + lib/graph/graph_feature_arc.c| 1236

[PATCH v5 0/5] add feature arc in rte_graph

2024-10-14 Thread Nitin Saxena
machine - Updated images in .png format - Added ABI change section in release notes - Fixed DPDK CI failures Changes in v4: - Fixed clang build compilations - Captured `feat_arc_proc` function in ABI change section of release notes Changes in v5: - Updated images in .svg format Nitin Saxena (5):

RE: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph

2024-10-14 Thread Nitin Saxena
t/dpdk/patch/20241010133111.2764712-3-nsax...@marvell.com/ Could you help merge this patch series in rc2 otherwise it has to wait for next LTS Thanks, Nitin > -Original Message- > From: David Marchand > Sent: Tuesday, October 8, 2024 1:34 PM > To: Nitin Saxena > Cc

[PATCH v4 4/5] test/graph_feature_arc: add functional tests

2024-10-10 Thread Nitin Saxena
Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_ar

[PATCH v4 2/5] graph: add feature arc option in graph create

2024-10-10 Thread Nitin Saxena
Added option in graph create to call feature-specific process node functions. This removes extra overhead for checking feature arc status in nodes where application is not using feature arc processing Signed-off-by: Pavan Nikhilesh Signed-off-by: Nitin Saxena --- doc/guides/rel_notes

[PATCH v4 3/5] graph: add IPv4 output feature arc

2024-10-10 Thread Nitin Saxena
add ipv4-output feature arc in ipv4-rewrite node to allow custom/standard nodes(like outbound IPsec policy node) in outgoing forwarding path Signed-off-by: Nitin Saxena --- lib/node/ip4_rewrite.c | 476 +--- lib/node/ip4_rewrite_priv.h | 15 +- lib/node

[PATCH v4 1/5] graph: add feature arc support

2024-10-10 Thread Nitin Saxena
add feature arc to allow dynamic steering of packets across graph nodes based on protocol features enabled on incoming or outgoing interface Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_24_11.rst | 10 + lib/graph/graph_feature_arc.c| 1236

[PATCH v4 0/5] add feature arc in rte_graph

2024-10-10 Thread Nitin Saxena
found in testing - Added new public APIs rte_graph_feature_arc_feature_to_node(), rte_graph_feature_arc_feature_to_name(), rte_graph_feature_arc_num_features() - Added programming guide for feature arc - Added release notes for feature arc Nitin Saxena (5): graph: add feature arc support graph: add fe

RE: [RFC PATCH 1/3] graph: add feature arc support

2024-10-09 Thread Nitin Saxena
Hi Kiran, See my inline comments. Somehow I forgot to respond earlier Thanks, Nitin > -Original Message- > From: Kiran Kumar Kokkilagadda > Sent: Wednesday, September 11, 2024 10:11 AM > To: Nitin Saxena ; Jerin Jacob ; > Nithin Kumar Dabilpuram ; Zhirun Yan >

RE: [EXTERNAL] Re: [PATCH v3 0/5] add feature arc in rte_graph

2024-10-09 Thread Nitin Saxena
Thanks Stephen. Will fix compilation in next version. Thanks, Nitin > -Original Message- > From: Stephen Hemminger > Sent: Wednesday, October 9, 2024 11:08 PM > To: Nitin Saxena > Cc: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Zhiru

RE: [EXTERNAL] Re: [PATCH v3 0/5] add feature arc in rte_graph

2024-10-09 Thread Nitin Saxena
Hi Christophe, Thanks for the review. See my comments inline Thanks, Nitin > -Original Message- > From: Christophe Fontaine > Sent: Wednesday, October 9, 2024 7:51 PM > To: Nitin Saxena > Cc: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram >

[PATCH v3 4/5] test/graph_feature_arc: add functional tests

2024-10-09 Thread Nitin Saxena
Added functional unit test case for verifying feature arc control plane and fast path APIs How to run: $ echo "graph_feature_arc_autotest" | ./bin/dpdk-test Signed-off-by: Nitin Saxena --- app/test/meson.build |1 + app/test/test_graph_feature_ar

[PATCH v3 3/5] graph: add IPv4 output feature arc

2024-10-09 Thread Nitin Saxena
add ipv4-output feature arc in ipv4-rewrite node to allow custom/standard nodes(like outbound IPsec policy node) in outgoing forwarding path Signed-off-by: Nitin Saxena --- lib/node/ip4_rewrite.c | 476 +--- lib/node/ip4_rewrite_priv.h | 15 +- lib/node

  1   2   >