Re: [PATCH v1] Remove Owen Hilyard as a DTS Maintainer

2023-02-07 Thread Owen Hilyard
On Tue, Feb 7, 2023 at 10:53 AM Thomas Monjalon wrote: > 07/02/2023 15:42, ohily...@iol.unh.edu: > > From: Owen Hilyard > > > > I (Owen Hilyard) am stepping down as a DTS maintainer. > > Thanks for your work Owen, you will be missed. > Hope we'll see you aga

Re: [PATCH v3 00/10] dts: add hello world testcase

2023-01-19 Thread Owen Hilyard
Everything looks good to me with the exception of some issues I ran into with terminal codes. Setting TERM=dumb before running fixed it, but we might want to set that inside of DTS since I can't think of a reason why we would need colors or any of the other "fancy" features of the vt220, and settin

Re: Mysterious CI/IOL failures in Patchwork

2022-12-07 Thread Owen Hilyard
address will send the email to everyone involved with DPDK here at UNH so you will usually get faster response times. Sorry for any inconvenience Owen Hilyard

Re: [RFC PATCH v2 04/10] dts: add dpdk execution handling

2022-11-28 Thread Owen Hilyard
On Wed, Nov 23, 2022 at 8:03 AM Juraj Linkeš wrote: > Again, apologies for removing recipients in my earlier reply. > > > > *From:* Owen Hilyard > *Sent:* Monday, November 21, 2022 1:40 PM > *To:* Juraj Linkeš > *Subject:* Re: [RFC PATCH v2 04/10] dts: add dpdk execu

Re: [RFC PATCH v2 08/10] dts: add testsuite class

2022-11-16 Thread Owen Hilyard
On Mon, Nov 14, 2022 at 11:54 AM Juraj Linkeš wrote: > This is the base class that all test suites inherit from. The base class > implements methods common to all test suites. The derived test suites > implement tests and any particular setup needed for the suite or tests. > > Signed-off-by: Jura

Re: [RFC PATCH v2 07/10] dts: add simple stats report

2022-11-16 Thread Owen Hilyard
You are missing type annotations throughout this. On Mon, Nov 14, 2022 at 11:54 AM Juraj Linkeš wrote: > Provide a summary of testcase passed/failed/blocked counts. > > Signed-off-by: Juraj Linkeš > --- > dts/framework/dts.py| 3 ++ > dts/framework/stats_reporter.py | 65 +

Re: [RFC PATCH v2 05/10] dts: add node memory setup

2022-11-16 Thread Owen Hilyard
On Mon, Nov 14, 2022 at 11:54 AM Juraj Linkeš wrote: > Setup hugepages on nodes. This is useful not only on SUT nodes, but > also on TG nodes which use TGs that utilize hugepages. > > Signed-off-by: Juraj Linkeš > --- > dts/framework/remote_session/__init__.py | 1 + > dts/framework/remot

Re: [RFC PATCH v2 04/10] dts: add dpdk execution handling

2022-11-16 Thread Owen Hilyard
On Mon, Nov 14, 2022 at 11:54 AM Juraj Linkeš wrote: > Add methods for setting up and shutting down DPDK apps and for > constructing EAL parameters. > > Signed-off-by: Juraj Linkeš > --- > dts/conf.yaml | 4 + > dts/framework/config/__init__.py |

Re: [RFC PATCH v2 03/10] dts: add dpdk build on sut

2022-11-16 Thread Owen Hilyard
On Mon, Nov 14, 2022 at 11:54 AM Juraj Linkeš wrote: > Add the ability to build DPDK and apps, using a configured target. > > Signed-off-by: Juraj Linkeš > --- > dts/framework/exception.py| 17 +++ > dts/framework/remote_session/os/os_session.py | 90 +++- > .../re

Re: [PATCH] devtools: set DTS directory to format check

2022-11-09 Thread Owen Hilyard
er > lint=false > ;; > - *) > + ?) > + usage > + exit 1 > esac > done > +shift $(($OPTIND - 1)) > > +directory=${1:-$(dirname $0)/../dts} > +cd $directory || exit 1 > > errors=0 > > -- > 2.36.1 > > Looks good to me. Reviewed-by: Owen Hilyard

Re: [PATCH v8 0/9] dts: ssh connection to a node

2022-11-09 Thread Owen Hilyard
On Wed, Nov 9, 2022 at 11:23 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > > > > > > 04/11/2022 12:05, Juraj Linkeš: > > > All the necessary code needed to connect to a node in a topology with > > > a bit more, such as basic logging and some extra useful methods. > > > > Applie

Re: testpmd logging

2022-11-08 Thread Owen Hilyard
On Tue, Nov 8, 2022 at 9:37 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > + Lijuan, Owen, Juraj > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, November 8, 2022 7:02 AM > > To: Aman Singh ; Yuying Zhang > > > > Cc: david.march...@redhat.com; dev@d

Re: [PATCH v6 00/10] dts: ssh connection to a node

2022-11-02 Thread Owen Hilyard
On Mon, Oct 31, 2022 at 3:01 PM Thomas Monjalon wrote: > I was about to merge this series, > and after long thoughts, it deserves a bit more changes. > I would like to work with you for a merge in 22.11-rc3. > > 13/10/2022 12:35, Juraj Linkeš: > > All the necessary code needed to connect to a nod

Re: [PATCH v5 00/10] dts: ssh connection to a node

2022-10-11 Thread Owen Hilyard
s. > Reworked SSH implementation - split it so that the split between an > abstraction and the actual implementation is clearer. > Modified the directory structure to better organize the current and the > future code. > > Juraj Linkeš (9): > dts: add project tools config > d

Re: [PATCH v4 4/9] dts: add ssh pexpect library

2022-09-19 Thread Owen Hilyard
On Wed, Sep 14, 2022 at 3:57 PM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > > > > > > > > On Fri, Jul 29, 2022 at 10:55:45AM +, Juraj Linkeš wrote: > > > > > > > +self.session = pxssh.pxssh(encoding="utf-8") > > > > +self.

Re: [PATCH v4 5/9] dts: add ssh connection extension

2022-09-14 Thread Owen Hilyard
> > On Wed, Sep 14, 2022 at 3:46 AM Bruce Richardson < > bruce.richard...@intel.com> wrote: > > On Fri, Jul 29, 2022 at 10:55:46AM +, Juraj Linkeš wrote: > > > The class adds logging and history records to existing pexpect > > methods. >

Re: [PATCH v4 6/9] dts: add config parser module

2022-09-13 Thread Owen Hilyard
> > +# Frozen makes the object immutable. This enables further optimizations, > > +# and makes it thread safe should we every want to move in that > direction. > > +@dataclass(slots=True, frozen=True) > > +class NodeConfiguration: > > +name: str > > +hostname: str > > +user: str > > +

Re: [PATCH v4 5/9] dts: add ssh connection extension

2022-09-13 Thread Owen Hilyard
> > On Fri, Jul 29, 2022 at 10:55:46AM +, Juraj Linkeš wrote: > > The class adds logging and history records to existing pexpect methods. > > > > Signed-off-by: Owen Hilyard > > Signed-off-by: Juraj Linkeš > > --- >

Re: [PATCH v4 4/9] dts: add ssh pexpect library

2022-09-13 Thread Owen Hilyard
> > On Fri, Jul 29, 2022 at 10:55:45AM +, Juraj Linkeš wrote: > > > +self.session = pxssh.pxssh(encoding="utf-8") > > +self.session.login( > > +self.node, > > +self.username, > > +self.password, > > +

Re: [PATCH v4 1/9] dts: add project tools config

2022-09-12 Thread Owen Hilyard
; static analysis Isort, import sorting > > > > > > > > > > .editorconfig modifies the line length to 88, which is the default > > > > > Black uses. It seems to be the best of all worlds. [0] > > > > > > > > > > [0] > &

[RFC] DPDK Distro Support Policies

2022-08-24 Thread Owen Hilyard
widespread use. Additionally, "binary compatible" distros will have a single distro selected for testing. For example, RHEL 7 will be treated as providing testing for CentOS 7. Owen Hilyard UNH InterOperability Lab

DTS WG Meeting Minutes - 5/15

2022-06-16 Thread Owen Hilyard
This meeting had a lot of book-keeping. In previous meetings we've had to skip reviewing some action items due to time constraints. This meeting we had time to review most of them, so we have a larger-than-normal "Review Action Items" section. Attendees - Owen Hilyard

Re: [PATCH v1 0/4] [RFC] Testpmd RPC API

2022-04-14 Thread Owen Hilyard
t; Hi everyone, > > First of all thanks Owen for stepping forward with this RFC. > Few thoughts on this subject below. > Konstantin > > > -Original Message- > > From: Ananyev, Konstantin > > Sent: Thursday, April 14, 2022 12:59 PM > > To: Ananyev, Konsta

Re: [PATCH v1 0/4] [RFC] Testpmd RPC API

2022-04-13 Thread Owen Hilyard
y plan is to leave unit testing in C, but help make it easier to expose C functions to Python for integration testing. This gives us the best of both worlds in terms of access to DPDK and the ability to use a high-level language to write the tests. On Tue, Apr 12, 2022 at 2:07 AM Jerin Jacob wro

Re: [RFC PATCH v1 00/15] merge DTS core files to DPDK

2022-04-11 Thread Owen Hilyard
> > 3) In my private discussions with David Marchand, he expressed interest > in getting the git log history. The current review process will not help in > this regard. Is this a must? If yes, are there any known methods to do this? The git docs point to https://github.com/newren/git-filter-repo

Re: [PATCH v1 0/4] [RFC] Testpmd RPC API

2022-04-11 Thread Owen Hilyard
> > scheme is probably over-engineered I tried my hardest to keep this as simple as possible. The requirements imposed by DTS being a distributed system in Python restricted what I could do a lot. Needing to be compatible with DPDK's license also got rid of a lot of options. Binding generators ar

DTS Improvement Working Group Minutes (March 2)

2022-03-09 Thread Owen Hilyard
Attendees - Owen Hilyard - Honnappa Nagarahalli - Lijuan Tu - Lincoln Lavoie Agenda - Additions to the agenda - Review/Carry forward pending action items - Review DTS DPDK Modifications excel sheet - Merging DTS into DPDK - Review

Re: [PATCH v1] drivers/net: use internal API to get eth dev from name

2022-02-10 Thread Owen Hilyard
The latest script in CI correctly selects 'next-net' for this patch. >

Re: [RFC] Testpmd Maintenance affecting DTS

2022-02-09 Thread Owen Hilyard
r something similar that is designed to perform cross-language RPC easily, in which case directly exposing RPC in C might be much easier. Owen Hilyard

[RFC] Testpmd Maintenance affecting DTS

2022-02-08 Thread Owen Hilyard
Currently, DTS tests DPDK via the example applications (/examples) and the apps (/app) included with DPDK. The DTS Working group has been trying to move to primarily using Testpmd, since it is the most complete and only using one application causes less maintenance work. Since Testpmd provides a te

Re: [PATCH v1] drivers/net: use internal API to get eth dev from name

2022-02-07 Thread Owen Hilyard
The Community CI hasn't been able to schedule downtime to update dpdk-ci across all of our systems since the refactoring Ali did. However, the patch was still applied on next-net and had a compilation error. See https://lab.dpdk.org/results/dashboard/patchsets/20895/. It was applied onto https://gi

Re: [RFC] Python Version for DTS

2022-02-02 Thread Owen Hilyard
After some discussion in the working group, we decided that this is mostly a question of what the labs can support. The UNH Lab uses the version of python that ships with the latest Ubuntu LTS, which is 3.8. The Intel Lab is in a similar situation. Are there any objections to python 3.8 with update

DTS WG Meeting Minutes 1/19/22

2022-01-26 Thread Owen Hilyard
, 2022Attendees - Owen Hilyard - Lincoln Lavoie - Lijuan Tu - Juraj Linkes - Honnappa Nagarahalli Agenda - Review/Carry forward pending action items - Merging DTS into DPDK - Review additional work items MinutesReview/Carry forward pending

[RFC] Python Version for DTS

2022-01-20 Thread Owen Hilyard
Community CI Lab perspective is that versions higher than 3.8 are not acceptable due to the issues with changing the default Python installation on Ubuntu. This may be raised to 3.10 in June of this year after we have had time to evaluate the 22.04 release of Ubuntu. Owen Hilyard

Re: [RFC] DTS Commit Policies

2022-01-18 Thread Owen Hilyard
/edit On Mon, Jan 17, 2022 at 7:23 AM Juraj Linkeš wrote: > > > > > *From:* Owen Hilyard > *Sent:* Wednesday, January 12, 2022 4:08 PM > *To:* dev ; d...@dpdk.org > *Subject:* [RFC] DTS Commit Policies > > > > Hello Everyone, > > > > The DTS Work

[RFC] DTS Commit Policies

2022-01-12 Thread Owen Hilyard
purpose of the commit policies is to help standardize the code that makes up DTS, as well as help new additions meet community requirements, such as avoiding breaking changes, ensuring runtime stability, and aiding debugability. Owen Hilyard DTS Working Group meeting room: https://armltd.zoom.us/j

Re: [dpdk-dev] [dpdk-ci] [PATCH v12 01/10] eal: add basic threading functions

2021-08-03 Thread Owen Hilyard
Our windows servers are both running 0.57.1, but all of the *nix hosts are running 0.58.1. This issue also happens on 0.57.1 and 0.57.2, with the exact same steps to reproduce. On Tue, Aug 3, 2021 at 11:38 AM Dmitry Kozlyuk wrote: > 2021-08-03 11:11 (UTC-0400), Owen Hilyard: > > It s

Re: [dpdk-dev] [dpdk-ci] [PATCH v12 01/10] eal: add basic threading functions

2021-08-03 Thread Owen Hilyard
It seems like meson encountered an error when building app/test/meson.build:472:11: ERROR: Index 1 out of bounds of array of size > 1. > > A full log can be found at > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/build/meson-logs/meson-log.txt > ninja: error: loadi

Re: [dpdk-dev] Memory leak in rte_pci_scan

2021-06-14 Thread Owen Hilyard
te: > On Mon, Jun 14, 2021 at 11:11 AM David Marchand > wrote: > > > > On Tue, Jun 8, 2021 at 8:48 PM Owen Hilyard > wrote: > > > > > > Hello All, > > > > > > As part of the community lab's work to deploy static analysis tools, >

Re: [dpdk-dev] [dts] [PATCH] malloc: fix size annotation for NUMA-aware realloc

2021-06-11 Thread Owen Hilyard
That test suite has been disabled on the system. Someone of the Intel team should be looking at it soon, since stats_checks also has similar issues. On Fri, Jun 11, 2021 at 3:40 AM David Marchand wrote: > On Fri, Jun 11, 2021 at 9:26 AM David Marchand > wrote: > > > > On Thu, Jun 10, 2021 at 2:

Re: [dpdk-dev] Define statement with UB prevents compilation using UBSAN

2021-06-11 Thread Owen Hilyard
. On Fri, Jun 11, 2021 at 10:34 AM Aaron Conole wrote: > Stephen Hemminger writes: > > > On Thu, 10 Jun 2021 16:51:37 -0400 > > Owen Hilyard wrote: > > > >> Working backward to the define > >> statement, AEU_INPUTS_ATTN_BI

[dpdk-dev] Define statement with UB prevents compilation using UBSAN

2021-06-10 Thread Owen Hilyard
r as I know, some of these drivers don't have DTS run on them in the course of CI, so I'm somewhat wary of trying to make a change to them. Until this is fixed, deploying UBSAN in any real capacity won't be useful since every patch will fail. What do the two of you think about steps moving forward on this problem? Owen Hilyard

Re: [dpdk-dev] [dpdk-ci] [PATCH v2] pmdinfogen: allow padding after NUL terminator

2021-06-09 Thread Owen Hilyard
Hi Dmitry, Those failures are the result of a known issue with that machine. Those tests were disabled on that machine shortly after you submitted that patch. I've re-run the patch. Owen Hilyard On Wed, Jun 9, 2021 at 12:48 PM Dmitry Kozlyuk wrote: > 2021-06-09 12:01 (UTC-0400),

[dpdk-dev] Memory leak in rte_pci_scan

2021-06-08 Thread Owen Hilyard
ce the log itself is too large for the mailing list. Test Output: https://drive.google.com/file/d/1NejCuba-HnvH9MMg7thBdGuOhQBXKiFh/view?usp=sharing Owen Hilyard

[dpdk-dev] dpdk-next-crypto/master is failing tests

2021-05-05 Thread Owen Hilyard
The Intel 10G and Intel 40G systems at the community lab had test jobs begin to crash a few hours ago. This was the result of DTS crashing severely enough that the job was unable to continue. A brief investigation makes it seem like the "-a" flag for testpmd has been removed, which is causing the t

[dpdk-dev] Rx interrupt testing

2020-08-07 Thread Owen Hilyard
ould submit a ticket to get a feature like that added into testpmd. I'd also appreciate any ideas for test cases. Thanks Owen Hilyard

Re: [dpdk-dev] Userspace testing

2020-08-03 Thread Owen Hilyard
On Fri, Jul 31, 2020 at 5:12 AM Burakov, Anatoly wrote: > On 30-Jul-20 5:54 PM, Owen Hilyard wrote: > > Thanks for the advice. > > > > I was wondering about the state of the "Setup VFIO permissions" option > > in the setup script. It seems to just modify t

Re: [dpdk-dev] Userspace testing

2020-07-30 Thread Owen Hilyard
29, 2020 at 11:35 AM Burakov, Anatoly wrote: > On 29-Jul-20 3:34 PM, Owen Hilyard wrote: > > Hello all, > > > > I was wondering what everyone's thoughts on doing both userspace testing > > and unprivileged testing of dpdk applications is. DTS currently runs all >

[dpdk-dev] Userspace testing

2020-07-29 Thread Owen Hilyard
Hello all, I was wondering what everyone's thoughts on doing both userspace testing and unprivileged testing of dpdk applications is. DTS currently runs all commands on the tester and the dut as the root user. Please correct me if I'm wrong, but I was under the assumption that most applications wr

[dpdk-dev] Fwd: Request for High Priority Features

2020-07-28 Thread Owen Hilyard
-- Forwarded message - From: Owen Hilyard Date: Tue, Jul 28, 2020 at 8:04 AM Subject: Request for High Priority Features To: Hello Everyone, Those of us at the IOL have been working on new DTS test cases for a while now, and we are starting to get to the point where we&#x

[dpdk-dev] Multicast MAC Filter Test Case

2020-07-02 Thread Owen Hilyard
test cases for this feature are also welcome. Thanks for your help, Owen Hilyard

Re: [dpdk-dev] Hardware Checksum Checks Offload Feature

2020-06-29 Thread Owen Hilyard
to an existing version, or drop the protocol from the test matrix without community input. Thoughts? On Thu, Jun 25, 2020 at 11:54 AM Owen Hilyard wrote: > I can do that. > > Thanks for the clarification > > On Thu, Jun 25, 2020 at 11:25 AM Thomas Monjalon > wrote: > >>

Re: [dpdk-dev] Hardware Checksum Checks Offload Feature

2020-06-25 Thread Owen Hilyard
I can do that. Thanks for the clarification On Thu, Jun 25, 2020 at 11:25 AM Thomas Monjalon wrote: > > > I think you should describe all the protocols you want to test. > > > > Could you please elaborate on this? > > I mean doing a test matrix inluding IP, TCP, UDP, VXLAN, GENEVE, etc. > > >

Re: [dpdk-dev] Hardware Checksum Checks Offload Feature

2020-06-25 Thread Owen Hilyard
Hello, In regards to the outer layers, having grepped through the code for "[\w_]+_GOOD|[\w_]+_BAD", I wasn't able to find the flags that I expected. I expected something like PKT_RX_OUTER_IP_CKSUM_BAD and PKT_RX_OUTER_IP_CKSUM_GOOD to show up since that seems to be the format for flags to be prin

[dpdk-dev] Hardware Checksum Checks Offload Feature

2020-06-24 Thread Owen Hilyard
to enable these checks aside from the checksum aside from TestChecksumOffload::checksum_enablehw. Thanks, Owen Hilyard Software Developer UNH Interoperability Lab