I have unfortunately no longer time enough for maintaining Tap PMD.
Keith has kindly volunteered to take over maintainership. He's been at
the origin of this PMD and knows well how it works.
Signed-off-by: Pascal Mazon
Acked-by: Keith Wiles
---
MAINTAINERS | 2 +-
1 file changed, 1 inse
Ok Ferruh, I missed that.
Apart for the type in "documentation" the patches are ok with me.
Acked-by: Pascal Mazon
On 03/04/2018 12:05, Ferruh Yigit wrote:
> On 4/3/2018 9:27 AM, Pascal Mazon wrote:
>> Hi,
>>
>> I'm not sure why you split this patch in two.
Hi,
I'm not sure why you split this patch in two.
It seemed to me that it was fine to change the doc+logs in the same
patch as the code.
Especially since documentation change is very small.
Anyway, there's just the "documnetation" typo in the commit title,
otherwise it's fine by me.
Best regards
don't use that variable much, I'm ok with it.
Acked-by: Pascal Mazon
On 26/02/2018 07:15, Vipin Varghese wrote:
> The change adds TUN PMD logic to the existing TAP PMD. TUN PMD can
> be initialized with 'net_tunX' where 'X' represents unique id. PMD
> supp
memory from that socket only.
In that case, allocation will fail.
To address this, use master lcore instead when called from mgmt thread.
The associated socket should have memory available.
Fixes: ec94dbc57362 ("qede: add base driver")
Cc: sta...@dpdk.org
Signed-off-by: Pascal Mazon
case, allocation will fail.
To address this, use master lcore instead when called from mgmt thread.
The associated socket should have memory available.
Fixes: ec94dbc57362 ("qede: add base driver")
Cc: sta...@dpdk.org
Signed-off-by: Pascal Mazon
---
drivers/net/qede/base/bcm_osal.c
Personally, I'm mostly ok with this.
I added a couple of comments inline.
On 21/02/2018 00:12, Vipin Varghese wrote:
> The change adds TUN PMD logic to the existing TAP PMD. TUN PMD can
> be initialized with 'net_tunX' where 'X' represents unique id. PMD
> supports argument interface, while MAC ad
Acked-by: Pascal Mazon
On 12/02/2018 15:44, Vipin Varghese wrote:
> Allow TAP PMD to pass user desired MAC address as argument.
> The argument value is processed as string delimited by ':',
> is parsed and converted to HEX MAC address after validation.
>
> Sign
Good job. Looks ok to me.
Acked-by: Pascal Mazon
On 14/02/2018 12:32, Ophir Munk wrote:
> Running testpmd command "port stop all" followed by command "port start
> all" may result in a TAP error:
> PMD: Kernel refused TC filter rule creation (17): File exists
>
&
Hi Ophir,
Typo in title: s/insersions/insertions/
I'm ok on principle, I have just a few comments inline.
Regards,
Pascal
On 13/02/2018 19:35, Ophir Munk wrote:
> Running testpmd command "port stop all" followed by command "port start
> all" may result in a TAP error:
> PMD: Kernel refused TC f
Acked-by: Pascal Mazon
On 13/02/2018 14:22, Matan Azrad wrote:
> The current implementation of the Tap PMD doesn't support packet size
> grater than 1522B, so no need to set jumbo frames in the Tap features.
>
> Fixes: 04b2c3c94346 ("doc: add tap features")
> Cc:
Acked-by: Pascal Mazon
On 08/02/2018 15:54, Ophir Munk wrote:
> Signed-off-by: Ophir Munk
> ---
> doc/guides/nics/tap.rst | 22 +-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guides/nics/tap.rst b/doc/guides/nics/tap.rst
> i
Acked-by: Pascal Mazon
On 05/02/2018 17:17, Moti Haimovsky wrote:
> This patch complements the partial cleanup done inside
> eth_dev_tap_create when the routine failed.
> Such a failure left a non-functional device attached to the system.
>
> Fixes: 050fe6e9ff97 ("dri
From: Vipin Varghese
Allow TAP PMD to pass user desired MAC address as argument.
The argument value is processed as string, where each 2 bytes
are converted to HEX MAC address after validation.
Signed-off-by: Vipin Varghese
Signed-off-by: Pascal Mazon
---
Hi Vipin,
I suggest the following
Acked-by: Pascal Mazon
On 05/02/2018 11:59, Ophir Munk wrote:
> TAP device is supporting multi segments Tx, however this capability is
> not reported when querying the TAP device.
> This commit adds this capability report.
>
> Fixes: 818fe14a9891 ("net/tap: use new Tx offl
The mitigation is good enough, random packets are more likely to have
cb[1] == 0 than something above 7cafe800.
Acked-by: Pascal Mazon
On 05/02/2018 15:40, Ophir Munk wrote:
> The eBPF classifier (section "cls_q" in tap_bpf_program.c) is tracing
> marked packets in which skb-&g
Hi,
You didn't address my request about not using a global value. Was there
a good reason?
I paste it here again as a reminder:
Can you also not use a global value for user_mac, but instead change the
last argument for eth_dev_tap_create():
Use directly a char mac[ETHER_ADDR_LEN], automati
The patches look good to me.
Good catch.
Acked-by: Pascal Mazon for the series.
On 30/01/2018 17:00, Ophir Munk wrote:
> v2:
> fix eBPF RSS map key handling
>
> v1:
> fix eBPF file descriptors leakage
>
> Ophir Munk (2):
> net/tap: fix eBPF file descriptors leakage
&
Acked-by: Pascal Mazon
On 30/01/2018 08:05, Gowrishankar wrote:
> From: Gowrishankar Muthukrishnan
>
> This patch defines __NR_bpf for powerpc architecture and hence,
> fixes compiling tap driver for this architecture.
>
> Fixes: b02d85e1 ("net/tap: add eBPF
Acked-by: Pascal Mazon
On 04/01/2018 16:44, Moti Haimovsky wrote:
> This patch adds support for registering and waiting for Rx interrupts.
> This allows applications to wait for Rx events from the PMD using the
> DPDK rte_epoll subsystem.
>
> Signed-off-by: Moti Haimovsky
>
g that later patches are expected in next release.
Acked-by: Pascal Mazon
Best regards,
Pascal
On 18/01/2018 14:38, Ophir Munk wrote:
> The patches of TAP RSS eBPF follow the RFC on this issue
> https://dpdk.org/dev/patchwork/patch/31781/
>
> v5 changes with respect to v4
> ===
I have no objection to having the 10G default speed on tap.
On 17/01/2018 17:22, Ferruh Yigit wrote:
> On 1/17/2018 4:14 PM, Wiles, Keith wrote:
>>
>>> On Jan 17, 2018, at 10:06 AM, Yigit, Ferruh wrote:
>>>
>>> On 12/21/2017 1:38 PM, Wiles, Keith wrote:
> On Dec 21, 2017, at 10:53 AM, Vi
Acked-by: Pascal Mazon for the series.
On 17/01/2018 15:04, Moti Haimovsky wrote:
> Ethdev Tx offloads API has changed since:
> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")
> This commit adds support for the new Tx offloads API.
>
> Signed-off-by: M
Acked-by: Pascal Mazon
On 10/01/2018 17:20, Moti Haimovsky wrote:
> Ethdev Rx offloads API has changed since:
> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
> This commit support the new Rx offloads API.
>
> Signed-off-by: Moti Haimovsky
> ---
>
Ok, now I get why ARRAY_SIZE was where it was. Nevermind.
I think you're doing too much in one patch. As the subject is not
trivial, I would rather have it split.
Can you make a first patch that just adds support for several actions,
then your patch that adds BPF rule support?
Otherwise your code
Hi Ophir,
I have a few remarks.
- Why do you define ARRAY_SIZE in tap_flow.h while it's used only in
tap_bpf_insns.c?
- I really dislike having the BPF bytecode hardcoded in tap_bpf_insns.c.
You don't provide the commands used to generate that bytecode.
And you don't provide the way to trans
Hi,
As you did in the previous patch, you can use less parentheses for this
line:
+ if (((port_offloads ^ offloads) & port_supp_offloads))
Otherwise ok.
Best regards,
Pascal
On 04/01/2018 20:18, Moti Haimovsky wrote:
> Ethdev Rx offloads API has changed since:
> commit ce17eddefc20 ("ethdev: i
Hi,
Good job, this patch looks good to me.
Acked-by: Pascal Mazon
On 04/01/2018 20:18, Moti Haimovsky wrote:
> Ethdev Tx offloads API has changed since:
> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")
> This commit support the new Tx offloads API.
>
Hi,
Can you also not use a global value for user_mac, but instead change the
last argument for eth_dev_tap_create():
Use directly a char mac[ETHER_ADDR_LEN], automatic variable from
rte_pmd_tap_probe().
In set_mac_type(), you can check either for "fixed" or a correct custom
mac address.
Then eth_d
Indeed, the spirit of the initial work was to publish source code,
compiled BPF bytecode, and Makefile for re-generating the latter.
I have no clue regarding licensing, I'll trust you guys on that.
On 30/11/2017 18:39, Thomas Monjalon wrote:
> 30/11/2017 18:20, Stephen Hemminger:
>> On Thu, 30 Nov
eBPF is effective only when running
> with an appropriate kernel version. It must be compiled with the
> appropriate Linux kernel headers. In case the kernel headers do
> not include eBPF definitions a warning will be issued during
> compilation time and TAP RSS will not be supported.
Hi,
The patch looks globally fine to me.
I'll inline just one comment.
Best regards,
Pascal
On 20/11/2017 14:59, Moti Haimovsky wrote:
> This patch adds support for registering and waiting for Rx interrupts.
> This allows applications to wait for Rx events from the PMD using the
> DPDK rte_epoll
On 25/10/2017 03:24, Ferruh Yigit wrote:
> On 9/19/2017 5:45 AM, Pascal Mazon wrote:
>> Hi,
>>
>> The patch looks mainly ok to me.
>>
>> I'll put some comments inline.
>>
>> On 18/09/2017 20:47, Ferruh Yigit wrote:
>>> From: Vipin
>> On 10/4/2017 9:15 AM, Pascal Mazon wrote:
>>> Hi,
>>>
>>> I'm surprised there's only one place in the file with indent problem,
>>> but I'm ok with the patch otherwise.
>>>
>>> Ferruh, I didn't get what you mean; M
Hi,
I was a little too quick earlier. The line breaks are justified because
they follow the list of variable declarations.
So I ack the whole patch series.
Acked-by: Pascal Mazon
On 04/10/2017 10:19, Pascal Mazon wrote:
> Hi,
>
> What you say stands to reason, I'm basically ok w
Hi,
What you say stands to reason, I'm basically ok with your patch, except
for one remark.
The rest of the file has no line breaks anywhere, please remove the two
you added.
Best regards,
Pascal
On 03/10/2017 16:55, Matan Azrad wrote:
> One of the main identified use cases for the tap PMD is to
Hi,
I'm surprised there's only one place in the file with indent problem,
but I'm ok with the patch otherwise.
Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in
patch 2/2, right?
Best regards,
Pascal
On 04/10/2017 00:07, Ferruh Yigit wrote:
> On 10/3/2017 3:55 PM, Matan Azrad
Acked-by: Pascal Mazon
On 20/09/2017 15:03, Thomas Monjalon wrote:
> The flow API is supported in TAP PMD if flower is supported in Linux.
> Some commands are combined to suggest a convenient check of its support
> by the running kernel.
>
> Signed-off-by: Thomas Monjalon
>
Hi,
The patch looks mainly ok to me.
I'll put some comments inline.
On 18/09/2017 20:47, Ferruh Yigit wrote:
> From: Vipin Varghese
>
> tap speed argument is not working without generating any error.
Can you describe the error, paste the log?
>
> This patch sets the configured speed during devi
Looks good.
Best regards,
Pascal
Acked-by: Pascal Mazon
On 18/09/2017 20:47, Ferruh Yigit wrote:
> From: Vipin Varghese
>
> tap_intr_handle_set() called by tap_dev_start(), and if LSC is disabled
> (dev_conf.intr_conf.lsc == 0), it tries to unregister interrupt
> callback witho
Hi,
Your reasons to keep *dev in pmd_internals are good enough for me!
The rest of the patch looks fine.
Acked-by: Pascal Mazon
On 17/09/2017 00:32, Ophir Munk wrote:
> This commit fixes two bugs related to tap devices. The first bug occurs
> when executing in testpmd the following flo
Hi,
The patch looks good globally, but I have a few comments/requests, inline.
Best regards,
Pascal
On 14/09/2017 17:07, Ophir Munk wrote:
> This commit fixes two bugs related to tap devices. The first bug occurs
> when executing in testpmd the following flow rule assuming tap device has
> 4 rx
Ok for me.
Cheers,
Pascal
Acked-by: Pascal Mazon
On 07/17/2017 11:00 AM, Raslan Darawsheh wrote:
Remove checks of Linux kernel version
in order to support kernel with backported features.
the expected behavior with a kernel that doesn't support flower
and other bits is the foll
Hello Raslan,
So I've compiled your code, and it looks fine.
Just one remark:
When trying to _create_ a rule, the error message keep stating
"overlapping rules".
That was fine before, at it was the main cause of error.
But now it is also likely that the error comes from the kernel not
suppor
Hi Raslan,
Your patch looks ok at first glance. However, I couldn't test it as it
does not apply on a
fresh next-net branch. Can you send a v2 after rebase?
Thank you.
Pascal
On 07/10/2017 10:13 AM, Raslan Darawsheh wrote:
Remove checks of Linux kernel version
in order to support kernel wit
Acked-by: Pascal Mazon
On 07/06/2017 05:28 PM, Thomas Monjalon wrote:
Some logs are missing the newline character \n.
The logs using only line can be checked with this command:
git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/
Fixes: 02f96a0a82d1 ("net/ta
Hi,
Looks good to me.
Acked-by: Pascal Mazon
On 06/27/2017 02:33 PM, Thomas Monjalon wrote:
When exiting a DPDK application, the TAP remote was left
with the link down even if it was initially up.
The device flags of the remote netdevice are saved when probing,
and restored when calling the
Hi Chillance, Ferruh,
Can you give the complete command line you used, with output?
(typically, are you using the remote feature)
As Ferruh said, it may be that you don't have the module loaded.
However in that case there should have been an error message earlier,
like "Unable to create TAP i
redirect packets to the
tap.
Signed-off-by: Pascal Mazon
---
This patch depend on isolate mode:
http://dpdk.org/dev/patchwork/patch/24488/
drivers/net/tap/rte_eth_tap.c | 10 +--
drivers/net/tap/rte_eth_tap.h | 1 +
drivers/net/tap/tap_flow.c| 169
> On 5/22/2017 12:20 PM, Pascal Mazon wrote:
> > This patch adds basic offloading support, widely expected in a PMD.
> >
> > Verify IPv4 and UDP/TCP checksums upon packet reception, and set
> > ol_flags accordingly.
> >
> > On Tx, set IPv4 and UDP/TCP checks
This patch adds basic offloading support, widely expected in a PMD.
Verify IPv4 and UDP/TCP checksums upon packet reception, and set
ol_flags accordingly.
On Tx, set IPv4 and UDP/TCP checksums when required, considering
ol_flags.
Signed-off-by: Pascal Mazon
---
doc/guides/nics/features
; or "ipv6".
For TC, they could thus not have the same priority.
Use ETH_P_ALL only in the TC message to make sure those rules can coexist.
Fixes: de96fe68ae95 ("net/tap: add basic flow API patterns and actions")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/tap_flow.c
Hi,
In the case of tap PMD, I would say it's rather partially supported (P).
Best regards,
Pascal
On Mon, 15 May 2017 11:59:46 +0100
Ferruh Yigit wrote:
> Signed-off-by: Ferruh Yigit
> ---
>
> Please fix partially support to fully supported speed capabilities.
>
> Please check other featur
affic capture")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 26a7f84d4f6b..49549b4f1822 100644
--- a/drivers/net/tap/rte_eth_t
; initialization can now fail if a remote is
requested but cannot be set up.
Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic capture")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 217 ++
1 file changed, 115
These functions are only two lines each and are used only once.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 26 --
1 file changed, 4 insertions(+), 22 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index
This is cosmetic; the code is functionally equivalent.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 34 +++---
1 file changed, 15 insertions(+), 19 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index
Print a detailed debug message inside tap_ioctl() directly. The caller
now only needs to check for return value.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/drivers/net
with limited capabilities.
This series ensures that the tap works more logically.
v3 changes:
- rebase on top of next-net/master
v2 changes:
- fix uninitialized fd variable
Pascal Mazon (5):
net/tap: add debug messages
net/tap: remove unnecessary functions
net/tap: drop unnecessary
("net/tap: support segmented mbufs")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index d9ec14d709ed..e44de027d705 100644
--- a/d
This is cosmetic; the code is functionally equivalent.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 34 +++---
1 file changed, 15 insertions(+), 19 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index
; initialization can now fail if a remote is
requested but cannot be set up.
Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic capture")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 217 ++
1 file changed, 115
affic capture")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 24ad9ead3b4c..58c1b4cb3ddf 100644
--- a/drivers/net/tap/rte_eth_t
Print a detailed debug message inside tap_ioctl() directly. The caller
now only needs to check for return value.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/drivers/net
These functions are only two lines each and are used only once.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 26 --
1 file changed, 4 insertions(+), 22 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index
with limited capabilities.
This series ensures that the tap works more logically.
v2 changes:
- fix uninitialized fd variable
Pascal Mazon (5):
net/tap: add debug messages
net/tap: remove unnecessary functions
net/tap: drop unnecessary nested block
net/tap: create netdevice during
affic capture")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 52bce08780ce..41276eacfec3 100644
--- a/drivers/net/tap/rte_eth_t
Print a detailed debug message inside tap_ioctl() directly. The caller
now only needs to check for return value.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/drivers/net
This is cosmetic; the code is functionally equivalent.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 32 ++--
1 file changed, 14 insertions(+), 18 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index
; initialization can now fail if a remote is
requested but cannot be set up.
Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic capture")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 217 ++
1 file changed, 115
These functions are only two lines each and are used only once.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 26 --
1 file changed, 4 insertions(+), 22 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index
with limited capabilities.
This series ensures that the tap works more logically.
Pascal Mazon (5):
net/tap: add debug messages
net/tap: remove unnecessary functions
net/tap: drop unnecessary nested block
net/tap: create netdevice during probing
net/tap: do not set remote MAC if not
Support for a fixed MAC address for testing with the last octet
incrementing by one for each interface defined with the new 'mac=fixed'
string on the --vdev option. The default option is still to randomize
the MAC address for each tap interface.
Signed-off-by: Keith Wiles
Signed-off-
Support for a fixed MAC address for testing with the last octet
incrementing by one for each interface defined with the new 'mac=fixed'
string on the --vdev option. The default option is still to randomize
the MAC address for each tap interface.
Signed-off-by: Keith Wiles
Signed-off-
On Tue, 11 Apr 2017 13:23:24 +
"Wiles, Keith" wrote:
>
> > On Apr 11, 2017, at 2:18 AM, Pascal Mazon wrote:
> >
> > Hi Keith,
> >
> > I have a few comments on your patch, see inline.
> >
> > On Mon, 10 Apr 2017 13:18:50 -0500
&g
Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic capture")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 34
Fixes: 62d3216d6194 ("app/testpmd: add latency statistics calculation")
Signed-off-by: Pascal Mazon
---
app/test-pmd/testpmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index d6bd2b20ecfd..6117deed1f6d 100644
--- a/app/test-pmd
Hi Keith,
I have a few comments on your patch, see inline.
On Mon, 10 Apr 2017 13:18:50 -0500
Keith Wiles wrote:
> Support for a fixed MAC address for testing with the last octet
> incrementing by one for each interface defined with the new 'mac=fixed'
> string on the --vdev option. The default
t;mk: introduce NXP dpaa2 architecture based on armv8-a")
Reported-by: Jan Viktorin
Signed-off-by: Pascal Mazon
---
I couldn't test it though, as I don't have an ARM toolchain.
mk/machine/armv7a/rte.vars.mk | 2 +-
mk/machine/dpaa2/rte.vars.mk | 2 +-
2 files changed, 2 insert
building, please make sure the tap_autoconf.h are removed from
build/build/drivers/net/tap/.
Thank you.
Best regards,
Pascal
On Fri, 7 Apr 2017 14:21:34 +0200
Jan Viktorin wrote:
> On Fri, 7 Apr 2017 14:05:59 +0200
> Pascal Mazon wrote:
>
> > On Fri, 7 Apr 2017 13:13:13 +0200
On Fri, 7 Apr 2017 13:13:13 +0200
Jan Viktorin wrote:
> Hello Pascal,
>
> my internal ARMv7 DPDK autobuilder is failing. I've bisected to the
> source of the problem:
>
> commit de96fe68ae95990f5ce2cd4c8d9547ab62d2a810
> Author: Pascal Mazon
> Date: T
This macro was defined twice.
On machines with kernel < 3.8, IFF_MULTI_QUEUE didn't exist, and thus
both definitions used different values.
Fixes: cf5643661161 ("net/tap: move private elements to external header")
Signed-off-by: Pascal Mazon
---
drivers/net/tap
Fixes: cf5643661161 ("net/tap: move private elements to external header")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 6 --
drivers/net/tap/rte_eth_tap.h | 6 +-
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c
; /homeDPDK/drivers/net/tap/rte_eth_tap.c:78:0: error: "RTE_PMD_TAP_MAX_QUEUES"
> redefined [-Werror] compilation terminated due to -Wfatal-errors.
> cc1: all warnings being treated as errors
>
> It occurred by following commit:
> commit cf5643661161056c0ad0c073dd37ff6
This is necessary to ensure packets with the new MAC address as
destination get redirected to the tap device.
Also change the MAC address only if the current one is different from
the requested one.
Fixes: 75b6a1f7f004 ("net/tap: add remote netdevice traffic capture")
Signed-off-by: Pa
traffic capture")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 85 ---
1 file changed, 48 insertions(+), 37 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 6567bba75b47..72897adcce3b 100644
-
whether the
kernel returned -EEXIST when requiring the qdisc creation. It's simpler
and faster.
Add a few messages for clarity when a netlink error occurs.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/tap_flow.c| 22 -
drivers/net/tap/tap_netlink.c
el's error message:
[PATCH 1/2] net/tap: update netlink error code management
- 1 patch for MAC address: update remote MAC address redirection:
[PATCH 2/2] net/tap: update redirection rule after MAC change
Pascal Mazon (3):
net/tap: update netlink error code management
net/ta
This is necessary to ensure packets with the new MAC address as
destination get redirected to the tap device.
Also change the MAC address only if the current one is different from
the requested one.
Fixes: 75b6a1f7f004 ("net/tap: add remote netdevice traffic capture")
Signed-off-by: Pa
traffic capture")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 85 ---
1 file changed, 48 insertions(+), 37 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 6567bba75b47..72897adcce3b 100644
-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4cb6e4957..46c23a48b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -398,7 +398,7 @@ F: drivers/net/pcap/
> F: doc/guides/nics/pcap_ring.rst
>
> Tap PMD
> -M:
the packet will be discarded.
Fixes: 4a6bb33dc67c ("net/tap: support segmented mbufs")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.
Only full mask (0x) is accepted, there is no way to specify a mask
for layer 4 ports to the kernel using TC rules.
Fixes: 1c71189ab9b7 ("net/tap: add basic flow API patterns and actions")
Signed-off-by: Pascal Mazon
---
drivers/net/tap/tap_flow.c | 20
1 fi
This is necessary to ensure packets with the new MAC address as
destination get redirected to the tap device.
Also make the change only if the requested MAC address is different from
the current one.
Fixes: 75b6a1f7f004 ("net/tap: add remote netdevice traffic capture")
Signed-off-
whether the
kernel returned -EEXIST when requiring the qdisc creation. It's simpler
and faster.
Add a few messages for clarity when a netlink error occurs.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/tap_flow.c| 22 -
drivers/net/tap/tap_netlink.c
Signed-off-by: Pascal Mazon
---
doc/guides/rel_notes/release_17_05.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/rel_notes/release_17_05.rst
b/doc/guides/rel_notes/release_17_05.rst
index dee63919efe7..4ab3e1a740c0 100644
--- a/doc/guides/rel_notes
On Mon, 27 Mar 2017 12:21:45 +0100
Ferruh Yigit wrote:
>
> There isn't time left for this release, proposal (v1) deadline is
> passed long ago. Almost integration deadline is hit (end of this
> week).
>
> If your other patches slip into next release, can you please send a
> release notes updates
On Fri, 24 Mar 2017 16:02:48 +
Ferruh Yigit wrote:
> On 3/22/2017 2:11 PM, Wiles, Keith wrote:
> >
> >> On Mar 22, 2017, at 3:40 AM, Pascal Mazon
> >> wrote:
> >>
> >> Reflect device link status according to the state of the tap
> >> ne
emote"
parameter.
Packets matching filtering rules created with the flow API are matched
on the remote device and redirected to the tap PMD, where the relevant
action will be performed.
Signed-off-by: Pascal Mazon
Acked-by: Olga Shern
Acked-by: Keith Wiles
---
doc/guides/nics/tap.rst
correctly handle terminating \0
v2 changes:
- rebase on top of updated "net/tap: support flow API"
- fix implicit flow flush when closing the netdevices
Pascal Mazon (1):
net/tap: add remote netdevice traffic capture
doc/guides/nics/tap.rst | 16 ++
drivers/net/tap/rt
1 - 100 of 251 matches
Mail list logo
