Actually, I do have one thought.
On Tue, Oct 8, 2024 at 4:45 PM Nicholas Pratte wrote:
> +def set_mac_addr(self, port_id: int, mac_address: str, add: bool,
> verify: bool = True) -> None:
> +"""Add or remove a mac address on a given port's Allowlist.
> +
> +Args:
> +
Series-reviewed-by: Patrick Robb
Reviewed-by: Patrick Robb
and turn vlan filtering off
> on the PMD.
> +Send a packet with the fake multicast address and no vlan tag
> to the PMD.
> +(Should receive)
> +Remove the fake multicast address from the PMDs multicast
> address filter.
> + Send
Paul and Patrick have been appointed as the new dts maintainers.
Updating the MAINTAINERS file to reflect this.
Signed-off-by: Patrick Robb
Signed-off-by: Paul Szczepanek
---
v2: added updated for Tree section
MAINTAINERS | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
Hi Min Zhou,
I think it makes sense for you to set your meson version to the minimum
version supported for DPDK (so, .57 now I suppose) instead of .63. The
principle that David described above regarding LTS is also true for main.
So, for the main and next-* branch testing that Loongson lab does, w
On Tue, Oct 8, 2024 at 4:04 PM Bruce Richardson
wrote:
>
> > UNH does not use it much
> >as we opt to meet the meson dependency separately in the dpdk-ci
> >project's container template engine.
>
> That's a bit of a pity, since we can't update the meson version
> automatically as part of
Haha... I guess that serves as a lesson.
Thanks Bruce.
On Tue, Oct 8, 2024 at 4:28 AM David Marchand
wrote:
>
> This series can't be merged until the (UNH and LoongArch) CI are ready
> for such a change.
>
> TL;DR: the meson minimum version is being changed from 0.53.2 to 0.57
> in the current release.
>
> @UNH @Min Zhou
> How long would it take for
Oh, I guess I should have mentioned that I did "test" this for good
measure, by spinning up a base ubuntu 20.04 container, running the
linux-setup.sh with this change, and did a dpdk build.
Tested-by: Patrick Robb
On Tue, Oct 8, 2024 at 3:27 PM Patrick Robb wrote:
> There
There is a proposed increase in the minimum meson version to .57
This patch aligns the linux setup ci script with this change.
Signed-off-by: Patrick Robb
---
.ci/linux-setup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh
index
Paul and Patrick have been appointed as the new dts maintainers.
Updating the MAINTAINERS file to reflect this.
Signed-off-by: Patrick Robb
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 812463fe9f..5c8402707a 100644
--- a
Recheck-request: iol-mellanox-Performance
When I enabled this test on Monday I accidentally set the delta threshold
to 1.5% instead of 5%. So the accepted results window was too small and led
to this false positive test fail.
Recheck-request: iol-mellanox-Performance
When I enabled this test on Monday I accidentally set the delta threshold
to 1.5% instead of 5%. So the accepted results window was too small and led
to this false positive test fail.
Reviewed-by: Patrick Robb
Recheck-request: iol-intel-Performance
On Tue, Sep 24, 2024 at 2:12 PM Morten Brørup
wrote:
> This patch refactors the mempool cache to fix two bugs:
> 1. When a mempool is created with a cache size of N objects, the cache was
> actually created with a size of 1.5 * N objects.
> 2. The mempool c
Recheck-request: iol-marvell-Functional
putting in a ci lab retest for the failures on this series.
Recheck-request: iol-marvell-Functional
putting in a ci lab retest for the failures on this series.
Dean actually just came down with an illness. Since the changes in his
series are minimal (I see the only ones left are updating dts.rst and
the devcontainer json) I think that one of us at UNH should submit a
patch which is essentially a v2 of his series. It's probably not worth
blocking a "critic
Recheck-request: iol-intel-Functional
Rerunning with David's DTS patch mentioned above.
#
September 12, 2024
Attendees
* Patrick Robb
* Paul Szczepanek
* Alex Chapman
* Luca Vizzarro
* Jeremey Spewock
* Juraj Linkeš
#
Minutes
Looks good to me, and I don't understand it as triggering a second
compile on the TG node.
I wonder whether the docstring for set_up_build_target() makes it
sound like it does though?
Reviewed-by: Patrick Robb
This looks good, except for the fact that a method for sending a list
of packets has been added since you submitted this patch (which does
return the packet list, not that it matters for your application).
So, this will need to be resubmitted with your patch reformatted for
_adjust_addresses() to
Just noting in attempting to test the latest version of this patch I
see it does not cleanly apply.
Looks good other than updating the testpmd_shell method names
Reviewed-by: Patrick Robb
On Wed, Jul 24, 2024 at 1:13 PM wrote:
> +class TestDualVlan(TestSuite):
> +"""DPDK Dual VLAN test suite.
> +
> +This suite tests the behavior of VLAN functions and prope
A new version should be submitted which will apply onto next-dts.
Mostly looks good barring 1 or 2 nits and some overlap with Luca's
pktgen/testpmd series which was merged to next-dts the other day.
On Wed, Sep 11, 2024 at 1:37 PM Dean Marx wrote:
>
> added the following methods to testpmd shell
Reviewed-by: Patrick Robb
Reviewed-by: Patrick Robb
itted with these changes, in my opinion it makes sense
to move this series to next-dts. Thanks!
Reviewed-by: Patrick Robb
Tested-by: Patrick Robb
#
September 5, 2024
Attendees
1. Patrick Robb
2. Ali Alnubani
3. Jeremy Spewock
4. Juraj Linkeš
5. Luca Vizzarro
6. Alex Chapman
7. Paul Szczepanek
8. Aaron Conole
#
August 29, 2024
Attendees
* Patrick Robb
* Luca Vizzarro
* Paul Szczepanek
* Jeremy Spewock
* Alex Chapman
#
Minutes
Reviewed-by: Patrick Robb
The only thought I had from this was that with more methods being
added to the framework for packet construction and validation (in this
case, your random packets utils.py method and the
testsuite.match_all_packets() strategy), and with multiple reference
solutions
Reviewed-by: Patrick Robb
Tested-by: Patrick Robb
Ran on a Broadcom 57414 2x25G NIC on an Intel x86 server.
I'll follow up with a review on the pktgen and testpmd changes series
as obviously we want to move that to next-dts. Thanks!
On Tue, Aug 6, 2024 at 8:53 AM Luca Vizzarro
Recheck-request: iol-marvell-Functional
On Fri, Aug 23, 2024 at 6:51 AM Soumyadeep Hore
wrote:
>
> Updating the latest shared code patches to ICE base driver.
>
> ---
> v3:
> - Addressed comments givn by reviewer
> ---
> v2:
> - Addressed comments given by reviewer
> - Corrected errors in Camel C
Recheck-request: iol-marvell-Functional
On Fri, Aug 23, 2024 at 7:56 AM Soumyadeep Hore
wrote:
>
> In E830 adapters, PHY timestamp for Tx packets should be read once
> the ready status of PHY timestamp registers is 1.
>
> Fixes: 881169950d80 ("net/ice/base: implement initial PTP support for E830"
#
August 22, 2024
Attendees
1. Patrick Robb
2. Tomas Durovec
3. Dean Marx
4. Luca Vizzarro
5. Jeremy Spewock
6. Ali Alnubani
7. Juraj Linkeš
8. Paul Szczepanek
#
August 15, 2024
Attendees
* Patrick Robb
* Jeremy Spewock
* Alex Chapman
* Juraj Linkeš
* Tomas Durovec
* Dean Marx
* Luca Vizzarro
* Paul Szczepanek
* Nicholas Pratte
Recheck-request: iol-marvell-Functional
Putting in a retest for this.
#
August 8, 2024
Attendees
1. Patrick Robb
2. Juraj Linkeš
3. Aaron Conole
4. Alex Chapman
5. Dean Marx
6. Jeremy Spewock
7. Luca Vizzarro
8. Nicholas Pratte
9. Paul Szczepanek
10. Manit Mahajan
Thanks I will merge the change disabling ABI checks at UNH at start of
day tomorrow.
On Thu, Aug 8, 2024 at 8:56 AM David Marchand wrote:
>
> On Thu, Aug 8, 2024 at 2:00 PM Thomas Monjalon wrote:
> >
> > 08/08/2024 10:03, David Marchand:
> > > Start a new release cycle with empty release notes.
I saw there was one fail for this series for the Marvell MVNETA container.
I thought I should also mention that the build did fail when our
automation tried to run DTS on the Octeon CN10K DPU (which is also
Marvell). So, that is why you won't get a report for the CN10K DTS
results.
Let me know if
August 1, 2024
#
Attendees
* Patrick Robb
* Jeremy Spewock
* Nicholas Pratte
* Juraj Linkeš
* Alex Chapman
* Luca Vizzarro
#
Minutes
this also raises the question of whether the DPDK docs for the
windows mingw64 compile process should be updated to point to
winlibs.com instead of sourceforge.net (only has the source code).
https://doc.dpdk.org/guides/windows_gsg/build_dpdk.html#option-2-mingw-w64-toolchain
On Thu, Jul 25, 202
Hi Stephen,
This is a UNH Lab system.
We review our systems for updates once every 4 months. The idea is we
do it early in each DPDK release's development cycle. So, we update
Dockerfiles (for container environments), we apply updates where
needed to persistent systems (for VMs, or baremetal serv
#
July 25, 2024
Attendees
1. Patrick Robb
2. Jeremy Spewock
3. Juraj Linkeš
4. Aaron Conole
5. Adam Hassick
6. Dean Marx
7. Luca Vizzarro
8. Manit Mahajan
9. Paul Szczepanek
10. Tomas Durovec
July 18, 2024
#
Attendees
* Patrick Robb
* juraj.lin...@pantheon.tech
* paul.szczepa...@arm.com
* Jeremy Spewock
* Dean Marx
* Nicholas Pratte
* Alex Chapman
On Thu, Jun 27, 2024 at 4:52 PM Patrick Robb wrote:
> #
> Minutes
>
> =
> General Announcements
> * DPDK Summit in Montreal will be Septem
Rerunning the CI Test for Broadcom Performance, which appears to be a
false failure.
On Mon, Jul 15, 2024 at 10:38 PM zhoumin wrote:
>
> Hi Patrick,
>
> Thanks for giving the link of commit `a6c3ec342ee1`.
>
> However I cannot checkout this commit in the next-net repository because
> the commit ID is not exist in the history of next-net repository. Could
> you find it?
>
> It seem
On Wed, Feb 14, 2024 at 3:17 PM Patrick Robb wrote:
>
>
>
> On Wed, Feb 14, 2024 at 3:00 PM Dumitrescu, Cristian
> wrote:
>>
>>
>>
>> [Cristian]
>> Yes, you are right, we do have a DTS test suite for the pipeline library.
>>
>> It would b
Hi Min Zhou,
I am seeing that commit for next-net:
https://git.dpdk.org/next/dpdk-next-net/commit/?id=a6c3ec342ee105e322ffdb21e810cdfd38455c62
If you try to manually apply it on next-net, does it work?
Pasting the logs from our apply process below for context:
```
Trying to checkout branch: o
Hello Zhoumin,
It looks like Loongarch CI failed to apply this patch, but it worked
at the other labs and locally for Serhii when they were checked out to
next-net.
Maybe your CI did not choose next-net, the right branch? I remember
you saying your CI is based on a fork of the dpdk-ci repo. Perha
#
July 11, 2024
Attendees
1. Patrick Robb
2. Juraj Linkeš
3. Alex Chapman
4. Tomas Durovec
5. Jeremy Spewock
6. Adam Hassick
7. Manit Mahajan
8. Dean Marx
On Tue, Jul 9, 2024 at 8:48 AM David Marchand wrote:
>
> On Tue, Jul 9, 2024 at 2:43 PM Morten Brørup
> wrote:
> > PS: The CI should catch this stuff.
>
> Restoring OVS tests in CI has been requested and I think it was being worked
> on.
> Not sure where we are atm, Patrick?
>
OvS and SPDK com
Recheck-request: iol-unit-amd64-testing
On Wed, Jul 3, 2024 at 12:14 PM Thomas Monjalon wrote:
>
>
> We had some doubts with CI.
> It should be solved on the top of the main branch, let's see.
>
> Applied, thanks.
>
https://patchwork.dpdk.org/project/dpdk/patch/1710970416-27841-3-git-send-email-roret...@linux.microsoft.com/
Looks like
#
Attendees
* Patrick Robb
* Nicholas Pratte
* Dean Marx
* Alex
* Nicholas Pratte
* Paul Szczepanek
#
Minutes
Hello,
There is interest in moving the DTS meeting from Wednesdays at 14:00
UTC to Thursdays at 13:00 UTC. This would mean the DTS meetings would
happen at the same time as the CI testing meetings, but on the off
weeks.
Let me know if this doesn't work for you, and we can try to make a
decision w
On Wed, Jul 3, 2024 at 10:22 AM David Marchand
wrote:
>
>
>
> From the discussions on the retest mechanism, I understand we need to
> ask for a rebase.
> I sent a new retest. Let's see...
>
Hi,
That makes sense that we need to re-apply on the latest mainline and
retest. But, the "rebase" feature
Recheck-request: iol-unit-arm64-testing
I see this patchseries had a CI testing fail, for coremask DTS test on
Marvel CN10k. I don't think it could relate to the contents of your
patch though.
It had a timeout:
TestCoremask: Test Case test_individual_coremask Result FAILED:
TIMEOUT on ./arm64-native-linuxapp-gcc/app/test/dpdk-test -c
#
Attendees
1. Patrick Robb
2. Paul Szczepanek
3. Luca Vizzarro
4. Nicholas Pratte
5. Aaron Conole
6. Dean Marx
7. Jeremy Spewock
8. Juraj Linkeš
9. Manit Mahajan
10. Tomas Durovec
11. Adam Hassick
Hi Thomas,
Last November when we chatted in tech board about 2024 DTS goals, you
said testpmd should be the primary tool used to drive the testsuites,
and that if testpmd was missing some support for any DPDK features we
want to test in DTS, then the support should be added into testpmd.
So, we h
On Fri, Jun 21, 2024 at 3:00 AM David Marchand
wrote:
>
> Hello guys,
>
> On Thu, Jun 20, 2024 at 6:32 PM Patrick Robb wrote:
> > * DPDK Summit Montreal
> >* Possible CFP topics for DTS:
> > * How to write a testsuite. This could be a simple lightning
>
rerunning the failing performance test in CI testing as it was a false failure.
On Tue, Jun 25, 2024 at 2:39 AM zhaoxinxin <15957197...@163.com> wrote:
>
> The rte_vhost_driver_unregister() vhost_user_read_cb()
> vhost_user_client_reconnect() can be called at the same time by 3 threads.
> when mem
Recheck-request: iol-intel-Functional
#
Attendees
1. Patrick Robb
2. Juraj Linkeš
3. Aaron Conole
4. Dean Marx
5. Jeremy Spewock
6. Manit Mahajan
7. Nicholas Pratte
8. Paul Szczepanek
9. Tomas Durovec
#
Attendees
* Patrick Robb
* Juraj Linkeš
* Paul Szczepanek
* Jeremy Spewock
* Nicholas Pratte
* Dean Marx
* Luca Vizzarro
#
Minutes
For CI Testing: re-applying to main and retesting because main was in
a bad state (now fixed by Maxime), causing a virtio_smoke fail on this
series.
https://git.dpdk.org/dpdk/commit/?id=6bdc14606724bc7fb3834d5ec59b1cccf98adf28
For CI Testing: re-applying to main and retesting because main was in
a bad state (now fixed by Maxime), causing a virtio_smoke fail on this
series.
https://git.dpdk.org/dpdk/commit/?id=6bdc14606724bc7fb3834d5ec59b1cccf98adf28
For CI Testing: re-applying to main and retesting because main was in
a bad state (now fixed by Maxime), causing a virtio_smoke fail on this
series.
https://git.dpdk.org/dpdk/commit/?id=6bdc14606724bc7fb3834d5ec59b1cccf98adf28
On Sat, Jun 15, 2024 at 12:02 PM Stephen Hemminger
wrote:
>
> The typ
On Fri, Jun 14, 2024 at 4:29 PM Jeremy Spewock wrote:
> > I wonder whether, when convenient, we want to name the methods more or
> > less 1:1 according to the actual testpmd text command they send? I.e.
> > in this case should the method be named vlan_set_filter_on instead of
> > vlan_filter_set_
Looks promising thanks - some comments below.
On Fri, Jun 14, 2024 at 11:03 AM Dean Marx wrote:
> +class TestVlan(TestSuite):
> +"""DPDK VLAN test suite.
> +
> +Ensures VLAN packet reception on the Poll Mode Driver when certain
> conditions are met.
> +If one or more of these conditi
On Fri, Jun 14, 2024 at 11:03 AM Dean Marx wrote:
> +def vlan_filter_set_on(self, port: int = 0, verify: bool = True):
> +"""Set vlan filter on.
> +
> +Args:
> +port: The port number to use, should be within 0-32.
> +verify: If :data:`True`, the output o
event should already be moved.
--
Patrick Robb
Technical Service Manager
UNH InterOperability Laboratory
21 Madbury Rd, Suite 100, Durham, NH 03824
www.iol.unh.edu
Thanks Dean.
I see there is some personal configuration you have included from the
conf.yaml. You can drop that and resubmit the patch.
Also if you can add a cover letter which briefly explains the vlan
functions the testsuite aims to provide coverage for, I think that will
help give people on th
#
June 5, 2024
Attendees
* Patrick Robb
* Nicholas Pratte
* Dean Marx
* Luca Vizzarro
* Juraj Linkeš
* Paul Szczepanek
* Tomas Durovec
* Jeremy Spewock
#
Minutes
On Fri, May 31, 2024 at 12:44 PM Luca Vizzarro
wrote:
>
> In my testing of Jeremy's patches which depend on this one ("Add second
> scatter test case"), I've discovered that the Intel E810-C NIC I am
> using to test does not automatically show "RX scattered packets: on".
> But I've noticed it doe
Hi all,
Found my way to this thread based on the CI testing call yesterday, as I am
about to put together the blurb for the dpdk website testing page that
documents support (or lack thereof) for depends-on in CI.
On Wed, May 29, 2024 at 10:40 AM Morten Brørup
wrote:
> > From: Aaron Conole [mail
May 30, 2024
#
Attendees
1. Patrick Robb
2. Adam Hassick
3. Nicholas Pratte
4. Paul Szczepanek
5. Jeremy Spewock
6. Dean Marx
7. Aaron Conole
8. Juraj Linkeš
Series-reviewed-by: Patrick Robb
As a reminder, once this is merged, UNH will add a CI job which runs
mypy and reports its results to PW (only runs for patches with changes
in dpdk/dts).
Luca, I assume what you had in mind was we will run
dts-check-format.sh, so including isort and pylama, as
Looks good to me.
Reviewed-by: Patrick Robb
Tested-by: Patrick Robb
nodes up as DTSRunner attributes. I like preserving the type hint,
but it also might just be cluttering the code to do this... up to you.
But overall I think it is good and I ran the mypy type check from this patch.
Reviewed-by: Patrick Robb
Tested-by: Patrick Robb
Reviewed-by: Patrick Robb
Reviewed-by: Patrick Robb
I don't have any comments beyond Luca's suggestions, but saw the typo below.
On Tue, May 14, 2024 at 4:15 PM wrote:
> +def __exit__(self, type: BaseException, value: BaseException, traceback:
> TracebackType) -> None:
> +&qu
Reviewed-by: Patrick Robb
On Tue, May 21, 2024 at 10:38 AM Ferruh Yigit wrote:
>
>
> Hi Patric,
>
> I guess './devtools/check-meson.py' checks are missing in the CI, I
> don't remember seeing any complain about it in the CI.
>
> Is it possible to add this task to the CI task-list backlog?
>
Correct, this script is not run
On Tue, May 21, 2024 at 9:47 AM Ferruh Yigit wrote:
>
>
> If we can have an Ubuntu 24.04 environment, this addresses the libbpf
> testing concern.
>
> @Christian can comment better, but as far as I can see although upgrade
> from previous LTS is not supported yet, it is possible to install Ubuntu
On Mon, May 20, 2024 at 1:49 PM Ferruh Yigit wrote:
>
> @Patric, I assume test environment also doesn't have 'libbpf', version:
> '>= 1.0' which we need to test this feature.
> Is it possible to update test environment to justify this dependency?
>
Hi, the libbpf version on our Ubuntu 22.04 conta
#
May 16, 2024
Attendees
1. Patrick Robb
2. Ali Alnubani
3. Paul Szczepanek
4. Aaron Conole
#
Minutes
When we sent this out originally we missed some patches Luca Vizzarro
has been working on for this release, so here is an updated version.
Thanks Luca.
1) Write ethdev testsuites:
Jumboframes:
https://git.dpdk.org/tools/dts/tree/test_plans/jumboframes_test_plan.rst
Mac Filter:
https://git.dpdk.
Recheck-request: iol-broadcom-Performance
On Mon, May 6, 2024 at 1:58 PM Tyler Retzlaff
wrote:
>
> This series converts all non-generic built atomics to use the rte_atomic
> macros that allow optional enablement of standard C11 atomics.
>
> Use of generic atomics for non-scalar types are not conv
Hi DPDK Developers,
I wanted to announce to the mailing lists that the UNH Community Lab
recently rolled out a new page on our dashboard where you can find
code coverage reports for DPDK unit tests.
https://lab.dpdk.org/results/dashboard/code-coverage
It provides some unit test code coverage rep
#
May 2, 2024
Attendees
1. Patrick Robb
2. Juraj Linkeš
3. Aaron Conole
4. Paul Szczepanek
5. Luca Vizzarro
#
Minutes
On Tue, Apr 30, 2024 at 4:13 PM Mattias Rönnblom
wrote:
> On 2024-04-30 15:52, Patrick Robb wrote:
> >
> >
> > On Sun, Apr 28, 2024 at 3:46 AM Mattias Rönnblom > <mailto:hof...@lysator.liu.se>> wrote:
> >
> > It would be great if the uni
On Sun, Apr 28, 2024 at 3:46 AM Mattias Rönnblom
wrote:
> It would be great if the unit test suite (app/test/*) was compiled (and
> run) using a C++ (C++11) compiler as well. At least, if such is available.
>
Sure, the UNH Lab can try this.
>
> With the current state of affairs, header file ma
On Mon, Apr 29, 2024 at 9:49 AM Jeremy Spewock wrote:
>
> > The patchset contains the .rst sources which Sphinx uses to generate the
> > html pages. These were first generated with the sphinx-apidoc utility
> > and modified to provide a better look. The documentation just doesn't
> > look that g
On Mon, Apr 29, 2024 at 6:01 AM David Marchand
wrote:
> Following an upgrade of musl, pread64/pwrite64 wrappers are not provided
> anymore. Switch to POSIX pread/pwrite.
>
> Bugzilla ID: 1422
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
>
>
Tested-by: Patri
Recheck-request: iol-compile-amd64-testing
The DPDK Community Lab updated to the latest Alpine image yesterday, which
resulted in all Alpine builds failing. The failure is unrelated to your
patch, and this recheck should remove the fail on Patchwork, as we have
disabled Alpine testing for now.
Recheck-request: iol-compile-amd64-testing
The DPDK Community Lab updated to the latest Alpine image yesterday, which
resulted in all Alpine builds failing. The failure is unrelated to your
patch, and this recheck should remove the fail on Patchwork, as we have
disabled Alpine testing for now.
1 - 100 of 247 matches
Mail list logo
