.@dpdk.org
Signed-off-by: Qiming Chen
---
v2:
Solve the potential mbuf leak of the alloc_rxq_mbufs function itself.
---
drivers/net/iavf/iavf_rxtx.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index
e and device")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/iavf/iavf_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 6ed2dbbcbe..9eca4b70ee 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/d
nnot fundamentally solve the failure problem, but it greatly
slows down the probability of the problem. The modification is based on the
i40evf kernel driver.
Fixes: 22b123a36d07 ("net/avf: initialize PMD")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/iavf/iavf.h | 2 +
t/avf: initialize PMD")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/iavf/iavf_vchnl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 06dc663947..2f39c2077c 100644
--- a/driver
memory
stepping event.
The patch uses the RTE_ALIGN_FLOOR down alignment macro to correct the
problem.
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/iavf/iavf_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
scheme is to judge whether the pointer is empty when the port
is stopped, and release the corresponding mbuf if it is not empty.
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/iavf/iavf_rxtx.c | 4
1 file
.@dpdk.org
Signed-off-by: Qiming Chen
---
v2:
Modify coding style warning.
---
drivers/net/iavf/iavf_rxtx.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index e33fe4576b..55393a9400 100644
--- a/driver
In the iavf_dev_rx_queue_start function, if the iavf_switch_queue
or iavf_switch_queue_lv function fails, the previously applied mbuf
is not released, resulting in leakage. The patch fixes the problem.
Fixes: 9cf9c02bf6ee ("net/iavf: add enable/disable queues for large VF")
Cc: sta...@dpdk.org
---
;)
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/iavf/iavf_ethdev.c | 38 --
1 file changed, 36 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 280d53a651..6ed2dbbcbe 100644
--- a/d
n text format, and REPLY inline.
BR,
Haiyue
From: Qiming Chen
Sent: Friday, September 10, 2021 14:27
To: Wang, Haiyue
Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing
; sta...@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] common/iavf: fix arq resource leak
Thanks your reply.
You are right. The res
a...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/iavf/iavf_ethdev.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 574cfe055e..280d53a651 100644
--- a/drivers/net/iavf/iavf_ethdev.c
Thanks your reply.
You are right. The resource leak is indeed scanned by tools, and then manually
confirmed whether it is a problem.
Our team has been developing and maintaining for many years. Because the
company process is not perfect,
the bug has not been promoted to the community, resulti
mmand buffer memory leak")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/common/iavf/iavf_adminq.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/common/iavf/iavf_adminq.c
b/drivers/common/iavf/iavf_adminq.c
index 0bf5af0cbe..9c36e8908e 10
In the receiving direction, if alloc mbuf or jumbo process failed, there
is no err_pkts count, which makes it difficult to locate the problem.
Because alloc mbuf failed, the rx_nombuf field is counted.
Signed-off-by: Qiming Chen
---
drivers/net/pcap/pcap_ethdev.c | 13 -
1 file
I have re-tested with kernel driver version 5.6.3 and found that this problem
has been solved, thank you again for your reply.
In the receiving direction, if alloc mbuf or jumbo process failed, there
is no err_pkts count, which makes it difficult to locate the problem.
Because alloc mbuf failed, the rx_nombuf field is counted.
Signed-off-by: Qiming Chen
---
drivers/net/pcap/pcap_ethdev.c | 14 --
1 file
In the receiving direction, if alloc mbuf or jumbo process failed, there
is no err_pkts count, which makes it difficult to locate the problem.
Because alloc mbuf failed, the rx_nombuf field is counted.
Signed-off-by: Qiming Chen
---
v2:
Clear coding style issues.
v3:
1) Send direction does
OK，Thanks your test and reply.
It may be that the pf kernel version I tested before is older, and the code
snippets you posted have not yet been implemented.
I will test it again based on the latest version.
This is a problem triggered by the existing network. I discovered it a long
time ago. I use the link state as an example.
It is not to say that it is a link state problem, but to show that ixgbevf does
have such a probability problem.
The current modification and repeated verification can indee
In the receiving direction, if alloc mbuf or jumbo process failed, there
is no err_pkts count, which makes it difficult to locate the problem.
Because alloc mbuf failed, the rx_nombuf field is counted.
Signed-off-by: Qiming Chen
---
v2:
Clear coding style issues.
v3:
1) Send direction does
oduce, but
the problem does exist.
On 9/8/2021 11:33，Wang, Haiyue wrote：
-Original Message-----
From: Qiming Chen
Sent: Monday, September 6, 2021 10:22
To: dev@dpdk.org
Cc: Wang, Haiyue ; Qiming Chen
; sta...@dpdk.org
Subject: [PATCH v2] net/ixgbe: fix probability of obtaining mailbox lo
result, it can be seen that the mac remains, and there is no clear.
This is vf driver quesion, not dpdk pf.
Also, the two interfaces you posted, I didn't find them in the dpdk code.
On 9/8/2021 16:35，Wang, Haiyue wrote：
-Original Message-
From: Qiming Chen
Sent: Monday, Septem
iver.
Fixes: 5c9222058df7 ("i40e: move to drivers/net/")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e/i40e_ethdev_vf.c
in
memory
stepping event.
The patch uses the RTE_ALIGN_FLOOR down alignment macro to correct the
problem.
Fixes: c1715402df8f ("i40evf: fix jumbo frame support")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 insertion(+), 1 d
ublic release")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
v2:
Modify fixes commit
---
drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 6a91f104e1..e40350d86e 10
ublic release")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
v2:
Modify fixes commit
---
drivers/net/ixgbe/base/ixgbe_mbx.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ixgbe/base/ixgbe_mbx.c
b/drivers/net/ixgbe/base/ixgbe_m
Ask a question: how to submit an issue while keeping the exchange log.
| |
Qiming Chen
|
|
chenqiming_hua...@163.com
|
签名由网易邮箱大师定制
On 9/1/2021 14:25，Wang, Haiyue wrote：
-Original Message-
From: Qiming Chen
Sent: Tuesday, August 31, 2021 22:22
To: dev@dpdk.org
Cc: Wang, Haiyue ; Qiming
scheme is to judge whether the pointer is empty when the port
is stopped, and release the corresponding mbuf if it is not empty.
Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
v2:
Sync to sta...@dpdk.org
v3:
Modify fixes commit
---
d
Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
v2:
Clear coding style warning.
v3:
Modify fixes commit.
---
drivers/net/ixgbe/ixgbe_ethdev.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/d
This is already the oldest commit node in git, and it has not been recorded
before。
Which commit should I fill in?
| |
Qiming Chen
|
|
chenqiming_hua...@163.com
|
签名由网易邮箱大师定制
On 8/31/2021 18:00，Kevin Traynor wrote：
On 31/08/2021 09:06, Qiming Chen wrote:
A local test found that repeated port
Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
v2:
Clear coding style warning.
---
drivers/net/ixgbe/ixgbe_ethdev.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgb
move to drivers/net/")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 6a91f104e1..e40350d86e 100644
--- a/drivers
Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/ixgbe/ixgbe_ethdev.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 7d3a821300..6a91f10
;)
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/ixgbe/ixgbe_ethdev.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 3fd3249150..7d3a821300 100644
--- a/drivers/net/ixgbe/ixgbe_ethd
ilter")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index ccb01ed344..3fd3249150 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++
ivers/net/")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/ixgbe/base/ixgbe_82599.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/base/ixgbe_82599.c
b/drivers/net/ixgbe/base/ixgbe_82599.c
index 69fd4cd3fb..edd63018d1 100644
---
ve to drivers/net/")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
drivers/net/ixgbe/base/ixgbe_mbx.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ixgbe/base/ixgbe_mbx.c
b/drivers/net/ixgbe/base/ixgbe_mbx.c
index 4dddff2c58..5a14fcc
scheme is to judge whether the pointer is empty when the port
is stopped, and release the corresponding mbuf if it is not empty.
Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
v2:
Sync to sta...@dpdk.org
---
drivers/net/ixgbe/ix
scheme is to judge whether the pointer is empty when the port
is stopped, and release the corresponding mbuf if it is not empty.
Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/")
Cc: sta...@dpdk.org
Signed-off-by: Qiming Chen
---
v2:
Cc: sta...@dpdk.org
---
drivers/net/ixgbe/ixgbe_
Do you mean let me sync to sta...@dpdk.org?
| |
Qiming Chen
|
|
chenqiming_hua...@163.com
|
签名由网易邮箱大师定制
On 8/31/2021 14:04，Wang, Haiyue wrote：
-Original Message-
From: Qiming Chen
Sent: Tuesday, August 31, 2021 11:28
To: dev@dpdk.org
Cc: Wang, Haiyue ; Qiming Chen
Subject: [PATCH] net
ok，Has been resubmitted to LTS
https://inbox.dpdk.org/stable/20210831035207.5590-1-chenqiming_hua...@163.com/T/#u
| |
Qiming Chen
|
|
chenqiming_hua...@163.com
|
签名由网易邮箱大师定制
On 8/30/2021 13:23，Xing, Beilei wrote：
-Original Message-
From: dev On Behalf Of Qiming Chen
Sent: Monday
scheme is to judge whether the pointer is empty when the port
is stopped, and release the corresponding mbuf if it is not empty.
Signed-off-by: Qiming Chen
---
drivers/net/ixgbe/ixgbe_rxtx.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe
k.org
Signed-off-by: Qiming Chen
---
drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index b5371568b5..ccb01ed344 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/i
When the port is probed, if the eth_from_pcaps function fails, the
previously opened pcap resources are not released, causing resource
leakage.
The patch solves the problem of resource leakage caused by abnormal
branch exit during the port probe process.
Signed-off-by: Qiming Chen
---
v2
When the port is probed, if the eth_from_pcaps function fails, the
previously opened pcap resources are not released, causing resource
leakage.
The patch solves the problem of resource leakage caused by abnormal
branch exit during the port probe process.
Signed-off-by: Qiming Chen
---
drivers
port 1 was stripped.
Signed-off-by: Qiming Chen
---
v2:
Clear coding style quesion.
---
drivers/net/i40e/i40e_ethdev_vf.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e/i40e_ethdev_vf.c
index 625981048a
port 1 was stripped.
Signed-off-by: Qiming Chen
---
drivers/net/i40e/i40e_ethdev_vf.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e/i40e_ethdev_vf.c
index 625981048a..e0208f4c35 100644
--- a/drivers/net/i40e
start function, the buf_size member variable is added to the
struct pmd_process_private structure. At the same time, for the uniform
code style, the buf_size member variable is also added to the
struct pmd_devargs structure, which is used by the probe function.
Signed-off-by: Qiming Chen
---
v2
start function, the buf_size member variable is added to the
struct pmd_process_private structure. At the same time, for the uniform
code style, the buf_size member variable is also added to the
struct pmd_devargs structure, which is used by the probe function.
Signed-off-by: Qiming Chen
---
v2
start function, the buf_size member variable is added to the
struct pmd_process_private structure. At the same time, for the uniform
code style, the buf_size member variable is also added to the
struct pmd_devargs structure, which is used by the probe function.
Signed-off-by: Qiming Chen
port 1 was stripped.
Signed-off-by: Qiming Chen
---
v2:
Re-test vlan filtering is no problem.
v3:
Clear coding style quesion.
---
drivers/net/i40e/i40e_ethdev_vf.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e
port 1 was stripped.
Signed-off-by: Qiming Chen
---
v2:
Re-test vlan filtering is no problem.
---
drivers/net/i40e/i40e_ethdev_vf.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e/i40e_ethdev_vf.c
index 12e69a3233
, and the test
is OK
2) Demo constructs a message with VLAN 200 to send from port 0, test NOK, the
message can also be received, VLAN filtering does not take effect
| |
Qiming Chen
|
|
chenqiming_hua...@163.com
|
签名由网易邮箱大师定制
On 8/25/2021 15:13，Xing, Beilei wrote：
-Original Message-
From
the corresponding mbuf needs to be released, otherwise
it will cause the mbuf to leak.
Signed-off-by: Qiming Chen
---
v2:
Clear coding style issues.
---
drivers/net/pcap/pcap_ethdev.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/net/pcap
the corresponding mbuf needs to be released, otherwise
it will cause the mbuf to leak.
Signed-off-by: Qiming Chen
---
drivers/net/pcap/pcap_ethdev.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap
finally
restore unicast promiscuous or multicast promiscuous state.
Signed-off-by: Qiming Chen
---
drivers/net/i40e/i40e_ethdev_vf.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e/i40e_ethdev_vf.c
index
finally
restore unicast promiscuous or multicast promiscuous state.
Signed-off-by: Qiming Chen
---
drivers/net/i40e/i40e_ethdev_vf.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e/i40e_ethdev_vf.c
index
ned-off-by: Qiming Chen
---
drivers/net/i40e/i40e_ethdev_vf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e/i40e_ethdev_vf.c
index 5b1c8e76ab..12e69a3233 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/driver
memory
stepping event.
The patch uses the RTE_ALIGN_FLOOR down alignment macro to correct the
problem.
Signed-off-by: Qiming Chen
---
drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e/i40e_ethde
iver.
Signed-off-by: Qiming Chen
---
drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/drivers/net/i40e/i40e_ethdev_vf.c
index f64db72e9a..924da8dfb4 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers
60 matches
Mail list logo
