[PATCH v3] crypto/qat: remove ZUC 256 support

2025-06-12 Thread Radu Nicolau
Due to changes in the specification related to IV size and initialization sequence remove ZUC 256 support from Gen 3 and 5 hardware Signed-off-by: Radu Nicolau Acked-by: Kai Ji --- v3: update description doc/guides/rel_notes/release_25_07.rst | 6 +++ drivers/common/qat/qat_adf

[PATCH v3] crypto/qat: remove ZUC 256 support

2025-06-12 Thread Radu Nicolau
Due to changes in the specification related to IV size and initialization sequence remove ZUC 256 support from Gen 3 and 5 hardware Signed-off-by: Radu Nicolau Acked-by: Kai Ji --- v3: updated description doc/guides/rel_notes/release_25_07.rst | 5 ++ drivers/common/qat/qat_adf

[PATCH] crypto/qat: fix out-of-place chain/cipher/auth headers

2025-06-12 Thread Radu Nicolau
Extend the original fix to gen3 and gen4 code. Fixes: 317d05f3721c ("crypto/qat: fix out-of-place chain/cipher/auth headers") Cc: arkadiuszx.kusz...@intel.com Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 13 - drivers/

[PATCH v2] crypto/qat: remove ZUC 256 support

2025-06-03 Thread Radu Nicolau
Remove ZUC 256 support from Gen 3 and 5 hardware Signed-off-by: Radu Nicolau --- v2: removed usnused function doc/guides/rel_notes/release_25_07.rst | 5 ++ drivers/common/qat/qat_adf/icp_qat_hw.h | 2 +- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 40 +--- drivers

[PATCH] crypto/qat: remove ZUC 256 support

2025-06-03 Thread Radu Nicolau
Remove ZUC 256 support from Gen 3 and 5 hardware Signed-off-by: Radu Nicolau --- doc/guides/rel_notes/release_25_07.rst | 5 +++ drivers/common/qat/qat_adf/icp_qat_hw.h | 2 +- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 40 +--- drivers/crypto/qat/dev

[PATCH] crypto/virtio: fix PMD cleanup

2025-05-29 Thread Radu Nicolau
Improper cleanup resulted in a segfault when more than 1 device was used Fixes: 6f0175ff53e0 ("crypto/virtio: support basic PMD ops") Cc: jianjay.z...@huawei.com Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/crypto/virtio/virtio_cryptodev.c | 3 +-- 1 file changed, 1

[PATCH] crypto/virtio: add request check on request side

2025-05-23 Thread Radu Nicolau
Add same request checks on the request side. Fixes: b2866f473369 ("vhost/crypto: fix missed request check for copy mode") Cc: roy.fan.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/crypto/virtio/virtio_rxtx.c | 40 + 1 file c

Re: [dpdk-dev v1] app/test-crypto-perf: remove decrypt test case from perf

2025-05-07 Thread Radu Nicolau
On 02-May-25 11:12 AM, Kai Ji wrote: Remove all decrypt test cases in aesni-mb throughput perf as the decrypt throughput testing only support OOP by dpdk-test-crypto-perf Signed-off-by: Kai Ji --- Acked-by: Radu Nicolau

[PATCH] crypto/qat: disable ZUC 256 on selected devices

2025-04-23 Thread Radu Nicolau
Disable ZUC 256 cipher on selected devices. Signed-off-by: Radu Nicolau --- drivers/common/qat/qat_common.h | 2 ++ drivers/common/qat/qat_device.c | 9 + drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 5 - drivers/crypto/qat/dev/qat_crypto_pmd_gen5.c | 9

[PATCH v2 5/5] app/eventdev: update eventdev app for SNOW-V

2025-04-11 Thread Radu Nicolau
Update eventdev app to handle SNOW-V correctly. Signed-off-by: Radu Nicolau --- app/test-eventdev/evt_options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/evt_options.c b/app/test-eventdev/evt_options.c index 323d1e724d..7903b5959c 100644 --- a/app

[PATCH v2 4/5] app/crypto-perf: add support for SNOW-V

2025-04-11 Thread Radu Nicolau
Add support for SNOW-V and SNOW-V AEAD algorithms. Signed-off-by: Radu Nicolau --- app/test-crypto-perf/cperf_ops.c | 6 -- doc/guides/tools/cryptoperf.rst | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf

[PATCH v2 2/5] examples/l2fwd-crypto: add support for SNOW-V

2025-04-11 Thread Radu Nicolau
Update l2fwd-crypto to be able to correctly handle SNOW-V Signed-off-by: Radu Nicolau --- examples/l2fwd-crypto/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index a441312f55..f1a6ca8899 100644 --- a

[PATCH v2 3/5] tests: add unit tests and test vectors for SNOW-V

2025-04-11 Thread Radu Nicolau
Add unit tests and test vectors for SNOW-V and SNOW-V AEAD. Signed-off-by: Radu Nicolau --- app/test/test_cryptodev.c | 599 ++ app/test/test_cryptodev_aead_test_vectors.h | 275 app/test/test_cryptodev_snow_v_test_vectors.h | 213 +++ 3 files

[PATCH v2 1/5] crypto/ipsec_mb: add support for SNOW-V

2025-04-11 Thread Radu Nicolau
Add support for SNOW-V and SNOW-V AEAD algorithms to crypto/ipsec_mb PMD. Signed-off-by: Radu Nicolau --- doc/guides/cryptodevs/aesni_mb.rst | 2 + drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 70 +++-- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 52

[PATCH v2 0/5] add SNOW-V support in ipsec_mb PMD

2025-04-11 Thread Radu Nicolau
Add support for SNOW-V and SNOW-V AEAD in ipsec_mb PMD. Add unit tests and test vectors for SNOW-V and SNOW-V AEAD. Add support in cryptoperf and eventdev test apps. Radu Nicolau (5): crypto/ipsec_mb: add support for SNOW-V examples/l2fwd-crypto: add support for SNOW-V tests: add unit

[PATCH 3/5] tests: add unit tests and test vectors for SNOW-V

2025-04-10 Thread Radu Nicolau
Add unit tests and test vectors for SNOW-V and SNOW-V AEAD. Signed-off-by: Radu Nicolau --- app/test/test_cryptodev.c | 337 ++ app/test/test_cryptodev_aead_test_vectors.h | 285 +++ app/test/test_cryptodev_snow_v_test_vectors.h | 213

[PATCH 1/5] crypto/ipsec_mb: add support for SNOW-V

2025-04-09 Thread Radu Nicolau
Add support for SNOW-V and SNOW-V AEAD algorithms to crypto/ipsec_mb PMD. Signed-off-by: Radu Nicolau --- doc/guides/cryptodevs/aesni_mb.rst | 2 + drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 70 +++-- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 52

[PATCH 5/5] app/eventdev: update eventdev app for SNOW-V

2025-04-08 Thread Radu Nicolau
Update eventdev app to handle SNOW-V correctly. Signed-off-by: Radu Nicolau --- app/test-eventdev/evt_options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/evt_options.c b/app/test-eventdev/evt_options.c index 323d1e724d..7903b5959c 100644 --- a/app

[PATCH 2/5] examples/l2fwd-crypto: add support for SNOW-V

2025-04-08 Thread Radu Nicolau
Update l2fwd-crypto to be able to correctly handle SNOW-V Signed-off-by: Radu Nicolau --- examples/l2fwd-crypto/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index a441312f55..f1a6ca8899 100644 --- a

[PATCH 4/5] app/crypto-perf: add support for SNOW-V

2025-04-08 Thread Radu Nicolau
Add suport for SNOW-V and SNOW-V AEAD algorithms. Signed-off-by: Radu Nicolau --- app/test-crypto-perf/cperf_ops.c | 6 -- doc/guides/tools/cryptoperf.rst | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf

[PATCH] cryptodev: add SNOW-V algorithms

2025-04-08 Thread Radu Nicolau
Add SNOW-V and SNOW-V AEAD mode algorithms to cryptodev API. Signed-off-by: Radu Nicolau --- lib/cryptodev/rte_crypto_sym.h | 17 - lib/cryptodev/rte_cryptodev.c | 4 +++- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/lib/cryptodev/rte_crypto_sym.h b/lib

Re: [PATCH] eal/x86: fix 32-bit write-combined stores

2024-09-06 Thread Radu Nicolau
fully, the prefix is unnecessary in 64-bit code, since the data size used is 32-bits. Fixes: 8a00dfc738fe ("eal: add write combining store") Cc: radu.nico...@intel.com Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- Acked-by: Radu Nicolau

Re: [PATCH v3] doc: announce rte_ipsec API changes

2024-07-30 Thread Radu Nicolau
number update inside IPsec library. Signed-off-by: Aakash Sasidharan --- Acked-by: Radu Nicolau

Re: [PATCH] examples/ipsec-secgw: revert fix SA salt endianness

2024-07-29 Thread Radu Nicolau
mples/ipsec-secgw: fix SA salt endianness") Cc: shihong.w...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- Acked-by: Radu Nicolau

Re: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-25 Thread Radu Nicolau
On 25-Jul-24 5:47 AM, Akhil Goyal wrote: On 24-Jul-24 2:04 PM, Akhil Goyal wrote: On 24-Jul-24 12:20 PM, Akhil Goyal wrote: On 23-Jul-24 5:57 PM, Akhil Goyal wrote: Hi all, This patch breaks ipsec tests with ipsec-secgw: ./examples/ipsec-secgw/test/run_test.sh -4 trs_aesctr_sha1 ... ERROR

Re: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-24 Thread Radu Nicolau
On 24-Jul-24 2:04 PM, Akhil Goyal wrote: On 24-Jul-24 12:20 PM, Akhil Goyal wrote: On 23-Jul-24 5:57 PM, Akhil Goyal wrote: Hi all, This patch breaks ipsec tests with ipsec-secgw: ./examples/ipsec-secgw/test/run_test.sh -4 trs_aesctr_sha1 ... ERROR: ./examples/ipsec-secgw/test/linux_test.s

Re: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-24 Thread Radu Nicolau
On 24-Jul-24 12:20 PM, Akhil Goyal wrote: On 23-Jul-24 5:57 PM, Akhil Goyal wrote: Hi all, This patch breaks ipsec tests with ipsec-secgw: ./examples/ipsec-secgw/test/run_test.sh -4 trs_aesctr_sha1 ... ERROR: ./examples/ipsec-secgw/test/linux_test.sh failed for dst=192.168.31.14, sz=1

Re: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-07-24 Thread Radu Nicolau
On 23-Jul-24 5:57 PM, Akhil Goyal wrote: Hi all, This patch breaks ipsec tests with ipsec-secgw: ./examples/ipsec-secgw/test/run_test.sh -4 trs_aesctr_sha1 ... ERROR: ./examples/ipsec-secgw/test/linux_test.sh failed for dst=192.168.31.14, sz=1 test IPv4 trs_aesctr_sha1 finished with status

[PATCH v4] examples/ipsec-secgw: fix cryptodev to SA mapping

2024-02-27 Thread Radu Nicolau
current lcore. Fixes: a8ade12123c3 ("examples/ipsec-secgw: create lookaside sessions at init") Cc: sta...@dpdk.org Cc: vfia...@marvell.com Signed-off-by: Radu Nicolau Tested-by: Ting-Kai Ku Acked-by: Ciara Power Acked-by: Kai Ji --- v4: replaced plain if with RTE_ASSERT examples/i

Re: [EXT] [PATCH v3] examples/ipsec-secgw: fix cryptodev to SA mapping

2024-02-27 Thread Radu Nicolau
Hi Anoob, reply inline. Regards, Radu On 27-Feb-24 5:19 AM, Anoob Joseph wrote: Hi Radu, Thanks for making the changes. I've one more question. Please see inline. Thanks, Anoob -Original Message- From: Radu Nicolau Sent: Monday, February 26, 2024 3:56 PM To: dev@dpdk.o

[PATCH v3] examples/ipsec-secgw: fix cryptodev to SA mapping

2024-02-26 Thread Radu Nicolau
current lcore. Fixes: a8ade12123c3 ("examples/ipsec-secgw: create lookaside sessions at init") Cc: sta...@dpdk.org Cc: vfia...@marvell.com Signed-off-by: Radu Nicolau Tested-by: Ting-Kai Ku Acked-by: Ciara Power Acked-by: Kai Ji --- v3: check if the cryptodev are not of the

[PATCH v2] examples/ipsec-secgw: fix cryptodev to SA mapping

2024-02-23 Thread Radu Nicolau
current lcore. Fixes: a8ade12123c3 ("examples/ipsec-secgw: create lookaside sessions at init") Cc: sta...@dpdk.org Cc: vfia...@marvell.com Signed-off-by: Radu Nicolau Signed-off-by: Radu Nicolau Tested-by: Ting-Kai Ku Signed-off-by: Radu Nicolau Acked-by: Ciara Power Acked-by: Kai

[PATCH] examples/ipsec-secgw: fix cryptodev to SA mapping

2023-12-11 Thread Radu Nicolau
current lcore. Fixes: a8ade12123c3 ("examples/ipsec-secgw: create lookaside sessions at init") Cc: sta...@dpdk.org Cc: vfia...@marvell.com Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/exam

Re: [PATCH] net/iavf: fix indent in Tx path

2023-10-26 Thread Radu Nicolau
txe->mbuf = NULL; - } + } iavf_fill_ipsec_desc(ipsec_desc, ipsec_md, &ipseclen); Acked-by: Radu Nicolau

Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition

2023-10-25 Thread Radu Nicolau
On 25-Oct-23 10:07 AM, David Marchand wrote: On Wed, Oct 25, 2023 at 11:02 AM Radu Nicolau wrote: On 25-Oct-23 12:30 AM, Zhang, Qi Z wrote: -Original Message- From: Nicolau, Radu Sent: Tuesday, October 24, 2023 10:49 PM To: Zhang, Qi Z ; Marchand, David Cc: Wu, Jingjing ; Xing

[PATCH v2] net/iavf: fix Tx offloading flags check

2023-10-25 Thread Radu Nicolau
Relax the check in the previous fix to allow packets with security offload flag set. Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading") Cc: sta...@dpdk.org Cc: david.march...@redhat.com Signed-off-by: Radu Nicolau --- v2: extend the check for only TX_SEC_OFFLOAD driver

Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition

2023-10-25 Thread Radu Nicolau
definition On 24-Oct-23 12:24 PM, Zhang, Qi Z wrote: -Original Message- From: Radu Nicolau Sent: Tuesday, October 24, 2023 6:23 PM To: Marchand, David Cc: Wu, Jingjing ; Xing, Beilei ; dev@dpdk.org; sta...@dpdk.org Subject: Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition On 24-Oct

Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition

2023-10-24 Thread Radu Nicolau
On 24-Oct-23 12:24 PM, Zhang, Qi Z wrote: -Original Message- From: Radu Nicolau Sent: Tuesday, October 24, 2023 6:23 PM To: Marchand, David Cc: Wu, Jingjing ; Xing, Beilei ; dev@dpdk.org; sta...@dpdk.org Subject: Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition On 24-Oct

Re: [PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition

2023-10-24 Thread Radu Nicolau
On 24-Oct-23 10:49 AM, David Marchand wrote: On Tue, Oct 24, 2023 at 11:13 AM Radu Nicolau wrote: IAVF_TX_OFFLOAD_MASK definition contained RTE_ETH_TX_OFFLOAD_SECURITY instead of RTE_MBUF_F_TX_SEC_OFFLOAD. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta..

[PATCH] net/iavf: fix IAVF_TX_OFFLOAD_MASK definition

2023-10-24 Thread Radu Nicolau
IAVF_TX_OFFLOAD_MASK definition contained RTE_ETH_TX_OFFLOAD_SECURITY instead of RTE_MBUF_F_TX_SEC_OFFLOAD. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_rxtx.h | 2 +- 1 file changed, 1 inser

Re: [PATCH] net/iavf: fix Tx offloading flags check

2023-10-24 Thread Radu Nicolau
On 24-Oct-23 9:44 AM, David Marchand wrote: On Tue, Oct 24, 2023 at 10:40 AM Radu Nicolau wrote: On 24-Oct-23 6:42 AM, Zhang, Qi Z wrote: -Original Message- From: Radu Nicolau Sent: Tuesday, October 24, 2023 12:38 AM To: Wu, Jingjing ; Xing, Beilei Cc: dev@dpdk.org; Nicolau, Radu

Re: [PATCH] net/iavf: fix Tx offloading flags check

2023-10-24 Thread Radu Nicolau
On 24-Oct-23 6:42 AM, Zhang, Qi Z wrote: -Original Message- From: Radu Nicolau Sent: Tuesday, October 24, 2023 12:38 AM To: Wu, Jingjing ; Xing, Beilei Cc: dev@dpdk.org; Nicolau, Radu ; sta...@dpdk.org; Marchand, David Subject: [PATCH] net/iavf: fix Tx offloading flags check Use

[PATCH] net/iavf: fix Tx offloading flags check

2023-10-23 Thread Radu Nicolau
Use IAVF_TX_OFFLOAD_MASK flags instead of IAVF_TX_CKSUM_OFFLOAD_MASK. Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading") Cc: sta...@dpdk.org Cc: david.march...@redhat.com Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_rxtx.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] net/iavf: fix ESN session update

2023-09-11 Thread Radu Nicolau
Update both high and low section of the ESN. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ipsec_crypto.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/iavf/iavf_ipsec_c

Re: [PATCH] doc: postpone deprecation of pipeline legacy API

2023-07-20 Thread Radu Nicolau
On 19-Jul-23 4:12 PM, Cristian Dumitrescu wrote: Postpone the deprecation of the legacy pipeline, table and port library API and gradual stabilization of the new API. Signed-off-by: Cristian Dumitrescu --- Acked-by: Radu Nicolau

Re: [EXT] [PATCH] ipsec: fix NAT-T length calculation

2023-07-10 Thread Radu Nicolau
On 10-Jul-23 10:24 AM, Konstantin Ananyev wrote: 07/07/2023 14:26, Radu Nicolau пишет: On 07-Jul-23 1:51 PM, Xiao Liang wrote: sa->hdr_len and prm->tun.hdr_len don't include L2 length so both should start in the diagram at the end of the ETH header. So the right way to compu

Re: [EXT] [PATCH] ipsec: fix NAT-T length calculation

2023-07-07 Thread Radu Nicolau
On 07-Jul-23 1:51 PM, Xiao Liang wrote: sa->hdr_len and prm->tun.hdr_len don't include L2 length so both should start in the diagram at the end of the ETH header. So the right way to compute datagram length is dgram_len = mb->pkt_len - sqh_len - sa->hdr_l3_off - sa->hdr_len + sizeof(struct rt

Re: [EXT] [PATCH] ipsec: fix NAT-T length calculation

2023-07-07 Thread Radu Nicolau
bove shows how udph->dgram_len = mb->pkt_len - sqh_len - sa->hdr_len + sizeof(struct rte_udp_hdr); and l3_len = prm->tun.hdr_len - sa->hdr_l3_off; Correct me if anything wrong. Thanks, Xiao Liang On Thu, Jul 6, 2023 at 6:20 PM Radu Nicolau wrote: On 06-Jul-23 10:08 AM,

Re: [EXT] [PATCH] ipsec: fix NAT-T length calculation

2023-07-06 Thread Radu Nicolau
On 06-Jul-23 10:08 AM, Konstantin Ananyev wrote: Hi Akhil, Hi Konstantin, Can you review this patch? UDP header length is included in sa->hdr_len. Take care of that in L3 header and pakcet length calculation. Fixes: 01eef5907fc3 ("ipsec: support NAT-T") Signed-off-by: Xiao Liang --- li

[PATCH 2/2] net/iavf: use static capabilities to set IV size

2023-03-13 Thread Radu Nicolau
If iavf_crypto_capabilities contains the required capability then use the IV size defined there, otherwise use relaxed IV size constrains Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ipsec_crypto.c | 54 ++-- 1 file changed, 43 insertions(+), 11 deletions

[PATCH 1/2] examples/ipsec-secgw: allow single xform SA

2023-03-13 Thread Radu Nicolau
Update check capabilities before session create to allow single xform SA i.e. auth or cipher only Fixes: a8781df86c14 ("examples/ipsec-secgw: check capabilities before session create") Cc: gak...@marvell.com,kai...@intel.com Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/i

[PATCH] net/iavf: remove contrains for AEAD IV and AAD size

2023-02-17 Thread Radu Nicolau
Because of incosistencies between IPsec library and sample app implementations for inline crypto remove IV and AAD size constrains from the advertised crypto capabilities Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ipsec_crypto.c | 15 --- 1 file changed, 8 insertions

[PATCH v2] net/iavf: fix handling of IPsec events

2022-10-24 Thread Radu Nicolau
Verify that the message length is non zero and keep processing virtual channel messages after the event is received. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- v2: rebased to next-net-intel drivers/net/iavf/ia

[PATCH] net/iavf: fix handling of IPsec events

2022-10-20 Thread Radu Nicolau
Verify that the message length is non zero and keep processing virtual channel messages after the event is received. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_vc

[PATCH] net/iavf: fix queue stop for large VF

2022-10-20 Thread Radu Nicolau
Use large VF queue stop request when large VF is enabled Fixes: 9cf9c02bf6ee ("net/iavf: add enable/disable queues for large VF") Cc: sta...@dpdk.org Cc: ting...@intel.com Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_rxtx.c | 14 -- 1 file changed, 12 insert

[PATCH] net/iavf: fix SPI check

2022-10-14 Thread Radu Nicolau
Return error if SPI from the flow spec doesn't match the one from the crypto session. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ipsec_crypto.c | 14 +++--- 1 file changed, 3 in

[PATCH 3/3] net/txgbe: fix security session destroy

2022-10-13 Thread Radu Nicolau
Replace mempool_put with memset 0, the internal session memory block is no longer allocated from a mempool Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") Cc: gak...@marvell.com Signed-off-by: Radu Nicolau --- drivers/net/txgbe/txgbe_ipsec.c | 3 +-- 1 file changed, 1

[PATCH 2/3] net/ixgbe: fix security session destroy

2022-10-13 Thread Radu Nicolau
Replace mempool_put with memset 0, the internal session memory block is no longer allocated from a mempool Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") Cc: gak...@marvell.com Signed-off-by: Radu Nicolau --- drivers/net/ixgbe/ixgbe_ipsec.c | 4 +--- 1 file changed, 1

[PATCH 1/3] net/iavf: fix security session destroy

2022-10-13 Thread Radu Nicolau
Replace mempool_put with memset 0, the internal session memory block is no longer allocated from a mempool Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") Cc: gak...@marvell.com Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ipsec_crypto.c | 2 +- 1 file

[PATCH] net/iavf: fix IPsec flow create error check

2022-10-11 Thread Radu Nicolau
Fix an error check where the return code was assigned to a unsigned integer which can hide negative error codes. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ipsec_crypto.c | 10 +---

[PATCH] examples/ipsec-secgw: fix Tx checksum offload flag

2022-09-30 Thread Radu Nicolau
Fix a typo in computing port mask for Tx checksum offload capability. Fixes: 4edcee19fc20 ("examples/ipsec-secgw: use Tx checksum offload conditionally") Cc: ndabilpu...@marvell.com Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 2 +- 1 file changed, 1 inser

[PATCH] net/iavf: update ESN values when updating session

2022-08-29 Thread Radu Nicolau
When updating an ingress session update the internal values before making the virtual channel request. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ipsec_crypto.c | 5 +++-- 1 file changed, 3

[PATCH v2] examples/ipsec-secgw: fix fallback session create

2022-06-30 Thread Radu Nicolau
Fix fallback session create for inline sessions. Fixes: a8ade12123c3 ("examples/ipsec-secgw: create lookaside sessions at init") Cc: vfia...@marvell.com Signed-off-by: Radu Nicolau --- v2: create the session rather than just check if it's NULLL examples/ipsec-

[PATCH] examples/ipsec-secgw: fix fallback session create

2022-06-30 Thread Radu Nicolau
Fix fallback session create for inline sessions. Fixes: a8ade12123c3 ("examples/ipsec-secgw: create lookaside sessions at init") Cc: vfia...@marvell.com Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/sa.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) di

[PATCH v2] examples/ipsec-secgw: fix Tx checksum offload flag

2022-06-29 Thread Radu Nicolau
For the inline crypto path set the Tx checksum offload flag only if the device supports it. Fixes: d24471e5786b ("examples/ipsec-secgw: disable Tx checksum for inline") Cc: ndabilpu...@marvell.com Signed-off-by: Radu Nicolau Acked-by: Fan Zhang Acked-by: Akhil Goyal --- v2: when sup

[PATCH] examples/ipsec-secgw: fix Tx checksum offload flag

2022-06-22 Thread Radu Nicolau
For the inline crypto path set the Tx checksum offload flag only if the device supports it. Fixes: d24471e5786b ("examples/ipsec-secgw: disable Tx checksum for inline") Cc: ndabilpu...@marvell.com Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/sa.c | 5 - 1 file changed, 4

[PATCH] examples/ipsec-secgw: fix ESN setting

2022-06-14 Thread Radu Nicolau
Fix ESN option flag and initial value for the rte_ipsec library path. Fixes: 560029d5cfc9 ("examples/ipsec-secgw: define initial ESN value") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/sa.c | 5 + 1 file changed, 5 insertions(+) diff --git a/exam

[PATCH] examples/ipsec-secgw: fix packet type parsing

2022-06-10 Thread Radu Nicolau
Add new packet type flags instead of overwriting. Fixes: d04bb1c52647 ("examples/ipsec-secgw: use HW parsed packet type in poll mode") Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/i

[PATCH 3/3] net/iavf: fix NAT-T payload length

2022-05-25 Thread Radu Nicolau
Correct the length calculation used for NAT-T Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ipsec_crypto.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH 2/3] examples/ipsec-secgw: fix NAT-T header fields

2022-05-25 Thread Radu Nicolau
Use the proper IP protocol (UDP instead of ESP) and set the ports when UDP encapsulation is enabled. Fixes: 9ae86b4cfc77 ("examples/ipsec-secgw: support UDP encap for inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/sa.c | 6 -- 1 file

[PATCH 1/3] ipsec: fix NAT-T ports and length

2022-05-25 Thread Radu Nicolau
Fix the UDP header fields, wrong byte order used for src and dst port and wrong offset used when updating UDP datagram length. Fixes: 01eef5907fc3 ("ipsec: support NAT-T") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/sa.c | 4 ++-

[PATCH v2] net/iavf: fix device stop

2022-05-23 Thread Radu Nicolau
Move security context destroy from device stop to device close function. Deleting the context on device stop can prevent the application from properly cleaning and releasing resources. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Ra

[PATCH] net/iavf: fix device stop

2022-05-06 Thread Radu Nicolau
Move security context destroy from device stop to device close function. Deleting the context on device stop can prevent the application from properly cleaning and releasing resources. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Ra

[PATCH] net/iavf: fix device initialization

2022-04-20 Thread Radu Nicolau
When the inline crypto feature VF capability flag is set also check if the feature is enabled, otherwise the initialization will fail even when the inline crypto is not required. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Ra

[PATCH] net/iavf: fix AES-GMAC IV size

2022-03-01 Thread Radu Nicolau
Fix AES-GMAC size, set it to the required value, unlike lookaside where it also includes salt length. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ipsec_crypto.c | 2 +- 1 file changed, 1 inser

[PATCH v2] net/iavf: add NAT-T / UDP encapsulation support

2022-02-28 Thread Radu Nicolau
Add support for NAT-T / UDP encapsulated ESP. This fixes the inline crypto feature for iAVF which will not function properly without setting the UDP encapsulation options. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --

[PATCH] net/iavf: add NAT-T / UDP encapsulation support

2022-02-24 Thread Radu Nicolau
Add support for NAT-T / UDP encapsulated ESP. Signed-off-by: Radu Nicolau --- drivers/common/iavf/virtchnl_inline_ipsec.h | 9 + drivers/net/iavf/iavf_ipsec_crypto.c| 16 +--- drivers/net/iavf/iavf_ipsec_crypto.h| 4 +++- 3 files changed, 25 insertions

[PATCH v2] net/iavf: fix segmentation offload buffer size

2022-02-15 Thread Radu Nicolau
This fix commit ff8b8bcd2ebe, which resulted in incorrect buffer size being computed for non IPses TSO packets. Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") Signed-off-by: Radu Nicolau --- v2: reworked it to fix the initial issue instead of just reverting ff

[PATCH] net/iavf: fix segmentation offload buffer size

2022-02-10 Thread Radu Nicolau
This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size being computed for TSO packets. Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_rxtx.c | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH v2] dma/idxd: add allow/block list support

2021-12-02 Thread Radu Nicolau
Add support for allow or block list for devices bound to the kernel driver. When used the allow or block list applies as an additional condition to the name prefix. Signed-off-by: Radu Nicolau Reviewed-by: Bruce Richardson Acked-by: Bruce Richardson --- v2: corrected doc doc/guides/dmadevs

[PATCH] dma/idxd: add allow/block list support

2021-11-30 Thread Radu Nicolau
Add support for allow or block list for devices bound to the kernel driver. When used the allow or block list applies as an additional condition to the name prefix. Signed-off-by: Radu Nicolau --- doc/guides/dmadevs/idxd.rst | 10 ++ drivers/dma/idxd/idxd_bus.c | 30

[PATCH] examples/ipsec-secgw: wrong offload flag used for TSO IPv6

2021-11-25 Thread Radu Nicolau
RTE_MBUF_F_TX_OUTER_IP_CKSUM should not be set for IPv6 packets. Fixes: a7f32947a316 ("examples/ipsec-secgw: support TCP TSO") Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec_process.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/i

[PATCH] examples/ipsec-secgw: set L4 length for TSO packets

2021-11-24 Thread Radu Nicolau
Using RTE_MBUF_F_TX_TCP_SEG requires L4 length to be set. Fixes: a7f32947a316 ("examples/ipsec-secgw: support TCP TSO") Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec_process.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/ipsec-secgw/ipsec_process.c b/exam

[PATCH] net/iavf: fix segmentation offload condition

2021-11-22 Thread Radu Nicolau
Apply segmentation offload when requested for non tunneled packets e.g. IPsec transport mode. Fixes: 1e728b01120c ("net/iavf: rework Tx path") Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_rxtx.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/d

[PATCH] net/iavf: fix VLAN insertion

2021-11-15 Thread Radu Nicolau
Fix wrong VLAN insertion position as inner. Fixes: 1e728b01120c ("net/iavf: rework Tx path") Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_rxtx.c | 50 1 file changed, 34 insertions(+), 16 deletions(-) diff --git a/drivers/net/iavf/iav

[dpdk-dev] [PATCH] net/iavf: fix xstats reset

2021-11-09 Thread Radu Nicolau
Wrong offset used to clear the extended stats section resulting in eth stats not being reset. Fixes: ccb49b834cd7 ("net/iavf: support xstats for inline IPsec crypto") Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ethdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletion

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix memory leaks

2021-11-09 Thread Radu Nicolau
Free telemetry structures when memory allocation or input parameter errors occur. Fixes: 3e7b7dd88021 ("examples/ipsec-secgw: support telemetry") Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 65 ++ 1 file changed, 49 inserti

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix potential build error

2021-11-03 Thread Radu Nicolau
("examples/ipsec-secgw: add per-core packet statistics") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 2 ++ examples/ipsec-secgw/ipsec-secgw.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix build error

2021-11-03 Thread Radu Nicolau
Move core_statistics definition out of header file. Fixes: 1329602b6c8f ("examples/ipsec-secgw: add per-core packet statistics") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 2 ++ examples/ipsec-secgw/ipsec-secgw.h | 2 +- 2 files

[dpdk-dev] [PATCH v6 6/7] examples/ipsec-secgw: add ethdev reset callback

2021-11-01 Thread Radu Nicolau
Applications should not quietly ignore an ethdev reset event. Register an event handler for ethdev reset callback RTE_ETH_EVENT_INTR_RESET that prints a message and quits the application. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal --- examples/ipsec-secgw

[dpdk-dev] [PATCH v6 7/7] examples/ipsec-secgw: add support for additional algorithms

2021-11-01 Thread Radu Nicolau
Add support for AES-GMAC, AES_CTR, AES_XCBC_MAC, AES_CCM, CHACHA20_POLY1305 Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal --- doc/guides/rel_notes/release_21_11.rst | 2 + doc/guides/sample_app_ug/ipsec_secgw.rst | 3 +- examples/ipsec-secgw/ipsec.h

[dpdk-dev] [PATCH v6 1/7] examples/ipsec-secgw: add stats interval argument

2021-11-01 Thread Radu Nicolau
Add -t for stats screen update interval, disabled by default. Signed-off-by: Radu Nicolau Acked-by: Hemant Agrawal Acked-by: Anoob Joseph --- doc/guides/sample_app_ug/ipsec_secgw.rst | 5 examples/ipsec-secgw/ipsec-secgw.c | 29 examples/ipsec-secgw/ipsec

[dpdk-dev] [PATCH v6 5/7] examples/ipsec-secgw: define initial ESN value

2021-11-01 Thread Radu Nicolau
172.16.2.5 \ esn 1 Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal --- doc/guides/sample_app_ug/ipsec_secgw.rst | 10 ++ examples/ipsec-secgw/ipsec.c | 6 ++ examples/ipsec-secgw/ipsec.h | 1 + examples/ipsec-secgw/sa.c

[dpdk-dev] [PATCH v6 2/7] examples/ipsec-secgw: update create inline session

2021-11-01 Thread Radu Nicolau
Rework create inline session function as to update the session configuration parameters before create session is called. Also updated the rss key array size to prevent buffers overflows with PMDs that copy more than 40 bytes. Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal --- examples/ipsec

[dpdk-dev] [PATCH v6 4/7] examples/ipsec-secgw: support telemetry

2021-11-01 Thread Radu Nicolau
Add telemetry support to the IPsec GW sample app and add support for per SA telemetry when using IPsec library. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- doc/guides/rel_notes/release_21_11.rst | 4 + doc/guides/sample_app_ug/ipsec_secgw.rst | 11 + examples/ipsec-secgw

[dpdk-dev] [PATCH v6 3/7] examples/ipsec-secgw: add support for inline crypto UDP encapsulation

2021-11-01 Thread Radu Nicolau
Enable UDP encapsulation for both transport and tunnel modes for the inline crypto offload path. Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal --- doc/guides/sample_app_ug/ipsec_secgw.rst | 3 ++- examples/ipsec-secgw/ipsec.c | 33 +--- examples/ipsec-secgw

[dpdk-dev] [PATCH v6 0/7] IPsec Sec GW new features

2021-11-01 Thread Radu Nicolau
Update the IPsec sample app with new features and updates: - telemetry support - add reset callback - stats screen configurable as a command line parameter - UDP encapsulation support for inline crypto - ESN with configurable start value Radu Nicolau (7): examples/ipsec-secgw: add stats

[dpdk-dev] [PATCH 2/2] net/iavf: fix build error

2021-10-29 Thread Radu Nicolau
Fix build error and wrong parameter used for function call Fixes: 7dd3f3e43732 ("net/iavf: add iAVF IPsec inline crypto support") Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ipsec_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[dpdk-dev] [PATCH 1/2] net/iavf: fix build error

2021-10-29 Thread Radu Nicolau
Fix clang build error, remove unused function Fixes: f12d8bf150f5 ("net/iavf: rework Tx path") Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_rxtx.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index

[dpdk-dev] [PATCH v13 5/7] net/iavf: add xstats support for inline IPsec crypto

2021-10-28 Thread Radu Nicolau
Add per queue counters for maintaining statistics for inline IPsec crypto offload, which can be retrieved through the rte_security_session_stats_get() with more detailed errors through the rte_ethdev xstats. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Acked-by: Jingjing Wu

  1   2   3   4   5   6   7   >