On Friday, June 06/10/22, 2022 at 16:45:22 -0700, Stephen Hemminger wrote:
> On Sat, 11 Jun 2022 03:36:43 +0530
> Rahul Lakkireddy wrote:
>
> > Add comma after 1 in 1000 too, like 1,000. Also, since max uint64_t is
> > a 20 digit number, increase space in temporary ar
outb[IPSEC_TEST_PACKETS_MAX];
^~~
Bugzilla ID: 1032
Fixes: d02c6bfcb99a ("test/crypto: add ESN and antireplay cases")
Cc: sta...@dpdk.org
Reported-by: Daxue Gao
Signed-off-by: Rahul Lakkireddy
---
v2:
- Return TEST_FAILED, instead of TEST_SKIPPED
- Add th
outb[IPSEC_TEST_PACKETS_MAX];
^~~
Fixes: d02c6bfcb99a ("test/crypto: add ESN and antireplay cases")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
app/test/test_cryptodev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test/test_cry
of size 4
sprintf(p[i++], "%d", (int)n);
^
Bugzilla ID: 1029
Fixes: 15c431864000 ("app/flow-perf: add packet forwarding support")
Cc: sta...@dpdk.org
Reported-by: Daxue Gao
Signed-off-by: Rahul Lakkireddy
---
app/test-flo
be: read firmware configuration file from
filesystem")
Reported-by: Daxue Gao
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c
index
to redistribute resources, like queues, TCAMs, etc.,
from disabled physical functions (PFs) to main PF, before
firmware init.
Signed-off-by: Rahul Lakkireddy
---
v3:
- Update cxgbe pmd doc about copying t5-config.txt to
/lib/firmware/cxgb4/ directory.
- Update cxgbe pmd doc about firmware
On Monday, May 05/16/22, 2022 at 12:06:01 +0100, Ferruh Yigit wrote:
> On 5/16/2022 11:27 AM, Rahul Lakkireddy wrote:
> > Add support to read firmware configuration file from
> > /lib/firmware/cxgb4/ path in the filesystem. The firmware
> > config file is used to enable or
to redistribute resources, like queues, TCAMs, etc.,
from disabled physical functions (PFs) to main PF, before
firmware init.
Signed-off-by: Rahul Lakkireddy
---
v2:
- Update cxgbe pmd doc about the firmware config file
- Update commit message to explain more about firmware config file
doc
On Tuesday, May 05/10/22, 2022 at 16:30:59 +0200, Thomas Monjalon wrote:
> 10/05/2022 16:11, Rahul Lakkireddy:
> > On Tuesday, May 05/10/22, 2022 at 11:02:05 +0200, Thomas Monjalon wrote:
> > > 06/05/2022 13:36, Rahul Lakkireddy:
> > > > The Chelsio FW config file con
On Tuesday, May 05/10/22, 2022 at 11:02:05 +0200, Thomas Monjalon wrote:
> 06/05/2022 13:36, Rahul Lakkireddy:
> > The Chelsio FW config file contains a list of register=value pairs to
> > change configuration of the NIC before firmware is initialized.
> > It closely resemble
nters. Also add xstats for these
counters.
Signed-off-by: Rahul Lakkireddy
---
v2:
- Update commit message with more info about the TP counters.
drivers/net/cxgbe/base/common.h | 2 ++
drivers/net/cxgbe/base/t4_hw.c | 14 --
drivers/net/cxgbe/base/t4_regs.h | 4
drivers/net/
On Thursday, May 05/05/22, 2022 at 17:36:06 +0100, Ferruh Yigit wrote:
> On 5/5/2022 5:29 PM, Ferruh Yigit wrote:
> > On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote:
> > > Add support to read firmware configuration file from
> > > /lib/firmware/cxgb4/ path in the fil
On Thursday, May 05/05/22, 2022 at 17:28:55 +0100, Ferruh Yigit wrote:
> On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote:
> > Rx packets can get dropped at TP due to congestion and this info
> > will not get propagated to MPS. Track these Rx dropped packets
> > in imissed cou
Add support to read firmware configuration file from
/lib/firmware/cxgb4/ path in the filesystem.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4fw_interface.h | 1 +
drivers/net/cxgbe/cxgbe_main.c | 329
2 files changed, 217 insertions(+), 113
Rx packets can get dropped at TP due to congestion and this info
will not get propagated to MPS. Track these Rx dropped packets
in imissed counter. Also add xstats for these counters.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/common.h | 2 ++
drivers/net/cxgbe/base/t4_hw.c
Match the closest supported Rx payload buffer size with the mempool
data size and program it for the Rx queue. This removes unnecessary
need for handling additional padding, packing, and alignment, when
posting Rx buffers to hardware.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base
acket through the normal Tx path.
Also use FW_ETH_TX_PKTS_WR to handle mbufs with chain for FW
to optimize.
Fixes: 6c2809628cd5 ("net/cxgbe: improve latency for slow traffic")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/sge.c | 38 +++---
Fill the correct DPDK ethdev port_id, instead of local adapter
physical port_id in mbufs allocated for Rx.
Fixes: 78fc1a716ae8 ("cxgbe: improve Rx performance")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/sge.c | 2 +-
1 file changed, 1 insertion(+),
/cxgb4/ to allow changing firmware parameters without
having to flash the configuration file onto the adapter.
Thanks,
Rahul
Rahul Lakkireddy (5):
net/cxgbe: fill correct port info in mbufs for Rx
net/cxgbe: fix Tx queue stuck with mbuf chain coalescing
net/cxgbe: simplify Rx payload buffer
Hi Ferruh,
On Monday, January 01/17/22, 2022 at 14:36:30 +, Ferruh Yigit wrote:
> Observed with: gcc (GCC) 12.0.0 20220116 (experimental)
>
> In file included from ../lib/eal/linux/include/rte_os.h:14,
> from ../lib/eal/include/rte_common.h:28,
> from ../lib/
’ declared here
Reported-by: Ferruh Yigit
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/adapter.h | 2 -
drivers/net/cxgbe/base/t4_hw.c | 83
drivers/net/cxgbe/base/t4vf_hw.c | 28 +++
3 files changed, 49 insertions(+), 64 deletions(-)
diff
h Yigit
Looks good. Thanks for fixing it up.
Reviewed-by: Rahul Lakkireddy
From: Nikhil Vasoya
Implement eth_dev_ops callback to get firmware version.
Signed-off-by: Nikhil Vasoya
Signed-off-by: Rahul Lakkireddy
---
v2:
- Update FW version feature in cxgbe.ini and cxgbevf.ini
doc/guides/nics/features/cxgbe.ini | 1 +
doc/guides/nics/features/cxgbevf.ini | 1
From: Nikhil Vasoya
Add support to fetch port and queue stats via xstats API. Also remove
queue stats from basic stats because they're now available via xstats
API for the VF.
Signed-off-by: Nikhil Vasoya
Signed-off-by: Rahul Lakkireddy
---
v2:
- Update Extended Stats feature in cxgbe.in
This series of patches add following features.
Patch 1 adds support to fetch port and queue stats via xstats API
for VF.
Patch 2 adds support to get firmware version.
Thanks,
Rahul
---
v2:
- Update Extended Stats and FW version features in cxgbe.ini and
cxgbevf.ini
Nikhil Vasoya (2):
net/c
From: Nikhil Vasoya
Implement eth_dev_ops callback to get firmware version.
Signed-off-by: Nikhil Vasoya
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_ethdev.c | 26 ++
drivers/net/cxgbe/cxgbe_pfvf.h | 2 ++
drivers/net/cxgbe/cxgbevf_ethdev.c | 1
From: Nikhil Vasoya
Add support to fetch port and queue stats via xstats API. Also remove
queue stats from basic stats because they're now available via xstats
API for the VF.
Signed-off-by: Nikhil Vasoya
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_ethdev.c
This series of patches add following features.
Patch 1 adds support to fetch port and queue stats via xstats API
for VF.
Patch 2 adds support to get firmware version.
Thanks,
Rahul
Nikhil Vasoya (2):
net/cxgbe: add support for xstats API for the VF
net/cxgbe: add support to get firmware ver
and prevent flooding firmware debug logs with permission
errors.
Fixes: a83041b1e998 ("net/cxgbe: rework and simplify link handling")
Cc: sta...@dpdk.org
Signed-off-by: Nikhil Vasoya
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4_hw.c | 2 +-
1 file changed, 1 inser
Remove queue stats from basic stats because they're now available
via xstats API. Also remove RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag.
Signed-off-by: Rahul Lakkireddy
---
v2:
- No change.
drivers/net/cxgbe/cxgbe_ethdev.c | 18 +++---
1 file changed, 3 insertions(+), 15 dele
Add support to fetch port and queue stats via xstats API.
Signed-off-by: Rahul Lakkireddy
---
v2:
- Perform explicit checks for NULL in conditions.
- Use rte_strlcpy() instead of strcpy().
drivers/net/cxgbe/cxgbe_ethdev.c | 303 ++-
1 file changed, 294 insertions
--
v2:
- Perform explicit checks for NULL in conditions.
- Use rte_strlcpy() instead of strcpy().
Rahul Lakkireddy (2):
net/cxgbe: add support for xstats API
net/cxgbe: remove queue stats from basic stats
drivers/net/cxgbe/cxgbe_ethdev.c | 321 ---
1 file changed
Hi Andrew,
On Thursday, July 07/01/21, 2021 at 17:50:19 +0300, Andrew Rybchenko wrote:
> On 6/3/21 6:30 PM, Rahul Lakkireddy wrote:
> > Remove queue stats from basic stats because they're now available
> > via xstats API. Also remove RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag.
&g
Remove queue stats from basic stats because they're now available
via xstats API. Also remove RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_ethdev.c | 18 +++---
1 file changed, 3 insertions(+), 15 deletions(-)
diff --
Add support to fetch port and queue stats via xstats API.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_ethdev.c | 302 ++-
1 file changed, 293 insertions(+), 9 deletions(-)
diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe
This series of patches add support to fetch port and queue stats via
xstats API.
Patch 1 adds support to fetch port and queue stats via xstats API.
Patch 2 removes queue stats from basic stats since they're available
via xstats API. Also removes RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag.
ed/removed when promisc mode is turned on/off
on the interface.
Signed-off-by: Rahul Lakkireddy
---
doc/guides/nics/cxgbe.rst | 14 ++---
drivers/net/cxgbe/base/common.h | 3 +
drivers/net/cxgbe/base/t4fw_interface.h | 2 +
drivers/net/cxgbe/cxgbe_ethdev.c| 14
Replace rte_atomic ops with C11 atomics.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4_hw.c | 1 -
drivers/net/cxgbe/clip_tbl.c | 13 +++--
drivers/net/cxgbe/clip_tbl.h | 2 +-
drivers/net/cxgbe/cxgbe_ethdev.c | 1 -
drivers/net/cxgbe/cxgbe_main.c | 23
deprecated rte_atomic ops to C11 atomics.
Patch 2 queries firmware for RAW MAC matchall filter support and
enables it when available.
Rahul Lakkireddy (2):
net/cxgbe: use C11 atomics instead of rte_atomic ops
net/cxgbe: add MAC matchall to track promisc traffic
doc/guides/nics/cxgbe.rst
re-enabled once the link up event is received in the firmware
event queue.
Signed-off-by: Rahul Lakkireddy
---
doc/guides/nics/cxgbe.rst | 14 +++
drivers/net/cxgbe/base/adapter.h| 4 ++
drivers/net/cxgbe/base/common.h | 1 +
drivers/net/cxgbe/base/t4_hw.
, there can only be 1 active FEC at any time. So, simplify the
FEC get ops. If FEC is supported and if none of the supported FEC
caps are set, then assume NOFEC by default, instead of AUTO.
Fixes: b99a547371e3 ("net/cxgbe: support configuring link FEC")
Signed-off-by: Rahul Lakkireddy
--
tatus coming in firmware's link config change reply.
Fixes: 61570952b138 ("net/cxgbe: rework and simplify link handling code")
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4_hw.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/
fixes issue with link FEC retraining during probe. If
firmware had already saved FEC before probe is completed, then
use the saved FEC for further link configuration, instead of
triggering link retraining. Also simplifies get fec ops.
Thanks,
Rahul
Rahul Lakkireddy (2):
net/cxgbe: do not link
+dev@dpdk.org which seems to have been dropped by accident.
On Friday, December 12/25/20, 2020 at 09:03:43 +0800, Min Hu (Connor) wrote:
>
>
> 在 2020/12/24 19:25, Rahul Lakkireddy 写道:
> >On Thursday, December 12/24/20, 2020 at 17:36:27 +0800, Min Hu (Connor)
> >wrote:
&g
From: Karra Satwik
Request the driver for number of entries in the FEC caps
array and then dynamically allocate the array.
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
Acked-by: Xiaoyun Li
---
v3:
- Use unsigned int num, instead of int num
v2:
- Replace if (!speed_fec_capa
On Monday, December 12/21/20, 2020 at 17:07:21 +0800, Min Hu (Connor) wrote:
>
>
> 在 2020/12/21 6:47, Rahul Lakkireddy 写道:
> >From: Karra Satwik
> >
> >Start from index 0 when going through the FEC array. This will allow
> >"off" to get print
From: Karra Satwik
Request the driver for number of entries in the FEC caps
array and then dynamically allocate the array.
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
Acked-by: Xiaoyun Li
---
v2:
- Replace if (!speed_fec_capa) with if (speed_fec_capa == NULL)
app/test-pmd
From: Karra Satwik
Add ethdev ops to query and configure link FEC.
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/common.h | 2 +
drivers/net/cxgbe/base/t4_hw.c | 79 ++
drivers/net/cxgbe/base/t4fw_interface.h | 6
From: Karra Satwik
Rework and simplify link handling code. Remove redundant
variables in link configuration structure and directly
extract information from the 32-bit link capabilities.
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/adapter.h
From: Karra Satwik
Remove legacy 16-bit link capabilities and always request for the
32-bit link capabilities from firmware.
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
---
doc/guides/nics/cxgbe.rst | 14 +-
drivers/net/cxgbe/base/common.h | 9
This series of patches rework link handling and add support to
configure Forward Error Correction (FEC) capability.
Patch 1 removes legacy 16-bit link capabilities infrastructure
and always enables 32-bit link capabilities in firmware.
Patch 2 simplifies link handling in preparation for FEC suppo
From: Karra Satwik
Request the driver for number of entries in the FEC caps
array and then dynamically allocate the array.
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
---
app/test-pmd/cmdline.c | 29 -
1 file changed, 20 insertions(+), 9 deletions
From: Karra Satwik
Start from index 0 when going through the FEC array. This will allow
"off" to get printed for RTE_ETH_FEC_NOFEC mode.
Fixes: b19da32e3151 ("app/testpmd: add FEC command")
Cc: sta...@dpdk.org
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkiredd
org
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_flow.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/cxgbe/cxgbe_flow.c b/drivers/net/cxgbe/cxgbe_flow.c
index f7c4f3696..520a5a5c9 100644
--- a/drivers/net/cxgbe/cxg
On Thursday, September 09/17/20, 2020 at 13:46:24 +0100, Ferruh Yigit wrote:
> On 9/1/2020 6:16 PM, Rahul Lakkireddy wrote:
> >Enable RTE_ETH_DEV_CLOSE_REMOVE during PCI probe for all ports
> >enumerated under the PF. Free up the underlying port Virtual
> >Identifier (VI) and
On Monday, September 09/14/20, 2020 at 00:16:17 +0200, Thomas Monjalon wrote:
> The patches for removing RTE_ETH_DEV_CLOSE_REMOVE are sent:
> https://patches.dpdk.org/project/dpdk/list/?series=12173
>
> 11 drivers are not supporting the new behaviour correctly:
> bnx2x, cxgbe, dpaa, dp
Chelsio T6 NIC can support up to 8 priority channels to manage
congestion. So, increase to 8 congestion channels for T6. Also,
add Rxq state to avoid unnecessarily ringing doorbell and polling
the hardware for more traffic when the Rxq is stopped.
Signed-off-by: Rahul Lakkireddy
---
drivers/net
ber/179131.html
Thanks,
Rahul
Rahul Lakkireddy (3):
net/cxgbe: rework queue allocation between ports
net/cxgbe: improve Rx congestion control
net/cxgbe: add support to update RSS redirection table
doc/guides/nics/features/cxgbe.ini | 1 +
drivers/net/cxgbe/base/adapter.h | 23 +++--
d
Implement eth_dev_ops to manipulate RSS redirection table.
Signed-off-by: Rahul Lakkireddy
---
doc/guides/nics/features/cxgbe.ini | 1 +
drivers/net/cxgbe/cxgbe_ethdev.c | 65 ++
2 files changed, 66 insertions(+)
diff --git a/doc/guides/nics/features/cxgbe.ini
b
, remove the equal distribution scheme and allow the
ports to allocate as many queues as they need.
Also remove the hardcoded 64 max limit on queue allocation. Instead,
use the max limit given by firmware.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/adapter.h | 12 +--
drivers/net
table")
Cc: sta...@dpdk.org
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
---
v2:
- Fix spelling Othewise to Otherwise in commit message.
drivers/net/cxgbe/mps_tcam.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/cxgbe/mps_tcam.c b/drivers/net/cxgbe/mps_tc
Ensure packets are available before accessing the mbuf list in Tx
burst function. Otherwise, just reclaim completed Tx descriptors and
exit.
Fixes: b1df19e43e1d ("net/cxgbe: fix prefetch for non-coalesced Tx packets")
Cc: sta...@dpdk.org
Reported-by: Brian Poole
Signed-off-by: Rahul
table")
Cc: sta...@dpdk.org
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/mps_tcam.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/cxgbe/mps_tcam.c b/drivers/net/cxgbe/mps_tcam.c
index 5302d1343..6e5fae992 100644
--- a/drivers/net/cxgbe/
all ports under
the PF, in PCI remove too.
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_ethdev.c | 28
drivers/net/cxgbe/cxgbe_main.c | 12 ++--
drivers/net/cxgbe/cxgbevf_ethdev.c | 8 +---
drivers/net/cxgbe/cxgbevf_main.c | 2 ++
4
d freelist queue.
So, remove check that tries to give memzone name for a non-existent
freelist queue.
Also, add a missing free for the control queue mempools.
Fixes: 0462d115441d ("cxgbe: add device related operations")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/
Patch 1 fixes queue DMA ring leaks seen during port close.
Patch 2 enables RTE_ETH_DEV_CLOSE_REMOVE and reworks resources
release logic for port close.
Thanks,
Rahul
Rahul Lakkireddy (2):
net/cxgbe: fix queue DMA ring leaks during port close
net/cxgbe: release port resources during port
From: Karra Satwik
Disable all unused firmware resources during init time to give
more resources for HASH (exact-match) filter region and always
request firmware to enable HASH filter support when resources
are available.
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
Free up Source MAC Table (SMT) entry properly during filter create
failure and filter delete.
Fixes: 993541b2fa4f ("net/cxgbe: support flow API for source MAC rewrite")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_fil
create, but only freed once during flow destroy.
Patch 4 fixes Source MAC Table (SMT) entry leaks.
Patch 5 fixes flow validation errors seen due to default masks set
for unrequested fields.
Thanks,
Rahul
Rahul Lakkireddy (5):
net/cxgbe: fix CLIP leak in filter error path
net/cxgbe: fix L2T
a444 ("net/cxgbe: add devargs to control filtermode and
filtermask")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_flow.c | 109 ++---
1 file changed, 74 insertions(+), 35 deletions(-)
diff --git a/drivers/net/cxgbe/cxgbe_
Free up Layer 2 Table (L2T) entry properly during filter create
failure and filter delete.
Fixes: 1decc62b1cbe ("net/cxgbe: add flow operations to offload VLAN actions")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_fil
")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_filter.c | 68 +++-
1 file changed, 31 insertions(+), 37 deletions(-)
diff --git a/drivers/net/cxgbe/cxgbe_filter.c b/drivers/net/cxgbe/cxgbe_filter.c
index 27e96c73e..45602d468 10
request.
Fixes: fefee7a619a4 ("net/cxgbe: add flow ops to match based on dest MAC")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_filter.c | 32
drivers/net/cxgbe/cxgbe_filter.h | 4 +++-
drivers/net/cxgbe/cxgbe_flo
On Wednesday, March 03/18/20, 2020 at 16:07:07 +0100, Thomas Monjalon wrote:
> 18/03/2020 14:06, Rahul Lakkireddy:
> > Hi Thomas,
> >
> > On Wednesday, March 03/18/20, 2020 at 13:09:47 +0100, Thomas Monjalon wrote:
> > > 11/03/2020 10:05, Rahul Lakkired
-off-by: Ferruh Yigit
I've tested CLANG compilation with 9.0.1 without this patch,
but couldn't hit the above mentioned error.
# clang --version
clang version 9.0.1 (Fedora 9.0.1-2.fc31)
However, after grabbing CLANG 3.4.2, I could see the error.
# clang --version
clang version 3.4
Hi Thomas,
On Wednesday, March 03/18/20, 2020 at 13:09:47 +0100, Thomas Monjalon wrote:
> 11/03/2020 10:05, Rahul Lakkireddy:
> > From: Karra Satwik
> >
> > This series of patches contain rte_flow support for matching
> > Q-in-Q VLAN, IP TOS, PF, and VF fields. Als
pport the new API, fallback to older way
of directly reading from indirect registers
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/common.h | 1 +
drivers/net/cxgbe/base/t4_hw.c | 46 ++---
drivers/net/cxgbe
and reflashing them onto the adapter. A table
of supported combinations is maintained by the driver to internally
translate the User specified devargs combination to hardware's internal
format before writing the requested combination to hardware
Signed-off-by: Karra Satwik
Signed-off-by:
be
matched.
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/adapter.h| 6
drivers/net/cxgbe/base/common.h | 6 ++--
drivers/net/cxgbe/base/t4_hw.c | 27 +---
drivers/net/cxgbe/base/t4fw_interface.h | 23 +
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4_tcb.h | 2 ++
drivers/net/cxgbe/cxgbe_filter.c | 8 ++--
drivers/net/cxgbe/cxgbe_filter.h | 1 +
drivers/net/cxgbe/cxgbe_flow.c | 14 ++
4 files changed, 23 insertions(+), 2 deletions(-)
diff --git a/drivers/net
-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4_msg.h | 40 +
drivers/net/cxgbe/base/t4_tcb.h | 8 +
drivers/net/cxgbe/base/t4fw_interface.h | 7 +-
drivers/net/cxgbe/cxgbe_filter.c| 35 -
drivers/net/cxgbe/cxgbe_filter.h| 3 +
drivers/net/cxgbe
igned-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/Makefile | 1 +
drivers/net/cxgbe/base/adapter.h| 1 +
drivers/net/cxgbe/base/t4fw_interface.h | 2 ++
drivers/net/cxgbe/cxgbe_main.c | 41 ++-
drivers/net/cxgbe/meson.build | 1 +
dr
emove check to reject rules without spec because
RTE_FLOW_ITEM_TYPE_PF doesn't require a spec. Due to this check
removal, RTE_FLOW_ITEM_TYPE_PHY_PORT item needs to be updated to
handle NULL spec
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/cxgbe_fil
From: Karra Satwik
Add support to match Type of Service (TOS) field in
IPv4/IPv6 header
Signed-off-by: Karra Satwik
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/common.h | 1 +
drivers/net/cxgbe/base/t4_hw.c | 1 +
drivers/net/cxgbe/cxgbe_filter.c | 7 +-
drivers/net
From: Karra Satwik
This series of patches contain rte_flow support for matching
Q-in-Q VLAN, IP TOS, PF, and VF fields. Also, adds Destination
MAC rewrite and Source MAC rewrite actions.
Apart from the 4-tuple (IP src/dst addresses and TCP/UDP src/dst
port addresses), there are only 40-bits avai
ned-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4_hw.c | 7 ---
drivers/net/cxgbe/base/t4_regs.h | 4 ++
drivers/net/cxgbe/cxgbe_filter.c | 26 +++-
drivers/net/cxgbe/cxgbe_flow.c | 102 +--
4 files changed, 82 insertions(+), 57 deletions(-)
di
Multi-segs Tx is already supported by CXGBE PMD. So, add the missing
DEV_TX_OFFLOAD_MULTI_SEGS flag to the list of supported Tx offload
features.
Fixes: 436125e64174 ("net/cxgbe: update to Rx/Tx offload API")
Cc: sta...@dpdk.org
Reported-by: Chas Williams <3ch...@gmail.com>
Sign
On Monday, January 01/13/20, 2020 at 15:50:21 -0500, Chas Williams wrote:
>
> It looks like the cxgbe driver doesn't set the DEV_TX_OFFLOAD_MULTI_SEGS
> offload capability. However, it looks like sge.c does have support for
> sending mbuf chains, e.g. write_sgl(). Is this just an oversight or is
>
implement flow create operation")
Fixes: da23bc9d33f4 ("net/cxgbe: implement flow destroy operation")
Fixes: 8d3c12e19368 ("net/cxgbe: implement flow query operation")
Fixes: 86910379d335 ("net/cxgbe: implement flow flush operation")
Cc: sta...@dpdk.org
Signe
Add support for setting VLAN PCP field via rte_flow API. Hardware
overwrites the entire 16-bit VLAN TCI field. So, both VLAN VID and
PCP actions must be specified.
Signed-off-by: Rahul Lakkireddy
---
v2:
- No changes.
drivers/net/cxgbe/cxgbe_flow.c | 27 +++
1 file
Query firmware for max number of packets that can be coalesced by
Tx.
Signed-off-by: Rahul Lakkireddy
---
v2:
- No changes.
doc/guides/nics/cxgbe.rst | 18 ++--
drivers/net/cxgbe/base/common.h | 1 +
drivers/net/cxgbe/base/t4fw_interface.h | 3 +-
drivers/net
Remove compile time option to control Tx coalescing Latency vs
Throughput behavior. Add tx_mode_latency devarg instead, to
dynamically control Tx coalescing behavior.
Signed-off-by: Rahul Lakkireddy
---
v2:
- No changes.
config/common_base | 1 -
doc/guides/nics/cxgbe.rst
ader, when
parsing incoming packet against VLAN pattern.
Signed-off-by: Rahul Lakkireddy
---
v2:
- No changes.
drivers/net/cxgbe/base/t4_regs_values.h | 9 ++
drivers/net/cxgbe/cxgbe_filter.c| 11 +-
drivers/net/cxgbe/cxgbe_flow.c | 145 +++-
drivers
Rework devargs parsing logic to separate VF only args.
Signed-off-by: Rahul Lakkireddy
---
v2:
- In cxgbe.rst doc, use ^ (instead of -) to represent common and
vf-only devargs as subsection of Runtime Options.
doc/guides/nics/cxgbe.rst | 6 +++
drivers/net/cxgbe/base/adapter.h
Remove compile time flags and use dynamic logging for debug prints.
Also remove rarely used debug logs in register access and datapath.
Signed-off-by: Rahul Lakkireddy
---
v2:
- Remove rarely used CXGBE_DEBUG_REG, CXGBE_DEBUG_TX, and
CXGBE_DEBUG_RX debug logs.
config/common_base
1e209cfc ("net/cxgbe: add Compressed Local IP region")
Signed-off-by: Rahul Lakkireddy
---
v2:
- No changes.
drivers/net/cxgbe/cxgbe_filter.c | 193 +++
drivers/net/cxgbe/cxgbe_filter.h | 5 +-
drivers/net/cxgbe/cxgbe_flow.c | 15 ++-
3 files changed, 8
Pass correct arguments to CLIP allocation code to avoid NULL pointer
dereference.
Cc: sta...@dpdk.org
Fixes: 3f2c1e209cfc ("net/cxgbe: add Compressed Local IP region")
Signed-off-by: Rahul Lakkireddy
---
v2:
- No changes.
drivers/net/cxgbe/cxgbe_filter.c | 2 +-
1 file changed, 1
cxgbe: add link up and down ops")
Signed-off-by: Rahul Lakkireddy
---
v2:
- No changes.
drivers/net/cxgbe/cxgbe_ethdev.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c
index 5d74f8ba3..5df8d746c 100644
--- a/dr
Move prefetch code out of Tx coalesce path to allow prefetching for
non-coalesced Tx packets, as well.
Cc: sta...@dpdk.org
Fixes: bf89cbedd2d9 ("cxgbe: optimize forwarding performance for 40G")
Signed-off-by: Rahul Lakkireddy
---
v2:
- No changes.
drivers/net/cxgbe/cxgbe_et
: 1decc62b1cbe ("net/cxgbe: add flow operations to offload VLAN actions")
Signed-off-by: Rahul Lakkireddy
---
v2:
- No changes.
drivers/net/cxgbe/cxgbe_flow.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/net/cxgbe/cxgbe_flow.c b/drivers
1 - 100 of 479 matches
Mail list logo
