Acked-by: Rami Rosen
Acked-by: Rami Rosen
Anatoly Burakov :
> The word "syncrhonous" appears twice. Fix it.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Anatoly Burakov
> ---
>
Reviewed-by: Rami Rosen
Acked-by: Rami Rosen
via
merge, it will be better.
Other than that,
Acked-by: Rami Rosen
>
>
hint.
> >
> > Signed-off-by: Kevin Traynor
> > ---
Acked-by: Anatoly Burakov
>
Reviewd-by: Rami Rosen
Acked-by: Rami Rosen
Acked-by: Rami Rosen
sta...@dpdk.org
Signed-off-by: Wenzhuo Lu
---
Reviewed-by: Rami Rosen
On 4/10/2019 7:20 AM, Jie Pan wrote:
> The type for MAC address should be unsigned.
>
> Fixes: 1cfe212ed17a ("kni: support MAC address change")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jie Pan
Acked-by: Ferruh Yigit
Reviewed-by: Rami Rosen
Acked-by: Rami Rosen
Acked-by: Rami Rosen
/+bug/1723127
and more.
Regards,
Rami Rosen
uot;)
> Fixes: caf05a1b86 ("app/testpmd: new command to dump log types")
>
> Signed-off-by: Agalya Babu RadhaKrishnan <
> agalyax.babu.radhakrish...@intel.com>
> ---
>
> Thanks for this work!
Reviewed-by: Rami Rosen
worth to add such a section
also
for these nics ?
Other than that,
Acked-by: Rami Rosen
t/ice: support promiscuous mode")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Wang Ying A
> ---
>
Reviewed-by: Rami Rosen
>Using a local (pointer) variable for dev->data->dev_conf.rxmode.offloads
>would make the code more readable and lines shorter.
+1
o the MAINTAINERS file. Though this may seem
obvious, it is not mentioned in DPDK documentation.
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
V3 changes:
* Fix a typo.
V2 changes:
* Fix according to feedback from Fiona Trahe and Akhil Goyal.
doc/guides/contributing/patches.rst | 8 ++
o the MAINTAINERS file. Though this may seem
obvious, it is not mentioned in DPDK documentation.
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
V2 changes:
* Fix according to feedback from Fiona Trahe and Akhil Goyal.
doc/guides/contributing/patches.rst | 8
1 file changed, 8 inser
it will come back)
Link was not work also for me, but now is started working all if a
sudden...:)
Regards,
Rami Rosen
dd check for port count")
> Coverity issue: 337682
>
> Signed-off-by: David Hunt
> ---
>
Acked-by: Rami Rosen
Stephen Hemminger :
> Minor spelling errors found with aspell.
>
> Signed-off-by: Stephen Hemminger
> --
>
Acked-by: Rami Rosen
bbdev.
Regards,
Rami Rosen
Hi Fiona,
>[Fiona] Good idea to add this patch. However despite the name crypto is
actual broader so maybe
>"If you add a new crypto or compression PMD "
Thanks for this feedback, I will fix it in V2 of the patch.
Regards,
Rami Rosen
Fix unchecked return value for fcntl.
Coverity issue: 277210
Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
Cc: sta...@dpdk.org
Signed-off-by: Chenbo Xia
---
Acked-by: Rami Rosen
Fix unchecked return value issue for rte_eth_dev_configure.
Coverity issue: 195021
Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration")
Cc: sta...@dpdk.org
Signed-off-by: Chenbo Xia
---
Acked-by:
d build with CONFIG_RTE_KNI_KMOD_ETHTOOL=y
after applying the patch, build was done against the bleeding edge of
net-next of today (kernel 5.1-rc4).
Build of the kni kernel module completed successfully.
Reviewed-by: Rami Rosen
.
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/contributing/patches.rst | 4
1 file changed, 4 insertions(+)
diff --git a/doc/guides/contributing/patches.rst
b/doc/guides/contributing/patches.rst
index d8404e623..4dde8e724 100644
--- a/doc/guides/contributing/patches.rst
Acked-By: Rami Rosen
Acked-by: Rami Rosen
Acked-By: Rami Rosen
In this occasion I noticed that there is a typo in the code that appears in
the patch;
it should be "Pointer to txq" instead of "Pointer to rxq":
I would consider resending and fixing it on this occasion:
> if (!txq || !txq->sw_ring) {
>
Acked-by: Rami Rosen
Acked-by: Rami Rosen
Acked-by: Rami Rosen
s 1500.
> +
> + Updated the KNI PMD driver to set the mbuf_size and mtu based on
> + th given mb-pool. This provide the ability to pass jumbo frames
> + if the bm-pool contains suitable buffers' size.
> +
>
Reviewd-by: Rami Rosen
This patch fixes a trivial typo in rte_ethdev.h.
retieve=>retrieve
Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
lib/librte_ethdev/rte_ethdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
This patch fixes a trivial info in proc info section.
informationi=>information.
Fixes: 8a37f37fc243 ("app/procinfo: add --show-port")
Signed-off-by: Rami Rosen
---
doc/guides/tools/proc_info.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc
On Fri, Mar 22, 2019 at 1:04 AM Stephen Hemminger <
step...@networkplumber.org> wrote:
> Log message should end with newline.
>
> Fixes: 4e32101f9b01 ("ring: support freeing")
> Signed-off-by: Stephen Hemminger
> ---
>
Reviewed-by: Rami Rosen
ude guard.
> Renamed the include guard in vhost.h to differentiate.
>
> Fixes: 6a84c37e3975 ("net/virtio-user: add vhost-user adapter layer")
> Cc: jianfeng@intel.com
> Signed-off-by: Andrius Sirvys
> ---
>
>
Acked-by: Rami Rosen
by: Reshma Pattan
+1
Checked when CONFIG_RTE_LIBRTE_PDUMP=n
with latest code from master, build completes succesfully
Reviewed-by: Rami Rosen
to
other PMDs, because of the bifurcated model.
When you launch the application, do you pass two pci ids (with 2 "-w" EAL
argument), or only one , or none ?
See:
https://doc.dpdk.org/guides-19.02/nics/mlx5.html
Regards,
Rami Rosen
בתאריך יום ג׳, 19 במרץ 2019, 15:07, מאת benli y
Hi Kothuri,
This nic is not supported by DPDK
(Actually no realtek network device is supported by DPDK).
For the list of nics supported by DPDK please look in:
https://doc.dpdk.org/guides/nics/index.html
Regards,
Rami Rosen
gt; Acked-by: Luca Boccassi
>
Reviewed-by: Rami Rosen
>
ed-off-by: Stephen Hemminger
> ---
> Reviewd-by: Rami Rosen
This patch fixes two typos in the coding style part of
DPDK contributing guide:
- The header entry should have .h file instead of .c file.
- The will->This will
Fixes: 44a6dface13b ("doc: describe how to add new components")
Signed-off-by: Rami Rosen
---
doc/guides
Hajkowski :
> From: Marcin Hajkowski
>
> Function rte_power_set_env will no longer return
> success on attempt to set env in initialized state.
>
> Signed-off-by: Marcin Hajkowski
> ---
>
For further patches, please remove the legal disclaimer at the bottom.
Reviewed-by: Rami Rosen
hen Hemminger
> ---
>
1. Actuaully in the patch itself it is:
+#define OCTEONTX_PMD net_octeon
Shouldn't it be "net_octeontx" as in the commit log ?
2. Typo in commit log: driverse->drivers
Reviewed-by: Rami Rosen
gt; > Signed-off-by: Thomas Monjalon
>
> Acked-by: Bruce Richardson
>
Reviewed-by: Rami Rosen
Original vlan offload code declared callbacks, but did not
> enable the feature offload bit
>
> Cc: sta...@dpdk.org
> Fixes: f7c2c2c8c558 ("net/atlantic: implement VLAN filters and offloads")
> Signed-off-by: Igor Russkikh
> ---
> Reviewed-by: Rami Rosen
>
>
This patch fixes rte_ethdev header file to use the correct method name,
namely to use rte_eth_dev_info_get() instead of
rte_eth_dev_infos_get().
Fixes: a4996bd89c42 ("ethdev: new Rx/Tx offloads API")
Fixes: 4f5701f28bd4 ("examples: fix RSS hash function configuration")
Signe
This patch fixes a typo in test-pmd/cmdline.c:
succcessfully->successfully
Two C's are good enough for success...
Signed-off-by: Rami Rosen
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline
> Make clear that spaces are only for alignments less than tab size.
>
> Signed-off-by: Kevin Traynor
>
Acked-by: Rami Rosen
> On 10-Mar-19 8:28 AM, Shahaf Shuler wrote:
> > As those should be replaced by rte_dev_dma_map and rte_dev_dma_unmap
> > APIs.
> >
> > Signed-off-by: Shahaf Shuler
> > --
>
Acked-by: Rami Rosen
Acked-by: Rami Rosen
>
> Thomas Monjalon wrote:
>Yes, but "git ls build*" is not empty because of buildtools/
>Could be "build" and "build-*".
+1
>
>
>
>
>
+1
>
> Could you categorize this related TM commands to a new group? As you know,
> the commands in "help config" almost over flow.
>
> Thanks
> Jingjing
>
>
Hi,
Added new net driver for Netcope nfb cards
Signed-off-by: Rastislav Cernay
Reviewed-by: Rami Rosen
---
v2: remove unnecessary cast
remove unnecessary zeroing
move declaration to not mix with code
restore skeleton example
v3: add release notes
add doc to doc index
add
+ "bpf-unload rx|tx (port) (queue)\n"
+ "Unload previously loaded eBPF program"
+ " for partciular RX/TX queue\n\n"
+
+ "port config (port_id) tx_metadata (value)\n"
+ "Set Tx metadata value per port.testpmd will add this value"
+ " to any Tx packet sent from this port\n\n"
Reviewed-by: Rami Rosen
Reviewed-by: Rami Rosen
>
Reviewed-by: Rami Rosen
>
Reviewed-by: Rami Rosen
>
>
This patch fixes a wrong link in gsg. The
Documentation/kernel-parameters.txt file from the kernel
source tree was moved quite a time ago to
Documentation/admin-guide/kernel-parameters.txt.
Fixes: 1ab07743b21b ("doc: getting started guide for linux")
Cc: sta...@dpdk.org
Signed-of
on, it should be "uses"
instead of "users".
Fixes: d0a87d9aa8de ("doc: update mlx5 guide on tunnel offloading")
Signed-off-by: Rami Rosen
---
doc/guides/nics/features.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/nics/features.rst b
Reviewed-by: Rami Rosen
Hi, Dekel,
It seems that the link to the patch in your post is broken.
Regards,
Rami Rosen
בתאריך יום ה׳, 28 בפבר׳ 2019, 12:04, מאת Dekel Peled :
> In current kernel implementation, the physical port name for representors
> is a numeric string (i.e. '0', '1',
Reviewed-by: Rami Rosen
Hi, Cernay,
> delete mode 100644 examples/skeleton/basicfwd.c
It seems that this patch deletes examples/skeleton/basicfwd.c,
(instead of patching it ?!), maybe by mistake.
Reviewed-by: Rami Rosen
Rami Rosen
On Tue, Feb 26, 2019 at 3:04 PM Rastislav Cernay wrote:
> From: Rastislav
Reviewed-by: Rami Rosen
On Tue, Feb 26, 2019 at 11:51 AM Raslan Darawsheh
wrote:
> The structure was not initialized.
>
> Fixes: c9aa56edec8e ("net/tap: access primary process queues from
> secondary")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Raslan Dara
("examples/ethtool: add user-space ethtool sample
application")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
examples/ethtool/lib/rte_ethtool.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/ethtool/lib/rte_ethtool.h
b/examples/ethtool/lib/rte_ethto
This patch removes the reference to rte.doc.mk in
DPDK programmers guide.
Fixes: ee801f6cc7b8 ("mk: clean dead doc rules")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/prog_guide/dev_kit_build_system.rst | 2 --
1 file changed, 2 deletions(-)
diff --git a/
Checked on Fedora 28
Reviewed-by: Rami Rosen
On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon
wrote:
> The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
> No need to call the DPDK flavor explictly.
>
> Signed-off-by: Thomas Monjalon
> ---
> drivers/n
Checked on Fedora 28
Reviewed-by: Rami Rosen
On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon
wrote:
> The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
> No need to call the DPDK flavor explictly.
>
> Signed-off-by: Thomas Monjalon
> ---
> app/
Reviewed-by: Rami Rosen
On Mon, Feb 25, 2019 at 12:33 AM Thomas Monjalon
wrote:
> The placeholder for PCI address should be named DBDF
> which stands for Domain/Bus/Device/Function.
>
> Fixes: 33af337773ac ("ethdev: add common devargs parser")
> Cc: remy.hor...@intel.
Reviewed-by: Rami Rosen
בתאריך יום ה׳, 21 בפבר׳ 2019, 21:01, מאת Thomas Monjalon <
tho...@monjalon.net>:
> The log was printing the device name two times,
> first one being supposed to be the driver name.
> As we don't know yet the driver name, the log is simplified.
>
Reviewed-by: Rami Rosen
בתאריך יום ג׳, 19 בפבר׳ 2019, 22:38, מאת David Marchand <
david.march...@redhat.com>:
> pthread_getaffinity_np returns a >0 value when failing.
>
> This is mainly for the sake of correctness.
> The only case where it could fail is when passin
Hi,
+Shared memory packet interface (memif) PMD allows for DPDK and any other
client
+using memif (DPDK, VPP, libmemif) toc ommunicate using shared memory.
Memif is
+Linux only.s
Minor nit.
should be "to communicate"
And Also
Linux only.s => Linux only.
Reviewed-by: Rami Rosen
+1
Reviewed-by: Rami Rosen
On Thu, Feb 14, 2019 at 5:43 PM David Marchand
wrote:
> Having the standard stats and the rx burst stats on the same line gives a
> really long line and is not consistent with the rest.
>
> Before:
> RX-packets: 3542977TX-packets: 3542971
Reviewed-by: Rami Rosen
On Fri, Feb 15, 2019 at 12:29 PM Nikhil Rao wrote:
> The type of value parameter to rte_service_attr_get
> should be uint64_t *, since the attributes
> are of type uint64_t.
>
> Fixes: 4d55194d76a4 ("service: add attribute get function")
&
I believe this patch should be cc'ed/sent to sta...@dpdk.org
Reviewed-by: Rami Rosen
On Thu, Feb 14, 2019 at 5:43 PM David Marchand
wrote:
> Remove some leftover from a previous rework.
>
> Fixes: c4bcc342c8ee ("app/testpmd: refactor ieee1588 forwarding")
> Si
Acked-by: Rami Rosen
בתאריך יום ב׳, 18 בפבר׳ 2019, 14:30, מאת Ferruh Yigit <
ferruh.yi...@intel.com>:
> Remove KNI ethtool support.
>
> Signed-off-by: Ferruh Yigit
> ---
> RFC Patch: https://patches.dpdk.org/patch/49025/
> ---
> doc/guides/rel_notes/deprecation
This patch fixes a minor typo in testpmd guide.
Cc: sta...@dpdk.org
Fixes: 3c272b280a50 ("app/testpmd: add commands for RSS queue region")
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
Hi,
I would suggest to consider to add:
Fixes: 450f0791312c ("power: add traffic pattern aware power control")
Reviewed-By: Rami Rosen
+1
Reviewed-by: Rami Rosen
>
This trivial patch fixes a typo in rte_mbuf.h.
Fixes: f20b50b946da ("mbuf: optimize refcnt update")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
lib/librte_mbuf/rte_mbuf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/l
uot;
instead of "Command"; this patch fixes it.
Bugzilla ID: 205
Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
Signed-off-by: Rami Rosen
---
test/test/autotest_data.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/test/autotest_d
latest/intro/install/dpdk/
"VFIO is prefered to the UIO driver when using recent versions of DPDK. "
Regards,
Rami Rosen
what are the benefits of providing DPDK VFs,
is it mandatory in some use cases, and are there any advantage for using a
DPDK PF/DPDK VF combination over using Kernel VF?
Regards,
Rami Rosen
ere are setups when you cannot generated
PMD VFs.
Most PMD Ethernet Vendors *do* provide VF PMDs in the DPDK official repo;
but what are the benefits of providing DPDK VFs PMD? is it mandatory in
some use cases ?
Is there any advantage for using a DPDK PF/DPDK VF
combination over using Kernel VF?
Regards,
Rami Rosen
per kernel thread for example)
via a sysf entry or a kernel parameter will be accepted, though. You may try
Regards,
Rami Rosen
them and try:
taskset -pc 7 521
pid 521's current affinity list: 0-15
taskset: failed to set pid 521's affinity: Invalid argument
Regards,
Rami Rosen
guide/sect-red_hat_enterprise_linux-performance_tuning_guide-cpu-configuration_suggestions
So if there is no way to configure JVM to use specified kernel cores (and I
am afraid there is no such way),
I am not sure how this can be solved.
Regards,
Rami Rosen
On Wed, Jan 30, 2019 at 9:05 AM Shirle
, if you boot from a different partition.
Regards,
Rami Rosen
Was it with
-l CORELIST / --lcores COREMAP EAL parameter ?
Did you try also the isolcpus Linux kernel parameter in order to isolate
cores from the general Linux scheduler?
Regards,
Rami Rosen
On Tue, Jan 29, 2019 at 6:32 PM Shirley Avishour
wrote:
> Hi,
> We are trying to run a dpdk based
Hi all,
>My vote is definitely for merging.
+1 for this, this seems very reasonable
Regards,
Rami Rosen
On Wed, 23 Jan 2019 at 19:20, Ananyev, Konstantin
wrote:
>
>
>
> > -Original Message-
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > Sent:
This minor cleanup patch removes an unecessary forward
declaration of virtio_intr_enable() in net/virtio PMD.
Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
drivers/net/virtio/virtio_ethdev.c | 1 -
1 file changed,
e dependency in
sub-section 4.3.1 of the contributing guide ("Dependencies").
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/contributing/documentation.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/contributing/documentation.
;)
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/nics/ifc.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/nics/ifc.rst b/doc/guides/nics/ifc.rst
index bdf7b4e..317d9ff 100644
--- a/doc/guides/nics/ifc.rst
+++ b/doc/guides/nics/ifc.rst
@@ -19,7 +19,7 @@ C
in the testpmd guide.
v2: Change "loopback" to "loop" (following Bernard review)
Fixes: 3e2006d6186c ("app/testpmd: add loopback topology")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/run_app.rst | 4 +++-
1 file changed, 3 ins
guide.
Fixes: 3e2006d6186c ("app/testpmd: add loopback topology")
Cc: sta...@dpdk.org
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/run_app.rst | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/run_app.rst
b/doc/guides/test
This minor patch fixes a typo in examples/vhost/main.c.
Fixes: d19533e86f1d ("examples/vhost: copy old vhost example")
Signed-off-by: Rami Rosen
---
examples/vhost/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/vhost/main.c b/examples/vhost/ma
1 - 100 of 177 matches
Mail list logo
