RE: [EXT] Re: [PATCH v5 1/2] eal: add API for bus close

2022-01-31 Thread Rohit Raj
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, January 20, 2022 8:28 PM > To: Rohit Raj > Cc: Bruce Richardson ; Ray Kinsella > ; Dmitry Kozlyuk ; Narcisa Ana > Maria Vasile ; Dmitry Malloy > ; Pallavi Kadam ; > dev@dpdk.org; Nipun Gupta

RE: [EXT] Re: [PATCH v5 1/2] eal: add API for bus close

2022-01-20 Thread Rohit Raj
these hardware specific buses. So, to close these devices, we need a new API which can do this for us. That is why "rte_bus_close" is required. Regards, Rohit Raj > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, January 19, 2022 4:02 PM > To: Rohit R

[PATCH v5 2/2] bus/fslmc: support bus close API

2022-01-09 Thread rohit . raj
From: Rohit Raj This patch add support for closing the bus objects which were acquired In the bus probe. Some devices need to be cleaned while in both primary and secondary process and while some need to be cleaned only in case of primary process. The devices are closed as per the white list

[PATCH v5 1/2] eal: add API for bus close

2022-01-09 Thread rohit . raj
From: Rohit Raj As per the current code we have API for bus probe, but the bus close API is missing. This breaks the multi process scenarios as objects are not cleaned while terminating the secondary processes. This patch adds a new API rte_bus_close() for cleanup of bus objects which were

RE: [EXT] RE: [PATCH v2] examples/l3fwd: fix jumbo packet drop issue

2021-11-15 Thread Rohit Raj
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, November 12, 2021 3:11 PM > To: Rohit Raj ; dev@dpdk.org; Yigit, Ferruh > > Cc: Nipun Gupta ; Sachin Saxena > ; Vanshika Shukla > Subject: [EXT] RE: [PATCH v2] examples/l3fwd: fix jumbo packet drop

[PATCH v2] examples/l3fwd: fix jumbo packet drop issue

2021-11-11 Thread rohit . raj
From: Rohit Raj l3fwd uses mbufs with 2KB data size. If we enable jumbo packets, it is not able to store packets with size greater than 2KB, hence these packets are dropped. This patch fixes this issue by enabling scatter for jumbo packet, if it is supported by NIC. If scatter is not supported

Re: [dpdk-dev] [PATCH v1] examples/l3fwd: fix jumbo packet drop issue

2021-08-12 Thread Rohit Raj
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, August 11, 2021 5:01 PM > To: Rohit Raj > Cc: dev@dpdk.org; Nipun Gupta ; Hemant Agrawal > ; Sachin Saxena ; > Vanshika Shukla > Subject: Re: [dpdk-dev] [PATCH v1] examples/l3fwd: fix jumbo packet d

[dpdk-dev] [PATCH v1] examples/l3fwd: fix jumbo packet drop issue

2021-07-27 Thread rohit . raj
From: Rohit Raj l3fwd uses mbufs with 2KB data size. If we enable jumbo packets, it is not able to store packets with size greater than 2KB, hence these packets are dropped. This patch fixes this issue by enabling scatter for jumbo packet, if it is supported by NIC. If scatter is not supported

Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/3] eal: add API for bus close

2020-10-08 Thread Rohit Raj
Hi Ferruh, Sorry, I missed you comment last time. I will send an updated patch series after taking care of your suggested changes. Regards, Rohit Raj Software Engineer | NXP India Private Limited Sent from Outlook Mobile From: Ferruh Yigit Sent: Thursday

[dpdk-dev] [PATCH v4 3/5] bus/fslmc: support bus close API

2020-10-08 Thread rohit . raj
From: Rohit Raj This patch add support for closing the bus objects which were acquired In the bus probe. Some devices need to be cleaned while in both primary and secondary process and while some need to be cleaned only in case of primary process. The devices are closed as per the white list

[dpdk-dev] [PATCH v4 1/5] eal: add API for bus close

2020-10-08 Thread rohit . raj
From: Rohit Raj As per the current code we have API for bus probe, but the bus close API is missing. This breaks the multi process scenarios as objects are not cleaned while terminating the secondary processes. This patch adds a new API rte_bus_close() for cleanup of bus objects which were

[dpdk-dev] [PATCH v4 5/5] eal/windows: added support for rte_bus_close API

2020-10-08 Thread rohit . raj
From: Rohit Raj Added support for rte_bus_close API on windows to reset the devices on the bus to default state. Signed-off-by: Rohit Raj --- lib/librte_eal/windows/eal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows

[dpdk-dev] [PATCH v4 4/5] eal/freebsd: added support for rte_bus_close API

2020-10-08 Thread rohit . raj
From: Rohit Raj Added support for rte_bus_close API on freebsd to reset the devices on the bus to default state. Signed-off-by: Rohit Raj --- lib/librte_eal/freebsd/eal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c index

[dpdk-dev] [PATCH v4 2/5] examples/multi_process: cleanup bus objects while terminating app

2020-10-08 Thread rohit . raj
From: Rohit Raj Certain bus objects may need to be closed and re-acquired while terminating and rerunning the client application. Hence a signal handler is required to catch the termination of the App and hence closing the bus objects. This patch adds the missing signal handler in the client

[dpdk-dev] [PATCH v3 1/3] eal: add API for bus close

2020-08-25 Thread rohit . raj
From: Rohit Raj As per the current code we have API for bus probe, but the bus close API is missing. This breaks the multi process scenarios as objects are not cleaned while terminating the secondary processes. This patch adds a new API rte_bus_close() for cleanup of bus objects which were

[dpdk-dev] [PATCH v3 3/3] bus/fslmc: support bus close API

2020-08-25 Thread rohit . raj
From: Rohit Raj This patch add support for closing the bus objects which were acquired In the bus probe. Some devices need to be cleaned while in both primary and secondary process and while some need to be cleaned only in case of primary process. The devices are closed as per the white list

[dpdk-dev] [PATCH v3 2/3] examples/multi_process: cleanup bus objects while terminating app

2020-08-25 Thread rohit . raj
From: Rohit Raj Certain bus objects may need to be closed and re-acquired while terminating and rerunning the client application. Hence a signal handler is required to catch the termination of the App and hence closing the bus objects. This patch adds the missing signal handler in the client

[dpdk-dev] [PATCH v2 3/3] bus/fslmc: support bus close API

2020-08-24 Thread rohit . raj
From: Rohit Raj This patch add support for closing the bus objects which were acquired In the bus probe. Some devices need to be cleaned while in both primary and secondary process and while some need to be cleaned only in case of primary process. The devices are closed as per the white list

[dpdk-dev] [PATCH v2 2/3] examples/multi_process: cleanup bus objects while terminating app

2020-08-24 Thread rohit . raj
From: Rohit Raj Certain bus objects may need to be closed and re-acquired while terminating and rerunning the client application. Hence a signal handler is required to catch the termination of the App and hence closing the bus objects. This patch adds the missing signal handler in the client

[dpdk-dev] [PATCH v2 1/3] eal: add API for bus close

2020-08-24 Thread rohit . raj
From: Rohit Raj As per the current code we have API for bus probe, but the bus close API is missing. This breaks the multi process scenarios as objects are not cleaned while terminating the secondary processes. This patch adds a new API rte_bus_close() for cleanup of bus objects which were

Re: [dpdk-dev] [EXT] Re: [PATCH v1 1/3] eal: add API for bus close

2020-07-30 Thread Rohit Raj
Yes, I agree. I will rework and send this patch series again. Regards, Rohit Raj Software Engineer | NXP India Private Limited Email: rohit@nxp.com -Original Message- From: Stephen Hemminger Sent: Tuesday, July 28, 2020 10:54 PM To: Rohit Raj Cc: Ray Kinsella ; Neil Horman ; dev

[dpdk-dev] [PATCH v1 3/3] bus/fslmc: support bus close API

2020-07-28 Thread rohit . raj
From: Rohit Raj This patch add support for closing the bus objects which were acquired In the bus probe. Some devices need to be cleaned while in both primary and secondary process and while some need to be cleaned only in case of primary process. The devices are closed as per the white list

[dpdk-dev] [PATCH v1 1/3] eal: add API for bus close

2020-07-28 Thread rohit . raj
From: Rohit Raj As per the current code we have API for bus probe, but the bus close API is missing. This breaks the multi process scenarios as objects are not cleaned while terminating the secondary processes. This patch adds a new API rte_bus_close() for cleanup of bus objects which were

[dpdk-dev] [PATCH v1 2/3] examples/multi_process: cleanup bus objects while terminating app

2020-07-28 Thread rohit . raj
From: Rohit Raj Certain bus objects may need to be closed and re-acquired while terminating and rerunning the client application. Hence a signal handler is required to catch the termination of the App and hence closing the bus objects. This patch adds the missing signal handler in the client

[dpdk-dev] [PATCH v1] bus/fslmc: fix dpio close

2020-07-28 Thread rohit . raj
From: Rohit Raj The current state of the DPIO object should be checked before trying to close/disable the object. Fixes: 293c0ca94c36 ("bus/fslmc: support memory backed portals with QBMAN 5.0") Cc: sta...@dpdk.org Signed-off-by: Rohit Raj --- drivers/bus/fslmc/portal/dpaa2_hw_