Re: [PATCH] net/dpaa2: change threshold value

2023-05-15 Thread Sachin Saxena (OSS)
On 5/8/2023 4:11 PM, Tianli Lai wrote: Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button this threshold value can be changed with function argument nb_rx_desc. Signed-off-by:

Re: [PATCH] net/dpaa2: set check sum good flags

2023-05-09 Thread Sachin Saxena (OSS)
On 5/8/2023 4:27 PM, Tianli Lai wrote: Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button set check sum good flags when dpaa2 hardware set check result. Signed-off-by: Tianli

Re: [PATCH] net/dpaa2: set check sum good flags

2023-05-09 Thread Sachin Saxena (OSS)
On 5/8/2023 4:27 PM, Tianli Lai wrote: Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button set check sum good flags when dpaa2 hardware set check result. Signed-off-by: Tianli

[v2] [RFC] dpaa2: replace system("echo ...") with file i/o

2023-05-02 Thread Sachin Saxena (OSS)
From: Stephen Hemminger Using system() is a bad idea in driver code because it introduces a number of potential security issues. The codeql analysis tool flags this a potential security issue. Instead just use normal stdio to do the same thing. Compile test only, do not have this hardware

Re: Dpaa2 driver using system("echo...")

2023-04-28 Thread Sachin Saxena (OSS)
On 4/10/2023 9:51 PM, Stephen Hemminger wrote: When the CodeQl (https://codeql.github.com/) is run against DPDK, one of the issues it reports is the unsafe usage of system() in code. I reported and fixed one of these issues in the dpaa2 driver https://patchwork.dpdk.org/project/dpdk/patch/202206

Re: [PATCH v3 16/16] enable lock check

2023-04-10 Thread Sachin Saxena (OSS)
On 4/4/2023 6:18 PM, David Marchand wrote: Now that a lot of components can be compiled with the lock checks, invert the logic and opt out for components not ready yet: - drivers/bus/dpaa, - drivers/common/cnxk, - drivers/common/mlx5, - drivers/event/cnxk, - drivers/net/bnx2x, - drivers/net/bnxt,

Re: [PATCH v11 1/5] net/enetfec: introduce NXP ENETFEC driver

2023-03-23 Thread Sachin Saxena (OSS)
On 3/23/2023 4:37 PM, Ferruh Yigit wrote: On 3/23/2023 6:00 AM, Sachin Saxena (OSS) wrote: On 3/21/2023 11:33 PM, Ferruh Yigit wrote: On 11/15/2021 7:19 AM, Apeksha Gupta wrote: +ENETFEC +--- + +This section provides an overview of the NXP ENETFEC and how it is +integrated into the DPDK

Re: [PATCH v11 1/5] net/enetfec: introduce NXP ENETFEC driver

2023-03-22 Thread Sachin Saxena (OSS)
On 3/21/2023 11:33 PM, Ferruh Yigit wrote: On 11/15/2021 7:19 AM, Apeksha Gupta wrote: +ENETFEC +--- + +This section provides an overview of the NXP ENETFEC and how it is +integrated into the DPDK. Driver is taken as **experimental** as driver +depends on a Linux kernel module 'enetfec-uio',

Re: [PATCH 07/33] doc: update enetfec guide

2023-03-22 Thread Sachin Saxena (OSS)
On 3/22/2023 5:29 AM, Ferruh Yigit wrote: - Move "Supported ENETFEC SoCs" section up Signed-off-by: Ferruh Yigit --- doc/guides/nics/enetfec.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/guides/nics/enetfec.rst b/doc/guides/nics/enetfec.rst index 38

Re: [PATCH 06/33] doc: update enetc guide

2023-03-22 Thread Sachin Saxena (OSS)
On 3/22/2023 5:29 AM, Ferruh Yigit wrote: - Reduce section indentation, 'ENETC' was single top level section - Move "Supported ENETC SoCs" section up Signed-off-by: Ferruh Yigit --- doc/guides/nics/enetc.rst | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) d

Re: [PATCH 04/33] doc: update dpaa guide

2023-03-22 Thread Sachin Saxena (OSS)
On 3/22/2023 5:29 AM, Ferruh Yigit wrote: - Renamed "Pre-Installation Configuration" section to "Configuration" Signed-off-by: Ferruh Yigit --- doc/guides/nics/dpaa.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/dpaa.rst b/doc/guides/nics/dpaa.rs

Re: [PATCH 05/12] net/enetfec: fix build with GCC 12

2022-06-14 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 6/10/2022 6:38 PM, David Marchand wrote: On Wed, May 18, 2022 at 12:17 PM David Marchand wrote: GCC 12 raises the following warning: ../drivers/net/enetfec/enet_ethdev.c: In function ‘enetfec_rx_queue_setup’: ../drivers/net/enetfec/enet_ethdev.c:473:9: err

Re: [PATCH 05/12] net/enetfec: fix build with GCC 12

2022-06-12 Thread Sachin Saxena (OSS)
Hello David, I understood and agree with your suggestion. We are using GCC 11.3 where we were not seeing this warning. We will fix this on priority and submit the patch asap. regards, Sachin Saxena On 6/10/2022 6:38 PM, David Marchand wrote: On Wed, May 18, 2022 at 12:17 PM David Marchand w

Re: [dpdk-dev] [PATCH 4/4] drivers/net/enetfec: add enqueue and dequeue support

2021-07-05 Thread Sachin Saxena (OSS)
On 30-Apr-21 10:04 AM, Apeksha Gupta wrote: This patch supported checksum offloads and add burst enqueue and dequeue operations to the enetfec PMD. Loopback mode is added, compile time flag 'ENETFEC_LOOPBACK' is used to enable this feature. By default loopback mode is disabled. Basic features a

Re: [dpdk-dev] [PATCH 3/4] drivers/net/enetfec: queue configuration

2021-07-03 Thread Sachin Saxena (OSS)
On 30-Apr-21 10:04 AM, Apeksha Gupta wrote: This patch added RX/TX queue configuration setup operations. added -> adds On packet Rx the respective BD Ring status bit is set which is then Suggestion:  Rx -> reception used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by:

Re: [dpdk-dev] [PATCH 2/4] drivers/net/enetfec: UIO support added

2021-07-03 Thread Sachin Saxena (OSS)
On 30-Apr-21 10:04 AM, Apeksha Gupta wrote: Implemented the fec-uio driver in kernel. enetfec PMD uses UIO interface to interact with kernel for PHY initialisation enetfec PMD uses UIO interface to interact with "fec-uio" driver implemented in kernel for PHY initialization... and for mapp

Re: [dpdk-dev] [PATCH 1/4] drivers/net/enetfec: Introduce NXP ENETFEC driver

2021-07-03 Thread Sachin Saxena (OSS)
On 30-Apr-21 10:04 AM, Apeksha Gupta wrote: ENET fec (Fast Ethernet Controller) is a network poll mode driver for NXP SoC imx8mmevk. Either use imx8mmevk  or  "i.MX 8M Mini"at all places ENET fec-> enetfec,   please change it at all places. This patch add skeleton for enetfec driver with pr

Re: [dpdk-dev] [PATCH 0/4] drivers/net: add NXP ENETFEC driver

2021-07-03 Thread Sachin Saxena (OSS)
On 30-Apr-21 10:04 AM, Apeksha Gupta wrote: This patch series introduce the enetfec ethernet driver, enetfec ethernet driver -> enetfec driver ENET fec (Fast Ethernet Controller) is a network poll mode driver for ENET fec ->enetfec Also, please use "enetfec" consistently at all places. the

Re: [dpdk-dev] [PATCH v3] net/dpaa2: fix build error about timesync functions

2020-10-09 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 08-Oct-20 6:42 PM, Ferruh Yigit wrote: On 10/8/2020 3:24 AM, Sachin Saxena (OSS) wrote: [please don't top post, I moved reply to down] On 06-Oct-20 10:46 PM, Ferruh Yigit wrote: From: Chenxu Di Some timesync related source files are built only

[dpdk-dev] [PATCH v1] doc: fix dpaa2 guide

2020-10-07 Thread Sachin Saxena (OSS)
From: Sachin Saxena The diagram to show dpaa2 drivers brief was missing in dpaa2.html file. fix a typo in encoding for a literal block to make it visible in generated doc file. Fixes: 846a8305f277 ("add DPAA2 NIC details") Cc: sta...@dpdk.org Signed-off-by: Sachin Saxena --- doc/guides/nics/

Re: [dpdk-dev] [PATCH v3] net/dpaa2: fix build error about timesync functions

2020-10-07 Thread Sachin Saxena (OSS)
Following change should also be handled as suggested by Ferruh in earlier. diff --git a/drivers/net/dpaa2/dpaa2_ptp.c b/drivers/net/dpaa2/dpaa2_ptp.c index 9f755e84bf..0e44d4c6bf 100644 --- a/drivers/net/dpaa2/dpaa2_ptp.c +++ b/drivers/net/dpaa2/dpaa2_ptp.c @@ -178,4 +178,6 @@ s

Re: [dpdk-dev] [PATCH v3 1/3] eal: add API for bus close

2020-09-28 Thread Sachin Saxena (OSS)
On 26-Aug-20 11:22 AM, rohit@nxp.com wrote: From: Rohit Raj As per the current code we have API for bus probe, but the bus close API is missing. This breaks the multi process scenarios as objects are not cleaned while terminating the secondary processes. This patch adds a new API rte_bu

[dpdk-dev] [PATCH v2] net/dpaa2: release port upon close

2020-09-28 Thread Sachin Saxena (OSS)
From: Sachin Saxena With removal of old close behavior, the private port resources must be released in the .dev_close callback. Freeing of port private resources is moved from the ".remove(device)" to the ".dev_close(port)" operation Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/dpaa2_eth

Re: [dpdk-dev] [PATCH v2 19/25] drivers/net: check process type in close operation

2020-09-28 Thread Sachin Saxena (OSS)
For dpaa, dpaa2, enetc and pfe Reviewed-by: Sachin Saxena On 28-Sep-20 5:12 AM, Thomas Monjalon wrote: The secondary processes are not allowed to release shared resources. Only process-private ressources should be freed in a secondary process. Most of the time, there is no process-private resso

Re: [dpdk-dev] [PATCH v2 18/25] drivers/net: accept removing device without any port

2020-09-28 Thread Sachin Saxena (OSS)
For "net/pfe" Reviewed-by: Sachin Saxena On 28-Sep-20 5:12 AM, Thomas Monjalon wrote: The ports can be closed (i.e. completely released) before removing the whole device. Such case was wrongly considered an error by some drivers. If the device supports only one port, there is nothing much to f

Re: [dpdk-dev] [PATCH v2 02/25] ethdev: allow drivers to return error on close

2020-09-28 Thread Sachin Saxena (OSS)
For dpaa, dpaa2, enetc and pfe. Reviewed-by: Sachin Saxena On 28-Sep-20 5:12 AM, Thomas Monjalon wrote: The device operation .dev_close was returning void. This driver interface is changed to return an int. Note that the API rte_eth_dev_close() is still returning void, although a deprecation

[dpdk-dev] [PATCH v1 4/4] net/enetc: release port upon close

2020-09-28 Thread Sachin Saxena (OSS)
From: Sachin Saxena With removal of old close behavior, the private port resources must be released in the .dev_close callback. Freeing of port private resources is moved from the ".remove(device)" to the ".dev_close(port)" operation Signed-off-by: Sachin Saxena --- drivers/net/enetc/enetc_eth

[dpdk-dev] [PATCH v1 2/4] net/dpaa2: release port upon close

2020-09-28 Thread Sachin Saxena (OSS)
From: Sachin Saxena With removal of old close behavior, the private port resources must be released in the .dev_close callback. Freeing of port private resources is moved from the ".remove(device)" to the ".dev_close(port)" operation Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/dpaa2_eth

[dpdk-dev] [PATCH v1 1/4] net/dpaa: release port upon close

2020-09-28 Thread Sachin Saxena (OSS)
From: Sachin Saxena With removal of old close behavior, the private port resources must be released in the .dev_close callback. Freeing of port private resources is moved from the ".remove(device)" to the ".dev_close(port)" operation Signed-off-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethde

[dpdk-dev] [PATCH v1 0/4] Align device close operation with new behavior

2020-09-28 Thread Sachin Saxena (OSS)
From: Sachin Saxena - patches are rebased on v2 series: http://patches.dpdk.org/project/dpdk/list/?series=12533 Sachin Saxena (4): net/dpaa: release port upon close net/dpaa2: release port upon close net/pfe: release port upon close net/enetc: release port upon close drivers/net/dp

[dpdk-dev] [PATCH v1 3/4] net/pfe: release port upon close

2020-09-28 Thread Sachin Saxena (OSS)
From: Sachin Saxena With removal of old close behavior, the private port resources must be released in the .dev_close callback. Freeing of port private resources is moved from the ".remove(device)" to the ".dev_close(port)" operation Signed-off-by: Sachin Saxena --- drivers/net/pfe/pfe_ethdev.

[dpdk-dev] [PATCH v3 3/6] net/dpaa2: fix check for key size

2020-09-23 Thread Sachin Saxena (OSS)
From: Apeksha Gupta DPAA2 has support for raw flow classification, which can be used for any protocol rules. This change fixes flow key pattern length match boundary condition with spec length. Fixes: 3f881f8d6eb0 ("net/dpaa2: support raw flow classification") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH v3 5/6] net/dpaa: send error packets to application

2020-09-23 Thread Sachin Saxena (OSS)
From: Nipun Gupta Send error packets to main queue (rx) to make application enable to receive error packets. Earlier all packets with L3/L4 checksum errors were getting dropped by the hardware. Signed-off-by: Rohit Raj Signed-off-by: Nipun Gupta --- drivers/net/dpaa/dpaa_ethdev.c | 10 ---

[dpdk-dev] [PATCH v3 4/6] bus/dpaa: enables RX/TX error queues

2020-09-23 Thread Sachin Saxena (OSS)
From: Sachin Saxena Enables a debugging queue to fetch error (Rx/Tx) packets to user space. Earlier all packets with L3/L4 checksum errors were getting dropped by the hardware. Setting CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER=y is required which enables following enhancements. 1) Enable TX/RX error q

[dpdk-dev] [PATCH v3 6/6] bus/dpaa: enhance link status support

2020-09-23 Thread Sachin Saxena (OSS)
From: Rohit Raj This patch adds support to get/set link speed, duplex and autoneg mode status from/to PHY. Enahnce device capabilities to advertise all supported link speeds according to mac type. Also enables fallback support for get link status api where kernel support is missing. Signed-off-

[dpdk-dev] [PATCH v3 2/6] bus/fslmc: run secondary debug app without blacklist devices

2020-09-23 Thread Sachin Saxena (OSS)
From: Rohit Raj dpaa2 hw impose limits on some HW access devices like DPMCP(Management control Port) and DPIO (HW portal). This causes issue in their shared usages in case of multi-process applications. It can overcome by using whitelist/blacklist in primary and secondary applications. However it

[dpdk-dev] [PATCH v3 1/6] bus/fslmc: fix atomic queues on nxp lx2 platform

2020-09-23 Thread Sachin Saxena (OSS)
From: Youri Querry Traffic was stalling after few packet while running l2fwd-event in atomic mode on LX2 platform. It was due to wrong dca setting while enqueuing packets to EQCR. This patch fixes the issue by writing correct dca setting. Fixes: 1b49352f41be ("bus/fslmc: rename portal pi index t

[dpdk-dev] [PATCH v3 0/6] enhancement and fixes for nxp dpaax platform

2020-09-23 Thread Sachin Saxena (OSS)
From: Sachin Saxena - V2: Removed checks warnings reported by checkpatch - V3: handled review comments Apeksha Gupta (1): net/dpaa2: fix check for key size Nipun Gupta (1): net/dpaa: send error packets to application Rohit Raj (2): bus/fslmc: run secondary debug app without blacklist d

Re: [dpdk-dev] [PATCH v1] maintainers: update for nxp bus, dpaa, dpaa2 and enetc

2020-09-23 Thread Sachin Saxena (OSS)
On 24-Sep-20 5:29 AM, Thomas Monjalon wrote: 14/09/2020 16:06, Sachin Saxena (OSS): From: Sachin Saxena Updated email of maintainer. Signed-off-by: Sachin Saxena --- NXP buses M: Hemant Agrawal -M: Sachin Saxena +M: Sachin Saxena Tab is replaced with a space, and applied

[dpdk-dev] [PATCH v2] net/pfe: fix misuse of if_index

2020-09-14 Thread Sachin Saxena (OSS)
From: Sachin Saxena Pfe pmd has no need to bound host interface for which we require if_index field. Setting it to 0 as unused. Signed-off-by: Sachin Saxena --- drivers/net/pfe/pfe_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe

[dpdk-dev] [PATCH v2] net/dpaa2: fix misuse of if_index

2020-09-14 Thread Sachin Saxena (OSS)
From: Sachin Saxena Dpaa2 pmd has no need to bound host interface for which we require if_index field. Setting it to 0 as unused. Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/ne

[dpdk-dev] [PATCH v1] maintainers: update for nxp bus, dpaa, dpaa2 and enetc

2020-09-14 Thread Sachin Saxena (OSS)
From: Sachin Saxena Updated email of maintainer. Signed-off-by: Sachin Saxena --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3b16d7a4b..b257427e3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -506,7 +506,7 @@ F: drive

[dpdk-dev] [PATCH v1 2/2] net/pfe: fix misuse of if_index

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena Pfe pmd has no need to bound host interface for which we require if_index field. Setting it to 0 as unused. Signed-off-by: Sachin Saxena --- drivers/net/pfe/pfe_ethdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/pfe/pfe_ethdev.c b/dr

[dpdk-dev] [PATCH v1 1/2] net/dpaa2: fix misuse of if_index

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena Dpaa2 pmd has no need to bound host interface for which we require if_index field. Setting it to 0 as unused. Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev

[dpdk-dev] [PATCH v2 8/8] net/dpaa: send error packets to application

2020-09-11 Thread Sachin Saxena (OSS)
From: Nipun Gupta Send error packets to main queue (rx) to make application enable to receive error packets. Signed-off-by: Rohit Raj Signed-off-by: Nipun Gupta --- drivers/net/dpaa/dpaa_ethdev.c | 10 -- drivers/net/dpaa/dpaa_rxtx.c | 17 + drivers/net/dpaa/dpaa_rxt

[dpdk-dev] [PATCH v2 4/8] bus/dpaa: RX/TX error queues

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER=y 1) Enable TX/RX error queues to check the errors. 2) Display error frame information(payload, status, paresr result). Signed-off-by: Jun Yang Signed-off-by: Rohit Raj Signed-off-by: Sachin Saxena --- drivers/bus/dpaa/base/fman/fman_h

[dpdk-dev] [PATCH v2 7/8] bus/dpaa: send error packets to application

2020-09-11 Thread Sachin Saxena (OSS)
From: Nipun Gupta Api fman_if_set_err_fqid should be marked as internal. Signed-off-by: Sachin Saxena Signed-off-by: Rohit Raj Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/include/fsl_fman.h | 1 + drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 + 2 files changed, 2 insertions(+) di

[dpdk-dev] [PATCH v2 6/8] bus/dpaa: enhance link status support

2020-09-11 Thread Sachin Saxena (OSS)
From: Rohit Raj This patch adds support to get/set link speed, duplex and autoneg mode status from/to PHY. Enahnce device capabilities to advertise all supported link speeds according to mac type. Also enables fallback support for get link status api where kernel support is missing. Signed-off-

[dpdk-dev] [PATCH v2 5/8] bus/fslmc: fix usage of dpio blocklist flag

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena DPIO object shouldn't be reserved if it is mentioned in blocklist. Exiting code is not setting the correct flag when such object is found. Fixes: c904a212646a ("bus/fslmc: run secondary debug app without blocklist devices") Signed-off-by: Sachin Saxena --- drivers/bus/fsl

[dpdk-dev] [PATCH v2 1/8] bus/fslmc: fix atomic queues on nxp lx2 platform

2020-09-11 Thread Sachin Saxena (OSS)
From: Youri Querry Traffic was stalling after few packet while running l2fwd-event in atomic mode on LX2 platform. It was due to wrong dca setting while enqueuing packets to EQCR. This patch fixes the issue by writing correct dca setting. Fixes: 1b49352f41be ("bus/fslmc: rename portal pi index t

[dpdk-dev] [PATCH v2 3/8] net/dpaa2: fix check for key size

2020-09-11 Thread Sachin Saxena (OSS)
From: Apeksha Gupta DPAA2 has support for raw flow classification, which can be used for any protocol rules. This change fixes flow key pattern length match. Fixes: 3f881f8d6eb0 ("net/dpaa2: support raw flow classification") Signed-off-by: Apeksha Gupta --- drivers/net/dpaa2/dpaa2_flow.c | 2

[dpdk-dev] [PATCH v2 0/8] enhancement and fixes for nxp dpaax platform

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena - V2: Removed checks warnings reported by checkpatch Apeksha Gupta (1): net/dpaa2: fix check for key size Nipun Gupta (2): bus/dpaa: send error packets to application net/dpaa: send error packets to application Rohit Raj (2): bus/fslmc: run secondary debug app with

[dpdk-dev] [PATCH v2 2/8] bus/fslmc: run secondary debug app without blocklist devices

2020-09-11 Thread Sachin Saxena (OSS)
From: Rohit Raj dpaa2 hw impose limits on some HW access devices like DPMCP(Mnagement control Port) and DPIO (HW portal). This causes issue in their usages in shared uses in case of multi-process applications. It can overcome by using allowlist/blocklist in primary and secondary applications. How

[dpdk-dev] [PATCH v1] mempool: dump socket id attribute

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena Enhance the dump function to also print socket_id attribute passed at creation time. Signed-off-by: Sachin Saxena --- lib/librte_mempool/rte_mempool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c ind

[dpdk-dev] [PATCH v1 7/8] bus/dpaa: send error packets to application

2020-09-11 Thread Sachin Saxena (OSS)
From: Nipun Gupta Api fman_if_set_err_fqid should be marked as internal. Signed-off-by: Sachin Saxena Signed-off-by: Rohit Raj Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/include/fsl_fman.h | 1 + drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 + 2 files changed, 2 insertions(+) di

[dpdk-dev] [PATCH v1 5/8] bus/fslmc: fix usage of dpio blocklist flag

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena DPIO object shouldn't be reserved if it is mentioned in blocklist. Exiting code is not setting the correct flag when such object is found. Fixes: c904a212646a ("bus/fslmc: run secondary debug app without blocklist devices") Signed-off-by: Sachin Saxena --- drivers/bus/fsl

[dpdk-dev] [PATCH v1 8/8] net/dpaa: send error packets to application

2020-09-11 Thread Sachin Saxena (OSS)
From: Nipun Gupta Send error packets to main queue (rx) to make application enable to receive error packets. Signed-off-by: Rohit Raj Signed-off-by: Nipun Gupta --- drivers/net/dpaa/dpaa_ethdev.c | 10 -- drivers/net/dpaa/dpaa_rxtx.c | 17 + drivers/net/dpaa/dpaa_rxt

[dpdk-dev] [PATCH v1 6/8] bus/dpaa: enhance link status support

2020-09-11 Thread Sachin Saxena (OSS)
From: Rohit Raj This patch adds support to get/set link speed, duplex and autoneg mode status from/to PHY. Enahnce device capabilities to advertise all supported link speeds according to mac type. Also enables fallback support for get link status api where kernel support is mssing. Signed-off-b

[dpdk-dev] [PATCH v1 2/8] bus/fslmc: run secondary debug app without blocklist devices

2020-09-11 Thread Sachin Saxena (OSS)
From: Rohit Raj dpaa2 hw impose limits on some HW access devices like DPMCP(Mnagement control Port) and DPIO (HW portal). This causes issue in their usages in shared uses in case of multi-process applications. It can overcome by using allowlist/blocklist in primary and secondary applications. How

[dpdk-dev] [PATCH v1 1/8] bus/fslmc: fix atomic queues on nxp lx2 platform

2020-09-11 Thread Sachin Saxena (OSS)
From: Youri Querry Traffic was stalling after few packet while running l2fwd-event in atomic mode on LX2 platform. It was due to wrong dca setting while enqueuing packets to EQCR. This patch fixes the issue by writing correct dca setting. Fixes: 1b49352f41be ("bus/fslmc: rename portal pi index t

[dpdk-dev] [PATCH v1 4/8] bus/dpaa: RX/TX error queues

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER=y 1) Enable TX/RX error queues to check the errors. 2) Display error frame information(payload, status, paresr result). Signed-off-by: Jun Yang Signed-off-by: Rohit Raj Signed-off-by: Sachin Saxena --- drivers/bus/dpaa/base/fman/fman_h

[dpdk-dev] [PATCH v1 3/8] net/dpaa2: fix check for key size

2020-09-11 Thread Sachin Saxena (OSS)
From: Apeksha Gupta DPAA2 has support for raw flow classification, which can be used for any protocol rules. This change fixes flow key pattern length match. Fixes: 3f881f8d6eb0 ("net/dpaa2: support raw flow classification") Signed-off-by: Apeksha Gupta --- drivers/net/dpaa2/dpaa2_flow.c | 2

[dpdk-dev] [PATCH v1 0/8] enhancements and fixes for nxp dpaax platform

2020-09-11 Thread Sachin Saxena (OSS)
From: Sachin Saxena Apeksha Gupta (1): net/dpaa2: fix check for key size Nipun Gupta (2): bus/dpaa: send error packets to application net/dpaa: send error packets to application Rohit Raj (2): bus/fslmc: run secondary debug app without blocklist devices bus/dpaa: enhance link status

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: remove underscore prefix from internal API

2020-09-09 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 09-Sep-20 6:31 PM, Ferruh Yigit wrote: '_rte_eth_dev_callback_process()' & '_rte_eth_dev_reset()' internal APIs has unconventional underscore ('_') prefix. Although this is not documented most probably this is to mark them as internal. Since we have '__rte_internal' f

Re: [dpdk-dev] [PATCH v4 2/7] ethdev: move inline device operations

2020-09-09 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 09-Sep-20 6:31 PM, Ferruh Yigit wrote: This patch is a preparation to hide the 'struct eth_dev_ops' from applications by moving some device operations from 'struct eth_dev_ops' to 'struct rte_eth_dev'. Mentioned ethdev APIs are in the data path and implemented as in

Re: [dpdk-dev] [PATCH] bus/dpaa: fix fd check before close

2020-08-26 Thread Sachin Saxena (OSS)
Thanks Yunjian for the fix. Acked-by: Sachin Saxena On 26-Aug-20 5:24 PM, wangyunjian wrote: From: Yunjian Wang The fd is possibly a negative value while it is passed as an argument to function "close". Fix the check to the fd. Fixes: b9c94167904f ("bus/dpaa: decouple FQ portal alloc and in

Re: [dpdk-dev] [PATCH v1] bus/fslmc: fix dpio close

2020-08-06 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 28-Jul-20 9:54 PM, rohit@nxp.com wrote: From: Rohit Raj The current state of the DPIO object should be checked before trying to close/disable the object. Fixes: 293c0ca94c36 ("bus/fslmc: support memory backed portals with QBMAN 5.0") Cc: sta...@dpdk.org Signed

Re: [dpdk-dev] [PATCH v1 3/3] bus/fslmc: support bus close API

2020-08-05 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 28-Jul-20 10:12 PM, rohit@nxp.com wrote: From: Rohit Raj This patch add support for closing the bus objects which were acquired In the bus probe. Some devices need to be cleaned while in both primary and secondary process and while some need to be cleaned only

Re: [dpdk-dev] [PATCH v1 2/3] examples/multi_process: cleanup bus objects while terminating app

2020-08-05 Thread Sachin Saxena (OSS)
On 28-Jul-20 10:12 PM, rohit@nxp.com wrote: From: Rohit Raj Certain bus objects may need to be closed and re-acquired while terminating and rerunning the client application. Hence a signal handler is required to catch the termination of the App and hence closing the bus objects. This pa

[dpdk-dev] [PATCH] net/dpaa: announce extended definition of port_id in API 'rte_pmd_dpaa_set_tx_loopback'

2020-07-14 Thread Sachin Saxena (OSS)
From: Sachin Saxena Signed-off-by: Sachin Saxena --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index a58a17946..a0715e587 100644 --- a/doc/guides/rel_notes/deprecation.

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-22 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 22-Jun-20 1:39 PM, Wei Hu (Xavier) wrote: Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver does not support certain VLAN hardware off

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: fix data room size verification in Rx queue setup

2020-06-22 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 22-Jun-20 1:38 PM, Wei Hu (Xavier) wrote: In the rte_eth_rx_queue_setup API function, the local variable named mbp_buf_size, which is the data room size of the input parameter mp, is checked to guarantee that each memory chunck used for net device in the mbuf is bigge

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-21 Thread Sachin Saxena (OSS)
On 22-Jun-20 8:17 AM, Wei Hu (Xavier) wrote: Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver does not support certain VLAN hardware offloads and does not check

Re: [dpdk-dev] [PATCH 11/13] drivers/bus: use log register macro

2020-06-21 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 17-Jun-20 12:00 PM, jer...@marvell.com wrote: From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/bus/dpaa/dpaa_bus.c | 10 +- drivers/bus/fslmc/fslmc_bus.c

Re: [dpdk-dev] [PATCH 10/13] drivers/common: use log register macro

2020-06-21 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 17-Jun-20 12:00 PM, jer...@marvell.com wrote: From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/common/dpaax/dpaax_iova_table.c | 10 +-- drivers/common/iavf/iavf_impl.

Re: [dpdk-dev] [PATCH 06/13] drivers/mempool: use log register macro

2020-06-21 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 17-Jun-20 12:00 PM, jer...@marvell.com wrote: From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob --- drivers/mempool/dpaa/dpaa_mempool.c | 10 ++ drivers/mempool/dpaa2

Re: [dpdk-dev] [PATCH 01/13] eal/log: introduce log register macro

2020-06-21 Thread Sachin Saxena (OSS)
On 17-Jun-20 12:00 PM, jer...@marvell.com wrote: From: Jerin Jacob Introducing the RTE_LOG_REGISTER macro to avoid the code duplication in the log registration process. It is a wrapper macro for declaring the logtype, register the log and sets it's level in the constructor context. Signed-off