Re: [Bug 1030] rte_malloc() and rte_free() get stuck when used with signal handler

2022-06-13 Thread Sarosh Arif
Thank you for help, I'll do it this way. On Sat, Jun 11, 2022 at 9:25 PM Mattias Rönnblom wrote: > > On 2022-06-10 08:04, Sarosh Arif wrote: > > On Thu, Jun 9, 2022 at 8:26 PM Stephen Hemminger > > wrote: > >> > >> On Thu, 09 Jun 2022 12

Re: [Bug 1030] rte_malloc() and rte_free() get stuck when used with signal handler

2022-06-09 Thread Sarosh Arif
On Thu, Jun 9, 2022 at 8:26 PM Stephen Hemminger wrote: > > On Thu, 09 Jun 2022 12:47:43 + > bugzi...@dpdk.org wrote: > > > https://bugs.dpdk.org/show_bug.cgi?id=1030 > > > > Bug ID: 1030 > >Summary: rte_malloc() and rte_free() get stuck when used with > >

[dpdk-dev] [PATCH] examples/l2fwd: add promiscuous mode selection through command line option

2021-10-13 Thread Sarosh Arif
command line parameter. l3fwd has a similar option available. Signed-off-by: Sarosh Arif --- .../sample_app_ug/l2_forward_real_virtual.rst | 4 examples/l2fwd/main.c | 23 +-- 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/doc/guides

[dpdk-dev] [PATCH] mlx5: fix typing error

2021-06-08 Thread Sarosh Arif
change returing to returning. Signed-off-by: Sarosh Arif --- drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 2 +- drivers/net/mlx5/mlx5_rxtx_vec_neon.h| 2 +- drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5

[dpdk-dev] [v4 PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size

2021-02-11 Thread Sarosh Arif
next time. Signed-off-by: Sarosh Arif --- v2: pass string in sys.exit() to remove pylint warning v3: modify get_valid_page_sizes() v4: fix indentation --- usertools/dpdk-hugepages.py | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/usertools/dpdk-hugepages.py b

[dpdk-dev] [v2 PATCH] doc: replace testpmd with dpdk-testpmd in all commands

2021-02-10 Thread Sarosh Arif
replace testpmd with dpdk-testpmd in all commands because on compilation through meson, dpdk-testpmd is the default application name. Signed-off-by: Sarosh Arif --- v2: drop relative path replace testpmd with dpdk-testpmd in ixgbe.rst too --- doc/guides/nics/bnxt.rst| 8 doc

Re: [dpdk-dev] [PATCH] doc: replace testpmd with .//app/dpdk-testpmd in all commands

2021-02-10 Thread Sarosh Arif
Yes, I think we can drop the relative path. I'll make this change in the next version. On Wed, Feb 10, 2021 at 5:54 PM Ferruh Yigit wrote: > > On 2/10/2021 11:56 AM, Sarosh Arif wrote: > > replace testpmd with .//app/dpdk-testpmd in all commands > > because on compilat

[dpdk-dev] [PATCH] doc: replace testpmd with .//app/dpdk-testpmd in all commands

2021-02-10 Thread Sarosh Arif
replace testpmd with .//app/dpdk-testpmd in all commands because on compilation through meson, dpdk-testpmd is the default application name. Signed-off-by: Sarosh Arif --- doc/guides/nics/bnxt.rst| 8 doc/guides/nics/e1000em.rst | 2 +- doc/guides/nics/kni.rst | 4 ++-- doc

[dpdk-dev] [v3 PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size

2021-02-09 Thread Sarosh Arif
next time. Signed-off-by: Sarosh Arif --- v2: pass string in sys.exit() to remove pylint warning v3: modify get_valid_page_sizes() --- usertools/dpdk-hugepages.py | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/usertools/dpdk-hugepages.py b/usertools/dpdk

[dpdk-dev] [v3 PATCH] usertools: show an error message if unable to reserve requested hugepages

2021-01-08 Thread Sarosh Arif
an error message if the pages reserved are different from the requested pages. Signed-off-by: Sarosh Arif --- v2: use a global variable SHOW_HUGEPAGES to remove linter warnings v3: only print an error message if unable to reserve hugepages. --- usertools/dpdk-hugepages.py | 2 ++ 1 file changed

Re: [dpdk-dev] [v2 PATCH] usertools: show an error message if unable to reserve requested hugepages

2021-01-07 Thread Sarosh Arif
On Thu, Dec 17, 2020 at 11:19 PM Stephen Hemminger wrote: > > On Thu, 17 Dec 2020 16:16:16 +0500 > Sarosh Arif wrote: > > > +if get_hugepages(path) != pages: > > +print("Unable to reserve required pages. The pages reserved are:")

[dpdk-dev] [v2 PATCH] usertools: show an error message if unable to reserve requested hugepages

2020-12-17 Thread Sarosh Arif
displays an error message if the pages reserved are different from the requested pages and shows the actual pages reserved. Signed-off-by: Sarosh Arif --- v2: use a global variable SHOW_HUGEPAGES to remove linter warnings --- usertools/dpdk-hugepages.py | 11 ++- 1 file changed, 10 insertions

[dpdk-dev] [v2 PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size

2020-12-02 Thread Sarosh Arif
next time. Signed-off-by: Sarosh Arif --- v2: pass string in sys.exit() to remove pylint warning --- usertools/dpdk-hugepages.py | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/usertools/dpdk-hugepages.py b/usertools/dpdk-hugepages.py index 1be100ca3..09d35bf55

[dpdk-dev] [PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size

2020-11-30 Thread Sarosh Arif
next time. Signed-off-by: Sarosh Arif --- usertools/dpdk-hugepages.py | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/usertools/dpdk-hugepages.py b/usertools/dpdk-hugepages.py index 1be100ca3..f503ad377 100755 --- a/usertools/dpdk-hugepages.py +++ b/usertools

[dpdk-dev] [PATCH] usertools: show an error message if unable to reserve requested hugepages

2020-11-30 Thread Sarosh Arif
displays an error message if the pages reserved are different from the requested pages and shows the actual pages reserved. Signed-off-by: Sarosh Arif --- usertools/dpdk-hugepages.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-hugepages.py b/usertools/dpdk

[dpdk-dev] setting parameters in meson build system

2020-10-22 Thread Sarosh Arif
CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM=4 Can someone help me figure out how to enable/disable/change these using the meson build system? Thanks, Sarosh Arif.

[dpdk-dev] [PATCH] doc: fix typing error

2020-10-14 Thread Sarosh Arif
changed "net_pcap1;" to "net_pcap1," in order to make the command correct. Fixes: 53bf48403409 ("net/pcap: capture only ingress packets from Rx iface") Signed-off-by: Sarosh Arif --- doc/guides/nics/pcap_ring.rst | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[dpdk-dev] [PATCH v5] testpmd: add speed capability in device info

2020-10-08 Thread Sarosh Arif
Called rte_eth_dev_info_get() in testpmd, to get device info so that speed capabilities can be printed under "show device info" ​ Bugzilla ID: 496 Signed-off-by: Sarosh Arif --- app/test-pmd/config.c | 43 +++ 1 file changed, 43 insertions(+) di

[dpdk-dev] [PATCH v4] testpmd: add speed capability in device info

2020-10-08 Thread Sarosh Arif
Called rte_eth_dev_info_get() in testpmd, to get device info so that speed capabilities can be printed under "show device info" ​ Bugzilla ID: 496 Signed-off-by: Sarosh Arif --- v2: display all speed capabilities in a single line remove switch case v3: add missing speeds make a fu

[dpdk-dev] [PATCH v3] testpmd: add speed capability in device info

2020-10-08 Thread Sarosh Arif
Called rte_eth_dev_info_get() in testpmd, to get device info so that speed capabilities can be printed under "show device info" ​ Bugzilla ID: 496 Signed-off-by: Sarosh Arif --- v2: display all speed capabilities in a single line remove switch case v3: add missing speeds make a fu

[dpdk-dev] [PATCH v2] testpmd: add speed capability in device info

2020-09-28 Thread Sarosh Arif
Called rte_eth_dev_info_get() in testpmd, to get device info so that speed capabilities can be printed under "show device info" ​ Bugzilla ID: 496 Signed-off-by: Sarosh Arif --- app/test-pmd/config.c | 38 ++ 1 file changed, 38 insertions(+) diff -

Re: [dpdk-dev] [v3 PATCH] test_distributor: prevent memory leakages from the pool

2020-09-28 Thread Sarosh Arif
On Fri, Sep 25, 2020 at 7:22 PM David Marchand wrote: > On Tue, Sep 8, 2020 at 12:22 PM Sarosh Arif > wrote: > > > > rte_mempool_get_bulk is used to get bufs/many_bufs from the pool, > > but at some locations when test fails the bufs/many_bufs are > > not returne

[dpdk-dev] [PATCH v2] common/octeontx2: fix memory mapping API's usage

2020-09-24 Thread Sarosh Arif
replace mmap() with rte_mem_map() and replace munmap() with rte_mem_unmap() Fixes: e1d9a02ad8f0 ("common/octeontx2: introduce common device class") Signed-off-by: Sarosh Arif --- v2: update description and commit message --- drivers/common/octeontx2/otx2_dev.c | 8 +--- 1 file

Re: [dpdk-dev] unable to bind to vfio-pci

2020-09-21 Thread Sarosh Arif
On Thu, Sep 17, 2020 at 2:35 PM Burakov, Anatoly wrote: > > On 17-Sep-20 10:21 AM, Sarosh Arif wrote: > > On Thu, Sep 17, 2020 at 2:17 PM Bruce Richardson > > wrote: > >> > >> On Thu, Sep 17, 2020 at 11:52:58AM +0500, Sarosh Arif wrote: > >>&

Re: [dpdk-dev] [PATCH] testpmd: add speed capability in device info

2020-09-21 Thread Sarosh Arif
On Thu, Sep 17, 2020 at 8:56 PM Ferruh Yigit wrote: > > On 9/4/2020 7:23 AM, Sarosh Arif wrote: > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > > index 30bee3324..8824ad174 100644 > > --- a/app/test-pmd/config.c > > +++ b/app/test-pmd

Re: [dpdk-dev] unable to bind to vfio-pci

2020-09-21 Thread Sarosh Arif
On Thu, Sep 17, 2020 at 4:50 PM Burakov, Anatoly wrote: > > On 17-Sep-20 11:22 AM, Bruce Richardson wrote: > > On Thu, Sep 17, 2020 at 02:21:27PM +0500, Sarosh Arif wrote: > >> On Thu, Sep 17, 2020 at 2:17 PM Bruce Richardson > >> wrote: > >>> >

Re: [dpdk-dev] unable to bind to vfio-pci

2020-09-17 Thread Sarosh Arif
On Thu, Sep 17, 2020 at 2:17 PM Bruce Richardson wrote: > > On Thu, Sep 17, 2020 at 11:52:58AM +0500, Sarosh Arif wrote: > > I have been trying to bind to vfio-pci using usertools/dpdk-devbind.py > > but am unable to do so. The reason behind this is that I am unable to > &g

Re: [dpdk-dev] unable to bind to vfio-pci

2020-09-17 Thread Sarosh Arif
Hello, On Thu, Sep 17, 2020 at 12:32 PM Dybkowski, AdamX wrote: > > Hi. > > > -Original Message- > > From: dev On Behalf Of Sarosh Arif > > Sent: Thursday, 17 September, 2020 08:53 > > To: dev@dpdk.org > > Subject: [dpdk-dev] unable to bind to vfio

[dpdk-dev] unable to bind to vfio-pci

2020-09-16 Thread Sarosh Arif
:b7:00.1 - Cannot bind to driver vfio-pci The details of :b7:00.1 are as follows: Ethernet Connection X722 for 10GBASE-T 37d2' if=eno6 drv=i40e I have also unbinded The pci bridge to which :b7:00.1 was connected. What more can be done to resolve this? Regards, Sarosh Arif

[dpdk-dev] [PATCH v2] doc: fix grammatical error

2020-09-16 Thread Sarosh Arif
This patch corrects a grammatical error by changing 'an DPDK' to 'a DPDK', so that the sentences can become grammatically accurate. Signed-off-by: Sarosh Arif --- doc/guides/linux_gsg/build_sample_apps.rst| 4 ++-- doc/guides/linux_gsg/enable_func.rst

[dpdk-dev] [PATCH] doc: fix grammatical error

2020-09-15 Thread Sarosh Arif
This patch corrects a grammatical error by changing 'an DPDK' to 'a DPDK', so that the sentences can become grammatically accurate. Signed-off-by: Sarosh Arif --- doc/guides/linux_gsg/build_sample_apps.rst| 6 +++--- doc/guides/linux_gsg/enable_func.rst

[dpdk-dev] [v3 PATCH] test_distributor: prevent memory leakages from the pool

2020-09-08 Thread Sarosh Arif
issue rte_mempool_put_bulk is used whenever the test fails and returns. Signed-off-by: Sarosh Arif --- v2: remove double freeing of mbufs v3: resubmit to run the tests again --- app/test/test_distributor.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/test/test_distributor.c b/app

Re: [dpdk-dev] [PATCH] testpmd: add speed capability in device info

2020-09-08 Thread Sarosh Arif
delay_us_sleep_autotest is failing on this patch. To replicate it, I ran the same test on my system and it did not fail. Can this test be re-run? On Fri, Sep 4, 2020 at 11:23 AM Sarosh Arif wrote: > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 30bee3324..8824ad1

[dpdk-dev] [PATCH] testpmd: add speed capability in device info

2020-09-03 Thread Sarosh Arif
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 30bee3324..8824ad174 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -518,6 +518,7 @@ device_infos_display(const char *identifier) struct rte_device *dev; struct rte_devargs da; portid_t port_

[dpdk-dev] [RFC] usertools: Replace dpdk-setup with a python curses based script

2020-08-18 Thread Sarosh Arif
dpdk-setup has been used for a long time in order to compile and configure dpdk along with running some basic applications. dpdk-setup uses the make build system to compile which is now deprecated. In addition to this it has been discussed on the mailing list a few times that dpdk-setup UI is quite

[dpdk-dev] [PATCH v2] doc: announce API change in timer

2020-08-03 Thread Sarosh Arif
event this rte_timer_reset_sync and rte_timer_stop_sync should have int return types, so that -1 can be returned if the above condition occurs Signed-off-by: Sarosh Arif --- v2: rephrase and fix typo --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides

Re: [dpdk-dev] [PATCH] doc: announce API change in timer

2020-08-03 Thread Sarosh Arif
eturns -1 due to which rte_timer_reset returns -1 > > and > > rte_timer_reset_sync goes into an infinite loop > > > > To to prevent this rte_timer_reset_sync and rte_timer_stop_sync should have > > int return types, so that -1 can be returned if the above conditi

[dpdk-dev] [PATCH] doc: announce API change in timer

2020-08-03 Thread Sarosh Arif
event this rte_timer_reset_sync and rte_timer_stop_sync should have int return types, so that -1 can be returned if the above condition occurs Signed-off-by: Sarosh Arif --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/

Re: [dpdk-dev] [PATCH] mbuf: replace c memcpy() code semantics with optimized rte_memcpy()

2020-07-28 Thread Sarosh Arif
.001808500 seconds time elapsed On Thu, Jul 23, 2020 at 8:47 PM Stephen Hemminger wrote: > > On Thu, 23 Jul 2020 12:02:40 +0500 > Sarosh Arif wrote: > > > Since rte_memcpy is more optimized it should be used instead of memcpy > > > > Signed-off-by: Sarosh Arif

Re: [dpdk-dev] [PATCH v4] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-07-23 Thread Sarosh Arif
Since this script has no maintainer who is responsible for providing ACK or NAK on the patches related to this script? On Tue, Jun 2, 2020 at 12:39 PM Sarosh Arif wrote: > Combine https://patches.dpdk.org/patch/67855/ with v2 of this patch to fix > the overall behaviour of dpdk-setup.sh

[dpdk-dev] [PATCH] mbuf: replace c memcpy() code semantics with optimized rte_memcpy()

2020-07-23 Thread Sarosh Arif
Since rte_memcpy is more optimized it should be used instead of memcpy Signed-off-by: Sarosh Arif --- lib/librte_mbuf/rte_mbuf.c | 2 +- lib/librte_mbuf/rte_mbuf.h | 3 ++- lib/librte_mbuf/rte_mbuf_dyn.c | 8 +--- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH] lib/librte_eal/common/rte_malloc: remove redundant check for size and alignment

2020-07-15 Thread Sarosh Arif
Since mallock_socket() always calls malloc_heap_alloc() and this check is present inside malloc_heap_alloc() so there is no need to place it in mallock_socket(). Signed-off-by: Sarosh Arif --- lib/librte_eal/common/rte_malloc.c | 4 1 file changed, 4 deletions(-) diff --git a/lib

Re: [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments

2020-07-13 Thread Sarosh Arif
Did you get the time to review it? On Tue, Jun 23, 2020 at 2:22 PM Pattan, Reshma wrote: > > > > > *From:* Sarosh Arif > *Sent:* Tuesday, June 23, 2020 10:19 AM > *To:* dev@dpdk.org; Pattan, Reshma > *Subject:* Re: [PATCH] examples/packet_ordering: Use rte_exit in

[dpdk-dev] [PATCH] drivers/common/octeontx2: use generic memory management

2020-07-13 Thread Sarosh Arif
Use generic memory management calls instead of Unix memory management calls for mempool. Signed-off-by: Sarosh Arif --- drivers/common/octeontx2/otx2_dev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/common/octeontx2/otx2_dev.c b/drivers/common/octeontx2

[dpdk-dev] [PATCH v3] lib/librte_timer:fix corruption with reset

2020-07-10 Thread Sarosh Arif
on to this problem is to return -1 from rte_timer_reset_sync/rte_timer_stop_sync in case the user tries to reset/stop some other timer in it's callback function. Bugzilla ID: 491 Fixes: 20d159f20543 ("timer: fix corruption with reset") Cc: h.mikit...@gmail.com Signed-off-by: Sarosh

Re: [dpdk-dev] [PATCH v2] lib/librte_timer:fix corruption with reset

2020-07-09 Thread Sarosh Arif
On Wed, Jul 8, 2020 at 8:07 PM Stephen Hemminger wrote: > On Wed, 8 Jul 2020 10:06:26 +0500 > Sarosh Arif wrote: > > > /* loop until rte_timer_reset() succeed */ > > -void > > +int > > rte_timer_reset_sync(struct rte_timer *tim, uint64_t ticks, > >

Re: [dpdk-dev] [PATCH v2] lib/librte_timer:fix corruption with reset

2020-07-09 Thread Sarosh Arif
On Wed, Jul 8, 2020 at 8:08 PM Stephen Hemminger wrote: > On Wed, 8 Jul 2020 10:06:26 +0500 > Sarosh Arif wrote: > > > rte_timer_stop_sync(struct rte_timer *tim) > > { > > + struct rte_timer_data *timer_data; > > + TIMER_DATA_VALID_GET_OR_ER

[dpdk-dev] [PATCH v2] lib/librte_timer:fix corruption with reset

2020-07-07 Thread Sarosh Arif
on to this problem is to return -1 from rte_timer_reset_sync/rte_timer_stop_sync in case the user tries to reset/stop some other timer in it's callback function. Bugzilla ID: 491 Fixes: 20d159f20543 ("timer: fix corruption with reset") Cc: h.mikit...@gmail.com Signed-off-by: Sarosh

[dpdk-dev] [PATCH] lib/librte_timer:fix corruption with reset

2020-07-07 Thread Sarosh Arif
on to this problem is to return -1 from rte_timer_reset_sync/rte_timer_stop_sync in case the user tries to reset/stop some other timer in it's callback function. Bugzilla ID: 491 Fixes: 20d159f20543 ("timer: fix corruption with reset") Cc: h.mikit...@gmail.com Signed-off-by: Sarosh Ar

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix references to /dev/huge

2020-07-06 Thread Sarosh Arif
On Mon, Jul 6, 2020 at 1:44 AM Thomas Monjalon wrote: > 23/06/2020 07:55, Sarosh Arif: > > change /dev/huge to /dev/hugepages > > > > Bugzilla ID: 492 > > Signed-off-by: Sarosh Arif > > Please could you explain why /dev/hugepages must be used, > in the com

Re: [dpdk-dev] [PATCH v2] app/test/test_distributor.c: prevent memory leakages from the pool

2020-06-24 Thread Sarosh Arif
Some tests are failing on this patch but I don't think the reason behind the failure is this patch. Is there a certain way to know that the problem is in the patch or somewhere else? On Wed, Jun 24, 2020 at 2:04 PM Sarosh Arif wrote: > > Some tests are failing on this patch but I

Re: [dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments

2020-06-23 Thread Sarosh Arif
Hello, This patch has been sitting around for more than 3 weeks. Is there something that needs to be done further for acceptance? Regards, Sarosh On Fri, Jun 5, 2020 at 4:49 PM Sarosh Arif wrote: > rte_exit should be called when the application exits due to > invalid EAL or appli

[dpdk-dev] [PATCH] doc: fix references to /dev/huge

2020-06-22 Thread Sarosh Arif
change /dev/huge to /dev/hugepages Bugzilla ID: 492 Signed-off-by: Sarosh Arif --- doc/guides/faq/faq.rst | 2 +- doc/guides/nics/thunderx.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst index f19c1389b..bb1df7dc8

[dpdk-dev] [PATCH v2 3/3] examples/skeleton: free resources on exit

2020-06-16 Thread Sarosh Arif
Resources should be cleared while exiting the application. Bugzilla ID: 437 Signed-off-by: Sarosh Arif --- v2: initialize portid --- examples/skeleton/basicfwd.c | 41 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/examples/skeleton

[dpdk-dev] [PATCH v2 2/3] examples/rxtx_callbacks: free resources on exit

2020-06-16 Thread Sarosh Arif
Resources should be cleared while exiting the application. Bugzilla ID: 437 Signed-off-by: Sarosh Arif --- v2: initialize portid --- examples/rxtx_callbacks/main.c | 47 -- 1 file changed, 39 insertions(+), 8 deletions(-) diff --git a/examples/rxtx_callbacks

[dpdk-dev] [PATCH v2 1/3] examples/packet_ordering: free resources on exit

2020-06-16 Thread Sarosh Arif
Resources should be cleared while exiting the application. Bugzilla ID: 437 Signed-off-by: Sarosh Arif --- v2: initialize portid --- examples/packet_ordering/main.c | 57 ++--- 1 file changed, 46 insertions(+), 11 deletions(-) diff --git a/examples/packet_ordering

[dpdk-dev] [PATCH] doc: fix typing error

2020-06-16 Thread Sarosh Arif
fixed typing error in doc/guides/tools/testbbdev.rst Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Signed-off-by: Sarosh Arif --- doc/guides/tools/testbbdev.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/tools/testbbdev

[dpdk-dev] [PATCH 1/3] examples/packet_ordering: free resources on exit

2020-06-15 Thread Sarosh Arif
Resources should be cleared while exiting the application. Bugzilla ID: 437 Signed-off-by: Sarosh Arif --- examples/packet_ordering/main.c | 51 ++--- 1 file changed, 41 insertions(+), 10 deletions(-) diff --git a/examples/packet_ordering/main.c b/examples

[dpdk-dev] [PATCH 2/3] examples/rxtx_callbacks: free resources on exit

2020-06-15 Thread Sarosh Arif
Resources should be cleared while exiting the application. Bugzilla ID: 437 Signed-off-by: Sarosh Arif --- examples/rxtx_callbacks/main.c | 45 -- 1 file changed, 38 insertions(+), 7 deletions(-) diff --git a/examples/rxtx_callbacks/main.c b/examples

[dpdk-dev] [PATCH 3/3] examples/skeleton: free resources on exit

2020-06-15 Thread Sarosh Arif
Resources should be cleared while exiting the application. Bugzilla ID: 437 Signed-off-by: Sarosh Arif --- examples/skeleton/basicfwd.c | 39 +--- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/examples/skeleton/basicfwd.c b/examples/skeleton

[dpdk-dev] [PATCH] examples: fix return value of function that parses portmask

2020-06-11 Thread Sarosh Arif
portmask causes an unexpected behaviour. If we return 0 instead of -1 this issue can be resolved. The program already contains the functionality to print "invalid portmask" and program usage if zero is returned. Signed-off-by: Sarosh Arif --- examples/distributor/main.c

[dpdk-dev] [PATCH] examples/packet_ordering: fix return value of parse_portmask

2020-06-05 Thread Sarosh Arif
sample app") Signed-off-by: Sarosh Arif --- examples/packet_ordering/main.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c index edaf810d9..b5fc6c54b 100644 --- a/examples/packet_ordering/main.c +++ b

[dpdk-dev] [PATCH] examples/packet_ordering: Use rte_exit in case of invalid EAL or application arguments

2020-06-05 Thread Sarosh Arif
rte_exit should be called when the application exits due to invalid EAL or application arguments. Fixes: 850f3733f840 ("examples/packet_ordering: new sample app") Cc: sergio.gonzalez.mon...@intel.com Signed-off-by: Sarosh Arif --- examples/packet_ordering/main.c | 4 ++-- 1 file

[dpdk-dev] [PATCH] doc/guides/sample_app_ug: fix ethtool app path

2020-06-04 Thread Sarosh Arif
The path to the ethtool application was slightly incorrect in the documentation. This patch corrects that path. Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") Cc: remy.hor...@intel.com Signed-off-by: Sarosh Arif --- doc/guides/sample_app_ug/ethto

[dpdk-dev] [PATCH v4] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-06-02 Thread Sarosh Arif
Combine https://patches.dpdk.org/patch/67855/ with v2 of this patch to fix the overall behaviour of dpdk-setup.sh on non-alphanumeric inputs. Instead of crashing the script will prompt the user to re-enter the input in case of non-alphanumeric input. Bugzilla ID: 419 Signed-off-by: Sarosh Arif

[dpdk-dev] [PATCH v3] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-06-01 Thread Sarosh Arif
Combine https://patches.dpdk.org/patch/67855/ with v2 of this patch to fix the overall behaviour of dpdk-setup.sh on non-alphanumeric inputs. Instead of crashing the script will prompt the user to re-enter the input in case of non-alphanumberic input. Bugzilla ID: 419 Signed-off-by: Sarosh Arif

Re: [dpdk-dev] [PATCH v2] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-04-17 Thread Sarosh Arif
Hello, If there is no objection on this patch then it can perhaps be applied. On Fri, Mar 20, 2020 at 11:50 AM Sarosh Arif wrote: > Bugzilla ID: 419 > Cc: sta...@dpdk.org > Signed-off-by: Sarosh Arif > --- > usertools/dpdk-setup.sh | 14 ++ > 1 file changed, 1

Re: [dpdk-dev] [PATCH v2] app/test/test_distributor.c: prevent memory leakages from the pool

2020-04-15 Thread Sarosh Arif
Yes, I plan to work on them when I get time. On Wed, Apr 15, 2020 at 11:52 AM Lukasz Wojciechowski < l.wojciec...@partner.samsung.com> wrote: > > W dniu 15.04.2020 o 08:42, Sarosh Arif pisze: > > v2: > > remove double freeing of mbufs > > > > Signed-off-by:

[dpdk-dev] [PATCH v2] app/test/test_distributor.c: prevent memory leakages from the pool

2020-04-14 Thread Sarosh Arif
v2: remove double freeing of mbufs Signed-off-by: Sarosh Arif --- app/test/test_distributor.c | 9 +++ 1 file changed, 7 insertions(+) diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index ba1f81cf8..5e972bb2e 100644 --- a/app/test/test_distributor.c +++ b/app/test

[dpdk-dev] [PATCH] test_distributor.c: prevent memory leakages from the pool

2020-04-13 Thread Sarosh Arif
this issue rte_mempool_put_bulk is used whenever the test passes/fails and returns. Signed-off-by: Sarosh Arif --- app/test/test_distributor.c | 13 + 1 file changed, 13 insertions(+) diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index ba1f81cf8

[dpdk-dev] [PATCH] usertools/dpdk-setup: ask user the name of build directory if RTE_TARGET is empty

2020-03-30 Thread Sarosh Arif
Bugzilla ID: 423 Cc: sta...@dpdk.org Signed-off-by: Sarosh Arif --- usertools/dpdk-setup.sh | 8 1 file changed, 8 insertions(+) diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh index e5bbe9fee..d7e4bc43d 100755 --- a/usertools/dpdk-setup.sh +++ b/usertools/dpdk-setup.sh

[dpdk-dev] [PATCH] doc/guides/contributing/patches.rst: fix typing error in line 426

2020-03-21 Thread Sarosh Arif
Bugzilla ID: 420 Cc: sta...@dpdk.org Signed-off-by: Sarosh Arif --- doc/guides/contributing/patches.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst index 59442824a..8caa8f1f5 100644 --- a/doc

[dpdk-dev] [PATCH v2] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-03-19 Thread Sarosh Arif
Bugzilla ID: 419 Cc: sta...@dpdk.org Signed-off-by: Sarosh Arif --- usertools/dpdk-setup.sh | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh index e5bbe9fee..c27f89c5f 100755 --- a/usertools/dpdk-setup.sh +++ b

[dpdk-dev] [PATCH v1] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-03-19 Thread Sarosh Arif
Bugzilla ID: 419 Cc: sta...@dpdk.org Signed-off-by: Sarosh Arif --- usertools/dpdk-setup.sh | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh index e5bbe9fee..bdacf5256 100755 --- a/usertools/dpdk-setup.sh +++ b

[dpdk-dev] [PATCH] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-03-19 Thread Sarosh Arif
Used regular expression to see if the input is numeric, otherwise prompts the user to re-enter. Bugzilla ID: 419 Cc: sta...@dpdk.org Signed-off-by: Sarosh Arif --- usertools/dpdk-setup.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) mode change 100755 => 100644 usertools/d