[PATCH] net/mlx5: fix flow dump for modify field

2023-06-29 Thread Sean Zhang
When using other process to dump flow information, the modify field information cannot be dumpped due to incorrect lcore value. Add loop to get modify field information from all lcore to fix the issue. Fixes: a7ac7fae4919 ("net/mlx5: enhance flow dump") Cc: sta...@dpdk.org Signed-of

RE: [PATCH] doc: support flow matching on representor ID

2022-11-01 Thread Sean Zhang (Networking SW)
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 1, 2022 5:37 PM > To: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko ; Sean > Zhang (Networking SW) > Cc: dev@dpdk.org > Subject: Re: [PATCH] doc: support flow matching on represento

[v2] doc: support flow matching on representor ID

2022-11-01 Thread Sean Zhang
Add note for support of matching on port representor ID. Fixes: 707d5e7d79e0 ("net/mlx5: support flow matching on representor ID") Signed-off-by: Sean Zhang --- v2 - add fixes line --- doc/guides/nics/mlx5.rst | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + 2 fil

[PATCH] doc: support flow matching on representor ID

2022-10-31 Thread Sean Zhang
Add note for support of matching on port representor ID. Signed-off-by: Sean Zhang --- doc/guides/nics/mlx5.rst | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + 2 files changed, 2 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index d5f9375a4e

[v4] net/mlx5: support matching flow on port representor ID

2022-10-24 Thread Sean Zhang
the flow will not be expanded and match on traffic from any representor port. Signed-off-by: Sean Zhang Acked-by: Viacheslav Ovsiienko --- The depending patches as below: [1] http://patches.dpdk.org/project/dpdk/cover/20220930125315.5079-1-suanmi...@nvidia.com --- v4 - update the commit title

[v3] net/mlx5: add port representor item support

2022-10-23 Thread Sean Zhang
the flow will not be expanded and match on traffic from any representor port. Signed-off-by: Sean Zhang Acked-by: Viacheslav Ovsiienko --- The depending patches as below: [1] http://patches.dpdk.org/project/dpdk/cover/20220930125315.5079-1-suanmi...@nvidia.com --- v3 - rebase to the latest version

RE: [PATCH] net/mlx5: add port representor support

2022-10-19 Thread Sean Zhang (Networking SW)
Thanks Ivan for the comments, patch updated. > -Original Message- > From: Ivan Malov > Sent: Wednesday, October 19, 2022 11:43 PM > To: Sean Zhang (Networking SW) > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Matan Azrad ; Slava Ovsiienko > ; Andrew Rybch

[v2] net/mlx5: add port representor item support

2022-10-19 Thread Sean Zhang
the flow will not be expanded and match on traffic from any representor port. Signed-off-by: Sean Zhang --- The depending patches as below: [1] http://patches.dpdk.org/project/dpdk/cover/20220930125315.5079-1-suanmi...@nvidia.com --- v2 - commit message updated and add missing feature in

[PATCH] net/mlx5: add port representor support

2022-10-19 Thread Sean Zhang
low will not be expanded and match on traffic from any representor port. Signed-off-by: Sean Zhang --- The depending patches as below: [1] http://patches.dpdk.org/project/dpdk/cover/20220930125315.5079-1-suanmi...@nvidia.com --- drivers/net/mlx5/mlx5_flow.c|

[v2 2/3] net/mlx5: add support to modify ECN field

2022-06-07 Thread Sean Zhang
This patch is to support modify ECN field in IPv4/IPv6 header. Signed-off-by: Sean Zhang Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 1 + doc/guides/rel_notes/release_22_07.rst | 1 + drivers/net/mlx5/mlx5_flow_dv.c| 20 3 files

[v2 3/3] net/mlx5: add modify field support in meter

2022-06-07 Thread Sean Zhang
off-by: Sean Zhang Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 4 ++-- drivers/net/mlx5/mlx5_flow.c | 5 +++- drivers/net/mlx5/mlx5_flow.h | 2 ++ drivers/net/mlx5/mlx5_flow_dv.c| 49 ++ drivers/net/m

[v2 1/3] common/mlx5: add modify ECN capability check

2022-06-07 Thread Sean Zhang
Flag outer_ip_ecn in header modify capabilities properties layout is added in order to check if the firmware supports modification of ecn field. Signed-off-by: Sean Zhang Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1

[v2 0/3] Add support for modifying ECN in IPv4/IPv6 header

2022-06-07 Thread Sean Zhang
This patch set adds support for modifying ECN fields in IPv4/IPv6 header, and also adds support for modify_filed action in meter. --- v2 --- rebase and add missing doc --- Sean Zhang (3): common/mlx5: add modify ECN capability check net/mlx5: add support to modify ECN field net/mlx5: add

[v2] net/mlx5: support represented port item

2022-06-07 Thread Sean Zhang
ess transfer group 0 pattern eth / represented_port / end actions represented_port ethdev_id is 0 / end Signed-off-by: Sean Zhang Acked-by: Viacheslav Ovsiienko --- v2 -- add missing doc --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 1 + doc/gui

RE: [v1 0/4] Add support for modifying ECN in IPv4/IPv6 header

2022-06-02 Thread Sean Zhang (Networking SW)
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 2, 2022 7:45 PM > To: Sean Zhang (Networking SW) ; Matan Azrad > ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: Re: [v1 0/4] Add support for modifying ECN in IPv4/IPv6 header > > External

[v1 1/4] ethdev: add IPv4/IPv6 ECN header rewrite action

2022-04-02 Thread Sean Zhang
From: Jiawei Wang This patch introduces the IPv4/IPv6 ECN modify field support, and adds the testpmd CLI commands support. Usage: modify_field op set dst_type ipv4_ecn src_type ... For example: flow create 0 ingress group 1 pattern eth / ipv4 / end actions modify_field op set

[v1 4/4] net/mlx5: add modify field support in meter

2022-04-02 Thread Sean Zhang
off-by: Sean Zhang --- doc/guides/nics/mlx5.rst | 4 +-- drivers/net/mlx5/mlx5_flow.c | 5 ++- drivers/net/mlx5/mlx5_flow.h | 2 ++ drivers/net/mlx5/mlx5_flow_dv.c| 49 +++--- drivers/net/mlx5/mlx5_flow_meter.c | 2 +- 5 files changed,

[v1 3/4] net/mlx5: add support to modify ECN field

2022-04-02 Thread Sean Zhang
This patch is to support modify ECN field in IPv4/IPv6 header. Signed-off-by: Sean Zhang --- drivers/net/mlx5/mlx5_flow_dv.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 1e9bd63635..e416eb5701

[v1 2/4] common/mlx5: add modify ECN capability check

2022-04-02 Thread Sean Zhang
Flag outer_ip_ecn in header modify capabilities properties layout is added in order to check if the firmware supports modification of ecn field. Signed-off-by: Sean Zhang --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/common/mlx5

[v1 0/4] Add support for modifying ECN in IPv4/IPv6 header

2022-04-02 Thread Sean Zhang
This patch set adds support for modifying ECN fields in IPv4/IPv6 header, and also adds support for modify_filed action in meter. Jiawei Wang (1): ethdev: add IPv4/IPv6 ECN header rewrite action Sean Zhang (3): common/mlx5: add modify ECN capability check net/mlx5: add support to modify

[v1] net/mlx5: support represented port item

2022-04-01 Thread Sean Zhang
ess transfer group 0 pattern eth / represented_port / end actions represented_port ethdev_id is 0 / end Signed-off-by: Sean Zhang --- drivers/net/mlx5/mlx5_flow.h| 4 + drivers/net/mlx5/mlx5_flow_dv.c | 160 +++- 2 files changed, 163 insertions(+), 1 delet

RE: [PATCH] net/mlx5: support matching optional fields of GRE

2022-02-25 Thread Sean Zhang (Networking SW)
Thanks Thomas. > -Original Message- > From: Thomas Monjalon > Sent: Friday, February 25, 2022 11:32 PM > To: Sean Zhang (Networking SW) > Cc: Matan Azrad ; Slava Ovsiienko > ; dev@dpdk.org; Asaf Penso > Subject: Re: [PATCH] net/mlx5: support matching o

RE: [PATCH] net/mlx5: support matching optional fields of GRE

2022-02-24 Thread Sean Zhang (Networking SW)
Hi Raslan, Rebased and new version sent out. Thanks, Sean > -Original Message- > From: Raslan Darawsheh > Sent: Thursday, February 24, 2022 9:18 PM > To: Sean Zhang (Networking SW) ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Matan Azrad > ; Slava Ovsiienko

[v4] net/mlx5: support matching optional fields of GRE

2022-02-24 Thread Sean Zhang
matching as before, but for patterns with checksum or sequence, validate capability first and then use misc5 for the matching. Signed-off-by: Sean Zhang Acked-by: Viacheslav Ovsiienko --- v4 - code rebase v3 - some code style change v2 - replace default mask with nic mask --- doc/guides/nics/mlx5.rst

RE: [PATCH] net/mlx5: support matching optional fields of GRE

2022-02-20 Thread Sean Zhang (Networking SW)
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, February 17, 2022 4:34 PM > To: Matan Azrad ; Slava Ovsiienko > ; Sean Zhang (Networking SW) > > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/mlx5: support matching optional fields of GRE

[PATCH] net/mlx5: support matching optional fields of GRE

2022-02-16 Thread Sean Zhang
matching as before, but for patterns with checksum or sequence, validate capability first and then use misc5 for the matching. Signed-off-by: Sean Zhang Acked-by: Slava Ovsiienko --- v3 - some code style change v2 - replace default mask with nic mask --- doc/guides/nics/mlx5.rst | 10

RE: [v2 0/4] Add support for GRE optional fields matching

2022-02-11 Thread Sean Zhang (Networking SW)
> -Original Message- > From: Ferruh Yigit > Sent: Friday, February 11, 2022 5:37 PM > To: Sean Zhang (Networking SW) ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Cc: dev@dpdk.org; Andrew Rybchenko ; > Ori Kam ; Qi Zhang > Subject: Re: [v2 0/4] Add support

RE: [v2 1/4] lib: add optional fields in GRE header

2022-02-11 Thread Sean Zhang (Networking SW)
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Friday, February 11, 2022 5:38 PM > To: Sean Zhang (Networking SW) ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Olivier Matz > > Cc: dev@dpdk.org; Andrew Rybchenko ; > Ori Kam > Subject: Re: [v2 1/

[v2 4/4] net/mlx5: support matching optional fields of GRE

2022-02-10 Thread Sean Zhang
before, but for patterns with checksum or sequence, validate capability first and then use misc5 for the matching. Signed-off-by: Sean Zhang --- doc/guides/nics/mlx5.rst | 8 +++ drivers/common/mlx5/mlx5_devx_cmds.c | 3 + drivers/net/mlx5/linux/mlx5_os.c | 2 + drivers/net

[v2 3/4] app/testpmd: add gre_option item command

2022-02-10 Thread Sean Zhang
cksum is 0x11 / end .. (c_bit is unset for gre item, but checksum is specified by gre_option item) Signed-off-by: Sean Zhang --- app/test-pmd/cmdline_flow.c | 72 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++ 2 fi

[v2 2/4] ethdev: support GRE optional fields

2022-02-10 Thread Sean Zhang
Add flow pattern items and header format for matching optional fields (checksum/key/sequence) in GRE header. And the flags in gre item should be correspondingly set with the new added items. Signed-off-by: Sean Zhang --- doc/guides/prog_guide/rte_flow.rst | 17 + doc/guides

[v2 1/4] lib: add optional fields in GRE header

2022-02-10 Thread Sean Zhang
There are optional fields in GRE header(checksum/key/sequence), this patch adds definition of structures of the optional fields. Signed-off-by: Sean Zhang --- lib/net/rte_gre.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/net/rte_gre.h b/lib/net/rte_gre.h

[v2 0/4] Add support for GRE optional fields matching

2022-02-10 Thread Sean Zhang
ld be correspondingly set. For example, if using gre_option to match checksum, the c_bit should be set '1' (.. / gre c_bit is 1 / gre_option checksum is xx / ..). change in v2: -changed the struct defined in rte_flow for gre_option item. -fixed raw encap issue. Sean Zhang (4): lib: ad

[v1 4/4] net/mlx5: support matching optional fields of GRE

2022-01-26 Thread Sean Zhang
before, but for patterns with checksum or sequence, validate capability first and then use misc5 for the matching. Signed-off-by: Sean Zhang --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 + drivers/net/mlx5/linux/mlx5_os.c | 2 + drivers/net/mlx5/mlx5.h | 1 + drivers/net

[v1 2/4] ethdev: support GRE optional fields

2022-01-26 Thread Sean Zhang
Add flow pattern items and header format for matching optional fields (checksum/key/sequence) in GRE header. And the flags in gre item should be correspondingly set with the new added items. Signed-off-by: Sean Zhang --- doc/guides/prog_guide/rte_flow.rst | 17 + lib/ethdev

[v1 3/4] app/testpmd: add gre_option item command

2022-01-26 Thread Sean Zhang
cksum is 0x11 / end .. (c_bit is unset for gre item, but checksum is specified by gre_option item) Signed-off-by: Sean Zhang --- app/test-pmd/cmdline_flow.c | 59 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++ 2 fi

[v1 0/4] Add support for GRE optional fields matching

2022-01-26 Thread Sean Zhang
ld be correspondingly set. For example, if using gre_option to match checksum, the c_bit should be set '1' (.. / gre c_bit is 1 / gre_option checksum is xx / ..). Sean Zhang (4): lib: add optional fields in GRE header ethdev: support GRE optional fields app/testpmd: add gre_option i

[v1 1/4] lib: add optional fields in GRE header

2022-01-26 Thread Sean Zhang
There are optional fields in GRE header(checksum/key/sequence), this patch adds definition of structures of the optional fields. Signed-off-by: Sean Zhang --- lib/net/rte_gre.h | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/net/rte_gre.h b/lib/net/rte_gre.h index

RE: [RFC 1/3] ethdev: support GRE optional fields

2022-01-25 Thread Sean Zhang (Networking SW)
Hi, > -Original Message- > From: Ori Kam > Sent: Wednesday, January 19, 2022 6:57 PM > To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Sean Zhang (Networking SW) ; Matan Azrad > ; Ferruh Yigit > Cc: Andrew Rybchenko ; dev@dpdk.org > Subject: RE: [RFC 1/3] ethd

RE: [RFC 1/3] ethdev: support GRE optional fields

2022-01-11 Thread Sean Zhang (Networking SW)
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Tuesday, January 11, 2022 3:24 PM > To: Sean Zhang (Networking SW) ; Matan Azrad > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Ferruh Yigit ; Andrew > Rybchenko > Cc: dev@dpdk.org > Subject: RE: [RFC 1/3] e

RE: [RFC 1/3] ethdev: support GRE optional fields

2022-01-10 Thread Sean Zhang (Networking SW)
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Sunday, January 9, 2022 8:30 PM > To: Sean Zhang (Networking SW) ; Matan Azrad > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Ferruh Yigit ; Andrew > Rybchenko > Cc: dev@dpdk.org > Subject: RE: [RFC 1/3] e

[RFC 3/3] net/mlx5: support matching on optional fields of GRE

2021-12-29 Thread Sean Zhang
before, but for patterns with checksum or sequence, validate capability first and then use misc5 for the matching. Signed-off-by: Sean Zhang --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 + drivers/net/mlx5/linux/mlx5_os.c | 2 + drivers/net/mlx5/mlx5.h | 1 + drivers/net

[RFC 2/3] app/testpmd: add gre_option item command

2021-12-29 Thread Sean Zhang
cksum is 0x11 / end .. (c_bit is unset for gre item, but checksum is specified by gre_option item) Signed-off-by: Sean Zhang --- app/test-pmd/cmdline_flow.c | 57 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++ 2 fi

[RFC 1/3] ethdev: support GRE optional fields

2021-12-29 Thread Sean Zhang
Add flow pattern items and header format for matching optional fields (checksum/key/sequence) in GRE header. And the flags in gre item should be correspondingly set with the new added items. Signed-off-by: Sean Zhang --- doc/guides/prog_guide/rte_flow.rst | 16 lib/ethdev

[RFC 0/3] Add support for GRE optional fields matching

2021-12-29 Thread Sean Zhang
ld be correspondingly set. For example, if using gre_option to match checksum, the c_bit should be set '1' (.. / gre c_bit is 1 / gre_option checksum is xx / ..). Sean Zhang (3): ethdev: support GRE optional fields app/testpmd: add gre_option item command net/mlx5: support matching

[dpdk-dev] [V2] app/flow-perf: add destination ports parameter

2021-10-13 Thread Sean Zhang
ortmask=0x12 --vxlan-encap --port-id=0,3 This command means the rules created on both representor 0 of PF 0 and PF 1, the destination port for the first represontor is PF 0, and the destination port for the other one it PF 1. Signed-off-by: Sean Zhang --- v2: remove new added dst-ports parameter, reuse

Re: [dpdk-dev] [PATCH] app/flow-perf: add destination ports parameter

2021-10-12 Thread Sean Zhang (Networking SW)
> -Original Message- > From: Wisam Monther > Sent: Tuesday, October 12, 2021 4:16 PM > To: Sean Zhang (Networking SW) ; NBU-Contact- > Thomas Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH] app/flow-perf: add destination ports parameter >

Re: [dpdk-dev] [PATCH] app/flow-perf: add destination ports parameter

2021-10-12 Thread Sean Zhang (Networking SW)
Hi Wisam, > -Original Message- > From: Wisam Monther > Sent: Tuesday, October 12, 2021 3:53 PM > To: Sean Zhang (Networking SW) ; NBU-Contact- > Thomas Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH] app/flow-perf: add destination po

[dpdk-dev] [PATCH] app/flow-perf: add destination ports parameter

2021-10-12 Thread Sean Zhang
-transfer --ingress --transfer \ > --ether --portmask=0x12 --vxlan-encap --port-id --dst-ports=0,3 This command means the rules created on both representor 0 of PF 0 and PF 1, the destination port for the first represontor is PF 0, and the destination port for the other one it PF 1. Signed-off-by

[dpdk-dev] [PATCH] common/mlx5: optimize debug log

2021-10-11 Thread Sean Zhang
Remove debug log inside of mlx5_list_init to avoid flooding debug messages when creating hash list with large actual size. Fixes: 9c373c524bae ("common/mlx5: move list utility from net driver") Cc: sta...@dpdk.org Signed-off-by: Sean Zhang Acked-by: Matan Azrad --- drivers/c

[dpdk-dev] [PATCH] common/mlx5: optimize debug log

2021-10-11 Thread Sean Zhang
Remove debug log inside of mlx5_list_init to avoid flooding debug messages when creating hash list with large actual size. Fixes: 9c373c524bae ('common/mlx5: move list utility from net driver') Cc: sta...@dpdk.org Signed-off-by: Sean Zhang Acked-by: Matan Azrad --- drivers/c