Re: [dpdk-dev] [PATCH v2] maintainers: update for net mlx4/mlx5

2021-09-03 Thread Shahaf Shuler
Monday, August 23, 2021 5:51 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2] maintainers: update for net mlx4/mlx5 > > For net/mlx4: > - removing Shahaf Shuler > - adding Viacheslav Ovsiienko > > For net/mlx5: > - removing Shahaf Shuler >

Re: [dpdk-dev] [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats

2020-04-20 Thread Shahaf Shuler
Monday, April 20, 2020 7:19 PM, Maxime Coquelin: > Cc: Slava Ovsiienko > Subject: Re: [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats > > > > On 4/20/20 5:57 PM, Shahaf Shuler wrote: > > Monday, April 20, 2020 10:13 AM, Maxime Coquelin: > >&g

Re: [dpdk-dev] [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats

2020-04-20 Thread Shahaf Shuler
Monday, April 20, 2020 10:13 AM, Maxime Coquelin: > Subject: Re: [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats > > Hi Shahaf, > > On 4/19/20 8:18 AM, Shahaf Shuler wrote: > > Thursday, April 16, 2020 4:20 PM, Maxime Coquelin: > >> Subject: R

Re: [dpdk-dev] [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats

2020-04-18 Thread Shahaf Shuler
Thursday, April 16, 2020 4:20 PM, Maxime Coquelin: > Subject: Re: [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats > > Hi Matan, > > On 4/16/20 11:06 AM, Matan Azrad wrote: > > Hi Maxime > > > > Can you point on specific vendor specific counter I suggested? > > No, I can't, but I th

[dpdk-dev] [PATCH v4] mbuf: extend pktmbuf pool private structure

2019-11-25 Thread Shahaf Shuler
be set to 0 by the user. [1] https://patches.dpdk.org/patch/63077/ Signed-off-by: Shahaf Shuler --- On v4: - added note to release notes On v3: - use memset to zero the entire private struct - validate flags is set to 0 also on ntb example On v2: - rename new field to flags - add extra

Re: [dpdk-dev] [PATCH v3] mbuf: extend pktmbuf pool private structure

2019-11-24 Thread Shahaf Shuler
Sunday, November 24, 2019 8:05 PM, Thomas Monjalon: > Subject: Re: [dpdk-dev] [PATCH v3] mbuf: extend pktmbuf pool private > structure > > 24/11/2019 18:50, Stephen Hemminger: > > On Sun, 24 Nov 2019 05:53:46 + > > Shahaf Shuler wrote: > > > > > diff -

[dpdk-dev] [PATCH v3] mbuf: extend pktmbuf pool private structure

2019-11-23 Thread Shahaf Shuler
be set to 0 by the user. [1] https://patches.dpdk.org/patch/63077/ Signed-off-by: Shahaf Shuler --- On v3: - use memset to zero the entire private struct - validate flags is set to 0 also on ntb example On v2: - rename new field to flags - add extra validation in code that flags = 0

Re: [dpdk-dev] [PATCH v2] mbuf: extend pktmbuf pool private structure

2019-11-23 Thread Shahaf Shuler
Thursday, November 21, 2019 4:32 PM, Olivier Matz: > Subject: Re: [PATCH v2] mbuf: extend pktmbuf pool private structure > > On Thu, Nov 21, 2019 at 12:28:18PM +0000, Shahaf Shuler wrote: [...[ > > > > Sorry I missed the last version in my previous mail. > &

[dpdk-dev] [PATCH v2] mbuf: extend pktmbuf pool private structure

2019-11-21 Thread Shahaf Shuler
be set to 0 by the user. [1] https://patches.dpdk.org/patch/63077/ Signed-off-by: Shahaf Shuler --- On v2: - rename new field to flags - add extra validation in code that flags = 0 --- lib/librte_mbuf/rte_mbuf.c | 10 +++--- lib/librte_mbuf/rte_mbuf.h | 1 + 2 files changed, 8 insertions

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

2019-11-19 Thread Shahaf Shuler
n Tue, 19 Nov 2019 15:23:50 + > > > Shahaf Shuler wrote: > > > > > > > Tuesday, November 19, 2019 11:33 AM, Thomas Monjalon: > > > > > Subject: Re: [PATCH] mbuf: extend pktmbuf pool private structure > > > > > > > > > &

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

2019-11-19 Thread Shahaf Shuler
Tuesday, November 19, 2019 11:33 AM, Thomas Monjalon: > Subject: Re: [PATCH] mbuf: extend pktmbuf pool private structure > > 18/11/2019 11:02, Shahaf Shuler: > > struct rte_pktmbuf_pool_private { > > uint16_t mbuf_data_room_size; /**< Size of data space in each >

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

2019-11-18 Thread Shahaf Shuler
Monday, November 18, 2019 6:12 PM, Stephen Hemminger: > Subject: Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private > structure > > On Mon, 18 Nov 2019 10:02:55 +0000 > Shahaf Shuler wrote: > > > With the API and ABI freeze ahead, it will be good to reserve some

[dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

2019-11-18 Thread Shahaf Shuler
be set to 0 by the user. [1] https://patches.dpdk.org/patch/63077/ Signed-off-by: Shahaf Shuler --- Note - am aware no proper RFC was sent before the proposal deadline of 19.11. However i hope this small change can be accepeted for the sake of simpler maintainance in the future. --- lib

[dpdk-dev] [RFC v20.20] mbuf: introduce pktmbuf pool with pinned external buffers

2019-11-18 Thread Shahaf Shuler
flag on the rte_pktmbuf_pool_private structure to specify this mempool is for mbuf with pinned external buffer. Upon detach this flag is validated and buffer is not detached. A new mempool create wrapper is also introduced to help application to create and populate such mempool. Signed-off-by: S

Re: [dpdk-dev] [PATCH] vfio: fix getting default container

2019-11-05 Thread Shahaf Shuler
; > > + if (container_fd == RTE_VFIO_DEFAULT_CONTAINER_FD) > > + return default_vfio_cfg; > > + > > for (i = 0; i < VFIO_MAX_CONTAINERS; i++) { > > if (vfio_cfgs[i].vfio_container_fd == container_fd) > > return &vfio_cfgs[i]; > > -- > > 2.17.1 > > Reviewed-by: David Marchand > > Shahaf, can you review this patch please? > Thanks. Looks good. Thanks for spotting this. Acked-by: Shahaf Shuler > > -- > David Marchand

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-11-04 Thread Shahaf Shuler
Monday, November 4, 2019 12:28 PM, Ilya Maximets: > Subject: Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from > host > > On 03.11.2019 7:48, Shahaf Shuler wrote: > > Friday, November 1, 2019 11:33 AM, Ilya Maximets: > >> Subject: Re: [dpdk-dev] [PATCH v

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-11-02 Thread Shahaf Shuler
Friday, November 1, 2019 11:33 AM, Ilya Maximets: > Subject: Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from > host > > On 30.10.2019 22:42, Thomas Monjalon wrote: > > 30/10/2019 17:09, Ilya Maximets: > >> On 30.10.2019 16:49, Thomas Monjalon wrote: > >>> 30/10/2019 16:07, Ilya Maxi

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-11-02 Thread Shahaf Shuler
Friday, November 1, 2019 3:25 PM, Jerin Jacob: > Subject: Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from > host > > On Fri, Nov 1, 2019 at 6:03 AM Thomas Monjalon > wrote: > > > > 30/10/2019 10:15, Jerin Jacob: > > > On Wed, Oct 30, 2019 at 2:26 PM Thomas Monjalon > wrote: > > >

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-10-30 Thread Shahaf Shuler
Wednesday, October 30, 2019 6:09 AM, Jerin Jacob: > Subject: Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from > host > > On Wed, Oct 30, 2019 at 12:21 AM Thomas Monjalon > wrote: > > > > In a virtual environment, the network controller may have to configure > > some SR-IOV VF parame

Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions

2019-10-27 Thread Shahaf Shuler
> -Original Message- > From: Damjan Marion (damarion) > Sent: Friday, October 25, 2019 2:14 PM > To: Thomas Monjalon > Cc: David Marchand ; Anatoly Burakov > ; Shahaf Shuler ; Ray > Kinsella ; dev ; Neil Horman > ; John McNamara ; > Marko Kovacevic ; Bruce

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-23 Thread Shahaf Shuler
Wednesday, October 23, 2019 4:34 PM, Olivier Matz: > Subject: Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags > > Hi Shahaf, > > On Wed, Oct 23, 2019 at 12:00:30PM +, Shahaf Shuler wrote: > > Hi Olivier, > > > > Thursday, October 17, 2019 5:4

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-23 Thread Shahaf Shuler
Hi Olivier, Thursday, October 17, 2019 5:42 PM, Olivier Matz: > Subject: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags > > Many features require to store data inside the mbuf. As the room in mbuf > structure is limited, it is not possible to have a field for each feature. > Also,

Re: [dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline packet

2019-10-23 Thread Shahaf Shuler
rom local > > > > > > DRAM, some buffers from other devices) with high BW, a hint > > > > > > flag is introduced in the mbuf. > > > > > > Application will hint the PMD whether or not it should try to > > > > > > inline the

Re: [dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline packet

2019-10-21 Thread Shahaf Shuler
Thursday, October 17, 2019 6:15 PM, Stephen Hemminger: > Subject: Re: [dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline > packet > > On Thu, 17 Oct 2019 07:27:34 +0000 > Shahaf Shuler wrote: > > > Some PMDs inline the mbuf data buffer directly to device. This is

Re: [dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline packet

2019-10-21 Thread Shahaf Shuler
Thursday, October 17, 2019 8:19 PM, Jerin Jacob: > Subject: Re: [dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline > packet > > On Thu, Oct 17, 2019 at 4:30 PM Shahaf Shuler > wrote: > > > > Thursday, October 17, 2019 11:17 AM, Jerin Jacob: > > > Subj

Re: [dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline packet

2019-10-17 Thread Shahaf Shuler
Thursday, October 17, 2019 11:17 AM, Jerin Jacob: > Subject: Re: [dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline > packet > > On Thu, Oct 17, 2019 at 12:57 PM Shahaf Shuler > wrote: > > > > Some PMDs inline the mbuf data buffer directly to device. This

[dpdk-dev] [RFC PATCH 20.02] mbuf: hint PMD not to inline packet

2019-10-17 Thread Shahaf Shuler
other devices) with high BW, a hint flag is introduced in the mbuf. Application will hint the PMD whether or not it should try to inline the given mbuf data buffer. PMD should do best effort to act upon this request. Signed-off-by: Shahaf Shuler --- lib/librte_mbuf/rte_mbuf.h | 9 + 1 file

Re: [dpdk-dev] [PATCH v2] vhost: add support for large buffers.

2019-10-05 Thread Shahaf Shuler
Havn't reviewed the code in details. But for the high level direction Acked-by: Shahaf Shuler > --- > doc/guides/prog_guide/vhost_lib.rst | 35 ++ > lib/librte_vhost/rte_vhost.h| 4 ++ > lib/librte_vhost/socket.c | 10 +++ > lib/librte_vhost/vh

Re: [dpdk-dev] [PATCH] vhost: add support to large linear mbufs

2019-10-02 Thread Shahaf Shuler
Wednesday, October 2, 2019 3:59 PM, Flavio Leitner: > Obrembski MichalX ; Stokes Ian > > Subject: Re: [dpdk-dev] [PATCH] vhost: add support to large linear mbufs > > > Hi Shahaf, > > Thanks for looking into this, see my inline comments. > > On Wed, 2 Oct 2019

Re: [dpdk-dev] [PATCH] vhost: add support to large linear mbufs

2019-10-02 Thread Shahaf Shuler
Wednesday, October 2, 2019 11:05 AM, David Marchand: > Subject: Re: [dpdk-dev] [PATCH] vhost: add support to large linear mbufs > > Hello Shahaf, > > On Wed, Oct 2, 2019 at 6:46 AM Shahaf Shuler > wrote: > > > > Wednesday, October 2, 2019 1:20 AM, Flavio Lei

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-10-02 Thread Shahaf Shuler
Wednesday, October 2, 2019 11:32 AM, Jerin Jacob Kollanukkaran: > Subject: Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev > subsystem > > > -Original Message- > > From: Shahaf Shuler > > Sent: Wednesday, October 2, 2019 11:23 AM > > To: J

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-10-01 Thread Shahaf Shuler
Friday, September 27, 2019 5:46 PM, Jerin Jacob Kollanukkaran: > subsystem > > > -Original Message- > > From: Jerin Jacob Kollanukkaran > > Sent: Tuesday, September 10, 2019 4:33 PM > > To: Shahaf Shuler ; Thomas Monjalon > > ; dev@dpdk.org > >

Re: [dpdk-dev] [PATCH v4 6/6] doc: deprecation notice for VFIO DMA map APIs

2019-10-01 Thread Shahaf Shuler
Hi David, Tuesday, October 1, 2019 6:20 PM, David Marchand: > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 6/6] doc: deprecation notice for VFIO > DMA map APIs > > Hello Shahaf, > > On 10/03/2019 09:28, Shahaf Shuler wrote: > > As those should be repl

Re: [dpdk-dev] [PATCH] vhost: add support to large linear mbufs

2019-10-01 Thread Shahaf Shuler
Wednesday, October 2, 2019 1:20 AM, Flavio Leitner: > Subject: [dpdk-dev] [PATCH] vhost: add support to large linear mbufs > > The rte_vhost_dequeue_burst supports two ways of dequeuing data. If the > data fits into a buffer, then all data is copied and a single linear buffer is > returned. Otherw

Re: [dpdk-dev] [PATCH 00/15] Introduce Virtio vDPA driver

2019-09-10 Thread Shahaf Shuler
Tuesday, September 10, 2019 4:56 PM, Maxime Coquelin: > Subject: Re: [dpdk-dev] [PATCH 00/15] Introduce Virtio vDPA driver > On 9/10/19 3:44 PM, Shahaf Shuler wrote: > > Tuesday, September 10, 2019 10:46 AM, Maxime Coquelin: > >> Subject: Re: [dpdk-dev] [PATCH 00/15] Introdu

Re: [dpdk-dev] [PATCH 00/15] Introduce Virtio vDPA driver

2019-09-10 Thread Shahaf Shuler
Tuesday, September 10, 2019 10:46 AM, Maxime Coquelin: > Subject: Re: [dpdk-dev] [PATCH 00/15] Introduce Virtio vDPA driver > > Hi Shahaf, > > On 9/9/19 1:55 PM, Shahaf Shuler wrote: > > Hi Maxime, > > > > Thursday, August 29, 2019 11:00 AM, Maxime Coquelin: >

Re: [dpdk-dev] [PATCH 00/15] Introduce Virtio vDPA driver

2019-09-09 Thread Shahaf Shuler
Hi Maxime, Thursday, August 29, 2019 11:00 AM, Maxime Coquelin: > Subject: [dpdk-dev] [PATCH 00/15] Introduce Virtio vDPA driver > > vDPA allows to offload Virtio Datapath processing by supported NICs, like > IFCVF for example. > > The control path has to be handled by a dedicated vDPA driver,

Re: [dpdk-dev] [PATCH] maintainers: update for Mellanox mlx5 PMD

2019-08-21 Thread Shahaf Shuler
hard work and the maintenance of the PMD. Acked-by: Shahaf Shuler > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4100260861..30dbb8be55 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -715

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-08-20 Thread Shahaf Shuler
Hi Jerin, Thursday, August 15, 2019 2:34 PM, Thomas Monjalon: > Subject: Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev > subsystem > > +Cc more > > > > From: Jerin Jacob > > Even though there are some vendors which offer Regex HW offload, due to > lack of standard AP

Re: [dpdk-dev] [PATCH 2/7] ethdev: add mbuf RSS update as a offload

2019-08-18 Thread Shahaf Shuler
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, August 18, 2019 10:01 AM > To: Shahaf Shuler ; pbhagavat...@marvell.com; > jer...@marvell.com; ferruh.yi...@intel.com; John McNamara > ; Marko Kovacevic > ; Thomas Monjalon > Cc: dev@dpdk.org > Sub

Re: [dpdk-dev] [PATCH 3/7] ethdev: add flow action type update as an offload

2019-08-17 Thread Shahaf Shuler
Sunday, August 18, 2019 8:57 AM, Andrew Rybchenko: > Subject: Re: [dpdk-dev] [PATCH 3/7] ethdev: add flow action type update as > an offload > > On 8/18/19 7:59 AM, Shahaf Shuler wrote: > > Friday, August 16, 2019 11:05 AM, Andrew Rybchenko: > >> ; Thomas Monjal

Re: [dpdk-dev] [PATCH 2/7] ethdev: add mbuf RSS update as a offload

2019-08-17 Thread Shahaf Shuler
Sunday, August 18, 2019 8:39 AM, Andrew Rybchenko: > ; Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/7] ethdev: add mbuf RSS update as a > offload > > On 8/18/19 7:52 AM, Shahaf Shuler wrote: > > Friday, August 16, 2019 10:48 AM, Andrew Rybchenko:

Re: [dpdk-dev] [PATCH 3/7] ethdev: add flow action type update as an offload

2019-08-17 Thread Shahaf Shuler
Friday, August 16, 2019 11:05 AM, Andrew Rybchenko: > ; Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 3/7] ethdev: add flow action type update as > an offload > > On 8/16/19 8:55 AM, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Add new Rx offload flag `

Re: [dpdk-dev] [PATCH 2/7] ethdev: add mbuf RSS update as a offload

2019-08-17 Thread Shahaf Shuler
Friday, August 16, 2019 10:48 AM, Andrew Rybchenko: > Subject: Re: [dpdk-dev] [PATCH 2/7] ethdev: add mbuf RSS update as a > offload > > On 8/16/19 8:55 AM, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used > to >

Re: [dpdk-dev] [PATCH 1/2] ethdev: add symmetric toeplitz hash support

2019-07-31 Thread Shahaf Shuler
Wednesday, July 31, 2019 3:31 PM, Adrien Mazarguil: > Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add symmetric toeplitz hash > support > > On Wed, Jul 31, 2019 at 03:08:19PM +0300, Andrew Rybchenko wrote: > > On 7/25/19 7:57 AM, simei wrote: > > > From: Simei Su > > > > > > Currently, there are

Re: [dpdk-dev] [PATCH v3] net/mlx5: add workaround for VLAN in virtual machine

2019-07-30 Thread Shahaf Shuler
workaround should be applied. > > Signed-off-by: Viacheslav Ovsiienko > Acked-by: Matan Azrad Acked-by: Shahaf Shuler

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix ESXi VLAN in virtual machine

2019-07-29 Thread Shahaf Shuler
Hi Slava, Monday, July 29, 2019 6:27 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix ESXi VLAN in virtual machine > > On ESXi setups when we have SR-IOV and E-Switch enabled there is the > problem to receive VLAN traffic on VF interfaces. The NIC driver in ESXi > hypervis

[dpdk-dev] [PATCH] maintainers: update for Mellanox

2019-07-04 Thread Shahaf Shuler
-off-by: Shahaf Shuler --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9eb96eb2d1..6bc938abab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -41,7 +41,7 @@ M: Jerin Jacob T: git://dpdk.org/next/dpdk-next-net-mrvl Next-net

[dpdk-dev] [PATCH] net/mlx5: fix 32b compilation

2019-06-11 Thread Shahaf Shuler
_mmap_offset 0x%lx", ^ Fixes: 6bf10ab69be0 ("net/mlx5: support 32-bit systems") Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_txq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5

Re: [dpdk-dev] [PATCH v1 0/9] mlx5: Handle data-path completions with error

2019-06-11 Thread Shahaf Shuler
Thursday, May 30, 2019 10:16 AM, Matan Azrad: > Cc: dev@dpdk.org; Matan Azrad > Subject: [PATCH v1 0/9] mlx5: Handle data-path completions with error > > Add support for data-path Rx and Tx completions with error handling: > > 1. Detect the error. > 2. Do not crash. > 3. Report it in statistics

Re: [dpdk-dev] [PATCH] net/mlx5: fix master device Netlink socket sharing

2019-06-11 Thread Shahaf Shuler
Thursday, June 6, 2019 3:23 PM, Viacheslav Ovsiienko: > Subject: [PATCH] net/mlx5: fix master device Netlink socket sharing > > There is the patch [1] that uses master device Netlink socket to retrieve > master device link settings. This is not thread safe because this resource may > be in use by

Re: [dpdk-dev] [PATCH] net/mlx5: fix condition for calling mlx5_link_update_unlocked_gset

2019-06-10 Thread Shahaf Shuler
Srinivas, Tuesday, June 11, 2019 9:29 AM, Asaf Penso: > Subject: [PATCH] net/mlx5: fix condition for calling > mlx5_link_update_unlocked_gset > > mlx5_link_update uses the newer ethtool command > ETHTOOL_GLINKSETTINGS to determine interface capabilities but falls back > to the older (deprecated)

Re: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scatter func

2019-06-02 Thread Shahaf Shuler
Monday, May 27, 2019 9:50 AM, Dekel Peled: > Subject: RE: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scatter > func > > PSB, thanks. > > > -Original Message----- > > From: Shahaf Shuler > > Sent: Sunday, May 26, 2019 9:49 PM > > To: Deke

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix event handler uninstall

2019-06-02 Thread Shahaf Shuler
Monday, May 27, 2019 7:59 AM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix event handler uninstall > > When device is being closed and tries to unregister interrupt callback, there > is > a chance the handler is still active (called in context of > eal_intr_thread_main >

Re: [dpdk-dev] [PATCH v2] net/mlx4: use dynamic log type

2019-05-26 Thread Shahaf Shuler
Friday, May 24, 2019 8:13 PM, Ferruh Yigit: > Subject: Re: [dpdk-dev] [PATCH v2] net/mlx4: use dynamic log type > > On 5/24/2019 5:03 PM, Stephen Hemminger wrote: > > From: Stephen Hemminger > > > > This driver should use dynamic log level not RTE_LOGTYPE_PMD. > > Other drivers were converted ba

Re: [dpdk-dev] [PATCH] net/mlx5: fix memory free on queue create error

2019-05-26 Thread Shahaf Shuler
Monday, May 20, 2019 8:42 PM, Ori Kam: > Subject: RE: [dpdk-dev] [PATCH] net/mlx5: fix memory free on queue create > error > > > > > -Original Message- > > From: dev On Behalf Of Dekel Peled > > Sent: Monday, May 20, 2019 11:07 AM > > To: Yongse

Re: [dpdk-dev] [PATCH] net/mlx5: fix event handler uninstall

2019-05-26 Thread Shahaf Shuler
Hi Slava, Saturday, May 25, 2019 12:26 PM, Of Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix event handler uninstall > > When device is being closed and tries to unregister interrupt callback, there > is > a chance the handler is still active (called in context of > eal_intr_

Re: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scatter func

2019-05-26 Thread Shahaf Shuler
Wednesday, May 15, 2019 1:08 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scatter > func > > Previous patch added handling of metadata for multi-segment packet. > Function txq_scatter_v in file mlx5_rxtx_vec_neon.h was updated > incorrectly, items were insert

Re: [dpdk-dev] [PATCH v4 0/4] net/mlx5: code cleanup in rx and tx files

2019-05-22 Thread Shahaf Shuler
Wednesday, May 8, 2019 11:30 AM, Dekel Peled: > Subject: [dpdk-dev] [PATCH v4 0/4] net/mlx5: code cleanup in rx and tx files > > During work on Rx feature I did some cleanup actions. > This series includes those changes divided by their type. > > --- > v2: Change 2nd patch type to "fix". > v3: Ap

Re: [dpdk-dev] [PATCH v2] doc: fix update release notes for Mellanox drivers

2019-05-13 Thread Shahaf Shuler
Monday, May 13, 2019 9:43 AM, Ori Kam: > Subject: RE: [dpdk-dev] [PATCH v2] doc: fix update release notes for > Mellanox drivers > > Hi, > > PSB > > > -Original Message----- > > From: Shahaf Shuler > > Sent: Monday, May 13, 2019 8:26 AM > > T

Re: [dpdk-dev] [PATCH v2] doc: fix update release notes for Mellanox drivers

2019-05-12 Thread Shahaf Shuler
Hi Ori, See some comments below. Sunday, May 12, 2019 11:33 PM, Ori Kam: > Subject: [dpdk-dev] [PATCH v2] doc: fix update release notes for Mellanox > drivers > > This patch adds some missing features to Mellanox drivers release notes. > It also updates the mlx5/mlx4 documentations. > > Fixes:

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix device removal handler for multiport device

2019-05-12 Thread Shahaf Shuler
Sunday, May 12, 2019 3:15 PM, Shahaf Shuler: > Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix device removal handler for > multiport device > > Sunday, May 12, 2019 11:32 AM, Viacheslav Ovsiienko: > > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix device removal handler > &

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix device removal handler for multiport device

2019-05-12 Thread Shahaf Shuler
;) > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Shahaf Shuler Thomas, Ferruh, This one is a critical fix for mlx5. w/o it will break the support for failsafe at azure. Can you consider to integrate it? > --- > v2: - address comments > - more detailed debug m

Re: [dpdk-dev] [PATCH] net/mlx5: fix errno in case of unsupported Direct Rules

2019-05-07 Thread Shahaf Shuler
Tuesday, May 7, 2019 4:42 PM, Ori Kam: > Subject: [PATCH] net/mlx5: fix errno in case of unsupported Direct Rules > > When Direct Rules API is not supported we don't set the errno. > this results in failing the function but with errno equals to zero. > The result of this is that a function that fa

Re: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object

2019-05-07 Thread Shahaf Shuler
Tuesday, May 7, 2019 10:26 AM, Dekel Peled: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue > object > > Function mlx5_rx_intr_disable() calls mlx5_rxq_ibv_get() and performs some > actions on the returned rxq_ibv. > It doens't release the rxq_ibv when all is completed with

Re: [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool name

2019-05-07 Thread Shahaf Shuler
Tuesday, May 7, 2019 2:22 AM, Yongseok Koh: > Subject: [PATCH] net/mlx5: fix Multi-Packet RQ mempool name > > Currently, the name of MPRQ mempool is set by > snprintf(name, sizeof(name), "%s-mprq", dev->device->name); For > port representor, the name is duplicate of its master and failed to

Re: [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files

2019-05-07 Thread Shahaf Shuler
Dekel, Sunday, May 5, 2019 4:09 PM, Dekel Peled: > Subject: [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files > > During work on Rx feature I did some cleanup actions. > This series includes those changes divided by their type. > > --- > v2: Change 2nd patch type to "fix". > v3: Apply min

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix init with zero Rx queues

2019-05-07 Thread Shahaf Shuler
Sunday, May 5, 2019 2:44 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH v3] net/mlx5: fix init with zero Rx queues > > Recent patch [1] added, at the end of mlx5_dev_configure(), a call to > mlx5_proc_priv_init(), initializing process_private data of eth_dev. > This call is not reached if PMD is st

Re: [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files

2019-05-02 Thread Shahaf Shuler
Hi Dekel, Monday, April 29, 2019 2:01 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files > > During work on Rx feature I did some cleanup actions. > This series includes those changes divided by their type. Good cleanup. I am basically OK w/ the series,

Re: [dpdk-dev] [PATCH v3 2/2] net/mlx: support IOVA VA mode

2019-05-02 Thread Shahaf Shuler
Thursday, May 2, 2019 12:08 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v3 2/2] net/mlx: support IOVA VA mode > > Set RTE_PCI_DRV_IOVA_AS_VA to driver's drv_flags as device's IOMMU > takes virtual address. > > Cc: sta...@dpdk.org > > Signed-off-by: Yong

Re: [dpdk-dev] [PATCH] net/mlx5: fix Direct Rules API

2019-05-01 Thread Shahaf Shuler
Wednesday, May 1, 2019 11:41 PM, Ori Kam: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Direct Rules API > > The RDMA-CORE Direct Rules API was changed in latest upstream code > > This commit update the API accordingly. > > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > > Signed-off-by:

Re: [dpdk-dev] [PATCH] net/mlx5: fix max number of queues for NEON Tx

2019-04-30 Thread Shahaf Shuler
Wednesday, May 1, 2019 4:37 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix max number of queues for NEON > Tx > > BlueField SmartNIC has 0xa2d2 as PCI device ID on both ARM and x86 host. > On ARM side, Tx inlining need not be used as PCI bandwidth is not > bottleneck. > Vectorized T

Re: [dpdk-dev] [PATCH v2] net/mlx5: check Tx queue size overflow

2019-04-30 Thread Shahaf Shuler
Wednesday, May 1, 2019 4:16 AM, Yongseok Koh: > Subject: Re: [PATCH v2] net/mlx5: check Tx queue size overflow > > > > On Apr 30, 2019, at 6:01 PM, Yongseok Koh wrote: > > > > If Tx packet inlining is enabled, rdma-core library should allocate > > large Tx WQ enough to support it. It is better f

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix E-Switch flow without port item

2019-04-30 Thread Shahaf Shuler
Thursday, April 25, 2019 8:54 PM, Yongseok Koh: > Subject: Re: [PATCH v2] net/mlx5: fix E-Switch flow without port item > > > > > On Apr 25, 2019, at 5:20 AM, Ori Kam wrote: > > > > When creating a flow rule without the port_id pattern item, always the > > PF was selected. > > > > This commit f

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow action destroy

2019-04-29 Thread Shahaf Shuler
Wednesday, April 24, 2019 3:56 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow action destroy > > ibv_destroy_flow_action() refers to QP. QP must not be freed until > corresponding action is destroyed. > > Fixes: 3eb004431072 ("net/mlx5: fix release of jump to queue action") >

Re: [dpdk-dev] [PATCH] net/mlx5: inherit master link settings for representors

2019-04-29 Thread Shahaf Shuler
Saturday, April 27, 2019 7:20 AM¸ Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH] net/mlx5: inherit master link settings for > representors > > There are some physical link settings can be queried from Ethernet devices: > link status, link speed, speed capabilities, duplex mode, etc. These set

Re: [dpdk-dev] [PATCH] net/mlx4: add support for multicast address list interface

2019-04-29 Thread Shahaf Shuler
Thursday, April 18, 2019 4:11 PM, Adrien Mazarguil: > Subject: [PATCH] net/mlx4: add support for multicast address list interface > > Since this driver does not distinguish unicast/multicast addresses, > applications could always rely on the standard MAC add/remove/set > interface to configure bot

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix modification action flags

2019-04-29 Thread Shahaf Shuler
Monday, April 22, 2019 10:03 PM, Shahaf Shuler: > Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: fix modification action flags > > > ‫ב-22 באפר׳ 2019, בשעה 21:06, ‏‏Ori Kam ‏ כתב/ה:‬ > > > When creating the modify action using Direct Rules, we need to add > > flags to

Re: [dpdk-dev] [PATCH v3 0/2] net/mlx5: share Memory Regions for multiport devices

2019-04-29 Thread Shahaf Shuler
Saturday, April 27, 2019 7:33 AM, Viacheslav Ovsiienko: > Subject: [PATCH v3 0/2] net/mlx5: share Memory Regions for multiport > devices > > The patches [1] and [2] are both related to Memory Regions sharing and their > applying order matters, this series just combines ones. > > The multiport Inf

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix modification action flags

2019-04-22 Thread Shahaf Shuler
Signed-off-by: Ori Kam Acked-by: Shahaf Shuler > --- > v3: > * Address ML comments. > > v2: > * Change title. > --- > drivers/net/mlx5/mlx5_flow.h| 1 + > drivers/net/mlx5/mlx5_flow_dv.c | 9 - > 2 files changed, 9 insertions(+), 1 deletion(-) >

Re: [dpdk-dev] [PATCH] net/mlx5: fix query host adapter if no DevX enabled

2019-04-22 Thread Shahaf Shuler
Monday, April 22, 2019 3:38 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix query host adapter if no DevX > enabled > > If there is the support of DevX is exposed by rdma-core but DevX is not > supported by or disabled for the specific interface the > mlx5_devx_cmd_query_hca_

Re: [dpdk-dev] [PATCH] net/mlx5: fix Direct Rules build

2019-04-22 Thread Shahaf Shuler
Saturday, April 20, 2019 3:03 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Direct Rules build > > All the library calls must be called via the glue layer. > > Fixes: b2177648b8de ("net/mlx5: add Direct Rules flow data alloc/free > routines") > Fixes: 79e35d0d5979 ("net/mlx5: shar

Re: [dpdk-dev] [PATCH] net/mlx5: fix typos replacing between Rx and Tx

2019-04-22 Thread Shahaf Shuler
Monday, April 22, 2019 6:24 PM, Dekel Peled: > Subject: [PATCH] net/mlx5: fix typos replacing between Rx and Tx > > In mlx5_rxq.c, in some comments, text includes "Tx" instead of "Rx". > In mlx5_txq.c, in some comments, text includes "Rx" instead of "Tx". > > This patch fixes these typos. > > Fi

Re: [dpdk-dev] [PATCH] net/mlx5: replace a port lookup with ethdev API

2019-04-22 Thread Shahaf Shuler
Thursday, April 18, 2019 3:15 AM, Thomas Monjalon: > Subject: [PATCH] net/mlx5: replace a port lookup with ethdev API > > Looking for an ethdev port is better (and more efficient) with an ethdev API > than an EAL one. > > Signed-off-by: Thomas Monjalon Applied to next-net-mlx, thanks.

Re: [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group

2019-04-22 Thread Shahaf Shuler
Wednesday, April 17, 2019 2:08 AM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: fix missing init for flow group > > On Sun, Apr 14, 2019 at 08:18:55PM +, Ori Kam wrote: > > the flow group should be initialized. > > For example selecting if the encapsulation is for root or private > > tables

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix modification action flags

2019-04-22 Thread Shahaf Shuler
Monday, April 22, 2019 3:34 PM, Ori Kam: > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix modification action flags > > When creating the modify action using Direct Rules, we need to add flags to > mark, if the action will be done on root table or on private table. > > Fixes: 4f84a19779ca ("net/mlx

Re: [dpdk-dev] [PATCH v3 0/9] net/mlx5: add Direct Verbs E-Switch support

2019-04-18 Thread Shahaf Shuler
Thursday, April 18, 2019 4:16 PM, Ori Kam: > Subject: [dpdk-dev] [PATCH v3 0/9] net/mlx5: add Direct Verbs E-Switch > support > > Currently MLX5 PMD supports 3 flow engines: > Verbs, Direct Verbs and TCF. The first two engines are for Nic steering while > the TCF is for E-Switch steering. > > Thi

Re: [dpdk-dev] [PATCH] net/mlx5: fix release of jump to queue action

2019-04-18 Thread Shahaf Shuler
Wednesday, April 17, 2019 1:46 AM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: fix release of jump to queue action > > On Sun, Apr 14, 2019 at 08:17:11PM +, Ori Kam wrote: > > Currenlty the allocation of the jump to QP is done in flow apply, this > > results in memory leak. > > > > This pat

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix modify header action position

2019-04-18 Thread Shahaf Shuler
Thursday, April 18, 2019 4:26 PM, Yongseok Koh: > Subject: Re: [PATCH v2] net/mlx5: fix modify header action position > > > > On Apr 17, 2019, at 1:01 PM, Ori Kam wrote: > > > > According to RTE flow the action order should be the order that the > > actions were given. > > In the case of modify

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/1] net/mlx5: fix memory region cleanup routine

2019-04-18 Thread Shahaf Shuler
Monday, April 15, 2019 11:46 AM, Slava Ovsiienko: > Subject: RE: [dpdk-stable] [PATCH 1/1] net/mlx5: fix memory region cleanup > routine > [...] > > I will take the v2. > There are some troubles with passing check-log script for mlx4/mlx5 merged > patch. > So, I prepared the separated patch for

Re: [dpdk-dev] [PATCH] net/mlx4: fix memory region cleanup routine

2019-04-18 Thread Shahaf Shuler
Monday, April 15, 2019 11:41 AM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH] net/mlx4: fix memory region cleanup routine > > mlx4 driver has a global list of Memory Regions created by device, and there > is a ml4_mr_release() routine which makes a memory cleanup at device > closing. The he

Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for PF representor

2019-04-18 Thread Shahaf Shuler
Tuesday, April 16, 2019 5:10 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2] net/mlx5: add support for PF representor > > On BlueField platform we have the new entity - PF representor. > This one represents the PCI PF attached to external host on the side of ARM. > The traffic sent by t

Re: [dpdk-dev] [PATCH v3 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

2019-04-18 Thread Shahaf Shuler
> > From: Yongseok Koh > > Sent: Thursday, April 18, 2019 4:23 PM > > To: Ori Kam > > Cc: Shahaf Shuler ; Matan Azrad > > ; Slava Ovsiienko ; > Moti > > Haimovsky ; dev@dpdk.org > > Subject: Re: [PATCH v3 9/9] net/mlx5: add drop action to Direct Verbs >

Re: [dpdk-dev] [PATCH] ethdev: deprecate legacy filter API

2019-04-16 Thread Shahaf Shuler
tep_termination > example. > > The next step will be to announce a deadline for complete removal. > As preparation of the removal of rte_eth_ctrl.h, RTE_ETH_FLOW_*, > RTE_TUNNEL_TYPE_* and RTE_ETH_HASH_FUNCTION_* definitions are > moved to rte_ethdev.h and rte_flow.h. > >

Re: [dpdk-dev] [PATCH 1/1] net/mlx5: add support for PF representor

2019-04-15 Thread Shahaf Shuler
Monday, April 15, 2019 12:12 PM, Slava Ovsiienko: > Subject: RE: [dpdk-dev] [PATCH 1/1] net/mlx5: add support for PF > representor > > Hi, Shahaf > > > -Original Message----- > > From: Shahaf Shuler > > Sent: Sunday, April 14, 2019 10:43 > > To: Slava O

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix RSS validation function

2019-04-14 Thread Shahaf Shuler
Sunday, April 14, 2019 10:05 AM, Ori Kam: > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix RSS validation function > > The RSS validation function was missing the verifcation that if RSS is > requested on inner packet, the flow must have tunnel data. > > Fixes: 23c1d42c7138 ("net/mlx5: split flow v

Re: [dpdk-dev] [PATCH 1/1] net/mlx5: add support for PF representor

2019-04-14 Thread Shahaf Shuler
Hi Slava, Friday, April 12, 2019 6:48 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH 1/1] net/mlx5: add support for PF representor > > On BlueField platform we have the new entity - PF representor. > This one represents the PCI PF attached to external host on the side of ARM. > The traffi

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/1] net/mlx5: fix memory region cleanup routine

2019-04-13 Thread Shahaf Shuler
Friday, April 12, 2019 8:55 PM, Yongseok Koh: > Subject: Re: [dpdk-stable] [PATCH 1/1] net/mlx5: fix memory region cleanup > routine > > > > On Apr 12, 2019, at 8:45 AM, Viacheslav Ovsiienko > wrote: > > > > mlx5 driver has a global list of Memory Regions created by device, and > > there is a ml

Re: [dpdk-dev] [PATCH v5 0/4] net/mlx: remove device register remap

2019-04-11 Thread Shahaf Shuler
Wednesday, April 10, 2019 9:41 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v5 0/4] net/mlx: remove device register remap > > This patchset lifts the requirement of reserving huge virtual address space > and remapping device UAR register on to it in order to use the same address > between primar

Re: [dpdk-dev] [PATCH] net/mlx4: fix Tx doorbell register unmap

2019-04-09 Thread Shahaf Shuler
Monday, April 8, 2019 9:23 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH] net/mlx4: fix Tx doorbell register unmap > > If rdma-core library doesn't support remapping UAR registers, the register > shouldn't be unmapped on device stop. > > Fixes: 0203d33a1059 ("net/mlx4: support secondary process"

  1   2   3   4   5   6   7   8   9   10   >