[dpdk-dev] [PATCH 1/1] net/i40e: fix compilation failure on core-avx-i

2021-06-22 Thread Shahed Shaikh
ch will only be included by i40e_rxtx_vec_avx2.c and i40e_rxtx_vec_avx512.c. Fixes: 0604b1f2208f ("net/i40e: fix crash in AVX512") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/i40e/i40e_rxtx_vec_avx2.c | 2 +- drivers/net/i40e/i40e_rxtx_vec_avx512.c |

[dpdk-dev] [PATCH 2/2] net/qede: enhance transmit data path CPU utilization

2020-01-02 Thread Shahed Shaikh
Use lightweight transmit handler which handles non-offloaded Tx data path. We get CPU utilization improvement of ~8%. Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 15 +++- drivers/net/qede/qede_rxtx.c | 125 + drivers/net/qede/qede_rxtx.h

[dpdk-dev] [PATCH 1/2] net/qede: enhance receive data path CPU utilization

2020-01-02 Thread Shahed Shaikh
Use light weight receive packet handler for non-LRO and non-scatter packets to improve CPU utilization in receive data path. We achieved ~18% CPU cycles improvement using this handler. Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 36 -- drivers/net/qede/qede_rxtx.c

Re: [dpdk-dev] [EXT] [PATCH v3 1/3] ethdev: support API to set max LRO packet size

2019-11-07 Thread Shahed Shaikh
uanziya...@huawei.com; cloud.wangxiao...@huawei.com; > zhouguoy...@huawei.com; wenzhuo...@intel.com; > konstantin.anan...@intel.com; ma...@mellanox.com; > shah...@mellanox.com; viachesl...@mellanox.com; Rasesh Mody > ; Shahed Shaikh ; > maxime.coque...@redhat.com; tiwei@intel.com; zhihong.w

[dpdk-dev] [PATCH v2 5/5] net/qede: implement rte_flow drop action

2019-09-12 Thread Shahed Shaikh
Add support to configure drop action in rte_flow infrastructure and add counter for dropped packets due to this filter action "rx_gft_filter_drop". Also, update supported flows and actions in qede guide. Signed-off-by: Shahed Shaikh --- doc/guides/nics/qede.rst

[dpdk-dev] [PATCH v2 3/5] net/qede: fix RSS configuration as per new 100Gb queue allocation method

2019-09-12 Thread Shahed Shaikh
;) Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 110 - 1 file changed, 27 insertions(+), 83 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 308588cb8..8b75ca3a7 100644 --- a/d

[dpdk-dev] [PATCH v2 4/5] net/qede: fix stats flow as per new 100Gb queue allocation method

2019-09-12 Thread Shahed Shaikh
As per new method, need to consider hw stats of queues from both engines. This patch fixes the stats collection flow accordingly. Fixes: 2af14ca79c0a ("net/qede: support 100G") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethd

[dpdk-dev] [PATCH v2 2/5] net/qede: fix ovs-dpdk failure when using odd number of queues on 100Gb mode

2019-09-12 Thread Shahed Shaikh
th_cmt' passed by Rx/Tx callbacks to respective engines. Fixes: 2af14ca79c0a ("net/qede: support 100G") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 112 --- drivers/net/qede/qede_ethdev.h | 5 +- drivers/net/qede/

[dpdk-dev] [PATCH v2 0/5] net/qede: fixes and enhancement

2019-09-12 Thread Shahed Shaikh
Fixed compilation failure from patch 2 on clang compiler. Shahed Shaikh (5): net/qede: refactor Rx and Tx queue setup net/qede: fix ovs-dpdk failure when using odd number of queues on 100Gb mode net/qede: fix RSS configuration as per new 100Gb queue allocation method net/qede: fix

[dpdk-dev] [PATCH v2 1/5] net/qede: refactor Rx and Tx queue setup

2019-09-12 Thread Shahed Shaikh
in next patch. Fixes: 2af14ca79c0a ("net/qede: support 100G") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_rxtx.c | 228 ++- 1 file changed, 141 insertions(+), 87 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c b/d

Re: [dpdk-dev] [PATCH v1 1/5] net/qede: refactor Rx and Tx queue setup

2019-09-12 Thread Shahed Shaikh
> -Original Message- > From: dev On Behalf Of Jerin Jacob > Sent: Thursday, September 12, 2019 6:04 PM > To: Shahed Shaikh > Cc: dev@dpdk.org; Rasesh Mody ; Jerin Jacob > Kollanukkaran ; GR-Everest-DPDK-Dev d...@marvell.com>; sta...@dpdk.org > Subject: Re: [dpdk

[dpdk-dev] [PATCH v1 5/5] net/qede: implement rte_flow drop action

2019-09-06 Thread Shahed Shaikh
Add support to configure drop action in rte_flow infrastructure and add counter for dropped packets due to this filter action "rx_gft_filter_drop". Also, update supported flows and actions in qede guide. Signed-off-by: Shahed Shaikh --- doc/guides/nics/qede.rst

[dpdk-dev] [PATCH v1 4/5] net/qede: fix stats flow as per new 100Gb queue allocation method

2019-09-06 Thread Shahed Shaikh
As per new method, need to consider hw stats of queues from both engines. This patch fixes the stats collection flow accordingly. Fixes: 2af14ca79c0a ("net/qede: support 100G") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethd

[dpdk-dev] [PATCH v1 1/5] net/qede: refactor Rx and Tx queue setup

2019-09-06 Thread Shahed Shaikh
in next patch. Fixes: 2af14ca79c0a ("net/qede: support 100G") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_rxtx.c | 228 ++- 1 file changed, 141 insertions(+), 87 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c b/d

[dpdk-dev] [PATCH v1 3/5] net/qede: fix RSS configuration as per new 100Gb queue allocation method

2019-09-06 Thread Shahed Shaikh
;) Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 110 - 1 file changed, 27 insertions(+), 83 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 308588cb8..8b75ca3a7 100644 --- a/d

[dpdk-dev] [PATCH v1 2/5] net/qede: fix ovs-dpdk failure when using odd number of queues on 100Gb mode

2019-09-06 Thread Shahed Shaikh
th_cmt' passed by Rx/Tx callbacks to respective engines. Fixes: 2af14ca79c0a ("net/qede: support 100G") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 112 --- drivers/net/qede/qede_ethdev.h | 5 +- drivers/net/qede/

[dpdk-dev] [PATCH v1 0/5] net/qede: fixes and enhancement

2019-09-06 Thread Shahed Shaikh
First patch refactors Rx and Tx queue setup code to lay a foundation for actual fix. - Second patch actually implements a new approach to fix the issue. - Third patch fixes RSS configuration w.r.t. new approach. - Fourth patch fixes statistics code impacted due to new approach. Shahed Shai

Re: [dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when using odd number of queues on 100Gb mode

2019-09-04 Thread Shahed Shaikh
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Wednesday, September 4, 2019 7:01 PM > To: Shahed Shaikh ; dev@dpdk.org > Cc: Rasesh Mody ; ferruh.yi...@intel.com; GR-Everest- > DPDK-Dev ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] net/qede:

[dpdk-dev] [PATCH 1/2] net/qede: fix ovs-dpdk failure when using odd number of queues on 100Gb mode

2019-09-04 Thread Shahed Shaikh
gines in separately installed Rx and Tx handlers. - Consolidate statistics of both HW queues while reporting to application. - Report engine wise queue statistics in xstats flow. e.g. - rx_q._xxx Fixes: 2af14ca79c0a ("net/qede: support 100G") Cc: sta...@dpdk.org Signed-off-by

[dpdk-dev] [PATCH 2/2] net/qede: implement rte_flow drop action

2019-09-04 Thread Shahed Shaikh
Add support to configure drop action in RTE_FLOW infrastructure. Also, add statistics counter for dropped packets due to this filter action "rx_gft_filter_drop" Signed-off-by: Shahed Shaikh --- drivers/net/qede/base/ecore_dev_api.h | 1 + drivers/net/qede/base/ecore_l2.c

[dpdk-dev] Recall: [PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD

2019-07-31 Thread Shahed Shaikh
Shahed Shaikh would like to recall the message, "[PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD".

Re: [dpdk-dev] [PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD

2019-07-31 Thread Shahed Shaikh
+ is not enabled. Before binging DPDK driver to one or more devices on Binging=>binding Thanks, Shahed > -Original Message- > From: Rasesh Mody > Sent: Wednesday, July 31, 2019 1:32 PM > To: dev@dpdk.org > Cc: Rasesh Mody ; John McNamara > ; Thomas Monjalon ; > Jerin Jacob K

Re: [dpdk-dev] [PATCH 3/3] drivers/net: use ack API in interrupt handlers

2019-07-17 Thread Shahed Shaikh
> -Original Message- > From: Nithin Dabilpuram > Sent: Wednesday, July 17, 2019 5:29 PM > To: Hyong Youb Kim ; David Marchand > ; Thomas Monjalon ; > Ferruh Yigit ; Igor Russkikh > ; Pavel Belous ; > Allain Legacy ; Matt Peters > ; Ravi Kumar ; Rasesh > Mody

Re: [dpdk-dev] [EXT] [RFC PATCH] vfio: move eventfd/interrupt pairing at setup time

2019-07-09 Thread Shahed Shaikh
t;rxtx" interrupts are left untouched but are most likely subject to the same > issue. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1654824 > Signed-off-by: David Marchand Thanks David for this patch. I have tested this patch with FastLinq adapters on which original issue is

Re: [dpdk-dev] [EXT] [PATCH] net/qede: remove interrupt reconfigure in handler

2019-07-01 Thread Shahed Shaikh
>From: David Marchand >Sent: Wednesday, June 26, 2019 1:07 PM >To: Rasesh Mody >Cc: dev@dpdk.org; sta...@dpdk.org; Shahed Shaikh >Subject: Re: [EXT] [PATCH] net/qede: remove interrupt reconfigure in handler >On Wed, Jun 26, 2019 at 12:50 AM Rasesh Mody <mailto:rm.

[dpdk-dev] [PATCH 3/5] net/bnx2x: fix memory leak

2019-06-04 Thread Shahed Shaikh
bnx2x_free_hsi_mem() does not free DMA memory. Fix it here. Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/bnx2x/bnx2x.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx

[dpdk-dev] [PATCH 5/5] net/bnx2x: fix supported max Rx and Tx descriptor count

2019-06-04 Thread Shahed Shaikh
") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/bnx2x/bnx2x.h| 10 -- drivers/net/bnx2x/bnx2x_ethdev.c | 5 + 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h index ef1688ff3..e4b4ec

[dpdk-dev] [PATCH 1/5] net/bnx2x: fix packet drop

2019-06-04 Thread Shahed Shaikh
ckets while looking for slow path completion descriptor out of fast path ring. This issue is seen under heavy traffic with link events happening in background. Fixes: 8bd31421c593 ("net/bnx2x: fix ramrod timeout") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/bnx

[dpdk-dev] [PATCH 4/5] net/bnx2x: fix link inconsistent state

2019-06-04 Thread Shahed Shaikh
is an actual link event or change in link status. Calling bnx2x_link_status_update() from bnx2x_link_update() may corrupt the data of link status in shared memory and result in inconsistent state of link. Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by

[dpdk-dev] [PATCH 2/5] net/bnx2x: fix interrupt flood

2019-06-04 Thread Shahed Shaikh
value, device continues to trigger interrupt causing an interrupt flood. Fix is to create and destroy status block DMA memory in dev_start and dev_stop flow instead of dev_configure and dev_close flow. Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Sha

[dpdk-dev] [PATCH 1/1] net/qede: update feature support matrix with flow API

2019-04-12 Thread Shahed Shaikh
Commit 267d32de46a8 ("net/qede: support generic flow API") added a support for RTE_FLOW APIs but did not update the feature support matrix. Fixes: 267d32de46a8 ("net/qede: support generic flow API") Signed-off-by: Shahed Shaikh --- doc/guides/nics/features/qede.ini | 1

Re: [dpdk-dev] [EXT] [PATCH v8] drivers/net: fix possible overflow using strlcat

2019-03-22 Thread Shahed Shaikh
> -Original Message- > From: Chaitanya Babu Talluri > Sent: Friday, March 22, 2019 1:22 PM > To: dev@dpdk.org > Cc: reshma.pat...@intel.com; jananeex.m.parthasara...@intel.com; Rasesh > Mody ; Shahed Shaikh ; > beilei.x...@intel.com; qi.z.zh...@intel.com; Chaitanya

[dpdk-dev] [PATCH 1/1] net/qede: fix receive packet drop

2019-03-12 Thread Shahed Shaikh
ring is less than or equals Rx packet burst count for dev->rx_pkt_burst(). Fixes: 8f2312474529 ("net/qede: fix performance bottleneck in Rx path") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_rxtx.c | 15 --- 1 file changed, 8 insertio

Re: [dpdk-dev] [PATCH] net/qede: support IOVA VA mode

2019-03-07 Thread Shahed Shaikh
nux") > > Cc: sta...@dpdk.org > > Signed-off-by: Kevin Traynor Acked-by: Shahed Shaikh Thanks, Shahed > --- > > drivers/net/qede/qede_ethdev.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/qede/qede_ethdev.c b/dr

[dpdk-dev] [PATCH 1/1] net/bnx2x: fix segfaults due to stale interrupt status

2019-02-21 Thread Shahed Shaikh
from previous ungraceful exit. So, check uninitialized status block variables in interrupt handling path which may lead to sefault. Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/bnx2x/bnx2x.c | 7 +++ 1 file change

[dpdk-dev] [PATCH 1/1] net/qede: fix tx_pkt_prepare for tunnel packets

2019-02-13 Thread Shahed Shaikh
d3978d5723 ("net/qede: fix Tx tunnel offload support mask") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 9bf93c2e1..01

Re: [dpdk-dev] [PATCH 1/2] net/qede: fix performance bottleneck in Rx path

2019-01-18 Thread Shahed Shaikh
> -Original Message- > From: Ferruh Yigit > Sent: Friday, January 18, 2019 8:11 PM > To: Shahed Shaikh ; dev@dpdk.org > Cc: sta...@dpdk.org; Rasesh Mody ; Thomas Monjalon > > Subject: [EXT] Re: [dpdk-dev] [PATCH 1/2] net/qede: fix performance bo

[dpdk-dev] [PATCH 1/2] net/qede: fix performance bottleneck in Rx path

2019-01-18 Thread Shahed Shaikh
rg Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_rxtx.c | 97 +--- drivers/net/qede/qede_rxtx.h | 2 + 2 files changed, 75 insertions(+), 24 deletions(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 0e33be1..684c

[dpdk-dev] [PATCH 2/2] net/qede: fix prefetch from incorrect place in Tx path

2019-01-18 Thread Shahed Shaikh
Incorrect placement of prefetch in Tx path is causing a performance drop of around ~2% on AMD platform. Fixes: 2ea6f76aff40 ("qede: add core driver") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_rxtx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/d