[dpdk-dev] PATCH] mbuf: rte_pktmbuf_dump: don't add 0x when using %p in format strings

2016-06-20 Thread Simon Kagstrom
I.e., avoid dump messages with double 0x0x, e.g., dump mbuf at 0x0x7fac7b17c800, phys=17b17c880, buf_len=2176 pkt_len=2064, ol_flags=0, nb_segs=1, in_port=255 segment at 0x0x7fac7b17c800, data=0x0x7fac7b17c8f0, data_len=2064 Signed-off-by: Simon Kagstrom --- lib/librte_mbuf

[dpdk-dev] [PATCH / RFC] sched: Correct subport calcuation

2016-06-10 Thread Simon Kagstrom
Signed-off-by: Simon Kagstrom --- I'm a total newbie to the rte_sched design and implementation, so I've added the RFC. We get crashes (at other places in the scheduler) without this code. lib/librte_sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH / RFC ] ethdev: Allow rte_eth_dev_configure with zero RX/TX queues

2016-05-16 Thread Simon Kagstrom
This allows releasing RX/TX queue memory. --- We're using DPDK 16.04 and have a test suite which performs a sequence of separate tests of the type allocate mempool rte_eth_dev_configure(port, n_rxq, n_txq, ...) setup rx/tx queues rte_eth_dev_start(port) stop rx/tx queues rt

[dpdk-dev] [PATCH v2] mk: pass EXTRA_CFLAGS to AUTO_CPUFLAGS to enable local modifications

2015-11-24 Thread Simon Kagstrom
asses EXTRA_CFLAGS to the figure-out-cpu-flags helper, which allows us to add -mno-aes to the compile flags and resolve this problem. Signed-off-by: Simon Kagstrom --- ChangeLog: v2: * Put EXTRA_CFLAGS after MACHINE_CFLAGS to enable overriding values mk/rte.cpuflags.mk | 2 +- 1 file chang

[dpdk-dev] [PATCH] mk: pass EXTRA_CFLAGS to AUTO_CPUFLAGS to enable local modifications

2015-11-18 Thread Simon Kagstrom
asses EXTRA_CFLAGS to the figure-out-cpu-flags helper, which allows us to add -mno-aes to the compile flags and resolve this problem. Signed-off-by: Simon Kagstrom --- mk/rte.cpuflags.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk

[dpdk-dev] [PATCH v2] rte_sched: release enqueued mbufs on rte_sched_port_free()

2015-11-17 Thread Simon Kagstrom
Otherwise mbufs will leak when the port is destroyed. The rte_sched_port_qbase() and rte_sched_port_qsize() functions are used in free now, so move them up. Signed-off-by: Simon Kagstrom --- ChangeLog: v2: * Break long line in rte_sched_port_qbase() * Provide some air after variable in

[dpdk-dev] [PATCH] rte_sched: release enqueued mbufs on rte_sched_port_free()

2015-10-28 Thread Simon Kagstrom
Otherwise mbufs will leak when the port is destroyed. The rte_sched_port_qbase() and rte_sched_port_qsize() functions are used in free now, so move them up. Signed-off-by: Simon Kagstrom --- lib/librte_sched/rte_sched.c | 44 +++- 1 file changed, 27

[dpdk-dev] [PATCH] rte_ether: clarify rte_eth_set_queue_rate_limit tx_rate parameter

2015-10-20 Thread Simon Kagstrom
The tx_rate unit is Mbps. Gleaned from the ixgbe implementation, the 82599 datasheet and the use in test-pmd. Signed-off-by: Simon Kagstrom --- lib/librte_ether/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether

[dpdk-dev] [PATCH v4] mbuf/ip_frag: move mbuf chaining to common code

2015-10-15 Thread Simon Kagstrom
Chaining/segmenting mbufs can be useful in many places, so make it global. Signed-off-by: Simon Kagstrom Signed-off-by: Johan Faltstrom --- ChangeLog: v4: * Line up doxygen comments better (Olivier Matz) * Correct patch name (Thomas Monajlon) v3: * Describe performance implications of

[dpdk-dev] [PATCH v2] kni: Use utsrelease.h to determine Ubuntu kernel version

2015-10-13 Thread Simon Kagstrom
Ping? // Simon On Thu, 20 Aug 2015 08:51:06 +0200 Simon Kagstrom wrote: > /proc/version_signature is the version for the host machine, but in > e.g., chroots, this does not necessarily match that DPDK is built > for. DPDK will then build for the wrong kernel version - that of the >

[dpdk-dev] [PATCH v3] mbuf/ip_frag: Move mbuf chaining to common code

2015-10-13 Thread Simon Kagstrom
Ping? // Simon On Mon, 7 Sep 2015 14:50:09 +0200 Simon Kagstrom wrote: > Chaining/segmenting mbufs can be useful in many places, so make it > global. > > Signed-off-by: Simon Kagstrom > Signed-off-by: Johan Faltstrom > --- > ChangeLog: > v2: > * Check for nb_

[dpdk-dev] [PATCH] mk: Quote $(KERNELCC) to allow ccache builds

2015-10-13 Thread Simon Kagstrom
Ping? This is one of three outstanding DPDK patches I have which hasn't seen any activitiy in a while. Is there a list of pending applies somewhere to monitor activity? // Simon On Thu, 24 Sep 2015 09:43:28 +0200 Simon Kagstrom wrote: > Otherwise building with KERNELCC="ccache g

[dpdk-dev] [PATCH] mk: Quote $(KERNELCC) to allow ccache builds

2015-09-24 Thread Simon Kagstrom
ersion print version and copyright information Signed-off-by: Simon Kagstrom --- mk/rte.module.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.module.mk b/mk/rte.module.mk index 7bf77c1..53ed4fe 100644 --- a/mk/rte.module.mk +++ b/mk/rte.module.mk @@

[dpdk-dev] [PATCH v3] mbuf/ip_frag: Move mbuf chaining to common code

2015-09-07 Thread Simon Kagstrom
Chaining/segmenting mbufs can be useful in many places, so make it global. Signed-off-by: Simon Kagstrom Signed-off-by: Johan Faltstrom --- ChangeLog: v2: * Check for nb_segs byte overflow (Olivier MATZ) * Don't reset nb_segs in tail (Olivier MATZ) v3: * Describe performance implica

[dpdk-dev] [PATCH v2] mbuf/ip_frag: Move mbuf chaining to common code

2015-09-07 Thread Simon Kagstrom
Chaining/segmenting mbufs can be useful in many places, so make it global. Signed-off-by: Simon Kagstrom Signed-off-by: Johan Faltstrom --- ChangeLog: v2: * Check for nb_segs byte overflow (Olivier MATZ) * Don't reset nb_segs in tail (Olivier MATZ) lib/librte_ip_frag/ip_frag_com

[dpdk-dev] [PATCH RFC] mbuf/ip_frag: Move mbuf chaining to common code

2015-08-31 Thread Simon Kagstrom
Chaining/segmenting mbufs can be useful in many places, so make it global. Signed-off-by: Simon Kagstrom Signed-off-by: Johan Faltstrom --- NOTE! Only compile-tested. We were looking for packet segmenting functionality in the MBUF API but didn't find it. This patch moves the implement

[dpdk-dev] [PATCH v2] kni: Use utsrelease.h to determine Ubuntu kernel version

2015-08-20 Thread Simon Kagstrom
kernel sources instead and fakes the upload version. Tested on a server with Ubuntu 12.04, building in a chroot for Ubuntu 14.04. Signed-off-by: Simon Kagstrom Signed-off-by: Johan Faltstrom --- ChangeLog: v2: Improve description and motivation for the patch. lib/librte_eal/linuxapp/kni/Makefile

[dpdk-dev] [PATCH v2] mem: Warn once if /proc/self/pagemap is unreadable

2015-06-24 Thread Simon Kagstrom
the time. Signed-off-by: Simon Kagstrom Signed-off-by: Johan Faltstrom --- ChangeLog: v2: Fix use with huge pages. lib/librte_eal/linuxapp/eal/eal_memory.c | 25 + 1 file changed, 25 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal

[dpdk-dev] [PATCH] mem: Warn once if /proc/self/pagemap is unreadable

2015-06-23 Thread Simon Kagstrom
the time. Signed-off-by: Simon Kagstrom Signed-off-by: Johan Faltstrom --- lib/librte_eal/linuxapp/eal/eal_memory.c | 24 1 file changed, 24 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index 9b8d946

[dpdk-dev] deadline notice

2015-06-11 Thread Simon Kagstrom
On Thu, 11 Jun 2015 10:33:21 +0200 Thomas Monjalon wrote: > 2015-06-11 09:27, Simon Kagstrom: > > On Wed, 10 Jun 2015 20:39:59 +0200 > > Thomas Monjalon wrote: > > > > I didn't find this in the list: > > > > rte_reorder: Allow sequence numbers

[dpdk-dev] deadline notice

2015-06-11 Thread Simon Kagstrom
Hi! On Wed, 10 Jun 2015 20:39:59 +0200 Thomas Monjalon wrote: > As described in the roadmap (http://dpdk.org/dev/roadmap), > starting from this week, > every new feature submission will be postponed to release 2.2. > The below features, which were submitted earlier, will be accepted in > the rel

[dpdk-dev] [PATCH v2] kni: Add set_rx_mode callback to handle multicast groups

2015-06-02 Thread Simon Kagstrom
interfaces because of an unimplemented ioctl SIOCADDMULTI. The patch simply adds an empty callback for set_rx_mode (typically used for setting up hardware) so that the ioctl succeeds. This is the same thing as the Linux tap interface does. Signed-off-by: Simon Kagstrom Signed-off-by: Johan

[dpdk-dev] [PATCH v2] eal: Allow combining -m and --no-huge

2015-05-27 Thread Simon Kagstrom
On Wed, 27 May 2015 09:06:46 -0400 Thomas F Herbert wrote: > I just tried applying v2 of the patch to master: > git apply ../patches/eal_common_options.patch > error: patch failed: lib/librte_eal/common/eal_common_options.c:850 > error: lib/librte_eal/common/eal_common_options.c: patch does not ap

[dpdk-dev] [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel version

2015-05-27 Thread Simon Kagstrom
/proc/version_signature is the version for the host machine, but in e.g., chroots, this does not need to match that DPDK is built for. Use utsrelease.h from the kernel sources instead and fake the upload version. Signed-off-by: Simon Kagstrom Signed-off-by: Johan Faltstrom --- lib/librte_eal

[dpdk-dev] [PATCH v2] eal: Allow combining -m and --no-huge

2015-05-27 Thread Simon Kagstrom
--vdev 'eth_pcap0,rx_pcap=/tmp/eth-rx.pcap,tx_pcap=/tmp/eth-tx.pcap' Signed-off-by: Simon Kagstrom Signed-off-by: Johan Faltstrom --- v2: * Remove unneeded parentheses and merge lines * Patch prefix now eal: * Add example and more description (from David Marchand) lib/librte_

[dpdk-dev] [PATCH] eal_common_options: Allow combining -m and --no-huge

2015-05-20 Thread Simon Kagstrom
Needed to run as non-root but with higher memory allocations. Signed-off-by: Simon Kagstrom Signed-off-by: Johan Faltstrom --- lib/librte_eal/common/eal_common_options.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib

[dpdk-dev] [PATCH] rte_reorder: Allow sequence numbers > 0 as starting point

2015-05-20 Thread Simon Kagstrom
nce number inserted as the starting point. Signed-off-by: Simon Kagstrom Signed-off-by: Johan Faltstrom --- lib/librte_reorder/rte_reorder.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_reorder/rte_reorder.c b/lib/librte_reorder/rte_reorder.c index dc0e806..4d6449e 100644 --

[dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle multicast groups

2015-05-07 Thread Simon Kagstrom
This is needed to add / remove interfaces in multicast groups via the ip tool. The callback does nothing - the same as the kernel tun.c. Signed-off-by: Simon Kagstrom --- Marked RFC since I'm by no means an expert on this. We noticed this when playing with KNI and IGMP handling.

[dpdk-dev] [PATCH] librte_eal: Allow combining --no-huge with -m XXX

2015-03-23 Thread Simon Kagstrom
Useful to run applications in usermode via a test driver. Signed-off-by: Simon Kagstrom --- Not sure if there are other implications of this, so please check! lib/librte_eal/common/eal_common_options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common

[dpdk-dev] [PATCH] headers: typeof -> __typeof__ to unbreak C++11 code

2015-02-25 Thread Simon Kagstrom
that indeed works when including the headers in C++ files (--std=c++11). There are some typeof()s left in C files, the patch only touches the public API. Signed-off-by: Simon Kagstrom --- lib/librte_acl/acl_vect.h | 8 lib/librte_eal/common/include/rte_common.h | 17