Re: [PATCH v1] net/ice: fix incorrect reading of PHY timestamp

2024-10-29 Thread Singh, Aman Deep
On 25-10-2024 15:56, Soumyadeep Hore wrote: In ICE PMD, previously the ready bitmap checking before reading PHY timestamp was not present. This caused incorrect Tx timestamping. The ready bitmap checking is enabled and PHY timestamp is read once the ready bitmap gives positive value. Fixes: 88

Re: [PATCH v1] net/ice: initialize PHC time with current time of day

2024-09-30 Thread Singh, Aman Deep
On 12-08-2024 10:47, Soumyadeep Hore wrote: The PHC main timer for ice pmd enabled drivers should be initialised to current time of day on enabling timesync else it will be initialized to 0 giving wrong timestamps. Signed-off-by: Soumyadeep Hore Acked-by: Aman Singh

RE: [PATCH v4 1/1] testpmd: add hairpin-map parameter

2024-09-20 Thread Singh, Aman Deep
Hi Gregory, Can you please resolve the compilation issues seen with this patch. Hairpin offloads packet forwarding between ports. Packet is expected on Rx port , Rx queue and is forwarded to Tx port Tx queue . Testpmd implements a static hairpin configuration scheme. The new parameter allows

Re: [PATCH] app/testpmd: handle IEEE1588 init fail

2024-04-05 Thread Singh, Aman Deep
On 3/30/2024 1:14 PM, Dengdui Huang wrote: When the port's timestamping function failed to initialize (for example, the device does not support PTP), the packets received by the hardware do not contain the timestamp. In this case, IEEE1588 packet forwarding should not start. This patch fix it.

Re: [PATCH v4 3/3] testpmd: replace EAL logtype TESTPMD_LOG

2024-03-11 Thread Singh, Aman Deep
On 3/9/2024 4:03 AM, Stephen Hemminger wrote: Testpmd is misusing EAL logtype for some errors. Since the code directly has a macro for logging, use that. Also, replace fprintf(stderr, ...) with TESTPMD_LOG where appropriate. Signed-off-by: Stephen Hemminger Acked-by: Huisong Li Acked-by:

Re: [PATCH v2 3/3] testpmd: replace EAL logtype TESTPMD_LOG

2024-03-08 Thread Singh, Aman Deep
On 2/16/2024 9:06 AM, Stephen Hemminger wrote: Testpmd is misusing EAL logtype for some errors. Since the code directly has a macro for logging, use that. Signed-off-by: Stephen Hemminger Acked-by: Huisong Li fix testpmd --- app/test-pmd/testpmd.c | 42 +++-

Re: [V1 2/5] app/testpmd: support VXLAN-GPE flags

2024-01-24 Thread Singh, Aman Deep
On 1/12/2024 1:32 PM, Gavin Li wrote: Add support for VXLAN-GPE flags field in flow rule pattern to testpmd. Signed-off-by: Gavin Li Acked-by: Dariusz Sosnowski Acked-by: Aman Singh

Re: [V1 4/5] app/testpmd: support VXLAN-GPE reserved fields

2024-01-24 Thread Singh, Aman Deep
On 1/12/2024 1:32 PM, Gavin Li wrote: Add support for VXLAN-GPE rsvd0 and rsvd1 fields in flow rule pattern to testpmd Signed-off-by: Gavin Li Acked-by: Dariusz Sosnowski Acked-by: Aman Singh (aman.deep.si...@intel.com> ---

Re: [PATCH] testpmd: unregister event callback

2023-09-26 Thread Singh, Aman Deep
On 9/15/2023 9:56 AM, ok...@kernel.org wrote: From: Sinan Kaya Header format doesn't requires to add "From: " as author "Signed-off" is already present. Cleanup event registry during shutdown to prevent memory leaks. Signed-off-by: Sinan Kaya Acked-by: Aman Singh --- app/test-pmd

Re: [PATCH] app/testpmd: add support for MPLS TTL

2023-09-01 Thread Singh, Aman Deep
On 8/22/2023 7:47 PM, Michael Baum wrote: Add support for matching "ttl" field in MPLS item. Signed-off-by: Michael Baum Acked-by: Aman Singh --- app/test-pmd/cmdline_flow.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline

Re: [PATCH 2/4] app/testpmd: support UFO in checksum engine

2023-06-01 Thread Singh, Aman Deep
On 4/13/2023 11:04 AM, Zhichao Zeng wrote: This commit supports UFO for both non-tunnel and tunneled packets. Similar to TSO, the command "tso set " or "tunnel_tso set " is used to enable UFO, and the following conditions need to be met: a. The NIC supports UFO; b. For enabling UFO in tunnel

Re: [PATCH 5/7] app/testpmd: add setting and querying of LLRS FEC mode

2023-04-27 Thread Singh, Aman Deep
On 4/8/2023 7:57 AM, Dongdong Liu wrote: From: Jie Hai This patch supports setting and querying of LLRS FEC mode. Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu Acked-by: Aman Singh --- app/test-pmd/cmdline.c | 5 - app/test-pmd/config.c

Re: [PATCH v5] app/testpmd: txonly multiflow port change support

2023-04-26 Thread Singh, Aman Deep
On 4/22/2023 4:50 AM, Joshua Washington wrote: Google cloud routes traffic using IP addresses without the support of MAC addresses, so changing source IP address for txonly-multi-flow can have negative performance implications for net/gve when using testpmd. This patch updates txonly multiflow

Re: [PATCH] app/testpmd: fix GTP L2 len in checksum engine

2023-04-25 Thread Singh, Aman Deep
On 4/2/2023 5:56 PM, Raslan Darawsheh wrote: GTP header can be followed by an optional 32 bits extension. But, l2_len value statically set to RTE_ETHER_GTP_HLEN which is defined to be (sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr)) This fixes the l2_len to take into conside

Re: [PATCH v4] app/testpmd: txonly multiflow port change support

2023-04-19 Thread Singh, Aman Deep
On 4/12/2023 11:46 PM, Joshua Washington wrote: Google cloud routes traffic using IP addresses without the support of MAC addresses, so changing source IP address for txonly-multi-flow can have negative performance implications for net/gve when using testpmd. This patch updates txonly multiflow

Re: [PATCH] app/testpmd: dump private info in 'show port info'

2023-03-15 Thread Singh, Aman Deep
On 3/15/2023 8:03 AM, Chengwen Feng wrote: This patch adds dump private info in 'show port info [port_id]' cmd. Signed-off-by: Chengwen Feng Acked-by: Aman Singh --- app/test-pmd/config.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/con

Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread Singh, Aman Deep
On 3/10/2023 1:52 AM, Stephen Hemminger wrote: On Thu, 9 Mar 2023 17:19:59 + "Dumitrescu, Cristian" wrote: -Original Message- From: Stephen Hemminger Sent: Thursday, March 9, 2023 4:31 PM To: Jangra, Yogesh Cc: dev@dpdk.org; Dumitrescu, Cristian ; R, Kamalakannan ; Suresh Naray

Re: [PATCH v2 3/9] app/testpmd: rework ieee1588 engine fwd configuration

2023-02-24 Thread Singh, Aman Deep
On 2/20/2023 10:10 PM, David Marchand wrote: This fwd engine currently ignores the forwarding configuration. Force it explicitly when initialising the stream. The code is then more consistent with other fwd engines (i.e. receiving on fs->rx_port, transmitting on fs->tx_port). Signed-off-by: Da

Re: [PATCH v3 2/9] app/testpmd: fix packet count in ieee15888 engine

2023-02-24 Thread Singh, Aman Deep
On 2/21/2023 12:04 AM, David Marchand wrote: Don't count a packet has been transmitted before it is done. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Aman Singh

Re: [dpdk-dev] [RFC] testpmd: support user-id attribute

2023-02-21 Thread Singh, Aman Deep
August 2022 10:01 To: Singh, Aman Deep ; dev@dpdk.org Cc: Slava Ovsiienko ; Ori Kam ; Asaf Penso ; Matan Azrad ; Gaetan Rivet ; Nir Anteby ; Yuying Zhang ; Ferruh Yigit ; Andrew Rybchenko ; NBU-Contact- Thomas Monjalon (EXTERNAL) Subject: RE: [dpdk-dev] [RFC] testpmd: support user-id attribute

Re: [PATCH] app/testpmd: fix crash on cleanup

2023-02-16 Thread Singh, Aman Deep
On 2/6/2023 9:19 PM, David Marchand wrote: If allocating the ports[] array fails, a crash will occur when shutting down testpmd since ethdev emits RTE_ETH_EVENT_DESTROY events. Move init_port() before registering ethdev event handler. Looks ok to me. Avoids seg_fault, due to Null pointer acce

Re: [PATCH 6/6] app/testpmd: factorize fwd engine Tx

2023-02-16 Thread Singh, Aman Deep
On 2/14/2023 11:47 PM, Ferruh Yigit wrote: On 2/14/2023 11:03 AM, Singh, Aman Deep wrote: On 1/24/2023 4:17 PM, David Marchand wrote: Reduce code duplication by introducing a helper that takes care of transmitting, retrying if enabled and incrementing tx counter. Signed-off-by: David

Re: [PATCH 6/6] app/testpmd: factorize fwd engine Tx

2023-02-14 Thread Singh, Aman Deep
On 1/24/2023 4:17 PM, David Marchand wrote: Reduce code duplication by introducing a helper that takes care of transmitting, retrying if enabled and incrementing tx counter. Signed-off-by: David Marchand --- app/test-pmd/5tswap.c| 22 + app/test-pmd/csumonly.c | 23 +--

Re: [PATCH v2] app/testpmd: expand noisy neighbour forward mode support

2023-02-08 Thread Singh, Aman Deep
On 2/2/2023 12:33 AM, Mike Pattrick wrote: On Wed, Feb 1, 2023 at 10:19 AM Singh, Aman Deep wrote: Hi Mike, Thanks a lot for the patch. On 1/26/2023 10:25 AM, Mike Pattrick wrote: Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding packets as is

Re: [PATCH] app/testpmd: fix forwarding stats for Tx dropped

2023-02-07 Thread Singh, Aman Deep
On 1/31/2023 5:26 PM, Ferruh Yigit wrote: There is an inconsistency at displaying Tx dropped value for per port forwarding stats and accumulated forwarding stats. While displaying per port TX-dropped value, it only takes 'ports_stats[pt_id].tx_dropped' into account, but for accumulated TX-drop

Re: [PATCH v3 11/11] app/testpmd: adjust cleanup sequence when quitting

2023-02-03 Thread Singh, Aman Deep
On 1/30/2023 6:50 PM, Rongwei Liu wrote: If flex item is referenced in async flow either by pattern template or action template, currently testpmd complains "flex item has flow references". Flex items should be flushed after async flow resources cleanup. Signed-off-by: Rongwei Liu Acked-by: O

Re: [PATCH] app/testpmd: fix link check condition on port start

2023-02-03 Thread Singh, Aman Deep
On 1/28/2023 4:15 AM, Ferruh Yigit wrote: In testpmd port start function, 'need_check_link_status' variable is used to detect if a link check is required after port is started. Intention is if at least one port is started, link check should be called, and initially 'need_check_link_status' used

Re: [PATCH v2] app/testpmd: expand noisy neighbour forward mode support

2023-02-01 Thread Singh, Aman Deep
Hi Mike, Thanks a lot for the patch. On 1/26/2023 10:25 AM, Mike Pattrick wrote: Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding packets as is. However, this limited the usefulness of noisy neighbour simulation. This feature has now been expanded into al

Re: [PATCH v3 2/7] testpmd: fix whitespace

2023-01-31 Thread Singh, Aman Deep
On 1/17/2023 5:44 AM, Stephen Hemminger wrote: The style standard is to use blank after keywords. I.e "if (" not "if(" Signed-off-by: Stephen Hemminger Acked-by: Aman Singh

Re: [PATCH 2/2] app/testpmd: add disable-flow-flush parameter

2023-01-30 Thread Singh, Aman Deep
On 1/26/2023 12:07 AM, Ferruh Yigit wrote: On 12/15/2022 1:41 AM, Chengwen Feng wrote: This patch adds "--disable-flow-flush" parameter, which could used to disable port flow flush when stop port. It allows testing keep flow rules or shared flow objects across restart. Signed-off-by: Chengwen

Re: [PATCH 2/2] app/testpmd: add disable-flow-flush parameter

2023-01-23 Thread Singh, Aman Deep
On 12/15/2022 7:11 AM, Chengwen Feng wrote: This patch adds "--disable-flow-flush" parameter, which could used to disable port flow flush when stop port. It allows testing keep flow rules or shared flow objects across restart. Signed-off-by: Chengwen Feng --- app/test-pmd/parameters.c

Re: [PATCH v2 1/1] app/testpmd: add valid check to verify multi mempool feature

2022-11-17 Thread Singh, Aman Deep
On 11/17/2022 6:25 PM, Hanumanth Pothula wrote: Validate ethdev parameter 'max_rx_mempools' to know wheater device supports multi-mempool feature or not. Spell check: whether Bugzilla ID: 1128 Signed-off-by: Hanumanth Pothula Tested-by: Aman Singh v2: - Rebased on tip of next-net/

Re: [PATCH v2] app/testpmd: fix interactive mode with no ports

2022-11-15 Thread Singh, Aman Deep
Hi Gregory, Thanks for the patch. On 11/9/2022 10:39 PM, Gregory Etelson wrote: Testpmd terminated unconditionally if it failed to start all ports. The patch allows testpmd to get into the command line, if the interactive mode was requested. I tested testpmd in interactive mode with no ports

Re: [PATCH] app/testpmd: flush flow templates when port is removed

2022-11-11 Thread Singh, Aman Deep
On 11/8/2022 3:00 PM, Dariusz Sosnowski wrote: From: Suanming Mou This patch adds explicit flushing of template tables, pattern and actions templates, when a port is closed or detached. Signed-off-by: Suanming Mou Acked-by: Aman Singh ---

Re: [PATCH v12 1/1] app/testpmd: support multiple mbuf pools per Rx queue

2022-11-09 Thread Singh, Aman Deep
On 11/7/2022 11:01 AM, Hanumanth Pothula wrote: Some of the HW has support for choosing memory pools based on the packet's size. The pool sort capability allows PMD/NIC to choose a memory pool based on the packet's length. On multiple mempool support enabled, populate mempool array accordingl

Re: [PATCH v2 1/3] app/testpmd: support congestion management CLIs

2022-11-06 Thread Singh, Aman Deep
These newly added files for Congestion Management look in-line to Traffic Metering part, would like @Cristian to also have a look. Regards Aman On 11/6/2022 3:38 PM, Andrew Rybchenko wrote: @Aman, @Yuying, please, help to review the patch. On 10/12/22 12:01, Sunil Kumar Kori wrote: Please re

Re: [EXT] Re: [PATCH v11 1/1] app/testpmd: support multiple mbuf pools per Rx queue

2022-11-03 Thread Singh, Aman Deep
On 11/3/2022 6:06 PM, Hanumanth Reddy Pothula wrote: -Original Message- From: Singh, Aman Deep Sent: Thursday, November 3, 2022 5:46 PM To: Hanumanth Reddy Pothula ; Yuying Zhang Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; tho...@monjalon.net; Jerin Jacob Kollanukkaran

Re: [PATCH v11 1/1] app/testpmd: support multiple mbuf pools per Rx queue

2022-11-03 Thread Singh, Aman Deep
On 10/25/2022 7:10 AM, Hanumanth Pothula wrote: Some of the HW has support for choosing memory pools based on the packet's size. The pool sort capability allows PMD/NIC to choose a memory pool based on the packet's length. On multiple mempool support enabled, populate mempool array accordingl

Re: [PATCH] app/testpmd: fix testpmd receive jumbo frame packets

2022-10-27 Thread Singh, Aman Deep
Hi Jie, Thanks for the patch. On 10/25/2022 7:35 AM, Jie Wang wrote: For NIC I40E_10G-10G_BASE_T_X722, when testpmd is configured with link speed, it cannot receive jumbo frame packets. Why only the jumbo frame are effected and not other pkts. Because it has changed the link status of the

Re: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq

2022-10-27 Thread Singh, Aman Deep
On 10/27/2022 2:06 PM, Huang, ZhiminX wrote: -Original Message- From: Mingjin Ye Sent: Thursday, October 27, 2022 1:10 AM To: dev@dpdk.org Cc: sta...@dpdk.org; Zhou, YidingX ; Ye, MingjinX ; Singh, Aman Deep ; Zhang, Yuying Subject: [PATCH v4 1/2] app/testpmd: fix vlan offload of

Re: [PATCH] app/testpmd: fix testpmd crash when quit with mlx5 avail_thresh enabled

2022-10-27 Thread Singh, Aman Deep
On 10/24/2022 8:44 AM, Spike Du wrote: When testpmd quit with mlx5 avail_thresh enabled, a rte timer handler delays to reconfigure rx queue to re-arm this event. However at the same time, testpmd is destroying rx queues. It's never a valid use case for mlx5 avail_thresh. Before testpmd quit, us

Re: [PATCH v9 1/1] app/testpmd: support mulitiple mbuf pools per Rx queue

2022-10-21 Thread Singh, Aman Deep
On 10/17/2022 2:18 PM, Hanumanth Pothula wrote: Some of the HW has support for choosing memory pools based on the packet's size. The pool sort capability allows PMD/NIC to choose a memory pool based on the packet's length. On multiple mempool support enabled, populate mempool array accordingl

Re: [PATCH] app/testpmd: remove useless check

2022-10-14 Thread Singh, Aman Deep
Thanks for the patch Yuan. On 10/12/2022 7:59 PM, Yuan Wang wrote: Protocol header sequence checking is supported in the ethdev library, the application does not need to do it again. I would like to rephrase the patch title to make it more specific. Like "remove useless check" to "remove unuse

Re: [PATCH] app/testpmd: fix slave port reset action

2022-10-13 Thread Singh, Aman Deep
On 10/12/2022 1:13 PM, Qiming Yang wrote: As stop action has been forbidden in secondary process, so the reset action should also not be allowed. Fixes: a550baf24af9 ("app/testpmd: support multi-process") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang Acked-by: Aman Singh --- app/test-pm

Re: [PATCH] app/testpmd: fix incorrect flow arguments name

2022-10-06 Thread Singh, Aman Deep
On 9/30/2022 5:09 PM, Suanming Mou wrote: There should be no spaces in flow command arguments name. This commit removes incorrect arguments name in queue based table template. Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations") Cc: akozy...@nvidia.com Signed-off-by:

Re: [PATCH] app/testpmd: fix vlan offload of rxq

2022-10-04 Thread Singh, Aman Deep
On 9/30/2022 9:15 PM, Mingjin Ye wrote: After setting "vlan offload" in testpmd, the result does not update the rxq queues configuration. Therefore, this patch is to reconfigure rxq queues after executing the "vlan offload" command. Fixes: a47aa8b97afe ("app/testpmd: add vlan offload support"

Re: [PATCH V2 4/6] app/testpmd: check the validity of the port

2022-09-21 Thread Singh, Aman Deep
On 9/15/2022 6:15 PM, Huisong Li wrote: This patch checks the validity of port id for all events in 'eth_event_callback()'. Signed-off-by: Huisong Li Acked-by: Aman Singh ---

Re: [PATCH 2/2] app/testpmd: add GTP PSC QFI field support

2022-09-21 Thread Singh, Aman Deep
On 9/21/2022 3:48 PM, Dariusz Sosnowski wrote: This patch adds support for specifying GTP PSC QFI field as a source or destination of MODIFY_FIELD flow action in testpmd. An example for copying GTP PSC QFI field using MODIFY_FIELD action: modify_field op set dst_type m

Re: [PATCH v2 1/1] app/testpmd: add command line argument 'nic-to-pmd-rx-metadata'

2022-09-01 Thread Singh, Aman Deep
On 8/2/2022 11:21 PM, Hanumanth Pothula wrote: Presently, rx metadata is sent to PMD by default, leading to a performance drop as processing for the same in rx path takes extra cycles. Hence, introducing command line argument, 'nic-to-pmd-rx-metadata' to control passing rx metadata to PMD. By

Re: [PATCH v2] app/testpmd: fix incorrect queues state of secondary process

2022-08-24 Thread Singh, Aman Deep
Hi Peng, On 8/19/2022 3:39 PM, peng1x.zh...@intel.com wrote: From: Peng Zhang Primary process could set up queues state correctly when starting port, but under multi-process scenario, "stream_init" function would get wrong queues state for secondary process. This commit is to get queues state

Re: [dpdk-dev] [RFC] testpmd: support user-id attribute

2022-07-28 Thread Singh, Aman Deep
Hi Eli, In RTE flow there is support for group_id attribute(u32). Similar to the example you gave- testpmd> flow create 0 group 0x1234 ingress pattern eth / end actions count / drop / end Please check if it fits the requirement. Regards Aman On 7/20/2022 2:14 AM, Thomas Monjalon wrote: +Cc

Re: [PATCH] app/testpmd: fix GTP PSC raw processing

2022-07-04 Thread Singh, Aman Deep
On 6/30/2022 6:20 PM, Gregory Etelson wrote: Fix GTP PSP extension size initialization. Clear input buffer. cc: sta...@dpdk.org Fixes: c65282c9aa31 ("app/testpmd: fix GTP PSC raw processing") Signed-off-by: Gregory Etelson Acked-by: Aman Singh ---

Re: [PATCH] app/testpmd: fix GTP PSC raw processing

2022-07-01 Thread Singh, Aman Deep
Hi Gregory, On 6/30/2022 6:20 PM, Gregory Etelson wrote: Fix GTP PSP extension size initialization. Clear input buffer. cc: sta...@dpdk.org Fixes: c65282c9aa31 ("app/testpmd: fix GTP PSC raw processing") Signed-off-by: Gregory Etelson --- app/test-pmd/cmdline_flow.c | 6 -- 1 file cha

Re: [PATCH] app/testpmd: fix memory leak for dscp table

2022-06-29 Thread Singh, Aman Deep
On 6/28/2022 6:59 PM, Jasvinder Singh wrote: This patch fixes memory leak reported by coverity. Coverity issue: 379220 Fixes: 9f5488e326d3 ("app/testpmd: support different input color method") Cc: sta...@dpdk.org Signed-off-by: Jasvinder Singh Acked-by: Aman Singh

Re: [PATCH] app/testpmd: fix memory leak for dscp table

2022-06-29 Thread Singh, Aman Deep
Hi Jasvinder, Thanks for the patch. On 6/29/2022 9:07 PM, Morrissey, Sean wrote: Reviewed-by: Sean Morrissey Thanks. On 28/06/2022 14:29, Jasvinder Singh wrote: This patch fixes memory leak reported by coverity. Coverity issue: 379220 Fixes: 9f5488e326d3 ("app/testpmd: support different i

Re: [PATCH v2 1/2] net: fix GTP PSC headers

2022-06-21 Thread Singh, Aman Deep
On 6/16/2022 11:31 PM, Gregory Etelson wrote: Fix bitmap fields order in little endian section of GTP PSC headers. Fixes: e8ca1479cdc4 ("net: add extension header for GTP PSC") cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Reviewed-by: Viacheslav Ovsiienko Acked-by: Aman Singh

Re: [PATCH v2 2/2] app/testpmd: fix GTP PSC raw processing

2022-06-21 Thread Singh, Aman Deep
On 6/16/2022 11:31 PM, Gregory Etelson wrote: Use generic GTP PSC header definition in raw handler. Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw sets") cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Reviewed-by: Viacheslav Ovsiienko Acked-by: Aman Singh

Re: [PATCH v2] app/testpmd: add throughput stats for forward streams

2022-06-16 Thread Singh, Aman Deep
Hi Junfeng, Thanks for the patch. On 6/6/2022 3:09 PM, Junfeng Guo wrote: 1. add throughput statistics (in pps) for forward streams. 2. display the forward statistics for every forward stream. v2: add parameter descriptions and fix commit title. Signed-off-by: Xiao Wang Signed-off-by: Junfe

Re: [PATCH v6] app/testpmd: add Host Shaper command

2022-06-14 Thread Singh, Aman Deep
Hi Spike, On 6/13/2022 8:20 AM, Spike Du wrote: Add command line options to support host shaper configure. - Command syntax: mlx5 set port host_shaper avail_thresh_triggered <0|1> rate - Example commands: To enable avail_thresh_triggered on port 1 and disable current host shaper: testpmd>

Re: [PATCH v2 1/6] Revert "app/testpmd: modify mac in csum forwarding"

2022-06-13 Thread Singh, Aman Deep
Hi Maxime, On 6/8/2022 6:19 PM, Maxime Coquelin wrote: This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding"), as the checksum forwarding is expected to only perform checksum and not also overwrites the source and destination MAC addresses. Doing so, we can test

Re: [PATCH] testpmd: optimize forward stream statistics

2022-06-01 Thread Singh, Aman Deep
Hi Junfeng On 5/24/2022 1:57 PM, Junfeng Guo wrote: 1. add throughput statistics for forward stream 2. display forward statistics for every forward stream Signed-off-by: Xiao Wang Signed-off-by: Junfeng Guo --- app/test-pmd/testpmd.c | 41 ++--- app/test

Re: [PATCH V2 4/4] app/testpmd: fix slave device isn't released

2022-05-30 Thread Singh, Aman Deep
Hi Connor, On 5/30/2022 11:31 AM, Min Hu (Connor) wrote: Hi, all, any comments for this patch? 在 2022/3/24 11:00, Min Hu (Connor) 写道: From: Huisong Li Currently, some eth devices are added to bond device, these devices are not released when the quit command is executed in testpmd. This

Re: [PATCH 1/2] app/testpmd: fix stats get when display fwd stats

2022-04-27 Thread Singh, Aman Deep
On 4/6/2022 2:15 PM, Min Hu (Connor) wrote: In function 'fwd_stats_display', if function 'rte_eth_stats_get' fails, 'stats' is uncertainty value. The display result will be abnormal. This patch check the return value of 'rte_eth_stats_get' to avoid display abnormal stats. Fixes: 53324971a14e

Re: [PATCH 2/2] app/testpmd: fix incorrect MTU verification

2022-04-25 Thread Singh, Aman Deep
On 4/6/2022 2:15 PM, Min Hu (Connor) wrote: From: Huisong Li The macro RTE_ETHER_MIN_LEN isn't the minimum value of MTU. But testpmd used it when execute 'port config mtu 0 xx' cmd. This patch fix it. Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") Cc: sta...@dpdk.org Signed-off-by

Re: [PATCH] app/testpmd: fix use of indirect action after port close

2022-04-11 Thread Singh, Aman Deep
On 4/11/2022 2:01 AM, Dmitry Kozlyuk wrote: Hi Aman, From: Dmitry Kozlyuk Sent: Thursday, March 31, 2022 1:57 AM [...] From: Singh, Aman Deep Sent: Wednesday, March 30, 2022 5:24 PM [...] On 3/7/2022 10:18 PM, Dmitry Kozlyuk wrote: When a port was closed, indirect actions could remain

Re: [PATCH] app/testpmd: fix quit testpmd with vfs and pf

2022-03-31 Thread Singh, Aman Deep
On 3/28/2022 3:36 PM, Singh, Aman Deep wrote: On 3/22/2022 12:48 PM, Ke Zhang wrote: When testpmd startups with pf and vfs,this error occurs when quitting, results in pf is released before vfs ,so the vf would access an freed heap memory. The solution is two steps: 1. Fetch the valid port

Re: [PATCH] app/testpmd: fix use of indirect action after port close

2022-03-30 Thread Singh, Aman Deep
Hi Dmitry, On 3/7/2022 10:18 PM, Dmitry Kozlyuk wrote: When a port was closed, indirect actions could remain with their handles no longer valid. If a newly attached device was assigned the same ID as the closed port, those indirect actions became accessible again. Any attempt to use them resulte

Re: [PATCH] app/testpmd: fix quit testpmd with vfs and pf

2022-03-28 Thread Singh, Aman Deep
On 3/22/2022 12:48 PM, Ke Zhang wrote: When testpmd startups with pf and vfs,this error occurs when quitting, results in pf is released before vfs ,so the vf would access an freed heap memory. The solution is two steps: 1. Fetch the valid port value from RTE_ETH_FOREACH_DEV. 2. free the port

Re: [PATCH] app/testpmd: fix GTP header parsing in csum FWD engine

2022-03-11 Thread Singh, Aman Deep
Looks good to me. On 3/10/2022 7:50 PM, Gregory Etelson wrote: GTP header can be followed by an optional 32 bits extension. GTP notifies about the extension presence through the E, S or PN header bits. Csum GTP header parser did not check the extension bits value. The patch updates GTP header

Re: [PATCH] app/testpmd: fixed using strtoull with 64-bit variables

2022-03-11 Thread Singh, Aman Deep
On 3/10/2022 11:20 PM, Adham Masarwah wrote: Replaced using strtoul with strtoull when converting to 64-bit mask field. In Windows strtoul returns 32-bit values which cause an issue with show RSS reta. Fixes: 66c594904ac ("ethdev: support multiple sizes of redirection table") Cc:sta...@dpdk.org

Re: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments

2022-03-11 Thread Singh, Aman Deep
On 3/11/2022 1:42 PM, Liu, KevinX wrote: -Original Message- From: Singh, Aman Deep Sent: 2022年3月11日 16:02 To: Liu, KevinX; Zhang, Qi Z; dev; Yigit, Ferruh Cc: Yang, Qiming; Yang, SteveX ; Xing, Beilei; Li, Xiaoyun ; dpdk stable; Zhang, Yuying Subject: Re: [PATCH v2 2/2] app/testpmd

Re: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments

2022-03-11 Thread Singh, Aman Deep
Hi Kevin, On 3/11/2022 12:34 PM, Liu, KevinX wrote: Hi, Ferruh Yuying has already reviewed it days ago. If you can, I hope you can change the status as soon as possible and try to merge the code in RC4. Thank you. -Original Message- From: Zhang, Yuying Sent: 2022年3月3日 14:30 To: Zhan

Re: [PATCH V3] app/testpmd: fix GENEVE parsing in csum forward mode

2022-02-21 Thread Singh, Aman Deep
On 2/20/2022 5:39 PM, Raja Zidane wrote: The csum FWD mode parses any received packet to set mbuf offloads for the transmitting burst, mainly in the checksum/TSO areas. In the case of a tunnel header, the csum FWD tries to detect known tunnels by the standard definition using the header'sdata an

Re: [PATCH V2] app/testpmd: fix GENEVE parsing in csum forward mode

2022-02-18 Thread Singh, Aman Deep
On 2/16/2022 6:07 PM, Raja Zidane wrote: The csum FWD mode parses any received packet to set mbuf offloads for the transmitting burst, mainly in the checksum/TSO areas. In the case of a tunnel header, the csum FWD tries to detect known tunnels by the standard definition using the header'sdata an

Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace

2022-02-16 Thread Singh, Aman Deep
On 2/16/2022 3:47 AM, Thomas Monjalon wrote: 15/02/2022 19:51, Singh, Aman Deep: On 2/11/2022 10:58 PM, Thomas Monjalon wrote: 11/02/2022 09:07, Singh, Aman Deep: On 2/10/2022 9:00 PM, Thomas Monjalon wrote: 10/02/2022 14:26, Singh, Aman Deep: On 2/4/2022 1:17 PM, Thomas Monjalon wrote

Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace

2022-02-15 Thread Singh, Aman Deep
On 2/11/2022 10:58 PM, Thomas Monjalon wrote: 11/02/2022 09:07, Singh, Aman Deep: On 2/10/2022 9:00 PM, Thomas Monjalon wrote: 10/02/2022 14:26, Singh, Aman Deep: On 2/4/2022 1:17 PM, Thomas Monjalon wrote: 04/02/2022 07:13, Singh, Aman Deep: Hi Thomas On 2/3/2022 2:31 AM, Thomas Monjalon

Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

2022-02-15 Thread Singh, Aman Deep
or stating "unknown tunnel pkt" with its udp_port parameters. *From:* Singh, Aman Deep *Sent:* Monday, January 31, 2022 6:48 PM *To:* Raja Zidane ; Matan Azrad ; Ferruh Yigit ; dev@dpdk.org; Beilei Xing ; Qi Zhang *Cc:* sta...@dpdk.org *Subject:* Re: [PATCH] app/testpmd: fix GE

Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace

2022-02-11 Thread Singh, Aman Deep
On 2/10/2022 9:00 PM, Thomas Monjalon wrote: 10/02/2022 14:26, Singh, Aman Deep: On 2/4/2022 1:17 PM, Thomas Monjalon wrote: 04/02/2022 07:13, Singh, Aman Deep: Hi Thomas On 2/3/2022 2:31 AM, Thomas Monjalon wrote: 23/01/2022 18:20, Aman Singh: Added two specific exceptions for

Re: [PATCH] app/testpmd : fix testpmd quit error

2022-02-10 Thread Singh, Aman Deep
Hi Wenxuan Wu, On 2/9/2022 4:12 PM, wenxuanx...@intel.com wrote: From: Wenxuan Wu when testpmd startup with pf and vfs, it is ok when running, while exiting, it will result in heap-free-after-use which means pf is released but vf is still accessing. Change the logic of func port_is_bonding_sla

Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace

2022-02-10 Thread Singh, Aman Deep
On 2/4/2022 1:17 PM, Thomas Monjalon wrote: 04/02/2022 07:13, Singh, Aman Deep: Hi Thomas On 2/3/2022 2:31 AM, Thomas Monjalon wrote: 23/01/2022 18:20, Aman Singh: Added two specific exceptions for ETH_SPEED_10G and ETH_SPEED_25G to avoid there name change. Added check for ETH_TUNNEL_FILTER

Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace

2022-02-03 Thread Singh, Aman Deep
Hi Thomas On 2/3/2022 2:31 AM, Thomas Monjalon wrote: 23/01/2022 18:20, Aman Singh: Added two specific exceptions for ETH_SPEED_10G and ETH_SPEED_25G to avoid there name change. Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA Please could you explain why? These two macro's ETH_SPEED_10G &

Re: [PATCH] app/testpmd: skip stopped queues when forwarding

2022-02-03 Thread Singh, Aman Deep
Hi Dmitry, Thanks for the patch. On 1/13/2022 2:51 PM, Dmitry Kozlyuk wrote: After "port rxq|txq stop" the stopped queue was used in forwarding nonetheless, which may cause undefined behavior in the PMD. Record the configured queue state and account for it when launching forwarding as follow

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix port status of active slave device

2022-02-02 Thread Singh, Aman Deep
On 11/16/2021 6:50 AM, lihuisong (C) wrote: 在 2021/11/15 21:01, Singh, Aman Deep 写道: On 10/25/2021 12:09 PM, Min Hu (Connor) wrote: From: Huisong Li Stopping a bond device also stops all active slaves under the bond device. If this port is bond device, we need to modify the port status

Re: [PATCH 2/2] app/testpmd: fix stack overflow for EEPROM display

2022-02-02 Thread Singh, Aman Deep
Hi Steve The patch looks ok to me. On 1/20/2022 8:29 AM, Steve Yang wrote: When the size of EEPROM exceeds the default thread stack size(8MB), e.g.: 10Mb size, it will be cashed with stack overflow. Just spelling: 10Mb/10MB, cashed/crashed Can even rephrase, like: it will crash due to stack ove

Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

2022-01-31 Thread Singh, Aman Deep
any other parameters also. -Original Message----- From: Singh, Aman Deep Sent: Thursday, January 20, 2022 12:47 PM To: Matan Azrad; Ferruh Yigit; Raja Zidane;dev@dpdk.org Cc:sta...@dpdk.org Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode External email: Use cauti

Re: [PATCH] devtools/cocci: update cocci for ethdev namespace

2022-01-23 Thread Singh, Aman Deep
On 12/10/2021 6:48 PM, Ferruh Yigit wrote: On 12/8/2021 11:45 AM, Aman Singh wrote: Added two specific execptions for ETH_SPEED_10G and ETH_SPEED_25G to avoid there name change. Signed-off-by: Aman Singh ---   devtools/cocci/namespace_ethdev.cocci | 3 ++-   1 file changed, 2 insertions(+), 1

Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

2022-01-20 Thread Singh, Aman Deep
On 1/18/2022 6:49 PM, Matan Azrad wrote: -Original Message- From: Ferruh Yigit Sent: Tuesday, January 18, 2022 3:03 PM To: Matan Azrad ; Raja Zidane ; dev@dpdk.org Cc: sta...@dpdk.org Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode External email: Use cauti

Re: [PATCH v4 1/2] net: add functions to calculate UDP/TCP cksum in mbuf

2022-01-06 Thread Singh, Aman Deep
On 1/4/2022 9:10 PM, Li, Xiaoyun wrote: Hi -Original Message- From: Li, Xiaoyun Sent: Tuesday, January 4, 2022 15:19 To: Singh, Aman Deep; Yigit, Ferruh ;olivier.m...@6wind.com; m...@smartsharesystems.com; Ananyev, Konstantin ;step...@networkplumber.org; Medvedkin, Vladimir Cc:dev

Re: [PATCH v4 1/2] net: add functions to calculate UDP/TCP cksum in mbuf

2021-12-15 Thread Singh, Aman Deep
On 12/3/2021 5:08 PM, Xiaoyun Li wrote: Add functions to call rte_raw_cksum_mbuf() to calculate IPv4/6 UDP/TCP checksum in mbuf which can be over multi-segments. Signed-off-by: Xiaoyun Li --- doc/guides/rel_notes/release_22_03.rst | 10 ++ lib/net/rte_ip.h | 186

Re: [PATCH] app/testpmd: fix tunnel offload validation

2021-11-17 Thread Singh, Aman Deep
On 11/17/2021 3:39 PM, Ferruh Yigit wrote: On 11/17/2021 8:57 AM, Gregory Etelson wrote: Hello Ferruh, Can you estimate when this patch will be merged into 21.11 ? Hi Gregory, It is not merged because it is missing review. Ori, Slava, can you please help with the review? Thank you. Re

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix port status of active slave device

2021-11-15 Thread Singh, Aman Deep
On 10/25/2021 12:09 PM, Min Hu (Connor) wrote: From: Huisong Li Stopping a bond device also stops all active slaves under the bond device. If this port is bond device, we need to modify the port status of all slaves from RTE_PORT_STARTED to RTE_PORT_STOPPED. Fixes: 0e545d3047fe ("app/testpmd:

Re: [PATCH v3] app/testpmd: fix DCB in VT configuration

2021-11-15 Thread Singh, Aman Deep
On 11/15/2021 8:59 AM, Jie Wang wrote: When set port DCB in VT mode enabled, it should remove RSS HASH offload before reconfiguring the device and queues. Because port multi-queue mode is changed from RSS to DCB in VT. Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration") Signed-off-by:

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix DCB configuration

2021-11-12 Thread Singh, Aman Deep
On 11/10/2021 2:38 PM, Jie Wang wrote: When set port DCB mode enabled, it should remove RSS HASH offload before reconfiguring the device and queues. Because port multi-queue mode is changed from RSS to DCB. Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration") Signed-off-by: Jie Wang -

Re: [dpdk-dev] [PATCH v5] ethdev: fix representor port ID search by name

2021-09-30 Thread Singh, Aman Deep
On 9/30/2021 5:33 PM, Andrew Rybchenko wrote: On 9/29/21 2:13 PM, Singh, Aman Deep wrote: On 9/13/2021 4:56 PM, Andrew Rybchenko wrote: From: Viacheslav Galaktionov Getting a list of representors from a representor does not make sense. Instead, a parent device should be used. To this end

Re: [dpdk-dev] [RFC 3/3] app/testpmd: fix hex string parser in flow commands

2021-09-29 Thread Singh, Aman Deep
Hi Ovsiienko, Can you please provide the flow command which causes "segmentation fault". Thanks Aman

Re: [dpdk-dev] [PATCH v5] ethdev: fix representor port ID search by name

2021-09-29 Thread Singh, Aman Deep
On 9/13/2021 4:56 PM, Andrew Rybchenko wrote: From: Viacheslav Galaktionov Getting a list of representors from a representor does not make sense. Instead, a parent device should be used. To this end, extend the rte_eth_dev_data structure to include the port ID of the backing device for repre

Re: [dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-09-28 Thread Singh, Aman Deep
On 9/22/2021 9:01 AM, Huisong Li wrote: 在 2021/9/20 22:07, Ferruh Yigit 写道: On 8/25/2021 10:53 AM, Huisong Li wrote: 在 2021/8/24 22:42, Ferruh Yigit 写道: On 8/19/2021 4:45 AM, Huisong Li wrote: 在 2021/8/18 19:24, Ferruh Yigit 写道: On 8/13/2021 9:16 AM, Huisong Li wrote: 在 2021/8/13 14:12,

Re: [dpdk-dev] [PATCH] eal: add log to print dpdk version at start

2021-09-06 Thread Singh, Aman Deep
On 9/2/2021 3:57 PM, Bruce Richardson wrote: On Thu, Sep 02, 2021 at 11:11:39AM +0100, Ferruh Yigit wrote: On 9/1/2021 6:12 PM, Stephen Hemminger wrote: On Wed, 1 Sep 2021 11:48:21 +0530 Aman Singh wrote: From the logs it is difficult to get the DPDK version that was used. So added a deb

Re: [dpdk-dev] [RFC V1] ethdev: fix the issue that dev uninit may be called twice

2021-08-18 Thread Singh, Aman Deep
Hi Huison, On 8/2/2021 6:16 PM, Huisong Li wrote: Ethernet devices in DPDK can be released by rte_eth_dev_close() and rte_dev_remove(). However, these two APIs do not have explicit invocation restrictions. In other words, at the ethdev layer, calling rte_eth_dev_close() and then rte_dev_remove()

Re: [dpdk-dev] [PATCH v16] app/testpmd: support multi-process

2021-08-16 Thread Singh, Aman Deep
On 8/2/2021 1:33 PM, Thomas Monjalon wrote: 02/08/2021 03:51, Min Hu (Connor): 在 2021/7/26 15:28, Min Hu (Connor) 写道: 在 2021/7/26 14:30, Thomas Monjalon 写道: 26/07/2021 02:26, Min Hu (Connor): 在 2021/7/24 19:45, Thomas Monjalon 写道: 10/07/2021 05:50, Min Hu (Connor): This patch adds multi-p

  1   2   >