Re: 回复:[PATCH v1 10/17] net/nbl: bus/pci: introduce get_iova_mode for pci dev

2025-06-13 Thread Stephen Hemminger
On Fri, 13 Jun 2025 10:28:06 +0800 "Kyo.Liu" wrote: > Hello, Stephen: > Thanks for your review. This patch is particularly important for our NBL > driver because our coexistence implementation depends on it. > Unlike RDMA devices that support hardware page table translation, our > hardware req

[PATCH 2/2] latencystats: optimize locking on transmit

2025-06-12 Thread Stephen Hemminger
If transmit callback is called, and there are no packets in the burst with timestamp set, then the expensive operations of locking and accessing TSC can be skipped. Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 17 + 1 file changed, 13 insertions

[PATCH 1/2] latencystats: fix receive sample MP issues

2025-06-12 Thread Stephen Hemminger
move to rte_cycles.h? Signed-off-by: Stephen Hemminger Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats") Cc: sta...@dpdk.org --- lib/latencystats/rte_latencystats.c | 47 ++--- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/lib/la

[PATCH 0/2] Latencystat optimization and fix

2025-06-12 Thread Stephen Hemminger
After investigating latencystat test failures, discovered it poorly designed to handle bursts and multiple queues. Stephen Hemminger (2): latencystats: fix receive sample MP issues latencystats: optimize locking on transmit lib/latencystats/rte_latencystats.c | 64

Re: [PATCH v1 02/17] net/nbl: add simple probe/remove and log module

2025-06-12 Thread Stephen Hemminger
On Thu, 12 Jun 2025 08:58:23 + Kyo Liu wrote: > diff --git a/drivers/net/nbl/nbl_include/nbl_include.h > b/drivers/net/nbl/nbl_include/nbl_include.h > new file mode 100644 > index 00..1697f50a75 > --- /dev/null > +++ b/drivers/net/nbl/nbl_include/nbl_include.h > @@ -0,0 +1,53 @@ > +/

Re: [PATCH v1 00/17] NBL PMD for Nebulamatrix NICs

2025-06-12 Thread Stephen Hemminger
On Thu, 12 Jun 2025 08:58:21 + Kyo Liu wrote: > This nbl PMD (**librte_net_nbl**) provides poll mode driver for > NebulaMatrix serials NICs. > > Features: > - > - MTU update > - promisc mode set > - xstats > - Basic stats > > Support NICs: > - > - S1205CQ-A00CHT > - S1

Re: [PATCH v1 10/17] net/nbl: bus/pci: introduce get_iova_mode for pci dev

2025-06-12 Thread Stephen Hemminger
On Thu, 12 Jun 2025 08:58:31 + Kyo Liu wrote: > I propose this patch for DPDK to enable coexistence between > DPDK and kernel drivers for regular NICs.This solution requires > adding a new pci_ops in rte_pci_driver, through which DPDK will > retrieve the required IOVA mode from the vendor dri

Re: [PATCH v1 00/17] NBL PMD for Nebulamatrix NICs

2025-06-12 Thread Stephen Hemminger
On Thu, 12 Jun 2025 08:58:21 + Kyo Liu wrote: > This nbl PMD (**librte_net_nbl**) provides poll mode driver for > NebulaMatrix serials NICs. > > Features: > - > - MTU update > - promisc mode set > - xstats > - Basic stats > > Support NICs: > - > - S1205CQ-A00CHT > - S1

[PATCH] more replace memcpy with structure assignment

2025-06-11 Thread Stephen Hemminger
Prefer using simple structure assignment instead of memcpy. Using a structure assignment preserves type information and compiler checks types already. Signed-off-by: Stephen Hemminger --- Reran cocci script against -rc1 and did minor replacement of "*&" drivers/common/sfc_efx/

Re: [v4 02/10] bus/dpaa: add FMan node

2025-06-11 Thread Stephen Hemminger
On Wed, 11 Jun 2025 12:40:31 +0530 vanshika.shu...@nxp.com wrote: > From: Jun Yang > > Add FMan node(s) and associate FMan to it's interface(port). > This method describes FMan attributes and avoid accessing FMan from > port directly. > Logically, something like IEEE 1588 is FMan global resource

Re: [v4 10/10] bus/dpaa: optimize qman enqueue check

2025-06-11 Thread Stephen Hemminger
On Wed, 11 Jun 2025 12:40:39 +0530 vanshika.shu...@nxp.com wrote: > From: Hemant Agrawal > > This patch improves data access during qman enequeue ring check. > > Signed-off-by: Jun Yang > Signed-off-by: Hemant Agrawal > --- Recheck-request: longarch-unit-testing

Re: [PATCH v4 07/11] net/dpaa2: support dpmac Tx stats

2025-06-11 Thread Stephen Hemminger
On Wed, 11 Jun 2025 16:21:45 +0530 Gagandeep Singh wrote: > From: Apeksha Gupta > > Added all mac counters including Tx stats buckets for > packet sizes. > > Signed-off-by: Apeksha Gupta > Signed-off-by: Vanshika Shukla Spelling error, should get fixed. ### [PATCH] net/dpaa2: support dpmac

Re: [PATCH 00/12] Fixes and supports for Wangxun NICs

2025-06-10 Thread Stephen Hemminger
On Fri, 6 Jun 2025 16:01:05 +0800 Jiawen Wu wrote: > Fix some bugs and improve flow filters. > > Jiawen Wu (12): > net/txgbe: support flow filter for VF > net/txgbe: refactor FDIR filter to improve functionality > net/txgbe: fix reserved extra FDIR headroom > net/txgbe: support RSS offl

Re: [PATCH 00/12] Fixes and supports for Wangxun NICs

2025-06-10 Thread Stephen Hemminger
On Fri, 6 Jun 2025 16:01:05 +0800 Jiawen Wu wrote: > Fix some bugs and improve flow filters. > > Jiawen Wu (12): > net/txgbe: support flow filter for VF > net/txgbe: refactor FDIR filter to improve functionality > net/txgbe: fix reserved extra FDIR headroom > net/txgbe: support RSS offl

[PATCH 1/2] devtools/linux-uapi: conform to kernel headers install

2025-06-10 Thread Stephen Hemminger
later. Want the distro and DPDK header to be exact match. Signed-off-by: Stephen Hemminger --- devtools/linux-uapi.sh | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/devtools/linux-uapi.sh b/devtools/linux-uapi.sh index ccd8b6816e..e739bdb1f4 100755 --- a

[PATCH v8 7/7] test: update to latencystats tests

2025-06-10 Thread Stephen Hemminger
No need for loop and memset() here. Just use structure initialization. Remove unnecessary initializations. Look at the number of samples, min, max and average numbers to make sure they look correct. Forward for longer to make sure multiple samples are taken. Signed-off-by: Stephen Hemminger

[PATCH v8 1/7] latencystats: handle fractional cycles per ns

2025-06-10 Thread Stephen Hemminger
The TSC frequency is not always an integral number of nanoseconds. For examples, cycles per nanoseconds on my test system is 2.8. Fix by using floating point where needed and calculate value once. Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 17 ++--- 1

[PATCH v8 2/7] latencystats: do not use floating point

2025-06-10 Thread Stephen Hemminger
;warm up". Do what RFC 6298 suggests and initialize on first sample. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Konstantin Ananyev --- lib/latencystats/rte_latencystats.c | 127 1 file changed, 72 inserti

[PATCH 0/2] uapi: script and header update

2025-06-10 Thread Stephen Hemminger
Make the script do what "make headers install" does and update existing headers. Stephen Hemminger (2): devtools/linux-uapi: conform to kernel headers install uapi: update headers to 6.15 kernel devtools/linux-uapi.sh | 16 ++-- kernel/linux/uapi/linux/vd

[PATCH 2/2] uapi: update headers to 6.15 kernel

2025-06-10 Thread Stephen Hemminger
The header contents does not change, but version and wrapper ifdef does change. Signed-off-by: Stephen Hemminger --- kernel/linux/uapi/linux/vduse.h | 6 +++--- kernel/linux/uapi/version | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/linux/uapi/linux/vduse.h

[PATCH v8 3/7] latencystats: fix log messages

2025-06-10 Thread Stephen Hemminger
All messages occur because of an error should be at log level NOTICE or above. Do not break log messages across lines. Reword message for the case where getting info about a port fails and it is skipped. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- lib/latencystats

[PATCH v8 5/7] latencystats: enforce that unused callback function is NULL

2025-06-10 Thread Stephen Hemminger
: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c index 1e176492f8..46f1819082 100644 --- a/lib/latencystats/rte_latencystats.c +++ b/lib

Re: [PATCH v1 2/8] net/r8169: update HW configurations for 8125 and 8126

2025-06-10 Thread Stephen Hemminger
On Tue, 10 Jun 2025 14:22:35 +0800 Howard Wang wrote: > Signed-off-by: Howard Wang > --- > drivers/net/r8169/base/rtl8125b.c |4 + > drivers/net/r8169/base/rtl8125bp_mcu.c | 172 +-- > drivers/net/r8169/base/rtl8125d.c | 99 +- > drivers/net/r8169/base/rtl8125d_mcu.c | 1471 ++

[PATCH v8 6/7] latencystats: add metric for number of samples

2025-06-10 Thread Stephen Hemminger
Keeping track of the number of samples is useful when doing debug and testing to make sure that samples are actually happening. Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/lib

[PATCH v8 4/7] latencystats: update include files

2025-06-10 Thread Stephen Hemminger
Include what is used here. Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c index 50043aea72..1e176492f8

[PATCH v8 0/7] latencystats: cleanup and floating point fixes

2025-06-10 Thread Stephen Hemminger
Latencystats uses unnecessary floating point and is inaccurate if the number of cycles per ns is not an integral value. Cleanup the code and add more tests as well. v8 - rebase to 25.07-rc1 Stephen Hemminger (7): latencystats: handle fractional cycles per ns latencystats: do not use floating

Re: [PATCH v9 0/3] net/macb: updated net macb driver

2025-06-09 Thread Stephen Hemminger
On Fri, 6 Jun 2025 09:05:14 + Wencheng Li wrote: > v9: > - Added RTE_PMD_REGISTER_KMOD_DEP macro to > declare dependency on macb_uio kernel module. > - The source link for the macb_uio module > can be found in macb.rst. > > v8: > - Delete log level reset code. > - Delete code that links t

Re: [PATCH 1/3] net/hns3: fix the hardware GRO function is abnormal

2025-06-09 Thread Stephen Hemminger
On Mon, 9 Jun 2025 21:06:49 +0800 Dengdui Huang wrote: > + rem = dma_addr & (HNS3_RX_DMA_ADDR_ALIGN_128 - 1); > + if ((rx_offload & RTE_ETH_RX_OFFLOAD_TCP_LRO) && rem > 0) { > + hns3_err(hw, "Hardware GRO is not supported when mbuf DMA " > + "address is 64

Re: [PATCH 00/11] NXP DPAA2 driver enhancements and fixes

2025-06-09 Thread Stephen Hemminger
On Fri, 30 May 2025 12:43:33 +0530 Gagandeep Singh wrote: > This patch series introduces enhancements and fixes to the > NXP DPAA2 Ethernet driver. > It includes support for > - software taildrop on ordered queues. > - setup speed capabilities. > - DPAA2 resource version. > - MAC level stati

[RFC] doc: change recommendation for installation of tools on Fedora

2025-06-08 Thread Stephen Hemminger
The syntax changed with Fedora 41 and the old command is now: $ sudo dnf group install development-tools Not sure what is on RHEL 9 or later. Signed-off-by: Stephen Hemminger --- doc/guides/howto/af_xdp_dp.rst| 2 +- doc/guides/linux_gsg/sys_reqs.rst | 2 +- 2 files changed, 2 insertions

[PATCH] uapi: update to 6.15 for vduse.h

2025-06-08 Thread Stephen Hemminger
Use the header as produced by the kernel: $ make headers_install So that it exact match to what would be in distros and other tools. Signed-off-by: Stephen Hemminger --- kernel/linux/uapi/linux/vduse.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/linux/uapi

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-08 Thread Stephen Hemminger
On Fri, 6 Jun 2025 15:52:08 -0600 Schneide wrote: > diff --git a/lib/pcapng/rte_pcapng.h b/lib/pcapng/rte_pcapng.h > index 48f2b57564..9880d415c4 100644 > --- a/lib/pcapng/rte_pcapng.h > +++ b/lib/pcapng/rte_pcapng.h > @@ -71,6 +71,8 @@ rte_pcapng_close(rte_pcapng_t *self); > * The handle to

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-08 Thread Stephen Hemminger
On Fri, 6 Jun 2025 15:52:08 -0600 Schneide wrote: > From: Dylan Schneider > > Allow the user to specify protocol link type when creating pcapng files. > This change is needed to specify the protocol type in the pcapng file, > DLT_EN10MB specifies ethernet packets only. This will allow dissecto

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-08 Thread Stephen Hemminger
On Fri, 6 Jun 2025 15:52:08 -0600 Schneide wrote: > From: Dylan Schneider > > Allow the user to specify protocol link type when creating pcapng files. > This change is needed to specify the protocol type in the pcapng file, > DLT_EN10MB specifies ethernet packets only. This will allow dissecto

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-08 Thread Stephen Hemminger
On Fri, 6 Jun 2025 15:52:08 -0600 Schneide wrote: > +RTE_VERSION_SYMBOL(25, int, rte_pcapng_add_interface, > + (rte_pcapng_t *self, uint16_t port, > +const char *ifname, const char *ifdescr, > +const ch

Re: Question regarding rte_hash_hash and rte_hash_add_key_with_hash_data

2025-06-08 Thread Stephen Hemminger
On Sun, 8 Jun 2025 00:36:02 +0530 venkatesh bs wrote: > Hi @dpdk community, > > In my application, I am using the dpdk hash table as below. > > 1. calculate the hash value. > 2. using this signature add the key and data into a table. > 3. lock is used in the 2nd call (add). > > Below is the c

Re: [PATCH 02/12] net/txgbe: refactor FDIR filter to improve functionality

2025-06-06 Thread Stephen Hemminger
On Fri, 6 Jun 2025 16:01:07 +0800 Jiawen Wu wrote: > There were some defects in the original configuration for flow director > filter. Now make the following improvements: > > 1) Fix incorrect parsing to ntuple filter when set the pattern likes: >flow create ... ipv4 / udp dst is ... / raw

Re: [PATCH v9 1/3] net/macb: add new poll mode driver

2025-06-06 Thread Stephen Hemminger
On Fri, 6 Jun 2025 09:06:10 + Wencheng Li wrote: > +static int macb_get_speed_info(struct rte_eth_dev *dev, char *speed_info) > +{ > + char filename[PATH_MAX]; > + char *s; > + struct macb_priv *priv = dev->data->dev_private; > + > + if (!speed_info) { > + MACB_LO

Re: [PATCH v9 0/3] net/macb: updated net macb driver

2025-06-06 Thread Stephen Hemminger
On Fri, 6 Jun 2025 09:05:14 + Wencheng Li wrote: > v9: > - Added RTE_PMD_REGISTER_KMOD_DEP macro to > declare dependency on macb_uio kernel module. > - The source link for the macb_uio module > can be found in macb.rst. > > v8: > - Delete log level reset code. > - Delete code that links t

Re: [PATCH v2 1/1] ethdev: add support to provide link type

2025-06-06 Thread Stephen Hemminger
On Fri, 6 Jun 2025 11:54:52 +0200 Morten Brørup wrote: > > From: sk...@marvell.com [mailto:sk...@marvell.com] > > Sent: Friday, 6 June 2025 11.28 > > > > From: Sunil Kumar Kori > > > > Adding link type parameter to provide the type > > of port like twisted pair, fibre etc. > > > > Also added

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-06 Thread Stephen Hemminger
On Thu, 5 Jun 2025 17:02:37 -0600 Schneide wrote: > > +RTE_VERSION_SYMBOL(25, int, rte_pcapng_add_interface, > + (rte_pcapng_t *self, uint16_t port, > +const char *ifname, const char *ifdescr, > +cons

Re: [PATCH] ethdev: add support to provide link type

2025-06-05 Thread Stephen Hemminger
On Thu, 5 Jun 2025 17:01:51 +0530 wrote: > From: Sunil Kumar Kori > > As a port can be configured at one of the supported speed > which can be part of specific link mode. > > Port type helps to translate speed into the respective mode. > > Hence add support to provide link type as part of lin

[PATCH] net/tap: remove unnecessary pragma unroll

2025-06-04 Thread Stephen Hemminger
Current versions of clang and BPF verifier no longer need an explicit unroll pragma. Signed-off-by: Stephen Hemminger --- drivers/net/tap/bpf/tap_rss.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/tap/bpf/tap_rss.c b/drivers/net/tap/bpf/tap_rss.c index a76f4bfcb3..6a1c3761b7

Re: [PATCH] net/tap: do not force inline or unroll

2025-06-04 Thread Stephen Hemminger
On Wed, 04 Jun 2025 11:27:18 +0200 Thomas Monjalon wrote: > 24/04/2025 18:07, Stephen Hemminger: > > The BPF code in TAP device was using outdated advice on how > > to write BPF programs. Modern BPF verifier has to do less work > > if force inlining and unrolling is not do

Re: [PATCH v9 1/2] ethdev: support RSS based on RoCEv2 header

2025-06-04 Thread Stephen Hemminger
On Thu, 29 May 2025 21:13:42 +0530 wrote: > From: Kiran Kumar K > > On supporting hardware, RoCEv2 header can be used to > perform RSS in the ingress path. > > Signed-off-by: Kiran Kumar K > --- > V9 Changes: > * Fix checkpatch warnings. > V8 Changes: > * Fixed doc > V7 Changes; > * Addressed

Re: [PATCH v2 2/2] app/testpmd: sort commands by help string

2025-06-04 Thread Stephen Hemminger
On Fri, 23 May 2025 11:36:05 +0100 Anatoly Burakov wrote: > When using '?' to find commands, it occasionally is difficult to find the > needed commands because all commands are not in alphabetical order, but > rather can be ordered rather arbitrarily. > > To address this, use help string to orde

Re: [PATCH v2 05/11] net/dpaa2: add dpmac MC header file

2025-06-04 Thread Stephen Hemminger
On Mon, 2 Jun 2025 16:10:35 +0530 Gagandeep Singh wrote: > From: Apeksha Gupta > > This patch upgrades the MC firmware release API compatibility > to 10.39.0. Added mc/fsl_dpmac.h file. > > Signed-off-by: Apeksha Gupta > --- > drivers/net/dpaa2/mc/fsl_dpmac.h | 490 +

Re: [RFC 00/18] add hinic3 PMD driver

2025-06-03 Thread Stephen Hemminger
On Fri, 18 Apr 2025 17:05:46 +0800 Feifei Wang wrote: > *** BLURB HERE *** > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support > for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. > > Feifei Wang (3): > net/hinic3: add intro doc for hinic3 > net/hinic3: add

Re: ethdev use from secondary process

2025-06-03 Thread Stephen Hemminger
On Mon, 2 Jun 2025 14:35:04 -0600 Ashish Sadanandan wrote: > Hi everyone, > I'm trying to use a secondary process to rx/tx packets through a NIC and > running into segfaults due to some data structures not being populated on > the secondary. I've figured out a solution, but it involves the use of

Re: [PATCH] pcapng: allow any protocol link type for the interface block

2025-05-29 Thread Stephen Hemminger
Full list of types is here https://www.tcpdump.org/linktypes.html On Thu, May 29, 2025, 10:16 Schneide wrote: > From: Dylan Schneider > > Allow the user to specify protocol link type when creating pcapng files. > This change is needed to specify the protocol type in the pcapng file, > DLT_EN10M

Re: [PATCH] pcapng: allow any protocol link type for the interface block

2025-05-29 Thread Stephen Hemminger
What other packet types would a DPDK app use. The possible type fields are quite limited see the spec. Plus it would be an ABI breakage would require versioning. On Thu, May 29, 2025, 10:16 Schneide wrote: > From: Dylan Schneider > > Allow the user to specify protocol link type when creating p

[PATCH] doc: update ABI reference version in example

2025-05-28 Thread Stephen Hemminger
The example should list current ABI reference version. Signed-off-by: Stephen Hemminger --- doc/guides/contributing/patches.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst index 8ad6b6e715

Re: [v1 01/10] bus/dpaa: avoid using same structure and variable name

2025-05-28 Thread Stephen Hemminger
On Wed, 28 May 2025 17:25:04 +0530 vanshika.shu...@nxp.com wrote: > From: Hemant Agrawal > > rte_dpaa_bus was being used as structure and variable name both. > > Signed-off-by: Jun Yang > Signed-off-by: Hemant Agrawal > --- That is perfectly ok in C. Would prefer that you not use rte_ for va

Re: [dpdk-dev] Regarding HQOS with run-to-completion Model

2025-05-27 Thread Stephen Hemminger
On Tue, 27 May 2025 21:09:57 +0530 farooq basha wrote: > Thanks Stephen. > > While browsing the DPDK qos code, i figured out that existing > PIPE-PROFILE cannot be updated or deleted at run time. > Was there any reason why this limitation ? My understanding was that the original au

Re: [PATCH v2 1/2] ethdev: remove unnecessary type conversion

2025-05-27 Thread Stephen Hemminger
On Mon, 12 May 2025 20:37:19 +0530 wrote: > /**@{@name Rx hardware descriptor states > diff --git a/lib/ethdev/rte_ethdev_core.h b/lib/ethdev/rte_ethdev_core.h > index e55fb42996..4ffae4921a 100644 > --- a/lib/ethdev/rte_ethdev_core.h > +++ b/lib/ethdev/rte_ethdev_core.h > @@ -45,7 +45,7 @@ type

Re: [PATCH v7 0/3] net/macb: updated net macb driver

2025-05-27 Thread Stephen Hemminger
On Fri, 18 Apr 2025 03:24:34 + Wencheng Li wrote: > v7: > - Use a legal name instead of an email alias. > - Do not use additional __rte_cold. > - Replace unsigned long with standard uint64_t. > - Describe the devargs used by the driver in the documentation. > - Update macb.ini. > > v6: > - F

Re: [PATCH v4] vhost: fix crash caused by accessing a freed vsocket

2025-05-26 Thread Stephen Hemminger
On Mon, 8 Jul 2024 12:41:03 +0800 Gongming Chen wrote: > diff --git a/lib/vhost/vhost_thread.c b/lib/vhost/vhost_thread.c > new file mode 100644 > index 00..f3ff182976 > --- /dev/null > +++ b/lib/vhost/vhost_thread.c > @@ -0,0 +1,33 @@ > +#include > + > +#include "vhost_thread.h" > + >

Re: [PATCH v4 1/3] net: fix GTP packet parsing

2025-05-26 Thread Stephen Hemminger
On Fri, 23 May 2025 10:55:55 +0800 Dengdui Huang wrote: > After parsing the GTP packet header, the next protocol type should > be converted from RTE_GTP_TYPE_IPV4/IPV6 to RTE_ETHER_TYPE_IPV4/IPV6. > Otherwise, the next protocol cannot be parsed. > > Bugzilla ID: 1672 > Fixes: 64ed7f854cf4 ("net:

Re: [PATCH v2 1/2] app/testpmd: harmonize case in help strings

2025-05-26 Thread Stephen Hemminger
On Fri, 23 May 2025 11:36:04 +0100 Anatoly Burakov wrote: > Most testpmd help strings are lower case. Amend those that aren't. > > Signed-off-by: Anatoly Burakov Why does DPDK not follow the convention used for years by the Unix man pages and commands? The Unix command description style is to

Re: [PATCH v3 0/7] net/ena: release 2.13.0

2025-05-26 Thread Stephen Hemminger
On Mon, 26 May 2025 14:13:27 + "Brandes, Shai" wrote: > Hi Stephen, and apologies for the multiple patchsets. > > We had a bug in our CI that prevented failed runs from showing up correctly > in the report, this has just been identified and fixed. > While rechecking, we discovered that one

Re: [PATCH v5 1/1] examples/l2fwd-jobstats: fix lock availability

2025-05-24 Thread Stephen Hemminger
On Sun, 11 Aug 2024 21:29:57 +0530 Rakesh Kudurumalla wrote: > Race condition between jobstats and time metrics > for forwarding and flushing is maintained using spinlock. > Timer metrics are not displayed properly due to the > frequent unavailability of the lock.This patch fixes > the issue by i

Re: [PATCH v5 2/3] cmdline: add floating point support

2025-05-23 Thread Stephen Hemminger
On Fri, 23 May 2025 12:21:15 +0200 "Burakov, Anatoly" wrote: > On 5/21/2025 4:05 PM, Stephen Hemminger wrote: > > On Wed, 7 May 2025 16:22:11 +0100 > > Anatoly Burakov wrote: > > > >> +NUMERIC_TYPES = { > >> +"UINT8": &

Re: [dpdk-dev] Regarding HQOS with run-to-completion Model

2025-05-22 Thread Stephen Hemminger
On Thu, 22 May 2025 08:15:14 +0530 farooq basha wrote: > Thanks Stephen for addressing my queries , and it is helpful. > > One more follow up question on the same , Can DPDK HQOS be customized > based on Use case ? > > For example: Hqos config for one of the use cases , *One Port , O

Re: [PATCH v1 2/2] app/testpmd: sort commands by help string

2025-05-21 Thread Stephen Hemminger
On Wed, 14 May 2025 14:02:12 +0100 Anatoly Burakov wrote: > When using '?' to find commands, it occasionally is difficult to find the > needed commands because all commands are not in alphabetical order, but > rather can be ordered rather arbitrarily. > > To address this, use help string to orde

[PATCH] net/bnxt: fix free of not allocated object

2025-05-21 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/tf_core/v3/tfo.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/tf_core/v3/tfo.c b/drivers/net/bnxt/tf_core/v3/tfo.c index bee813ebf6..c888dd1e4e 100644 --- a/drivers/net/bnxt/tf_core/v3/tfo.c +++

Re: [PATCH v1] net/virtio-user: implement MAC setting for Vhost-kernel

2025-05-21 Thread Stephen Hemminger
On Wed, 21 May 2025 16:23:05 +0200 Maxime Coquelin wrote: > iff --git a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c > b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c > index 611e2e25ec..3e13f8f65b 100644 > --- a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c > +++ b/drivers/net/virt

Re: [dpdk-dev] Regarding HQOS with run-to-completion Model

2025-05-21 Thread Stephen Hemminger
On Mon, 28 Apr 2025 16:55:07 +0530 farooq basha wrote: > Hello DevTeam, > > I am planning to use DPDK HQOS for Traffic shaping with a > run-to-completion Model. While I was reading the dpdk-qos document, I came > across the following statement. > > "*Running enqueue and dequeue operations f

Re: [PATCH v5 2/3] cmdline: add floating point support

2025-05-21 Thread Stephen Hemminger
On Wed, 7 May 2025 16:22:11 +0100 Anatoly Burakov wrote: > +NUMERIC_TYPES = { > +"UINT8": "uint8_t", > +"UINT16": "uint16_t", > +"UINT32": "uint32_t", > +"UINT64": "uint64_t", > +"INT8": "int8_t", > +"INT16": "int16_t", > +"INT32": "int32_t", > +"INT64": "int64_t"

Re: [PATCH v2] ethdev: optimize how the values of the flag variables are assigned

2025-05-21 Thread Stephen Hemminger
On Wed, 21 May 2025 18:15:31 +0800 Sunyang Wu wrote: > Set the values of the promiscuous and all_multicast variables > according to the return value. > > Signed-off-by: Morten Brørup > Signed-off-by: Sunyang Wu > --- > lib/ethdev/rte_ethdev.c | 11 +-- > 1 file changed, 5 insertions(+

Re: [PATCH 1/2] net: fix offset calculation for GENEVE packet

2025-05-20 Thread Stephen Hemminger
On Mon, 19 May 2025 21:36:55 +0530 wrote: > From: Sunil Kumar Kori > > While parsing packet headers, offset must be added to get next > header but for geneve header parsing offset is overwritten. > Also inner_l2_len is not set in case of geneve packets. > > Fixes: 64ed7f854cf4 ("net: add tunne

Re: [PATCH 2/2] app/testpmd: clear stale internal len information

2025-05-20 Thread Stephen Hemminger
On Mon, 19 May 2025 21:36:56 +0530 wrote: > From: Sunil Kumar Kori > > hdr_lens is used to maintain header lengths after parsing packets. > When port receives different type of packets (say first is VXLAN > packet and second is GRE packet). > > For first packet, L2/L3/L4 lengths are set for in

Re: [PATCH] net/mlx5: fix transceiver warning when not exist

2025-05-20 Thread Stephen Hemminger
On Mon, 5 May 2025 12:14:51 + Yogev Chaimovich wrote: > From ffe666291bc531b89620cc28a7b45fa209700f35 Mon Sep 17 00:00:00 2001 > From: yogev > Date: Sun, 4 May 2025 23:11:46 +0300 > Subject: [PATCH] net/mlx5: fix transceiver warning when not exist > > In case no transceiver exist when tryin

Re: [PATCH] bus/pci: introduce get_iova_mode for pci dev

2025-05-20 Thread Stephen Hemminger
On Thu, 24 Apr 2025 12:34:09 + Kyo Liu wrote: > I propose this patch for DPDK to enable coexistence between > DPDK and kernel drivers for regular NICs.This solution requires > adding a new pci_ops in rte_pci_driver, through which DPDK will > retrieve the required IOVA mode from the vendor dri

Re: [PATCH v5 2/3] cmdline: add floating point support

2025-05-20 Thread Stephen Hemminger
On Wed, 7 May 2025 16:22:11 +0100 Anatoly Burakov wrote: > Add support for parsing floating point numbers in cmdline library, as well > as unit tests for the new functionality. Use C library for parsing. > > Signed-off-by: Anatoly Burakov This looks good, please resolve the checkpatch warning

Re: [PATCH] net/tap: fix add qdisc failed when create tap

2025-05-20 Thread Stephen Hemminger
On Mon, 12 May 2025 16:22:04 +0800 luyan <973788...@qq.com> wrote: > From: luyan > > The errno variable was assigned a positive value in the previous handling, > but here it is compared against -EEXIST, > When the tap already exists, this would falsely report an error. > > Signed-off-by: luyan

Re: [PATCH] ethdev: optimize how the values of the flag variables are assigned

2025-05-20 Thread Stephen Hemminger
eck the flag to determine whether the corresponding disable > operation needs to be executed. If the flag is set before the operation is > completed, the driver will not execute the operation when it checks the flag, > as it will find that the flag has already been set. > > 发件人:

Re: [RFC 00/18] add hinic3 PMD driver

2025-05-20 Thread Stephen Hemminger
On Fri, 18 Apr 2025 15:02:38 +0800 Feifei Wang wrote: > *** BLURB HERE *** > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support > for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. > > Feifei Wang (3): > net/hinic3: add intro doc for hinic3 > net/hinic3: add

Re: [RFC 01/18] net/hinic3: add intro doc for hinic3

2025-05-20 Thread Stephen Hemminger
On Fri, 18 Apr 2025 15:02:39 +0800 Feifei Wang wrote: > diff --git a/doc/guides/rel_notes/release_25_07.rst > b/doc/guides/rel_notes/release_25_07.rst > index 093b85d206..1d65cf7829 100644 > --- a/doc/guides/rel_notes/release_25_07.rst > +++ b/doc/guides/rel_notes/release_25_07.rst > @@ -24,37 +

Re: [PATCH v6 1/2] ethdev: support RSS based on RoCEv2 header

2025-05-20 Thread Stephen Hemminger
On Mon, 5 May 2025 11:27:15 +0530 wrote: > @@ -149,6 +151,7 @@ const struct rss_type_info rss_type_table[] = { > { "l3-dst-only", RTE_ETH_RSS_L3_DST_ONLY }, > { "l3-src-only", RTE_ETH_RSS_L3_SRC_ONLY }, > { "ipv6-flow-label", RTE_ETH_RSS_IPV6_FLOW_LABEL }, > + { "ib_bth", RTE

Re: [PATCH 1/1] net/nbl add doc and minimun nbl build framework

2025-05-20 Thread Stephen Hemminger
On Thu, 24 Apr 2025 11:49:19 + Kyo Liu wrote: > Signed-off-by: Kyo Liu > diff --git a/MAINTAINERS b/MAINTAINERS > index 9b8bb60023..4cf891a312 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1020,6 +1020,15 @@ F: drivers/net/sfc/ > F: doc/guides/nics/sfc_efx.rst > F: doc/guides/nics/

Re: [RFC PATCH v4 3/3] ethdev: introduce the cache stashing hints API

2025-05-20 Thread Stephen Hemminger
On Sat, 17 May 2025 15:17:35 + Wathsala Vithanage wrote: > Extend the ethdev library to enable the stashing of different data > objects, such as the ones listed below, into CPU caches directly > from the NIC. > > - Rx/Tx queue descriptors > - Rx packets > - Packet headers > - packet payloads

Re: [Bug Report] KNI Module Causes Loopback Interface to Have Incorrect ifindex in Linux 5.4.46

2025-05-20 Thread Stephen Hemminger
On Wed, 23 Apr 2025 13:52:39 +0800 nan he wrote: > Dear DPDK Developers, > > I am reporting an issue encountered in an environment running Linux kernel > version 5.4.46 with DPDK 19.11. When attempting to run Docker containers in > bridge mode, the container creation fails consistently. The kmsg

Re: [PATCH 2/4] uapi: import VDUSE header from v6.14 kernel

2025-05-20 Thread Stephen Hemminger
On Wed, 16 Apr 2025 14:34:24 +0200 Maxime Coquelin wrote: > This header will be used by the Vhost library. > > Signed-off-by: Maxime Coquelin > --- > kernel/linux/uapi/linux/vduse.h | 353 > kernel/linux/uapi/version | 2 +- > 2 files changed, 354 inser

Re: [PATCH v5 1/2] lib/fib: remove warning about implicit 64-bit conversion

2025-05-17 Thread Stephen Hemminger
Ok. Wonder if RTE_PTR_ADD should have the cast there instead On Sat, May 17, 2025, 05:45 Andre Muezerie wrote: > MSVC issues the warning below: > > ../lib/fib/trie.c(341): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > > The fix is

Re: [PATCH] ethdev: optimize how the values of the flag variables are assigned

2025-05-07 Thread Stephen Hemminger
Why bother? This is not critical path. Original code looked fine On Thu, May 8, 2025, 11:34 Sunyang Wu wrote: > Set the values of the promiscuous and all_multicast variables > according to the return value. > > Signed-off-by: Sunyang Wu > --- > lib/ethdev/rte_ethdev.c | 9 +++-- > 1 file c

Re: [PATCH 3/3] eal/linux: Check hugepage access permissions

2025-05-07 Thread Stephen Hemminger
Please don't split message a across multiple lines. Open and access are not the same in all security checks, so not a great idea. Some analyzer tools may flag as time of check, time of use issue. On Wed, May 7, 2025, 02:50 Jake Freeland wrote: > Currently, hugepage mountpoints will be used irres

Re: [PATCH v1 1/1] app/testpmd: add sleep command

2025-05-02 Thread Stephen Hemminger
On Fri, 2 May 2025 13:27:29 +0100 Anatoly Burakov wrote: > @@ -13701,6 +13735,7 @@ static cmdline_parse_ctx_t builtin_ctx[] = { > &cmd_help_brief, > &cmd_help_long, > &cmd_quit, > + &cmd_sleep, > &cmd_load_from_file, > &cmd_showport, > &cmd_showqueue, > --

Re: [PATCH v3 1/4] eal: deprecate old coremask-based EAL parameters

2025-05-02 Thread Stephen Hemminger
On Fri, 2 May 2025 16:11:31 +0100 Bruce Richardson wrote: > As the number of cores/cpus on platforms has increased over the years, > the use of coremasks rather than core-lists for identifying DPDK cores > has become more and more unwieldy. At this point, let's deprecate the > coremask-based EAL

rte_control event API?

2025-05-01 Thread Stephen Hemminger
There was recent discussions about drivers creating control threads. The current drivers that use rte_thread_create_internal_control keeps growing, but it got me looking at if this could be done better. Rather than having multiple control threads which have potential conflicts, why not add a new

Re: Thread priority for background tasks

2025-04-30 Thread Stephen Hemminger
On Wed, 30 Apr 2025 20:40:52 +0200 Morten Brørup wrote: > There are only two thread priorities in the enum rte_thread_priority: Normal > and Real-time Critical. > > I would like to poll ethdev counters, collect garbage and perform other > jitter non-sensitive tasks in a control thread with low

Re: Regarding Mellanox bifurcated driver on Azure

2025-04-30 Thread Stephen Hemminger
On Wed, 30 Apr 2025 22:00:29 +0530 Prashant Upadhyaya wrote: > On Wed, 30 Apr 2025 at 19:58, Stephen Hemminger > wrote: > > > On Wed, 30 Apr 2025 13:00:53 +0530 > > Prashant Upadhyaya wrote: > > > > > > With DPDK on Azure, an application should never u

Re: [PATCH v7 2/4] lib: fix comparison between devices

2025-04-30 Thread Stephen Hemminger
a comprehensive overview. Can you take a look? > > Thank you! > > https://docs.google.com/document/d/1LmMlJ31P1G77K0TGkBfXWz0DEj6zdprP0bG5p_wu77w/edit?usp=sharing > > > > -Original Message- > > From: Stephen Hemminger > > Sent: Monday, 17 March 2025 16:1

Re: Regarding Mellanox bifurcated driver on Azure

2025-04-30 Thread Stephen Hemminger
On Wed, 30 Apr 2025 13:00:53 +0530 Prashant Upadhyaya wrote: > > With DPDK on Azure, an application should never use the VF directly. > > It needs to use either netvsc PMD which handles both the vmbus (slow path) > > and VF (fast path) combined. Or use the older vdev_netvsc/failsafe/tap > > combi

Re: [PATCH v1 24/25] net/ntnic: avoid possible deadlock

2025-04-30 Thread Stephen Hemminger
On Wed, 30 Apr 2025 15:48:36 +0200 Oleksandr Kolomeiets wrote: > From: Danylo Vodopianov > > Sometimes during high flow learn performance two threads > could cause deadlock using queue and mutex. > > learn_ignored variable sets when flow learn and gets > when flow removes. Hence, learn_ignore

Re: [PATCH] ethdev: remove callback checks from fast path

2025-04-29 Thread Stephen Hemminger
On Tue, 29 Apr 2025 23:41:30 +0530 wrote: > > +static inline void > +rte_eth_set_dummy_fops(struct rte_eth_dev *eth_dev) Not fastpath, do not add inline here > +{ > + eth_dev->rx_pkt_burst = rte_eth_pkt_burst_dummy; > + eth_dev->tx_pkt_burst = rte_eth_pkt_burst_dummy; > + eth_dev-

Re: [PATCH] ethdev: remove callback checks from fast path

2025-04-29 Thread Stephen Hemminger
On Tue, 29 Apr 2025 23:41:30 +0530 wrote: > @@ -7131,14 +7118,11 @@ rte_eth_tx_queue_count(uint16_t port_id, uint16_t > queue_id) > goto out; > } > #endif > - if (fops->tx_queue_count == NULL) { > - rc = -ENOTSUP; > - goto out; > - } > - >

Re: Regarding Mellanox bifurcated driver on Azure

2025-04-29 Thread Stephen Hemminger
On Tue, 29 Apr 2025 21:45:36 +0530 Prashant Upadhyaya wrote: > On Mon, 28 Apr 2025 at 21:07, Stephen Hemminger > wrote: > > > On Mon, 28 Apr 2025 11:31:10 +0530 > > Prashant Upadhyaya wrote: > > > > > On Sat, 26 Apr 2025 at 20:58, Stephen Hemmin

Re: [PATCH v2 1/2] ethdev: support RSS based on RoCEv2 header

2025-04-29 Thread Stephen Hemminger
On Tue, 29 Apr 2025 15:22:41 +0530 wrote: > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index e89af21cec..444e4b0388 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -89,67 +89,69 @@ static const struct { > > const struct rss_type_info rss_type_table[] =

Re: [PATCH v3 1/1] bus/pci: introduce get_iova_mode for pci dev

2025-04-28 Thread Stephen Hemminger
On Sun, 27 Apr 2025 02:27:34 + Kyo Liu wrote: > I propose this patch for DPDK to enable coexistence between > DPDK and kernel drivers for regular NICs.This solution requires > adding a new pci_ops in rte_pci_driver, through which DPDK will > retrieve the required IOVA mode from the vendor dri

Re: Regarding Mellanox bifurcated driver on Azure

2025-04-28 Thread Stephen Hemminger
On Mon, 28 Apr 2025 11:31:10 +0530 Prashant Upadhyaya wrote: > On Sat, 26 Apr 2025 at 20:58, Stephen Hemminger > wrote: > > > On Fri, 25 Apr 2025 23:17:30 +0530 > > Prashant Upadhyaya wrote: > > > > > Hi, > > > > > > I am having a VM

  1   2   3   4   5   6   7   8   9   10   >