> -Original Message-
> From: Yigit, Ferruh
> Sent: Monday, May 10, 2021 10:32 AM
> To: Wang, Haiyue ; Yang, Qiming
> ; Zhang, Qi Z ; Stillwell Jr,
> Paul
> M ; Lu, Wenzhuo ;
> Rong, Leyi ; Shukla, Shivanshu
>
> Cc: dev@dpdk.org; sta...@dpdk.org; K
See my responses inline.
Paul
> -Original Message-
> From: Zhang, Qi Z
> Sent: Saturday, March 14, 2020 6:50 PM
> To: Stillwell Jr, Paul M ; Wang, Haiyue
> ; dev@dpdk.org; Ye, Xiaolong
> ; Yang, Qiming ; Xing,
> Beilei
> Cc: Zhao1, Wei ; Wang, Haiyue
> ; Lian
u are calling iavf
functions from within the ice PMD which seems wrong to me.
Paul
> -Original Message-
> From: Wang, Haiyue
> Sent: Friday, March 13, 2020 10:05 AM
> To: Stillwell Jr, Paul M ; dev@dpdk.org; Ye,
> Xiaolong ; Zhang, Qi Z ;
> Yang, Qiming ; Xing, B
ate from the ice PMD and it seems like DCF should also be
separate.
Paul
> -Original Message-
> From: Wang, Haiyue
> Sent: Friday, March 13, 2020 9:25 AM
> To: Stillwell Jr, Paul M ; dev@dpdk.org; Ye,
> Xiaolong ; Zhang, Qi Z ;
> Yang, Qiming ; Xing, Beilei
>
I'm confused. Shouldn't the DCF be a separate driver since it is a VF, not part
of a PF? You are starting to combine PF/VF code and I'm not sure if that is the
correct way to go.
Paul
> -Original Message-
> From: dev On Behalf Of Haiyue Wang
> Sent: Monday, March 9, 2020 11:50 PM
> To:
> -Original Message-
> From: dev On Behalf Of wei.zh...@intel.com
> Sent: Thursday, March 12, 2020 6:04 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z ; Ye, Xiaolong
> ; sta...@dpdk.org; Zhao1, Wei
>
> Subject: [dpdk-dev] [PATCH 5/7] net/ice: change default tunnle type
>
> The default tunnle
This patch set is confusing to me. Only the DCF can deal with switch rules so
why is the ice PMD trying to do anything with switch rules related to DCF?
Paul
> -Original Message-
> From: dev On Behalf Of wei.zh...@intel.com
> Sent: Thursday, March 12, 2020 6:04 PM
> To: dev@dpdk.org
> C
NACK, this code is not properly stripped and should not be released externally.
Additionally, APF is NOT released and is only for Mt Evans and should not be in
the code.
Paul
> -Original Message-
> From: dev On Behalf Of Xiaolong Ye
> Sent: Sunday, December 1, 2019 11:49 PM
> To: Xing,
NACK, this code is not properly stripped and should not be released externally.
Additionally, the commit message shouldn't mention anything about wrapping the
code so if you want to include this you will need to re-write the commit
message to make sense without mentioning wrapping the code.
Pau
NACK, no code names in public commit messages.
Paul
> -Original Message-
> From: dev On Behalf Of Xiaolong Ye
> Sent: Sunday, December 1, 2019 11:49 PM
> To: Xing, Beilei ; Zhang, Qi Z
> Cc: dev@dpdk.org; Ye, Xiaolong ; Azarewicz, Piotr
>
> Subject: [dpdk-dev] [PATCH 35/69] net/i40e/ba
> -Original Message-
> From: dev On Behalf Of Qi Zhang
> Sent: Thursday, November 14, 2019 7:42 PM
> To: Ye, Xiaolong
> Cc: dev@dpdk.org; Zhang, Qi Z
> Subject: [dpdk-dev] [PATCH v2] net/ice: add flow mark hint support
>
> Since not all data paths support flow mark, the driver need a
Disregard my previous email, I didn't see this one. See my comments inline.
Paul
> -Original Message-
> From: dev On Behalf Of Simei Su
> Sent: Wednesday, November 6, 2019 12:26 AM
> To: Zhang, Qi Z ; Ye, Xiaolong ;
> Yang, Qiming
> Cc: dev@dpdk.org; Su, Simei
> Subject: [dpdk-dev] [PA
Can you provide more details on how this fixes the issue? Looking at the code,
the pointer *parser should get set by the code so I'm not sure how this change
does anything.
Paul
> -Original Message-
> From: dev On Behalf Of Simei Su
> Sent: Tuesday, November 5, 2019 11:09 PM
> To: Zhan
> -Original Message-
> From: dev On Behalf Of Qi Zhang
> Sent: Tuesday, November 5, 2019 10:07 PM
> To: Yang, Qiming
> Cc: dev@dpdk.org; Zhang, Qi Z
> Subject: [dpdk-dev] [PATCH v3] net/ice/base: fix wrong ptype bitmap for GRE
>
> The ptype bitmap calculation for GRE packet is modifie
> -Original Message-
> From: dev On Behalf Of Qiming Yang
> Sent: Sunday, November 3, 2019 9:40 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo ; Yang, Qiming
> ; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ice: fix link status recovery
>
> This patch fix a kernel driver link status issue b
Hi Xiaolong,
> -Original Message-
> From: dev On Behalf Of Ye Xiaolong
> Sent: Monday, October 28, 2019 10:35 PM
> To: Zhang, Qi Z
> Cc: Yang, Qiming ; dev@dpdk.org;
> sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ice: fix unexpected link down
>
> Hi, Qi
>
> On 10/29, Qi Zhang
NAK, this is not true for ice.
Paul
> -Original Message-
> From: dev On Behalf Of Yang, Qiming
> Sent: Monday, October 14, 2019 6:49 PM
> To: Min, JiaqiX ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: add known issue for ice
>
>
> > -Original Message-
> > From: Min, Jiaq
> -Original Message-
> From: dev On Behalf Of Ying Wang
> Sent: Tuesday, September 3, 2019 3:15 PM
> To: Zhang, Qi Z
> Cc: Ye, Xiaolong ; Yang, Qiming
> ; dev@dpdk.org; Wang, Ying A
> ; Zhao1, Wei
> Subject: [dpdk-dev] [PATCH 1/4] net/ice: add devargs to control pipeline
> mode
>
> From
> -Original Message-
> From: dev On Behalf Of Ting Xu
> Sent: Thursday, August 29, 2019 6:18 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo ; Yang, Qiming
> ; Zhang, Qi Z
> Subject: [dpdk-dev] [PATCH v1] net/ice: support device-specific DDP package
> loading
>
> This patch adds the feature that
> -Original Message-
> From: dev On Behalf Of Xiaolong Ye
> Sent: Friday, July 26, 2019 9:44 AM
> To: Yigit, Ferruh ; Xing, Beilei
> ; Zhang, Qi Z
> Cc: dev@dpdk.org; Ye, Xiaolong
> Subject: [dpdk-dev] [PATCH v2 02/11] net/i40e: replace license text with
> SPDX tag
>
> Signed-off-by: Xi
> -Original Message-
> From: dev On Behalf Of Xiaolong Ye
> Sent: Friday, July 26, 2019 2:30 AM
> To: Yigit, Ferruh ; Lu, Wenzhuo
>
> Cc: dev@dpdk.org; Ye, Xiaolong
> Subject: [dpdk-dev] [PATCH v1 03/11] net/e1000: replace license text with
> SPDX tag
>
> Signed-off-by: Xiaolong Ye
> -
> -Original Message-
> From: dev On Behalf Of Xiaolong Ye
> Sent: Friday, July 26, 2019 2:30 AM
> To: Yigit, Ferruh ; Lu, Wenzhuo
> ; Ananyev, Konstantin
>
> Cc: dev@dpdk.org; Ye, Xiaolong
> Subject: [dpdk-dev] [PATCH v1 01/11] net/ixgbe: replace license text with
> SPDX tag
>
> Signed-
> -Original Message-
> From: dev On Behalf Of Xiaolong Ye
> Sent: Friday, July 26, 2019 2:30 AM
> To: Yigit, Ferruh ; Xing, Beilei
> ; Zhang, Qi Z
> Cc: dev@dpdk.org; Ye, Xiaolong
> Subject: [dpdk-dev] [PATCH v1 02/11] net/i40e: replace license text with
> SPDX tag
>
> Signed-off-by:
> -Original Message-
> From: dev On Behalf Of Xiao Zhang
> Sent: Friday, July 19, 2019 4:00 AM
> To: dev@dpdk.org
> Cc: Xing, Beilei ; Wang, Haiyue
> ; Zhang, Qi Z ; Zhang, Xiao
> ; sta...@dpdk.org
> Subject: [dpdk-dev] [v4] net/i40e: fix SFP X722 not work with FW4.16
>
> The code check
> -Original Message-
> From: dev On Behalf Of Wei Zhao
> Sent: Friday, June 21, 2019 1:22 AM
> To: dev@dpdk.org
> Cc: Zhao1, Wei
> Subject: [dpdk-dev] [PATCH v5] net/ice: enable switch filter
>
> From: wei zhao
>
> The patch enables the backend of rte_flow. It transfers rte_flow_xxx to
> -Original Message-
> From: Rong, Leyi
> Sent: Tuesday, June 11, 2019 8:52 AM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Rong, Leyi ; Stillwell Jr, Paul M
>
> Subject: [PATCH v2 30/66] net/ice/base: add some minor features
>
> 1. Disable TX pacing option.
>
> -Original Message-
> From: Rong, Leyi
> Sent: Tuesday, June 11, 2019 8:52 AM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Rong, Leyi ; Stillwell Jr, Paul M
>
> Subject: [PATCH v2 27/66] net/ice/base: add some minor features
>
> 1. Add loopback reporting to
> -Original Message-
> From: Rong, Leyi
> Sent: Tuesday, June 11, 2019 8:52 AM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Rong, Leyi ; Keller, Jacob E
> ; Stillwell Jr, Paul M
>
> Subject: [PATCH v2 24/66] net/ice/base: add support for reading REPC
>
> -Original Message-
> From: Rong, Leyi
> Sent: Tuesday, June 11, 2019 8:52 AM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Rong, Leyi ; Nguyen, Anthony L
> ; Stillwell Jr, Paul M
>
> Subject: [PATCH v2 21/66] net/ice/base: add helper functions for PHY caching
>
&g
> -Original Message-
> From: Rong, Leyi
> Sent: Tuesday, June 11, 2019 8:52 AM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Rong, Leyi ; Nowlin, Dan
> ; Stillwell Jr, Paul M
> Subject: [PATCH v2 17/66] net/ice/base: add API to init FW logging
>
> In order to initi
> -Original Message-
> From: Maxime Coquelin
> Sent: Friday, June 7, 2019 5:41 AM
> To: Stillwell Jr, Paul M ; Rong, Leyi
> ; Zhang, Qi Z
> Cc: dev@dpdk.org; Nowlin, Dan
> Subject: Re: [dpdk-dev] [PATCH 47/49] net/ice/base: enable additional
> switch rules
>
> -Original Message-
> From: Maxime Coquelin
> Sent: Wednesday, June 5, 2019 3:35 AM
> To: Rong, Leyi ; Zhang, Qi Z
> Cc: dev@dpdk.org; Sridhar, Vignesh ; Stillwell Jr,
> Paul M
> Subject: Re: [dpdk-dev] [PATCH 14/49] net/ice/base: refactor HW table init
> funct
> -Original Message-
> From: Maxime Coquelin
> Sent: Wednesday, June 5, 2019 5:24 AM
> To: Rong, Leyi ; Zhang, Qi Z
> Cc: dev@dpdk.org; Nowlin, Dan ; Stillwell Jr, Paul M
>
> Subject: Re: [dpdk-dev] [PATCH 47/49] net/ice/base: enable additional
> switch rules
&
> -Original Message-
> From: Maxime Coquelin
> Sent: Wednesday, June 5, 2019 9:28 AM
> To: Stillwell Jr, Paul M ; Rong, Leyi
> ; Zhang, Qi Z
> Cc: dev@dpdk.org; Raj, Victor
> Subject: Re: [dpdk-dev] [PATCH 07/49] net/ice/base: replay advanced rule
> after reset
&
> -Original Message-
> From: Maxime Coquelin
> Sent: Wednesday, June 5, 2019 8:59 AM
> To: Stillwell Jr, Paul M ; Rong, Leyi
> ; Zhang, Qi Z
> Cc: dev@dpdk.org; Raj, Victor
> Subject: Re: [dpdk-dev] [PATCH 07/49] net/ice/base: replay advanced rule
> after reset
&
> -Original Message-
> From: Maxime Coquelin
> Sent: Wednesday, June 5, 2019 1:59 AM
> To: Rong, Leyi ; Zhang, Qi Z
> Cc: dev@dpdk.org; Raj, Victor ; Stillwell Jr, Paul M
>
> Subject: Re: [dpdk-dev] [PATCH 07/49] net/ice/base: replay advanced rule
> after reset
&
There will be a newer version of this patch that removes this code.
Paul
> -Original Message-
> From: Venkataramanan, Anirudh
> Sent: Tuesday, June 4, 2019 12:17 PM
> To: Zhang, Qi Z ; Rong, Leyi
> Cc: Stillwell Jr, Paul M ; dev@dpdk.org
> Subject: Re: [PATCH 42/49] ne
> -Original Message-
> From: Maxime Coquelin
> Sent: Tuesday, June 4, 2019 10:15 AM
> To: Rong, Leyi ; Zhang, Qi Z
> Cc: dev@dpdk.org; Cao, Chinh T ; Ertman, David M
> ; Stillwell Jr, Paul M
>
> Subject: Re: [dpdk-dev] [PATCH 03/49] net/ice/base: add API to confi
> -Original Message-
> From: dev On Behalf Of Igor Russkikh
> Sent: Monday, May 6, 2019 4:22 AM
> To: Ido Goshen ; Ananyev, Konstantin
> ; Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support
>
>
> >>>
> >>> The hw->allow_unsupported
> -Original Message-
> From: dev On Behalf Of Qi Zhang
> Sent: Saturday, May 4, 2019 2:46 AM
> To: Lu, Wenzhuo ; Yang, Qiming
>
> Cc: Stokes, Ian ; Yigit, Ferruh
> ;
> dev@dpdk.org; Zhang, Qi Z
> Subject: [dpdk-dev] [PATCH] net/ice: set min and max MTU
>
> This commit sets the min an
> -Original Message-
> From: Wang, Haiyue
> Sent: Tuesday, April 30, 2019 10:19 AM
> To: Stillwell Jr, Paul M ; dev@dpdk.org; Zhang,
> Qi Z ; Lu, Wenzhuo
> Subject: RE: [dpdk-dev] [PATCH v1] net/ice: add link-up and link-down
> functions
>
> > -
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Haiyue Wang
> Sent: Tuesday, April 30, 2019 12:12 AM
> To: dev@dpdk.org; Zhang, Qi Z ; Lu, Wenzhuo
>
> Cc: Wang, Haiyue
> Subject: [dpdk-dev] [PATCH v1] net/ice: add link-up and link-down functions
>
> Support
> -Original Message-
> From: dev On Behalf Of Wei Zhao
> Sent: Friday, March 29, 2019 1:16 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo ; sta...@dpdk.org; Zhang, Qi Z
> ; Zhao1, Wei
> Subject: [dpdk-dev] [PATCH v2] net/ixgbe: enable 10Mb/s link setup for x553
>
> There is need to eanble 10M
> -Original Message-
> From: dev On Behalf Of Qiming Yang
> Sent: Sunday, March 24, 2019 7:30 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z ; Yang, Qiming
>
> Subject: [dpdk-dev] [PATCH v5 0/3] enable package download in ice driver
>
> This patch set enabled package downloading to the device
> -Original Message-
> From: dev On Behalf Of Wei Zhao
> Sent: Monday, March 18, 2019 8:05 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei
>
> Subject: [dpdk-dev] [PATCH] net/iavf: fix vertor interrupt number
> configuration error
>
Should the patch name be net/a
NACK, see comments below
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang
> Sent: Friday, March 1, 2019 4:46 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming
> Subject: [dpdk-dev] [PATCH 1/2] net/ice: suppport package download
>
> Columbiaville requires a p
Hi Qiming,
For some reason I am not seeing patch 1/2 in this series. Can you make sure you
sent it or re-send it?
Paul
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang
Sent: Friday, March 1, 2019 4:46 AM
To: dev@dpdk.org
Cc: Yang, Qiming
Subject: [dpd
> There is need to enble CLEARPBA bit for ice NIC of A0/A1 version in order to
> enable admin queue interrupt in avf mode.
Minor nit: You misspelled enable above
Your patch description says we should be checking dev_conf.rxmode.offloads
should be checked to enable VLAN, but I don't see the patch checking for that.
What am I missing?
Paul
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao
Sent: Tuesday, February 12,
ruh
Sent: Wednesday, December 12, 2018 7:19 AM
To: Lu, Wenzhuo ; dev@dpdk.org
Cc: Stillwell Jr, Paul M
Subject: Re: [dpdk-dev] [PATCH v3 02/34] net/ice: Add basic structures
On 12/12/2018 6:59 AM, Wenzhuo Lu wrote:
> From: Paul M Stillwell Jr
>
> Add the structures required by the NIC.
>
&
50 matches
Mail list logo
