RE: [PATCH] doc: update link to DevX integration on Windows

2024-03-07 Thread Tal Shnaiderman
idia.com/networking/display/winof2v290/devx+interface> > `_. > The minimal supported WinOF2 version is 2.60. > > > -- > 2.25.1 Acked-by: Tal Shnaiderman

[PATCH v2 1/3] net/mlx5: support multi-packet RQ on Windows

2023-05-16 Thread Tal Shnaiderman
and can by enabled by setting mprq_en=1 in the PMD specific arguments. Signed-off-by: Tal Shnaiderman Tested-by: Pier Damouny Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c| 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h| 2 ++ drivers/common/mlx5/windows

[PATCH v2 3/3] net/mlx5: support enhanced multi-packet write on Windows

2023-05-16 Thread Tal Shnaiderman
mpw_en unset(default) - enhanced multi packet write will be activated if supported. if unsupported the multi packet write feature is disabled. Signed-off-by: Tal Shnaiderman Tested-by: Pier Damouny Acked-by: Matan Azrad --- doc/guides/rel_notes/release_23_07.rst | 33 -

[PATCH v2 2/3] net/mlx5: support CQE compression on Windows

2023-05-16 Thread Tal Shnaiderman
-off-by: Tal Shnaiderman Tested-by: Pier Damouny Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/net/mlx5/windows/mlx5_os.c | 12 3 files changed, 15 insertions(+) diff --git a/drivers/common/mlx5

[PATCH v2 0/3] Windows performance enhancements

2023-05-16 Thread Tal Shnaiderman
The following series enables support of 3 hardware offloads on Windows which improve PMD throughput. RX throughput improvements: **Multi-packet RQ. **CQE compression. TX throughput improvement: **Multi packet send. --- v2: * Add tags --- Tal Shnaiderman (3): net/mlx5: support multi-packet

[PATCH 3/3] net/mlx5: support enhanced multi-packet write on Windows

2023-05-03 Thread Tal Shnaiderman
mpw_en unset(default) - enhanced multi packet write will be activated if supported. if unsupported the multi packet write feature is disabled. Signed-off-by: Tal Shnaiderman --- doc/guides/rel_notes/release_23_07.rst | 33 - drivers/common/mlx5/mlx5_devx_cmds.c | 6 ++

[PATCH 2/3] net/mlx5: support CQE compression on Windows

2023-05-03 Thread Tal Shnaiderman
-off-by: Tal Shnaiderman --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/net/mlx5/windows/mlx5_os.c | 12 3 files changed, 15 insertions(+) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5

[PATCH 1/3] net/mlx5: support multi-packet RQ on Windows

2023-05-03 Thread Tal Shnaiderman
and can by enabled by setting mprq_en=1 in the PMD specific arguments. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/mlx5_devx_cmds.c| 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h| 2 ++ drivers/common/mlx5/windows/mlx5_win_defs.h | 8 +++- drivers/net/mlx5/windows

[PATCH 0/3] Windows performance enhancements

2023-05-03 Thread Tal Shnaiderman
The following series enables support of 3 hardware offloads on Windows which improve PMD throughput. RX throughput improvements: **Multi-packet RQ. **CQE compression. TX throughput improvement: **Multi packet send. Tal Shnaiderman (3): net/mlx5: support multi-packet RQ on Windows net/mlx5

RE: [PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling

2023-03-12 Thread Tal Shnaiderman
> Subject: Re: [PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling > > External email: Use caution opening links or attachments > > > 19/02/2023 18:53, Stephen Hemminger: > > On Fri, 3 Feb 2023 11:14:06 -0800 > > Stephen Hemminger wrote: > > > > > This patchset keeps uncovering b

RE: [PATCH v3 3/3] net/mlx5: fix Windows build with MinGW GCC 12

2023-03-08 Thread Tal Shnaiderman
dpdk.org > > > > Signed-off-by: Thomas Monjalon > > --- > > lgtm > > Acked-by: Tyler Retzlaff Acked-by: Tal Shnaiderman

RE: [PATCH v3 2/3] net/mlx5: remove weak stub functions

2023-03-08 Thread Tal Shnaiderman
er to understand, > > and the weak attributes can be removed. > > > > This change helps to compile with MinGW GCC which has no support for > > weak functions. > > > > Signed-off-by: Thomas Monjalon > > --- > > Acked-by: Tyler Retzlaff Acked-by: Tal Shnaiderman

RE: [PATCH v3 1/3] common/mlx5: get Windows dependency from standard variables

2023-03-08 Thread Tal Shnaiderman
7;, 'import os; > print(os.environ["DEVX_INC_PATH"])', check: false) > - > -if (res_lib.returncode() != 0 or res_inc.returncode() != 0) > -build = false > -reason = 'DevX environment variables are not set, DEVX_LIB_PATH and > DEVX_INC_PATH vars must be exported' > -subdir_done() > -endif > - > -devx_lib_dir = res_lib.stdout().strip() -devx_inc_dir = > res_inc.stdout().strip() > - > -ext_deps += cc.find_library('mlx5devx', dirs: devx_lib_dir, required: true) - > includes += include_directories(devx_inc_dir) cflags_options = [ > '-std=c11', > '-Wno-strict-prototypes', > -- > 2.39.1 Acked-by: Tal Shnaiderman

[PATCH] net/mlx5: fix thread termination check on Windows

2022-10-11 Thread Tal Shnaiderman
The mlx5_is_thread_alive function always returns false (terminated) regardless to the actual thread state. Fixed to return the correct thread state. Bugzilla ID: 1089 Fixes: 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS") Cc: sta...@dpdk.org Signed-off-by: Tal S

[RFC PATCH 1/3] net/mlx5: support multi-packet RQ on Windows

2022-04-12 Thread Tal Shnaiderman
and can by enabled by setting mprq_en=1 in the PMD specific arguments. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/mlx5_devx_cmds.c| 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h| 2 ++ drivers/common/mlx5/windows/mlx5_win_defs.h | 7 +++ drivers/net/mlx5/windows

[RFC PATCH 0/3] Windows performance enhancements

2022-04-12 Thread Tal Shnaiderman
The following series enables support of 3 hardware offloads on Windows which improve PMD throughput. RX throughput improvements: **Multi-packet RQ. **CQE compression. TX throughput improvement: **Multi packet send. Tal Shnaiderman (3): net/mlx5: support multi-packet RQ on Windows net/mlx5

[RFC PATCH 2/3] net/mlx5: support CQE compression on Windows

2022-04-12 Thread Tal Shnaiderman
-off-by: Tal Shnaiderman --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/net/mlx5/windows/mlx5_os.c | 8 3 files changed, 11 insertions(+) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index

[RFC PATCH 3/3] net/mlx5: support enhanced multi-packet write on Windows

2022-04-12 Thread Tal Shnaiderman
mpw_en unset(default) - enhanced multi packet write will be activated if supported. if unsupported the multi packet write feature is disabled. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/mlx5_devx_cmds.c | 6 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++ drivers/net/mlx5/wind

RE: [PATCH v3] app/testpmd: fix show RSS RETA on Windows

2022-03-13 Thread Tal Shnaiderman
return -1; > } > for (i = 0; i < ret; i++) > - conf[i].mask = (uint64_t)strtoul(str_fld[i], &end, 0); > + conf[i].mask = (uint64_t)strtoull(str_fld[i], &end, 0); > > return 0; > } > -- > 2.16.1.windows.4 Acked-by: Tal Shnaiderman

RE: [PATCH] net/mlx5: fix destroying empty matchers list

2022-02-23 Thread Tal Shnaiderman
_list_destroy(tbl_data->matchers); > + if (tbl_data->matchers) > + mlx5_list_destroy(tbl_data->matchers); > mlx5_ipool_free(sh->ipool[MLX5_IPOOL_JUMP], tbl_data->idx); } > > -- > 2.16.1.windows.4 Acked-by: Tal Shnaiderman

RE: [PATCH] eal/windows: set pthread affinity

2022-01-31 Thread Tal Shnaiderman
/* Initialize services so drivers can register services during probe. > */ > -- > 2.31.1.windows.1 Acked-by: Tal Shnaiderman

[PATCH] net/mlx5: support the imissed counter on Windows

2021-12-23 Thread Tal Shnaiderman
Add support for the imissed counter using the DevX API on Windows. imissed is queried by creating a queue counter for the port, attaching it to all created RQs and querying the "out_of_buffer" field. If the counter cannot be created, imissed will always report 0. Signed-off-by: Tal S

Re: [dpdk-dev] [EXT] [PATCH v3 5/5] crypto/mlx5: support on Windows

2021-10-27 Thread Tal Shnaiderman
> Subject: RE: [EXT] [PATCH v3 5/5] crypto/mlx5: support on Windows > > External email: Use caution opening links or attachments > > > > Add support for mlx5 crypto pmd on Windows OS. > > Add changes to release note and pmd guide. > > > > Signed-off-b

[dpdk-dev] [PATCH v3 3/5] crypto/mlx5: fix size of UMR WQE

2021-10-25 Thread Tal Shnaiderman
ambiguity the allocation size will be calculated by the sizes of the members excluding the flexible union. Fixes: a1978aa23bf4 ("crypto/mlx5: add maximum segments configuration") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_cr

[dpdk-dev] [PATCH v3 5/5] crypto/mlx5: support on Windows

2021-10-25 Thread Tal Shnaiderman
Add support for mlx5 crypto pmd on Windows OS. Add changes to release note and pmd guide. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- doc/guides/cryptodevs/mlx5.rst | 15 --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/common/mlx5

[dpdk-dev] [PATCH v3 4/5] build: check Windows support per driver

2021-10-25 Thread Tal Shnaiderman
Remove the check and build failure from crypto/meson.build in case building for Windows OS. Add this check/failure in the meson.build file of each crypto PMD that is not enforcing it to allow PMD support for Windows per driver when applicable. Signed-off-by: Tal Shnaiderman Acked-by: Matan

[dpdk-dev] [PATCH v3 2/5] crypto/mlx5: modify unix pthread code

2021-10-25 Thread Tal Shnaiderman
Remove the usage of PTHREAD_MUTEX_INITIALIZER which is not support in Windows and initialize priv_list_lock in RTE_INIT. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers

[dpdk-dev] [PATCH v3 0/5] Support MLX5 crypto driver on Windows

2021-10-25 Thread Tal Shnaiderman
r mlx5 only and the rest of the drivers [AkhilG] --- Tal Shnaiderman (5): common/mlx5: add DV enums to Windows defs file crypto/mlx5: modify unix pthread code crypto/mlx5: fix size of UMR WQE build: check Windows support per driver crypto/mlx5: support on Windows doc/guides/cryp

[dpdk-dev] [PATCH v3 1/5] common/mlx5: add DV enums to Windows defs file

2021-10-25 Thread Tal Shnaiderman
Add needed DV enums used by the crypto PMD and missing for Windows OS. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/windows/mlx5_win_defs.h | 12 1 file changed, 12 insertions(+) diff --git a/drivers/common/mlx5/windows/mlx5_win_defs.h b/drivers

[dpdk-dev] [PATCH v2 5/6] build: have Windows support checked per driver

2021-10-17 Thread Tal Shnaiderman
Remove the check and build failure in case of Windows OS from crypto/meson.build to the meson.build file of each crypto PMD to allow PMD support on this OS per driver. Signed-off-by: Tal Shnaiderman --- drivers/crypto/aesni_gcm/meson.build | 6 ++ drivers/crypto/aesni_mb/meson.build | 6

[dpdk-dev] [PATCH v2 6/6] crypto/mlx5: support on Windows

2021-10-17 Thread Tal Shnaiderman
Add support for mlx5 crypto pmd on Windows OS. Add changes to release note and pmd guide. Signed-off-by: Tal Shnaiderman --- doc/guides/cryptodevs/mlx5.rst | 15 --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/common/mlx5/version.map | 2

[dpdk-dev] [PATCH v2 5/6] build: check Windows support per driver

2021-10-17 Thread Tal Shnaiderman
Remove the check and build failure from crypto/meson.build in case building for Windows OS. Add this check/failure in the meson.build file of each crypto PMD that is not enforcing it to allow PMD support for Windows per driver when applicable. Signed-off-by: Tal Shnaiderman --- drivers/crypto

[dpdk-dev] [PATCH v2 1/6] common/mlx5: add DV enums to Windows defs file

2021-10-17 Thread Tal Shnaiderman
Add needed DV enums used by the crypto PMD and missing for Windows OS. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/windows/mlx5_win_defs.h | 12 1 file changed, 12 insertions(+) diff --git a/drivers/common/mlx5/windows/mlx5_win_defs.h b/drivers

[dpdk-dev] [PATCH v2 0/6] Support MLX5 crypto driver on Windows

2021-10-17 Thread Tal Shnaiderman
Support the MLX5 crypto driver on Windows OS by moving the driver's control path communication with the Kernel to be OS agnostic. --- Depends-on: series-19421 ("mlx5: sharing global MR cache between drivers") v2: Split build change for mlx5 only and the rest of the drivers [A

[dpdk-dev] [PATCH v2 3/6] crypto/mlx5: use OS agnostic functions for UMEM operations

2021-10-17 Thread Tal Shnaiderman
use the functions mlx5_os_umem_reg, mlx5_os_umem_dereg mlx5_os_get_umem_id instead of the glue functions to support UMEM operations on all OSs. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 8 drivers/crypto/mlx5/mlx5_crypto.h | 2 +- 2

[dpdk-dev] [PATCH v2 2/6] crypto/mlx5: replace UNIX functions with EAL functions

2021-10-17 Thread Tal Shnaiderman
Use the OS agnostic EAL function rte_mem_page_size to get page size value instead of the Linux specific implementation. Also remove the usage of PTHREAD_MUTEX_INITIALIZER which is not support in Windows and initialize priv_list_lock in RTE_INIT. Signed-off-by: Tal Shnaiderman Acked-by: Matan

[dpdk-dev] [PATCH v2 4/6] crypto/mlx5: fix size of UMR WQE

2021-10-17 Thread Tal Shnaiderman
ambiguity the allocation size will be calculated by the sizes of the members excluding the flexible union. Fixes: a1978aa23bf4 ("crypto/mlx5: add maximum segments configuration") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_cr

Re: [dpdk-dev] [EXT] [PATCH 5/5] crypto/mlx5: support on Windows

2021-10-17 Thread Tal Shnaiderman
> Subject: RE: [EXT] [PATCH 5/5] crypto/mlx5: support on Windows > > External email: Use caution opening links or attachments > > > > Add support for mlx5 crypto pmd on Windows OS. > > Add changes to release note and pmd guide. > > > > Signed-off-by: T

Re: [dpdk-dev] [PATCH v4] cryptodev: add telemetry callbacks

2021-10-13 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH v4] cryptodev: add telemetry callbacks > > External email: Use caution opening links or attachments > > > The cryptodev library now registers commands with telemetry, and > implements the corresponding callback functions. These commands allow a > list of cryptodevs t

Re: [dpdk-dev] [PATCH] doc: add table of supported operating systems for cryptodevs

2021-10-12 Thread Tal Shnaiderman
todevs > > External email: Use caution opening links or attachments > > > Added table to the crypto device drivers documentation stating the support > of each PMD on Linux, FreeBSD and Windows. > > Signed-off-by: Tal Shnaiderman > --- > Depends-on: series-19563 (&quo

[dpdk-dev] [PATCH] doc: add table of supported operating systems for cryptodevs

2021-10-12 Thread Tal Shnaiderman
Added table to the crypto device drivers documentation stating the support of each PMD on Linux, FreeBSD and Windows. Signed-off-by: Tal Shnaiderman --- Depends-on: series-19563 ("Support MLX5 crypto driver on Windows") --- doc/guides/conf.py | 5 +

[dpdk-dev] [PATCH 3/5] crypto/mlx5: use OS agnostic functions for UMEM operations

2021-10-12 Thread Tal Shnaiderman
use the functions mlx5_os_umem_reg, mlx5_os_umem_dereg mlx5_os_get_umem_id instead of the glue functions to support UMEM operations on all OSs. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 8 drivers/crypto/mlx5/mlx5_crypto.h | 2 +- 2

[dpdk-dev] [PATCH 0/5] Support MLX5 crypto driver on Windows

2021-10-12 Thread Tal Shnaiderman
Support the MLX5 crypto driver on Windows OS by moving the driver's control path communication with the Kernel to be OS agnostic. --- Depends-on: series-19421 ("mlx5: sharing global MR cache between drivers") --- Tal Shnaiderman (5): common/mlx5: add DV enums to Windows defs fil

[dpdk-dev] [PATCH 1/5] common/mlx5: add DV enums to Windows defs file

2021-10-12 Thread Tal Shnaiderman
Add needed DV enums used by the crypto PMD and missing for Windows OS. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/windows/mlx5_win_defs.h | 12 1 file changed, 12 insertions(+) diff --git a/drivers/common/mlx5/windows/mlx5_win_defs.h b/drivers

[dpdk-dev] [PATCH 5/5] crypto/mlx5: support on Windows

2021-10-12 Thread Tal Shnaiderman
Add support for mlx5 crypto pmd on Windows OS. Add changes to release note and pmd guide. Signed-off-by: Tal Shnaiderman --- doc/guides/cryptodevs/mlx5.rst | 15 --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/common/mlx5/version.map | 2

[dpdk-dev] [PATCH 2/5] crypto/mlx5: replace UNIX functions with EAL functions

2021-10-12 Thread Tal Shnaiderman
Use the OS agnostic EAL function rte_mem_page_size to get page size value instead of the Linux specific implementation. Also remove the usage of PTHREAD_MUTEX_INITIALIZER which is not support in Windows and initialize priv_list_lock in RTE_INIT. Signed-off-by: Tal Shnaiderman Acked-by: Matan

[dpdk-dev] [PATCH 4/5] crypto/mlx5: fix size of UMR WQE

2021-10-12 Thread Tal Shnaiderman
ambiguity the allocation size will be calculated by the sizes of the members excluding the flexible union. Fixes: a1978aa23bf4 ("crypto/mlx5: add maximum segments configuration") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_cr

[dpdk-dev] [PATCH v2 10/13] net/mlx5: support VLAN stripping offload on Windows

2021-10-12 Thread Tal Shnaiderman
Support of the VLAN stripping offloading by checking the relevant FW capability (vlan_cap) for NIC support. Supported offload: DEV_RX_OFFLOAD_VLAN_STRIP Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/net/mlx5/windows/mlx5_flow_os.h | 1 + drivers

[dpdk-dev] [PATCH v2 11/13] common/mlx5: read FCS scattering capability from DevX

2021-10-12 Thread Tal Shnaiderman
mlx5 in Windows needs the hca capability scatter_fcs to query the NIC support for the CRC keeping offload. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/common/mlx5

[dpdk-dev] [PATCH v2 09/13] common/mlx5: read VLAN capability from DevX

2021-10-12 Thread Tal Shnaiderman
mlx5 in Windows needs the hca capability vlan_cap to query the NIC for VLAN stripping support Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/common/mlx5/mlx5_devx_cmds.c

[dpdk-dev] [PATCH v2 13/13] doc: add new Windows offloads to the release note

2021-10-12 Thread Tal Shnaiderman
Added the new Windows supported offload to the 21.11 release note. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- doc/guides/rel_notes/release_21_11.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes

[dpdk-dev] [PATCH v2 08/13] net/mlx5: support TSO offload on Windows

2021-10-12 Thread Tal Shnaiderman
Support of the TSO offloading by checking the relevant FW capability for NIC support. Supported offloads: DEV_TX_OFFLOAD_TCP_TSO DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon

[dpdk-dev] [PATCH v2 07/13] common/mlx5: read TSO capability from DevX

2021-10-12 Thread Tal Shnaiderman
mlx5 in Windows needs the hca capability max_lso_cap to query the NIC for TSO offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/common/mlx5

[dpdk-dev] [PATCH v2 12/13] net/mlx5: support keep-CRC offload on Windows

2021-10-12 Thread Tal Shnaiderman
Support of the keep-CRC offloading by checking the relevant FW capability (scatter_fcs) for NIC support. Supported offload: DEV_RX_OFFLOAD_KEEP_CRC Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/net/mlx5/windows/mlx5_os.c | 1 + 1 file changed, 1

[dpdk-dev] [PATCH v2 05/13] common/mlx5: read tunneling capabilities from DevX

2021-10-12 Thread Tal Shnaiderman
mlx5 in Windows needs the tunneling hca capabilities to query the NIC for Inner TSO offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/common/mlx5

[dpdk-dev] [PATCH v2 04/13] net/mlx5: fix tunneling support query

2021-10-12 Thread Tal Shnaiderman
ffload DEV_TX_OFFLOAD_GENEVE_TNL_TSO can be enabled. The fix enables the offloads according to the correct flags returned by the kernel. Fixes: dbccb4cddcd2f7c ("net/mlx5: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon

[dpdk-dev] [PATCH v2 06/13] net/mlx5: query tunneling support on Windows

2021-10-12 Thread Tal Shnaiderman
Query tunneling supported on the NIC. Save the offloads values in a config parameter. This is needed for the following TSO support: DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan

[dpdk-dev] [PATCH v2 02/13] common/mlx5: read software parsing capabilities from DevX

2021-10-12 Thread Tal Shnaiderman
mlx5 in Windows needs the software parsing hca capabilities to query the NIC for TSO and Checksum offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers

[dpdk-dev] [PATCH v2 01/13] net/mlx5: fix software parsing support query

2021-10-12 Thread Tal Shnaiderman
SO from the standard one") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/net/mlx5/linux/mlx5_os.c | 3 ++- drivers/net/mlx5/linux/mlx5_os.h | 12 drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH v2 03/13] net/mlx5: query software parsing support on Windows

2021-10-12 Thread Tal Shnaiderman
Query software parsing supported on the NIC. Save the offloads values in a config parameter. This is needed for the outer IPv4 checksum and IP and UPD tunneled packet TSO support. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Idan Hackmon --- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH v2 00/13] Expand NIC offloads support on Windows

2021-10-12 Thread Tal Shnaiderman
The series supports a group of NIC offloads on Windows: DEV_TX_OFFLOAD_TCP_TSO DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO DEV_RX_OFFLOAD_VLAN_STRIP DEV_RX_OFFLOAD_KEEP_CRC --- v2: updated 21.11 release note --- Tal Shnaiderman (13): net/mlx5: fix

[dpdk-dev] [PATCH 08/12] net/mlx5: support TSO offload on Windows

2021-10-06 Thread Tal Shnaiderman
Support of the TSO offloading by checking the relevant FW capability for NIC support. Supported offloads: DEV_TX_OFFLOAD_TCP_TSO DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/net/mlx5

[dpdk-dev] [PATCH 07/12] common/mlx5: read TSO capability from DevX

2021-10-06 Thread Tal Shnaiderman
mlx5 in Windows needs the hca capability max_lso_cap to query the NIC for TSO offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers

[dpdk-dev] [PATCH 11/12] common/mlx5: read FCS scattering capability from DevX

2021-10-06 Thread Tal Shnaiderman
mlx5 in Windows needs the hca capability scatter_fcs to query the NIC support for the CRC keeping offload. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2

[dpdk-dev] [PATCH 09/12] common/mlx5: read VLAN capability from DevX

2021-10-06 Thread Tal Shnaiderman
mlx5 in Windows needs the hca capability vlan_cap to query the NIC for VLAN stripping support Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common

[dpdk-dev] [PATCH 10/12] net/mlx5: support VLAN stripping offload on Windows

2021-10-06 Thread Tal Shnaiderman
Support of the VLAN stripping offloading by checking the relevant FW capability (vlan_cap) for NIC support. Supported offload: DEV_RX_OFFLOAD_VLAN_STRIP Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/net/mlx5/windows/mlx5_flow_os.h | 1 + drivers/net/mlx5/windows/mlx5_os.c

[dpdk-dev] [PATCH 06/12] net/mlx5: query tunneling support on Windows

2021-10-06 Thread Tal Shnaiderman
Query tunneling supported on the NIC. Save the offloads values in a config parameter. This is needed for the following TSO support: DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/net/mlx5

[dpdk-dev] [PATCH 12/12] net/mlx5: support keep-CRC offload on Windows

2021-10-06 Thread Tal Shnaiderman
Support of the keep-CRC offloading by checking the relevant FW capability (scatter_fcs) for NIC support. Supported offload: DEV_RX_OFFLOAD_KEEP_CRC Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/net/mlx5/windows/mlx5_os.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[dpdk-dev] [PATCH 05/12] common/mlx5: read tunneling capabilities from DevX

2021-10-06 Thread Tal Shnaiderman
mlx5 in Windows needs the tunneling hca capabilities to query the NIC for Inner TSO offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 6

[dpdk-dev] [PATCH 03/12] net/mlx5: query software parsing support on Windows

2021-10-06 Thread Tal Shnaiderman
Query software parsing supported on the NIC. Save the offloads values in a config parameter. This is needed for the outer IPv4 checksum and IP and UPD tunneled packet TSO support. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c| 16

[dpdk-dev] [PATCH 04/12] net/mlx5: fix tunneling support query

2021-10-06 Thread Tal Shnaiderman
ffload DEV_TX_OFFLOAD_GENEVE_TNL_TSO can be enabled. The fix enables the offloads according to the correct flags returned by the kernel. Fixes: dbccb4cddcd2f7c ("net/mlx5: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/net/mlx5/linux/

[dpdk-dev] [PATCH 01/12] net/mlx5: fix software parsing support query

2021-10-06 Thread Tal Shnaiderman
SO from the standard one") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 3 ++- drivers/net/mlx5/linux/mlx5_os.h | 12 drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_txq.c | 15 +--

[dpdk-dev] [PATCH 02/12] common/mlx5: read software parsing capabilities from DevX

2021-10-06 Thread Tal Shnaiderman
mlx5 in Windows needs the software parsing hca capabilities to query the NIC for TSO and Checksum offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c

[dpdk-dev] [PATCH 00/12] Expand NIC offloads support on Windows

2021-10-06 Thread Tal Shnaiderman
The series supports a group of NIC offloads on Windows: DEV_TX_OFFLOAD_TCP_TSO DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO DEV_RX_OFFLOAD_VLAN_STRIP DEV_RX_OFFLOAD_KEEP_CRC Tal Shnaiderman (12): net/mlx5: fix software parsing support query common

Re: [dpdk-dev] [EXT] [PATCH] cryptodev: build on Windows

2021-10-05 Thread Tal Shnaiderman
> Subject: RE: [EXT] [PATCH] cryptodev: build on Windows > > External email: Use caution opening links or attachments > > > > > Build the cryptography device library on Windows OS by removing > > > unneeded include and exports blocking the compilation. > >

Re: [dpdk-dev] [PATCH 2/2] security: build on Windows

2021-09-30 Thread Tal Shnaiderman
> Subject: Re: [PATCH 2/2] security: build on Windows > > External email: Use caution opening links or attachments > > > On 9/15/2021 9:26 AM, Tal Shnaiderman wrote: > > Build the security library on Windows. > > > > Remove unneeded export from vers

Re: [dpdk-dev] [PATCH] bus/pci: fix numa node return value

2021-09-23 Thread Tal Shnaiderman
RROR_SUCCESS; > } > RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW" > -- > 2.31.1.windows.1 You should add "on Windows" to the end of the patch name to clarity it's a Windows issue. Aside from that LGTM. Acked-by: Tal Shnaiderman

Re: [dpdk-dev] [EXT] [PATCH 1/2] security: use the net library for IP structs

2021-09-16 Thread Tal Shnaiderman
systems. > > > > Signed-off-by: Tal Shnaiderman > > --- > > lib/net/rte_ip.h| 1 + > > lib/security/meson.build| 2 +- > > lib/security/rte_security.h | 5 + > > 3 files changed, 3 insertions(+), 5 deletions(-) > > > >

[dpdk-dev] [PATCH] app/test: enable crypto unit tests on Windows

2021-09-15 Thread Tal Shnaiderman
Enable cryptography unit tests on Windows supported crypto PMDs. Signed-off-by: Tal Shnaiderman --- Depends-on: series-18674 ("app/test: enable subset of tests on Windows") Depends-on: patch-98942 ("security: build on Windows") --- app/test/meson.build | 12 ++-

[dpdk-dev] [PATCH 1/2] security: use the net library for IP structs

2021-09-15 Thread Tal Shnaiderman
Remove the netinet includes and replaces them with rte_ip.h to support the in_addr/in6_addr structs on all operating systems. Signed-off-by: Tal Shnaiderman --- lib/net/rte_ip.h| 1 + lib/security/meson.build| 2 +- lib/security/rte_security.h | 5 + 3 files changed, 3

[dpdk-dev] [PATCH 2/2] security: build on Windows

2021-09-15 Thread Tal Shnaiderman
Build the security library on Windows. Remove unneeded export from version file. Signed-off-by: Tal Shnaiderman --- Depends-on: patch-98796 ("cryptodev: build on Windows") --- lib/meson.build | 1 + lib/security/version.map | 1 - 2 files changed, 1 insertion(+), 1 deletio

[dpdk-dev] [RFC PATCH 07/12] common/mlx5: read TSO capability from DevX

2021-09-15 Thread Tal Shnaiderman
mlx5 in Windows needs the hca capability max_lso_cap to query the NIC for TSO offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h

[dpdk-dev] [RFC PATCH 10/12] net/mlx5: support VLAN stripping offload on Windows

2021-09-15 Thread Tal Shnaiderman
Support of the VLAN stripping offloading by checking the relevant FW capability (vlan_cap) for NIC support. Supported offload: DEV_RX_OFFLOAD_VLAN_STRIP Signed-off-by: Tal Shnaiderman --- drivers/net/mlx5/windows/mlx5_os.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [RFC PATCH 09/12] common/mlx5: read VLAN capability from DevX

2021-09-15 Thread Tal Shnaiderman
mlx5 in Windows needs the hca capability vlan_cap to query the NIC for VLAN stripping support Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1

[dpdk-dev] [RFC PATCH 06/12] net/mlx5: query tunneling support on Windows

2021-09-15 Thread Tal Shnaiderman
Query tunneling supported on the NIC. Save the offloads values in a config parameter. This is needed for the following TSO support: DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO Signed-off-by: Tal Shnaiderman --- drivers/net/mlx5/mlx5.c| 14

[dpdk-dev] [RFC PATCH 05/12] common/mlx5: read tunneling capabilities from DevX

2021-09-15 Thread Tal Shnaiderman
mlx5 in Windows needs the tunneling hca capabilities to query the NIC for Inner TSO offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/mlx5_devx_cmds.c | 6 ++ drivers/common/mlx5

[dpdk-dev] [RFC PATCH 12/12] net/mlx5: support keep-CRC offload on Windows

2021-09-15 Thread Tal Shnaiderman
Support of the keep-CRC offloading by checking the relevant FW capability (scatter_fcs) for NIC support. Supported offload: DEV_RX_OFFLOAD_KEEP_CRC Signed-off-by: Tal Shnaiderman --- drivers/net/mlx5/windows/mlx5_os.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5

[dpdk-dev] [RFC PATCH 11/12] common/mlx5: read FCS scattering capability from DevX

2021-09-15 Thread Tal Shnaiderman
mlx5 in Windows needs the hca capability scatter_fcs to query the NIC support for the CRC keeping offload. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5

[dpdk-dev] [RFC PATCH 03/12] net/mlx5: query software parsing support on Windows

2021-09-15 Thread Tal Shnaiderman
Query software parsing supported on the NIC. Save the offloads values in a config parameter. This is needed for the outer IPv4 checksum and IP and UPD tunneled packet TSO support. Signed-off-by: Tal Shnaiderman --- drivers/net/mlx5/mlx5.c| 16 drivers/net/mlx5/mlx5

[dpdk-dev] [RFC PATCH 08/12] net/mlx5: support TSO offload on Windows

2021-09-15 Thread Tal Shnaiderman
Support of the TSO offloading by checking the relevant FW capability for NIC support. Supported offloads: DEV_TX_OFFLOAD_TCP_TSO DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO Signed-off-by: Tal Shnaiderman --- drivers/net/mlx5/windows/mlx5_os.c | 2

[dpdk-dev] [RFC PATCH 04/12] net/mlx5: fix tunneling support query

2021-09-15 Thread Tal Shnaiderman
ffload DEV_TX_OFFLOAD_GENEVE_TNL_TSO can be enabled. The fix enables the offloads according to the correct flags returned by the kernel. Fixes: dbccb4cddcd2f7c ("net/mlx5: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman --- drivers/net/mlx5/linux/mlx5_os.c | 6 ++

[dpdk-dev] [RFC PATCH 00/12] Expand NIC offloads support on Windows

2021-09-15 Thread Tal Shnaiderman
The series supports a group of NIC offloads on Windows: DEV_TX_OFFLOAD_TCP_TSO DEV_TX_OFFLOAD_VXLAN_TNL_TSO DEV_TX_OFFLOAD_GRE_TNL_TSO DEV_TX_OFFLOAD_GENEVE_TNL_TSO DEV_RX_OFFLOAD_VLAN_STRIP DEV_RX_OFFLOAD_KEEP_CRC Tal Shnaiderman (12): net/mlx5: fix software parsing support query common

[dpdk-dev] [RFC PATCH 02/12] common/mlx5: read software parsing capabilities from DevX

2021-09-15 Thread Tal Shnaiderman
mlx5 in Windows needs the software parsing hca capabilities to query the NIC for TSO and Checksum offloading support. Added the capability as part of the capabilities queried by the PMD using DevX. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/mlx5_devx_cmds.c | 6 ++ drivers

[dpdk-dev] [RFC PATCH 01/12] net/mlx5: fix software parsing support query

2021-09-15 Thread Tal Shnaiderman
SO from the standard one") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman --- drivers/net/mlx5/linux/mlx5_os.c | 3 ++- drivers/net/mlx5/linux/mlx5_os.h | 12 drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_txq.c | 15 +-- 4 files changed, 24

[dpdk-dev] [RFC PATCH 09/10] crypto/mlx5: fix size of UMR WQE

2021-09-14 Thread Tal Shnaiderman
ambiguity the allocation size will be calculated by the sizes of the members excluding the flexible union. Fixes: a1978aa23bf4 ("crypto/mlx5: add maximum segments configuration") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman --- drivers/crypto/mlx5/mlx5_crypto.c | 4 +++- 1 file

[dpdk-dev] [RFC PATCH 07/10] crypto/mlx5: use OS agnostic functions for PD operations

2021-09-14 Thread Tal Shnaiderman
use the functions mlx5_os_alloc_pd, mlx5_os_dealloc_pd mlx5_os_get_pdn instead of the glue functions to support PD operations on all OSs. Signed-off-by: Tal Shnaiderman --- drivers/crypto/mlx5/mlx5_crypto.c | 15 ++- drivers/crypto/mlx5/mlx5_crypto.h | 2 +- 2 files changed, 7

[dpdk-dev] [RFC PATCH 06/10] crypto/mlx5: use OS agnostic functions for UMEM operations

2021-09-14 Thread Tal Shnaiderman
use the functions mlx5_os_umem_reg, mlx5_os_umem_dereg mlx5_os_get_umem_id instead of the glue functions to support UMEM operations on all OSs. Signed-off-by: Tal Shnaiderman --- drivers/crypto/mlx5/mlx5_crypto.c | 14 +++--- drivers/crypto/mlx5/mlx5_crypto.h | 2 +- 2 files changed, 8

[dpdk-dev] [RFC PATCH 08/10] crypto/mlx5: use OS agnostic functions for Verbs operations

2021-09-14 Thread Tal Shnaiderman
use the functions mlx5_os_open_device_context, mlx5_os_get_ctx_device_name mlx5_os_reg_mr mlx5_os_dereg_mr instead of the ib verbs functions and variables to support device operations on all OSs. Signed-off-by: Tal Shnaiderman --- drivers/crypto/mlx5/mlx5_crypto.c | 41

[dpdk-dev] [RFC PATCH 04/10] common/mlx5: add memory region OS agnostic functions for Linux

2021-09-14 Thread Tal Shnaiderman
The OS agnostic functions for memory region registration/deregistration (mlx5_os_reg_mr mlx5_os_dereg_mr) exist only for Windows OS. Adding them for Linux as well as they are needed for memory region activities in shared code. Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/linux

[dpdk-dev] [RFC PATCH 05/10] crypto/mlx5: replace UNIX functions with EAL functions

2021-09-14 Thread Tal Shnaiderman
Use the OS agnostic EAL function rte_mem_page_size to get page size value instead of the Linux specific implementation. Also remove the usage of PTHREAD_MUTEX_INITIALIZER which is not support in Windows and initialize priv_list_lock in RTE_INIT. Signed-off-by: Tal Shnaiderman --- drivers

  1   2   3   4   5   6   >