[V4] ethdev: restore eth_da init at startup of rte_eth_devargs_parse()

2024-03-11 Thread Thierry Herbelot
w argument: nb_da, the memset takes it into account. Fixes: 9a9eb104edf6 ("ethdev: parse multiple representor devargs") Signed-off-by: Thierry Herbelot Signed-off-by: Olivier Matz --- V4: use nb_da to define the size of the memset V3: fix variable name V2: fix git hash length lib/ethdev

[V3] ethdev: restore eth_devargs init at startup of rte_eth_devargs_parse()

2024-03-11 Thread Thierry Herbelot
parse multiple representor devargs") Signed-off-by: Thierry Herbelot --- V3: fix variable name V2: fix git hash length lib/ethdev/ethdev_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c index 1660dd3f2a46..18f1144dcdeb 100

[V2] ethdev: restore eth_da init at startup of rte_eth_devargs_parse()

2024-03-11 Thread Thierry Herbelot
parse multiple representor devargs") Signed-off-by: Thierry Herbelot --- V2: fix git hash length lib/ethdev/ethdev_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c index 1660dd3f2a46..7513b990157f 100644 --- a/lib/ethdev/e

[PATCH] ethdev: restore eth_da init at startup of rte_eth_devargs_parse()

2024-03-11 Thread Thierry Herbelot
parse multiple representor devargs") Signed-off-by: Thierry Herbelot --- lib/ethdev/ethdev_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c index 1660dd3f2a46..7513b990157f 100644 --- a/lib/ethdev/ethdev_driver.c +++ b/lib/et

Question on a patch in lib/ethdev/ethdev_driver.c

2024-03-11 Thread Thierry Herbelot
_pci_probe(): unsupported representor type: Indeed, nb_representor_ports was supposed to be correctly defined when calling rte_eth_devargs_parse(). The question is: why was "memset(eth_da, 0, sizeof(*eth_da));" removed ? This is not explained in the commit log. Best regards

Re: [PATCH] common/cnxk/roc_npa: fix npa_aura_fini

2023-06-20 Thread Thierry Herbelot
Hello David, I added a trace in mbox_get() to print when a mbox lock was already locked. The traces were displayed when running an internal CI/CD test suite. Best regards Thierry On 6/20/23 11:32, David Marchand wrote: On Tue, Jun 20, 2023 at 10:51 AM Thierry Herbelot wrote

[PATCH v3] common/cnxk/roc_npa: unlock mbox in error cases

2023-06-20 Thread Thierry Herbelot
In npa_aura_pool_fini and in npa_aura_fini, Unlock mbox when an error is detected. Fixes: ea4d70cc4f0b46d5 ('common/cnxk: add NPA aura create/destroy ROC APIs') Signed-off-by: Thierry Herbelot -- V2: also patch npa_aura_pool_fini V3: add missing space --- drivers/common/cnxk/roc_

[PATCH v2] common/cnxk/roc_npa: unlock mbox in error cases

2023-06-20 Thread Thierry Herbelot
In npa_aura_pool_fini and in npa_aura_fini, Unlock mbox when an error is detected. Fixes: ea4d70cc4f0b46d5 ('common/cnxk: add NPA aura create/destroy ROC APIs') Signed-off-by: Thierry Herbelot -- V2: also patch npa_aura_pool_fini --- drivers/common/cnxk/roc_npa.c | 12 --

Re: [EXT] [PATCH] common/cnxk/roc_npa: fix npa_aura_fini

2023-06-20 Thread Thierry Herbelot
Hello Ashwin, I will resend a patch with a fix also in npa_aura_pool_fini Thierry On 6/20/23 11:27, Ashwin Sekhar T K wrote: Hi Thierry, Could you please add the same fix in npa_aura_pool_fini() as well. Thanks Ashwin Sekhar T K -Original Message- From: Thierry Herbelot

[PATCH] common/cnxk/roc_npa: fix npa_aura_fini

2023-06-20 Thread Thierry Herbelot
Unlock mbox when an error is detected. Fixes: ea4d70cc4f0b46d5 ('common/cnxk: add NPA aura create/destroy ROC APIs') Signed-off-by: Thierry Herbelot --- drivers/common/cnxk/roc_npa.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/r

[PATCH] doc/guides: fix typo for cnxk platform

2023-06-02 Thread Thierry Herbelot
The Linux kernel option has an added underscore. Fixes: 14ad4f01845331a ('doc: add Marvell OCTEON TX2 platform guide') Signed-off-by: Thierry Herbelot --- doc/guides/platform/cnxk.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/platform/cnxk.rst b/

Re: [DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-08 Thread Thierry Herbelot
Hello, After upgrading the firmware on the bnxt NIC, the NIC is correctly detected by a DPDK application with both DPDK-v20.11 and DPDK-v21.11. Regards Thierry On 3/4/22 01:56, Honnappa Nagarahalli wrote: + Ruifeng On Wed, Mar 2, 2022 at 9:28 AM Thierry Herbelot wrote

Re: [DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-02 Thread Thierry Herbelot
On 3/2/22 18:26, Ajit Khaparde wrote: On Wed, Mar 2, 2022 at 9:16 AM Thierry Herbelot wrote: Hello Ajit The card is not correctly probed by the kernel, and so the FW version is not visible. Thanks Thierry. I thought it was just the PMD running into trouble. Can you give details of the ARM

Re: [DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-02 Thread Thierry Herbelot
): Firmware not responding, status: 0x8 And then there are no bnxt_en netdevices. Best regards Thierry On 3/2/22 18:13, Ajit Khaparde wrote: On Wed, Mar 2, 2022 at 7:13 AM Thierry Herbelot wrote: Hello Ajit Thanks for the quick response. Please keep me posted when you

Re: [DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-02 Thread Thierry Herbelot
issues. But we can try it again and get back to you. Thanks Thierry Herbelot PS: a similar error is seen for the Ethernet ports, when handled by the kernel: dmesg|grep bnxt [ 57.823746] bnxt_en :03:00.0 (unnamed net_device) (uninitialized): Error (timeout: 500015) msg {0x0

[DPDK/bnxt] Issues starting bnxt on an Arm server

2022-03-02 Thread Thierry Herbelot
ing option: vfio.enable_unsafe_noiommu_mode=1 A similar testpmd log is obtained with DPDK v21.11.0. Is this a know issue ? Thanks Thierry Herbelot PS: a similar error is seen for the Ethernet ports, when handled by the kernel: dmesg|grep bnxt [ 57.823746] bnxt_en :03:00.

[dpdk-dev] [PATCH V3] table: fix bucket empty logic

2021-07-07 Thread Thierry Herbelot
Due to a typo, only 3 out of 4 keys in the bucket of the exact match table were considered, which can result in valid keys being incorrectly dropped from the table. Fixes: d0a00966618ba ("table: add exact match SWX table") Cc: sta...@dpdk.org Cc: Cristian Dumitrescu Signed-off-b

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

2021-06-21 Thread Thierry Herbelot
On 6/21/21 6:14 PM, Thomas Monjalon wrote: 21/06/2021 17:54, Thierry Herbelot: On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote: From: Thierry Herbelot On 6/17/21 9:01 AM, Thomas Monjalon wrote: Check Bucket key for all possible indices. Fixes: d0a00966618ba ("table: add exact matc

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

2021-06-21 Thread Thierry Herbelot
On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote: -Original Message- From: Thierry Herbelot Sent: Thursday, June 17, 2021 8:12 AM To: Thomas Monjalon ; Dumitrescu, Cristian Cc: dev@dpdk.org; sta...@dpdk.org Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo On 6/17/21 9:01 AM

Re: [dpdk-dev] [PATCH V6] config/arm: add Qualcomm Centriq 2400 part number

2021-06-18 Thread Thierry Herbelot
On 6/18/21 10:51 AM, Thomas Monjalon wrote: 18/06/2021 04:09, Ruifeng Wang: From: Thierry Herbelot 'part_number_config': { -'0xc00': {'machine_args': ['-march=armv8-a+crc']} +'0x800': {'machine_args'

[dpdk-dev] [PATCH V6] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
0xc00 is for "SoC 2.0" Qualcomm Centriq servers. 0x800 is for "SoC 1.1". Cc: Jerin Jacob Cc: Ruifeng Wang Cc: Honnappa Nagarahalli Cc: Juraj Linkeš Signed-off-by: Thierry Herbelot -- V2: add maintainers as Cc V3: fix meson syntax for the SoC v1.1 machine des

[dpdk-dev] [PATCH V5] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
0xc00 is for "SoC 2.0" Qualcomm Centriq servers. 0x800 is for "SoC 1.1". Cc: Jerin Jacob Cc: Ruifeng Wang Cc: Honnappa Nagarahalli Cc: Juraj Linkeš Signed-off-by: Thierry Herbelot -- V2: add maintainers as Cc V3: fix meson syntax for the SoC v1.1 machine des

[dpdk-dev] [PATCH V4] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
0xc00 is for "SoC 2.0" Qualcomm Centriq servers. 0x800 is for "SoC 1.1". Cc: Jerin Jacob Cc: Ruifeng Wang Cc: Honnappa Nagarahalli Cc: Juraj Linkeš Signed-off-by: Thierry Herbelot -- V2: add maintainers as Cc V3: fix meson syntax for the SoC v1.1 machine des

Re: [dpdk-dev] [PATCH V3] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
On 6/17/21 12:03 PM, Ruifeng Wang wrote: -Original Message- From: Thierry Herbelot Sent: Thursday, June 17, 2021 4:16 PM To: dev@dpdk.org Cc: Thierry Herbelot ; tho...@monjalon.net; jer...@marvell.com; Ruifeng Wang ; Honnappa Nagarahalli ; Juraj Linkeš Subject: [PATCH V3] config/arm

[dpdk-dev] [PATCH V3] config/arm: add Qualcomm Centriq 2400 part number

2021-06-17 Thread Thierry Herbelot
0xc00 is for "SoC 2.0" Qualcomm Centriq servers. 0x800 is for "SoC 1.1". Cc: Jerin Jacob Cc: Ruifeng Wang Cc: Honnappa Nagarahalli Cc: Juraj Linkeš Signed-off-by: Thierry Herbelot -- V2: add maintainers as Cc V3: fix meson syntax for the SoC v1.1 machine descrip

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

2021-06-17 Thread Thierry Herbelot
On 6/17/21 9:01 AM, Thomas Monjalon wrote: Check Bucket key for all possible indices. Fixes: d0a00966618ba ("table: add exact match SWX table") Cc: sta...@dpdk.org Cc: Cristian Dumitrescu Signed-off-by: Thierry Herbelot [...] - return (!bkt->sig[0] && !bkt-&

Re: [dpdk-dev] [PATCH] net/virtio: fix kernel set features for multi-queue devices

2021-06-01 Thread Thierry Herbelot
Hello Maxime, On 6/1/21 9:51 AM, Maxime Coquelin wrote: On 5/28/21 3:20 PM, Thierry Herbelot wrote: Restore the original code, where VHOST_SET_FEATURES is applied to all vhostfds of the device. Fixes: cc0151b34dee ("net/virtio: add virtio-user features ops") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH] net/virtio: fix kernel set features for multi-queue devices

2021-05-28 Thread Thierry Herbelot
Restore the original code, where VHOST_SET_FEATURES is applied to all vhostfds of the device. Fixes: cc0151b34dee ("net/virtio: add virtio-user features ops") Cc: sta...@dpdk.org Cc: Maxime Coquelin Cc: Chenbo Xia Signed-off-by: Thierry Herbelot --- drivers/net/virtio/v

[dpdk-dev] [PATCH v2] config/arm: add Qualcomm Centriq 2400 part number

2021-05-25 Thread Thierry Herbelot
0xc00 is for "SoC 2.0" Qualcom Centriq servers. 0x800 is for "SoC 1.1". Cc: Jerin Jacob Cc: Ruifeng Wang Cc: Honnappa Nagarahalli Cc: Juraj Linkeš Signed-off-by: Thierry Herbelot -- V2: add maintainers as Cc --- config/arm/meson.build | 1 + 1 file changed, 1 insert

[dpdk-dev] [PATCH] config/arm: add Qualcomm Centriq 2400 part number

2021-05-25 Thread Thierry Herbelot
0xc00 is for "SoC 2.0" Qualcom Centriq servers. 0x800 is for "SoC 1.1". Signed-off-by: Thierry Herbelot --- config/arm/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index e83a56e0d589..971a050efd93 100

[dpdk-dev] [PATCH v2] sched: check newly allocated pointer

2021-05-24 Thread Thierry Herbelot
Check port->subport_profiles after it was allocated. Fixes: 0ea4c6afcaf14 ("sched: add subport profile table") Cc: sta...@dpdk.org Cc: Cristian Dumitrescu Cc: Jasvinder Singh Signed-off-by: Thierry Herbelot -- V2: reword patch title --- lib/sched/rte_sched.c | 2 +- 1 fi

[dpdk-dev] [PATCH v2] table: fix typo

2021-05-24 Thread Thierry Herbelot
Check Bucket key for all possible indices. Fixes: d0a00966618ba ("table: add exact match SWX table") Cc: sta...@dpdk.org Cc: Cristian Dumitrescu Signed-off-by: Thierry Herbelot -- V2: reword patch title --- lib/table/rte_swx_table_em.c | 2 +- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH] net/sfc: fix typo

2021-05-24 Thread Thierry Herbelot
Do not return "GOOD" flag if the status was bad. Fixes: 9e6e7f479ae9b ("net/sfc: support Rx checksum offload for EF100") Cc: sta...@dpdk.org Cc: Andrew Rybchenko Signed-off-by: Thierry Herbelot --- drivers/net/sfc/sfc_ef100_rx.c | 2 +- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH v2] net/pfe: no need to check dev to be NULL Pointer

2021-05-24 Thread Thierry Herbelot
librte_ethdev library is already doing some checks on dev before calling the link update. Fixes: acd4818ea2a45 ("net/pfe: add link status update") Cc: sta...@dpdk.org Cc: Gagandeep Singh Signed-off-by: Thierry Herbelot -- V2: rework after noting dev cannot be NULL --- drive

[dpdk-dev] [PATCH v2] graph: do not use a possibly NULL Pointer

2021-05-24 Thread Thierry Herbelot
Use stats only after it was checked not to be NULL. Fixes: af1ae8b6a32c9 ("graph: implement stats") Cc: sta...@dpdk.org Cc: Jerin Jacob Cc: Kiran Kumar K Signed-off-by: Thierry Herbelot -- V2: reword patch title --- lib/graph/graph_stats.c | 2 +- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH v2] vhost/vhost_crypto: do not use possibly NULL Pointers

2021-05-24 Thread Thierry Herbelot
Use vc_req only after it was checked not to be NULL. Fixes: 2d962bb736521 ("vhost/crypto: fix possible TOCTOU attack") Cc: sta...@dpdk.org Cc: Maxime Coquelin Cc: Chenbo Xia Signed-off-by: Thierry Herbelot -- V2: fix copy/paste typo --- lib/vhost/vhost_crypto.c | 6 -- 1 file

[dpdk-dev] [PATCH] app/testpmd: do not use a possibly NULL Pointer

2021-05-24 Thread Thierry Herbelot
Use out only after it was checked not to be NULL. Fixes: 4d07cbefe3ba0 ("app/testpmd: add commands for conntrack") Cc: sta...@dpdk.org Cc: Ori Kam Signed-off-by: Thierry Herbelot --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ap

[dpdk-dev] [PATCH] test/test_cryptodev: do not use a possibly NULL Pointer

2021-05-24 Thread Thierry Herbelot
Use m only after it was checked not to be NULL. Fixes: 202d375c60bc1 ("app/test: add cryptodev unit and performance tests") Cc: sta...@dpdk.org Cc: Declan Doherty Signed-off-by: Thierry Herbelot --- app/test/test_cryptodev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletion

[dpdk-dev] [PATCH] net/bnxt: do not use possibly NULL pointers

2021-05-24 Thread Thierry Herbelot
Check that pointers are valid before using them. Fixes: 7bc8e9a227ccb ("net/bnxt: support async link notification") Cc: sta...@dpdk.org Cc: Ajit Khaparde Cc: Somnath Kotur Signed-off-by: Thierry Herbelot --- drivers/net/bnxt/bnxt_irq.c | 5 - 1 file changed, 4 insertions(+),

[dpdk-dev] [PATCH] net/octeontx_ep: do not use a NULL Pointer

2021-05-24 Thread Thierry Herbelot
mz is known to be NULL: do not use it to print a memzone name. Fixes: 242e18c056890 ("net/octeontx_ep: add Rx queue setup and release") Cc: sta...@dpdk.org Cc: Nalla Pradeep Cc: Radha Mohan Chintakuntla Cc: Veerasenareddy Burru Signed-off-by: Thierry Herbelot --- drivers/net/o

[dpdk-dev] [PATCH] net/pfe: do not use a possibly NULL Pointer

2021-05-24 Thread Thierry Herbelot
Use dev only after it was checked not to be NULL. Fixes: acd4818ea2a45 ("net/pfe: add link status update") Cc: sta...@dpdk.org Cc: Gagandeep Singh Signed-off-by: Thierry Herbelot --- drivers/net/pfe/pfe_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/d

[dpdk-dev] [PATCH] graph_stats: do not use a possibly NULL Pointer

2021-05-24 Thread Thierry Herbelot
Use stats only after it was checked not to be NULL. Fixes: af1ae8b6a32c9 ("graph: implement stats") Cc: sta...@dpdk.org Cc: Jerin Jacob Cc: Kiran Kumar K Signed-off-by: Thierry Herbelot --- lib/graph/graph_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[dpdk-dev] [PATCH] vhost/vhost_crypto: do not use possibly NULL Pointers

2021-05-24 Thread Thierry Herbelot
Use vc_req only after it was checked not to be NULL. Fixes: 2d962bb736521 ("vhost/crypto: fix possible TOCTOU attack") Cc: sta...@dpdk.org Cc: Maxime Coquelin Cc: Chenbo Xia Signed-off-by: Thierry Herbelot --- lib/vhost/vhost_crypto.c | 6 -- 1 file changed, 4 insertions(+), 2

[dpdk-dev] [PATCH] rte_sched: check newly allocated pointer

2021-05-24 Thread Thierry Herbelot
Check port->subport_profiles after it was allocated. Fixes: 0ea4c6afcaf14 ("sched: add subport profile table") Cc: sta...@dpdk.org Cc: Cristian Dumitrescu Cc: Jasvinder Singh Signed-off-by: Thierry Herbelot --- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[dpdk-dev] [PATCH] app/regex: avoid division by zero

2021-05-24 Thread Thierry Herbelot
Check that nb_jobs is not zero before using it for a division. Fixes: f5cffb7eb7fb6 ("app/regex: read data file once at startup") Cc: sta...@dpdk.org Cc: Ori Kam Signed-off-by: Thierry Herbelot --- app/test-regex/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/

[dpdk-dev] [PATCH] rte_swx: fix typo

2021-05-24 Thread Thierry Herbelot
Check Bucket key for all possible indices. Fixes: d0a00966618ba ("table: add exact match SWX table") Cc: sta...@dpdk.org Cc: Cristian Dumitrescu Signed-off-by: Thierry Herbelot --- lib/table/rte_swx_table_em.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[dpdk-dev] [PATCH-V7] config/arm: add Qualcomm Centriq 2400 SoC config

2021-05-07 Thread Thierry Herbelot
g implementer configuration, and a cross file. Signed-off-by: Thierry Herbelot -- V7: - use a more specific subject - add a cross file V6: - rebase after merge of "doc: fix Arm SoCs list" V5: - rebase after http://patches.dpdk.org/project/dpdk/patch/20210429070751.6065-1-david.march...@

[dpdk-dev] [PATCH-V6] config/arm: restore support for Qualcomm servers

2021-05-06 Thread Thierry Herbelot
g implementer configuration. Signed-off-by: Thierry Herbelot -- V6: - rebase after merge of "doc: fix Arm SoCs list" V5: - rebase after http://patches.dpdk.org/project/dpdk/patch/20210429070751.6065-1-david.march...@redhat.com/ V4: - use a more specific SoC name V3: - include doc patch

[dpdk-dev] [PATCH-V5] config/arm: restore support for Qualcomm servers

2021-04-29 Thread Thierry Herbelot
g implementer configuration. Signed-off-by: Thierry Herbelot -- V5: - rebase after http://patches.dpdk.org/project/dpdk/patch/20210429070751.6065-1-david.march...@redhat.com/ V4: - use a more specific SoC name V3: - include doc patch - remove Fixes line V2: - use the right original commit in Fixe

[dpdk-dev] [PATCH-V4] config/arm: restore support for Qualcomm servers

2021-04-29 Thread Thierry Herbelot
g implementer configuration. Signed-off-by: Thierry Herbelot -- V4: - use a more specific SoC name V3: - include doc patch - remove Fixes line V2: - use the right original commit in Fixes --- config/arm/meson.build | 8 doc/guides/linux_gsg/cross_build_dpdk_

[dpdk-dev] [PATCH-V3] config/arm: restore support for Qualcomm servers

2021-04-29 Thread Thierry Herbelot
g implementer configuration. Signed-off-by: Thierry Herbelot -- V3: - include doc patch - remove Fixes line V2: - use the right original commit in Fixes --- config/arm/meson.build | 8 doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 1 + 2 fil

[dpdk-dev] [PATCH-V2] config/arm: restore support for Qualcomm servers

2021-04-29 Thread Thierry Herbelot
g implementer configuration. Fixes: f2340c858046 ("config/arm: add platform config option") Signed-off-by: Thierry Herbelot -- V2: - use the right original commit in Fixes --- config/arm/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/config/arm/meson.build b

[dpdk-dev] [PATCH] doc/cross_build: update the list supported Arm SoCs

2021-04-29 Thread Thierry Herbelot
Align the list of supported targets with config/arm/meson.build Fixes: f2340c858046 ("config/arm: add platform config option") Signed-off-by: Thierry Herbelot --- doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides

Re: [dpdk-dev] [PATCH] config/arm: restore support for Qualcomm servers

2021-04-28 Thread Thierry Herbelot
On 4/28/21 8:21 PM, Honnappa Nagarahalli wrote: Subject: Re: [PATCH] config/arm: restore support for Qualcomm servers 28/04/2021 18:08, Thierry Herbelot: Like for other Arm chips, the 'soc' entry is also needed. Fixes: fddbe822c3eb ("config/arm: add Qualcomm") Si

[dpdk-dev] [PATCH] config/arm: restore support for Qualcomm servers

2021-04-28 Thread Thierry Herbelot
Like for other Arm chips, the 'soc' entry is also needed. Fixes: fddbe822c3eb ("config/arm: add Qualcomm") Signed-off-by: Thierry Herbelot --- config/arm/meson.build | 8 1 file changed, 8 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.buil

[dpdk-dev] [PATCH] net/virtio: fix kernel set memory table for multi-queue devices

2021-04-23 Thread Thierry Herbelot
Restore the original code, where VHOST_SET_MEM_TABLE is applied to all vhostfds of the device. Fixes: 539d910c9c768 ("net/virtio: add virtio-user memory tables ops") Cc: sta...@dpdk.org Signed-off-by: Thierry Herbelot --- drivers/net/virtio/virtio_user/vhost_kernel.c | 12 +-

[dpdk-dev] [PATCH] net/virtio: fix vhost_kernel_set_owner for multi-queue devices

2021-04-08 Thread Thierry Herbelot
Restore the original code, where VHOST_SET_OWNER is applied to all vhostfds of the device. Fixes: 06856cabb89b0 ("net/virtio: add virtio-user ops to set owner") Cc: Maxime Coquelin Cc: Chenbo Xia Signed-off-by: Thierry Herbelot --- drivers/net/virtio/virtio_user/vhost_ker

Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build

2021-02-24 Thread Thierry Herbelot
Message: 4 Date: Wed, 24 Feb 2021 11:24:27 +0100 From: Thomas Monjalon To: oulijun Cc: ferruh.yi...@intel.com, dev@dpdk.org, linux...@openeuler.org, juraj.lin...@pantheon.tech, bruce.richard...@intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC

[dpdk-dev] Typos in Arm xconfig files

2021-02-01 Thread Thierry Herbelot
Hello, There is an inconsistency in the name of variables: most xconfig files use 'implementer_id' two still use 'implementor_id' Regards Thierry -- Thierry Herbelot Senior Software Engineer Tel: +33 1 39 30 92 61 http://www.6wind.com/ Follow us: http

[dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8

2020-09-18 Thread Thierry Herbelot
_id++) { ^ Fixes: 769de16872ab9 ('net/bnxt: fix port default rule create/destroy') Cc: Ajit Khaparde Cc: Somnath Kotur Signed-off-by: Thierry Herbelot --- drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[dpdk-dev] [PATCH] crypto/octeontx2: enable unbinding

2020-02-09 Thread Thierry Herbelot
for bind and unbind. Fixes: 2f8a1b963eb77 ("crypto/octeontx2: add PMD skeleton") Cc: sta...@dpdk.org Cc: Anoob Joseph Signed-off-by: Thierry Herbelot --- drivers/crypto/octeontx2/otx2_cryptodev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/octeontx2/otx2_cryp

Re: [dpdk-dev] drivers/octeontx2: compilation fails without RTE_LIBRTE_SECURITY

2020-02-06 Thread Thierry Herbelot
On 2/6/20 4:06 PM, Jerin Jacob wrote: On Thu, Feb 6, 2020 at 8:26 PM Thierry Herbelot wrote: On 2/6/20 3:48 PM, Jerin Jacob wrote: On Thu, Feb 6, 2020 at 8:06 PM Thierry Herbelot wrote: On 2/6/20 3:27 PM, Bruce Richardson wrote: On Thu, Feb 06, 2020 at 02:39:28PM +0100, Thierry Herbelot

Re: [dpdk-dev] drivers/octeontx2: compilation fails without RTE_LIBRTE_SECURITY

2020-02-06 Thread Thierry Herbelot
On 2/6/20 3:48 PM, Jerin Jacob wrote: On Thu, Feb 6, 2020 at 8:06 PM Thierry Herbelot wrote: On 2/6/20 3:27 PM, Bruce Richardson wrote: On Thu, Feb 06, 2020 at 02:39:28PM +0100, Thierry Herbelot wrote: Hello, When RTE_LIBRTE_SECURITY is disabled, compilation fails for octeontx2 (on an

Re: [dpdk-dev] drivers/octeontx2: compilation fails without RTE_LIBRTE_SECURITY

2020-02-06 Thread Thierry Herbelot
On 2/6/20 3:27 PM, Bruce Richardson wrote: On Thu, Feb 06, 2020 at 02:39:28PM +0100, Thierry Herbelot wrote: Hello, When RTE_LIBRTE_SECURITY is disabled, compilation fails for octeontx2 (on an Intel machine): git clone git://dpdk.org/dpdk cd dpdk make config T=x86_64-native-linux-gcc cd build

[dpdk-dev] drivers/octeontx2: compilation fails without RTE_LIBRTE_SECURITY

2020-02-06 Thread Thierry Herbelot
pdk/drivers/crypto/octeontx2/otx2_ipsec_fp.h:9:10: fatal error: rte_security.h: No such file or directory #include ^~~~ compilation terminated. This seems cause by f44e7163775537 ('net/octeontx2: add security session operations'). Thanks Thierr

Re: [dpdk-dev] [PATCH] mk: fix dpaax library dependency

2019-10-31 Thread Thierry Herbelot
te DPAAX table') Suggested-by: Thierry Herbelot Signed-off-by: Gagandeep Singh --- The first suggested patch was https://patchwork.dpdk.org/patch/62150/ , which is not the right fix for this issue. This patch is a complete fix of compilation issues because of NXP's PMDs. drivers/net

Re: [dpdk-dev] [PATCH] drivers/net: only compile PFE and ENETC when DPAA was selected

2019-10-30 Thread Thierry Herbelot
On 10/30/19 6:46 AM, Gagandeep Singh wrote: Hi Thierry, -Original Message- From: Thierry Herbelot Sent: Tuesday, October 29, 2019 6:32 PM To: dev@dpdk.org Cc: Thomas Monjalon ; Gagandeep Singh Subject: [PATCH] drivers/net: only compile PFE and ENETC when DPAA was selected PFE and

[dpdk-dev] [PATCH] drivers/net: only compile PFE and ENETC when DPAA was selected

2019-10-29 Thread Thierry Herbelot
PFE and ENETC depend on DPAA features. Fixes: e56463ec47f0 ('net/enetc: enable dpaax library') Fixes: 67fc3ff97c39 ('net/pfe: introduce basic functions') Cc: Gagandeep Singh Signed-off-by: Thierry Herbelot --- drivers/net/Makefile | 4 mk/rte.app.mk| 4

[dpdk-dev] [PATCH] doc/guides/nics: fix typos

2019-10-18 Thread Thierry Herbelot
add device start operation') Fixes: f994cecafdcf ('doc: add ThunderX nicvf') Cc: sta...@dpdk.org Signed-off-by: Thierry Herbelot --- doc/guides/nics/fm10k.rst | 4 ++-- doc/guides/nics/liquidio.rst | 4 ++-- doc/guides/nics/octeontx.rst | 4 ++-- doc/guides/nics/octeontx2.rst

Re: [dpdk-dev] [PATCH] crypto/dpaa_sec: enable compilation without security

2019-10-18 Thread Thierry Herbelot
+ifeq ($(CONFIG_RTE_LIBRTE_SECURITY),y) +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_CAAM_JR) += -lrte_pmd_caam_jr endif # CONFIG_RTE_LIBRTE_SECURITY _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO) += -lrte_pmd_virtio_crypto endif # CONFIG_RTE_LIBRTE_CRYPTODEV Acked-by: Thierry Herbelot -- Thierry Herbelot 6WIND Senior Software Engineer

Re: [dpdk-dev] [PATCH] app/proc-info: fix compilation with no security

2019-10-18 Thread Thierry Herbelot
751,6 +754,7 @@ show_port(void) s_cap->crypto_capabilities->op); } } +#endif } STATS_BDR_STR(50, ""); Acked-by: Thierry Herbelot -- Thierry Herbelot 6WIND Senior Software Engineer

Re: [dpdk-dev] [PATCH] test/crypto: fix compilation issue without security

2019-10-18 Thread Thierry Herbelot
{ if (ut_params->sess) { rte_cryptodev_sym_session_clear( ts_params->valid_devs[0], Acked-by: Thierry Herbelot -- Thierry Herbelot 6WIND Senior Software Engineer

[dpdk-dev] [DPDK] broken compilation when RTE_LIBRTE_SECURITY is not enabled

2019-10-14 Thread Thierry Herbelot
quot;. Thanks Thierry -- Thierry Herbelot 6WIND Senior Software Engineer

Re: [dpdk-dev] [PATCH 19.11 V3 00/12] Miscellaneous fixes

2019-10-10 Thread Thierry Herbelot
On 10/10/19 3:01 PM, David Marchand wrote: On Thu, Aug 8, 2019 at 4:34 PM Thomas Monjalon wrote: 08/08/2019 15:19, Thierry Herbelot: On 8/8/19 10:22 AM, Thierry Herbelot wrote: This series of patches includes fixes for issues seen with 6WIND fast path, built on DPDK. The patches are in

Re: [dpdk-dev] [PATCH 1/1] net/ixgbevf: fix stats update after a PF reset

2019-09-30 Thread Thierry Herbelot
etrieve the PF status from the VF device. Regards Thierry Thanks, Xiaolong On 09/17, Zhang, Qi Z wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thierry Herbelot Sent: Thursday, September 12, 2019 12:01 AM To: dev@dpdk.org Cc: Guo Fen

[dpdk-dev] [PATCH] crypto: remove cut'n'paste comment

2019-09-30 Thread Thierry Herbelot
ry') Cc: sta...@dpdk.org Cc: jer...@marvell.com Cc: michae...@marvell.com Cc: declan.dohe...@intel.com Signed-off-by: Thierry Herbelot --- drivers/crypto/armv8/rte_armv8_pmd.c | 1 - drivers/crypto/mvsam/rte_mrvl_pmd.c | 1 - drivers/crypto/openssl/rte_openssl_pmd.c | 1 - 3 files

[dpdk-dev] [PATCH V2] crypto/octeontx: enable unbinding for the OCTEON TX crypto engines

2019-09-12 Thread Thierry Herbelot
used for bind and unbind. Fixes: bfe2ae495ee268 ('crypto/octeontx: add PMD skeleton') Cc: sta...@dpdk.org Cc: ano...@marvell.com V2: only "vfio-pci" is needed by this PMD Signed-off-by: Thierry Herbelot --- drivers/crypto/octeontx/otx_cryptodev.c | 1 + 1 file changed, 1 inse

[dpdk-dev] [PATCH] drivers/crypto/dpaa_sec: update DPAA iova table in dpaa_mem_vtop

2019-09-12 Thread Thierry Herbelot
m V2: use "ms->addr" instead of "(void *)ms->addr_64" to fix compilation on 32bit (i686) Signed-off-by: Thierry Herbelot --- drivers/crypto/dpaa_sec/dpaa_sec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/d

[dpdk-dev] [PATCH] drivers/crypto/octeontx: enable unbinding for the OcteonTx crypto engines

2019-09-11 Thread Thierry Herbelot
used for bind and unbind. Fixes: bfe2ae495ee268 ('crypto/octeontx: add PMD skeleton') Cc: sta...@dpdk.org Cc: ano...@marvell.com Signed-off-by: Thierry Herbelot --- drivers/crypto/octeontx/otx_cryptodev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/octeontx/otx_c

[dpdk-dev] [PATCH] drivers/crypto/dpaa_sec: update DPAA iova table in dpaa_mem_vtop

2019-09-11 Thread Thierry Herbelot
om Signed-off-by: Thierry Herbelot --- drivers/crypto/dpaa_sec/dpaa_sec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 122c80a072ff..22b8b1d63ce0 100644 --- a/drivers/crypto/dpaa_sec/dpaa_s

[dpdk-dev] [PATCH] drivers/crypto/openssl: use a local copy for the session contexts

2019-09-11 Thread Thierry Herbelot
allocated. This in turn reduces the performance. Fixes: d61f70b4c918 ('crypto/libcrypto: add driver for OpenSSL library') Cc: sta...@dpdk.org Cc: declan.dohe...@intel.com Signed-off-by: Thierry Herbelot --- drivers/crypto/openssl/rte_openssl_pmd.c | 34 +--- 1 file c

[dpdk-dev] [PATCH 0/2] Fixes in virtio vectorized functions

2019-09-11 Thread Thierry Herbelot
Two fixes in the vectorized functions of virtio. Thibaut Collet (2): virtio: fix rx stats with vectorized functions virtio: get all pending rx packets with vectorized functions drivers/net/virtio/virtio_rxtx.c | 2 +- drivers/net/virtio/virtio_rxtx.h | 2 ++ drivers

[dpdk-dev] [PATCH 1/2] virtio: fix rx stats with vectorized functions

2019-09-11 Thread Thierry Herbelot
From: Thibaut Collet With vectorized functions, only the rx stats for number of packets is incremented. Update also the other statistics. Performance impact is about 2% Fixes: fc3d66212fed ("virtio: add vector Rx") Cc: sta...@dpdk.org Cc: maxime.coque...@redhat.com Cc: tiwei@intel.com Cc: zh

[dpdk-dev] [PATCH 2/2] virtio: get all pending rx packets with vectorized functions

2019-09-11 Thread Thierry Herbelot
From: Thibaut Collet The loop to read packets does not take all packets as the number of available packets (nb_used) is decremented in the loop. Take all available packets provides a performance improvement of 3%. Fixes: fc3d66212fed ("virtio: add vector Rx") Cc: sta...@dpdk.org Cc: maxime.coque

[dpdk-dev] [PATCH] net/i40e: set speed to undefined for default case in link update

2019-09-11 Thread Thierry Herbelot
From: Laurent Hardy During PF/VF link update, a default speed value of 100M will be set if get_link_info has failed or speed is unknown. Consequently if PF is put in no-carrier state, VFs will switch to "in carrier" state due to a link up + a link speed set to 100M (default value if no speed det

[dpdk-dev] [PATCH 1/1] net/ixgbevf: fix stats update after a PF reset

2019-09-11 Thread Thierry Herbelot
From: Guo Fengtian When PF is set down, in VF, the value of stats register is zero. So only increase stats when it's non zero. Fixes: af75078fece3 ('first public release') Cc: sta...@dpdk.org Cc: wenzhuo...@intel.com Cc: konstantin.anan...@intel.com Signed-off-by: Guo Fengtian --- drivers/net

Re: [dpdk-dev] [PATCH 19.11 V3 00/12] Miscellaneous fixes

2019-08-08 Thread Thierry Herbelot
On 8/8/19 10:22 AM, Thierry Herbelot wrote: This series of patches includes fixes for issues seen with 6WIND fast path, built on DPDK. The patches are in 6WIND version of DPDK, and should have been upstreamed a long time ago. In fact, I will re-submit another series of patches, as some are not

[dpdk-dev] [PATCH 19.11 V3 11/12] drivers/crypto/dpaa_sec: update DPAA iova table in dpaa_mem_vtop

2019-08-08 Thread Thierry Herbelot
the DPAA iova table has entries for all needed memory ranges. With this patch, dpaa_mem_ptov will always use dpaax_iova_table_get_va, which ensures optimal performance. Fixes: 5a7dbb934d75 ('dpaa: enable dpaax library') Cc: sta...@dpdk.org Signed-off-by: Thierry Herbelot --- driv

[dpdk-dev] [PATCH 19.11 V3 09/12] virtio: get all pending rx packets with vectorized functions

2019-08-08 Thread Thierry Herbelot
From: Thibaut Collet The loop to read packets does not take all packets as the number of available packets (nb_used) is decremented in the loop. Take all available packets provides a performance improvement of 3%. Fixes: fc3d66212fed ("virtio: add vector Rx") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH 19.11 V3 12/12] drivers/crypto/octeontx: enable unbinding for the OcteonTx crypto engines

2019-08-08 Thread Thierry Herbelot
used for bind and unbind. Fixes: bfe2ae495ee268 ('crypto/octeontx: add PMD skeleton') Cc: sta...@dpdk.org Signed-off-by: Thierry Herbelot --- drivers/crypto/octeontx/otx_cryptodev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/octeontx/otx_cryptodev.c b/driv

[dpdk-dev] [PATCH 19.11 V3 10/12] drivers/crypto/openssl: use a local copy for the session contexts

2019-08-08 Thread Thierry Herbelot
allocated. This in turn reduces the performance. Fixes: d61f70b4c918 ('crypto/libcrypto: add driver for OpenSSL library') Cc: sta...@dpdk.org Signed-off-by: Thierry Herbelot --- drivers/crypto/openssl/rte_openssl_pmd.c | 34 +++- 1 file changed, 25 insert

[dpdk-dev] [PATCH 19.11 V3 08/12] virtio: fix rx stats with vectorized functions

2019-08-08 Thread Thierry Herbelot
From: Thibaut Collet With vectorized functions, only the rx stats for number of packets is incremented. Update also the other statistics. Performance impact is about 2% Fixes: fc3d66212fed ("virtio: add vector Rx") Cc: sta...@dpdk.org Signed-off-by: Thibaut Collet --- drivers/net/virtio/virti

[dpdk-dev] [PATCH 19.11 V3 06/12] net/i40e: fix Tx descriptor status api

2019-08-08 Thread Thierry Herbelot
From: Olivier Matz The Tx descriptor status api was not behaving as expected. This API is used to inspect the content of the descriptors in the Tx ring to determine the length of the Tx queue. Since the software advances the tail pointer and the hardware advances the head pointer, the Tx queue i

[dpdk-dev] [PATCH 19.11 V3 07/12] net/i40e: set speed to undefined for default case in link update

2019-08-08 Thread Thierry Herbelot
From: Laurent Hardy During PF/VF link update, a default speed value of 100M will be set if get_link_info has failed or speed is unknown. Consequently if PF is put in no-carrier state, VFs will switch to "in carrier" state due to a link up + a link speed set to 100M (default value if no speed det

[dpdk-dev] [PATCH 19.11 V3 02/12] ethdev: fix description of tx descriptor status

2019-08-08 Thread Thierry Herbelot
From: Olivier Matz The API comment of rte_eth_tx_descriptor_status() was incorrect. The reference descriptor (when offset = 0) is not where the next packet will be sent, but where the latest packet has been enqueued. Fixes: 52f5cdd2e897 ("ethdev: add descriptor status API") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH 19.11 V3 03/12] net/e1000: fix Tx descriptor status api (igb)

2019-08-08 Thread Thierry Herbelot
From: Olivier Matz The Tx descriptor status api was not behaving as expected. This API is used to inspect the content of the descriptors in the Tx ring to determine the length of the Tx queue. Since the software advances the tail pointer and the hardware advances the head pointer, the Tx queue i

[dpdk-dev] [PATCH 19.11 V3 04/12] net/e1000: fix Tx descriptor status api (em)

2019-08-08 Thread Thierry Herbelot
From: Olivier Matz The Tx descriptor status api was not behaving as expected. This API is used to inspect the content of the descriptors in the Tx ring to determine the length of the Tx queue. Since the software advances the tail pointer and the hardware advances the head pointer, the Tx queue i

[dpdk-dev] [PATCH 19.11 V3 05/12] net/ixgbe: fix Tx descriptor status api

2019-08-08 Thread Thierry Herbelot
From: Olivier Matz The Tx descriptor status api was not behaving as expected. This API is used to inspect the content of the descriptors in the Tx ring to determine the length of the Tx queue. Since the software advances the tail pointer and the hardware advances the head pointer, the Tx queue i

[dpdk-dev] [PATCH 19.11 V3 00/12] Miscellaneous fixes

2019-08-08 Thread Thierry Herbelot
status api (em) net/ixgbe: fix Tx descriptor status api net/i40e: fix Tx descriptor status api Thibaut Collet (2): virtio: fix rx stats with vectorized functions virtio: get all pending rx packets with vectorized functions Thierry Herbelot (3): drivers/crypto/openssl: use a local copy for

[dpdk-dev] [PATCH 19.11 V3 01/12] net/ixgbevf: fix stats update after a PF reset

2019-08-08 Thread Thierry Herbelot
From: Guo Fengtian When PF is set down, in VF, the value of stats register is zero. So only increase stats when it's non zero. Fixes: af75078fece3 ('first public release') Cc: sta...@dpdk.org Signed-off-by: Guo Fengtian --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 -- 1 file changed, 4 insert

  1   2   >