Re: [PATCH v6 16/30] drivers/regex: replace packed attributes

2024-12-04 Thread Tyler Retzlaff
to the push. > > Macro __rte_packed_end is deliberately utilized to trigger a > MSVC compiler warning if no existing packing has been pushed allowing > easy identification of locations where the __rte_packed_begin is > missing. > > Signed-off-by: Andre Muezerie > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v6 15/30] drivers/raw: replace packed attributes

2024-12-04 Thread Tyler Retzlaff
to the push. > > Macro __rte_packed_end is deliberately utilized to trigger a > MSVC compiler warning if no existing packing has been pushed allowing > easy identification of locations where the __rte_packed_begin is > missing. > > Signed-off-by: Andre Muezerie > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v6 17/30] drivers/vdpa: replace packed attributes

2024-12-04 Thread Tyler Retzlaff
to the push. > > Macro __rte_packed_end is deliberately utilized to trigger a > MSVC compiler warning if no existing packing has been pushed allowing > easy identification of locations where the __rte_packed_begin is > missing. > > Signed-off-by: Andre Muezerie > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v6 13/30] drivers/mempool: replace packed attributes

2024-12-04 Thread Tyler Retzlaff
to the push. > > Macro __rte_packed_end is deliberately utilized to trigger a > MSVC compiler warning if no existing packing has been pushed allowing > easy identification of locations where the __rte_packed_begin is > missing. > > Signed-off-by: Andre Muezerie > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH 4/6] eal: add unit tests for atomic bitset operations

2024-12-04 Thread Tyler Retzlaff
On Wed, Oct 09, 2024 at 10:29:01PM +0200, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Thursday, 12 September 2024 06.52 > > > > On Fri, Aug 09, 2024 at 10:14:38PM +0200, Mattias R??nnblom wrote: > > > Exten

Re: [PATCH v6 12/30] drivers/event: replace packed attributes

2024-12-04 Thread Tyler Retzlaff
to the push. > > Macro __rte_packed_end is deliberately utilized to trigger a > MSVC compiler warning if no existing packing has been pushed allowing > easy identification of locations where the __rte_packed_begin is > missing. > > Signed-off-by: Andre Muezerie > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v6 11/30] drivers/dma: replace packed attributes

2024-12-04 Thread Tyler Retzlaff
to the push. > > Macro __rte_packed_end is deliberately utilized to trigger a > MSVC compiler warning if no existing packing has been pushed allowing > easy identification of locations where the __rte_packed_begin is > missing. > > Signed-off-by: Andre Muezerie > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v6 10/30] drivers/crypto: replace packed attributes

2024-12-04 Thread Tyler Retzlaff
to the push. > > Macro __rte_packed_end is deliberately utilized to trigger a > MSVC compiler warning if no existing packing has been pushed allowing > easy identification of locations where the __rte_packed_begin is > missing. > > Signed-off-by: Andre Muezerie > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v6 09/30] drivers/compress: replace packed attributes

2024-12-04 Thread Tyler Retzlaff
to the push. > > Macro __rte_packed_end is deliberately utilized to trigger a > MSVC compiler warning if no existing packing has been pushed allowing > easy identification of locations where the __rte_packed_begin is > missing. > > Signed-off-by: Andre Muezerie > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v6 08/30] drivers/common: replace packed attributes

2024-12-04 Thread Tyler Retzlaff
to the push. > > Macro __rte_packed_end is deliberately utilized to trigger a > MSVC compiler warning if no existing packing has been pushed allowing > easy identification of locations where the __rte_packed_begin is > missing. > > Signed-off-by: Andre Muezerie > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v6 07/30] drivers/bus: replace packed attributes

2024-12-04 Thread Tyler Retzlaff
to the push. > > Macro __rte_packed_end is deliberately utilized to trigger a > MSVC compiler warning if no existing packing has been pushed allowing > easy identification of locations where the __rte_packed_begin is > missing. > > Signed-off-by: Andre Muezerie > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v6 06/30] drivers/baseband: replace packed attributes

2024-12-04 Thread Tyler Retzlaff
On Tue, Nov 26, 2024 at 04:52:17PM -0800, Andre Muezerie wrote: > MSVC struct packing is not compatible with GCC. Replace macro > __rte_packed with __rte_packed_begin to push existing pack value > and set packing to 1-byte and macro __rte_packed_end to restore > the pack value prior to the push. >

Re: [PATCH v6 04/30] app/test: replace packed attributes

2024-12-04 Thread Tyler Retzlaff
to the push. > > Macro __rte_packed_end is deliberately utilized to trigger a > MSVC compiler warning if no existing packing has been pushed allowing > easy identification of locations where the __rte_packed_begin is > missing. > > Signed-off-by: Andre Muezerie > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v5 01/16] eal: provide pack start macro for MSVC

2024-12-04 Thread Tyler Retzlaff
On Tue, Nov 19, 2024 at 09:32:07AM +0100, Morten Brørup wrote: > > From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > > Sent: Tuesday, 19 November 2024 05.35 > > > > From: Tyler Retzlaff > > > > MSVC struct packing is not compatible with GCC. Pro

Re: [PATCH v6 01/30] devtools: check packed attributes

2024-12-04 Thread Tyler Retzlaff
On Tue, Nov 26, 2024 at 04:52:12PM -0800, Andre Muezerie wrote: > Ensure __rte_packed_begin and __rte_packed_end show up in pairs > when checking patches. > > Signed-off-by: Andre Muezerie > --- Acked-by: Tyler Retzlaff

Re: [PATCH v6 05/30] doc/guides: replace packed attributes

2024-12-04 Thread Tyler Retzlaff
to the push. > > Macro __rte_packed_end is deliberately utilized to trigger a > MSVC compiler warning if no existing packing has been pushed allowing > easy identification of locations where the __rte_packed_begin is > missing. > > Signed-off-by: Andre Muezerie > --- Acked-by: Tyler Retzlaff

Re: [PATCH v6 30/30] lib/eal: remove __rte_packed

2024-12-04 Thread Tyler Retzlaff
when MSVC is used. > > Signed-off-by: Andre Muezerie > --- Acked-by: Tyler Retzlaff

Re: [PATCH v6 02/30] eal/include: add new packing macros

2024-12-04 Thread Tyler Retzlaff
patch. > > Signed-off-by: Andre Muezerie > --- Acked-by: Tyler Retzlaff

Re: [PATCH] service: avoid worker lcore exit deadlock

2024-10-02 Thread Tyler Retzlaff
is change also results in a > slight reduction of service framework overhead. > > Fixes: 33666b448f15 ("service: fix crash on exit") > Cc: harry.van.haa...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Mattias Rönnblom > --- Acked-by: Tyler Retzlaff

Re: [PATCH 0/5] Increase minimum meson version

2024-09-30 Thread Tyler Retzlaff
+- > drivers/meson.build | 7 ++- > drivers/net/cnxk/meson.build | 2 +- > lib/meson.build | 6 -- > meson.build | 7 ++- > 14 files changed, 20 insertions(+), 32 deletions(-) > > -- Series-acked-by: Tyler Retzlaff

Re: Meson get_cross_property deprecated

2024-09-30 Thread Tyler Retzlaff
On Fri, Sep 20, 2024 at 11:20:12AM +0200, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Friday, 20 September 2024 11.08 > > > > On Fri, Sep 20, 2024 at 10:22:59AM +0200, Morten Brørup wrote: > > >Hi Bruce, > > > > > > > > >Meson version 1.3.2

Re: [PATCH v25 15/15] doc: add release note about log library

2024-09-30 Thread Tyler Retzlaff
On Thu, Sep 19, 2024 at 08:04:21AM -0700, Stephen Hemminger wrote: > Significant enough to add some documentation. > > Signed-off-by: Stephen Hemminger > Acked-by: Morten Brørup > Acked-by: Bruce Richardson > Acked-by: Chengwen Feng > --- Acked-by: Tyler Retzlaff

Re: [PATCH] eal/x86: fix 32-bit write-combined stores

2024-09-11 Thread Tyler Retzlaff
; 32-bit code, causing issues. Thankfully, the prefix is unnecessary in > 64-bit code, since the data size used is 32-bits. > > Fixes: 8a00dfc738fe ("eal: add write combining store") > Cc: radu.nico...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Bruce Richardson > --- Acked-by: Tyler Retzlaff

Re: [PATCH] power: don't disable all cast qualifier warnings

2024-09-11 Thread Tyler Retzlaff
ephen Hemminger > --- Acked-by: Tyler Retzlaff

Re: [PATCH] net/ena: revert redefining memcpy

2024-09-11 Thread Tyler Retzlaff
D: 1510 > Fixes: 142778b3702a ("net/ena: switch memcpy to optimized version") > > Signed-off-by: Stephen Hemminger > --- Acked-by: Tyler Retzlaff

Re: [PATCH 6/6] event/dsw: add support for larger port count

2024-09-11 Thread Tyler Retzlaff
maximum port count beyond 64, by means of changing an "event_dev.h" > > Signed-off-by: Mattias R??nnblom > --- Acked-by: Tyler Retzlaff

Re: [PATCH 5/6] service: use multi-word bitset to represent service flags

2024-09-11 Thread Tyler Retzlaff
h a more > compact multi-word bitset-based representation, reducing memory > footprint somewhat. > > Signed-off-by: Mattias R??nnblom > --- Acked-by: Tyler Retzlaff

Re: [PATCH 4/6] eal: add unit tests for atomic bitset operations

2024-09-11 Thread Tyler Retzlaff
On Fri, Aug 09, 2024 at 10:14:38PM +0200, Mattias R??nnblom wrote: > Extend bitset tests to cover the basic operation of the > rte_bitset_atomic_*() family of functions. > > Signed-off-by: Mattias R??nnblom > --- Tyler Retzlaff

Re: [PATCH 3/6] eal: add atomic bitset functions

2024-09-11 Thread Tyler Retzlaff
On Fri, Aug 09, 2024 at 10:14:37PM +0200, Mattias R??nnblom wrote: > Extend the bitset API with atomic versions of the most basic bitset > operations. > > Signed-off-by: Mattias R??nnblom > --- Acked-by: Tyler Retzlaff

Re: [PATCH 2/6] eal: add bitset test suite

2024-09-11 Thread Tyler Retzlaff
gt; * Fix signed char issue in test cases. (Stephen Hemminger) > * Add test cases for logic operations. > * Use the unit test suite runner helper. > --- Acked-by: Tyler Retzlaff

Re: [PATCH 1/6] eal: add bitset type

2024-09-11 Thread Tyler Retzlaff
bits). For very large bitsets, the > API may be a more appropriate choice. > > Depends-on: series-32740 ("Improve EAL bit operations API") > > Signed-off-by: Mattias R??nnblom > > -- Acked-by: Tyler Retzlaff

Re: [RFC] ethdev: convert string initialization

2024-08-05 Thread Tyler Retzlaff
On Thu, Aug 01, 2024 at 02:27:22AM -0700, Ferruh Yigit wrote: > gcc 15 experimental [1], with -Wextra flag, gives warning in variable > initialization as string [2]. > > The warning has a point when initialized variable is intended to use as > string, since assignment is missing the required null

Re: Portable alternative to inet_ntop?

2024-08-05 Thread Tyler Retzlaff
On Wed, Jul 24, 2024 at 09:21:13AM -0700, Stephen Hemminger wrote: > The function inet_ntop is useful to make printable addresses for debugging. > It is available on Linux and FreeBSD but not on Windows. i know my reply is late. but the following wasn't usable? https://learn.microsoft.com/en-us/wi

Re: [PATCH] net/*: replace intrinsic header include with rte_vect

2024-06-21 Thread Tyler Retzlaff
ntrin.h with rte_vect.h for all network drivers. > > Signed-off-by: Bruce Richardson > --- Acked-by: Tyler Retzlaff

Re: [PATCH] memzone: remove unnecessary null checks

2024-06-18 Thread Tyler Retzlaff
On Tue, Jun 18, 2024 at 04:25:08PM -0700, Stephen Hemminger wrote: > The function rte_memzone_free() already checks if the argument > is NULL. Add it to the coccinelle fix script and correct > all the existing code. > > Signed-off-by: Stephen Hemminger > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH] build: raise error if requested application is unbuildable

2024-06-18 Thread Tyler Retzlaff
On Tue, Jun 18, 2024 at 02:51:12PM +0200, David Marchand wrote: > Similarly to libraries, when setting a list of desired applications, > report if some application cannot be built because of a missing > dependency. > > Signed-off-by: David Marchand > --- Acked-by: Tyler Retzlaff

Re: [PATCH] net: add bit fields to IPv6 header definition

2024-06-18 Thread Tyler Retzlaff
On Tue, Jun 18, 2024 at 08:42:53AM +0200, Morten Brørup wrote: > > From: Gregory Etelson [mailto:getel...@nvidia.com] > > Sent: Tuesday, 18 June 2024 07.18 > > > > DPDK IPv6 header definition combined the `version`, `traffic class` > > and `flow label` header fields into a single 32 bits structure

Re: Coding Style for local variables

2024-06-10 Thread Tyler Retzlaff
On Mon, Jun 10, 2024 at 05:10:01PM +0200, Morten Brørup wrote: > The coding style guide says: > > "Variables should be declared at the start of a block of code rather than in > the middle. The exception to this is when the variable is const in which case > the declaration must be at the point of

Re: [PATCH 4/5] fib: properly include vector API header file

2024-06-10 Thread Tyler Retzlaff
On Wed, Jun 05, 2024 at 08:49:44AM +0200, Mattias Rönnblom wrote: > The trie implementation of the fib library relied on , but > failed to provide a direct include of this file. > > Signed-off-by: Mattias Rönnblom > --- Acked-by: Tyler Retzlaff

Re: [PATCH 3/5] distributor: properly include vector API header file

2024-06-10 Thread Tyler Retzlaff
On Wed, Jun 05, 2024 at 08:49:43AM +0200, Mattias Rönnblom wrote: > The distributor library relied on , but failed to provide > a direct include of this file. > > Signed-off-by: Mattias Rönnblom > --- Acked-by: Tyler Retzlaff

Re: [PATCH v5 2/2] eal: initialize shared plugins on Windows

2024-05-29 Thread Tyler Retzlaff
On Wed, May 29, 2024 at 04:29:29PM +0200, Thomas Monjalon wrote: > 12/03/2024 17:52, Tyler Retzlaff: > > When EAL is built with MSVC it is possible to dynamically load plugins > > on Windows. Hook eal_plugins_init into rte_eal_init if built with MSVC > > and provide code to lo

Re: [PATCH 1/3] compress/uadk: Introduce UADK compression driver

2024-05-23 Thread Tyler Retzlaff
On Thu, May 23, 2024 at 04:30:30PM +, Konstantin Ananyev wrote: > > > > -Original Message- > > From: Stephen Hemminger > > Sent: Thursday, May 23, 2024 5:21 PM > > To: Zhangfei Gao > > Cc: Akhil Goyal ; Fan Zhang ; > > Ashish Gupta ; > > dev@dpdk.org > > Subject: Re: [PATCH 1/3] co

Re: [PATCH v9 1/8] eal: generic 64 bit counter

2024-05-22 Thread Tyler Retzlaff
On Wed, May 22, 2024 at 07:57:01PM +0200, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, 22 May 2024 17.38 > > > > On Wed, 22 May 2024 10:31:39 +0200 > > Morten Brørup wrote: > > > > > > +/* On 32 bit platform, need to use atomic to avoi

[PATCH v2] hash: cast away atomic qualification

2024-05-22 Thread Tyler Retzlaff
ion. Signed-off-by: Tyler Retzlaff --- lib/hash/rte_cuckoo_hash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c index 9cf9464..b31a3d9 100644 --- a/lib/hash/rte_cuckoo_hash.c +++ b/lib/hash/rte_cuckoo_hash.c @@ -48

[PATCH v2] hash: cast away atomic qualification

2024-05-22 Thread Tyler Retzlaff
v2: * update commit message to indicate the conditions under which a warning will be issued without this patch. Tyler Retzlaff (1): hash: cast away atomic qualification lib/hash/rte_cuckoo_hash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.8.3.1

[PATCH v2] hash: provide crc32 functions based on intrinsics

2024-05-21 Thread Tyler Retzlaff
MSVC does not support inline asm so replace crc32 inline function implementations with intrinsics compatible with all toolchains. v2: * just provide inline functions based on intrinsics and remove inline asm versions. Tyler Retzlaff (1): hash: provide crc32 functions based on

[PATCH v2] hash: provide crc32 functions based on intrinsics

2024-05-21 Thread Tyler Retzlaff
MSVC does not support inline asm so replace crc32 inline function implementations with intrinsics compatible with all toolchains. Signed-off-by: Tyler Retzlaff --- lib/hash/rte_crc_x86.h | 38 +- 1 file changed, 13 insertions(+), 25 deletions(-) diff --git a

Re: [PATCH v6 00/45] use stdatomic API

2024-05-17 Thread Tyler Retzlaff
On Fri, May 17, 2024 at 06:58:57PM +0200, David Marchand wrote: > On Tue, May 14, 2024 at 6:36 PM Tyler Retzlaff > wrote: > > > > This series converts all non-generic built atomics to use the rte_atomic > > macros that allow optional enablement of standard C11 atomics

Re: [PATCH] crypto/mvsam: fix build

2024-05-16 Thread Tyler Retzlaff
}; already applied i see, but acking anyway. sorry for the trouble. Acked-by: Tyler Retzlaff > > /** > * Map of supported cipher algorithms. > -- > 2.45.0

Re: [PATCH v4] devtools: add .clang-format file

2024-05-14 Thread Tyler Retzlaff
On Tue, May 14, 2024 at 08:56:49AM +0100, Bruce Richardson wrote: > On Mon, May 13, 2024 at 09:11:32PM +0200, Morten Brørup wrote: > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Monday, 13 May 2024 17.55 > > > > > > On Mon, 13 May 2024 14:08:07 +0100 > > > Ferruh Yig

[PATCH v6 45/45] app/test-bbdev: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- app/test-bbdev/test_bbdev_perf.c | 183 +++ 1 file changed, 110 insertions

[PATCH v6 43/45] app/test-crypto-perf: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- app/test-crypto-perf/cperf_test_latency.c| 6 +++--- app/test-crypto-perf/cperf_test_pmd_cyclecount.c | 10

[PATCH v6 44/45] app/test-compress-perf: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- app/test-compress-perf/comp_perf_test_common.h | 2 +- app/test-compress-perf/comp_perf_test_cyclecount.c | 4

[PATCH v6 42/45] app/test-eventdev: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- app/test-eventdev/test_order_atq.c| 4 ++-- app/test-eventdev/test_order_common.c | 5 +++-- app/test-eventdev

[PATCH v6 41/45] app/test: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- app/test/test_bpf.c| 46 - app/test/test_distributor.c| 114

[PATCH v6 40/45] app/dumpcap: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- app/dumpcap/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/dumpcap

[PATCH v6 39/45] examples: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- examples/bbdev_app/main.c | 13 + examples/l2fwd-event/l2fwd_common.h

[PATCH v6 38/45] bus/vmbus: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/bus/vmbus/rte_vmbus_reg.h | 2 +- drivers/bus/vmbus/vmbus_channel.c | 8 2 files changed, 5

[PATCH v6 37/45] common/cpt: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/common/cpt/cpt_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common

[PATCH v6 36/45] crypto/ccp: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/crypto/ccp/ccp_dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v6 35/45] dma/idxd: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/dma/idxd/idxd_internal.h | 2 +- drivers/dma/idxd/idxd_pci.c | 9 + 2 files changed, 6

[PATCH v6 34/45] event/dlb2: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/event/dlb2/dlb2.c| 34 +- drivers/event/dlb2/dlb2_priv.h | 13

[PATCH v6 33/45] net/null: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/null/rte_eth_null.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a

[PATCH v6 32/45] net/txgbe: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ethdev.c| 12 +++- drivers/net/txgbe/txgbe_ethdev.h| 2 +- drivers/net

[PATCH v6 31/45] baseband/acc: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/baseband/acc/rte_acc100_pmd.c | 36 +-- drivers/baseband/acc/rte_vrb_pmd.c| 47

[PATCH v6 29/45] common/idpf: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/common/idpf/idpf_common_device.h | 6 +++--- drivers/common/idpf/idpf_common_rxtx.c| 14

[PATCH v6 30/45] common/iavf: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/common/iavf/iavf_impl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v6 28/45] common/mlx5: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/common/mlx5/linux/mlx5_nl.c | 5 +-- drivers/common/mlx5/mlx5_common.h | 2 +- drivers/common

[PATCH v6 27/45] crypto/octeontx: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v6 25/45] event/dsw: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger Reviewed-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.h | 6 +++--- drivers/event/dsw/dsw_event.c | 47

[PATCH v6 26/45] dma/skeleton: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/dma/skeleton/skeleton_dmadev.c | 5 +++-- drivers/dma/skeleton/skeleton_dmadev.h | 2 +- 2 files changed, 4

[PATCH v6 24/45] event/octeontx: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/event/octeontx/timvf_evdev.h | 8 drivers/event/octeontx/timvf_worker.h | 36

[PATCH v6 23/45] event/opdl: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/event/opdl/opdl_ring.c | 80 +- 1 file changed, 40 insertions

[PATCH v6 20/45] net/ring: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v6 22/45] raw/ifpga: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/raw/ifpga/ifpga_rawdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a

[PATCH v6 19/45] net/qede: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/qede/base/bcm_osal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v6 21/45] vdpa/mlx5: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/vdpa/mlx5/mlx5_vdpa.c | 24 +- drivers/vdpa/mlx5/mlx5_vdpa.h | 14

[PATCH v6 18/45] net/idpf: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/idpf/idpf_ethdev.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v6 16/45] net/virtio: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/virtio/virtio_ring.h | 4 +-- drivers/net/virtio/virtio_user/virtio_user_dev.c | 12

[PATCH v6 17/45] net/hinic: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/hinic/hinic_pmd_rx.c | 2 +- drivers/net/hinic/hinic_pmd_rx.h | 2 +- 2 files changed, 2 insertions

[PATCH v6 15/45] net/thunderx: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/thunderx/nicvf_rxtx.c | 9 + drivers/net/thunderx/nicvf_struct.h | 4 ++-- 2 files changed, 7

[PATCH v6 14/45] net/memif: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/memif/memif.h | 4 ++-- drivers/net/memif/rte_eth_memif.c | 50

[PATCH v6 13/45] net/gve: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/gve/base/gve_osdep.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v6 12/45] net/cxgbe: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/cxgbe/clip_tbl.c | 12 ++-- drivers/net/cxgbe/clip_tbl.h | 2 +- drivers/net/cxgbe

[PATCH v6 11/45] net/octeontx: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_ethdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

[PATCH v6 09/45] net/af_xdp: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/af_xdp/rte_eth_af_xdp.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions

[PATCH v6 10/45] net/octeon_ep: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/octeon_ep/cnxk_ep_rx.h| 5 +++-- drivers/net/octeon_ep/cnxk_ep_tx.c| 5 +++-- drivers/net

[PATCH v6 08/45] net/cpfl: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/cpfl/cpfl_ethdev.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v6 07/45] net/bnxt: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_cpr.h | 4 ++-- drivers/net/bnxt/bnxt_rxq.h | 2 +- drivers/net/bnxt

[PATCH v6 06/45] net/hns3: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/hns3/hns3_cmd.c | 18 ++-- drivers/net/hns3/hns3_dcb.c | 2 +- drivers/net/hns3

[PATCH v6 05/45] net/i40e: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev.c| 4 ++-- drivers/net/i40e/i40e_rxtx.c | 6 +++--- drivers/net/i40e

[PATCH v6 04/45] net/ice: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/ice/base/ice_osdep.h | 4 ++-- drivers/net/ice/ice_dcf.c| 6 +++--- drivers/net/ice/ice_dcf.h

[PATCH v6 03/45] net/iavf: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/iavf/iavf.h | 16 drivers/net/iavf/iavf_rxtx.c | 4

[PATCH v6 01/45] net/mlx5: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 6 +- drivers/net/mlx5/linux/mlx5_verbs.c | 9 ++- drivers/net

[PATCH v6 00/45] use stdatomic API

2024-05-14 Thread Tyler Retzlaff
). v2: * drop the net/sfc driver from the series. the sfc driver uses generic __atomic_store not handled by the current macros. the cases where generic __atomic_xxx are used on objects that can't be accepted by __atomic_xxx_n will be addressed in a separate series. Tyler R

[PATCH v6 02/45] net/ixgbe: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional rte stdatomic API. Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 14 -- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe

Re: [PATCH v5 31/45] baseband/acc: use rte stdatomic API

2024-05-14 Thread Tyler Retzlaff
On Tue, May 14, 2024 at 09:31:18AM +0200, David Marchand wrote: > On Mon, May 13, 2024 at 9:05 PM Morten Brørup > wrote: > > > > Tyler, it looks like the line continuations in > > /drivers/baseband/acc/rte_vrb_pmd.c are indented with four spaces instead > > of double . > > For Tyler defence, i

Re: [PATCH] eal/arm: replace RTE_BUILD_BUG on non-constant

2024-05-09 Thread Tyler Retzlaff
On Thu, May 09, 2024 at 12:11:50PM +0100, Daniel Gregory wrote: > On Fri, May 03, 2024 at 06:02:36PM -0700, Stephen Hemminger wrote: > > On Thu, 2 May 2024 15:21:16 +0100 > > Daniel Gregory wrote: > > > > > The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check > > > memorder, which

[PATCH v3 17/19] common/mlx5: remove use of VLAs for Windows built code

2024-05-06 Thread Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays or alloca(). alloca() is available for all toolchain/platform combinations officially supported by DPDK. Signed-off-by: Tyler Retzlaff --- drivers/common/mlx5/mlx5_common.h| 4 ++-- drivers/common/mlx5/mlx5_devx_cmds.c | 7

[PATCH v3 19/19] build: enable vla warnings on Windows built code

2024-05-06 Thread Tyler Retzlaff
MSVC does not support optional C11 VLAs. When building for Windows enable -Wvla so that mingw and clang also fail if a VLA is used. Signed-off-by: Tyler Retzlaff --- config/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/config/meson.build b/config/meson.build index 8c8b019

  1   2   3   4   5   6   7   8   9   10   >