Re: [PATCH v2] net/bonding: fix error in bonding mode 4 with dedicated queues enabled

We cannot configure the queues when the device is started. So, that part is still before the device starts. I just moved bond_ethdev_8023ad_flow_set() after the device start. On Thu, Sep 29, 2022 at 9:05 AM Usman Tanveer wrote: > > when dedicated queues are enable with bonding mode 4

[PATCH v2] net/bonding: fix error in bonding mode 4 with dedicated queues enabled

driver codes (I have tried on ixgbe). Bugzilla ID: 759 Signed-off-by: Usman Tanveer --- drivers/net/bonding/rte_eth_bond_pmd.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c

[PATCH] net/bonding: fix error in bonding mode 4 with dedicated queues enabled

driver codes (I have tried on ixgbe). Bugzilla ID: 759 Signed-off-by: Usman Tanveer --- drivers/net/bonding/rte_eth_bond_pmd.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c

Re: [PATCH] drivers/raw/skeleton: fix typecasting in skeleton_rawdev_enqueue_bufs()

Hi Thomas, Can you please have a look and update the status? On Wed, Jul 6, 2022 at 11:33 AM Usman Tanveer wrote: > In function "skeleton_rawdev_enqueue_bugs", variable "context" is being > typecasted to (int*), and then assigned to a "uint16_t" type

Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

Hi, Can you please have a look and update the status? On Wed, Jul 6, 2022 at 2:49 PM Usman Tanveer wrote: > > It has been there since the file was added (2015). I'm not able to > find any purpose for this. > > Although, it's misleading the messages it shows upon calli

Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

a message "device already started", but it's not like that because it first stops the device and then starts it again. The above change fixes both misleading messages. On Mon, Jun 27, 2022 at 2:16 AM Thomas Monjalon wrote: > > 27/05/2022 08:42, Usman Tanveer: > > The

[PATCH] drivers/raw/skeleton: fix typecasting in skeleton_rawdev_enqueue_bufs()

In function "skeleton_rawdev_enqueue_bugs", variable "context" is being typecasted to (int*), and then assigned to a "uint16_t" type variable "q_id". As the value is a "uint16_t", (int*) is replaced by (uint16_t*). Signed-off-by: Usman Tanvee

[PATCH] net/cnxk: fix segmentation fault in telemetry

It gives segmentation fault when no parameter is passed for command '/cnxk/ipsec/info' in usertools/telemetry app as NULL is being passed as parameter to strtoul(). Now this function returns -1 before strtoul() if no parameter is passed. Signed-off-by: Usman Tanveer --- driver

Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

om rte_ethtool_net_open(). > > Signed-off-by: Usman Tanveer > --- > examples/ethtool/lib/rte_ethtool.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/examples/ethtool/lib/rte_ethtool.c > b/examples/ethtool/lib/rte_ethtool.c > index ffaad96498..0a000d0a7b

[PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

There is a call to rte_eth_dev_stop() in rte_ethtool_net_open() due to which user gets misleading message upon first open/start call. It says that the device is already stopped, which should not be the case. This patch removes rte_eth_dev_stop() from rte_ethtool_net_open(). Signed-off-by: Usman

Re: [PATCH] app/pdump: close program if --pdump argument is missing

The 20.11 release is not coming out till August, in the meantime, this patch can be applied to print help if mandatory argument is not passed. On Wed, Mar 2, 2022 at 9:52 PM Stephen Hemminger wrote: > > On Wed, 2 Mar 2022 14:26:14 +0500 > "usman.tanveer" wrote: > > > --pdump is a mandatory arg

[dpdk-dev] examples/ethtool: issue in rte_ethtool_net_open()

Hi, I have a question from dpdk-ethtool. *file: examples/ethtool/lib/rte_ethtool.c* *intrte_ethtool_net_open(uint16_t port_id){ int ret; ret = rte_eth_dev_stop(port_id); if (ret != 0) return ret; return rte_eth_dev_start(port_id);}* Does anyone know the purpose of calling rte_eth_dev_