Re: [dpdk-dev] [v4]net/hinic: fix coredump when the scondary process using the hinic port.

2021-03-17 Thread Wangxiaoyun (Cloud)
Hi Ferruh, For secondary process fix,you can refer to this patch "net/hinic: fix coredump when PMD used by fstack". Thanks 在 2020/11/12 20:30, Wangxiaoyun (Cloud) 写道: When we complete repair and testing, we will upstream the patch in next release, maybe not keep up with 20.1

Re: [dpdk-dev] [v4]net/hinic: fix coredump when the scondary process using the hinic port.

2020-11-12 Thread Wangxiaoyun (Cloud)
When we complete repair and testing, we will upstream the patch in next release, maybe not keep up with 20.11. 在 2020/11/12 17:26, Ferruh Yigit 写道: On 11/12/2020 2:11 AM, Wangxiaoyun (Cloud) wrote: Hi Ferruh, Align with Qingqing Li, this path will not apply to dpdk master now, some dev_ops

Re: [dpdk-dev] [v4]net/hinic: fix coredump when the scondary process using the hinic port.

2020-11-11 Thread Wangxiaoyun (Cloud)
Hi Ferruh, Align with Qingqing Li, this path will not apply to dpdk master now, some dev_ops may casue fail when run in secondary proc, so need to modify it later and add tests for other dev_ops. Thanks 在 2020/10/31 18:10, Qingqing Li 写道: fix coredump when secondary process using the hinic p

Re: [dpdk-dev] [PATCH v1 1/2] net/hinic: fix outer_l3_len parse error

2020-11-03 Thread Wangxiaoyun (Cloud)
Yes,the actual fix is following as this patch: commit 8c8b61234ffd9a283cecbf9751942cbdb87d68f6 Author: Xiaoyun Wang Date: Sat Jul 25 16:15:33 2020 +0800 net/hinic: refactor checksum functions Encapsulate different types of packet checksum preprocessing into functions. 在 2020/11

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-22 Thread Wangxiaoyun (Cloud)
Acked-by: Xiaoyun wang 在 2020/6/22 16:09, Wei Hu (Xavier) 写道: Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver does not support certain VLAN hardware offloads a

Re: [dpdk-dev] [PATCH v3 1/2] net/hinic/base: fix FW hotactive problem

2020-04-10 Thread Wangxiaoyun (Cloud)
Hi Ferruch, I will upstream a new patch to clarify the comments. Best regards xiaoyun wang 在 2020/4/4 1:24, Ferruh Yigit 写道: On 4/1/2020 10:30 AM, Xiaoyun wang wrote: When PF detects FW is hotactive, up returns HINIC_DEV_BUSY_ACTIVE_FW for Hi Xiaoyun, What is 'hotactive'? "hot active"? D

Re: [dpdk-dev] [PATCH v4 01/19] net/hinic/base: add mbox command channel for SRIOV

2019-10-28 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Gavin, Thanks for your comments, I will fix the code style issue in Patch v5, and the bit operation for hinic_test_bit and others has beed replaced with common rte_io_XX_bit APIs by Joyce Kong's pathces, I will check other remained bit operations and replace it with the common one. Best

Re: [dpdk-dev] [PATCH v6 00/15] A new net PMD - hinic

2019-10-28 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi David , Thanks for your comments, I check the test-report from dpdk.org(https://mails.dpdk.org/archives/test-report/2019-October/101893.html), which shows hinic pmd driver passed meson build on FreeBSD12-64, also I analysize the building errs, pthread_mutex_consistent is defined in on Fr

Re: [dpdk-dev] [PATCH v4 16/19] net/hinic: add hinic PMD doc files

2019-10-12 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Ferruh, Thanks for your comments and modify. Best Regards Xiaoyun Wang On 10/10/2019 3:52 PM, Xiaoyun wang wrote: Add new supported features to rst file and add features to ini file. Signed-off-by: Xiaoyun wang --- doc/guides/nics/features/hinic.ini | 2 ++ doc/guides/rel_no

Re: [dpdk-dev] [PATCH v3 00/19] Add advanced features for Huawei hinic pmd

2019-10-10 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Ferruh, I have deleted the seq_id getting logs, and we can get the infos by other method, which is updated by Patch V4. Best Regards, Xiaoyun Wang 在 2019/10/8 23:33, Ferruh Yigit 写道: On 10/8/2019 4:14 PM, Wangxiaoyun (Cloud, Network Chip Application Development Dept) wrote: Hi Ferruh

Re: [dpdk-dev] [PATCH v3 18/19] net/hinic: optimize RX performance

2019-10-08 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Ferruh, Thanks for your comments. I think you're right, i will modify it with Patch V4. Also I change it with the same structure for X86-64 and ARM platform with cache-aligned, and test the RX performance, all is OK. Best Regards Xiaoyun Wang 在 2019/9/30 23:10, Ferruh Yigit 写道: On 9/3

Re: [dpdk-dev] [PATCH v3 00/19] Add advanced features for Huawei hinic pmd

2019-10-08 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Ferruh, Thanks for your comments. hinic pmd driver doesn't support 32-bit build, we add descriptions with config file "defconfig_x86_x32-native-linuxapp-gcc". and “defconfig_x86_x32-native-linux-gcc”. I don't know why it also build in 32-bit platform, can you tell me where also need me to

Re: [dpdk-dev] [PATCH v2 17/17] net/hinic: optimize tx&rx performance

2019-09-30 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Gavin, Thanks for your comments. +#if defined(__ARM64_NEON__) No NEON intrinsics used, maybe RTE_ARCH_ARM64 is better. In the following line __rte_always_inline is commonly used in DPDK, the effect is same. /Gavin For this patch, we don't use NEON intrinsics, but for tx& rx pro

Re: [dpdk-dev] [PATCH v2 00/17] Add advanced features for Huawei hinic pmd

2019-09-30 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Ferruh, Thanks for your comments, I have sent a new patch V3 with new API changes, and add comments for every patch version, which is show in cover-letter patch, please check it. Best regards Xiaoyun Wang 在 2019/9/27 2:51, Ferruh Yigit 写道: On 9/25/2019 3:30 PM, Xiaoyun wang wrote: This

Re: [dpdk-dev] [PATCH v2 15/17] net/hinic: add hinic PMD doc files

2019-09-30 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Ferruh, Thanks for your comments. I send to you a new patch V3 with the following review comments fixed. 1) I have fixed SR-IOV with unix style; 2) I splited the hinic.ini and hinic.rst into releated feature patches; 3) I have updated the release_19_11.rst with next version. B

Re: [dpdk-dev] [PATCH v2 07/17] net/hinic: add fdir config interface

2019-09-30 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Ferruh, Thanks for your comments, I have fixed the patch comments with "net/hinic/base: add fdir config interface", and send a new patch V3 to you. Best regards Xiaoyun Wang 在 2019/9/27 2:48, Ferruh Yigit 写道: On 9/25/2019 3:30 PM, Xiaoyun wang wrote: This patch adds fdir config operat

Re: [dpdk-dev] [PATCH v2 05/17] net/hinic: add allmulticast mode and MTU set

2019-09-30 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Hi Ferruh, Thanks for your comments, I have added min_mtu & max_mtu to hinic_dev_infos_get interface, which will be shown in Patch V3. Best regards Xiaoyun Wang 在 2019/9/27 2:47, Ferruh Yigit 写道: On 9/25/2019 3:30 PM, Xiaoyun wang wrote: When enable allmulticast mode, all multicast packet

Re: [dpdk-dev] [PATCH v2 12/17] net/hinic: set link down and up

2019-09-30 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
Thanks for your comments, I have splited this patch into 2 patched, one is for link down and up,the other is for getting fw version. 在 2019/9/27 2:47, Ferruh Yigit 写道: On 9/25/2019 3:30 PM, Xiaoyun wang wrote: This patch supports setting link down and up, Also adds support for geting firmware

[dpdk-dev] 答复: [PATCH v2 12/17] net/hinic: set link down and up

2019-09-28 Thread Wangxiaoyun (Cloud, Network Chip Application Development Dept)
-邮件原件- 发件人: Ferruh Yigit [mailto:ferruh.yi...@intel.com] 发送时间: 2019年9月27日 2:48 收件人: Wangxiaoyun (Cloud, Network Chip Application Development Dept) 抄送: dev@dpdk.org; Xuanziyang (William); Shahar Belkar; Luoxianjun; Tanya Brokhman; zhouguoyang; Wulike (Collin) 主题: Re: [PATCH v2 12/17