Re: [dpdk-dev] [PATCH] eal: fix '--huge-unlink' option

2018-09-26 Thread Wodkowski, PawelX
Hi Anatoly, Can you take a look at this small fix. Thank you Paweł > -Original Message- > From: Wodkowski, PawelX > Sent: Friday, September 21, 2018 1:57 PM > To: dev@dpdk.org > Cc: Wodkowski, PawelX > Subject: [PATCH] eal: fix '--huge-unlink' option &g

Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs

2018-04-10 Thread Wodkowski, PawelX
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, April 10, 2018 9:44 AM > To: Wodkowski, PawelX ; Zhang, Roy Fan > ; dev@dpdk.org > Cc: jianjay.z...@huawei.com; Tan, Jianfeng > Subject: Re: [PATCH] lib/librte_vhost: f

Re: [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs

2018-04-10 Thread Wodkowski, PawelX
> # all source are stored in SRCS-y > SRCS-$(CONFIG_RTE_LIBRTE_VHOST) := fd_man.c iotlb.c socket.c vhost.c \ > diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c > index d84513e7f..2acfc908c 100644 > --- a/lib/librte_vhost/vhost_crypto.c > +++ b/lib/librte_vhost/vhost_

Re: [dpdk-dev] [PATCH v4 1/8] lib/librte_vhost: add external backend support

2018-04-03 Thread Wodkowski, PawelX
> -Original Message- > From: Tan, Jianfeng > Sent: Tuesday, April 3, 2018 4:43 PM > To: Maxime Coquelin ; Zhang, Roy Fan > ; Wodkowski, PawelX > ; dev@dpdk.org > Cc: jianjay.z...@huawei.com > Subject: Re: [dpdk-dev] [PATCH v4 1/8] lib/librte_vhost: add ex

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Wodkowski, PawelX
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Thursday, March 29, 2018 6:38 PM > To: Wodkowski, PawelX ; Tan, Jianfeng > ; Victor Kaplansky > Cc: dev@dpdk.org; sta...@dpdk.org; Yang, Yi Y ; > Harris, James R ; Yang, Zi

Re: [dpdk-dev] [PATCH v4 1/8] lib/librte_vhost: add external backend support

2018-03-29 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Thursday, March 29, 2018 2:53 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; jianjay.z...@huawei.com; Tan, Jianfeng > > Subject: [dpdk-dev] [PATCH v4 1/8] lib/librte_vhost: add external b

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2018-03-29 Thread Wodkowski, PawelX
> > DPDK vhost-user handles this message rudely by unmap all existing > > regions and map new ones. This might lead to segfault if there > > is pmd thread just trying to touch those unmapped memory regions. > > > > But for most cases, except VM memory hotplug, > >> > >> FYI, Vic

Re: [dpdk-dev] [PATCH v3 0/5] vhost: support selective datapath

2018-03-29 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhihong Wang > Sent: Tuesday, February 27, 2018 11:14 AM > To: dev@dpdk.org > Cc: Tan, Jianfeng ; Bie, Tiwei ; > maxime.coque...@redhat.com; y...@fridaylinux.org; Liang, Cunming > ; Wang, Xiao W ; Daly, > Dan ; Wang

Re: [dpdk-dev] [PATCH v2] vhost: add virtio configuration space messages

2018-03-28 Thread Wodkowski, PawelX
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, March 28, 2018 11:12 AM > To: Kulasek, TomaszX ; y...@fridaylinux.org > Cc: Verkamp, Daniel ; Harris, James R > ; Wodkowski, PawelX > ; dev@dpdk.org; Liu, Changp

Re: [dpdk-dev] [PATCH v2 01/10] lib/librte_vhost: add vhost user private info structure

2018-03-22 Thread Wodkowski, PawelX
> -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, March 21, 2018 5:12 PM > To: Maxime Coquelin ; dev@dpdk.org; > Kulasek, TomaszX ; Wodkowski, PawelX > > Cc: jianjay.z...@huawei.com; y...@fridaylinux.org; Tan, Jianfeng > ; Bie, Tiwei > Subject: RE:

Re: [dpdk-dev] [PATCH v2 01/10] lib/librte_vhost: add vhost user private info structure

2018-03-21 Thread Wodkowski, PawelX
> int > vhost_user_register_call_back(struct virtio_net *dev, msg_handler > post_msg_handler); > > > > > Also, it might be interesting for the external backend to register > > callbacks for > > existing requests. For example .pre_vhost_user_msg_handler > > and .post_vhost_user_msg_handler. Doing

Re: [dpdk-dev] [PATCH] vhost: stop device before updating public vring data

2018-03-07 Thread Wodkowski, PawelX
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, March 7, 2018 11:09 AM > To: Wodkowski, PawelX ; Kulasek, TomaszX > ; y...@fridaylinux.org > Cc: Verkamp, Daniel ; Harris, James R > ; dev@dpdk.org; Stojaczyk, Dari

Re: [dpdk-dev] [PATCH] vhost: stop device before updating public vring data

2018-03-07 Thread Wodkowski, PawelX
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, March 6, 2018 5:27 PM > To: Kulasek, TomaszX ; y...@fridaylinux.org > Cc: Verkamp, Daniel ; Harris, James R > ; Wodkowski, PawelX > ; dev@dpdk.org; Stojaczyk, DariuszX &g

Re: [dpdk-dev] [PATCH] maintainers: update job stats library

2017-10-24 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Tuesday, October 24, 2017 11:57 AM > To: tho...@monjalon.net > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] maintainers: update job stats library > > Signed-off-by: P

Re: [dpdk-dev] [PATCH v3] examples/vhost: introduce a new vhost-user-scsi sample application

2017-07-12 Thread Wodkowski, PawelX
Hi, sorry for late review but just spotted this patch. Please see my comments > diff --git a/examples/vhost_scsi/scsi.c b/examples/vhost_scsi/scsi.c > new file mode 100644 > index 000..08dfe61 > --- /dev/null > +++ b/examples/vhost_scsi/scsi.c > @@ -0,0 +1,507 @@ > +static int > +vhost_hex2bi

Re: [dpdk-dev] [PATCH] vfio: allow to map other memory regions

2017-06-28 Thread Wodkowski, PawelX
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, June 19, 2017 11:04 PM > To: Wodkowski, PawelX > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] vfio: allow to map other memory regions > > Hi, > Some comments below &

Re: [dpdk-dev] [PATCH] vfio: allow to map other memory regions

2017-06-05 Thread Wodkowski, PawelX
> -Original Message- > From: Wodkowski, PawelX > Sent: Monday, June 05, 2017 1:54 PM > To: Wodkowski, PawelX > Subject: [PATCH] vfio: allow to map other memory regions > > Currently it is not possible to use memory that is not owned by DPDK to > perform DMA. This

Re: [dpdk-dev] [RFC][PATCH] vfio: allow to map other memory regions

2017-05-18 Thread Wodkowski, PawelX
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, May 17, 2017 7:20 PM > To: Wodkowski, PawelX > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC][PATCH] vfio: allow to map other memory regions > > On Wed, 17

[dpdk-dev] [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel version

2015-05-28 Thread Wodkowski, PawelX
> -Original Message- > From: Buriez, Patrice > Sent: Thursday, May 28, 2015 1:07 PM > To: Wodkowski, PawelX; Simon K?gstr?m; Zhang, Helin; Alexander Guy; Julien > Cretin > Cc: dev at dpdk.org > Subject: RE: [PATCH] kni: Use utsrelease.h to determine Ubuntu kerne

[dpdk-dev] [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel version

2015-05-28 Thread Wodkowski, PawelX
> -Original Message- > From: Simon K?gstr?m [mailto:simon.kagstrom at netinsight.net] > Sent: Thursday, May 28, 2015 12:37 PM > To: Wodkowski, PawelX; Zhang, Helin; Alexander Guy; Julien Cretin; Buriez, > Patrice > Cc: dev at dpdk.org > Subject: Re: [PATCH] kni

[dpdk-dev] [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel version

2015-05-28 Thread Wodkowski, PawelX
> > > > -ifeq ($(shell test -f /proc/version_signature && lsb_release -si > > 2>/dev/null),Ubuntu) > > +ifeq ($(shell lsb_release -si 2>/dev/null),Ubuntu) > > MODULE_CFLAGS += -DUBUNTU_RELEASE_CODE=$(shell lsb_release -sr | tr - > d .) > > -UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version

[dpdk-dev] [PATCH 0/2] cmdline: add polling mode for command line

2015-05-12 Thread Wodkowski, PawelX
Self NACK - misconfigured git - wrong email address :( I will resend this. > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pawel Wodkowski > Sent: Tuesday, May 12, 2015 1:10 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 0/2] cmdline: add polling mode

[dpdk-dev] [PATCH 1/5] bond: use existing enslaved device queues

2015-04-14 Thread Wodkowski, PawelX
> > Pawel, > > I generally test things I've just built using virtio devices and calling > rte_eth_tx_queue_setup() more than once for a given queue id fails. > However, it seems that most PMDs allow re-allocating device queues while > virtio does not (xenvirt also seems to lack this functionality

[dpdk-dev] [PATCH 1/5] rte_timer: fix invalid declaration of rte_timer_cb_t

2015-02-24 Thread Wodkowski, PawelX
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, February 24, 2015 11:39 AM > To: Wodkowski, PawelX; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/5] rte_timer: fix invalid declaration of > rte_timer_cb_t > > Hi P

[dpdk-dev] [PATCH v5 0/3] new headroom stats library and example application

2015-02-24 Thread Wodkowski, PawelX
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, February 24, 2015 11:00 AM > To: Jastrzebski, MichalX K > Cc: Wodkowski, PawelX; dev at dpdk.org; Neil Horman > Subject: Re: [dpdk-dev] [PATCH v5 0/3] new headroom stats l

[dpdk-dev] [PATCH v5 0/3] new headroom stats library and example application

2015-02-24 Thread Wodkowski, PawelX
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, February 24, 2015 11:00 AM > To: Jastrzebski, MichalX K > Cc: Wodkowski, PawelX; dev at dpdk.org; Neil Horman > Subject: Re: [dpdk-dev] [PATCH v5 0/3] new headroom stats l

[dpdk-dev] [PATCH] ring: fix minor memory leak of kvlist in dev init

2015-02-23 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John McNamara > Sent: Monday, February 23, 2015 2:17 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] ring: fix minor memory leak of kvlist in dev init > > Fix for Klockwork identified issue. > > Signed

[dpdk-dev] [RFC PATCH] lib/librte_ethdev: Expand port identifier

2015-02-18 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, February 18, 2015 1:32 PM > To: Tetsuya Mukawa > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH] lib/librte_ethdev: Expand port identifier > > On Wed, Feb 18, 2015 a

[dpdk-dev] [PATCH v3 0/2] new headroom stats library and example application

2015-02-17 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pawel Wodkowski > Sent: Tuesday, February 17, 2015 5:20 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3 0/2] new headroom stats library and example > application > > Hi community, > I would like to intr

[dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4 header files

2015-01-30 Thread Wodkowski, PawelX
> -Original Message- > From: Doherty, Declan > Sent: Friday, January 30, 2015 12:42 PM > To: Wodkowski, PawelX; Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4 header > files > > On 30

[dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4 header files

2015-01-30 Thread Wodkowski, PawelX
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, January 30, 2015 11:21 AM > To: Wodkowski, PawelX > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4 header > fil

[dpdk-dev] [PATCH 0/2] new headroom stats library and example application

2015-01-30 Thread Wodkowski, PawelX
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Thursday, January 29, 2015 8:13 PM > To: Wodkowski, PawelX > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/2] new headroom stats library and example > application > >

[dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss

2015-01-30 Thread Wodkowski, PawelX
> -Original Message- > From: Ouyang, Changchun > Sent: Friday, January 30, 2015 2:20 AM > To: Wodkowski, PawelX; Thomas Monjalon; Richardson, Bruce > Cc: dev at dpdk.org; Ouyang, Changchun > Subject: RE: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf

[dpdk-dev] [PATCH 0/2] new headroom stats library and example application

2015-01-29 Thread Wodkowski, PawelX
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Thursday, January 29, 2015 2:25 PM > To: Wodkowski, PawelX > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/2] new headroom stats library and example > application > > On

[dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss

2015-01-29 Thread Wodkowski, PawelX
essary check in vf rss > > > > > To follow up the comments from Wodkowski, PawelX, remove this > > > unnecessary check, as check_mq_mode has already check the queue > > number > > > in device configure stage, if the queue number of vf is not correct, > >

[dpdk-dev] Pktgen-DPDK rate and traffic inconsistency problem

2015-01-28 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Alexandre Frigon > Sent: Tuesday, January 27, 2015 8:31 PM > To: dev at dpdk.org > Subject: [dpdk-dev] Pktgen-DPDK rate and traffic inconsistency problem > > Hi all, > > I'm using dpdk 1.8 and pktgen-dpdk 2.8

[dpdk-dev] [PATCH 4/4] lib/librte_eal: Optimized memcpy in arch/x86/rte_memcpy.h for both SSE and AVX platforms

2015-01-26 Thread Wodkowski, PawelX
Hi, I must say: greate work. I have some small comments: > +/** > + * Macro for copying unaligned block from one location to another, > + * 47 bytes leftover maximum, > + * locations should not overlap. > + * Requirements: > + * - Store is aligned > + * - Load offset is , which must be immediate

[dpdk-dev] [PATCH v1 02/15] eal: new eal option '--lcores' for cpu assignment

2015-01-22 Thread Wodkowski, PawelX
Hi, I want to mention that similar but for me much more readable syntax have Pktgen-DPDK for defining core - port mapping. Maybe we can adopt this syntax for new '--lcores' parameter. See '-m' parameter syntax on Pktgen readme. https://github.com/pktgen/Pktgen-DPDK/blob/master/dpdk/examples/pktge

[dpdk-dev] [PATCH v6 5/6] ixgbe: Config VF RSS

2015-01-22 Thread Wodkowski, PawelX
> > I'm new on the list and my experience with DPDK is about two months so, > pls., don't judge me too harsh... ;) > I tried to cover the obvious things and actually learned the code while > reviewing. The things u say, Pavel(X?) make sense and I obviously missed I am really puzzled about mail cl

[dpdk-dev] [PATCH v6 5/6] ixgbe: Config VF RSS

2015-01-21 Thread Wodkowski, PawelX
> -Original Message- > From: Ouyang, Changchun > Sent: Wednesday, January 21, 2015 3:44 AM > To: Wodkowski, PawelX; dev at dpdk.org > Cc: Ouyang, Changchun > Subject: RE: [dpdk-dev] [PATCH v6 5/6] ixgbe: Config VF RSS > > > > > -Original Message

[dpdk-dev] [PATCH v6 5/6] ixgbe: Config VF RSS

2015-01-20 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun > Sent: Monday, January 12, 2015 6:59 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v6 5/6] ixgbe: Config VF RSS > > It needs config RSS and IXGBE_MRQC and IXGBE_VFPSRTYPE to enable VF R

[dpdk-dev] [PATCH v2 2/4] ethdev: prevent changing of nb_q_per_pool in rte_eth_dev_check_mq_mode()

2015-01-20 Thread Wodkowski, PawelX
> -Original Message- > From: Ouyang, Changchun > Sent: Tuesday, January 20, 2015 2:33 AM > To: Wodkowski, PawelX; dev at dpdk.org > Cc: Ouyang, Changchun > Subject: RE: [dpdk-dev] [PATCH v2 2/4] ethdev: prevent changing of > nb_q_per_pool in rte_

[dpdk-dev] [PATCH v6 4/6] ether: Check VMDq RSS mode

2015-01-19 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun > Sent: Monday, January 12, 2015 6:59 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v6 4/6] ether: Check VMDq RSS mode > > Check mq mode for VMDq RSS, handle it correctly instead of retu

[dpdk-dev] [PATCH v6 3/6] ixgbe: Get VF queue number

2015-01-19 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun > Sent: Monday, January 12, 2015 6:59 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v6 3/6] ixgbe: Get VF queue number > > Get the available Rx and Tx queue number when receiving > IXG

[dpdk-dev] [PATCH] ethdev: fix missing parenthesis

2015-01-16 Thread Wodkowski, PawelX
> Good catch! > Was introduced in commit 4bdefaade6d1 (VMDQ enhancements). > Note that quite often, when a patch contains too much things, > we miss this kind of bugs. That's a reason to well split patches. > What is most surprising I did not spotted this, neither the compiler what I think it sh

[dpdk-dev] [PATCH 1/2] pmd: add DCB for VF for ixgbe

2015-01-14 Thread Wodkowski, PawelX
> > > > > > - split nb_q_per_pool to nb_rx_q_per_pool and nb_tx_q_per_pool > > > > > > Rationale: > > > > > > rx and tx number of queue might be different if RX and TX are > > > > > > configured in different mode. This allow to inform VF about > > > > > > proper number of queues.

[dpdk-dev] [PATCH 2/2] testpmd: fix dcb in vt mode

2015-01-13 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Tuesday, January 13, 2015 11:16 AM > To: Jastrzebski, MichalX K; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] testpmd: fix dcb in vt mode > > > On 01/12/15 17:50, Michal Jastrzeb

[dpdk-dev] [PATCH 1/2] pmd: add DCB for VF for ixgbe

2015-01-13 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Tuesday, January 13, 2015 11:14 AM > To: Jastrzebski, MichalX K; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] pmd: add DCB for VF for ixgbe > > > On 01/12/15 17:50, Michal Jastrz

[dpdk-dev] [PATCH 0/2] Enable DCB in SRIOV mode for ixgbe driver

2015-01-13 Thread Wodkowski, PawelX
Comments are more than welcome :) Pawel

[dpdk-dev] [PATCH] bond: vlan flags misinterpreted in xmit_slave_hash function

2014-12-16 Thread Wodkowski, PawelX
> -Original Message- > From: Doherty, Declan > Sent: Tuesday, December 16, 2014 12:16 PM > To: dev at dpdk.org > Cc: Wodkowski, PawelX; Doherty, Declan > Subject: [PATCH] bond: vlan flags misinterpreted in xmit_slave_hash function > > - Split transmit hashin

[dpdk-dev] [PATCH v2] bond: static analysis issues fix

2014-12-16 Thread Wodkowski, PawelX
> -Original Message- > From: Doherty, Declan > Sent: Monday, December 15, 2014 6:14 PM > To: dev at dpdk.org > Cc: Wodkowski, PawelX; Doherty, Declan > Subject: [PATCH v2] bond: static analysis issues fix > > -v2: > Incorporates Pawel's comment

[dpdk-dev] error: value computed is not used

2014-12-15 Thread Wodkowski, PawelX
> > > > And something like this? > > > > > > > > #define rte_memcpy(dst, src, n) \ > > > > - ((__builtin_constant_p(n)) ? \ > > > > + ({ (__builtin_constant_p(n)) ? \ > > > > memcpy((dst), (src), (n)) : \ > > > > - rte_memcpy_func((

[dpdk-dev] error: value computed is not used

2014-12-15 Thread Wodkowski, PawelX
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, December 15, 2014 2:27 PM > To: Wodkowski, PawelX > Cc: Qiu, Michael; dev at dpdk.org > Subject: Re: [dpdk-dev] error: value computed is not used > > 2014-12-15

[dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library

2014-12-15 Thread Wodkowski, PawelX
> Because it doesn't work correctly :-) It should, what I am missing here? :P Pawel

[dpdk-dev] error: value computed is not used

2014-12-15 Thread Wodkowski, PawelX
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, December 15, 2014 11:55 AM > To: Wodkowski, PawelX; Qiu, Michael > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] error: value computed is not used > > 2014-12-08

[dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library

2014-12-15 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jay Rolette > Sent: Thursday, December 11, 2014 5:06 PM > To: Dev > Subject: [dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with > qsort() from standard library > > Signed-off-by: Jay Rolette > -

[dpdk-dev] [PATCH] bond: static analysis issues fix

2014-12-12 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Declan Doherty > Sent: Friday, December 12, 2014 6:40 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] bond: static analysis issues fix > > Fixes for link bonding library identified by static analysis to

[dpdk-dev] Added Spinlock to l3fwd-vf example to prevent race conditioning

2014-12-10 Thread Wodkowski, PawelX
> Though, that said, doesn't it seem to anyone else like serialization of > enqueue > to a port should be the responsibility of the library, not the application? > > Neil >From my knowledge it is an application responsibility to serialize access to queue on particular port. Pawel

[dpdk-dev] error: value computed is not used

2014-12-08 Thread Wodkowski, PawelX
> -Original Message- > From: Qiu, Michael > Sent: Monday, December 08, 2014 4:24 PM > To: Wodkowski, PawelX; dev at dpdk.org > Subject: Re: error: value computed is not used > > On 2014/12/8 19:00, Wodkowski, PawelX wrote: > >> lib/librte_pmd

[dpdk-dev] [PATCH v2] bond: fix for mac assignment to slaves device

2014-12-08 Thread Wodkowski, PawelX
> -Original Message- > From: Doherty, Declan > Sent: Monday, December 08, 2014 12:20 PM > To: dev at dpdk.org > Cc: Wodkowski, PawelX; Jiajia, SunX; Doherty, Declan > Subject: [PATCH v2] bond: fix for mac assignment to slaves device > > -V2: > Tidies up the s

[dpdk-dev] error: value computed is not used

2014-12-08 Thread Wodkowski, PawelX
> lib/librte_pmd_enic/enic_main.c: In function 'enic_set_rsskey': > lib/librte_pmd_enic/enic_main.c:862:2: error: value computed is not used > > I dig out that, it was ome issue of the macros rte_memcpy() > #define rte_memcpy(dst, src, n) \ > ((__builtin_constant_p(n)) ?

[dpdk-dev] [PATCH] bond: fix for mac assignment to slaves device

2014-12-08 Thread Wodkowski, PawelX
Some formatting issues during posting. I was talking about parenthesis in count calculation (sizeof(internals->slaves[0]) * internals->slave_count - i - 1));

[dpdk-dev] [PATCH] bond: fix for mac assignment to slaves device

2014-12-08 Thread Wodkowski, PawelX
> + memmove(&internals->slaves[i], &internals- > >slaves[i+1], > + (sizeof(internals->slaves[0]) * ^^^ > + internals->slave_count - i

[dpdk-dev] [PATCH v6 4/6] enicpmd: pmd specific code

2014-11-27 Thread Wodkowski, PawelX
> diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c > new file mode 100644 > index 000..c047cc8 > --- /dev/null > +++ b/lib/librte_pmd_enic/enic_main.c > @@ -0,0 +1,1266 @@ > +/* > + * Copyright 2008-2014 Cisco Systems, Inc. All rights reserved. > +#ident "$Id$"

[dpdk-dev] [PATCH v6 2/2] testpmd: add mode 4 support v6

2014-11-26 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, November 26, 2014 1:31 PM > To: Jastrzebski, MichalX K > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 2/2] testpmd: add mode 4 support v6 > > 2014-11-26 11:17, Micha

[dpdk-dev] [PATCH v5 0/2] bond: mode 4 support

2014-11-25 Thread Wodkowski, PawelX
Some information detail about mode mode 4 of link bonding: This mode is described in IEEE 802.3ad/AX standard described. It is also described here https://www.kernel.org/doc/Documentation/networking/bonding.txt. In this implementation we have an array of mode 4 setting for each slave. There is al

[dpdk-dev] [PATCH v3 0/2] bond: mode 4 support

2014-11-07 Thread Wodkowski, PawelX
Pawe? > -Original Message- > From: Wodkowski, PawelX > Sent: Friday, November 07, 2014 16:05 > To: De Lara Guarch, Pablo; Jastrzebski, MichalX K > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 0/2] bond: mode 4 support > > > Since Declan sent a

[dpdk-dev] [PATCH v3 0/2] bond: mode 4 support

2014-11-07 Thread Wodkowski, PawelX
> Since Declan sent a v6 for link bonding changes, maybe it is a good idea > to send another version, as v5 will not be merged. > > Pablo Hi Pablo I compared v6 patches vs patches produced by git rebase v5 patches on top which I used to produce mode 4 v3 patches and I think they are compatible.

[dpdk-dev] [PATCH v3 1/2] bond: add mode 4 support

2014-11-07 Thread Wodkowski, PawelX
> > Hi, > > 2014-11-07 11:04, Michal Jastrzebski: > > From: Pawel Wodkowski > > > > > > Signed-off-by: Pawel Wodkowski > > Michal, if you worked on this patch you should add your signed-off-by. > I temporary lost ability to use git send-email command so I asked Michal to send those patches

[dpdk-dev] [PATCH v2] Change alarm cancel function to thread-safe:

2014-09-30 Thread Wodkowski, PawelX
> -Original Message- > Pawe? > > > On Mon, Sep 29, 2014 at 10:11:38AM +0000, Wodkowski, PawelX wrote: > > > > > > > > > > Image how you will be damned by someone that not even notice you > > change > > > > > an

[dpdk-dev] [PATCH v2] bond: Add mode 4 support.

2014-09-30 Thread Wodkowski, PawelX
Fixed patch version sent. Pawel

[dpdk-dev] [PATCH v2] Change alarm cancel function to thread-safe:

2014-09-30 Thread Wodkowski, PawelX
Pawe? > -Original Message- > From: Richardson, Bruce > Sent: Monday, September 29, 2014 12:33 > To: Wodkowski, PawelX > Cc: Ananyev, Konstantin; Neil Horman; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] Change alarm cancel function to thread- > safe: > &

[dpdk-dev] [PATCH v2] Change alarm cancel function to thread-safe:

2014-09-29 Thread Wodkowski, PawelX
> > > > Image how you will be damned by someone that not even notice you change > > and he Is managing some kind of resource based on returned number of > > set/canceled timers. If you suddenly start returning negative values how > > those > > application will behave? Silently changing returned va

[dpdk-dev] [PATCH v2] Change alarm cancel function to thread-safe:

2014-09-29 Thread Wodkowski, PawelX
> Yes, this is my concern exactly. > > > If that's so, then I suppose we can do: make alarm_cancel() to return a > negative value for the case #3 (-EINPROGRESS or something). > > Something like: > > ... > > if (ap->executing == 0) { > >LIST_REMOVE(ap,next); > > rte_free(ap); > > coun

[dpdk-dev] [PATCH v2] Change alarm cancel function to thread-safe:

2014-09-26 Thread Wodkowski, PawelX
> > > Maybe I don't see something obvious? :) > > I think you're missing the fact that your patch doesn't do what you assert > above > either :) Issue is not in setting alarms but canceling it. If you look closer to my patch you see that it address this issue (look at added *do { lock(); ;

[dpdk-dev] [PATCH v2] Change alarm cancel function to thread-safe:

2014-09-26 Thread Wodkowski, PawelX
> So basically cancel() just set ALARM_CANCELLED and leaves actual alarm > deletion to the callback()? > That was the thought, yes. > > > I think it is doable - but I don't see any real advantage with that > > approach. > > Yes, code will become a bit simpler, as we'll have one point when we rem

[dpdk-dev] [PATCH v2] Change alarm cancel function to thread-safe:

2014-09-26 Thread Wodkowski, PawelX
> > > > diff --git a/lib/librte_eal/linuxapp/eal/eal_alarm.c > > b/lib/librte_eal/linuxapp/eal/eal_alarm.c > > index 480f0cb..73b6dc5 100644 > > --- a/lib/librte_eal/linuxapp/eal/eal_alarm.c > > +++ b/lib/librte_eal/linuxapp/eal/eal_alarm.c > > @@ -64,6 +64,9 @@ > > #define MS_PER_S 1000 > > #def

[dpdk-dev] [PATCH v2] Change alarm cancel function to thread-safe:

2014-09-26 Thread Wodkowski, PawelX
> Given what you said above, I agree, at least in the current implementation. > It > still seems like theres a simpler solution that doesn't require all the > comparative gymnastics. Yes, there is simpler solution, but this solution involve recursive locking. DPDK recursive spinlocks are no an o

[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

2014-09-22 Thread Wodkowski, PawelX
> I think that will work, but I believe you're making it more complicated (and > less reusable) than it needs to be. What I think you really need to do is > create a new rte api call, rte_eal_alarm_cancel_sync (something like the > equivalent of del_timer_sync in linux, that wraps up the > while(r

[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

2014-09-19 Thread Wodkowski, PawelX
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Thursday, September 18, 2014 18:03 > To: Wodkowski, PawelX > Cc: dev at dpdk.org; Jastrzebski, MichalX K; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH 2/2] bond: add mode 4 support &

[dpdk-dev] [PATCH 2/2] bond: add mode 4 support

2014-09-18 Thread Wodkowski, PawelX
> > +int > > +bond_mode_8023ad_deactivate_slave(struct rte_eth_dev *bond_dev, > > + uint8_t slave_pos) > > +{ > > + struct bond_dev_private *internals = bond_dev->data->dev_private; > > + struct mode8023ad_data *data = &internals->mode4; > > + struct port *port; > > + uint8_t i; >

[dpdk-dev] [PATCH] ixgbe_rx_scan_hw_ring: Fix initializing id and hash fields in flow director mode.

2014-09-08 Thread Wodkowski, PawelX
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, August 29, 2014 17:41 > To: dev at dpdk.org > Cc: Wodkowski, PawelX > Subject: Re: [dpdk-dev] [PATCH] ixgbe_rx_scan_hw_ring: Fix initializing id and > hash fields

[dpdk-dev] a NIC binding to igb_uio module of DPDK is down

2014-08-13 Thread Wodkowski, PawelX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of BYEONG-GI KIM > Sent: Wednesday, August 13, 2014 06:27 > To: dev at dpdk.org; Dpdk-ovs at lists.01.org > Subject: [dpdk-dev] a NIC binding to igb_uio module of DPDK is down > > Hello. > > I deployed openstack w

[dpdk-dev] SRIOV mode and different RX and TX configuration

2014-08-11 Thread Wodkowski, PawelX
> Do you mean the configurable number of rx/tx queues in VF? For Niantic, > hardware just supports only one queue in VF, so there is no flexibility for > that. > For later NICs like i40e, we will have that flexibility. Yes, you are right but only in when DCB and RSS/TSS are off. When using DCB a

[dpdk-dev] SRIOV mode and different RX and TX configuration

2014-08-11 Thread Wodkowski, PawelX
Hi, I am wondering if there is a sense in having different configuration in for RX and TX mode in SR-IOV mode. Ex RX mode ETH_MQ_RX_NONE and TX mode ETH_MQ_TX_VMDQ_DCB or something similar. I am asking because in code there is no difference between number of RX queues and TX queues reported to VF a

[dpdk-dev] About round trip latency with DPDK

2014-07-24 Thread Wodkowski, PawelX
Refer to DPDK getting started guide paragraph 5.4. It might help. Also it might be easier to do write simple application that send a packet on port 1 and rx it on port 2 in separate threads on separate cores (simple physical loop). You can then add timestamp and send packet back and see how long