te 0 pattern pppoe_proto_id is
Fixes: 226c6e60c35b ("ethdev: add PPPoE to flow API")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v2 change the command line according to review comments.
---
app/test-pmd/cmdline_flow.c | 8 +---
1 file changed, 5 insertions(+), 3 deletion
The command line to create RTE flow for specific proto_id of PPPOES is
not correct. This patch is to fix this issue.
Fixes: 226c6e60c35b ("ethdev: add PPPoE to flow API")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
app/test-pmd/cmdline_flow.c | 13 +++--
1 file
, when
create rules for PFCP Session header with certain SEID the S field need
be set 1.
Signed-off-by: Xiao Zhang
---
v2 - change type of msg_len and seid to BE format.
---
app/test-pmd/cmdline_flow.c | 37 +
doc/guides/prog_guide/rte_flow.rst
Return ENOTSUP error code when configuring i40evf promiscuous mode to
fix port start hang issue on platforms which are unsupported to configure
promiscuous mode.
Fixes: ddc7cb0d9453 ("net/i40e: re-program promiscuous mode on VF
interface")
Cc: sta...@dpdk.org
Signed-off-by:
, when
create rules for PFCP Session header with certain SEID the S field need
be set 1.
Signed-off-by: Xiao Zhang
---
app/test-pmd/cmdline_flow.c | 37 +
doc/guides/prog_guide/rte_flow.rst | 11 +
doc/guides/testpmd_app_ug
Some illegal packets will lead to TX hang. This patch checks those
illegal packets and protects TX from hanging.
Fixes: 7829b8d52be0 ("net/ixgbe: add Tx preparation")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v2 change the minimum packet length according to the datasheet.
--
Some illegal packets will lead to TX hang. This patch checks those illegal
packets and protects TX from hanging.
Fixes: 7829b8d52be0 ("net/ixgbe: add Tx preparation")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++
drivers/net/ixgbe/ixgbe_
Add AH and AH SPI to testpmd rte flow command line.
Add note and sample AH rules in testpmd guide.
Signed-off-by: Xiao Zhang
---
v2 Add sample rules in testpmd guide.
---
app/test-pmd/cmdline_flow.c | 29 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst
add ITEM_AH
add ITEM_AH_SPI
Signed-off-by: Xiao Zhang
---
app/test-pmd/cmdline_flow.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index c2cc4c5..680cb1c 100644
--- a/app/test-pmd/cmdline_flow.c
t;net/ixgbe: improve link state check on VF")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
Reviewed-by: Wei Zhao
---
v2
Rebase the patch to latest master code.
---
drivers/net/ixgbe/ixgbe_ethdev.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/d
ned-off-by: Xiao Zhang
---
v3
Checking more places using max packet len.
v2
Add fix for i40evf and correct the checking when using the max_pkt_len.
---
drivers/net/i40e/i40e_ethdev.c| 2 +-
drivers/net/i40e/i40e_ethdev_vf.c | 11 +++
drivers/net/i40e/i40e_fdir.c | 2 +-
driver
ned-off-by: Xiao Zhang
---
v2
add fix for i40evf and correct the checking when using the max_pkt_len.
---
drivers/net/i40e/i40e_ethdev.c| 2 +-
drivers/net/i40e/i40e_ethdev_vf.c | 8 +---
drivers/net/i40e/i40e_rxtx.c | 6 --
3 files changed, 10 insertions(+), 6 deletions(-)
diff --git
poll mode driver")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v2
Correct the fixline and remove temporary variable.
---
drivers/net/i40e/i40e_rxtx.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rx
ivate
size")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/i40e/i40e_rxtx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index bfe161f..ca15b12 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/d
vlan packets with ip length bigger then 1496 will not be received by
i40e due to wrong packets size checking. This patch fixes the issue by
correcting the maximum frame size during checking.
Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines")
Cc: sta...@dpdk.org
Signed-of
")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/e1000/em_rxtx.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c
index 5925e49..49c5371 100644
--- a/drivers/net/e1000/em_rxtx.c
+++ b/drivers/net/
The mac types of i219 are e1000_pch_spt and e1000_pch_cnp, correct the
checking code of mac type when flushing i219 descriptor rings.
Fixes: 1fc9701238ed ("net/e1000: fix i219 hang on reset/close")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/e1000/em_ethdev.c | 2
Interrupt will not be received when disabling RX interrupt without
synchronization mechanism sometimes which leads to wake up issue,
add spinlock to fix it.
Fixes: b736d64787fc ("mples/l3fwd-power: disable Rx interrupt when
waking up")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
not work for X722 vf, use aq command to
setup the LUT to make it work properly.
Fixes: cea7a51c1750 ("i40evf: support RSS")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v6 update commit message
v5 fix compile issue
v4 move local variable definition to the begin of the function
v
.
Fixes: cea7a51c1750 ("i40evf: support RSS")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v5 fix compile issue
v4 move local variable definition to the begin of the function
v3 move LUT configuration in to i40evf_configure_rss
v2 change for loop format to avoid build patch issue
--
.
Fixes: cea7a51c1750 ("i40evf: support RSS")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v4 move local variable definition to the begin of the function
v3 move LUT configuration in to i40evf_configure_rss
v2 change for loop format to avoid build patch issue
---
driver
.
Fixes: cea7a51c1750 ("i40evf: support RSS")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v3 move LUT configuration in to i40evf_configure_rss
v2 change for loop format to avoid build patch issue
---
drivers/net/i40e/i40e_ethdev_vf.c | 32 ++--
1 file c
.
Fixes: cea7a51c1750 ("i40evf: support RSS")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v2 change for loop format to avoid build patch issue.
---
drivers/net/i40e/i40e_ethdev_vf.c | 36 +---
1 file changed, 29 insertions(+), 7 deletions(-)
di
properly.
Fixes: cea7a51c1750 ("i40evf: support RSS")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/i40e/i40e_ethdev_vf.c | 35 ---
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
b/driver
This patch fixes (dereference after null check) coverity issue.
The address of first segmented packets was not set correctly during
reassembling packets which led to this issue.
Coverity issue: 343416
Fixes: fe65e1e1 ("fm10k: add vector scatter Rx")
Cc: sta...@dpdk.org
Signed-off-by:
)
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
index c9ba482..599ba30 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c
+++
.@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/ice/ice_rxtx_vec_avx2.c | 1 +
drivers/net/ice/ice_rxtx_vec_sse.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/ice/ice_rxtx_vec_avx2.c
b/drivers/net/ice/ice_rxtx_vec_avx2.c
index fac869a..5ce29c2 100644
--- a/drive
This patch fixes (dereference after null check) coverity issue.
The address of first segmented packets was not set correctly during
reassembling packets which led to this issue.
Coverity issue: 343447
Fixes: 319c421f ("net/avf: enable SSE Rx Tx")
Cc: sta...@dpdk.org
Signed-off-by:
ector
driver")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/i40e/i40e_rxtx_vec_avx2.c | 1 +
drivers/net/i40e/i40e_rxtx_vec_sse.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/i40e/i40e_rxtx_vec_avx2.c
b/drivers/net/i40e/i40e_rxtx_vec_avx2.c
index c4dc99
k: add vector scatter Rx")
Coverity issue: 13245
Fixes: 8a44c15a ("net/ixgbe: extract non-x86 specific code from vector driver")
Cc: sta...@dpdk.org
v2 Add cover letter and move the fix after invalidation check
Xiao Zhang (5):
net/ixgbe: fix dereference after null check coverity
Add return value checking when reading configure information from PCI
register to avoid coverity issue.
Fixes: 1fc97012 ("net/e1000: fix i219 hang on reset/close")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/e1000/em_rxtx.c | 18 +++---
1 file c
The address of receive queue start segment was not updated when found by
iterated checking, update the address to fix coverity issue.
Coverity issue: 343452
Coverity issue: 343407
Fixes: c68a52b8 ("net/ice: support vector SSE in Rx")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
--
The address of receive queue start segment was not updated when found by
iterated checking, update the address to fix coverity issue.
Coverity issue: 13245
Fixes: 8a44c15a ("net/ixgbe: extract non-x86 specific code from vector
driver")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
--
The address of receive queue start segment was not updated when found by
iterated checking, update the address to fix coverity issue.
Coverity issue: 343447
Fixes: 319c421f ("net/avf: enable SSE Rx Tx")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/iavf/iavf_rxtx_vec
ned-off-by: Xiao Zhang
---
drivers/net/i40e/i40e_rxtx_vec_avx2.c | 1 +
drivers/net/i40e/i40e_rxtx_vec_sse.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/i40e/i40e_rxtx_vec_avx2.c
b/drivers/net/i40e/i40e_rxtx_vec_avx2.c
index c4dc990..0cbb2c2 100644
--- a/driver
The address of receive queue start segment was not updated when found by
iterated checking, update the address to fix coverity issue.
Coverity issue: 343416
Fixes: fe65e1e1 ("fm10k: add vector scatter Rx")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/fm10k/fm10k_
Add multiple processes support for ice, secondary processes will share
memory and configuration with primary process, do not need further
initialization for secondary processes.
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v3 Update the title and commit message.
v2 Remove limitation for
Add multiple processes support for CVL, secondary processes will share
memory and configuration with primary process, do not need further
initialization for secondary processes.
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v2 Remove limitation for secondary processes control path
("e1000: support EM devices (also known as e1000/e1000e)")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v8 Modify to follow code style of dpdk community.
v7 Add fix line.
v6 Change the fix on em driver instead of igb driver and update the
register address according to C-Spec.
v5
("e1000: support EM devices (also known as e1000/e1000e)")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v7 Add fix line.
v6 Change the fix on em driver instead of igb driver and update the
register address according to C-Spec.
v5 Change the subject.
v4 Correct the tail descriptor of t
Signed-off-by: Xiao Zhang
---
v6 Change the fix on em driver instead of igb driver and update the
register address according to C-Spec.
v5 Change the subject.
v4 Correct the tail descriptor of tx ring.
v3 Add loop to handle all tx and rx queues.
v2 Use configuration register instead of NVM7 to
: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v2
Change the fix from igb_rxtx to em_rxtx, since i219 use em PMD.
v1
Apply kernel fix to igb PMD driver.
---
drivers/net/e1000/base/e1000_ich8lan.h | 1 +
drivers/net/e1000/em_rxtx.c| 16
2 files changed, 17 insertions
be allowed to do configuration but share from primary process.
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/ice/ice_ethdev.c | 85
drivers/net/ice/ice_rxtx.c | 24 +
2 files changed, 109 insertions(+)
diff --git a
be allowed to do configuration but share from primary process.
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
drivers/net/ice/ice_ethdev.c | 85
drivers/net/ice/ice_rxtx.c | 24 +
2 files changed, 109 insertions(+)
diff --git a
ch AQ instead of register
setting")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v4
Add more detailed information in the commit log.
v3
Modify the commit log to make it not confused and add fixed line.
v2
Unset adminq flag instead of only checking device id when set TPID.
v1
Check device id wh
witch AQ instead of register
setting")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v3
Modify the commit log to make it not confused and add fixed line.
v2
Unset adminq flag instead of only checking device id when set TPID.
v1
Check device id when setting TPID, use adminq if not SFP
FW4.16 of SFP X722 does not support setting TPID by set_switch_config
adminq operation, for firmware version less than 4.16 TPID is set by
register instead. For device SFP X722, disable adminq flag to follow
the same path with old firmware version to make it work.
Signed-off-by: Xiao Zhang
FW4.16 of SFP X722 does not support setting TPID by set_switch_config
adminq operation, for firmware version less than 4.16 TPID is set by
register instead. Follow the same path with new firmware version for
SFP X722 to make it work.
Signed-off-by: Xiao Zhang
---
drivers/net/i40e/i40e_ethdev.c
k: add vector scatter Rx")
Coverity issue: 13245
Fixes: 8a44c15a ("net/ixgbe: extract non-x86 specific code from vector driver")
Cc: sta...@dpdk.org
Signed-off-by: Xiao Zhang
---
v2 changes:
* update commit log with fixes information.
drivers/net/fm10k/fm10k_rxtx_vec.c| 3
This patch tries to fix the coverity issues of dereference after null
check.
Coverity issue: 343452
Coverity issue: 343447
Coverity issue: 343422
Coverity issue: 343416
Coverity issue: 343407
Coverity issue: 343403
Coverity issue: 13245
Signed-off-by: Xiao Zhang
---
drivers/net/fm10k
Unit hang may occur if multiple descriptors are available in the rings
during reset or close. This state can be detected by configure status
by bit 8 in register. If the bit is set and there are pending descriptors
in one of the rings, we must flush them before reset or close.
Signed-off-by: Xiao
Unit hang may occur if multiple descriptors are available in the rings
during reset or close. This state can be detected by configure status
by bit 8 in register. If the bit is set and there are pending descriptors
in one of the rings, we must flush them before reset or close.
Signed-off-by: Xiao
Unit hang may occur if multiple descriptors are available in the rings
during reset or close. This state can be detected by configure status
by bit 8 in register. If the bit is set and there are pending descriptors
in one of the rings, we must flush them before reset or close.
Signed-off-by: Xiao
-off-by: Xiao Zhang
---
drivers/net/e1000/base/e1000_ich8lan.h | 1 +
drivers/net/e1000/igb_rxtx.c | 16
2 files changed, 17 insertions(+)
diff --git a/drivers/net/e1000/base/e1000_ich8lan.h
b/drivers/net/e1000/base/e1000_ich8lan.h
index 1f2a3f8..084eb9c 100644
--- a
Unit hang may occur if multiple descriptors are available in the rings
during reset or close. This state can be detected by configure status
by bit 8 in register. If the bit is set and there are pending descriptors
in one of the rings, we must flush them before reset or close.
Signed-off-by: Xiao
Unit hang may occur if multiple descriptors are available in the rings during
reset or close. Flush them before reset or close to avoid the issue.
Change-Id: Ia5e8dd06ad890d19f5093f1696faf68f7f52b491
Signed-off-by: Xiao Zhang
---
drivers/net/e1000/base/e1000_ich8lan.h | 1 +
drivers/net/e1000
56 matches
Mail list logo
