Re: [EXT] Libtpa: a DPDK based userspace TCP stack implementation

2023-12-11 Thread Yuanhan Liu
On Mon, Dec 11, 2023 at 01:16:52PM +0100, Thomas Monjalon wrote: > 11/12/2023 12:32, Jerin Jacob Kollanukkaran: > > From: Yuanhan Liu > > > Hi all, > > > > > > I'd like to share a new DPDK open source project, libtpa(Transport > > > Prot

Re: [EXT] Libtpa: a DPDK based userspace TCP stack implementation

2023-12-11 Thread Yuanhan Liu
On Mon, Dec 11, 2023 at 11:32:16AM +, Jerin Jacob Kollanukkaran wrote: > > > > -Original Message- > > From: Yuanhan Liu > > Sent: Monday, December 11, 2023 3:27 PM > > To: lib...@googlegroups.com > > Cc: dev@dpdk.org; Yuanhan Liu > > Sub

Libtpa: a DPDK based userspace TCP stack implementation

2023-12-11 Thread Yuanhan Liu
dard congestion avoid algorithm (New Reno). Libtpa implements slightly more than that though, such as SACK, congestion window validation, spurious retransmission detection, keepalive, etc. That's all. Comments, questions, patches and testing are all welcome! Thanks, Yuanhan Liu --- [0]: libtpa

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-03 Thread Yuanhan Liu
On Mon, Jul 2, 2018, at 1:44 PM, Qi Zhang wrote: > Introduce API rte_eth_dev_lock and rte_eth_dev_unlock to let > application lock or unlock on specific ethdev, a locked device > can't be detached, this help applicaiton to prevent unexpected > device detaching, especially in multi-process envrio

[dpdk-dev] [dpdk-announce] DPDK 17.11.3 (LTS) released

2018-06-15 Thread Yuanhan Liu
net/mlx5: fix disabling Tx packet inlining net/mlx5: remove excessive data prefetch net/mlx5: fix calculation of Tx TSO inline room size net/mlx5: change device reference for secondary process Yuanhan Liu (1): version: 17.11.3 Yunjian Wang (2): net/i40e: fix intr

Re: [dpdk-dev] 17.11.3 (LTS) patches review and test

2018-06-08 Thread Yuanhan Liu
On Fri, Jun 8, 2018, at 11:00 PM, Bruce Richardson wrote: > On Sun, May 27, 2018 at 01:35:17PM +0800, Yuanhan Liu wrote: > > Hi all, > > > > Here is a list of patches targeted for LTS release 17.11.3. Please > > help review and test. The planned date for the fi

Re: [dpdk-dev] 17.11.3 (LTS) patches review and test

2018-06-08 Thread Yuanhan Liu
ssage- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yuanhan Liu > Sent: Sunday, May 27, 2018 8:35 AM > To: dpdk stable > Cc: dev@dpdk.org; Thomas Monjalon > Subject: [dpdk-dev] 17.11.3 (LTS) patches review and test > > Hi all, > > Here is a list of patche

Re: [dpdk-dev] [PATCH] app/testpmd: fix failsafe PMD failure on exit

2018-06-01 Thread Yuanhan Liu
On Sun, May 27, 2018 at 02:37:28PM +0200, Thomas Monjalon wrote: > 27/05/2018 06:06, Yuanhan Liu: > > On Tue, May 22, 2018 at 07:35:08PM +0100, Ferruh Yigit wrote: > > > + /* > > > + * This is a workaround to f

[dpdk-dev] 17.11.3 (LTS) patches review and test

2018-05-26 Thread Yuanhan Liu
Hi all, Here is a list of patches targeted for LTS release 17.11.3. Please help review and test. The planned date for the final release is 8th, Jun. Before that, please let me know if anyone has objections with these patches being applied. These patches are located at branch 17.11 of dpdk-stable

Re: [dpdk-dev] [PATCH] app/testpmd: fix failsafe PMD failure on exit

2018-05-26 Thread Yuanhan Liu
On Tue, May 22, 2018 at 07:35:08PM +0100, Ferruh Yigit wrote: > vdevs detach on testpmd exit implemented as workaround to fix > a virtio-user issue. The issue was virtio-user cleanup is not > called and existing socket file not cleaned up which will fail > next run. > > The vdev cleanup causing pr

Re: [dpdk-dev] release date for 17.11.3?

2018-05-20 Thread Yuanhan Liu
On Thu, May 17, 2018 at 10:11:40PM +0200, Thomas Monjalon wrote: > 17/05/2018 18:16, Montorsi, Francesco: > > Hi all, > > I'd like to build DPDK on Centos 7.5... I found a commit > > (http://dpdk.org/browse/dpdk-stable/commit/?h=17.11&id=3ee847054cc9ab62fa2c9c6dc6ba68899d620e3a) > > that allows t

Re: [dpdk-dev] [RFC v2] vhost: new rte_vhost API proposal

2018-05-20 Thread Yuanhan Liu
On Fri, May 18, 2018 at 03:50:45PM +0200, Maxime Coquelin wrote: > Hi Dariusz, > > On 05/18/2018 03:01 PM, Dariusz Stojaczyk wrote: > > rte_vhost is not vhost-user spec compliant. Some Vhost drivers have > > been already confirmed not to work with rte_vhost. virtio-user-scsi-pci > > in QEMU 2.12 d

Re: [dpdk-dev] [PATCH] maintainers: resign from vhost and vdev

2018-05-05 Thread Yuanhan Liu
On Thu, May 03, 2018 at 05:44:29PM +0200, Thomas Monjalon wrote: > 03/05/2018 12:49, Burakov, Anatoly: > > On 03-May-18 11:02 AM, Yang, Zhiyong wrote: > > > Thanks a lot for your excellent contributions to DPDK community, > > > Jianfeng. > > > See you later. > > > > +1, you will be missed! > >

[dpdk-dev] [dpdk-announce] DPDK 17.11.1 (LTS) released

2018-02-27 Thread Yuanhan Liu
s in SW Rx queue net/mlx5: fix deadlock of link status alarm net/mlx5: fix missing attribute size for drop action net/mlx5: fix calculation of flow ID flag net/mlx5: fix memory region lookup net/mlx5: fix handling link status event Yuanhan Liu (5): Revert "net

Re: [dpdk-dev] 17.11.1 patches review and test

2018-02-26 Thread Yuanhan Liu
hankar > > On Monday 19 February 2018 06:13 PM, Yuanhan Liu wrote: > >Hi all, > > > >Here is a list of patches targeted for LTS release 17.11.1. Please > >help review and test. The planned date for the final release is 27th, > >Feb. Before that, please shout

[dpdk-dev] 17.11.1 patches review and test

2018-02-19 Thread Yuanhan Liu
: fix deadlock of link status alarm net/mlx5: fix missing attribute size for drop action net/mlx5: fix calculation of flow ID flag net/mlx5: fix memory region lookup net/mlx5: fix handling link status event Yuanhan Liu (4): Revert "net/mlx5: fix IPv6 header f

Re: [dpdk-dev] [PATCH] doc: coding style: use linux kernel style for indentation

2018-02-13 Thread Yuanhan Liu
On Tue, Feb 13, 2018 at 12:51:57PM +, Ferruh Yigit wrote: > On 1/13/2016 4:49 PM, stephen at networkplumber.org (Stephen Hemminger) wrote: > > On Wed, 13 Jan 2016 15:07:08 + > > Bruce Richardson wrote: > > > >> So, while the two-tab indent may look "a bit weird" it does solve the two > >

Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer

2018-02-12 Thread Yuanhan Liu
On Mon, Feb 12, 2018 at 10:54:08AM +0100, Maxime Coquelin wrote: > Hi Yuanhan, > > On 02/12/2018 10:44 AM, Yuanhan Liu wrote: > >On Mon, Feb 12, 2018 at 04:51:58PM +0800, Yuanhan Liu wrote: > >>I was doing terrible reviews jobs recently, and to not hold back > >>t

Re: [dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer

2018-02-12 Thread Yuanhan Liu
On Mon, Feb 12, 2018 at 04:51:58PM +0800, Yuanhan Liu wrote: > I was doing terrible reviews jobs recently, and to not hold back > the vhost/virtio development, it's better for me to resign. > > Then here it is. One thing I forgot to mention is, not surprisingly, I will als

[dpdk-dev] [PATCH] MAINTAINERS: resign from vhost/virtio maintainer

2018-02-12 Thread Yuanhan Liu
I was doing terrible reviews jobs recently, and to not hold back the vhost/virtio development, it's better for me to resign. Then here it is. Signed-off-by: Yuanhan Liu --- MAINTAINERS | 3 --- 1 file changed, 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4f1f33b..f12d83d 1

[dpdk-dev] [PATCH] net/mlx4: use PCI address as port name

2018-02-11 Thread Yuanhan Liu
. Judging the fact that there are 2 ports associated with one PCI for ConnectX-3, a postfix is needed. Thus, the final name looks like something below: :04:00.0-port0 :04:00.0-port1 Cc: sta...@dpdk.org Signed-off-by: Yuanhan Liu --- drivers/net/mlx4/mlx4.c | 17 + 1 file

Re: [dpdk-dev] [PATCH] maintainers: update vhost lib and pmd

2018-02-10 Thread Yuanhan Liu
On Sun, Feb 11, 2018 at 01:04:51AM +, Jianfeng Tan wrote: > Signed-off-by: Jianfeng Tan Acked-by: Yuanhan Liu And welcome! BTW, the verb "update" doesn't look good to me ;) --yliu > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) >

[dpdk-dev] [PATCH] net/mlx5: fix link speed

2018-02-05 Thread Yuanhan Liu
pport for newer link speeds") Cc: sta...@dpdk.org Signed-off-by: Yuanhan Liu --- drivers/net/mlx5/mlx5_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 6665076..492ca07 100644 --- a/drivers/net/mlx

Re: [dpdk-dev] [PATCH v3 0/2] vhost: IOTLB fixes

2018-02-01 Thread Yuanhan Liu
vhost: remove pending IOTLB entry if IOTLB MISS request sending failed Series Acked-by: Yuanhan Liu Thanks. --yliu > > lib/librte_vhost/iotlb.c | 20 ++-- > lib/librte_vhost/iotlb.h | 3 +++ > lib/librte_vhost/vhost.c | 13 ++--- > 3 files changed, 27 insertions(+), 9 deletions(-) > > -- > 2.14.3

Re: [dpdk-dev] [PATCH] examples/vhost_scsi: drop unimplemented EVENT_IDX feature bit

2018-02-01 Thread Yuanhan Liu
le by the > built-in virtio_net.c driver in librte_vhost. > > This patch drops VIRTIO_RING_F_EVENT_IDX from vhost_scsi so that vring > call works again. > > Cc: Changpeng Liu > Cc: Junjie Chen > Signed-off-by: Stefan Hajnoczi Acked-by: Yuanhan Liu Thanks. --yliu &

Re: [dpdk-dev] [PATCH 0/2] vhost: fix VIRTIO_NET_F_MQ vhost_scsi breakage

2018-02-01 Thread Yuanhan Liu
ssion by handling VIRTIO_NET_F_MQ only when the > built-in > virtio_net.c driver is in use. > > Stefan Hajnoczi (2): > vhost: add flag for built-in virtio_net.c driver > vhost: only drop vqs with built-in virtio_net.c driver Series Acked-by: Yuanhan Liu Thanks.

Re: [dpdk-dev] [PATCH 1/2] vhost: add flag for built-in virtio_net.c driver

2018-02-01 Thread Yuanhan Liu
Hi Stefan, On Wed, Jan 31, 2018 at 05:46:50PM +, Stefan Hajnoczi wrote: > The librte_vhost API is used in two ways: > 1. As a vhost net device backend via rte_vhost_enqueue/dequeue_burst(). This is how DPDK vhost-user firstly implemented. > 2. As a library for implementing vhost device backe

Re: [dpdk-dev] [PATCH v3 0/4] net/virtio: fix memory leak when reinitializing device

2018-01-26 Thread Yuanhan Liu
On Tue, Jan 23, 2018 at 04:54:39PM +0100, Olivier Matz wrote: > When devops->configure() is called, the queues may be reallocated > if the features flag changed, but the previous are not freed. This > patchset fixes this issue. Seires applied to dpdk-next-virtio. Thanks. --yliu > > To r

Re: [dpdk-dev] [PATCH] net/virtio: fix Rx and Tx handler selection for arm32

2018-01-26 Thread Yuanhan Liu
On Thu, Dec 14, 2017 at 03:45:04PM +0100, Maxime Coquelin wrote: > Hi Olivier, > > On 12/14/2017 03:32 PM, Olivier Matz wrote: > >From: Samuel Gauthier > > > >On arm32, we were always selecting the simple handler, but it is only > >available if neon is present. > > > >This is due to a typo in the

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix segfault as features change

2018-01-26 Thread Yuanhan Liu
On Tue, Jan 23, 2018 at 09:52:43AM +, Jianfeng Tan wrote: > Since commit 59fe5e17d930 ("vhost: propagate set features handling error"), > vhost does not allow to set different features without reset. > > The virito-user driver fails to reset the device in below commit. > > To fix, we send the

Re: [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT declaration

2018-01-26 Thread Yuanhan Liu
On Sat, Jan 20, 2018 at 01:54:52AM +0800, Tan, Jianfeng wrote: > > > On 1/19/2018 10:42 PM, Yuanhan Liu wrote: > >On Fri, Jan 19, 2018 at 02:02:50PM -0500, Zhihong Wang wrote: > >>The VIRTIO_F_ANY_LAYOUT feature indicates the device accepts arbitrary > >>descr

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-25 Thread Yuanhan Liu
On Wed, Jan 24, 2018 at 05:57:34PM +0100, Thomas Monjalon wrote: > 24/01/2018 16:04, Yuanhan Liu: > > On Wed, Jan 24, 2018 at 11:37:31AM +0100, Thomas Monjalon wrote: > > > 24/01/2018 11:36, Yuanhan Liu: > > > > On Wed, Jan 24, 2018 at 11:21:44AM +0100, Thomas Monjal

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Yuanhan Liu
On Tue, Jan 23, 2018 at 05:08:16PM +0100, Gaëtan Rivet wrote: > Drivers answers to a specific API (ethdev, cryptodev, ...), to create > standardized objects in response to parameters that are given to them > for init. I think matching properties should be restricted to higher > classes (bus, eth/cr

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Yuanhan Liu
On Wed, Jan 24, 2018 at 11:37:31AM +0100, Thomas Monjalon wrote: > 24/01/2018 11:36, Yuanhan Liu: > > On Wed, Jan 24, 2018 at 11:21:44AM +0100, Thomas Monjalon wrote: > > > 24/01/2018 10:28, Yuanhan Liu: > > > > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjal

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Yuanhan Liu
On Wed, Jan 24, 2018 at 11:21:44AM +0100, Thomas Monjalon wrote: > 24/01/2018 10:28, Yuanhan Liu: > > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote: > > > 24/01/2018 07:43, Yuanhan Liu: > > > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjal

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Yuanhan Liu
On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote: > 24/01/2018 07:43, Yuanhan Liu: > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > > > 23/01/2018 13:46, Yuanhan Liu: > > > > On Thu, Jan 18, 2018 at 10:46:23AM +0100, Gaëtan Rivet w

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-23 Thread Yuanhan Liu
On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > 23/01/2018 13:46, Yuanhan Liu: > > On Thu, Jan 18, 2018 at 10:46:23AM +0100, Gaëtan Rivet wrote: > > > On Thu, Jan 18, 2018 at 09:46:29AM +0100, Thomas Monjalon wrote: > > > > 18/01/2018 08:35, Yuanhan

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-23 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 10:46:23AM +0100, Gaëtan Rivet wrote: > On Thu, Jan 18, 2018 at 09:46:29AM +0100, Thomas Monjalon wrote: > > 18/01/2018 08:35, Yuanhan Liu: > > > On Wed, Jan 17, 2018 at 12:34:08PM +, Ferruh Yigit wrote: > > > > So does it make sense to se

[dpdk-dev] [PATCH] net/mlx5: use PCI BDF as the port name

2018-01-22 Thread Yuanhan Liu
, a postfix " port %u" is added, just in case their might be more than 1 port assoicated with a PCI device. Signed-off-by: Yuanhan Liu --- drivers/net/mlx5/mlx5.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/driver

Re: [dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT declaration

2018-01-19 Thread Yuanhan Liu
On Fri, Jan 19, 2018 at 02:02:50PM -0500, Zhihong Wang wrote: > The VIRTIO_F_ANY_LAYOUT feature indicates the device accepts arbitrary > descriptor layouts. The vhost-user lib already supports it, but the > feature declaration is missing. This patch fixes the mismatch. I remembered there was a lo

Re: [dpdk-dev] [PATCH] reset src fd field to -1 in fdset_move of vhost

2018-01-19 Thread Yuanhan Liu
On Thu, Dec 21, 2017 at 05:15:40PM +0800, Bing Zhao wrote: > In the fdset_move, after copying the fd&rwfds from the src to the dst, the fd > should be set to -1. Or else in some cases, there will be a fault missing. > E.g: > Before: 1 -1 3 4 -1 6 7 -1 9 10 > After: 1 10 3 4 9 6 7 -1 9 10 > Then t

Re: [dpdk-dev] [PATCH v5] vhost_user: protect active rings from async ring changes

2018-01-19 Thread Yuanhan Liu
On Wed, Jan 17, 2018 at 03:49:25PM +0200, Victor Kaplansky wrote: > When performing live migration or memory hot-plugging, > the changes to the device and vrings made by message handler > done independently from vring usage by PMD threads. > > This causes for example segfaults during live-migratio

Re: [dpdk-dev] [PATCH 00/12] lib/librte_vhost: introduce new vhost_user crypto

2018-01-18 Thread Yuanhan Liu
On Mon, Nov 27, 2017 at 08:01:03PM +, Fan Zhang wrote: > This patchset adds crypto backend suppport to vhost_user library, > including a proof-of-concept sample application. The implementation > follows the virtio-crypto specification and have been tested > with qemu 2.9.50 (with several patche

Re: [dpdk-dev] [PATCH 03/12] lib/librte_vhost: add virtio crypto user message structure

2018-01-18 Thread Yuanhan Liu
On Mon, Nov 27, 2017 at 08:01:06PM +, Fan Zhang wrote: > This patch adds virtio-crypto spec user message structure to > vhost_user. > > Signed-off-by: Fan Zhang > --- > lib/librte_vhost/vhost_user.h | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/lib/libr

Re: [dpdk-dev] [PATCH 02/12] lib/librte_vhost: add vhost_user private info structure

2018-01-18 Thread Yuanhan Liu
On Mon, Nov 27, 2017 at 08:01:05PM +, Fan Zhang wrote: > This patch adds a vhost_user_dev_priv structure and a vhost_user > message handler function prototype to vhost_user. This allows > different types of devices to add private information and their > device-specific vhost-user message functi

Re: [dpdk-dev] [PATCH 1/3] net/virtio: fix typo in function name

2018-01-18 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 02:45:48PM +0100, Olivier Matz wrote: > On Thu, Jan 18, 2018 at 09:27:10PM +0800, Yuanhan Liu wrote: > > On Thu, Jan 18, 2018 at 10:07:31AM +0100, Olivier Matz wrote: > > > Fixes: c1f86306a026 ("virtio: add new driver") > > > Cc: sta...@

Re: [dpdk-dev] [PATCH 2/3] net/virtio: rationalize queue flushing

2018-01-18 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 02:55:44PM +0100, Olivier Matz wrote: > On Thu, Jan 18, 2018 at 09:26:09PM +0800, Yuanhan Liu wrote: > > Hi Oliver, > > > > On Thu, Jan 18, 2018 at 10:07:32AM +0100, Olivier Matz wrote: > > > Rationalize the function virtio_dev_free_mbufs()

Re: [dpdk-dev] [PATCH v3] lib/librte_vhost: move fdset_del out of conn_mutex

2018-01-18 Thread Yuanhan Liu
Hi, Apologize for late review. On Tue, Jan 02, 2018 at 02:08:36AM -0800, zhike wang wrote: > From: wang zhike > > v3: > * Fix duplicate variable name, which leads to unexpected memory write. > v2: > * Move fdset_del before conn destroy. > * Fix coding style. Note that we prefer to put the chan

Re: [dpdk-dev] [PATCH 1/3] net/virtio: fix typo in function name

2018-01-18 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 10:07:31AM +0100, Olivier Matz wrote: > Fixes: c1f86306a026 ("virtio: add new driver") > Cc: sta...@dpdk.org I would not suggest to include such patch for a stable release. It doesn't fix a real issue. Thanks. --yliu > > Signed-off-by: Olivier Matz > --- > driv

Re: [dpdk-dev] [PATCH 2/3] net/virtio: rationalize queue flushing

2018-01-18 Thread Yuanhan Liu
Hi Oliver, On Thu, Jan 18, 2018 at 10:07:32AM +0100, Olivier Matz wrote: > Rationalize the function virtio_dev_free_mbufs(): > > - skip NULL vqs instead of crashing: this is required for the > next commit > - use the same kind of loop than in virtio_free_queues() > - also flush mbufs from the c

Re: [dpdk-dev] [PATCH v2] vhost: dequeue zero copy should restore mbuf before return to pool

2018-01-18 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 09:44:41AM +0100, Maxime Coquelin wrote: > > > On 01/17/2018 04:45 PM, Junjie Chen wrote: > >dequeue zero copy change buf_addr and buf_iova of mbuf, and return > >to mbuf pool without restore them, it breaks vm memory if others allocate > >mbuf from same pool since mbuf re

Re: [dpdk-dev] [PATCH] lib/librte_vhost: mov enum definition from PMD to lib

2018-01-18 Thread Yuanhan Liu
On Fri, Jan 12, 2018 at 04:12:12PM +0800, Zhiyong Yang wrote: > The enum definition is placed in librte_vhost in order to avoid many > duplication definitions in PMD and example code everywhere. I moved them out from rte_vhost.h on purpose, for they are virtio-net specific while this library is no

Re: [dpdk-dev] [PATCH 1/2] net: fixup RARP generation

2018-01-18 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 09:38:39AM +0100, Thomas Monjalon wrote: > 18/01/2018 04:14, Yuanhan Liu: > > Due to a mistake operation from me, older version (v10) was merged to > > master branch. It's the v11 should be applied. However, the master branch > > is not rebase-able

Re: [dpdk-dev] [PATCH 2/2] net: fix build error

2018-01-18 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 09:36:46AM +0100, Thomas Monjalon wrote: > 18/01/2018 09:03, Yuanhan Liu: > > On Thu, Jan 18, 2018 at 07:45:23AM +, Wang, Xiao W wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 18/01/2018 04:14, Yuanhan Liu: > &g

Re: [dpdk-dev] [PATCH 2/2] net: fix build error

2018-01-18 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 07:45:23AM +, Wang, Xiao W wrote: > > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Thursday, January 18, 2018 3:39 PM > > To: Yuanhan Liu > > Cc: dev@dpdk.org; Wang, Xiao

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-17 Thread Yuanhan Liu
On Wed, Jan 17, 2018 at 12:34:08PM +, Ferruh Yigit wrote: > On 1/16/2018 2:50 PM, Yuanhan Liu wrote: > > This patch documents the new devargs syntax, which is going to be > > implemented in DPDK v18.05. > > > > The new devargs proposal is introduced for having a c

[dpdk-dev] [PATCH 1/2] net: fixup RARP generation

2018-01-17 Thread Yuanhan Liu
Due to a mistake operation from me, older version (v10) was merged to master branch. It's the v11 should be applied. However, the master branch is not rebase-able. Thus, this patch is made, from the diff between v10 and v11. Code is from Xiao Wang. Signed-off-by: Yuanhan Liu --- lib/librt

[dpdk-dev] [PATCH 2/2] net: fix build error

2018-01-17 Thread Yuanhan Liu
2d5): undefined reference to `rte_mempool_ops_table' rte_arp.c:(.text+0x384): undefined reference to `rte_mempool_ops_table' rte_arp.c:(.text+0x4b7): undefined reference to `rte_mempool_ops_table' Fixes: 45ae05df824c ("net: add a helper for making RARP packet") Signed-

Re: [dpdk-dev] [PATCH v11 0/5] net/virtio: support GUEST ANNOUNCE

2018-01-17 Thread Yuanhan Liu
Xiao told me that this series (except the last patch) was already applied to the Thomas master branch. I then realised it was my mistake. I applied v10 last week locally for some basic testing. There is a conflict in last patch, that's why the last patch is not merged. I forgot to do a reset befor

Re: [dpdk-dev] [PATCH] vhost: do deep copy while reallocate vq

2018-01-17 Thread Yuanhan Liu
On Mon, Jan 15, 2018 at 06:32:19AM -0500, Junjie Chen wrote: > When vhost reallocate dev and vq for NUMA enabled case, it doesn't perform > deep copy, which lead to 1) zmbuf list not valid 2) remote memory access. > This patch is to re-initlize the zmbuf list and also do the deep copy. > > Signed-

[dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-16 Thread Yuanhan Liu
the details. Also, here is link for the background: http://dpdk.org/ml/archives/dev/2017-November/082600.html This syntax is suggestd by Thomas: http://dpdk.org/ml/archives/dev/2017-December/084234.html Signed-off-by: Yuanhan Liu --- doc/guides/prog_guide/env_abstraction_layer.rst | 34

Re: [dpdk-dev] [PATCH] vhost: support Explicit Congestion Notification

2018-01-11 Thread Yuanhan Liu
On Wed, Nov 22, 2017 at 11:19:42AM +0800, Jiayu Hu wrote: > In virtio, Explicit Congestion Notification (ECN) includes two parts: > guest ECN and host ECN. Guest ECN means the frontend can handle TSO > packets which have ECN set, and host ECN means the backend can handle > TSO packets which have EC

Re: [dpdk-dev] [PATCH v4 0/5] lib: add Port Representors

2018-01-10 Thread Yuanhan Liu
On Mon, Jan 08, 2018 at 02:37:15PM +, Remy Horton wrote: > Port Representors provide a logical presentation in DPDK of VF (virtual > function) ports for the purposes of control and monitoring. Each port > representor device represents a single VF and is associated with it's > parent physical

Re: [dpdk-dev] [PATCH v10 3/5] net: add a helper for making RARP packet

2018-01-10 Thread Yuanhan Liu
Thomas, look good to you? --yliu On Wed, Jan 10, 2018 at 09:23:54AM +0800, Xiao Wang wrote: > Suggested-by: Maxime Coquelin > Signed-off-by: Xiao Wang > Reviewed-by: Maxime Coquelin > --- > lib/librte_net/Makefile| 1 + > lib/librte_net/rte_arp.c | 42 > +++

Re: [dpdk-dev] [PATCH v2] examples/vhost: fix remove dev_info.max_rx_queues checking to solve startup failure

2018-01-10 Thread Yuanhan Liu
On Wed, Jan 10, 2018 at 02:01:01PM +0800, Zhiyong Yang wrote: > For vhost sample, the operation if (dev_info.max_rx_queues > > MAX_QUEUES) in the function port_init causes startup failure > when using X710(i40e driver). X710 requires that MAX_QUEUES > should be defined no less than 320, however it

Re: [dpdk-dev] [PATCH 5/5] vhost: add reconnect thread name for client mode.

2018-01-09 Thread Yuanhan Liu
On Tue, Jan 09, 2018 at 09:12:43PM +0800, Yuanhan Liu wrote: > On Fri, Jan 05, 2018 at 06:10:39AM -0800, Tonghao Zhang wrote: > > This patch adds the name for vhost-user reconnect thread. > > It can help us to know whether the thread is running. > > > > S

Re: [dpdk-dev] [PATCH v7 3/3] net/virtio: support GUEST ANNOUNCE

2018-01-09 Thread Yuanhan Liu
On Tue, Jan 09, 2018 at 12:41:53PM +0100, Thomas Monjalon wrote: > > > Do you think it could make sense to have this function in a lib, as > > > vhost user lib does exactly the same? > > > > > > I don't know if it could be useful to others than vhost/virtio though. > > > > Hi Thomas, > > > > Do

Re: [dpdk-dev] [PATCH] vhost: fix error code check when creating pthread

2018-01-09 Thread Yuanhan Liu
On Fri, Dec 08, 2017 at 11:19:49AM +0100, Olivier Matz wrote: > On error, pthread_create() returns a positive number (errno). > Fix the test on the return value. > > Fixes: af1475918124 ("vhost: introduce API to start a specific driver") > Fixes: e623e0c6d8a5 ("vhost: add reconnect ability") > Cc:

Re: [dpdk-dev] [PATCH] examples/vhost: fix extend MAX_QUEUES to resolve startup failure

2018-01-09 Thread Yuanhan Liu
On Thu, Jan 04, 2018 at 02:33:32PM +0800, Zhiyong Yang wrote: > When binding X710 NIC (i40e driver) to DPDK, vhost sample startups > failure. > The sample requires that MAX_QUEUES should be defined no less than 320. > So, the patch redefines MAX_QUEUES 320 to fix the issue. It just makes the issue

Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel

2018-01-09 Thread Yuanhan Liu
On Fri, Jan 05, 2018 at 02:28:06AM -0800, Zhike Wang wrote: > From: zhike wang > > The max_mtu is kept as zero in case no CRTL channel, which leads > to failure when calling virtio_mtu_set(). > > Signed-off-by: Zhike Wang Applied to dpdk-next-virtio. Thanks. --yliu > --- > drivers/n

Re: [dpdk-dev] [PATCH 5/5] vhost: add reconnect thread name for client mode.

2018-01-09 Thread Yuanhan Liu
On Fri, Jan 05, 2018 at 06:10:39AM -0800, Tonghao Zhang wrote: > This patch adds the name for vhost-user reconnect thread. > It can help us to know whether the thread is running. > > Signed-off-by: Tonghao Zhang > --- > lib/librte_vhost/socket.c | 8 > 1 file changed, 8 insertions(+) >

Re: [dpdk-dev] [PATCH v7] vhost: support virtqueue interrupt/notification suppression

2018-01-09 Thread Yuanhan Liu
On Tue, Jan 09, 2018 at 07:34:17AM +, Yao, Lei A wrote: > > > > -Original Message- > > From: Chen, Junjie J > > Sent: Tuesday, January 9, 2018 7:04 PM > > To: y...@fridaylinux.org; maxime.coque...@redhat.com; Wang, Xiao W > > ; Bie, Tiwei ; Yao, Lei A > > > > Cc: dev@dpdk.org; Chen,

Re: [dpdk-dev] [PATCH v6] vhost: support virtqueue interrupt/notification suppression

2018-01-08 Thread Yuanhan Liu
On Tue, Jan 09, 2018 at 02:12:02AM +, Chen, Junjie J wrote: > > > + if (vring_need_event(vhost_used_event(vq), new, old) > > > > It's a bit weird that you use one from the standard linux header file > > (vring_need_event), while you define you own one (vhost_used_event). > > Note that

Re: [dpdk-dev] [PATCH v5 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2018-01-08 Thread Yuanhan Liu
On Wed, Dec 13, 2017 at 09:51:05AM +0100, Maxime Coquelin wrote: > Hi, > > This fifth revision fixes bug reported by Tiwei, dev->virtqueue[$idx] > wasn't reset to NULL at vq freeing time. Applied to dpdk-next-virtio. Thanks. --yliu > > Having QEMU started with mq=on but guest driver no

Re: [dpdk-dev] [PATCH] vhost: support UDP Fragmentation Offload

2018-01-08 Thread Yuanhan Liu
On Tue, Nov 21, 2017 at 02:56:52PM +0800, Jiayu Hu wrote: > In virtio, UDP Fragmentation Offload (UFO) includes two parts: host UFO > and guest UFO. Guest UFO means the frontend can receive large UDP packets, > and host UFO means the backend can receive large UDP packets. This patch > supports host

Re: [dpdk-dev] [PATCH v2] examples/vhost: fix sending arp packet to self

2018-01-08 Thread Yuanhan Liu
On Fri, Dec 29, 2017 at 09:33:19AM -0500, Junjie Chen wrote: > ARP packets are not dropped when dest vdev is itself, which breaks > RX ring inconspicuously. > > Fixes: 9c5ef51207c6 ("examples/vhost: handle broadcast packet") > > Signed-off-by: Junjie Chen > --- Applied to dpdk-next-virtio. Tha

Re: [dpdk-dev] [PATCH v6] vhost: support virtqueue interrupt/notification suppression

2018-01-08 Thread Yuanhan Liu
On Tue, Dec 26, 2017 at 12:43:10PM -0500, Junjie Chen wrote: > The driver can suppress interrupt when VIRTIO_F_EVENT_IDX feature bit is > negotiated. The driver set vring flags to 0, and MAY use used_event in > available ring to advise device interrupt util reach an index specified > by used_event.

Re: [dpdk-dev] [PATCH v2 0/2] vhost: introduce rte_vhost_vring_call()

2018-01-08 Thread Yuanhan Liu
On Wed, Jan 03, 2018 at 09:17:32AM +0100, Maxime Coquelin wrote: > >>Reviewed-by: Maxime Coquelin > > > > From 3.2. Managing ABI updates, General Guidelines: > > > > New APIs will be marked as experimental for at least one release to > > allow any issues found by users of the new API to be fix

Re: [dpdk-dev] [PATCH v6 1/3] net/virtio: make control queue thread-safe

2018-01-08 Thread Yuanhan Liu
On Sun, Jan 07, 2018 at 04:05:11AM -0800, Xiao Wang wrote: > diff --git a/drivers/net/virtio/virtio_rxtx.h > b/drivers/net/virtio/virtio_rxtx.h > index 54f1e849b..71b5798b0 100644 > --- a/drivers/net/virtio/virtio_rxtx.h > +++ b/drivers/net/virtio/virtio_rxtx.h > @@ -84,6 +84,7 @@ struct virtnet_c

Re: [dpdk-dev] [PATCH v6 2/3] net/virtio: add packet injection method

2018-01-08 Thread Yuanhan Liu
On Sun, Jan 07, 2018 at 04:05:12AM -0800, Xiao Wang wrote: > + /* > + * App management thread and virtio interrupt handler thread > + * both can change the 'started' flag, this lock is meant to > + * avoid such a contention. > + */ > + rte_spinlock_t state_lock; Why not

Re: [dpdk-dev] [PATCH v2 0/4] various fixes and cleanups for virtio PMD

2017-12-27 Thread Yuanhan Liu
On Mon, Dec 11, 2017 at 01:13:28PM +0800, Tiwei Bie wrote: > v2: > - refine indent for patch 2 > - fix a typo in commit log for patch 4 > - drop the blank lines squeezing patch Series applied to dpdk-next-virtio. Thanks. --yliu > > Tiwei Bie (4): > net/virtio: fix vector Rx break caus

Re: [dpdk-dev] [PATCH] vhost: support Generic Segmentation Offload

2017-12-27 Thread Yuanhan Liu
On Mon, Dec 25, 2017 at 01:53:29AM +, Yao, Lei A wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jiayu Hu > > Sent: Tuesday, November 28, 2017 1:29 PM > > To: dev@dpdk.org > > Cc: y...@fridaylinux.org; Tan, Jianfeng ; Hu, Jiayu > > > > Subje

Re: [dpdk-dev] [PATCH] net/virtio: fix incorrect cast of void *

2017-12-27 Thread Yuanhan Liu
On Thu, Dec 14, 2017 at 03:49:32PM +0100, Maxime Coquelin wrote: > > > On 12/14/2017 03:33 PM, Olivier Matz wrote: > >From: Didier Pallard > > > >The rx_queues and tx_queues fields of the data structure points to a struct > >virtnet_rx or virtnet_tx. Casting it to a virtqueue is an error. > > >

Re: [dpdk-dev] [PATCH] vhost: support UDP Fragmentation Offload

2017-12-27 Thread Yuanhan Liu
On Tue, Nov 21, 2017 at 02:56:52PM +0800, Jiayu Hu wrote: > In virtio, UDP Fragmentation Offload (UFO) includes two parts: host UFO > and guest UFO. Guest UFO means the frontend can receive large UDP packets, > and host UFO means the backend can receive large UDP packets. This patch > supports host

Re: [dpdk-dev] [PATCH] lib/librte_vhost: remove redundant logic judgement

2017-12-27 Thread Yuanhan Liu
On Mon, Dec 25, 2017 at 05:16:17PM +0800, Zhiyong Yang wrote: > At the beginning of vring_translate, the code > if(!(dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))) already judges > if IOMMU_PLATFORM is supported. The function vhost_iova_to_vva always > repeats the logic, __vhost_iova_to_vva ca

Re: [dpdk-dev] [PATCH] net/virtio: remove unnecessary macro definitions

2017-12-27 Thread Yuanhan Liu
On Tue, Dec 26, 2017 at 05:25:00PM +0800, Zhiyong Yang wrote: > DPDK has already the definition of Ethernet numeric link speeds in Mbps in > the file Rte_ethdev.h, it is unnecessary to rededine virtio specific link > speeds macros again. > > Signed-off-by: Zhiyong Yang Applied to dpdk-next-virti

Re: [dpdk-dev] [PATCH] vhost: fix dequeue zero copy not work with virtio1

2017-12-15 Thread Yuanhan Liu
On Fri, Dec 15, 2017 at 10:33:41AM +, Loftus, Ciara wrote: > > > > Hi Junjie, > > > > On 12/13/2017 05:50 PM, Junjie Chen wrote: > > > This fix dequeue zero copy can not work with Qemu > > > version >= 2.7. Since from Qemu 2.7 virtio device > > > use virtio-1 protocol, the zero copy code path

[dpdk-dev] [dpdk-announce] DPDK 17.08.1 released

2017-12-07 Thread Yuanhan Liu
/mlx5: fix tunneled TCP/UDP packet type Yuanhan Liu (2): Revert "net/virtio: flush Rx queues on start" version: 17.08.1 Zhiyong Yang (2): test: fix assignment operation net/virtio: fix Tx packet length stats

Re: [dpdk-dev] 17.08.1 patches review and test

2017-12-07 Thread Yuanhan Liu
On Mon, Dec 04, 2017 at 08:40:03PM +, Patil, Harish wrote: > > > -Original Message- > From: dev on behalf of Yuanhan Liu > > Date: Monday, November 27, 2017 at 4:21 AM > To: dpdk stable > Cc: "dev@dpdk.org" , "Xu, Qian Q" > Subj

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-12-06 Thread Yuanhan Liu
On Tue, Dec 05, 2017 at 06:22:05PM +0100, Adrien Mazarguil wrote: > > > > > Just for information, this "port=x" argument in mlx4 is consistent > > > > > with the > > > > > value found in /sys/class/net/ethX/dev_port under Linux. If we choose > > > > > to use > > > > > a port index (instead of a M

Re: [dpdk-dev] [PATCH v2 2/2] net/virtio: support GUEST ANNOUNCE

2017-12-06 Thread Yuanhan Liu
On Wed, Dec 06, 2017 at 07:23:11PM +0800, Tiwei Bie wrote: > On Mon, Dec 04, 2017 at 06:02:08AM -0800, Xiao Wang wrote: > [...] > > diff --git a/drivers/net/virtio/virtio_rxtx.c > > b/drivers/net/virtio/virtio_rxtx.c > > index 6a24fde..7313bdd 100644 > > --- a/drivers/net/virtio/virtio_rxtx.c > >

Re: [dpdk-dev] [PATCH] vhost_user: protect active rings from async ring changes

2017-12-06 Thread Yuanhan Liu
On Wed, Dec 06, 2017 at 03:55:49PM +0200, Victor Kaplansky wrote: > When performing live migration or memory hot-plugging, > the changes to the device and vrings made by message handler > done independently from vring usage by PMD threads. > > This causes for example segfauls during live-migration

Re: [dpdk-dev] The limitation of VHOST_MEMORY_MAX_NREGIONS in virtio-user with vhost-user backend

2017-12-06 Thread Yuanhan Liu
On Wed, Dec 06, 2017 at 12:23:19PM +0100, Maxime Coquelin wrote: > Hi, > > On 12/05/2017 07:58 AM, Wang, Wei 5. (NSB - CN/Hangzhou) wrote: > > > > > >Hi, all > > > >In DPDK document, it it described that Virtio in containers Cannot work when > >there are more than VHOST_MEMORY_MAX_NREGIONS(8) hug

Re: [dpdk-dev] Your next patch "net/virtio: fix an incorrect behavior..."

2017-12-05 Thread Yuanhan Liu
> one more thing. I saw they are going to backport some patches into 17.08.1 > > > > http://dev.dpdk.narkive.com/pX0IIwPl/dpdk-dev-17-08-1-patches-review-and-test > > > > is your next fix related to the one reported as "net/virtio: flush Rx > > queues on start"? > > > > If that's the case, should we flag this to Yuanhan Liu, just to be aware > > there's some work in progress? > > > > > > Antonio > >

Re: [dpdk-dev] The limitation of VHOST_MEMORY_MAX_NREGIONS in virtio-user with vhost-user backend

2017-12-05 Thread Yuanhan Liu
On Tue, Dec 05, 2017 at 06:58:53AM +, Wang, Wei 5. (NSB - CN/Hangzhou) wrote: > > > Hi, all > > In DPDK document, it it described that Virtio in containers Cannot work when > there are more than VHOST_MEMORY_MAX_NREGIONS(8) hugepages. In another word, > do not use 2MB hugepage so far. Do

Re: [dpdk-dev] [PATCH 2/2] net/virtio: support GUEST ANNOUNCE

2017-12-05 Thread Yuanhan Liu
On Thu, Nov 30, 2017 at 02:41:12AM +, Wang, Xiao W wrote: > > > > -Original Message- > > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > > Sent: Monday, November 27, 2017 8:49 PM > > To: Wang, Xiao W > > Cc: dev@dpdk.org > > Subject:

Re: [dpdk-dev] [PATCH] vhost: fix segfault as handle set_mem_table message

2017-12-05 Thread Yuanhan Liu
>regions. > > > >Fixes: 8f972312b8f4 ("vhost: support vhost-user") > > > >CC: sta...@dpdk.org > > > >CC: Yuanhan Liu > >CC: Maxime Coquelin > > > >Reported-by: Yang Zhang > >Reported-by: Xin Long > >Signed-off-by: Y

Re: [dpdk-dev] [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting VM2VM scenario

2017-12-05 Thread Yuanhan Liu
On Tue, Dec 05, 2017 at 06:59:26AM +, Yang, Zhiyong wrote: > Hi all, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhiyong Yang > > Sent: Thursday, November 30, 2017 5:47 PM > > To: dev@dpdk.org; y...@fridaylinux.org; maxime.coque...@redhat.com > > C

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-12-05 Thread Yuanhan Liu
On Tue, Dec 05, 2017 at 02:20:05PM +0100, Thomas Monjalon wrote: > 05/12/2017 12:04, Adrien Mazarguil: > > > Hi Yuanhan, > > > > > > On Mon, Dec 04, 2017 at 09:55:31PM +0800, Yuanhan Liu wrote: > > > rte_devargs is identified by the name (pci id for pc

Re: [dpdk-dev] [PATCH] maintainers: claim responsibility for virtio PMD

2017-12-05 Thread Yuanhan Liu
On Fri, Dec 01, 2017 at 08:06:04PM +0800, Yuanhan Liu wrote: > On Fri, Dec 01, 2017 at 07:04:35PM +0800, Tiwei Bie wrote: > > Add myself as co-maintainer for virtio driver. > > > > Signed-off-by: Tiwei Bie > > --- > > Hi Yuanhan and Maxime, > > > >

  1   2   3   4   5   6   7   8   9   10   >