From: Lipei Liang
When mapping two adjacent memory areas A and B, the current implementation
merges them into one segment, known as area C. However, if areas A and B
are mapped again, there will be separate entries for A, C, and B in the
memory maps, as C divides A and B. This means that if A and
From: Lipei Liang
If we map two continuous memory area A and B, current implementation
will merge these two segments into one, as area C. But, if area A and
B are mapped again, after sort, there while be A, C, B in mem maps,
as A and B divided by C, these segs couldn't be merged. In other words,
In xdp_umem_configure() allocated some resources for the
xsk umem, we should delete them when xsk configure fails,
otherwise it will lead to resources leak.
Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
v3: remove unnece
In xdp_umem_configure() allocated some resources for the
xsk umem, we should delete them when xsk configure fails,
otherwise it will lead to resources leak.
Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
v2: update cod
In xdp_umem_configure() allocated some resources for the
xsk umem, we should delete them when xsk configure fails,
otherwise it will lead to resources leak.
Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/
pp/test-pmd/testpmd.c:3808
#5 0x6c1a94 in main ../app/test-pmd/testpmd.c:4759
#6 0x9328f038 (/usr/lib64/libc.so.6+0x2b038)
#7 0x9328f110 in __libc_start_main (/usr/lib64/libc.so.6+
0x2b110)
Fixes: 6e78005 ("net/mlx5: add reference counter on DPDK Tx queues")
Cc: sta..
In ixgbe_ipsec_ctx_create() allocated memory for the 'security_ctx',
we should free it when errors occur, otherwise it will lead
to memory leak.
Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
v2: just resend t
af_xdp: introduce AF_XDP PMD")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
v2: update code suggested by Ferruh Yigit
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
b/drivers/net/af_xdp/rte_eth_a
In ixgbe_ipsec_ctx_create() allocated memory for the 'security_ctx',
we should free it when errors occur, otherwise it will lead
to memory leak.
Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/net/ixgbe
In iavf_security_ctx_create() allocated memory for the
'security_ctx', we should free it when memory malloc for
the 'iavf_security_ctx' fails, otherwise it will lead to
memory leak.
Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto")
Cc: sta...@dpdk.or
In xdp_umem_configure() allocated memzone for the 'umem', we should
free it when xsk_umem__create() call fails, otherwise it will lead
to memory zone leak.
Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
/txgbe: add SFP hotplug identification")
Fixes: e0d876ef6bbc ("net/txgbe: support device stop and close")
Cc: sta...@dpdk.org
Reported-by: Pengfei Sun
Signed-off-by: Yunjian Wang
---
drivers/net/txgbe/txgbe_ethdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
After the memzone is freed, it is not removed from the 'rte_ring_tailq'.
If rte_ring_lookup is called at this time, it will cause a use-after-free
problem. This change prevents that from happening.
Fixes: 4e32101f9b01 ("ring: support freeing")
Cc: sta...@dpdk.org
Signed-
ggested-by: Honnappa Nagarahalli
Signed-off-by: Yunjian Wang
---
v2: update code suggested by Honnappa Nagarahalli
---
lib/ring/rte_ring.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c
index 8ed455043d..2755323b8a 100644
--- a/lib/r
When using the ring to find out tailq entry, however it had been
freed by rte_memzone_free function. This change prevents that
from happening.
Fixes: 4e32101f9b01 ("ring: support freeing")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
lib/ring/rte_ring.c | 11 +--
1 fi
In the device probing, there is no need to log the error message in the
case, that device has been already probed and return with -EEXIST.
Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
Cc: sta...@dpdk.org
Signed-off-by: Lipei Liang
Signed-off-by: Yunjian Wang
---
lib/
size, the BIG memzone
queue index will be lost. This will lead to a memory leak. So we
should release the memzone when releasing queues.
Fixes: 460d1679586e ("drivers/net: delete HW rings while freeing queues")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/net/ixgbe/ixgbe
the BIG memzone
queue index will be lost. This will lead to a memory leak. So we
should release the memzone when releasing queues.
Fixes: 460d1679586e ("drivers/net: delete HW rings while freeing queues")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/net/i40e/i40e_fdir.c
ne
queue index will be lost. This will lead to a memory leak. So we
should release the memzone when releasing queues.
Fixes: 460d1679586e ("drivers/net: delete HW rings while freeing queues")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/net/ice/ice_fdir_filter.c | 2 --
ne
queue index will be lost. This will lead to a memory leak. So we
should release the memzone when releasing queues.
Fixes: 460d1679586e ("drivers/net: delete HW rings while freeing queues")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/net/e1000/em_rxtx.c | 8 +
This series for fixing memzone leak when re-configure the RX/TX queues for
igb, ixgbe, i40e, ice & em drivers.
---
v3:
* 1. Update commit log
* 2. And ice fdir rxq/txq memzones are freed
v2:
* Update commit log
Yunjian Wang (4):
net/e1000: fix memzone leak when re-configure th
the memzone
when releasing queues.
Signed-off-by: Yunjian Wang
---
drivers/net/ixgbe/ixgbe_rxtx.c | 6 --
drivers/net/ixgbe/ixgbe_rxtx.h | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index bfdfd5e755..1b6e
the memzone
when releasing queues.
Signed-off-by: Yunjian Wang
---
drivers/net/i40e/i40e_fdir.c | 3 ---
drivers/net/i40e/i40e_rxtx.c | 8 ++--
drivers/net/i40e/i40e_rxtx.h | 2 ++
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i
leasing queues.
Signed-off-by: Yunjian Wang
---
drivers/net/ice/ice_rxtx.c | 6 --
drivers/net/ice/ice_rxtx.h | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 5d7ab4f047..472da6bf83 100644
--- a/drivers/net/i
leasing queues.
Signed-off-by: Yunjian Wang
---
drivers/net/e1000/em_rxtx.c | 8 ++--
drivers/net/e1000/igb_rxtx.c | 9 +++--
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c
index dfd8f2fd00..82928083f5 100644
--- a/
This series for deleting HW rings when releasing queues for
igb, ixgbe, i40e, ice & em drivers.
---
v2:
* Update commit log
Yunjian Wang (4):
net/e1000: delete HW rings when releasing queues
net/ice: delete HW rings when releasing queues
net/i40e: delete HW rings when releasing qu
memzone, we can release the memzone
when releasing queues.
Signed-off-by: Yunjian Wang
---
drivers/net/ixgbe/ixgbe_rxtx.c | 6 --
drivers/net/ixgbe/ixgbe_rxtx.h | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
memzone, we can release the memzone
when releasing queues.
Signed-off-by: Yunjian Wang
---
drivers/net/i40e/i40e_fdir.c | 3 ---
drivers/net/i40e/i40e_rxtx.c | 8 ++--
drivers/net/i40e/i40e_rxtx.h | 2 ++
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/net/i40e/i40e_fdir.c
memzone, we can release the memzone
when releasing queues.
Signed-off-by: Yunjian Wang
---
drivers/net/ice/ice_rxtx.c | 6 --
drivers/net/ice/ice_rxtx.h | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 5d7ab4f047
memzone, we can release the memzone
when releasing queues.
Signed-off-by: Yunjian Wang
---
drivers/net/e1000/em_rxtx.c | 8 ++--
drivers/net/e1000/igb_rxtx.c | 9 +++--
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c
This series for deleting HW rings when releasing queues for
igb, ixgbe, i40e, ice & em drivers.
Yunjian Wang (4):
net/e1000: delete HW rings when releasing queues
net/ice: delete HW rings when releasing queues
net/i40e: delete HW rings when releasing queues
net/ixgbe: delete HW rings
.com; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/netvsc: fix txq leak in error path
>
> >Subject: [dpdk-dev] [PATCH] net/netvsc: fix txq leak in error path
> >
> >From: Yunjian Wang
> >
> >In hn_dev_tx_queue_setup() allocated memory for txq, we should free i
Currently, only the 'vfio_dev_fd' is closed in failure path, so
some resources are not released(such as 'vfio_group_fd'). The
rte_vfio_release_device() should be used to avoid this problem.
Fixes: 33604c31354a ("vfio: refactor PCI BAR mapping")
Cc: sta...@dpdk.or
c, sizeof(rte_uuid_t));
^~
Fixes: 6bc67c497a51 ("eal: add uuid API")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
lib/librte_eal/include/rte_uuid.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/include/rte_uuid.h
b/lib/librte_eal/include/rte_uuid.h
index 044afbd
The 'vfio_res' is not freed when unmapping resource by primary process.
This leads to memory leak.
Fixes: ab53203e194b ("vfio: enable unmapping resource for secondary")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/bus/pci/linux/pci_vfio.c | 1 +
1 file
a...@dpdk.org
Signed-off-by: Yunjian Wang
---
v2:
* Modify according to Ferruh's suggestions
---
drivers/net/tap/rte_eth_tap.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index a13d8d50d..05470a211 100644
a...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/net/tap/rte_eth_tap.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index a13d8d50d..079310fea 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/
a...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/net/tap/rte_eth_tap.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index a13d8d50d..079310fea 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/
Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.
Signed-off-by: Yunjian Wang
---
drivers/net/nfp/nfp_net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 3aafa7f80..64d9d218d 100644
---
Use PCI_PRI_FMT instead of "%04d:%02d:%02d:%d" print format.
Signed-off-by: Yunjian Wang
---
drivers/net/e1000/em_ethdev.c | 2 +-
drivers/net/e1000/igb_ethdev.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/e
The function vhost_kernel_tap_set_offload() could return errors,
the return value need to be checked. And there is no need to fail
when error is -ENOTSUP.
Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before set")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wa
The function vhost_kernel_tap_set_offload() could return errors,
the return value need to be checked. And there is no need to fail
when error is -ENOTSUP.
Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before set")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
The function eth_dev_vhost_create() could return errors,
the return value need to be checked.
Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
v3:
* Add newline at the end of the error message
v2:
* Chang
The function eth_dev_vhost_create() could return errors,
the return value need to be checked.
Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
v2:
-change function eth_dev_vhost_create return 0 on success
---
drivers
The function eth_dev_vhost_create() could return errors,
the return value need to be checked.
Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/net/vhost/rte_eth_vhost.c | 6 --
1 file changed, 4 insert
The function vhost_kernel_tap_set_offload() could return errors,
the return value need to be checked.
Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before set")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/net/virtio/virtio_user/vhost_kernel_tap.c
From: Henry Cai
Support 16 sockets server, such as HPE AH337A,
Huawei kunlun server etc.
Signed-off-by: Henry Cai
---
config/common_base | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/config/common_base b/config/common_base
index 5bdba1d..38561b6 100644
--- a/config/co
Signed-off-by: Yunjian Wang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index fb618ef..e3fcf33 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe
48 matches
Mail list logo