[PATCH v1 0/4] [RFC] Testpmd RPC API

2022-04-07 Thread ohilyard
From: Owen Hilyard Currently, DTS uses Testpmd for most of its testing. This has been successful in reducing the need to create more test apps, but it has a few drawbacks. First, if some part of DPDK is not exposed via Testpmd or one of the example applications, for the purposes of DTS it

[PATCH v1 4/4] app/test-pmd-api: Implementation files for the API

2022-04-07 Thread ohilyard
From: Owen Hilyard As of right now, this is a fairly direct port. As such, most of the main file from test-acl is present in api_impl.cc. If this proof of concept is going to expand into a usable application, the acl test helper can be moved to another file to help keep the service definition fil

[PATCH v1 1/4] app/test-pmd-api: Add C++ Compiler

2022-04-07 Thread ohilyard
From: Owen Hilyard Adds a C++ compiler to the project, which is currently enabled by default for ease of testing. Meson currently lacks a way to try to get a compiler, and failing to find a compiler for a language always causes a hard error, so this is the only workable approach. Signed-off-by:

[PATCH v1 2/4] app/test-pmd-api: Add POC with gRPC deps

2022-04-07 Thread ohilyard
From: Owen Hilyard The new app is disabled if the dependencies are not present, in order to avoid breaking the build on any system that does not have gRPC installed. The meson file for the app is heavily derived from the testpmd. Signed-off-by: Owen Hilyard --- app/meson.build | 1

[PATCH v1 3/4] app/test-pmd-api: Add protobuf file

2022-04-07 Thread ohilyard
From: Owen Hilyard This file contains the gRPC definitions for the api as it currently stands. Signed-off-by: Owen Hilyard --- app/test-pmd-api/api.proto | 12 1 file changed, 12 insertions(+) create mode 100644 app/test-pmd-api/api.proto diff --git a/app/test-pmd-api/api.proto

[PATCH v1] Remove Owen Hilyard as a DTS Maintainer

2023-02-07 Thread ohilyard
From: Owen Hilyard I (Owen Hilyard) am stepping down as a DTS maintainer. Signed-off-by: Owen Hilyard --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3495946d0f..e78bed6da1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1765,7 +1765,6 @@ F: do

[dpdk-dev] [PATCH] lib/rte_rib6: fix stack buffer overflow

2021-06-16 Thread ohilyard
From: Owen Hilyard ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. The fix for the stack buffer overflow was to make sure depth was always < 128, since when depth = 128 it caused the index into the ip address to be 16, which read off the end of the array. While trying to solve

[dpdk-dev] [PATCH] tests/test_eal_flags: fix memory leak

2021-06-16 Thread ohilyard
From: Owen Hilyard The directory steam was not closed when the hugepage action was HUGEPAGE_CHECK_EXISTS. This caused a memory leak in some parts of the unit tests. Signed-off-by: Owen Hilyard --- app/test/test_eal_flags.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test/test_eal_f

[dpdk-dev] [PATCH] tests/cmdline: fix memory leaks

2021-06-16 Thread ohilyard
From: Owen Hilyard Fixes for a few memory leaks in the cmdline_autotest unit test. All of the leaks were related to not freeing the commandline struct after testing had completed. Signed-off-by: Owen Hilyard --- app/test/test_cmdline_lib.c | 32 1 file changed

[dpdk-dev] [PATCH] tests/cmdline: fix memory leaks

2021-06-16 Thread ohilyard
From: Owen Hilyard Fixes for a few memory leaks in the cmdline_autotest unit test. All of the leaks were related to not freeing the commandline struct after testing had completed. Fixes: dbb860e03e ("cmdline: tests") Signed-off-by: Owen Hilyard Reviewed-by: David Marchand --- app/test/test_

[dpdk-dev] [PATCH v2] lib/rte_rib6: fix stack buffer overflow

2021-06-16 Thread ohilyard
From: Owen Hilyard ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. The fix for the stack buffer overflow was to make sure depth was always < 128, since when depth = 128 it caused the index into the ip address to be 16, which read off the end of the array. While trying to solve

[dpdk-dev] [PATCH] lib/flow_classify: fix leaking rules on delete

2021-06-16 Thread ohilyard
From: Owen Hilyard Rules in a classify table were not freed if the table had a delete function. Fixes: be41ac2a3 ("flow_classify: introduce flow classify library") Signed-off-by: Owen Hilyard --- lib/flow_classify/rte_flow_classify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v3] lib/rte_rib6: fix stack buffer overflow

2021-06-21 Thread ohilyard
From: Owen Hilyard ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. The fix for the stack buffer overflow was to make sure depth was always < 128, since when depth = 128 it caused the index into the ip address to be 16, which read off the end of the array. While trying to solve

[dpdk-dev] [PATCH v4] rib: fix max depth IPv6 lookup

2021-06-23 Thread ohilyard
From: Owen Hilyard ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. The fix for the stack buffer overflow was to make sure depth was always < 128, since when depth = 128 it caused the index into the ip address to be 16, which read off the end of the array. While trying to solve

[dpdk-dev] [PATCH v2] flow_classify: fix leaking rules on delete

2021-06-23 Thread ohilyard
From: Owen Hilyard Rules in a classify table were not freed if the table had a delete function. Fixes: be41ac2a3 ("flow_classify: introduce flow classify library") Signed-off-by: Owen Hilyard --- lib/flow_classify/rte_flow_classify.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH v3] tests/cmdline: fix memory leaks

2021-06-23 Thread ohilyard
From: Owen Hilyard Fixes for a few memory leaks in the cmdline_autotest unit test. All of the leaks were related to not freeing the commandline struct after testing had completed. Fixes: dbb860e03e ("cmdline: tests") Signed-off-by: Owen Hilyard Reviewed-by: David Marchand --- app/test/test_