On Thu, Jul 28, 2016 at 03:44:57AM +0530, Alex Williamson wrote:
> Hi,
>
> I took a quick look at the dpdk vfio code and spotted an invalid
> assumption that should probably be corrected ASAP. That is:
>
> lib/librte_eal/linuxapp/eal/eal_vfio.h:
> #define VFIO_GET_REGION_ADDR(x) ((uint64_t) x
test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So
removing ptr var. Now freeing mp_stack var.
Signed-off-by: Santosh Shukla
---
app/test/test_mempool.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/app/test/test_mempool.c b/app/test
On Fri, May 13, 2016 at 02:50:48PM +0200, Thomas Monjalon wrote:
> 2016-05-11 19:17, Hemant Agrawal:
> > IGB_UIO not supported for arm64 arch in kernel so disable.
>
> If I understand well, a patch is needed in the kernel to make
> igb_uio works? Please confirm.
>
Yes. User need this [1]
On Thu, May 12, 2016 at 05:52:54PM +0800, Jianbo Liu wrote:
> On 12 May 2016 at 16:57, Santosh Shukla
> wrote:
> > On Thu, May 12, 2016 at 01:54:13PM +0800, Jianbo Liu wrote:
> >> On 12 May 2016 at 13:06, Santosh Shukla
> >> wrote:
> >> > On Thu, Ma
On Thu, May 12, 2016 at 01:54:13PM +0800, Jianbo Liu wrote:
> On 12 May 2016 at 13:06, Santosh Shukla
> wrote:
> > On Thu, May 12, 2016 at 11:42:26AM +0800, Jianbo Liu wrote:
> >> On 12 May 2016 at 11:17, Santosh Shukla
> >> wrote:
> >> > On Thu, Ma
On Thu, May 12, 2016 at 11:42:26AM +0800, Jianbo Liu wrote:
> On 12 May 2016 at 11:17, Santosh Shukla
> wrote:
> > On Thu, May 12, 2016 at 10:01:05AM +0800, Jianbo Liu wrote:
> >> On 12 May 2016 at 02:25, Stephen Hemminger
> >> wrote:
> >> > On Wed, 11
;> > On Wed, 11 May 2016 19:17:58 +0530
> >> > Hemant Agrawal wrote:
> >> >
> >> > > IGB_UIO not supported for arm64 arch in kernel so disable.
> >> > >
> >> > > Signed-off-by: Hemant Agrawal
> >> > > R
On Wed, May 11, 2016 at 08:22:59AM -0700, Stephen Hemminger wrote:
> On Wed, 11 May 2016 19:17:58 +0530
> Hemant Agrawal wrote:
>
> > IGB_UIO not supported for arm64 arch in kernel so disable.
> >
> > Signed-off-by: Hemant Agrawal
> > Reviewed-by: Santos
On Fri, Apr 29, 2016 at 7:14 PM, Jan Viktorin
wrote:
>
> Hello,
>
> here follows several patchs extracting the general VFIO code out of the
> PCI + VFIO code base. Usually, it's just move and rename of functions.
> The most complicated ones are:
>
> * eal/linux: extract setup logic out of
erhaps IGB_UIO not supported for arm64
arch so disable.
if you agress to do then patch looks okay to me,
Reviewed-by: Santosh Shukla
> Signed-off-by: Hemant Agrawal
> ---
> config/defconfig_arm64-armv8a-linuxapp-gcc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/confi
On Mon, May 9, 2016 at 2:36 PM, Jerin Jacob
wrote:
> On Mon, May 09, 2016 at 07:18:22PM +0530, Hemant Agrawal wrote:
> > This patch introduces dpaa2 machine target to address difference
> > in cpu parameter, number of core to 8 and no numa support
> > w.r.t default armv8-a machine
> >
> >
On Mon, May 9, 2016 at 7:18 PM, Hemant Agrawal
wrote:
> This patch introduces dpaa2 machine target to address difference
> in cpu parameter, number of core to 8 and no numa support
> w.r.t default armv8-a machine
>
> Signed-off-by: Hemant Agrawal
> ---
>
emcmp(perm_addr, mac_addr, sizeof(struct ether_addr)) == 0)
- continue;
On Mon, Apr 25, 2016 at 7:05 PM, santosh wrote:
> Hi Ivan
>
> ixgbevf_set_default_mac_addr() could not find in our code base.
> put traces at other places as suggested by you.
> Log at "eth
the system.
1.
Logs at the time of boot up:
-
INIT: Initializing NIC port 0 RX queue 0 ...
INIT: Initializing NIC port 0 TX queue 0 ...
Santosh ixgbevf_add_mac_addr portid=0 mac=00:50:56:A0:10:C2
.....
....
Santosh ixgbevf_add_mac_addr portid=0 mac=00:50:5
Hi Ivan and team,
Please respond to my last mail and let me know if there is any
alternate way to handle this.
Our release is in pending due to this issue.
Thanks & Regards
Santosh
On Wed, Apr 20, 2016 at 2:35 PM, santosh wrote:
> Hi Ivan,
>
> Thanks for your response.
>
>
ce)
Log o/p in failure case
Santosh ixgbevf_add_mac_addr returning
code changes:
-
ixgbevf_add_mac_addr() {
...
if (memcmp(hw->mac.perm_addr, mac_addr, sizeof(struct ether_addr)) == 0) {
PMD_DRV_LOG(DEBUG, "Existing MAC \n")
On Thu, Mar 3, 2016 at 6:56 PM, Thomas Monjalon
wrote:
> 2016-03-02 14:11, Santosh Shukla:
>> On Wed, Mar 2, 2016 at 2:02 PM, Yuanhan Liu
>> wrote:
>> > On Tue, Mar 01, 2016 at 03:32:17PM +0530, Santosh Shukla wrote:
>> >> - 1st patch: let non-x86 a
On Wed, Mar 2, 2016 at 2:02 PM, Yuanhan Liu
wrote:
> On Tue, Mar 01, 2016 at 03:32:17PM +0530, Santosh Shukla wrote:
>> - 1st patch: let non-x86 arch use virtio pmd driver in non-vec
>> - 2nd patch: enable virtio arm support
>> - 3rd patch: update virtio for arm feature e
On Tue, Mar 1, 2016 at 12:02 PM, Yuanhan Liu
wrote:
> On Tue, Mar 01, 2016 at 11:38:55AM +0530, Santosh Shukla wrote:
>> On Tue, Mar 1, 2016 at 11:29 AM, Yuanhan Liu
>> wrote:
>> > On Mon, Feb 29, 2016 at 06:28:10PM +0530, Santosh Shukla wrote:
>> >> Check cpu
Signed-off-by: Santosh Shukla
---
doc/guides/rel_notes/release_16_04.rst |5 +
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/release_16_04.rst
b/doc/guides/rel_notes/release_16_04.rst
index 8273817..fc0b3bd 100644
--- a/doc/guides/rel_notes/release_16_04.rst
+++ b
removed _VIRTIO_PMD=n from arch config and let arch to use _VIRTIO_PMD from
config/common_linuxapp.
Signed-off-by: Santosh Shukla
---
config/defconfig_arm-armv7a-linuxapp-gcc |1 -
config/defconfig_arm64-armv8a-linuxapp-gcc |1 -
2 files changed, 2 deletions(-)
diff --git a/config
-vectored rx/tx apis.
Signed-off-by: Santosh Shukla
---
v1: rework of this[1] patch
[1] http://dpdk.org/dev/patchwork/patch/10911/
- Removed ifdef from virtio_rxtx_simple.c
drivers/net/virtio/Makefile |3 +++
drivers/net/virtio/virtio_rxtx.c | 16 +++-
drivers/net/virtio
- 1st patch: let non-x86 arch use virtio pmd driver in non-vec
- 2nd patch: enable virtio arm support
- 3rd patch: update virtio for arm feature entry in release guide.
Thanks.
Santosh Shukla (3):
virtio: use vector rx/tx for ssse cpuflag only
config: enable virtio for armv7/v8
guide
On Tue, Mar 1, 2016 at 2:41 PM, Qiu, Michael wrote:
> On 2/26/2016 4:53 PM, Santosh Shukla wrote:
>> Check cpuflag macro before using vectored api.
>> -virtio_recv_pkts_vec() uses _sse3__ simd instruction for now so added
>> cpuflag.
>> - Also wrap other ve
On Tue, Mar 1, 2016 at 11:25 AM, Yuanhan Liu
wrote:
> On Mon, Feb 29, 2016 at 06:01:38PM +0530, Santosh Shukla wrote:
>> On Mon, Feb 29, 2016 at 9:57 AM, Yuanhan Liu
>> wrote:
>> > On Fri, Feb 26, 2016 at 02:21:02PM +0530, Santosh Shukla wrote:
>> >> Check cpu
On Tue, Mar 1, 2016 at 11:29 AM, Yuanhan Liu
wrote:
> On Mon, Feb 29, 2016 at 06:28:10PM +0530, Santosh Shukla wrote:
>> Check cpuflag macro before using vectored api.
>> -virtio_recv_pkts_vec() uses _sse3__ simd instruction for now so added
>> cpuflag.
>> - Also wra
esource_init(dev, hw) < 0)
> + if (legacy_virtio_resource_init(dev, hw) < 0) {
> + if (dev->kdrv == RTE_KDRV_UNKNOWN) {
> + PMD_INIT_LOG(INFO,
> + "skip kernel managed virtio device.");
> + return 1;
> + }
> return -1;
> + }
>
> hw->vtpci_ops = _ops;
> hw->use_msix = legacy_virtio_has_msix(>addr);
Tested-by: Santosh Shukla
Acked-by: Santosh Shukla
> --
> 1.8.1.4
>
virtio_recv_pkts_vec() implementation to
drivers/virtio/virtio_vec_.h file.
2) Remove use_simple_rxtx flag, so that virtio/virtio_vec_.h
files to provide vectored/non-vectored rx/tx apis.
Signed-off-by: Santosh Shukla
---
- v2: Removed VIRTIO_PMD=n from arm v7/v8
- v1: This is a rework
On Mon, Feb 29, 2016 at 9:57 AM, Yuanhan Liu
wrote:
> On Fri, Feb 26, 2016 at 02:21:02PM +0530, Santosh Shukla wrote:
>> Check cpuflag macro before using vectored api.
>> -virtio_recv_pkts_vec() uses _sse3__ simd instruction for now so added
>> cpuflag.
>> - Also wra
On Fri, Feb 26, 2016 at 2:14 PM, Xie, Huawei wrote:
> On 2/26/2016 4:29 PM, David Marchand wrote:
>> On Fri, Feb 26, 2016 at 3:23 AM, Yuanhan Liu
>> wrote:
>>> Mauricio, thanks for the testing and report.
>>>
>>> On Thu, Feb 25, 2016 at 02:30:18PM +0100, David Marchand wrote:
>From the
to
drivers/virtio/virtio_vec_.h file.
2) Remove use_simple_rxtx flag, so that virtio/virtio_vec_.h
files to provide vectored/non-vectored rx/tx apis.
Signed-off-by: Santosh Shukla
---
- v1: This is a rework of patch [1].
Note: This patch will let non-x86 arch to use virtio pmd.
[1] http://dpdk.org/dev
On Thu, Feb 25, 2016 at 5:00 PM, Mauricio V?squez
wrote:
> Hello,
>
> I am trying to connect two virtual machines through Open vSwitch using
> vhost-user ports, on the host side everything looks fine.
> When using the standard virtio drivers both virtual machines are able to
> exchange traffic,
Hi Thomas,
On Mon, Feb 22, 2016 at 11:11 AM, Yuanhan Liu
wrote:
> On Sun, Feb 21, 2016 at 07:47:58PM +0530, Santosh Shukla wrote:
>> v9 patchset to support vfio infrasture for ioport, required for archs example
>> arm64/arm and x86.
>>
>>
>> For virtio inc_vec
Include vfio map/rd/wr support for pci ioport.
Signed-off-by: Santosh Shukla
Acked-by: Anatoly Burakov
Acked-by: David Marchand
---
v7:
- This is enhancement patch for vfio map/rd/wr, rebased on top of David(s) -
"Rework ioport for virtio" patchset. For more information about api, r
vfio_pci_mmap() try to map all pci bars. ioport region are not mapped in
vfio/kernel so ignore mmaping for ioport.
Signed-off-by: Santosh Shukla
Acked-by: Anatoly Burakov
---
v9: included anatoly acked-by
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 20
1 file changed
iopl() syscall not supported in linux-arm/arm64 so always return 0 value.
Signed-off-by: Santosh Shukla
Suggested-by: Stephen Hemminger
Acked-by: Jan Viktorin
Acked-by: David Marchand
---
lib/librte_eal/linuxapp/eal/eal.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/lib
] http://dpdk.org/dev/patchwork/patch/10429/
Santosh Shukla (3):
eal/linux: never check iopl for arm
eal/linux: vfio: ignore mapping for ioport region
eal/linux: vfio: add pci ioport support
lib/librte_eal/linuxapp/eal/eal.c |2 +
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 56
On Tue, Feb 16, 2016 at 8:35 AM, Yuanhan Liu
wrote:
> On Mon, Feb 15, 2016 at 04:48:36PM +0530, Santosh Shukla wrote:
>> Hi Yuanhan,
>>
>> On Mon, Feb 15, 2016 at 4:27 PM, Yuanhan Liu
>> wrote:
>> > On Mon, Feb 15, 2016 at 03:22:11PM +0530, Santosh Shukla wr
On Sun, Feb 7, 2016 at 7:21 PM, Santosh Shukla wrote:
> iopl() syscall not supported in linux-arm/arm64 so always return 0 value.
>
> Signed-off-by: Santosh Shukla
> Suggested-by: Stephen Hemminger
> Acked-by: Jan Viktorin
> Acked-by: David Marchand
> ---
> lib/librt
On Tue, Feb 9, 2016 at 2:34 PM, David Marchand
wrote:
> On Mon, Feb 8, 2016 at 3:13 PM, Burakov, Anatoly
> wrote:
>>> Include vfio map/rd/wr support for pci ioport.
>>>
>>> Signed-off-by: Santosh Shukla
>>> ---
>>> v7->v8:
>>> - R
Include vfio map/rd/wr support for pci ioport.
Signed-off-by: Santosh Shukla
---
v7->v8:
- Remove rte_pci_ioport malloc and rte_free()/unmap() func from v7.
- removed umap from git header.
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 36 ++--
1 file changed,
vfio_pci_mmap() try to map all pci bars. ioport region are not mapped in
vfio/kernel so ignore mmaping for ioport.
Signed-off-by: Santosh Shukla
Acked-by: Anatoly Burakov
---
v7-->v8:
- included Anatoly acked-by:
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 20
1 f
On Mon, Feb 8, 2016 at 2:21 PM, David Marchand
wrote:
> On Sun, Feb 7, 2016 at 2:51 PM, Santosh Shukla wrote:
>> @@ -999,37 +1000,56 @@ int
>> pci_vfio_ioport_map(struct rte_pci_device *dev, int bar,
>> struct rte_pci_ioport *p)
>
> p is passed
On Sun, Feb 7, 2016 at 1:18 PM, David Marchand
wrote:
> Move all os / arch specifics to eal.
>
> Signed-off-by: David Marchand
Reviewed-by: Santosh Shukla
Tested-by: Santosh Shukla
later patches
> - rte_pci_ioport object now reaches driver implementation (uio / vfio)
> - sanity checks are in uio map function, no reason to have those checks in
> read/write functions
>
Looks okay to me.
Reviewed-by: Santosh Shukla
Tested for arm64/x86_64 for vfio mode...so..
On Mon, Feb 8, 2016 at 2:55 AM, Thomas Monjalon
wrote:
> 2016-02-07 19:21, Santosh Shukla:
>> - virtio_recv_pkts_vec and other virtio vector friend apis are written for
>> sse/avx instructions. For arm64 in particular, virtio vector implementation
>> does not exist(todo)
Include vfio map/unmap/rd/wr support for pci ioport.
Signed-off-by: Santosh Shukla
---
v7:
- This is enhancement patch for vfio map/rd/wr, rebased on top of David(s) -
"Rework ioport for virtio" patchset. For more information about api, refer
patch [1].
[1] http://dp
vfio_pci_mmap() try to map all pci bars. ioport region are not mapped in
vfio/kernel so ignore mmaping for ioport.
Signed-off-by: Santosh Shukla
---
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 20
1 file changed, 20 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal
for non-sse/avx targets and will work
in non-vectored virtio mode.
Disabling RTE_VIRTIO_INC_VECTOR config for :
- i686 arch as i686 target config says:
config/defconfig_i686-native-linuxapp-gcc says "Vectorized PMD is not
supported on 32-bit".
- armv7/v8 arch.
Signed-off-by: Sant
iopl() syscall not supported in linux-arm/arm64 so always return 0 value.
Signed-off-by: Santosh Shukla
Suggested-by: Stephen Hemminger
Acked-by: Jan Viktorin
Acked-by: David Marchand
---
lib/librte_eal/linuxapp/eal/eal.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/lib
v4.. v1) patch history, refer [2].
Thanks.
[1] https://github.com/sshukla82/dpdk.git branch virtio-vfio-v6-review
[2] http://comments.gmane.org/gmane.comp.networking.dpdk.devel/31402
Santosh Shukla (4):
eal/linux: never check iopl for arm
virtio: Introduce config RTE_VIRTIO_INC_VECTOR
e
On Tue, Feb 2, 2016 at 9:48 PM, Santosh Shukla wrote:
> On Tue, Feb 2, 2016 at 9:21 PM, Santosh Shukla wrote:
>> On Tue, Feb 2, 2016 at 2:19 PM, Yuanhan Liu
>> wrote:
>>> On Tue, Feb 02, 2016 at 06:50:18AM +0100, David Marchand wrote:
>>>> On Tue,
On Tue, Feb 2, 2016 at 9:21 PM, Santosh Shukla wrote:
> On Tue, Feb 2, 2016 at 2:19 PM, Yuanhan Liu
> wrote:
>> On Tue, Feb 02, 2016 at 06:50:18AM +0100, David Marchand wrote:
>>> On Tue, Feb 2, 2016 at 6:43 AM, Yuanhan Liu >> linux.intel.com> wrote:
>>&g
On Tue, Feb 2, 2016 at 2:19 PM, Yuanhan Liu
wrote:
> On Tue, Feb 02, 2016 at 06:50:18AM +0100, David Marchand wrote:
>> On Tue, Feb 2, 2016 at 6:43 AM, Yuanhan Liu
>> wrote:
>> > On Tue, Feb 02, 2016 at 09:44:14AM +0530, Santosh Shukla wrote:
>> >> Cu
On Tue, Feb 2, 2016 at 12:30 PM, Santosh Shukla wrote:
> On Tue, Feb 2, 2016 at 11:13 AM, Yuanhan Liu
> wrote:
>> On Tue, Feb 02, 2016 at 09:44:14AM +0530, Santosh Shukla wrote:
>>> >> +int rte_eal_pci_read_bar(const struct rte_pci_device *device,
>>> >>
On Tue, Feb 2, 2016 at 11:13 AM, Yuanhan Liu
wrote:
> On Tue, Feb 02, 2016 at 09:44:14AM +0530, Santosh Shukla wrote:
>> >> +int rte_eal_pci_read_bar(const struct rte_pci_device *device,
>> >> + void *buf, size_t len, off_t offset,
>> >
On Tue, Feb 2, 2016 at 10:49 AM, Yuanhan Liu
wrote:
> On Tue, Feb 02, 2016 at 10:00:36AM +0530, Santosh Shukla wrote:
>> >
>> > BTW, I didn't follow the noIOMMU discussion; how did it end? Do we still
>> > need that? Is this patch a full story to enable virtio
On Mon, Feb 1, 2016 at 7:18 PM, Yuanhan Liu
wrote:
> On Fri, Jan 29, 2016 at 11:51:50PM +0530, Santosh Shukla wrote:
>> Introducing below api for pci bar region rd/wr.
>> Api's are:
>> - rte_eal_pci_read_bar
>> - rte_eal_pci_write_bar
>>
>> Signed-of
[2] http://comments.gmane.org/gmane.comp.networking.dpdk.devel/31402
Santosh Shukla (8):
eal: pci: add api to rd/wr pci bar region
linuxapp/vfio: ignore mapping for ioport region
eal/linux: never check iopl for arm
virtio: Introduce config RTE_VIRTIO_INC_VECTOR
virtio: move io header and api from vir
If virtio interface attached to vfio driver then
do not parse for virtio resource. Instead exit with return 0;
Signed-off-by: Santosh Shukla
---
v5-->v6:
- Removed _noimmu and using deafult rte_kdrv_vfio for drv check.
drivers/net/virtio/virtio_pci.c |4 +++-
1 file changed, 3 inserti
So far virtio handle rw access for uio / ioport interface,
This patch to extend the support for vfio.
Signed-off-by: Santosh Shukla
---
drivers/net/virtio/virtio_io.h |2 +-
drivers/net/virtio/virtio_pci.c | 110 ++-
2 files changed, 98 insertions
For vfio case - Use pread/pwrite api to access virtio
ioport space.
Signed-off-by: Santosh Shukla
Signed-off-by: Rizwan Ansari
Signed-off-by: Rakesh Krishnamurthy
---
v5-->v6:
- renamed inport_in/out to vfio_in/out
- Renamed file from virtio_vfio_rw.h to virtio_vfio_io.h
drivers/net/vir
Moving io api and header file i.e. sys/io.h to separate file virtio_io.h
Signed-off-by: Santosh Shukla
---
v5-->v6:
- included new file virtio_io.h, has in/out api and sys/io.h.
drivers/net/virtio/virtio_io.h | 114 +++
drivers/net/virtio/virtio_pc
for non-sse/avx targets and will work
in non-vectored virtio mode.
Disabling RTE_VIRTIO_INC_VECTOR config for :
- i686 arch as i686 target config says:
config/defconfig_i686-native-linuxapp-gcc says "Vectorized PMD is not
supported on 32-bit".
- armv7/v8 arch.
Signed-off-by: Sant
iopl() syscall not supported in linux-arm/arm64 so always return 0 value.
Signed-off-by: Santosh Shukla
Suggested-by: Stephen Hemminger
Acked-by: Jan Viktorin
Acked-by: David Marchand
---
lib/librte_eal/linuxapp/eal/eal.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/lib
vfio_pci_mmap() try to map all pci bars. ioport region are not mapped in
vfio/kernel so ignore mmaping for ioport.
Signed-off-by: Santosh Shukla
---
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 20
1 file changed, 20 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal
Introducing below api for pci bar region rd/wr.
Api's are:
- rte_eal_pci_read_bar
- rte_eal_pci_write_bar
Signed-off-by: Santosh Shukla
---
v5-->v6:
- update api infor in rte_eal_version.map file
suggested by david manchand.
lib/librte_eal/bsdapp/eal/eal_pci.c |
On Fri, Jan 29, 2016 at 12:57 PM, Xie, Huawei wrote:
> On 1/14/2016 9:29 PM, Santosh Shukla wrote:
>> Hi,
>>
>> This v4 patch uses vfio-noiommu-way to access virtio-net pci interface.
>> Tested for arm64 thunderX platform. Patch builds for
>> x86/i386/arm/ar
On Fri, Jan 29, 2016 at 2:32 PM, Thomas Monjalon
wrote:
> 2016-01-29 15:34, Yuanhan Liu:
>> There is another option for that: the git scissors option; you could
>> check the git format-patch man page for more detailed info (by searching
>> "scissors" keyword). I'm just not quite sure Thomas like
On Fri, Jan 29, 2016 at 12:31 PM, Yuanhan Liu
wrote:
> On Tue, Jan 19, 2016 at 05:16:11PM +0530, Santosh Shukla wrote:
>> For non-x86 arch, Compiler will throw build error for in/out apis. Including
>> dummy api function so to pass build.
>>
>> Note that: For virt
On Fri, Jan 29, 2016 at 12:37 PM, Yuanhan Liu
wrote:
> On Tue, Jan 19, 2016 at 05:16:07PM +0530, Santosh Shukla wrote:
>> For vfio case - Use pread/pwrite api to access virtio
>> ioport space.
>>
>> Applicable for virtio 0.95 spec.
>>
>> Signed-off-by: S
On Fri, Jan 29, 2016 at 10:12 AM, Yuanhan Liu
wrote:
> On Fri, Jan 29, 2016 at 10:02:26AM +0530, Santosh Shukla wrote:
>> Hi Yuan,
>
> It's Yuanhan, but not Yuan :)
>
Sorry for that,
>> On Wed, Jan 27, 2016 at 8:03 AM, Yuanhan Liu
>> wrote:
>> > O
Hi Yuan,
On Wed, Jan 27, 2016 at 8:03 AM, Yuanhan Liu
wrote:
> On Wed, Jan 27, 2016 at 07:53:21AM +0530, Santosh Shukla wrote:
>> Ping?
>
> I was on vacation late last week. And I was quite busy till now after
> the vacation. So, sorry that I still don't have time to do more
If virtio interface attached to vfio-noiommu driver then
do not parse for virtio resource. Instead exit with return 0;
Note: Applicable for virtio spec 0.95.
Signed-off-by: Santosh Shukla
---
v5-->v6:
- Replaced pci_dev->kdrv check from __noiommu to default;
This is because patch [1]
On Wed, Jan 27, 2016 at 9:26 PM, Santosh Shukla wrote:
> On Wed, Jan 27, 2016 at 9:09 PM, Thomas Monjalon
> wrote:
>> 2016-01-27 21:02, Santosh Shukla:
>>> 1. virtio currently works for vfio+noiommu and likely will work for
>>> vfio+iommu in near future.
>
On Wed, Jan 27, 2016 at 9:09 PM, Thomas Monjalon
wrote:
> 2016-01-27 21:02, Santosh Shukla:
>> 1. virtio currently works for vfio+noiommu and likely will work for
>> vfio+iommu in near future.
>> 2. So remove __noiommu suffix and always use default.
>> 3. Introduce v
On Wed, Jan 27, 2016 at 4:11 PM, Santosh Shukla wrote:
> On Tue, Jan 26, 2016 at 9:51 PM, Santosh Shukla wrote:
>> On Tue, Jan 26, 2016 at 7:58 PM, Thomas Monjalon
>> wrote:
>>> 2016-01-26 19:35, Santosh Shukla:
>>>> On Tue, Jan 26, 2016 at 6:30 PM, Thomas
> > address of the noiommu switch itself.
>> >
>> > Reported-by: Alexey Kardashevskiy
>> > Fixes: 03a76b60f8ba ("vfio: Include No-IOMMU mode")
>> > Signed-off-by: Alex Williamson
>>
>>
>>
>> Reviewed-by: Alexey Kard
On Tue, Jan 26, 2016 at 9:51 PM, Santosh Shukla wrote:
> On Tue, Jan 26, 2016 at 7:58 PM, Thomas Monjalon
> wrote:
>> 2016-01-26 19:35, Santosh Shukla:
>>> On Tue, Jan 26, 2016 at 6:30 PM, Thomas Monjalon
>>> wrote:
>>> > 2016-01-26 15:56, Santosh S
Ping?
On Tue, Jan 19, 2016 at 5:16 PM, Santosh Shukla wrote:
> For non-x86 arch, Compiler will throw build error for in/out apis. Including
> dummy api function so to pass build.
>
> Note that: For virtio to work for non-x86 arch - RTE_EAL_VFIO is the only
> supported method.
Ping
On Jan 19, 2016 5:16 PM, "Santosh Shukla" wrote:
> make sure sys/io.h used only for x86 archs. This fixes build error
> arm64/arm case.
>
> Signed-off-by: Santosh Shukla
> ---
> drivers/net/virtio/virtio_pci.h |2 ++
> 1 file changed, 2 insertions(
Ping.
On Jan 19, 2016 5:16 PM, "Santosh Shukla" wrote:
> vfio_pci_mmap() try to map all pci bars. ioport region are not mapped in
> vfio/kernel so ignore mmaping for ioport.
>
> Signed-off-by: Santosh Shukla
> ---
> lib/librte_eal/linuxapp/eal/eal_pci_vfio.c |
Ping?
On Jan 19, 2016 5:16 PM, "Santosh Shukla" wrote:
> - virtio_recv_pkts_vec and other virtio vector friend apis are written for
> sse/avx instructions. For arm64 in particular, virtio vector
> implementation
> does not exist(todo).
>
> So virtio pmd driver
On Tue, Jan 26, 2016 at 7:58 PM, Thomas Monjalon
wrote:
> 2016-01-26 19:35, Santosh Shukla:
>> On Tue, Jan 26, 2016 at 6:30 PM, Thomas Monjalon
>> wrote:
>> > 2016-01-26 15:56, Santosh Shukla:
>> >> In my observation, currently virtio work for vfio-noiommu,
On Tue, Jan 26, 2016 at 6:30 PM, Thomas Monjalon
wrote:
> 2016-01-26 15:56, Santosh Shukla:
>> On Mon, Jan 25, 2016 at 8:59 PM, Thomas Monjalon
>> wrote:
>> > 2016-01-21 22:47, Santosh Shukla:
>> >> On Thu, Jan 21, 2016 at 8:16 PM, Thomas Monjalon
>> &g
On Mon, Jan 25, 2016 at 8:59 PM, Thomas Monjalon
wrote:
> 2016-01-21 22:47, Santosh Shukla:
>> On Thu, Jan 21, 2016 at 8:16 PM, Thomas Monjalon
>> wrote:
>> > 2016-01-21 17:34, Santosh Shukla:
>> >> On Thu, Jan 21, 2016 at 4:58 PM, Thomas Monjalon
>> &g
Ping?
On Tue, Jan 19, 2016 at 5:16 PM, Santosh Shukla wrote:
> Hi,
>
> Patch series uses vfio-noiommu-way to access virtio-net pci interface.
> Tested for arm64 thunderX/ x86_64 platform. Patch builds for
> x86/i386/arm/armv8/thunderX. Tested with testpmd application.
>
On Thu, Jan 21, 2016 at 8:16 PM, Thomas Monjalon
wrote:
> 2016-01-21 17:34, Santosh Shukla:
>> On Thu, Jan 21, 2016 at 4:58 PM, Thomas Monjalon
>> wrote:
>> > 2016-01-21 16:43, Santosh Shukla:
>> >> David Marchand wrote:
>> >> > This is
On Thu, Jan 21, 2016 at 4:58 PM, Thomas Monjalon
wrote:
> 2016-01-21 16:43, Santosh Shukla:
>> David Marchand wrote:
>> > This is a mode (specific to vfio), not a new kernel driver.
>> >
>> Yes, Specific to VFIO and this is why noiommu appended after vfio i
On Thu, Jan 21, 2016 at 4:02 PM, David Marchand
wrote:
> Santosh,
>
> On Tue, Jan 19, 2016 at 7:57 PM, Santosh Shukla
> wrote:
> > Adding RTE_KDRV_VFIO_NOIOMMU mode in kernel driver. Also including
> > rte_vfio_is_noiommu() helper function. This function will parse
Introducing below api for pci bar space rd/wr. Currently used for
pci iobar rd/wr.
Api's are:
- rte_eal_pci_read_bar
- rte_eal_pci_write_bar
virtio when used for vfio-mode then virtio driver will use these api
to do rd/wr operation on ioport pci bar.
Signed-off-by: Santosh Shukla
---
v5-->
iopl() syscall not supported in linux-arm/arm64 so always return 0 value.
Signed-off-by: Santosh Shukla
Acked-by: Jan Viktorin
Suggested-by: Stephen Hemminger
---
v5 --> v5:
- Renamed patch titled from "linuxapp: eal: arm: Always return 0 for
rte_eal_iopl_init()" to curre
On Thu, Jan 21, 2016 at 3:12 PM, David Marchand
wrote:
> Santosh,
>
> On Tue, Jan 19, 2016 at 12:46 PM, Santosh Shukla
> wrote:
>> Introducing below api for pci bar space rd/wr. Currently used for
>> pci iobar rd/wr.
>>
>> Api's are:
>> - rte_e
On Thu, Jan 21, 2016 at 3:11 PM, David Marchand
wrote:
> Hello Santosh,
>
> On Tue, Jan 19, 2016 at 12:46 PM, Santosh Shukla
> wrote:
> > iopl() syscall not supported in linux-arm/arm64 so always return 0 value.
> >
> > Signed-off-by: Santosh Shukla
> > A
On Tue, Jan 19, 2016 at 7:48 PM, Burakov, Anatoly
wrote:
> Hi Santosh,
>
>> +int
>> +pci_vfio_is_noiommu(struct rte_pci_device *pci_dev) {
>> + FILE *fp;
>> + struct rte_pci_addr *loc;
>> + const char *path =
>> "/sys/module/vfio/parame
and supported interface by that arch:
ARCH IGB_UIO VFIO
x86 Y Y
ARM64 N/A Y
PPC_64 N/A Y (Not tested but likely should work, as vfio is
arch independent)
Note: Applicable for virtio spec 0.95
Signed-off-by: Santosh Shukla
---
drivers/net/virtio
If virtio interface attached to vfio-noiommu driver then
do not parse for virtio resource. Instead exit with return 0;
Note: Applicable for virtio spec 0.95.
Signed-off-by: Santosh Shukla
---
v4-->v5:
- added _NOIOMMU drv check for lagecy virtio. No need for resource_init in vfio
c
then set drv->kdrv = RTE_KDRV_VFIO_NOIOMMU
Also did similar changes in virtio_rd/wr, Changes applicable for virtio spec
0.95 only.
Signed-off-by: Santosh Shukla
---
v4--> v5:
- Removed virtio_xx_init_by_vfio and added new driver mode.
- Now no need to parse vfio interface in virtio. As pci_eal
So far virtio handle rw access for uio / ioport interface, This patch to extend
the support for vfio interface.
Applicable for virtio 0.95 spec.
Signed-off-by: Santosh Shukla
---
v4--> v5:
- Replaced virtio_rd/wr_1/2/4() macro implementation with inline function, per
Yuan review commm
For vfio case - Use pread/pwrite api to access virtio
ioport space.
Applicable for virtio 0.95 spec.
Signed-off-by: Santosh Shukla
Signed-off-by: Rizwan Ansari
Signed-off-by: Rakesh Krishnamurthy
---
v4 --> v5:
- Removed unnecessary type casting.
drivers/net/virtio/virtio_vfio_rw.h |
1 - 100 of 216 matches
Mail list logo
