Re: [EXT] Re: [PATCH v2] examples/fips_validation: fix memory leak in sha test

2022-07-04 Thread Thomas Monjalon
04/07/2022 09:50, Akhil Goyal: > > On Sat, Jul 2, 2022 at 4:59 PM Gowrishankar Muthukrishnan > > wrote: > > > > > > There is wrong size used for allocation of digest buffer which in > > > some cases cause memory corruption. Also, fixed places where memory > > > leak is observed. This fix would ena

RE: [EXT] Re: [PATCH v2] examples/fips_validation: fix memory leak in sha test

2022-07-04 Thread Gowrishankar Muthukrishnan
> vec.cipher_auth.digest.len * 8); > > + if (vec.cipher_auth.digest.val) > > + free(vec.cipher_auth.digest.val); > > Unneeded if(). > Ack. > We just did a tree-wide cleanup to avoid these. > Please don't reintroduce some. > > > > + > > +

RE: [EXT] Re: [PATCH v2] examples/fips_validation: fix memory leak in sha test

2022-07-04 Thread Akhil Goyal
> On Sat, Jul 2, 2022 at 4:59 PM Gowrishankar Muthukrishnan > wrote: > > > > There is wrong size used for allocation of digest buffer which in > > some cases cause memory corruption. Also, fixed places where memory > > leak is observed. This fix would enable sha 384 and 512 NIST vectors > > be sup