RE: [EXTERNAL] [PATCH 2/3] compress/uadk: support basic operations

2024-05-24 Thread Akhil Goyal
> > > > > > One more question, > > > rte_compressdev_pmd_init_params does not have .max_nb_queue_pairs as > > > rte_cryptodev_pmd_init_params. > > > So dpdk-test-compress-perf will use 128 queues by default, except > > > adding -l 1,2. > > > Is this expected? > > > > > rte_compressdev_pmd_init_par

Re: [EXTERNAL] [PATCH 2/3] compress/uadk: support basic operations

2024-05-24 Thread Zhangfei Gao
On Fri, 24 May 2024 at 18:20, Akhil Goyal wrote: > > > > > +static int > > > > +uadk_compress_pmd_config(struct rte_compressdev *dev, > > > > + struct rte_compressdev_config *config) > > > > +{ > > > > + char mp_name[RTE_MEMPOOL_NAMESIZE]; > > > > + struct uadk_compres

RE: [EXTERNAL] [PATCH 2/3] compress/uadk: support basic operations

2024-05-24 Thread Akhil Goyal
> > > +static int > > > +uadk_compress_pmd_config(struct rte_compressdev *dev, > > > + struct rte_compressdev_config *config) > > > +{ > > > + char mp_name[RTE_MEMPOOL_NAMESIZE]; > > > + struct uadk_compress_priv *priv; > > > + struct rte_mempool *mp; > > > + in

Re: [EXTERNAL] [PATCH 2/3] compress/uadk: support basic operations

2024-05-24 Thread Zhangfei Gao
Hi, Akhil Thanks for your time. On Thu, 23 May 2024 at 23:38, Akhil Goyal wrote: > > Hi Zhangfei, > > Overall, a well written driver. > Please see below comment. > > > +static int > > +uadk_compress_pmd_config(struct rte_compressdev *dev, > > + struct rte_compressdev_config

RE: [EXTERNAL] [PATCH 2/3] compress/uadk: support basic operations

2024-05-23 Thread Akhil Goyal
Hi Zhangfei, Overall, a well written driver. Please see below comment. > +static int > +uadk_compress_pmd_config(struct rte_compressdev *dev, > + struct rte_compressdev_config *config) > +{ > + char mp_name[RTE_MEMPOOL_NAMESIZE]; > + struct uadk_compress_priv *priv; >