RE: [EXT] Re: [PATCH] crypto/ccp: Check for the NULL pointer after calling rte_malloc

2022-08-22 Thread Namburu, Chandu-babu
[Public] + sunil -Original Message- From: Akhil Goyal Sent: Tuesday, August 16, 2022 9:31 PM To: Namburu, Chandu-babu ; 835703...@qq.com Cc: dev@dpdk.org; David Marchand Subject: RE: [EXT] Re: [PATCH] crypto/ccp: Check for the NULL pointer after calling rte_malloc Hi, Could you

RE: [EXT] Re: [PATCH] crypto/ccp: Check for the NULL pointer after calling rte_malloc

2022-08-16 Thread Akhil Goyal
Hi, Could you please reply to David and Stephen's comments? Regards, Akhil > On Wed, Jul 20, 2022 at 8:29 AM Namburu, Chandu-babu > wrote: > > From: Shiqi Liu <835703...@qq.com> > > > > As the possible failure of the rte_malloc(), the not_checked and checked > > could > be NULL pointer. > > Ther

Re: [PATCH] crypto/ccp: Check for the NULL pointer after calling rte_malloc

2022-07-20 Thread Stephen Hemminger
On Wed, 20 Jul 2022 06:29:06 + "Namburu, Chandu-babu" wrote: > sha_ctx = (void *)rte_malloc(NULL, SHA512_DIGEST_SIZE, 64); > + if (sha_ctx == NULL) { > + return -ENOMEM; > + } There is unnecessary cast here (pre-existing). rte_malloc() already returns void *

Re: [PATCH] crypto/ccp: Check for the NULL pointer after calling rte_malloc

2022-07-20 Thread David Marchand
On Wed, Jul 20, 2022 at 8:29 AM Namburu, Chandu-babu wrote: > From: Shiqi Liu <835703...@qq.com> > > As the possible failure of the rte_malloc(), the not_checked and checked > could be NULL pointer. > Therefore, it should be better to check it in order to avoid the dereference > of the NULL poin

RE: [PATCH] crypto/ccp: Check for the NULL pointer after calling rte_malloc

2022-07-19 Thread Namburu, Chandu-babu
[Public] Acked-by: Chandubabu Namburu -Original Message- From: 835703...@qq.com <835703...@qq.com> Sent: Saturday, July 9, 2022 4:31 PM To: Namburu, Chandu-babu Cc: dev@dpdk.org; Shiqi Liu <835703...@qq.com> Subject: [PATCH] crypto/ccp: Check for the NULL pointer a

[PATCH] crypto/ccp: Check for the NULL pointer after calling rte_malloc

2022-07-09 Thread 835703180
From: Shiqi Liu <835703...@qq.com> As the possible failure of the rte_malloc(), the not_checked and checked could be NULL pointer. Therefore, it should be better to check it in order to avoid the dereference of the NULL pointer. Fixes: 09a0fd736a0 ("crypto/ccp: enable IOMMU") Signed-off-by: Shiqi