11/11/2022 11:06, Juraj Linkeš:
> > >
> > > Good comment, I'll improve in v2.
> >
> > One more thing, if we go with changing the Formatting echo, then we should
> > also change the Linting echo. Or we could do it in some other place just
> > once,
> > I'm not sure which is better.
>
> I have one
> >
> > Good comment, I'll improve in v2.
>
> One more thing, if we go with changing the Formatting echo, then we should
> also change the Linting echo. Or we could do it in some other place just once,
> I'm not sure which is better.
>
I have one more request, could you add "echo 'Summary:'" bef
> -Original Message-
> From: Thomas Monjalon
> Sent: Thursday, November 10, 2022 11:26 AM
> To: Juraj Linkeš
> Cc: dev@dpdk.org; Lijuan Tu ; Owen Hilyard
>
> Subject: Re: [PATCH] devtools: set DTS directory to format check
>
> 10/11/2022 10:27, Juraj Linkeš
10/11/2022 10:27, Juraj Linkeš:
> From: Thomas Monjalon
> > usage() {
> > - echo "Run formatting and linting programs for DTS. Usage:"
> > -
> > + echo 'Usage: $(basename $0) [options] [directory]'
>
> Double quotes here, otherwise $0 won't be expanded.
I wonder how I tested it :)
> > +dir
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, November 9, 2022 6:09 PM
> To: dev@dpdk.org
> Cc: Juraj Linkeš ; Lijuan Tu
> ; Owen Hilyard
> Subject: [PATCH] devtools: set DTS directory to format check
>
> The script was running on the cur
On Wed, Nov 9, 2022 at 12:09 PM Thomas Monjalon wrote:
> The script was running on the current directory.
> If not in the DTS directory, it would re-format every Python files.
>
> A new positional argument is added to specify the directory to check.
> In most cases, the (new) default value should
The script was running on the current directory.
If not in the DTS directory, it would re-format every Python files.
A new positional argument is added to specify the directory to check.
In most cases, the (new) default value should be enough.
While updating argument handling,
the usage is printe
7 matches
Mail list logo
