Re: [PATCH] drivers: fix symbol exports when map is omitted

2022-12-01 Thread Tyler Retzlaff
On Tue, Nov 29, 2022 at 06:23:21PM +, Ferruh Yigit wrote: > On 11/29/2022 2:00 PM, David Marchand wrote: > > ld exports any global symbol by default if no version script is passed. > > As a consequence, the incriminated change let any public symbol leak > > out of the driver shared libraries. >

Re: [PATCH] drivers: fix symbol exports when map is omitted

2022-11-30 Thread Ferruh Yigit
On 11/30/2022 8:27 AM, David Marchand wrote: > On Wed, Nov 30, 2022 at 8:13 AM David Marchand > wrote: >>> I assume this will cause warnings for ABI check scripts, how can we >>> prevent the warnings? >> >> Indeed. >> >> Some options: >> - add exhaustive suppression rules in devtools/libabigail.ab

Re: [PATCH] drivers: fix symbol exports when map is omitted

2022-11-30 Thread David Marchand
On Wed, Nov 30, 2022 at 8:13 AM David Marchand wrote: > > I assume this will cause warnings for ABI check scripts, how can we > > prevent the warnings? > > Indeed. > > Some options: > - add exhaustive suppression rules in devtools/libabigail.abignore, > - retag the v22.11 release with this fix, bu

Re: [PATCH] drivers: fix symbol exports when map is omitted

2022-11-29 Thread David Marchand
On Tue, Nov 29, 2022 at 7:23 PM Ferruh Yigit wrote: > > On 11/29/2022 2:00 PM, David Marchand wrote: > > ld exports any global symbol by default if no version script is passed. > > As a consequence, the incriminated change let any public symbol leak > > out of the driver shared libraries. > > > >

Re: [PATCH] drivers: fix symbol exports when map is omitted

2022-11-29 Thread Ferruh Yigit
On 11/29/2022 2:00 PM, David Marchand wrote: > ld exports any global symbol by default if no version script is passed. > As a consequence, the incriminated change let any public symbol leak > out of the driver shared libraries. > > Hide again those symbols by providing a default map file which > u

[PATCH] drivers: fix symbol exports when map is omitted

2022-11-29 Thread David Marchand
ld exports any global symbol by default if no version script is passed. As a consequence, the incriminated change let any public symbol leak out of the driver shared libraries. Hide again those symbols by providing a default map file which unexports any global symbol using a local: * catchall stat