Re: [PATCH] eal/linux: enhanced error handling for affinity

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

Re:Re: [PATCH] eal/linux: enhanced error handling for affinity

2024-04-26 Thread Jianyue Wu
Hello, Stephen, Understand, yesterday I had added new changes to the patch, how to recall that patch? Thank you~ At 2024-04-25 23:04:46, "Stephen Hemminger" wrote: >On Thu, 25 Apr 2024 13:40:21 +0800 (CST) >吴剑跃 wrote: > >> After reviewing the code, I believe that the combinati

Re: [PATCH] eal/linux: enhanced error handling for affinity

2024-04-25 Thread Stephen Hemminger
On Thu, 25 Apr 2024 13:40:21 +0800 (CST) 吴剑跃 wrote: > After reviewing the code, I believe that the combination of the __linux__ and > _GNU_SOURCE macros effectively confirms whether the pthread_getname_np() API > can be utilized. I will proceed with adding them. Thank you~ > #if defined(__linux

Re:Re:Re: [PATCH] eal/linux: enhanced error handling for affinity

2024-04-25 Thread 吴剑跃
After reviewing the code, I believe that the combination of the __linux__ and _GNU_SOURCE macros effectively confirms whether the pthread_getname_np() API can be utilized. I will proceed with adding them. Thank you~ #if defined(__linux__) && defined(_GNU_SOURCE) 在 2024-04-25 09:08:59,"吴剑跃" 写道:

Re:Re: [PATCH] eal/linux: enhanced error handling for affinity

2024-04-25 Thread 吴剑跃
Hello, Stephen, Good day The issue is not caused by DPDK itself, but arises when the DPDK worker process attempts to set affinity to a cpuset that exceeds the limits set by the cgroup cpuset settings. Original error prints are: PANIC in rte_eal_init(): Cannot set affinity # Call

Re: [PATCH] eal/linux: enhanced error handling for affinity

2024-04-24 Thread Stephen Hemminger
On Tue, 23 Apr 2024 11:02:43 +0800 Jianyue Wu wrote: > Improve the robustness of setting thread affinity in DPDK > by adding detailed error logging. Is this an error you saw in your application or something inside DPDK? > Changes: > 1. Check the return value of pthread_setaffinity_np() and log

[PATCH] eal/linux: enhanced error handling for affinity

2024-04-24 Thread Jianyue Wu
Improve the robustness of setting thread affinity in DPDK by adding detailed error logging. Changes: 1. Check the return value of pthread_setaffinity_np() and log an error if the call fails. 2. Include the current thread name, the intended CPU set, and a detailed error message in the log. Sample

RE: [PATCH] eal/linux: enhanced error handling for affinity

2024-04-22 Thread Jianyue Wu (NSB)
dk.org' Subject: [PATCH] eal/linux: enhanced error handling for affinity Hello, Good day~ I hope this message finds you well. I am writing to submit a patch for consideration, which primarily adds enhanced error handling for affinity sets within the eal/linux of DPDK. Unfortunately, my curren

Re: [PATCH] eal/linux: enhanced error handling for affinity

2024-04-22 Thread Stephen Hemminger
On Mon, 22 Apr 2024 13:23:50 + "Jianyue Wu (NSB)" wrote: > + EAL_LOG(ERR, "Cannot set affinity for thread %s with cpus %s, " > + "ret: %d, errno: %d, error description: %s", > + thread_name, cpus_str, > + ret, errno, stre

Re: [PATCH] eal/linux: enhanced error handling for affinity

2024-04-22 Thread Stephen Hemminger
On Mon, 22 Apr 2024 13:23:50 + "Jianyue Wu (NSB)" wrote: > + char cpus_str[RTE_MAX_LCORE + 1] = {'\0'}; > + char thread_name[RTE_MAX_THREAD_NAME_LEN] = {'\0'}; > + You don't need '\0' here, just doing { } will have same effect.

Re: [PATCH] eal/linux: enhanced error handling for affinity

2024-04-22 Thread Stephen Hemminger
On Mon, 22 Apr 2024 13:23:50 + "Jianyue Wu (NSB)" wrote: > +/* Function to convert cpu_set_t to a string. */ > +static void cpuset_to_string(const cpu_set_t *cpuset, > + char *cpus_str, size_t cpus_str_size) { > + int cpu; > + // Track the current position in the s

Re: [PATCH] eal/linux: enhanced error handling for affinity

2024-04-22 Thread Ferruh Yigit
On 4/22/2024 2:23 PM, Jianyue Wu (NSB) wrote: > Hello, > >   > > Good day~ > > I hope this message finds you well. I am writing to submit a patch for > consideration, which primarily adds enhanced error handling for affinity > sets within the eal/linux of DPDK. Unfortunately, my current environm

[PATCH] eal/linux: enhanced error handling for affinity

2024-04-22 Thread Ferruh Yigit
From: Jianyue Wu Improve the robustness of setting thread affinity in DPDK by adding detailed error logging. Changes: 1. Set `errno` to 0 before calling `pthread_setaffinity_np()` to ensure clean error status. 2. Check the return value of `pthread_setaffinity_np()` and log an error if the call f

[PATCH] eal/linux: enhanced error handling for affinity

2024-04-22 Thread Jianyue Wu (NSB)
Hello, Good day~ I hope this message finds you well. I am writing to submit a patch for consideration, which primarily adds enhanced error handling for affinity sets within the eal/linux of DPDK. Unfortunately, my current environment does not support git send-email, so I am sending this patch a