Re: [PATCH] ethdev: add template table resize API

2024-02-08 Thread Etelson, Gregory
Hello Ferruh, I work on the patch update with detailed user guide for the table resize API. Regards, Gregory So, by design, driver will keep the old table when it is resized. - Can this have a performance impact, like when rules updated/removed/inserted driver will need to look more tables? -

Re: [PATCH] ethdev: add template table resize API

2024-02-08 Thread Ferruh Yigit
On 1/30/2024 6:15 PM, Etelson, Gregory wrote: > Hello Ferruh, > >> So, by design, driver will keep the old table when it is resized. >> - Can this have a performance impact, like when rules >> updated/removed/inserted driver will need to look more tables? >> - Or can this cause additional capacity

Re: [PATCH] ethdev: add template table resize API

2024-01-30 Thread Etelson, Gregory
Hello Ferruh, Template table creation API sets table flows capacity. If application needs more flows then the table was designed for, the following procedures must be completed: 1. Create a new template table with larger flows capacity. 2. Re-create existing flows in the new table and delete flo

Re: [PATCH] ethdev: add template table resize API

2024-01-30 Thread Etelson, Gregory
Hello Ferruh, So, by design, driver will keep the old table when it is resized. - Can this have a performance impact, like when rules updated/removed/inserted driver will need to look more tables? - Or can this cause additional capacity complexity, like total number of rules will be sum of rules

Re: [PATCH] ethdev: add template table resize API

2024-01-30 Thread Ferruh Yigit
On 12/17/2023 9:32 AM, Gregory Etelson wrote: > Template table creation API sets table flows capacity. > If application needs more flows then the table was designed for, > the following procedures must be completed: > 1. Create a new template table with larger flows capacity. > 2. Re-create existin

Re: [PATCH] ethdev: add template table resize API

2024-01-30 Thread Ferruh Yigit
On 1/30/2024 12:46 PM, Etelson, Gregory wrote: > Hello Ferruh, > >> >> If a multi-threaded application can add new and updated old >> simultaneously, this should be done via monolithic API, like: >> { >>  lock >>    resize >>  unlock >>  for each flow >>    lock >>    update >>    unlock >> } >> >

Re: [PATCH] ethdev: add template table resize API

2024-01-30 Thread Etelson, Gregory
Hello Ferruh, If a multi-threaded application can add new and updated old simultaneously, this should be done via monolithic API, like: { lock resize unlock for each flow lock update unlock } The flow template API was designed for performance. Application that implements the f

Re: [PATCH] ethdev: add template table resize API

2024-01-30 Thread Ferruh Yigit
On 1/29/2024 3:08 PM, Etelson, Gregory wrote: > Hello Ferruh, > >> >> Hi Gregory, Ori, >> >> Why we need three separate APIs, >> rte_flow_template_table_resize >> rte_flow_async_update_resized >> rte_flow_template_table_resize_complete >> >> Why not 'rte_flow_template_table_resize()' update existi

Re: [PATCH] ethdev: add template table resize API

2024-01-29 Thread Etelson, Gregory
Hello Ferruh, Hi Gregory, Ori, Why we need three separate APIs, rte_flow_template_table_resize rte_flow_async_update_resized rte_flow_template_table_resize_complete Why not 'rte_flow_template_table_resize()' update existing flows and release resources related to the original tables automatica

Re: [PATCH] ethdev: add template table resize API

2024-01-29 Thread Ferruh Yigit
On 12/17/2023 9:32 AM, Gregory Etelson wrote: > Template table creation API sets table flows capacity. > If application needs more flows then the table was designed for, > the following procedures must be completed: > 1. Create a new template table with larger flows capacity. > 2. Re-create existin

[PATCH] ethdev: add template table resize API

2023-12-17 Thread Gregory Etelson
Template table creation API sets table flows capacity. If application needs more flows then the table was designed for, the following procedures must be completed: 1. Create a new template table with larger flows capacity. 2. Re-create existing flows in the new table and delete flows from the or