Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-10-04 Thread Stephen Hemminger
On Thu, 25 Apr 2024 17:53:08 +0100 Ferruh Yigit wrote: > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 548fada1c7ad..40f04c0e191b 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -3136,6 +3136,9 @@ int rte_eth_stats_get(uint16_t port_id, struct

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-29 Thread Stephen Hemminger
On Mon, 29 Apr 2024 08:20:13 +0200 Morten Brørup wrote: > > turn talk the control plane, which in turn would talk to the data plane > > (including ). > > > > Either the control plane or the O&M layer could keep track of a reset > > offset. Doesn't have to be on the PMD level. > > Exactly. >

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-29 Thread Mattias Rönnblom
On 2024-04-29 09:57, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Sunday, 28 April 2024 17.49 On 2024-04-26 14:20, Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Thursday, 25 April 2024 18.53 Making 'rte_eth_stats_reset()' and 'r

RE: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-29 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Sunday, 28 April 2024 17.49 > > On 2024-04-26 14:20, Morten Brørup wrote: > >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > >> Sent: Thursday, 25 April 2024 18.53 > >> > >> Making 'rte_eth_stats_reset()' and 'rte_eth_xstats_rese

RE: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-28 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Sunday, 28 April 2024 17.53 > > On 2024-04-26 17:17, Morten Brørup wrote: > >> From: Stephen Hemminger [mailto:step...@networkplumber.org] > >> Sent: Friday, 26 April 2024 17.14 > >> > >> On Fri, 26 Apr 2024 14:20:01 +0200 > >> Morten

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-28 Thread Mattias Rönnblom
On 2024-04-26 17:17, Morten Brørup wrote: From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Friday, 26 April 2024 17.14 On Fri, 26 Apr 2024 14:20:01 +0200 Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Thursday, 25 April 2024 18.53 Making 'rte_eth

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-28 Thread Mattias Rönnblom
On 2024-04-26 14:20, Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Thursday, 25 April 2024 18.53 Making 'rte_eth_stats_reset()' and 'rte_eth_xstats_reset()' APIs thread safe has performance impact on datapath. Instead document APIs as not thread safe and add condit

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-26 Thread Stephen Hemminger
On Fri, 26 Apr 2024 17:17:25 +0200 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Friday, 26 April 2024 17.14 > > > > On Fri, 26 Apr 2024 14:20:01 +0200 > > Morten Brørup wrote: > > > > > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > >

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

RE: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-26 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 26 April 2024 17.14 > > On Fri, 26 Apr 2024 14:20:01 +0200 > Morten Brørup wrote: > > > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > > Sent: Thursday, 25 April 2024 18.53 > > > > > > Making 'rte_eth_stats_res

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-26 Thread Stephen Hemminger
On Fri, 26 Apr 2024 14:20:01 +0200 Morten Brørup wrote: > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > Sent: Thursday, 25 April 2024 18.53 > > > > Making 'rte_eth_stats_reset()' and 'rte_eth_xstats_reset()' APIs thread > > safe has performance impact on datapath. > > > > Instead docum

RE: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-26 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Thursday, 25 April 2024 18.53 > > Making 'rte_eth_stats_reset()' and 'rte_eth_xstats_reset()' APIs thread > safe has performance impact on datapath. > > Instead document APIs as not thread safe and add condition for reliable > stats reset

[PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-25 Thread Ferruh Yigit
Making 'rte_eth_stats_reset()' and 'rte_eth_xstats_reset()' APIs thread safe has performance impact on datapath. Instead document APIs as not thread safe and add condition for reliable stats reset functionality, forwarding should be stopped. Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- C