Re: [PATCH] ethdev: fix get_reg_info

2025-03-11 Thread Stephen Hemminger
On Fri, 7 Mar 2025 17:40:17 +0800 fengchengwen wrote: > I think there are ambiguities in the original API definition: > 1) the width was used as an output parameter in current all PMD impl. > 2) the offset was unused in current all PMD impl. > > But maybe other non-opensource PMD will use these

Re: [PATCH] ethdev: fix get_reg_info

2025-03-07 Thread fengchengwen
On 2025/2/18 19:58, Thierry Herbelot wrote: > 'width' and 'offset' are input parameters when dumping the register > info of an Ethernet device. They should be copied in the new request > before calling the device callback function. > > Fixes: 083db2ed9e9 ('ethdev: add report of register names and

Re: [PATCH] ethdev: fix get_reg_info

2025-03-07 Thread fengchengwen
On 2025/2/20 2:45, Stephen Hemminger wrote: > On Tue, 18 Feb 2025 12:58:28 +0100 > Thierry Herbelot wrote: > >> 'width' and 'offset' are input parameters when dumping the register >> info of an Ethernet device. They should be copied in the new request >> before calling the device callback functio

Re: [PATCH] ethdev: fix get_reg_info

2025-03-06 Thread Thomas Monjalon
19/02/2025 19:45, Stephen Hemminger: > On Tue, 18 Feb 2025 12:58:28 +0100 > Thierry Herbelot wrote: > > > 'width' and 'offset' are input parameters when dumping the register > > info of an Ethernet device. They should be copied in the new request > > before calling the device callback function. >

[PATCH] ethdev: fix get_reg_info

2025-02-18 Thread Thierry Herbelot
'width' and 'offset' are input parameters when dumping the register info of an Ethernet device. They should be copied in the new request before calling the device callback function. Fixes: 083db2ed9e9 ('ethdev: add report of register names and filter') Cc: sta...@dpdk.org Signed-off-by: Thierry H