Re: [PATCH] ethdev: optimize activation of fast-path tracepoints

2024-09-16 Thread Jerin Jacob
On Mon, Sep 16, 2024 at 2:01 PM David Marchand wrote: > > On Mon, Sep 16, 2024 at 10:26 AM Jerin Jacob wrote: > > > rte_flow_dev_dump; > > > > > > # added in 20.05 > > > - __rte_ethdev_trace_rx_burst; > > > > Removal of a public symbol breaks the ABI. The good news is that 2

Re: [PATCH] ethdev: optimize activation of fast-path tracepoints

2024-09-16 Thread David Marchand
On Mon, Sep 16, 2024 at 10:26 AM Jerin Jacob wrote: > > rte_flow_dev_dump; > > > > # added in 20.05 > > - __rte_ethdev_trace_rx_burst; > > Removal of a public symbol breaks the ABI. The good news is that 24.11 > can break the ABI. > IMO, It is OK to break this ABI. This symb

Re: [PATCH] ethdev: optimize activation of fast-path tracepoints

2024-09-16 Thread Jerin Jacob
On Sat, Sep 14, 2024 at 1:59 AM Adel Belkhiri wrote: > > From: Adel Belkhiri > > Split the tracepoints rte_ethdev_trace_rx_burst and > rte_eth_trace_call_rx_callbacks into two separate ones > for empty and non-empty calls to avoid saturating > quickly the trace buffer. > > Signed-off-by: Adel Bel

RE: [PATCH] ethdev: optimize activation of fast-path tracepoints

2024-09-13 Thread Morten Brørup
> +++ b/lib/ethdev/version.map > @@ -207,7 +207,8 @@ EXPERIMENTAL { > rte_flow_dev_dump; > > # added in 20.05 > - __rte_ethdev_trace_rx_burst; > + __rte_ethdev_trace_rx_burst_empty; > + __rte_ethdev_trace_rx_burst_nonempty; These two should be moved down below "# added in

[PATCH] ethdev: optimize activation of fast-path tracepoints

2024-09-13 Thread Adel Belkhiri
From: Adel Belkhiri Split the tracepoints rte_ethdev_trace_rx_burst and rte_eth_trace_call_rx_callbacks into two separate ones for empty and non-empty calls to avoid saturating quickly the trace buffer. Signed-off-by: Adel Belkhiri --- .mailmap | 1 + lib/ethdev/ethdev