Re: [PATCH] lib/ethdev: sanity check on callback before resource allocation

On Tue, 11 Jul 2023 01:18:09 + Kaiyu Zhang wrote: > sanity check is performed after a rte_eth_dev object is allocated. > The object is not freed if the check fails, though in the current > reality this never happens, but it's better programming paradigm > to move the quick check up front to t

Re: [PATCH] lib/ethdev: sanity check on callback before resource allocation

On 7/11/2023 2:48 AM, fengchengwen wrote: > On 2023/7/11 9:18, Kaiyu Zhang wrote: >> sanity check is performed after a rte_eth_dev object is allocated. >> The object is not freed if the check fails, though in the current >> reality this never happens, but it's better programming paradigm >> to mov

Re: [PATCH] lib/ethdev: sanity check on callback before resource allocation

Please add Cc. Reviewed-by: Chengwen Feng On 2023/7/11 9:18, Kaiyu Zhang wrote: > sanity check is performed after a rte_eth_dev object is allocated. > The object is not freed if the check fails, though in the current > reality this never happens, but it's better programming paradigm > to move the

[PATCH] lib/ethdev: sanity check on callback before resource allocation

sanity check is performed after a rte_eth_dev object is allocated. The object is not freed if the check fails, though in the current reality this never happens, but it's better programming paradigm to move the quick check up front to the start of rte_eth_dev_pci_generic_probe. Signed-off-by: Kaiyu