Re: [PATCH] net/gve: Enable stats reporting for GQ format

Those are fair points. I'll fix this by simply calling gve_get_imissed_from_nic from gve_xstats_get in the v3 patch. On Wed, Jan 17, 2024 at 3:10 PM Ferruh Yigit wrote: > On 1/16/2024 6:18 AM, Rushil Gupta wrote: > > > > > > On Fri, Jan 12, 2024 at 8:36 PM Ferruh Yigit >

Re: [PATCH] net/gve: Enable stats reporting for GQ format

On 1/16/2024 6:18 AM, Rushil Gupta wrote: > > > On Fri, Jan 12, 2024 at 8:36 PM Ferruh Yigit > wrote: > > On 12/22/2023 3:39 PM, Rushil Gupta wrote: > > Read from shared region to retrieve imissed statistics for GQ from > device. > > Tested using `sh

Re: [PATCH] net/gve: Enable stats reporting for GQ format

> > >> <...> >> >> > gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) >> > { >> > uint16_t i; >> > + if (gve_is_gqi(dev->data->dev_private)) >> > + gve_get_imissed_from_nic(dev); >> > >> >> This updates imissed in RxQ struct for all queues for basic st

Re: [PATCH] net/gve: Enable stats reporting for GQ format

On Fri, Jan 12, 2024 at 8:36 PM Ferruh Yigit wrote: > On 12/22/2023 3:39 PM, Rushil Gupta wrote: > > Read from shared region to retrieve imissed statistics for GQ from > device. > > Tested using `show port xstats ` in interactive mode. > > This metric can be triggered by using queues > cores. > >

Re: [PATCH] net/gve: Enable stats reporting for GQ format

On 12/22/2023 3:39 PM, Rushil Gupta wrote: > Read from shared region to retrieve imissed statistics for GQ from device. > Tested using `show port xstats ` in interactive mode. > This metric can be triggered by using queues > cores. > Looks good but please check following comments: Checkpatch giv

[PATCH] net/gve: Enable stats reporting for GQ format

Read from shared region to retrieve imissed statistics for GQ from device. Tested using `show port xstats ` in interactive mode. This metric can be triggered by using queues > cores. Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington --- drivers/net/gve/base/gve_adminq.h | 11 driv

[PATCH] net/gve: Enable stats reporting for GQ format

Read from shared region to retrieve imissed statistics for GQ from device. Tested using `show port xstats ` in interactive mode. This metric can be triggered by using queues > cores. Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington --- drivers/net/gve/base/gve_adminq.h | 11 driv

[PATCH] net/gve: Enable stats reporting for GQ format

Read from shared region to retrieve imissed statistics for GQ from device. Tested using `show port xstats ` in interactive mode. This metric can be triggered by using queues > cores. --- drivers/net/gve/base/gve_adminq.h | 11 +++ drivers/net/gve/gve_ethdev.c | 117 ++

[PATCH] net/gve: Enable stats reporting for GQ format

Read from shared region to retrieve imissed statistics for GQ. Tested using `show port xstats ` in interactive mode. This metric can be triggered by using queues > cores. Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington --- drivers/net/gve/base/gve_adminq.h | 11 +++ drivers/net/gve/

RE: [PATCH] net/gve: Enable stats reporting for GQ format

> -Original Message- > From: Rushil Gupta > Sent: Tuesday, December 19, 2023 10:17 > To: Guo, Junfeng ; jeroe...@google.com; > joshw...@google.com; ferruh.yi...@amd.com > Cc: dev@dpdk.org; Rushil Gupta > Subject: [PATCH] net/gve: Enable stats reporting for GQ

[PATCH] net/gve: Enable stats reporting for GQ format

Read from shared region to retrieve imissed statistics for GQ. Tested using `show port xstats ` in interactive mode. This metric can be triggered by using queues > cores. Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington --- drivers/net/gve/base/gve_adminq.h | 11 drivers/net/gve/

[PATCH] net/gve: Enable stats reporting for GQ format

Read from shared region to retrieve imissed statistics for GQ. Tested using `show port xstats ` in interactive mode. This metric can be triggered by using queues > cores. Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington --- drivers/net/gve/base/gve_adminq.h | 11 drivers/net/gve/