Re: [PATCH] net/mlx5: avoid setting kernel MTU if not needed

2025-06-10 Thread Raslan Darawsheh
Hi, On 28/05/2025 12:36 PM, Maxime Coquelin wrote: This patch checks whether the Kernel MTU has the same value as the requested one at port configuration time, and skip setting it if it is the same. Doing this, we can avoid the application to require NET_ADMIN capability, as in v23.11. Fixes:

Re: [PATCH] net/mlx5: avoid setting kernel MTU if not needed

2025-06-04 Thread David Marchand
On Tue, Jun 3, 2025 at 7:54 PM Dariusz Sosnowski wrote: > > Atm, I don't see the need for keeping such a cached mtu value in priv. > > There is only one user of the value, and it is for configuration > > operation that can do a query to the kernel. > > I agree. It's not really needed, especially s

Re: [PATCH] net/mlx5: avoid setting kernel MTU if not needed

2025-06-04 Thread Dariusz Sosnowski
Hi Maxime, On Tue, Jun 03, 2025 at 07:56:11PM +0200, Dariusz Sosnowski wrote: > On Tue, Jun 03, 2025 at 07:53:45PM +0200, Dariusz Sosnowski wrote: > > Hi, > > > > On Wed, May 28, 2025 at 02:12:37PM +0200, David Marchand wrote: > > > Hello, > > > > > > On Wed, May 28, 2025 at 11:36 AM Maxime Coqu

Re: [PATCH] net/mlx5: avoid setting kernel MTU if not needed

2025-06-03 Thread Dariusz Sosnowski
On Tue, Jun 03, 2025 at 07:53:45PM +0200, Dariusz Sosnowski wrote: > Hi, > > On Wed, May 28, 2025 at 02:12:37PM +0200, David Marchand wrote: > > Hello, > > > > On Wed, May 28, 2025 at 11:36 AM Maxime Coquelin > > wrote: > > > > > > This patch checks whether the Kernel MTU has the same value > >

Re: [PATCH] net/mlx5: avoid setting kernel MTU if not needed

2025-06-03 Thread Dariusz Sosnowski
Hi, On Wed, May 28, 2025 at 02:12:37PM +0200, David Marchand wrote: > Hello, > > On Wed, May 28, 2025 at 11:36 AM Maxime Coquelin > wrote: > > > > This patch checks whether the Kernel MTU has the same value > > as the requested one at port configuration time, and skip > > setting it if it is the

Re: [PATCH] net/mlx5: avoid setting kernel MTU if not needed

2025-05-28 Thread David Marchand
Hello, On Wed, May 28, 2025 at 11:36 AM Maxime Coquelin wrote: > > This patch checks whether the Kernel MTU has the same value > as the requested one at port configuration time, and skip > setting it if it is the same. > > Doing this, we can avoid the application to require > NET_ADMIN capability

[PATCH] net/mlx5: avoid setting kernel MTU if not needed

2025-05-28 Thread Maxime Coquelin
This patch checks whether the Kernel MTU has the same value as the requested one at port configuration time, and skip setting it if it is the same. Doing this, we can avoid the application to require NET_ADMIN capability, as in v23.11. Fixes: 10859ecf09c4 ("net/mlx5: fix MTU configuration") Cc: s