Re: [PATCH] net/nfp: improve readability NFP HWINFO header

2022-09-21 Thread Ferruh Yigit
On 8/26/2022 6:39 AM, Chaoyong He wrote: From: James Hershaw Prepend `0x` to the NFP HWINFO header value that is printed to improve the readability of the printed statement. Signed-off-by: James Hershaw Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund Fixes: c7e9729da6b5 ("net/n

Re: [PATCH] net/nfp: improve readability NFP HWINFO header

2022-09-21 Thread Ferruh Yigit
On 9/21/2022 8:19 AM, Niklas Söderlund wrote: Hello Ferruh, On 2022-09-20 19:01:47 +0100, Ferruh Yigit wrote: Instead of changing the log content and API with same patch, it is better to have them separate. I agree. I prefer to convert them to proper log API first, and later fix the conten

Re: [PATCH] net/nfp: improve readability NFP HWINFO header

2022-09-21 Thread Niklas Söderlund
Hello Ferruh, On 2022-09-20 19:01:47 +0100, Ferruh Yigit wrote: > Instead of changing the log content and API with same patch, it is > better to have them separate. I agree. > > I prefer to convert them to proper log API first, and later fix the content > of the log (to not update a line with

Re: [PATCH] net/nfp: improve readability NFP HWINFO header

2022-09-20 Thread Ferruh Yigit
On 9/20/2022 6:51 PM, Niklas Söderlund wrote: Hi Ferruh, Thanks for your feedback. On 2022-09-20 18:33:02 +0100, Ferruh Yigit wrote: On 8/26/2022 6:39 AM, Chaoyong He wrote: From: James Hershaw Prepend `0x` to the NFP HWINFO header value that is printed to improve the readability of the pri

Re: [PATCH] net/nfp: improve readability NFP HWINFO header

2022-09-20 Thread Niklas Söderlund
Hi Ferruh, Thanks for your feedback. On 2022-09-20 18:33:02 +0100, Ferruh Yigit wrote: > On 8/26/2022 6:39 AM, Chaoyong He wrote: > > From: James Hershaw > > > > Prepend `0x` to the NFP HWINFO header value that is printed to improve > > the readability of the printed statement. > > > > Signed-

Re: [PATCH] net/nfp: improve readability NFP HWINFO header

2022-09-20 Thread Ferruh Yigit
On 8/26/2022 6:39 AM, Chaoyong He wrote: From: James Hershaw Prepend `0x` to the NFP HWINFO header value that is printed to improve the readability of the printed statement. Signed-off-by: James Hershaw Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfpcore/nfp

Re: [PATCH] net/nfp: improve readability NFP HWINFO header

2022-09-20 Thread Niklas Söderlund
Hi all, Gentle ping. On 2022-08-26 13:39:03 +0800, Chaoyong He wrote: > From: James Hershaw > > Prepend `0x` to the NFP HWINFO header value that is printed to improve > the readability of the printed statement. > > Signed-off-by: James Hershaw > Reviewed-by: Chaoyong He > Reviewed-by: Niklas

[PATCH] net/nfp: improve readability NFP HWINFO header

2022-08-25 Thread Chaoyong He
From: James Hershaw Prepend `0x` to the NFP HWINFO header value that is printed to improve the readability of the printed statement. Signed-off-by: James Hershaw Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfpcore/nfp_hwinfo.c | 2 +- 1 file changed, 1 insertio