Re: [PATCH] net: add bit fields to IPv6 header definition

2024-06-18 Thread Etelson, Gregory
Hello, The mbuf structure [1] has __extension__ here, i.e. preceding the structure following the integer field, instead of preceding the union. [1]: https://git.dpdk.org/dpdk/tree/lib/mbuf/rte_mbuf_core.h#n520 +1 anonymous unions are standard C so __extension__ is not necessary, it is necessa

Re: [PATCH] net: add bit fields to IPv6 header definition

2024-06-18 Thread Tyler Retzlaff
On Tue, Jun 18, 2024 at 08:42:53AM +0200, Morten Brørup wrote: > > From: Gregory Etelson [mailto:getel...@nvidia.com] > > Sent: Tuesday, 18 June 2024 07.18 > > > > DPDK IPv6 header definition combined the `version`, `traffic class` > > and `flow label` header fields into a single 32 bits structure

RE: [PATCH] net: add bit fields to IPv6 header definition

2024-06-18 Thread Etelson, Gregory
Hello, I've posted v2 patch with fixes. Regards, Gregory

RE: [PATCH] net: add bit fields to IPv6 header definition

2024-06-18 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > > > From: Gregory Etelson [mailto:getel...@nvidia.com] > > Sent: Tuesday, 18 June 2024 07.18 > > > > DPDK IPv6 header definition combined the `version`, `traffic class` > > and `flow label` header fields into a single 32 bits structure me

RE: [PATCH] net: add bit fields to IPv6 header definition

2024-06-17 Thread Morten Brørup
> From: Gregory Etelson [mailto:getel...@nvidia.com] > Sent: Tuesday, 18 June 2024 07.18 > > DPDK IPv6 header definition combined the `version`, `traffic class` > and `flow label` header fields into a single 32 bits structure member > `vtc_flow`. > > The patch expands IPv6 header definition with

[PATCH] net: add bit fields to IPv6 header definition

2024-06-17 Thread Gregory Etelson
DPDK IPv6 header definition combined the `version`, `traffic class` and `flow label` header fields into a single 32 bits structure member `vtc_flow`. The patch expands IPv6 header definition with dedicated structure members for the `version`, `traffic class` and `flow label` fields. The patch also